Review Request 118197: Fix regression in NETRootInfo::sendPing
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118197/ --- Review request for KDE Frameworks, kwin and Eike Hein. Bugs: 335024 https://bugs.kde.org/show_bug.cgi?id=335024 Repository: kwindowsystem Description --- Fix regression in NETRootInfo::sendPing Client message for _NET_WM_PING has a message_type of WM_PROTOCOLS. BUG: 335024 Diffs - src/netwm.cpp a4186d6d7beca67361a2ba6fa6fd9723296eaef9 Diff: https://git.reviewboard.kde.org/r/118197/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 118197: Fix regression in NETRootInfo::sendPing
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118197/#review58132 --- Ship it! Fix tested and confirmed. - Eike Hein On May 19, 2014, 7:52 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118197/ --- (Updated May 19, 2014, 7:52 a.m.) Review request for KDE Frameworks, kwin and Eike Hein. Bugs: 335024 https://bugs.kde.org/show_bug.cgi?id=335024 Repository: kwindowsystem Description --- Fix regression in NETRootInfo::sendPing Client message for _NET_WM_PING has a message_type of WM_PROTOCOLS. BUG: 335024 Diffs - src/netwm.cpp a4186d6d7beca67361a2ba6fa6fd9723296eaef9 Diff: https://git.reviewboard.kde.org/r/118197/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 118197: Fix regression in NETRootInfo::sendPing
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118197/#review58151 --- Ship it! ... and is the only theoretically correct procedure as well. - Thomas Lübking On May 19, 2014, 7:52 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118197/ --- (Updated May 19, 2014, 7:52 a.m.) Review request for KDE Frameworks, kwin and Eike Hein. Bugs: 335024 https://bugs.kde.org/show_bug.cgi?id=335024 Repository: kwindowsystem Description --- Fix regression in NETRootInfo::sendPing Client message for _NET_WM_PING has a message_type of WM_PROTOCOLS. BUG: 335024 Diffs - src/netwm.cpp a4186d6d7beca67361a2ba6fa6fd9723296eaef9 Diff: https://git.reviewboard.kde.org/r/118197/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 118197: Fix regression in NETRootInfo::sendPing
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118197/ --- (Updated May 20, 2014, 5:27 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, kwin and Eike Hein. Bugs: 335024 https://bugs.kde.org/show_bug.cgi?id=335024 Repository: kwindowsystem Description --- Fix regression in NETRootInfo::sendPing Client message for _NET_WM_PING has a message_type of WM_PROTOCOLS. BUG: 335024 Diffs - src/netwm.cpp a4186d6d7beca67361a2ba6fa6fd9723296eaef9 Diff: https://git.reviewboard.kde.org/r/118197/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 118197: Fix regression in NETRootInfo::sendPing
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118197/#review58184 --- This review has been submitted with commit eb4f296767e5b3f17a4b9f8db33acc66581e3fe3 by Martin Gräßlin to branch master. - Commit Hook On May 19, 2014, 7:52 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118197/ --- (Updated May 19, 2014, 7:52 a.m.) Review request for KDE Frameworks, kwin and Eike Hein. Bugs: 335024 https://bugs.kde.org/show_bug.cgi?id=335024 Repository: kwindowsystem Description --- Fix regression in NETRootInfo::sendPing Client message for _NET_WM_PING has a message_type of WM_PROTOCOLS. BUG: 335024 Diffs - src/netwm.cpp a4186d6d7beca67361a2ba6fa6fd9723296eaef9 Diff: https://git.reviewboard.kde.org/r/118197/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
