Re: Review Request 120092: Turn KFormat into Q_GADGET and expose DurationFormat
On Sept. 7, 2014, 1:48 nachm., David Edmundson wrote: I've just added kdeframeworks to the review group in case they have comments. Meh. Q_GADGET expands to add a static const QMetaObject staticMetaObject and that's a BIC, right? - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120092/#review65987 --- On Sept. 7, 2014, 1:49 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120092/ --- (Updated Sept. 7, 2014, 1:49 nachm.) Review request for KDE Frameworks and Plasma. Repository: kcoreaddons Description --- Thanks to the awesome David, I discovered Q_GADGET and it allows us to expose the Duration stuff in KDeclarative without needing to turn it into a QObject Diffs - src/lib/util/kformat.h 7a6a418 src/lib/util/kformat.cpp d62240e Diff: https://git.reviewboard.kde.org/r/120092/diff/ Testing --- Works. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120092: Turn KFormat into Q_GADGET and expose DurationFormat
On Sept. 7, 2014, 1:48 p.m., David Edmundson wrote: I've just added kdeframeworks to the review group in case they have comments. Kai Uwe Broulik wrote: Meh. Q_GADGET expands to add a static const QMetaObject staticMetaObject and that's a BIC, right? https://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C++#The_Do.27s_and_Don.27ts You can: - add new static data members. Kevin Krammer (new Frameworks maintainer \o/) says it's fine. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120092/#review65987 --- On Sept. 7, 2014, 1:49 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120092/ --- (Updated Sept. 7, 2014, 1:49 p.m.) Review request for KDE Frameworks and Plasma. Repository: kcoreaddons Description --- Thanks to the awesome David, I discovered Q_GADGET and it allows us to expose the Duration stuff in KDeclarative without needing to turn it into a QObject Diffs - src/lib/util/kformat.h 7a6a418 src/lib/util/kformat.cpp d62240e Diff: https://git.reviewboard.kde.org/r/120092/diff/ Testing --- Works. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120092: Turn KFormat into Q_GADGET and expose DurationFormat
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120092/ --- (Updated Sept. 9, 2014, 3:50 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Plasma. Repository: kcoreaddons Description --- Thanks to the awesome David, I discovered Q_GADGET and it allows us to expose the Duration stuff in KDeclarative without needing to turn it into a QObject Diffs - src/lib/util/kformat.h 7a6a418 src/lib/util/kformat.cpp d62240e Diff: https://git.reviewboard.kde.org/r/120092/diff/ Testing --- Works. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120092: Turn KFormat into Q_GADGET and expose DurationFormat
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120092/ --- (Updated Sept. 7, 2014, 1:49 p.m.) Review request for KDE Frameworks and Plasma. Repository: kcoreaddons Description --- Thanks to the awesome David, I discovered Q_GADGET and it allows us to expose the Duration stuff in KDeclarative without needing to turn it into a QObject Diffs - src/lib/util/kformat.h 7a6a418 src/lib/util/kformat.cpp d62240e Diff: https://git.reviewboard.kde.org/r/120092/diff/ Testing --- Works. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
