Re: Review Request 120196: Find-Module to detect libgit2
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/#review66567 --- Shouldn't it be called FindLibGit2? Git2 and LibGit2 seem different things to me. - Aleix Pol Gonzalez On Sept. 14, 2014, 10:19 a.m., Christoph Cullmann wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/ --- (Updated Sept. 14, 2014, 10:19 a.m.) Review request for KDE Frameworks and Alex Merry. Repository: extra-cmake-modules Description --- Add a find module that allows to detect libgit2. Will be used by KTextEditor Kate. Will remove the copy in KTextEditor after this is merged. Diffs - docs/find-module/FindGIT2.rst PRE-CREATION find-modules/FindGIT2.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120196/diff/ Testing --- Tested with KTextEditor, version detection is here important, as libgit2 did change API a lot, seems to work on Linux, hope it works on Windows, too. Thanks, Christoph Cullmann ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120196: Find-Module to detect libgit2
On Sept. 15, 2014, 3:15 p.m., Aleix Pol Gonzalez wrote: Shouldn't it be called FindLibGit2? Git2 and LibGit2 seem different things to me. I can rename it, but then it is inconsistent with most other FindXXX.cmake's, as they skip the lib prefix. - Christoph --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/#review66567 --- On Sept. 14, 2014, 10:19 a.m., Christoph Cullmann wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/ --- (Updated Sept. 14, 2014, 10:19 a.m.) Review request for KDE Frameworks and Alex Merry. Repository: extra-cmake-modules Description --- Add a find module that allows to detect libgit2. Will be used by KTextEditor Kate. Will remove the copy in KTextEditor after this is merged. Diffs - docs/find-module/FindGIT2.rst PRE-CREATION find-modules/FindGIT2.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120196/diff/ Testing --- Tested with KTextEditor, version detection is here important, as libgit2 did change API a lot, seems to work on Linux, hope it works on Windows, too. Thanks, Christoph Cullmann ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120196: Find-Module to detect libgit2
On Sept. 15, 2014, 3:15 p.m., Aleix Pol Gonzalez wrote: Shouldn't it be called FindLibGit2? Git2 and LibGit2 seem different things to me. Christoph Cullmann wrote: I can rename it, but then it is inconsistent with most other FindXXX.cmake's, as they skip the lib prefix. I'm unsure it's inconsistent. The project is actually called libgit2, because it's a library that does git things: https://libgit2.github.com/ As an example, here's archlinux: https://www.archlinux.org/packages/extra/i686/git/ https://www.archlinux.org/packages/community/x86_64/libgit2/ And in general, archlinux doesn't prefix the lib for frameworks anyway: https://www.archlinux.org/packages/extra/x86_64/kcoreaddons/ Does that make sense? :) - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/#review66567 --- On Sept. 14, 2014, 10:19 a.m., Christoph Cullmann wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/ --- (Updated Sept. 14, 2014, 10:19 a.m.) Review request for KDE Frameworks and Alex Merry. Repository: extra-cmake-modules Description --- Add a find module that allows to detect libgit2. Will be used by KTextEditor Kate. Will remove the copy in KTextEditor after this is merged. Diffs - docs/find-module/FindGIT2.rst PRE-CREATION find-modules/FindGIT2.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120196/diff/ Testing --- Tested with KTextEditor, version detection is here important, as libgit2 did change API a lot, seems to work on Linux, hope it works on Windows, too. Thanks, Christoph Cullmann ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120196: Find-Module to detect libgit2
On Sept. 15, 2014, 3:15 p.m., Aleix Pol Gonzalez wrote: Shouldn't it be called FindLibGit2? Git2 and LibGit2 seem different things to me. Christoph Cullmann wrote: I can rename it, but then it is inconsistent with most other FindXXX.cmake's, as they skip the lib prefix. Aleix Pol Gonzalez wrote: I'm unsure it's inconsistent. The project is actually called libgit2, because it's a library that does git things: https://libgit2.github.com/ As an example, here's archlinux: https://www.archlinux.org/packages/extra/i686/git/ https://www.archlinux.org/packages/community/x86_64/libgit2/ And in general, archlinux doesn't prefix the lib for frameworks anyway: https://www.archlinux.org/packages/extra/x86_64/kcoreaddons/ Does that make sense? :) Ok, that seems to be reasonable, will change that, if Alex is ok with that, too ;=) Other remarks? - Christoph --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/#review66567 --- On Sept. 14, 2014, 10:19 a.m., Christoph Cullmann wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/ --- (Updated Sept. 14, 2014, 10:19 a.m.) Review request for KDE Frameworks and Alex Merry. Repository: extra-cmake-modules Description --- Add a find module that allows to detect libgit2. Will be used by KTextEditor Kate. Will remove the copy in KTextEditor after this is merged. Diffs - docs/find-module/FindGIT2.rst PRE-CREATION find-modules/FindGIT2.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120196/diff/ Testing --- Tested with KTextEditor, version detection is here important, as libgit2 did change API a lot, seems to work on Linux, hope it works on Windows, too. Thanks, Christoph Cullmann ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120196: Find-Module to detect libgit2
On Sept. 15, 2014, 3:15 p.m., Aleix Pol Gonzalez wrote: Shouldn't it be called FindLibGit2? Git2 and LibGit2 seem different things to me. Christoph Cullmann wrote: I can rename it, but then it is inconsistent with most other FindXXX.cmake's, as they skip the lib prefix. Aleix Pol Gonzalez wrote: I'm unsure it's inconsistent. The project is actually called libgit2, because it's a library that does git things: https://libgit2.github.com/ As an example, here's archlinux: https://www.archlinux.org/packages/extra/i686/git/ https://www.archlinux.org/packages/community/x86_64/libgit2/ And in general, archlinux doesn't prefix the lib for frameworks anyway: https://www.archlinux.org/packages/extra/x86_64/kcoreaddons/ Does that make sense? :) Christoph Cullmann wrote: Ok, that seems to be reasonable, will change that, if Alex is ok with that, too ;=) Other remarks? Btw., that rename would imply that the vars are LIBGIT2_... and the Target would be LibGit2::LibGit2, or? - Christoph --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/#review66567 --- On Sept. 14, 2014, 10:19 a.m., Christoph Cullmann wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/ --- (Updated Sept. 14, 2014, 10:19 a.m.) Review request for KDE Frameworks and Alex Merry. Repository: extra-cmake-modules Description --- Add a find module that allows to detect libgit2. Will be used by KTextEditor Kate. Will remove the copy in KTextEditor after this is merged. Diffs - docs/find-module/FindGIT2.rst PRE-CREATION find-modules/FindGIT2.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120196/diff/ Testing --- Tested with KTextEditor, version detection is here important, as libgit2 did change API a lot, seems to work on Linux, hope it works on Windows, too. Thanks, Christoph Cullmann ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120196: Find-Module to detect libgit2
On Sept. 15, 2014, 3:15 p.m., Aleix Pol Gonzalez wrote: Shouldn't it be called FindLibGit2? Git2 and LibGit2 seem different things to me. Christoph Cullmann wrote: I can rename it, but then it is inconsistent with most other FindXXX.cmake's, as they skip the lib prefix. Aleix Pol Gonzalez wrote: I'm unsure it's inconsistent. The project is actually called libgit2, because it's a library that does git things: https://libgit2.github.com/ As an example, here's archlinux: https://www.archlinux.org/packages/extra/i686/git/ https://www.archlinux.org/packages/community/x86_64/libgit2/ And in general, archlinux doesn't prefix the lib for frameworks anyway: https://www.archlinux.org/packages/extra/x86_64/kcoreaddons/ Does that make sense? :) Christoph Cullmann wrote: Ok, that seems to be reasonable, will change that, if Alex is ok with that, too ;=) Other remarks? Christoph Cullmann wrote: Btw., that rename would imply that the vars are LIBGIT2_... and the Target would be LibGit2::LibGit2, or? Yes, +1 to that. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/#review66567 --- On Sept. 14, 2014, 10:19 a.m., Christoph Cullmann wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/ --- (Updated Sept. 14, 2014, 10:19 a.m.) Review request for KDE Frameworks and Alex Merry. Repository: extra-cmake-modules Description --- Add a find module that allows to detect libgit2. Will be used by KTextEditor Kate. Will remove the copy in KTextEditor after this is merged. Diffs - docs/find-module/FindGIT2.rst PRE-CREATION find-modules/FindGIT2.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120196/diff/ Testing --- Tested with KTextEditor, version detection is here important, as libgit2 did change API a lot, seems to work on Linux, hope it works on Windows, too. Thanks, Christoph Cullmann ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120196: Find-Module to detect libgit2
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/ --- (Updated Sept. 15, 2014, 6:30 p.m.) Review request for KDE Frameworks and Alex Merry. Changes --- Rename to FindLibGit2 Repository: extra-cmake-modules Description --- Add a find module that allows to detect libgit2. Will be used by KTextEditor Kate. Will remove the copy in KTextEditor after this is merged. Diffs (updated) - docs/find-module/FindLibGit2.rst PRE-CREATION find-modules/FindLibGit2.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120196/diff/ Testing --- Tested with KTextEditor, version detection is here important, as libgit2 did change API a lot, seems to work on Linux, hope it works on Windows, too. Thanks, Christoph Cullmann ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120196: Find-Module to detect libgit2
On Sept. 15, 2014, 3:15 p.m., Aleix Pol Gonzalez wrote: Shouldn't it be called FindLibGit2? Git2 and LibGit2 seem different things to me. Christoph Cullmann wrote: I can rename it, but then it is inconsistent with most other FindXXX.cmake's, as they skip the lib prefix. Aleix Pol Gonzalez wrote: I'm unsure it's inconsistent. The project is actually called libgit2, because it's a library that does git things: https://libgit2.github.com/ As an example, here's archlinux: https://www.archlinux.org/packages/extra/i686/git/ https://www.archlinux.org/packages/community/x86_64/libgit2/ And in general, archlinux doesn't prefix the lib for frameworks anyway: https://www.archlinux.org/packages/extra/x86_64/kcoreaddons/ Does that make sense? :) Christoph Cullmann wrote: Ok, that seems to be reasonable, will change that, if Alex is ok with that, too ;=) Other remarks? Christoph Cullmann wrote: Btw., that rename would imply that the vars are LIBGIT2_... and the Target would be LibGit2::LibGit2, or? Aleix Pol Gonzalez wrote: Yes, +1 to that. Renamed, its ok? Need to retest it again, but in principle should work. - Christoph --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/#review66567 --- On Sept. 15, 2014, 6:30 p.m., Christoph Cullmann wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/ --- (Updated Sept. 15, 2014, 6:30 p.m.) Review request for KDE Frameworks and Alex Merry. Repository: extra-cmake-modules Description --- Add a find module that allows to detect libgit2. Will be used by KTextEditor Kate. Will remove the copy in KTextEditor after this is merged. Diffs - docs/find-module/FindLibGit2.rst PRE-CREATION find-modules/FindLibGit2.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120196/diff/ Testing --- Tested with KTextEditor, version detection is here important, as libgit2 did change API a lot, seems to work on Linux, hope it works on Windows, too. Thanks, Christoph Cullmann ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120196: Find-Module to detect libgit2
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/#review66593 --- Yep, I think the name change is sensible. find-modules/FindLibGit2.cmake https://git.reviewboard.kde.org/r/120196/#comment46410 Whitespace find-modules/FindLibGit2.cmake https://git.reviewboard.kde.org/r/120196/#comment46413 Remove this comment (I know it's in other modules, but the comment isn't really true, especially once you remove VERSION_STRING). find-modules/FindLibGit2.cmake https://git.reviewboard.kde.org/r/120196/#comment46412 Don't need this one in a completely new module. - Alex Merry On Sept. 15, 2014, 6:30 p.m., Christoph Cullmann wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/ --- (Updated Sept. 15, 2014, 6:30 p.m.) Review request for KDE Frameworks and Alex Merry. Repository: extra-cmake-modules Description --- Add a find module that allows to detect libgit2. Will be used by KTextEditor Kate. Will remove the copy in KTextEditor after this is merged. Diffs - docs/find-module/FindLibGit2.rst PRE-CREATION find-modules/FindLibGit2.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120196/diff/ Testing --- Tested with KTextEditor, version detection is here important, as libgit2 did change API a lot, seems to work on Linux, hope it works on Windows, too. Thanks, Christoph Cullmann ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120196: Find-Module to detect libgit2
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/ --- (Updated Sept. 15, 2014, 6:56 p.m.) Review request for KDE Frameworks and Alex Merry. Changes --- Fixed stuff in comments ;) Repository: extra-cmake-modules Description --- Add a find module that allows to detect libgit2. Will be used by KTextEditor Kate. Will remove the copy in KTextEditor after this is merged. Diffs (updated) - docs/find-module/FindLibGit2.rst PRE-CREATION find-modules/FindLibGit2.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120196/diff/ Testing --- Tested with KTextEditor, version detection is here important, as libgit2 did change API a lot, seems to work on Linux, hope it works on Windows, too. Thanks, Christoph Cullmann ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120196: Find-Module to detect libgit2
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/#review66594 --- Ship it! Ship It! - Alex Merry On Sept. 15, 2014, 6:56 p.m., Christoph Cullmann wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/ --- (Updated Sept. 15, 2014, 6:56 p.m.) Review request for KDE Frameworks and Alex Merry. Repository: extra-cmake-modules Description --- Add a find module that allows to detect libgit2. Will be used by KTextEditor Kate. Will remove the copy in KTextEditor after this is merged. Diffs - docs/find-module/FindLibGit2.rst PRE-CREATION find-modules/FindLibGit2.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120196/diff/ Testing --- Tested with KTextEditor, version detection is here important, as libgit2 did change API a lot, seems to work on Linux, hope it works on Windows, too. Thanks, Christoph Cullmann ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120196: Find-Module to detect libgit2
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/ --- (Updated Sept. 15, 2014, 7:11 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Alex Merry. Repository: extra-cmake-modules Description --- Add a find module that allows to detect libgit2. Will be used by KTextEditor Kate. Will remove the copy in KTextEditor after this is merged. Diffs - docs/find-module/FindLibGit2.rst PRE-CREATION find-modules/FindLibGit2.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120196/diff/ Testing --- Tested with KTextEditor, version detection is here important, as libgit2 did change API a lot, seems to work on Linux, hope it works on Windows, too. Thanks, Christoph Cullmann ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 120196: Find-Module to detect libgit2
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/ --- Review request for KDE Frameworks and Alex Merry. Repository: extra-cmake-modules Description --- Add a find module that allows to detect libgit2. Will be used by KTextEditor Kate. Will remove the copy in KTextEditor after this is merged. Diffs - docs/find-module/FindGIT2.rst PRE-CREATION find-modules/FindGIT2.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120196/diff/ Testing --- Tested with KTextEditor, version detection is here important, as libgit2 did change API a lot, seems to work on Linux, hope it works on Windows, too. Thanks, Christoph Cullmann ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
