Re: Review Request 120648: Encode the URIs which end up in DTD files
On April 3, 2015, 5:58 p.m., Andrius da Costa Ribas wrote:
cmake/uriencode.cmake, line 15
https://git.reviewboard.kde.org/r/120648/diff/2/?file=320784#file320784line15
I've tried changing this to:
execute_process(COMMAND perl -MURI::Escape -e print
uri_escape_utf8(\${escaped_uri}\, \^A-Za-z0-9\\-\\._~\\/:\);
(...)
it works here, but I'm not sure if it'd be the proper fix.
Patrick von Reth wrote:
ah that whas the error, thanks I finally can compile kdoctools (atleast
locally ) again
Has this already been committed, or should this RR still considered to be
re-opened?
- Marko
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120648/#review78445
---
On Feb. 28, 2015, 11:02 p.m., Luigi Toscano wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120648/
---
(Updated Feb. 28, 2015, 11:02 p.m.)
Review request for Build System, KDE Software on Mac OS X, KDE Frameworks,
and kdewin.
Repository: kdoctools
Description
---
The URI need to be encoded, because some valid characters for
filenames are not valid according RFC 2396.
Easy way to trigger the issue: when the path contains spaces,
as it happens on MacOSX builds.
See also https://git.reviewboard.kde.org/r/120649/ for the twin review on
kdelibs4support.
Diffs
-
cmake/uriencode.cmake PRE-CREATION
src/CMakeLists.txt 341ecf4
Diff: https://git.reviewboard.kde.org/r/120648/diff/
Testing
---
It compiles, but I can't properly test Mac and Windows scenarios
Thanks,
Luigi Toscano
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120648: Encode the URIs which end up in DTD files
On April 3, 2015, 5:58 p.m., Andrius da Costa Ribas wrote:
cmake/uriencode.cmake, line 15
https://git.reviewboard.kde.org/r/120648/diff/2/?file=320784#file320784line15
I've tried changing this to:
execute_process(COMMAND perl -MURI::Escape -e print
uri_escape_utf8(\${escaped_uri}\, \^A-Za-z0-9\\-\\._~\\/:\);
(...)
it works here, but I'm not sure if it'd be the proper fix.
Patrick von Reth wrote:
ah that whas the error, thanks I finally can compile kdoctools (atleast
locally ) again
Marko Käning wrote:
Has this already been committed, or should this RR still considered to be
re-opened?
No reopen, it was submitted. No, it was not committed, I'd like to understand
the implication of the patch.
- Luigi
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120648/#review78445
---
On Feb. 28, 2015, 11:02 p.m., Luigi Toscano wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120648/
---
(Updated Feb. 28, 2015, 11:02 p.m.)
Review request for Build System, KDE Software on Mac OS X, KDE Frameworks,
and kdewin.
Repository: kdoctools
Description
---
The URI need to be encoded, because some valid characters for
filenames are not valid according RFC 2396.
Easy way to trigger the issue: when the path contains spaces,
as it happens on MacOSX builds.
See also https://git.reviewboard.kde.org/r/120649/ for the twin review on
kdelibs4support.
Diffs
-
cmake/uriencode.cmake PRE-CREATION
src/CMakeLists.txt 341ecf4
Diff: https://git.reviewboard.kde.org/r/120648/diff/
Testing
---
It compiles, but I can't properly test Mac and Windows scenarios
Thanks,
Luigi Toscano
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120648: Encode the URIs which end up in DTD files
On April 3, 2015, 5:58 p.m., Andrius da Costa Ribas wrote:
cmake/uriencode.cmake, line 15
https://git.reviewboard.kde.org/r/120648/diff/2/?file=320784#file320784line15
I've tried changing this to:
execute_process(COMMAND perl -MURI::Escape -e print
uri_escape_utf8(\${escaped_uri}\, \^A-Za-z0-9\\-\\._~\\/:\);
(...)
it works here, but I'm not sure if it'd be the proper fix.
Patrick von Reth wrote:
ah that whas the error, thanks I finally can compile kdoctools (atleast
locally ) again
Marko Käning wrote:
Has this already been committed, or should this RR still considered to be
re-opened?
Luigi Toscano wrote:
No reopen, it was submitted. No, it was not committed, I'd like to
understand the implication of the patch.
Thanks for clarifying.
BTW, thanks to Scarlett's progress on the new CI system it looks like we might
soon be able to check whether this works also reliably on OSX when installing
the files in space-containing paths.
- Marko
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120648/#review78445
---
On Feb. 28, 2015, 11:02 p.m., Luigi Toscano wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120648/
---
(Updated Feb. 28, 2015, 11:02 p.m.)
Review request for Build System, KDE Software on Mac OS X, KDE Frameworks,
and kdewin.
Repository: kdoctools
Description
---
The URI need to be encoded, because some valid characters for
filenames are not valid according RFC 2396.
Easy way to trigger the issue: when the path contains spaces,
as it happens on MacOSX builds.
See also https://git.reviewboard.kde.org/r/120649/ for the twin review on
kdelibs4support.
Diffs
-
cmake/uriencode.cmake PRE-CREATION
src/CMakeLists.txt 341ecf4
Diff: https://git.reviewboard.kde.org/r/120648/diff/
Testing
---
It compiles, but I can't properly test Mac and Windows scenarios
Thanks,
Luigi Toscano
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120648: Encode the URIs which end up in DTD files
On April 3, 2015, 3:58 nachm., Andrius da Costa Ribas wrote:
cmake/uriencode.cmake, line 15
https://git.reviewboard.kde.org/r/120648/diff/2/?file=320784#file320784line15
I've tried changing this to:
execute_process(COMMAND perl -MURI::Escape -e print
uri_escape_utf8(\${escaped_uri}\, \^A-Za-z0-9\\-\\._~\\/:\);
(...)
it works here, but I'm not sure if it'd be the proper fix.
ah that whas the error, thanks I finally can compile kdoctools (atleast locally
) again
- Patrick
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120648/#review78445
---
On Feb. 28, 2015, 10:02 nachm., Luigi Toscano wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120648/
---
(Updated Feb. 28, 2015, 10:02 nachm.)
Review request for Build System, KDE Software on Mac OS X, KDE Frameworks,
and kdewin.
Repository: kdoctools
Description
---
The URI need to be encoded, because some valid characters for
filenames are not valid according RFC 2396.
Easy way to trigger the issue: when the path contains spaces,
as it happens on MacOSX builds.
See also https://git.reviewboard.kde.org/r/120649/ for the twin review on
kdelibs4support.
Diffs
-
cmake/uriencode.cmake PRE-CREATION
src/CMakeLists.txt 341ecf4
Diff: https://git.reviewboard.kde.org/r/120648/diff/
Testing
---
It compiles, but I can't properly test Mac and Windows scenarios
Thanks,
Luigi Toscano
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120648: Encode the URIs which end up in DTD files
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120648/#review78445
---
cmake/uriencode.cmake (line 15)
https://git.reviewboard.kde.org/r/120648/#comment53670
I've tried changing this to:
execute_process(COMMAND perl -MURI::Escape -e print
uri_escape_utf8(\${escaped_uri}\, \^A-Za-z0-9\\-\\._~\\/:\);
(...)
it works here, but I'm not sure if it'd be the proper fix.
- Andrius da Costa Ribas
On Fev. 28, 2015, 10:02 p.m., Luigi Toscano wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120648/
---
(Updated Fev. 28, 2015, 10:02 p.m.)
Review request for Build System, KDE Software on Mac OS X, KDE Frameworks,
and kdewin.
Repository: kdoctools
Description
---
The URI need to be encoded, because some valid characters for
filenames are not valid according RFC 2396.
Easy way to trigger the issue: when the path contains spaces,
as it happens on MacOSX builds.
See also https://git.reviewboard.kde.org/r/120649/ for the twin review on
kdelibs4support.
Diffs
-
cmake/uriencode.cmake PRE-CREATION
src/CMakeLists.txt 341ecf4
Diff: https://git.reviewboard.kde.org/r/120648/diff/
Testing
---
It compiles, but I can't properly test Mac and Windows scenarios
Thanks,
Luigi Toscano
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120648: Encode the URIs which end up in DTD files
On Abril 3, 2015, 3:35 p.m., Andrius da Costa Ribas wrote:
src/CMakeLists.txt, line 20
https://git.reviewboard.kde.org/r/120648/diff/2/?file=320785#file320785line20
It's already committed (but there's been a long time since I hadn't
build anything), but now I see that DocBookXML4_DTD_DIR is used only inside
the else(NOT WIN32) part, is this what's been intended? Also, this
doesn't work when the original DocBookXML4_DTD_DIR is an absolute Windows
path V: becomes V%3A and xmllint fails to recognise it as an absolute
path (see below) and CMake would fail to install to such location. (maybe
we should prepend it with file:// ?)
file:///V:/build/frameworks/kdoctools/work/msvc2013-RelWithDebInfo-master/src/customization/dtd/kdedbx45.dtd:102:
warning: failed to load external
///V:/build/frameworks/kdoctools/work/msvc2013-RelWithDebInfo-master/src/customization/dtd/v%3A/share/xml/docbook/schema/dtd/4.5/docbookx.dtd
%DocBookDTD;
Luigi Toscano wrote:
- DocBookXML4_DTD_DIR is properly touched both for non WIN32 (line 4) and
WIN32 (lines 4 and 20). The WIN32 logic is a bit complicated, but basically
it rewrites again the generated ${_custom_dtd_kdex} file using the DTD path
which is knows during the installation. Or something like that.
- Oh, that's the feedback I was looking for. Can you please copy the
exact content of the path to docbookx.dtd as referenced into kdedbx45.dtd?
!ENTITY % DocBookDTD PUBLIC
-//OASIS//DTD DocBook XML V4.5//EN
v%3A/share/xml/docbook/schema/dtd/4.5/docbookx.dtd
%DocBookDTD;
- Andrius da Costa
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120648/#review78442
---
On Fev. 28, 2015, 10:02 p.m., Luigi Toscano wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120648/
---
(Updated Fev. 28, 2015, 10:02 p.m.)
Review request for Build System, KDE Software on Mac OS X, KDE Frameworks,
and kdewin.
Repository: kdoctools
Description
---
The URI need to be encoded, because some valid characters for
filenames are not valid according RFC 2396.
Easy way to trigger the issue: when the path contains spaces,
as it happens on MacOSX builds.
See also https://git.reviewboard.kde.org/r/120649/ for the twin review on
kdelibs4support.
Diffs
-
cmake/uriencode.cmake PRE-CREATION
src/CMakeLists.txt 341ecf4
Diff: https://git.reviewboard.kde.org/r/120648/diff/
Testing
---
It compiles, but I can't properly test Mac and Windows scenarios
Thanks,
Luigi Toscano
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120648: Encode the URIs which end up in DTD files
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/#review78442 --- src/CMakeLists.txt (line 20) https://git.reviewboard.kde.org/r/120648/#comment53667 It's already committed (but there's been a long time since I hadn't build anything), but now I see that DocBookXML4_DTD_DIR is used only inside the else(NOT WIN32) part, is this what's been intended? Also, this doesn't work when the original DocBookXML4_DTD_DIR is an absolute Windows path V: becomes V%3A and xmllint fails to recognise it as an absolute path (see below) and CMake would fail to install to such location. (maybe we should prepend it with file:// ?) file:///V:/build/frameworks/kdoctools/work/msvc2013-RelWithDebInfo-master/src/customization/dtd/kdedbx45.dtd:102: warning: failed to load external ///V:/build/frameworks/kdoctools/work/msvc2013-RelWithDebInfo-master/src/customization/dtd/v%3A/share/xml/docbook/schema/dtd/4.5/docbookx.dtd %DocBookDTD; - Andrius da Costa Ribas On Fev. 28, 2015, 10:02 p.m., Luigi Toscano wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/ --- (Updated Fev. 28, 2015, 10:02 p.m.) Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, and kdewin. Repository: kdoctools Description --- The URI need to be encoded, because some valid characters for filenames are not valid according RFC 2396. Easy way to trigger the issue: when the path contains spaces, as it happens on MacOSX builds. See also https://git.reviewboard.kde.org/r/120649/ for the twin review on kdelibs4support. Diffs - cmake/uriencode.cmake PRE-CREATION src/CMakeLists.txt 341ecf4 Diff: https://git.reviewboard.kde.org/r/120648/diff/ Testing --- It compiles, but I can't properly test Mac and Windows scenarios Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120648: Encode the URIs which end up in DTD files
On April 3, 2015, 5:35 p.m., Andrius da Costa Ribas wrote:
src/CMakeLists.txt, line 20
https://git.reviewboard.kde.org/r/120648/diff/2/?file=320785#file320785line20
It's already committed (but there's been a long time since I hadn't
build anything), but now I see that DocBookXML4_DTD_DIR is used only inside
the else(NOT WIN32) part, is this what's been intended? Also, this
doesn't work when the original DocBookXML4_DTD_DIR is an absolute Windows
path V: becomes V%3A and xmllint fails to recognise it as an absolute
path (see below) and CMake would fail to install to such location. (maybe
we should prepend it with file:// ?)
file:///V:/build/frameworks/kdoctools/work/msvc2013-RelWithDebInfo-master/src/customization/dtd/kdedbx45.dtd:102:
warning: failed to load external
///V:/build/frameworks/kdoctools/work/msvc2013-RelWithDebInfo-master/src/customization/dtd/v%3A/share/xml/docbook/schema/dtd/4.5/docbookx.dtd
%DocBookDTD;
- DocBookXML4_DTD_DIR is properly touched both for non WIN32 (line 4) and WIN32
(lines 4 and 20). The WIN32 logic is a bit complicated, but basically it
rewrites again the generated ${_custom_dtd_kdex} file using the DTD path which
is knows during the installation. Or something like that.
- Oh, that's the feedback I was looking for. Can you please copy the exact
content of the path to docbookx.dtd as referenced into kdedbx45.dtd?
- Luigi
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120648/#review78442
---
On Feb. 28, 2015, 11:02 p.m., Luigi Toscano wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120648/
---
(Updated Feb. 28, 2015, 11:02 p.m.)
Review request for Build System, KDE Software on Mac OS X, KDE Frameworks,
and kdewin.
Repository: kdoctools
Description
---
The URI need to be encoded, because some valid characters for
filenames are not valid according RFC 2396.
Easy way to trigger the issue: when the path contains spaces,
as it happens on MacOSX builds.
See also https://git.reviewboard.kde.org/r/120649/ for the twin review on
kdelibs4support.
Diffs
-
cmake/uriencode.cmake PRE-CREATION
src/CMakeLists.txt 341ecf4
Diff: https://git.reviewboard.kde.org/r/120648/diff/
Testing
---
It compiles, but I can't properly test Mac and Windows scenarios
Thanks,
Luigi Toscano
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120648: Encode the URIs which end up in DTD files
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/#review76782 --- Ship it! Ship It! - Jeremy Whiting On Oct. 19, 2014, 6:12 p.m., Luigi Toscano wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/ --- (Updated Oct. 19, 2014, 6:12 p.m.) Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, and kdewin. Repository: kdoctools Description --- The URI need to be encoded, because some valid characters for filenames are not valid according RFC 2396. Easy way to trigger the issue: when the path contains spaces, as it happens on MacOSX builds. See also https://git.reviewboard.kde.org/r/120649/ for the twin review on kdelibs4support. Diffs - cmake/uriencode.cmake PRE-CREATION src/CMakeLists.txt 341ecf4 Diff: https://git.reviewboard.kde.org/r/120648/diff/ Testing --- It compiles, but I can't properly test Mac and Windows scenarios Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120648: Encode the URIs which end up in DTD files
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/ --- (Updated Feb. 28, 2015, 10:02 p.m.) Status -- This change has been marked as submitted. Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, and kdewin. Repository: kdoctools Description --- The URI need to be encoded, because some valid characters for filenames are not valid according RFC 2396. Easy way to trigger the issue: when the path contains spaces, as it happens on MacOSX builds. See also https://git.reviewboard.kde.org/r/120649/ for the twin review on kdelibs4support. Diffs - cmake/uriencode.cmake PRE-CREATION src/CMakeLists.txt 341ecf4 Diff: https://git.reviewboard.kde.org/r/120648/diff/ Testing --- It compiles, but I can't properly test Mac and Windows scenarios Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120648: Encode the URIs which end up in DTD files
On Oct. 21, 2014, 9:08 p.m., Alex Merry wrote: Ship It! Marko Käning wrote: Hi Alex, did you test this successfully on Windows? No, I'm expecting Luigi to interpret my shipit as approval of the CMake code in principle, and to exercise his own judgement in whether it's actually good to go. This is where the Gerrit +1/+2 system can be useful... - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/#review68855 --- On Oct. 20, 2014, 12:12 a.m., Luigi Toscano wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/ --- (Updated Oct. 20, 2014, 12:12 a.m.) Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, and kdewin. Repository: kdoctools Description --- The URI need to be encoded, because some valid characters for filenames are not valid according RFC 2396. Easy way to trigger the issue: when the path contains spaces, as it happens on MacOSX builds. See also https://git.reviewboard.kde.org/r/120649/ for the twin review on kdelibs4support. Diffs - cmake/uriencode.cmake PRE-CREATION src/CMakeLists.txt 341ecf4 Diff: https://git.reviewboard.kde.org/r/120648/diff/ Testing --- It compiles, but I can't properly test Mac and Windows scenarios Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120648: Encode the URIs which end up in DTD files
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/#review69055 --- I'll try to set up an OSX/CI VM in such a way that I can test this patch. I will report back. - Marko Käning On Oct. 20, 2014, 2:12 a.m., Luigi Toscano wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/ --- (Updated Oct. 20, 2014, 2:12 a.m.) Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, and kdewin. Repository: kdoctools Description --- The URI need to be encoded, because some valid characters for filenames are not valid according RFC 2396. Easy way to trigger the issue: when the path contains spaces, as it happens on MacOSX builds. See also https://git.reviewboard.kde.org/r/120649/ for the twin review on kdelibs4support. Diffs - cmake/uriencode.cmake PRE-CREATION src/CMakeLists.txt 341ecf4 Diff: https://git.reviewboard.kde.org/r/120648/diff/ Testing --- It compiles, but I can't properly test Mac and Windows scenarios Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120648: Encode the URIs which end up in DTD files
On Oct. 21, 2014, 11:08 p.m., Alex Merry wrote: Ship It! Hi Alex, did you test this successfully on Windows? - Marko --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/#review68855 --- On Oct. 20, 2014, 2:12 a.m., Luigi Toscano wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/ --- (Updated Oct. 20, 2014, 2:12 a.m.) Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, and kdewin. Repository: kdoctools Description --- The URI need to be encoded, because some valid characters for filenames are not valid according RFC 2396. Easy way to trigger the issue: when the path contains spaces, as it happens on MacOSX builds. See also https://git.reviewboard.kde.org/r/120649/ for the twin review on kdelibs4support. Diffs - cmake/uriencode.cmake PRE-CREATION src/CMakeLists.txt 341ecf4 Diff: https://git.reviewboard.kde.org/r/120648/diff/ Testing --- It compiles, but I can't properly test Mac and Windows scenarios Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120648: Encode the URIs which end up in DTD files
On Oct. 18, 2014, 8:50 p.m., René J.V. Bertin wrote: These are both RRs for KF5? Luigi Toscano wrote: Yes, otherwise the repository would have been kdelibs. Do you think it would make sense to backport it? René J.V. Bertin wrote: You say that this is for when the path contains spaces, as it happens on MacOSX builds. I haven't run into this, can you give an example? What path, and building what? I'd say that people installing KDE on OS X are aware enough of the dangers not to use spaces in KDE related paths (I for one certainly avoid them), but I may be overlooking certain scenarios. Luigi Toscano wrote: Please ask Marko, he hit this problem when testing KDocTools/KF5. René, the path would be /Library/Application Support for instance! :-) - Marko --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/#review68675 --- On Oct. 20, 2014, 2:12 a.m., Luigi Toscano wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/ --- (Updated Oct. 20, 2014, 2:12 a.m.) Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, and kdewin. Repository: kdoctools Description --- The URI need to be encoded, because some valid characters for filenames are not valid according RFC 2396. Easy way to trigger the issue: when the path contains spaces, as it happens on MacOSX builds. See also https://git.reviewboard.kde.org/r/120649/ for the twin review on kdelibs4support. Diffs - cmake/uriencode.cmake PRE-CREATION src/CMakeLists.txt 341ecf4 Diff: https://git.reviewboard.kde.org/r/120648/diff/ Testing --- It compiles, but I can't properly test Mac and Windows scenarios Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120648: Encode the URIs which end up in DTD files
On Oct. 19, 2014, 10:52 a.m., Alex Merry wrote: src/CMakeLists.txt, line 19 https://git.reviewboard.kde.org/r/120648/diff/1/?file=320540#file320540line19 You've already included it above... Luigi Toscano wrote: This is different, it's in a piece of code inside install(CODE...) which is executed in a different moment (installation time). From my quick test it seems I need the previous include is in a different scope. Ah, you're absolutely right. Sorry. - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/#review68696 --- On Oct. 20, 2014, 12:12 a.m., Luigi Toscano wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/ --- (Updated Oct. 20, 2014, 12:12 a.m.) Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, and kdewin. Repository: kdoctools Description --- The URI need to be encoded, because some valid characters for filenames are not valid according RFC 2396. Easy way to trigger the issue: when the path contains spaces, as it happens on MacOSX builds. See also https://git.reviewboard.kde.org/r/120649/ for the twin review on kdelibs4support. Diffs - cmake/uriencode.cmake PRE-CREATION src/CMakeLists.txt 341ecf4 Diff: https://git.reviewboard.kde.org/r/120648/diff/ Testing --- It compiles, but I can't properly test Mac and Windows scenarios Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120648: Encode the URIs which end up in DTD files
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/#review68855 --- Ship it! Ship It! - Alex Merry On Oct. 20, 2014, 12:12 a.m., Luigi Toscano wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/ --- (Updated Oct. 20, 2014, 12:12 a.m.) Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, and kdewin. Repository: kdoctools Description --- The URI need to be encoded, because some valid characters for filenames are not valid according RFC 2396. Easy way to trigger the issue: when the path contains spaces, as it happens on MacOSX builds. See also https://git.reviewboard.kde.org/r/120649/ for the twin review on kdelibs4support. Diffs - cmake/uriencode.cmake PRE-CREATION src/CMakeLists.txt 341ecf4 Diff: https://git.reviewboard.kde.org/r/120648/diff/ Testing --- It compiles, but I can't properly test Mac and Windows scenarios Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120648: Encode the URIs which end up in DTD files
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120648/#review68696
---
cmake/uriencode.cmake
https://git.reviewboard.kde.org/r/120648/#comment47898
You may want to consider using `string(REPLACE)` to escape double-quote
chars in `${_original_uri}`, like
string(REPLACE \ \\ escaped_uri ${${_original_uri}})
and then use `${escaped_uri}` in the perl script.
src/CMakeLists.txt
https://git.reviewboard.kde.org/r/120648/#comment47897
You've already included it above...
- Alex Merry
On Oct. 18, 2014, 3:50 p.m., Luigi Toscano wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120648/
---
(Updated Oct. 18, 2014, 3:50 p.m.)
Review request for Build System, KDE Software on Mac OS X, KDE Frameworks,
and kdewin.
Repository: kdoctools
Description
---
The URI need to be encoded, because some valid characters for
filenames are not valid according RFC 2396.
Easy way to trigger the issue: when the path contains spaces,
as it happens on MacOSX builds.
See also https://git.reviewboard.kde.org/r/120649/ for the twin review on
kdelibs4support.
Diffs
-
src/CMakeLists.txt 341ecf4
cmake/uriencode.cmake PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/120648/diff/
Testing
---
It compiles, but I can't properly test Mac and Windows scenarios
Thanks,
Luigi Toscano
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120648: Encode the URIs which end up in DTD files
On Ott. 19, 2014, 12:52 p.m., Alex Merry wrote:
src/CMakeLists.txt, line 19
https://git.reviewboard.kde.org/r/120648/diff/1/?file=320540#file320540line19
You've already included it above...
This is different, it's in a piece of code inside install(CODE...) which is
executed in a different moment (installation time). From my quick test it seems
I need the previous include is in a different scope.
On Ott. 19, 2014, 12:52 p.m., Alex Merry wrote:
cmake/uriencode.cmake, line 14
https://git.reviewboard.kde.org/r/120648/diff/1/?file=320539#file320539line14
You may want to consider using `string(REPLACE)` to escape double-quote
chars in `${_original_uri}`, like
string(REPLACE \ \\ escaped_uri ${${_original_uri}})
and then use `${escaped_uri}` in the perl script.
Added to the function, thanks.
- Luigi
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120648/#review68696
---
On Ott. 18, 2014, 5:50 p.m., Luigi Toscano wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120648/
---
(Updated Ott. 18, 2014, 5:50 p.m.)
Review request for Build System, KDE Software on Mac OS X, KDE Frameworks,
and kdewin.
Repository: kdoctools
Description
---
The URI need to be encoded, because some valid characters for
filenames are not valid according RFC 2396.
Easy way to trigger the issue: when the path contains spaces,
as it happens on MacOSX builds.
See also https://git.reviewboard.kde.org/r/120649/ for the twin review on
kdelibs4support.
Diffs
-
src/CMakeLists.txt 341ecf4
cmake/uriencode.cmake PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/120648/diff/
Testing
---
It compiles, but I can't properly test Mac and Windows scenarios
Thanks,
Luigi Toscano
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120648: Encode the URIs which end up in DTD files
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/ --- (Updated Oct. 20, 2014, 2:12 a.m.) Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, and kdewin. Changes --- Encoding for double quote added; colon is now encoded as well. Repository: kdoctools Description --- The URI need to be encoded, because some valid characters for filenames are not valid according RFC 2396. Easy way to trigger the issue: when the path contains spaces, as it happens on MacOSX builds. See also https://git.reviewboard.kde.org/r/120649/ for the twin review on kdelibs4support. Diffs (updated) - cmake/uriencode.cmake PRE-CREATION src/CMakeLists.txt 341ecf4 Diff: https://git.reviewboard.kde.org/r/120648/diff/ Testing --- It compiles, but I can't properly test Mac and Windows scenarios Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 120648: Encode the URIs which end up in DTD files
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/ --- Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, and kdewin. Repository: kdoctools Description --- The URI need to be encoded, because some valid characters for filenames are not valid according RFC 2396. Easy way to trigger the issue: when the path contains spaces, as it happens on MacOSX builds. See also https://git.reviewboard.kde.org/r/120649/ for the twin review on kdelibs4support. Diffs - src/CMakeLists.txt 341ecf4 cmake/uriencode.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120648/diff/ Testing --- It compiles, but I can't properly test Mac and Windows scenarios Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120648: Encode the URIs which end up in DTD files
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/#review68674 --- I guess we're assuming no-one's putting double-quotes in the URIs? It's probably not worth making it more reslient, given the extra complexity that would entail (you'd either have to do some pre-escaping or write it out to a temporary file, given the lack of an INPUT_VARIABLE option to execute_process. - Alex Merry On Oct. 18, 2014, 3:50 p.m., Luigi Toscano wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/ --- (Updated Oct. 18, 2014, 3:50 p.m.) Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, and kdewin. Repository: kdoctools Description --- The URI need to be encoded, because some valid characters for filenames are not valid according RFC 2396. Easy way to trigger the issue: when the path contains spaces, as it happens on MacOSX builds. See also https://git.reviewboard.kde.org/r/120649/ for the twin review on kdelibs4support. Diffs - src/CMakeLists.txt 341ecf4 cmake/uriencode.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120648/diff/ Testing --- It compiles, but I can't properly test Mac and Windows scenarios Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120648: Encode the URIs which end up in DTD files
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/#review68675 --- These are both RRs for KF5? - René J.V. Bertin On Oct. 18, 2014, 5:50 p.m., Luigi Toscano wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/ --- (Updated Oct. 18, 2014, 5:50 p.m.) Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, and kdewin. Repository: kdoctools Description --- The URI need to be encoded, because some valid characters for filenames are not valid according RFC 2396. Easy way to trigger the issue: when the path contains spaces, as it happens on MacOSX builds. See also https://git.reviewboard.kde.org/r/120649/ for the twin review on kdelibs4support. Diffs - src/CMakeLists.txt 341ecf4 cmake/uriencode.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120648/diff/ Testing --- It compiles, but I can't properly test Mac and Windows scenarios Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120648: Encode the URIs which end up in DTD files
On Ott. 18, 2014, 8:50 p.m., René J.V. Bertin wrote: These are both RRs for KF5? Yes, otherwise the repository would have been kdelibs. Do you think it would make sense to backport it? - Luigi --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/#review68675 --- On Ott. 18, 2014, 5:50 p.m., Luigi Toscano wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/ --- (Updated Ott. 18, 2014, 5:50 p.m.) Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, and kdewin. Repository: kdoctools Description --- The URI need to be encoded, because some valid characters for filenames are not valid according RFC 2396. Easy way to trigger the issue: when the path contains spaces, as it happens on MacOSX builds. See also https://git.reviewboard.kde.org/r/120649/ for the twin review on kdelibs4support. Diffs - src/CMakeLists.txt 341ecf4 cmake/uriencode.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120648/diff/ Testing --- It compiles, but I can't properly test Mac and Windows scenarios Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120648: Encode the URIs which end up in DTD files
On Ott. 18, 2014, 8:10 p.m., Alex Merry wrote: I guess we're assuming no-one's putting double-quotes in the URIs? It's probably not worth making it more reslient, given the extra complexity that would entail (you'd either have to do some pre-escaping or write it out to a temporary file, given the lack of an INPUT_VARIABLE option to execute_process. Uhm, I don't know. It's theoretically possible, I have the feeling that some other stuff would break too. Another possible solution would be to pass the value using an environment value. What do you think? And apart from this issue, what do you think of the rest of the code? - Luigi --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/#review68674 --- On Ott. 18, 2014, 5:50 p.m., Luigi Toscano wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/ --- (Updated Ott. 18, 2014, 5:50 p.m.) Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, and kdewin. Repository: kdoctools Description --- The URI need to be encoded, because some valid characters for filenames are not valid according RFC 2396. Easy way to trigger the issue: when the path contains spaces, as it happens on MacOSX builds. See also https://git.reviewboard.kde.org/r/120649/ for the twin review on kdelibs4support. Diffs - src/CMakeLists.txt 341ecf4 cmake/uriencode.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120648/diff/ Testing --- It compiles, but I can't properly test Mac and Windows scenarios Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120648: Encode the URIs which end up in DTD files
On Oct. 18, 2014, 8:50 p.m., René J.V. Bertin wrote: These are both RRs for KF5? Luigi Toscano wrote: Yes, otherwise the repository would have been kdelibs. Do you think it would make sense to backport it? You say that this is for when the path contains spaces, as it happens on MacOSX builds. I haven't run into this, can you give an example? What path, and building what? I'd say that people installing KDE on OS X are aware enough of the dangers not to use spaces in KDE related paths (I for one certainly avoid them), but I may be overlooking certain scenarios. - René J.V. --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/#review68675 --- On Oct. 18, 2014, 5:50 p.m., Luigi Toscano wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/ --- (Updated Oct. 18, 2014, 5:50 p.m.) Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, and kdewin. Repository: kdoctools Description --- The URI need to be encoded, because some valid characters for filenames are not valid according RFC 2396. Easy way to trigger the issue: when the path contains spaces, as it happens on MacOSX builds. See also https://git.reviewboard.kde.org/r/120649/ for the twin review on kdelibs4support. Diffs - src/CMakeLists.txt 341ecf4 cmake/uriencode.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120648/diff/ Testing --- It compiles, but I can't properly test Mac and Windows scenarios Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120648: Encode the URIs which end up in DTD files
On Ott. 18, 2014, 8:50 p.m., René J.V. Bertin wrote: These are both RRs for KF5? Luigi Toscano wrote: Yes, otherwise the repository would have been kdelibs. Do you think it would make sense to backport it? René J.V. Bertin wrote: You say that this is for when the path contains spaces, as it happens on MacOSX builds. I haven't run into this, can you give an example? What path, and building what? I'd say that people installing KDE on OS X are aware enough of the dangers not to use spaces in KDE related paths (I for one certainly avoid them), but I may be overlooking certain scenarios. Please ask Marko, he hit this problem when testing KDocTools/KF5. - Luigi --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/#review68675 --- On Ott. 18, 2014, 5:50 p.m., Luigi Toscano wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/ --- (Updated Ott. 18, 2014, 5:50 p.m.) Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, and kdewin. Repository: kdoctools Description --- The URI need to be encoded, because some valid characters for filenames are not valid according RFC 2396. Easy way to trigger the issue: when the path contains spaces, as it happens on MacOSX builds. See also https://git.reviewboard.kde.org/r/120649/ for the twin review on kdelibs4support. Diffs - src/CMakeLists.txt 341ecf4 cmake/uriencode.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120648/diff/ Testing --- It compiles, but I can't properly test Mac and Windows scenarios Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
