Re: Review Request 121356: Do not change the volume when playing a notification
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121356/ --- (Updated des. 8, 2014, 10:39 p.m.) Status -- This change has been discarded. Review request for KDE Frameworks and David Edmundson. Repository: knotifications Description --- Playing a notification should be that, playing a notification. Inspired by David's comment on https://git.reviewboard.kde.org/r/121278/ Diffs - src/notifybysound.cpp 09a80dd Diff: https://git.reviewboard.kde.org/r/121356/diff/ Testing --- Thanks, Albert Astals Cid ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121356: Do not change the volume when playing a notification
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121356/#review71411 --- For frameworks version it's actually using notifybyaudio plugin for playing the sounds and that's using phonon exclusively, there's no more volume fiddling in fact. The notifybysound should just be removed altogether..don't know why it's still around :O - Martin Klapetek On Dec. 4, 2014, 10:12 p.m., Albert Astals Cid wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121356/ --- (Updated Dec. 4, 2014, 10:12 p.m.) Review request for KDE Frameworks and David Edmundson. Repository: knotifications Description --- Playing a notification should be that, playing a notification. Inspired by David's comment on https://git.reviewboard.kde.org/r/121278/ Diffs - src/notifybysound.cpp 09a80dd Diff: https://git.reviewboard.kde.org/r/121356/diff/ Testing --- Thanks, Albert Astals Cid ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121356: Do not change the volume when playing a notification
On Dec. 5, 2014, 10:59 a.m., Martin Klapetek wrote: For frameworks version it's actually using notifybyaudio plugin for playing the sounds and that's using phonon exclusively, there's no more volume fiddling in fact. The notifybysound should just be removed altogether..don't know why it's still around :O so the entire page about choosing an external player in plasma-desktop is invalid? - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121356/#review71411 --- On Dec. 4, 2014, 9:12 p.m., Albert Astals Cid wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121356/ --- (Updated Dec. 4, 2014, 9:12 p.m.) Review request for KDE Frameworks and David Edmundson. Repository: knotifications Description --- Playing a notification should be that, playing a notification. Inspired by David's comment on https://git.reviewboard.kde.org/r/121278/ Diffs - src/notifybysound.cpp 09a80dd Diff: https://git.reviewboard.kde.org/r/121356/diff/ Testing --- Thanks, Albert Astals Cid ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121356: Do not change the volume when playing a notification
On Dec. 5, 2014, 11:59 a.m., Martin Klapetek wrote: For frameworks version it's actually using notifybyaudio plugin for playing the sounds and that's using phonon exclusively, there's no more volume fiddling in fact. The notifybysound should just be removed altogether..don't know why it's still around :O David Edmundson wrote: so the entire page about choosing an external player in plasma-desktop is invalid? Seems like it. If we still want that, I think it would be easy to implement into the notifybyaudio. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121356/#review71411 --- On Dec. 4, 2014, 10:12 p.m., Albert Astals Cid wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121356/ --- (Updated Dec. 4, 2014, 10:12 p.m.) Review request for KDE Frameworks and David Edmundson. Repository: knotifications Description --- Playing a notification should be that, playing a notification. Inspired by David's comment on https://git.reviewboard.kde.org/r/121278/ Diffs - src/notifybysound.cpp 09a80dd Diff: https://git.reviewboard.kde.org/r/121356/diff/ Testing --- Thanks, Albert Astals Cid ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121356: Do not change the volume when playing a notification
On Dec. 5, 2014, 10:59 a.m., Martin Klapetek wrote: For frameworks version it's actually using notifybyaudio plugin for playing the sounds and that's using phonon exclusively, there's no more volume fiddling in fact. The notifybysound should just be removed altogether..don't know why it's still around :O David Edmundson wrote: so the entire page about choosing an external player in plasma-desktop is invalid? Martin Klapetek wrote: Seems like it. If we still want that, I think it would be easy to implement into the notifybyaudio. I say kill it and see if anyone complains. It was written literally for last millenium. A time before Pulse, before Phonon and possibly even before ARTs. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121356/#review71411 --- On Dec. 4, 2014, 9:12 p.m., Albert Astals Cid wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121356/ --- (Updated Dec. 4, 2014, 9:12 p.m.) Review request for KDE Frameworks and David Edmundson. Repository: knotifications Description --- Playing a notification should be that, playing a notification. Inspired by David's comment on https://git.reviewboard.kde.org/r/121278/ Diffs - src/notifybysound.cpp 09a80dd Diff: https://git.reviewboard.kde.org/r/121356/diff/ Testing --- Thanks, Albert Astals Cid ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121356: Do not change the volume when playing a notification
On Dec. 5, 2014, 11:59 a.m., Martin Klapetek wrote: For frameworks version it's actually using notifybyaudio plugin for playing the sounds and that's using phonon exclusively, there's no more volume fiddling in fact. The notifybysound should just be removed altogether..don't know why it's still around :O David Edmundson wrote: so the entire page about choosing an external player in plasma-desktop is invalid? Martin Klapetek wrote: Seems like it. If we still want that, I think it would be easy to implement into the notifybyaudio. David Edmundson wrote: I say kill it and see if anyone complains. It was written literally for last millenium. A time before Pulse, before Phonon and possibly even before ARTs. +1. There was even no bug report about this so I'd assume it just works. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121356/#review71411 --- On Dec. 4, 2014, 10:12 p.m., Albert Astals Cid wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121356/ --- (Updated Dec. 4, 2014, 10:12 p.m.) Review request for KDE Frameworks and David Edmundson. Repository: knotifications Description --- Playing a notification should be that, playing a notification. Inspired by David's comment on https://git.reviewboard.kde.org/r/121278/ Diffs - src/notifybysound.cpp 09a80dd Diff: https://git.reviewboard.kde.org/r/121356/diff/ Testing --- Thanks, Albert Astals Cid ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 121356: Do not change the volume when playing a notification
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121356/ --- Review request for KDE Frameworks and David Edmundson. Repository: knotifications Description --- Playing a notification should be that, playing a notification. Inspired by David's comment on https://git.reviewboard.kde.org/r/121278/ Diffs - src/notifybysound.cpp 09a80dd Diff: https://git.reviewboard.kde.org/r/121356/diff/ Testing --- Thanks, Albert Astals Cid ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121356: Do not change the volume when playing a notification
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121356/#review71372 --- Ship it! Ship It! - Jeremy Whiting On Dec. 4, 2014, 2:12 p.m., Albert Astals Cid wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121356/ --- (Updated Dec. 4, 2014, 2:12 p.m.) Review request for KDE Frameworks and David Edmundson. Repository: knotifications Description --- Playing a notification should be that, playing a notification. Inspired by David's comment on https://git.reviewboard.kde.org/r/121278/ Diffs - src/notifybysound.cpp 09a80dd Diff: https://git.reviewboard.kde.org/r/121356/diff/ Testing --- Thanks, Albert Astals Cid ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121356: Do not change the volume when playing a notification
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121356/#review71379 --- Ship it! Ship It! - David Edmundson On Dec. 4, 2014, 9:12 p.m., Albert Astals Cid wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121356/ --- (Updated Dec. 4, 2014, 9:12 p.m.) Review request for KDE Frameworks and David Edmundson. Repository: knotifications Description --- Playing a notification should be that, playing a notification. Inspired by David's comment on https://git.reviewboard.kde.org/r/121278/ Diffs - src/notifybysound.cpp 09a80dd Diff: https://git.reviewboard.kde.org/r/121356/diff/ Testing --- Thanks, Albert Astals Cid ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
