Re: Review Request 121895: Fix local issues in KIO build

2015-01-07 Thread Aleix Pol Gonzalez

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121895/
---

(Updated Jan. 7, 2015, 1:41 p.m.)


Status
--

This change has been discarded.


Review request for KDE Frameworks.


Repository: kio


Description
---

Fix KIO build, otherwise I get the following error:
``` /home/kde-devel/frameworks/kio/src/kioexec/main.cpp:47:24: fatal error: 
KStartupInfo: No such file or directory```
``` #include KStartupInfo```


Diffs
-

  src/kioexec/CMakeLists.txt 1f08845 

Diff: https://git.reviewboard.kde.org/r/121895/diff/


Testing
---

Now it builds.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 121895: Fix local issues in KIO build

2015-01-07 Thread Jeremy Whiting


 On Jan. 7, 2015, 5:35 a.m., Jeremy Whiting wrote:
  Ship It!

Fixes it here.


- Jeremy


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121895/#review73359
---


On Jan. 7, 2015, 4:52 a.m., Aleix Pol Gonzalez wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/121895/
 ---
 
 (Updated Jan. 7, 2015, 4:52 a.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: kio
 
 
 Description
 ---
 
 Fix KIO build, otherwise I get the following error:
 ``` /home/kde-devel/frameworks/kio/src/kioexec/main.cpp:47:24: fatal error: 
 KStartupInfo: No such file or directory```
 ``` #include KStartupInfo```
 
 
 Diffs
 -
 
   src/kioexec/CMakeLists.txt 1f08845 
 
 Diff: https://git.reviewboard.kde.org/r/121895/diff/
 
 
 Testing
 ---
 
 Now it builds.
 
 
 Thanks,
 
 Aleix Pol Gonzalez
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 121895: Fix local issues in KIO build

2015-01-07 Thread Jeremy Whiting

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121895/#review73359
---

Ship it!


Ship It!

- Jeremy Whiting


On Jan. 7, 2015, 4:52 a.m., Aleix Pol Gonzalez wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/121895/
 ---
 
 (Updated Jan. 7, 2015, 4:52 a.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: kio
 
 
 Description
 ---
 
 Fix KIO build, otherwise I get the following error:
 ``` /home/kde-devel/frameworks/kio/src/kioexec/main.cpp:47:24: fatal error: 
 KStartupInfo: No such file or directory```
 ``` #include KStartupInfo```
 
 
 Diffs
 -
 
   src/kioexec/CMakeLists.txt 1f08845 
 
 Diff: https://git.reviewboard.kde.org/r/121895/diff/
 
 
 Testing
 ---
 
 Now it builds.
 
 
 Thanks,
 
 Aleix Pol Gonzalez
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Review Request 121895: Fix local issues in KIO build

2015-01-07 Thread Aleix Pol Gonzalez

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121895/
---

Review request for KDE Frameworks.


Repository: kio


Description
---

Fix KIO build, otherwise I get the following error:
``` /home/kde-devel/frameworks/kio/src/kioexec/main.cpp:47:24: fatal error: 
KStartupInfo: No such file or directory```
``` #include KStartupInfo```


Diffs
-

  src/kioexec/CMakeLists.txt 1f08845 

Diff: https://git.reviewboard.kde.org/r/121895/diff/


Testing
---

Now it builds.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel