Re: Review Request 122667: Some tools for easily do qml based apps using KPackage
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122667/#review76989 --- +1 - David Edmundson On March 3, 2015, 7:29 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122667/ --- (Updated March 3, 2015, 7:29 p.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- This is still a bit rough but adding it there for early feedback. comes from the fact that I would like a standard-ish way for KDE apps to do QML based apps It adds 3 things: * KPackage support to QmlObject: the class is done to easily load QML without using qquickview, since I want to push loading qml from KPackages, adding kpackage support to this class seems to make sense * qmlpackagelauncher: tiny tool to launch qml apps from qml packages: supports both the case the root object is a qquickitem or an ApplicationWindow qtquickcomponent(that is a window in itself) puts proper window title and icon, sets the kaboutdata from the metadata file, binds commandline arguments in the context (kinda feel some other bindings/API could be needed) * KPackageView: is a qquickview that loads kpackages... seeing that the direction from Qt of using ApplicationWindow as root item makes me a bit unsure wether to add this tough Diffs - src/kdeclarative/qmlobject.h a0a74d3 src/kdeclarative/qmlobject.cpp 00478b4 src/kpackagelauncherqml/CMakeLists.txt PRE-CREATION src/kpackagelauncherqml/main.cpp PRE-CREATION src/quickaddons/CMakeLists.txt 8272f1f tests/CMakeLists.txt a8abfaf tests/helloworld/contents/ui/main.qml PRE-CREATION tests/helloworld/metadata.desktop PRE-CREATION tests/helloworldnowindow/contents/ui/main.qml PRE-CREATION tests/helloworldnowindow/metadata.desktop PRE-CREATION CMakeLists.txt 52a698a src/CMakeLists.txt 32da8a5 src/kdeclarative/CMakeLists.txt 052b9e2 Diff: https://git.reviewboard.kde.org/r/122667/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122667: Some tools for easily do qml based apps using KPackage
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122667/ --- (Updated March 4, 2015, 10:51 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- This is still a bit rough but adding it there for early feedback. comes from the fact that I would like a standard-ish way for KDE apps to do QML based apps It adds 3 things: * KPackage support to QmlObject: the class is done to easily load QML without using qquickview, since I want to push loading qml from KPackages, adding kpackage support to this class seems to make sense * qmlpackagelauncher: tiny tool to launch qml apps from qml packages: supports both the case the root object is a qquickitem or an ApplicationWindow qtquickcomponent(that is a window in itself) puts proper window title and icon, sets the kaboutdata from the metadata file, binds commandline arguments in the context (kinda feel some other bindings/API could be needed) * KPackageView: is a qquickview that loads kpackages... seeing that the direction from Qt of using ApplicationWindow as root item makes me a bit unsure wether to add this tough Diffs - src/kdeclarative/qmlobject.h a0a74d3 src/kdeclarative/qmlobject.cpp 00478b4 src/kpackagelauncherqml/CMakeLists.txt PRE-CREATION src/kpackagelauncherqml/main.cpp PRE-CREATION src/quickaddons/CMakeLists.txt 8272f1f tests/CMakeLists.txt a8abfaf tests/helloworld/contents/ui/main.qml PRE-CREATION tests/helloworld/metadata.desktop PRE-CREATION tests/helloworldnowindow/contents/ui/main.qml PRE-CREATION tests/helloworldnowindow/metadata.desktop PRE-CREATION CMakeLists.txt 52a698a src/CMakeLists.txt 32da8a5 src/kdeclarative/CMakeLists.txt 052b9e2 Diff: https://git.reviewboard.kde.org/r/122667/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122667: Some tools for easily do qml based apps using KPackage
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122667/#review76991 --- Ship it! Looking good. src/kdeclarative/qmlobject.h https://git.reviewboard.kde.org/r/122667/#comment52955 stray space tests/helloworld/contents/ui/main.qml https://git.reviewboard.kde.org/r/122667/#comment52956 stray trailing space - Sebastian Kügler On March 3, 2015, 7:29 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122667/ --- (Updated March 3, 2015, 7:29 p.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- This is still a bit rough but adding it there for early feedback. comes from the fact that I would like a standard-ish way for KDE apps to do QML based apps It adds 3 things: * KPackage support to QmlObject: the class is done to easily load QML without using qquickview, since I want to push loading qml from KPackages, adding kpackage support to this class seems to make sense * qmlpackagelauncher: tiny tool to launch qml apps from qml packages: supports both the case the root object is a qquickitem or an ApplicationWindow qtquickcomponent(that is a window in itself) puts proper window title and icon, sets the kaboutdata from the metadata file, binds commandline arguments in the context (kinda feel some other bindings/API could be needed) * KPackageView: is a qquickview that loads kpackages... seeing that the direction from Qt of using ApplicationWindow as root item makes me a bit unsure wether to add this tough Diffs - src/kdeclarative/qmlobject.h a0a74d3 src/kdeclarative/qmlobject.cpp 00478b4 src/kpackagelauncherqml/CMakeLists.txt PRE-CREATION src/kpackagelauncherqml/main.cpp PRE-CREATION src/quickaddons/CMakeLists.txt 8272f1f tests/CMakeLists.txt a8abfaf tests/helloworld/contents/ui/main.qml PRE-CREATION tests/helloworld/metadata.desktop PRE-CREATION tests/helloworldnowindow/contents/ui/main.qml PRE-CREATION tests/helloworldnowindow/metadata.desktop PRE-CREATION CMakeLists.txt 52a698a src/CMakeLists.txt 32da8a5 src/kdeclarative/CMakeLists.txt 052b9e2 Diff: https://git.reviewboard.kde.org/r/122667/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122667: Some tools for easily do qml based apps using KPackage
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122667/ --- (Updated March 3, 2015, 10:14 a.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- This is still a bit rough but adding it there for early feedback. comes from the fact that I would like a standard-ish way for KDE apps to do QML based apps It adds 3 things: * KPackage support to QmlObject: the class is done to easily load QML without using qquickview, since I want to push loading qml from KPackages, adding kpackage support to this class seems to make sense * qmlpackagelauncher: tiny tool to launch qml apps from qml packages: supports both the case the root object is a qquickitem or an ApplicationWindow qtquickcomponent(that is a window in itself) puts proper window title and icon, sets the kaboutdata from the metadata file, binds commandline arguments in the context (kinda feel some other bindings/API could be needed) * KPackageView: is a qquickview that loads kpackages... seeing that the direction from Qt of using ApplicationWindow as root item makes me a bit unsure wether to add this tough Diffs (updated) - CMakeLists.txt 52a698a src/CMakeLists.txt 32da8a5 src/kdeclarative/CMakeLists.txt 052b9e2 src/kdeclarative/qmlobject.h a0a74d3 src/kdeclarative/qmlobject.cpp 00478b4 src/kpackagelauncherqml/CMakeLists.txt PRE-CREATION src/kpackagelauncherqml/main.cpp PRE-CREATION src/quickaddons/CMakeLists.txt 8272f1f tests/CMakeLists.txt a8abfaf tests/helloworld/contents/ui/main.qml PRE-CREATION tests/helloworld/metadata.desktop PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122667/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122667: Some tools for easily do qml based apps using KPackage
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122667/ --- (Updated March 3, 2015, 7:29 p.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- This is still a bit rough but adding it there for early feedback. comes from the fact that I would like a standard-ish way for KDE apps to do QML based apps It adds 3 things: * KPackage support to QmlObject: the class is done to easily load QML without using qquickview, since I want to push loading qml from KPackages, adding kpackage support to this class seems to make sense * qmlpackagelauncher: tiny tool to launch qml apps from qml packages: supports both the case the root object is a qquickitem or an ApplicationWindow qtquickcomponent(that is a window in itself) puts proper window title and icon, sets the kaboutdata from the metadata file, binds commandline arguments in the context (kinda feel some other bindings/API could be needed) * KPackageView: is a qquickview that loads kpackages... seeing that the direction from Qt of using ApplicationWindow as root item makes me a bit unsure wether to add this tough Diffs (updated) - src/kdeclarative/qmlobject.h a0a74d3 src/kdeclarative/qmlobject.cpp 00478b4 src/kpackagelauncherqml/CMakeLists.txt PRE-CREATION src/kpackagelauncherqml/main.cpp PRE-CREATION src/quickaddons/CMakeLists.txt 8272f1f tests/CMakeLists.txt a8abfaf tests/helloworld/contents/ui/main.qml PRE-CREATION tests/helloworld/metadata.desktop PRE-CREATION tests/helloworldnowindow/contents/ui/main.qml PRE-CREATION tests/helloworldnowindow/metadata.desktop PRE-CREATION CMakeLists.txt 52a698a src/CMakeLists.txt 32da8a5 src/kdeclarative/CMakeLists.txt 052b9e2 Diff: https://git.reviewboard.kde.org/r/122667/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122667: Some tools for easily do qml based apps using KPackage
On March 3, 2015, 5:46 p.m., David Edmundson wrote: src/kpackagelauncherqml/main.cpp, line 99 https://git.reviewboard.kde.org/r/122667/diff/3/?file=352798#file352798line99 returning here is weird. ah, you do it because otherwise the QQuickWindow would be out of scope. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122667/#review76958 --- On March 3, 2015, 6:10 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122667/ --- (Updated March 3, 2015, 6:10 p.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- This is still a bit rough but adding it there for early feedback. comes from the fact that I would like a standard-ish way for KDE apps to do QML based apps It adds 3 things: * KPackage support to QmlObject: the class is done to easily load QML without using qquickview, since I want to push loading qml from KPackages, adding kpackage support to this class seems to make sense * qmlpackagelauncher: tiny tool to launch qml apps from qml packages: supports both the case the root object is a qquickitem or an ApplicationWindow qtquickcomponent(that is a window in itself) puts proper window title and icon, sets the kaboutdata from the metadata file, binds commandline arguments in the context (kinda feel some other bindings/API could be needed) * KPackageView: is a qquickview that loads kpackages... seeing that the direction from Qt of using ApplicationWindow as root item makes me a bit unsure wether to add this tough Diffs - CMakeLists.txt 52a698a src/CMakeLists.txt 32da8a5 src/kdeclarative/CMakeLists.txt 052b9e2 src/kdeclarative/qmlobject.h a0a74d3 src/kdeclarative/qmlobject.cpp 00478b4 src/kpackagelauncherqml/CMakeLists.txt PRE-CREATION src/kpackagelauncherqml/main.cpp PRE-CREATION src/quickaddons/CMakeLists.txt 8272f1f tests/CMakeLists.txt a8abfaf tests/helloworld/contents/ui/main.qml PRE-CREATION tests/helloworld/metadata.desktop PRE-CREATION tests/helloworldnowindow/contents/ui/main.qml PRE-CREATION tests/helloworldnowindow/metadata.desktop PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122667/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122667: Some tools for easily do qml based apps using KPackage
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122667/ --- (Updated March 3, 2015, 6:10 p.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- This is still a bit rough but adding it there for early feedback. comes from the fact that I would like a standard-ish way for KDE apps to do QML based apps It adds 3 things: * KPackage support to QmlObject: the class is done to easily load QML without using qquickview, since I want to push loading qml from KPackages, adding kpackage support to this class seems to make sense * qmlpackagelauncher: tiny tool to launch qml apps from qml packages: supports both the case the root object is a qquickitem or an ApplicationWindow qtquickcomponent(that is a window in itself) puts proper window title and icon, sets the kaboutdata from the metadata file, binds commandline arguments in the context (kinda feel some other bindings/API could be needed) * KPackageView: is a qquickview that loads kpackages... seeing that the direction from Qt of using ApplicationWindow as root item makes me a bit unsure wether to add this tough Diffs (updated) - CMakeLists.txt 52a698a src/CMakeLists.txt 32da8a5 src/kdeclarative/CMakeLists.txt 052b9e2 src/kdeclarative/qmlobject.h a0a74d3 src/kdeclarative/qmlobject.cpp 00478b4 src/kpackagelauncherqml/CMakeLists.txt PRE-CREATION src/kpackagelauncherqml/main.cpp PRE-CREATION src/quickaddons/CMakeLists.txt 8272f1f tests/CMakeLists.txt a8abfaf tests/helloworld/contents/ui/main.qml PRE-CREATION tests/helloworld/metadata.desktop PRE-CREATION tests/helloworldnowindow/contents/ui/main.qml PRE-CREATION tests/helloworldnowindow/metadata.desktop PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122667/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122667: Some tools for easily do qml based apps using KPackage
On March 3, 2015, 5:46 p.m., David Edmundson wrote: src/kpackagelauncherqml/main.cpp, line 80 https://git.reviewboard.kde.org/r/122667/diff/3/?file=352798#file352798line80 we load this, we set the authors then don't do anything with it? Is it used implicitly? Marco Martin wrote: yeah, i could disable it for now.. I was thinking about exporting it to the qml context somehow, but then didn't decide yet how to use it. (doing a standard kde about dialog would link to kxmlgui that meh, just having data available to the context I'm not sure how much then applications would use it) David Edmundson wrote: There's a KAboutData::setApplicationData that sets up all the methods on QApplication, sounds perfect I think. yeah, good point (done). would still need a c++ import to access any of that, but at least is possible to access. - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122667/#review76958 --- On March 3, 2015, 7:29 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122667/ --- (Updated March 3, 2015, 7:29 p.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- This is still a bit rough but adding it there for early feedback. comes from the fact that I would like a standard-ish way for KDE apps to do QML based apps It adds 3 things: * KPackage support to QmlObject: the class is done to easily load QML without using qquickview, since I want to push loading qml from KPackages, adding kpackage support to this class seems to make sense * qmlpackagelauncher: tiny tool to launch qml apps from qml packages: supports both the case the root object is a qquickitem or an ApplicationWindow qtquickcomponent(that is a window in itself) puts proper window title and icon, sets the kaboutdata from the metadata file, binds commandline arguments in the context (kinda feel some other bindings/API could be needed) * KPackageView: is a qquickview that loads kpackages... seeing that the direction from Qt of using ApplicationWindow as root item makes me a bit unsure wether to add this tough Diffs - src/kdeclarative/qmlobject.h a0a74d3 src/kdeclarative/qmlobject.cpp 00478b4 src/kpackagelauncherqml/CMakeLists.txt PRE-CREATION src/kpackagelauncherqml/main.cpp PRE-CREATION src/quickaddons/CMakeLists.txt 8272f1f tests/CMakeLists.txt a8abfaf tests/helloworld/contents/ui/main.qml PRE-CREATION tests/helloworld/metadata.desktop PRE-CREATION tests/helloworldnowindow/contents/ui/main.qml PRE-CREATION tests/helloworldnowindow/metadata.desktop PRE-CREATION CMakeLists.txt 52a698a src/CMakeLists.txt 32da8a5 src/kdeclarative/CMakeLists.txt 052b9e2 Diff: https://git.reviewboard.kde.org/r/122667/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122667: Some tools for easily do qml based apps using KPackage
On March 3, 2015, 5:46 p.m., David Edmundson wrote: src/kpackagelauncherqml/main.cpp, line 80 https://git.reviewboard.kde.org/r/122667/diff/3/?file=352798#file352798line80 we load this, we set the authors then don't do anything with it? Is it used implicitly? Marco Martin wrote: yeah, i could disable it for now.. I was thinking about exporting it to the qml context somehow, but then didn't decide yet how to use it. (doing a standard kde about dialog would link to kxmlgui that meh, just having data available to the context I'm not sure how much then applications would use it) There's a KAboutData::setApplicationData that sets up all the methods on QApplication, sounds perfect I think. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122667/#review76958 --- On March 3, 2015, 6:10 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122667/ --- (Updated March 3, 2015, 6:10 p.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- This is still a bit rough but adding it there for early feedback. comes from the fact that I would like a standard-ish way for KDE apps to do QML based apps It adds 3 things: * KPackage support to QmlObject: the class is done to easily load QML without using qquickview, since I want to push loading qml from KPackages, adding kpackage support to this class seems to make sense * qmlpackagelauncher: tiny tool to launch qml apps from qml packages: supports both the case the root object is a qquickitem or an ApplicationWindow qtquickcomponent(that is a window in itself) puts proper window title and icon, sets the kaboutdata from the metadata file, binds commandline arguments in the context (kinda feel some other bindings/API could be needed) * KPackageView: is a qquickview that loads kpackages... seeing that the direction from Qt of using ApplicationWindow as root item makes me a bit unsure wether to add this tough Diffs - CMakeLists.txt 52a698a src/CMakeLists.txt 32da8a5 src/kdeclarative/CMakeLists.txt 052b9e2 src/kdeclarative/qmlobject.h a0a74d3 src/kdeclarative/qmlobject.cpp 00478b4 src/kpackagelauncherqml/CMakeLists.txt PRE-CREATION src/kpackagelauncherqml/main.cpp PRE-CREATION src/quickaddons/CMakeLists.txt 8272f1f tests/CMakeLists.txt a8abfaf tests/helloworld/contents/ui/main.qml PRE-CREATION tests/helloworld/metadata.desktop PRE-CREATION tests/helloworldnowindow/contents/ui/main.qml PRE-CREATION tests/helloworldnowindow/metadata.desktop PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122667/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122667: Some tools for easily do qml based apps using KPackage
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122667/#review76958 --- src/kdeclarative/qmlobject.h https://git.reviewboard.kde.org/r/122667/#comment52937 typo src/kdeclarative/qmlobject.cpp https://git.reviewboard.kde.org/r/122667/#comment52938 question, where does KPackage/GenericQML come from? src/kpackagelauncherqml/main.cpp https://git.reviewboard.kde.org/r/122667/#comment52939 leaks. not that important as we want it to have the lifespan of the program, but it'll show up in valgrind logs. src/kpackagelauncherqml/main.cpp https://git.reviewboard.kde.org/r/122667/#comment52940 we load this, we set the authors then don't do anything with it? Is it used implicitly? src/kpackagelauncherqml/main.cpp https://git.reviewboard.kde.org/r/122667/#comment52944 I think one should go with implicit size if valid first? src/kpackagelauncherqml/main.cpp https://git.reviewboard.kde.org/r/122667/#comment52941 returning here is weird. src/kpackagelauncherqml/main.cpp https://git.reviewboard.kde.org/r/122667/#comment52943 if the root item is a QObject (which is valid, ableit odd) we just pause doing nothing with no feedback. tests/helloworld/contents/ui/main.qml https://git.reviewboard.kde.org/r/122667/#comment52942 A test where the main item isn't a window might be good. - David Edmundson On March 3, 2015, 10:14 a.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122667/ --- (Updated March 3, 2015, 10:14 a.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- This is still a bit rough but adding it there for early feedback. comes from the fact that I would like a standard-ish way for KDE apps to do QML based apps It adds 3 things: * KPackage support to QmlObject: the class is done to easily load QML without using qquickview, since I want to push loading qml from KPackages, adding kpackage support to this class seems to make sense * qmlpackagelauncher: tiny tool to launch qml apps from qml packages: supports both the case the root object is a qquickitem or an ApplicationWindow qtquickcomponent(that is a window in itself) puts proper window title and icon, sets the kaboutdata from the metadata file, binds commandline arguments in the context (kinda feel some other bindings/API could be needed) * KPackageView: is a qquickview that loads kpackages... seeing that the direction from Qt of using ApplicationWindow as root item makes me a bit unsure wether to add this tough Diffs - CMakeLists.txt 52a698a src/CMakeLists.txt 32da8a5 src/kdeclarative/CMakeLists.txt 052b9e2 src/kdeclarative/qmlobject.h a0a74d3 src/kdeclarative/qmlobject.cpp 00478b4 src/kpackagelauncherqml/CMakeLists.txt PRE-CREATION src/kpackagelauncherqml/main.cpp PRE-CREATION src/quickaddons/CMakeLists.txt 8272f1f tests/CMakeLists.txt a8abfaf tests/helloworld/contents/ui/main.qml PRE-CREATION tests/helloworld/metadata.desktop PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122667/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122667: Some tools for easily do qml based apps using KPackage
On Feb. 23, 2015, 12:08 p.m., Marco Martin wrote: I like where this is going! :) Marco Martin wrote: One thing i'm still not sure is what to export to it. it now sets the application commandline arguments, that's not really possible to obtain otherwise. Another thing would probably be the kaboutdata, which now is constructing one but not really doing anything with it. I would like to have an easy way to automatically have the various about application/about kde dialogs there too, even tough not depending from kxmlgui, but don't really know a clean way to do it atm I agree that being able to define the KAboutData would be interesting eventually. It's probably out of scope for this patch. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122667/#review76459 --- On Feb. 25, 2015, 10:29 a.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122667/ --- (Updated Feb. 25, 2015, 10:29 a.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- This is still a bit rough but adding it there for early feedback. comes from the fact that I would like a standard-ish way for KDE apps to do QML based apps It adds 3 things: * KPackage support to QmlObject: the class is done to easily load QML without using qquickview, since I want to push loading qml from KPackages, adding kpackage support to this class seems to make sense * qmlpackagelauncher: tiny tool to launch qml apps from qml packages: supports both the case the root object is a qquickitem or an ApplicationWindow qtquickcomponent(that is a window in itself) puts proper window title and icon, sets the kaboutdata from the metadata file, binds commandline arguments in the context (kinda feel some other bindings/API could be needed) * KPackageView: is a qquickview that loads kpackages... seeing that the direction from Qt of using ApplicationWindow as root item makes me a bit unsure wether to add this tough Diffs - CMakeLists.txt 52a698a src/CMakeLists.txt 32da8a5 src/kdeclarative/CMakeLists.txt 052b9e2 src/kdeclarative/qmlobject.h a0a74d3 src/kdeclarative/qmlobject.cpp 00478b4 src/kpackagelauncherqml/CMakeLists.txt PRE-CREATION src/kpackagelauncherqml/main.cpp PRE-CREATION src/quickaddons/CMakeLists.txt 8272f1f tests/CMakeLists.txt a8abfaf tests/helloworld/contents/ui/main.qml PRE-CREATION tests/helloworld/metadata.desktop PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122667/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122667: Some tools for easily do qml based apps using KPackage
On Feb. 23, 2015, 11:08 a.m., Marco Martin wrote: I like where this is going! :) Marco Martin wrote: One thing i'm still not sure is what to export to it. it now sets the application commandline arguments, that's not really possible to obtain otherwise. Another thing would probably be the kaboutdata, which now is constructing one but not really doing anything with it. I would like to have an easy way to automatically have the various about application/about kde dialogs there too, even tough not depending from kxmlgui, but don't really know a clean way to do it atm Aleix Pol Gonzalez wrote: I agree that being able to define the KAboutData would be interesting eventually. It's probably out of scope for this patch. well, it already creates a KAboutData, just that it doesn't use it.. since commandline parameters (even tough in a dynamic fashion could be done only in a very primitive fashion) would be needed from the get go, so a nice expandable interface wit hthe qml part would probably be nice - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122667/#review76459 --- On Feb. 25, 2015, 9:29 a.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122667/ --- (Updated Feb. 25, 2015, 9:29 a.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- This is still a bit rough but adding it there for early feedback. comes from the fact that I would like a standard-ish way for KDE apps to do QML based apps It adds 3 things: * KPackage support to QmlObject: the class is done to easily load QML without using qquickview, since I want to push loading qml from KPackages, adding kpackage support to this class seems to make sense * qmlpackagelauncher: tiny tool to launch qml apps from qml packages: supports both the case the root object is a qquickitem or an ApplicationWindow qtquickcomponent(that is a window in itself) puts proper window title and icon, sets the kaboutdata from the metadata file, binds commandline arguments in the context (kinda feel some other bindings/API could be needed) * KPackageView: is a qquickview that loads kpackages... seeing that the direction from Qt of using ApplicationWindow as root item makes me a bit unsure wether to add this tough Diffs - CMakeLists.txt 52a698a src/CMakeLists.txt 32da8a5 src/kdeclarative/CMakeLists.txt 052b9e2 src/kdeclarative/qmlobject.h a0a74d3 src/kdeclarative/qmlobject.cpp 00478b4 src/kpackagelauncherqml/CMakeLists.txt PRE-CREATION src/kpackagelauncherqml/main.cpp PRE-CREATION src/quickaddons/CMakeLists.txt 8272f1f tests/CMakeLists.txt a8abfaf tests/helloworld/contents/ui/main.qml PRE-CREATION tests/helloworld/metadata.desktop PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122667/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122667: Some tools for easily do qml based apps using KPackage
On Feb. 23, 2015, 11:08 a.m., Aleix Pol Gonzalez wrote: src/qmlpackagelauncher/CMakeLists.txt, line 8 https://git.reviewboard.kde.org/r/122667/diff/1/?file=350611#file350611line8 Maybe it would make sense to call it kpackagelauncher-qml? renamed, but without the dash that i don't like too much On Feb. 23, 2015, 11:08 a.m., Marco Martin wrote: I like where this is going! :) One thing i'm still not sure is what to export to it. it now sets the application commandline arguments, that's not really possible to obtain otherwise. Another thing would probably be the kaboutdata, which now is constructing one but not really doing anything with it. I would like to have an easy way to automatically have the various about application/about kde dialogs there too, even tough not depending from kxmlgui, but don't really know a clean way to do it atm - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122667/#review76459 --- On Feb. 25, 2015, 9:29 a.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122667/ --- (Updated Feb. 25, 2015, 9:29 a.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- This is still a bit rough but adding it there for early feedback. comes from the fact that I would like a standard-ish way for KDE apps to do QML based apps It adds 3 things: * KPackage support to QmlObject: the class is done to easily load QML without using qquickview, since I want to push loading qml from KPackages, adding kpackage support to this class seems to make sense * qmlpackagelauncher: tiny tool to launch qml apps from qml packages: supports both the case the root object is a qquickitem or an ApplicationWindow qtquickcomponent(that is a window in itself) puts proper window title and icon, sets the kaboutdata from the metadata file, binds commandline arguments in the context (kinda feel some other bindings/API could be needed) * KPackageView: is a qquickview that loads kpackages... seeing that the direction from Qt of using ApplicationWindow as root item makes me a bit unsure wether to add this tough Diffs - CMakeLists.txt 52a698a src/CMakeLists.txt 32da8a5 src/kdeclarative/CMakeLists.txt 052b9e2 src/kdeclarative/qmlobject.h a0a74d3 src/kdeclarative/qmlobject.cpp 00478b4 src/kpackagelauncherqml/CMakeLists.txt PRE-CREATION src/kpackagelauncherqml/main.cpp PRE-CREATION src/quickaddons/CMakeLists.txt 8272f1f tests/CMakeLists.txt a8abfaf tests/helloworld/contents/ui/main.qml PRE-CREATION tests/helloworld/metadata.desktop PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122667/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122667: Some tools for easily do qml based apps using KPackage
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122667/#review76459 --- src/qmlpackagelauncher/CMakeLists.txt https://git.reviewboard.kde.org/r/122667/#comment52668 Maybe it would make sense to call it kpackagelauncher-qml? src/quickaddons/kpackageview.h https://git.reviewboard.kde.org/r/122667/#comment52669 I would assume applications are using a Window/ApplicationWindow. This way the view is not needed anymore and we can have different kinds of applications. I like where this is going! :) - Aleix Pol Gonzalez On Feb. 21, 2015, 7:26 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122667/ --- (Updated Feb. 21, 2015, 7:26 p.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- This is still a bit rough but adding it there for early feedback. comes from the fact that I would like a standard-ish way for KDE apps to do QML based apps It adds 3 things: * KPackage support to QmlObject: the class is done to easily load QML without using qquickview, since I want to push loading qml from KPackages, adding kpackage support to this class seems to make sense * qmlpackagelauncher: tiny tool to launch qml apps from qml packages: supports both the case the root object is a qquickitem or an ApplicationWindow qtquickcomponent(that is a window in itself) puts proper window title and icon, sets the kaboutdata from the metadata file, binds commandline arguments in the context (kinda feel some other bindings/API could be needed) * KPackageView: is a qquickview that loads kpackages... seeing that the direction from Qt of using ApplicationWindow as root item makes me a bit unsure wether to add this tough Diffs - src/quickaddons/CMakeLists.txt 8272f1f src/quickaddons/kpackageview.h PRE-CREATION src/quickaddons/kpackageview.cpp PRE-CREATION tests/CMakeLists.txt a8abfaf tests/helloworld/contents/ui/main.qml PRE-CREATION tests/helloworld/metadata.desktop PRE-CREATION CMakeLists.txt 52a698a src/CMakeLists.txt 32da8a5 src/kdeclarative/CMakeLists.txt 052b9e2 src/kdeclarative/qmlobject.h a0a74d3 src/kdeclarative/qmlobject.cpp 00478b4 src/qmlpackagelauncher/CMakeLists.txt PRE-CREATION src/qmlpackagelauncher/main.cpp PRE-CREATION src/qmlpackagelauncher/view.h PRE-CREATION src/qmlpackagelauncher/view.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122667/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 122667: Some tools for easily do qml based apps using KPackage
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122667/ --- Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- This is still a bit rough but adding it there for early feedback. comes from the fact that I would like a standard-ish way for KDE apps to do QML based apps It adds 3 things: * KPackage support to QmlObject: the class is done to easily load QML without using qquickview, since I want to push loading qml from KPackages, adding kpackage support to this class seems to make sense * qmlpackagelauncher: tiny tool to launch qml apps from qml packages: supports both the case the root object is a qquickitem or an ApplicationWindow qtquickcomponent(that is a window in itself) puts proper window title and icon, sets the kaboutdata from the metadata file, binds commandline arguments in the context (kinda feel some other bindings/API could be needed) * KPackageView: is a qquickview that loads kpackages... seeing that the direction from Qt of using ApplicationWindow as root item makes me a bit unsure wether to add this tough Diffs - src/quickaddons/CMakeLists.txt 8272f1f src/quickaddons/kpackageview.h PRE-CREATION src/quickaddons/kpackageview.cpp PRE-CREATION tests/CMakeLists.txt a8abfaf tests/helloworld/contents/ui/main.qml PRE-CREATION tests/helloworld/metadata.desktop PRE-CREATION CMakeLists.txt 52a698a src/CMakeLists.txt 32da8a5 src/kdeclarative/CMakeLists.txt 052b9e2 src/kdeclarative/qmlobject.h a0a74d3 src/kdeclarative/qmlobject.cpp 00478b4 src/qmlpackagelauncher/CMakeLists.txt PRE-CREATION src/qmlpackagelauncher/main.cpp PRE-CREATION src/qmlpackagelauncher/view.h PRE-CREATION src/qmlpackagelauncher/view.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122667/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
