Re: Review Request 122732: Add std::function overloads for KServiceTypeTrader
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122732/#review102470 --- if it's still valid, please move it to phabricator - Marco Martin On Feb. 26, 2015, 7:44 p.m., Alex Richardson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122732/ > --- > > (Updated Feb. 26, 2015, 7:44 p.m.) > > > Review request for KDE Frameworks, Marco Martin and Sebastian Kügler. > > > Repository: kservice > > > Description > --- > > These are a lot more flexible and less error-prone and will eventually > allow us to remove the trader query language in KF6 once all users in > KService are gone. > > REVIEW: 122732 > > > Diffs > - > > autotests/kservicetest.cpp d46f868185c3bf45138d80d04f4eb0d2840de9ca > autotests/ksycocathreadtest.cpp fbd889b28a32397fbf9245827ff8b54405b82e3d > src/services/kservicetypetrader.h 8e46812c2eeddca225e978a4dd55aa4cc5e902d0 > src/services/kservicetypetrader.cpp > 290e44e9161c8db47278543714426fdd3b5a87af > > Diff: https://git.reviewboard.kde.org/r/122732/diff/ > > > Testing > --- > > Unit tests pass > > There are still some more classes that use the string based checks, I'll add > a std::function overload to them as well once this has been approved. > > > Thanks, > > Alex Richardson > >
Re: Review Request 122732: Add std::function overloads for KServiceTypeTrader
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122732/ --- (Updated Feb. 8, 2017, 3:30 p.m.) Status -- This change has been discarded. Review request for KDE Frameworks, Marco Martin and Sebastian Kügler. Repository: kservice Description --- These are a lot more flexible and less error-prone and will eventually allow us to remove the trader query language in KF6 once all users in KService are gone. REVIEW: 122732 Diffs - autotests/kservicetest.cpp d46f868185c3bf45138d80d04f4eb0d2840de9ca autotests/ksycocathreadtest.cpp fbd889b28a32397fbf9245827ff8b54405b82e3d src/services/kservicetypetrader.h 8e46812c2eeddca225e978a4dd55aa4cc5e902d0 src/services/kservicetypetrader.cpp 290e44e9161c8db47278543714426fdd3b5a87af Diff: https://git.reviewboard.kde.org/r/122732/diff/ Testing --- Unit tests pass There are still some more classes that use the string based checks, I'll add a std::function overload to them as well once this has been approved. Thanks, Alex Richardson
Re: Review Request 122732: Add std::function overloads for KServiceTypeTrader
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122732/#review102447 --- Is this still relevant? If not, please discard it... - Sebastian Kügler On Feb. 26, 2015, 7:44 p.m., Alex Richardson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122732/ > --- > > (Updated Feb. 26, 2015, 7:44 p.m.) > > > Review request for KDE Frameworks, Marco Martin and Sebastian Kügler. > > > Repository: kservice > > > Description > --- > > These are a lot more flexible and less error-prone and will eventually > allow us to remove the trader query language in KF6 once all users in > KService are gone. > > REVIEW: 122732 > > > Diffs > - > > autotests/kservicetest.cpp d46f868185c3bf45138d80d04f4eb0d2840de9ca > autotests/ksycocathreadtest.cpp fbd889b28a32397fbf9245827ff8b54405b82e3d > src/services/kservicetypetrader.h 8e46812c2eeddca225e978a4dd55aa4cc5e902d0 > src/services/kservicetypetrader.cpp > 290e44e9161c8db47278543714426fdd3b5a87af > > Diff: https://git.reviewboard.kde.org/r/122732/diff/ > > > Testing > --- > > Unit tests pass > > There are still some more classes that use the string based checks, I'll add > a std::function overload to them as well once this has been approved. > > > Thanks, > > Alex Richardson > >
Re: Review Request 122732: Add std::function overloads for KServiceTypeTrader
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122732/#review76685 --- src/services/kservicetypetrader.h https://git.reviewboard.kde.org/r/122732/#comment52817 I'll update this to use a lambda src/services/kservicetypetrader.h https://git.reviewboard.kde.org/r/122732/#comment52818 This section can probably be deleted - Alex Richardson On Feb. 26, 2015, 7:44 nachm., Alex Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122732/ --- (Updated Feb. 26, 2015, 7:44 nachm.) Review request for KDE Frameworks, Marco Martin and Sebastian Kügler. Repository: kservice Description --- These are a lot more flexible and less error-prone and will eventually allow us to remove the trader query language in KF6 once all users in KService are gone. REVIEW: 122732 Diffs - autotests/ksycocathreadtest.cpp fbd889b28a32397fbf9245827ff8b54405b82e3d autotests/kservicetest.cpp d46f868185c3bf45138d80d04f4eb0d2840de9ca src/services/kservicetypetrader.h 8e46812c2eeddca225e978a4dd55aa4cc5e902d0 src/services/kservicetypetrader.cpp 290e44e9161c8db47278543714426fdd3b5a87af Diff: https://git.reviewboard.kde.org/r/122732/diff/ Testing --- Unit tests pass There are still some more classes that use the string based checks, I'll add a std::function overload to them as well once this has been approved. Thanks, Alex Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 122732: Add std::function overloads for KServiceTypeTrader
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122732/ --- Review request for KDE Frameworks, Marco Martin and Sebastian Kügler. Repository: kservice Description --- These are a lot more flexible and less error-prone and will eventually allow us to remove the trader query language in KF6 once all users in KService are gone. REVIEW: 122732 Diffs - autotests/ksycocathreadtest.cpp fbd889b28a32397fbf9245827ff8b54405b82e3d autotests/kservicetest.cpp d46f868185c3bf45138d80d04f4eb0d2840de9ca src/services/kservicetypetrader.h 8e46812c2eeddca225e978a4dd55aa4cc5e902d0 src/services/kservicetypetrader.cpp 290e44e9161c8db47278543714426fdd3b5a87af Diff: https://git.reviewboard.kde.org/r/122732/diff/ Testing --- Unit tests pass There are still some more classes that use the string based checks, I'll add a std::function overload to them as well once this has been approved. Thanks, Alex Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
