Re: Review Request 123737: Use QTemporaryFile instead of hardcoding a temporary file
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123737/#review80313 --- Ship it! Ship It! - Aleix Pol Gonzalez On May 13, 2015, 7:13 p.m., Michael Palimaka wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123737/ --- (Updated May 13, 2015, 7:13 p.m.) Review request for KDE Frameworks. Repository: kdelibs4support Description --- Hardcoding files like this seems like a bad idea. Also updates the source URL to something fetchable. This also affects kdelibs. Diffs - tests/netaccesstest.cpp a06b49d015fe420fd0293292041caa988422f521 Diff: https://git.reviewboard.kde.org/r/123737/diff/ Testing --- Test still passes on Linux. Can't test on Windows. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123737: Use QTemporaryFile instead of hardcoding a temporary file
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123737/ --- (Updated May 13, 2015, 5:26 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit b87835cc7bdf869624b77fea7e6b7b0526c33ec6 by Michael Palimaka to branch master. Repository: kdelibs4support Description --- Hardcoding files like this seems like a bad idea. Also updates the source URL to something fetchable. This also affects kdelibs. Diffs - tests/netaccesstest.cpp a06b49d015fe420fd0293292041caa988422f521 Diff: https://git.reviewboard.kde.org/r/123737/diff/ Testing --- Test still passes on Linux. Can't test on Windows. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123737: Use QTemporaryFile instead of hardcoding a temporary file
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123737/ --- (Updated May 13, 2015, 5:13 p.m.) Review request for KDE Frameworks. Changes --- Eliminate ifdefs. Repository: kdelibs4support Description --- Hardcoding files like this seems like a bad idea. Also updates the source URL to something fetchable. This also affects kdelibs. Diffs (updated) - tests/netaccesstest.cpp a06b49d015fe420fd0293292041caa988422f521 Diff: https://git.reviewboard.kde.org/r/123737/diff/ Testing --- Test still passes on Linux. Can't test on Windows. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123737: Use QTemporaryFile instead of hardcoding a temporary file
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123737/ --- (Updated May 12, 2015, 5:12 p.m.) Review request for KDE Frameworks. Summary (updated) - Use QTemporaryFile instead of hardcoding a temporary file Repository: kdelibs4support Description --- Hardcoding files like this seems like a bad idea. Also updates the source URL to something fetchable. This also affects kdelibs. Diffs - tests/netaccesstest.cpp a06b49d015fe420fd0293292041caa988422f521 Diff: https://git.reviewboard.kde.org/r/123737/diff/ Testing --- Test still passes on Linux. Can't test on Windows. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123737: Use QTemporaryFile instead of hardcoding a temporary file
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123737/#review80263 --- tests/netaccesstest.cpp (line 39) https://git.reviewboard.kde.org/r/123737/#comment55059 Use QUrl::fromLocalFile and remove the ifdef. - Aleix Pol Gonzalez On May 12, 2015, 7:12 p.m., Michael Palimaka wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123737/ --- (Updated May 12, 2015, 7:12 p.m.) Review request for KDE Frameworks. Repository: kdelibs4support Description --- Hardcoding files like this seems like a bad idea. Also updates the source URL to something fetchable. This also affects kdelibs. Diffs - tests/netaccesstest.cpp a06b49d015fe420fd0293292041caa988422f521 Diff: https://git.reviewboard.kde.org/r/123737/diff/ Testing --- Test still passes on Linux. Can't test on Windows. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
