Re: Review Request 124089: Connected timeout before timer start.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124089/#review102141 --- I'm going to discard this as it seems that Jordan Hewitt did not act on David Faure's comment from more than one year ago. - Albert Astals Cid On June 12, 2015, 8:27 p.m., Jordan Hewitt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124089/ > --- > > (Updated June 12, 2015, 8:27 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kio > > > Description > --- > > Connected timeout before timer start. > > > Diffs > - > > src/widgets/krun.cpp 50660c0a0f103a03d7950aa1f65b60ff796d1825 > > Diff: https://git.reviewboard.kde.org/r/124089/diff/ > > > Testing > --- > > > Thanks, > > Jordan Hewitt > >
Re: Review Request 124089: Connected timeout before timer start.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124089/ --- (Updated Jan. 21, 2017, 12:53 a.m.) Status -- This change has been discarded. Review request for KDE Frameworks. Repository: kio Description --- Connected timeout before timer start. Diffs - src/widgets/krun.cpp 50660c0a0f103a03d7950aa1f65b60ff796d1825 Diff: https://git.reviewboard.kde.org/r/124089/diff/ Testing --- Thanks, Jordan Hewitt
Re: Review Request 124089: Connected timeout before timer start.
On June 13, 2015, 7:28 p.m., David Faure wrote:
startTimer is called many times so doing the connect every time is wrong,
and the connect is already done before, so I don't understand this patch.
What problem is it supposed to fix?
I was having an issue with Konsole on Plasma 5 (Kubuntu 15.04). When opening
links in Konsole, Konsole would freeze and the link wouldn't open. In Konsole
on Plasma 5, type out a link (like https://www.kde.org;), right click on the
link and click Open Link. Konsole will freeze. This was reproducible for me,
and--although I didn't see any other repots on the issue--I decided to
investigate it and fix it. Adding this line resolved the issue.
The initial call comes from the konsole repository in the slot
UrlFilter::HotSpot::activate. actiate() then calls new KRun(QUrl(url),
activeWindow);::
void UrlFilter::HotSpot::activate(QObject* object)
{
qDebug() Opening URL object;
QString url = capturedTexts().first();
const UrlType kind = urlType();
const QString actionName = object ? object-objectName() : QString();
if (actionName == copy-action) {
QApplication::clipboard()-setText(url);
return;
}
if (!object || actionName == open-action) {
if (kind == StandardUrl) {
// if the URL path does not include the protocol ( eg.
www.kde.org ) then
// prepend http:// ( eg. www.kde.org -- http://www.kde.org;
)
if (!url.contains(://)) {
url.prepend(http://;);
}
} else if (kind == Email) {
url.prepend(mailto:;);
}
QWidget *activeWindow = QApplication::activeWindow();
qDebug() Launching KRun with url , activeWindow;
new KRun(QUrl(url), activeWindow);
}
}
Or is the issue really in konsole? Should Konsole create a new instance of
``KRun()`` and then call ``k-init()``?
- Jordan
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124089/#review81450
---
On June 12, 2015, 8:27 p.m., Jordan He wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124089/
---
(Updated June 12, 2015, 8:27 p.m.)
Review request for KDE Frameworks.
Repository: kio
Description
---
Connected timeout before timer start.
Diffs
-
src/widgets/krun.cpp 50660c0a0f103a03d7950aa1f65b60ff796d1825
Diff: https://git.reviewboard.kde.org/r/124089/diff/
Testing
---
Thanks,
Jordan He
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124089: Connected timeout before timer start.
On June 13, 2015, 7:28 p.m., David Faure wrote:
startTimer is called many times so doing the connect every time is wrong,
and the connect is already done before, so I don't understand this patch.
What problem is it supposed to fix?
Jordan He wrote:
I was having an issue with Konsole on Plasma 5 (Kubuntu 15.04). When
opening links in Konsole, Konsole would freeze and the link wouldn't open. In
Konsole on Plasma 5, type out a link (like https://www.kde.org;), right
click on the link and click Open Link. Konsole will freeze. This was
reproducible for me, and--although I didn't see any other repots on the
issue--I decided to investigate it and fix it. Adding this line resolved the
issue.
The initial call comes from the konsole repository in the slot
UrlFilter::HotSpot::activate. actiate() then calls new KRun(QUrl(url),
activeWindow);::
void UrlFilter::HotSpot::activate(QObject* object)
{
qDebug() Opening URL object;
QString url = capturedTexts().first();
const UrlType kind = urlType();
const QString actionName = object ? object-objectName() :
QString();
if (actionName == copy-action) {
QApplication::clipboard()-setText(url);
return;
}
if (!object || actionName == open-action) {
if (kind == StandardUrl) {
// if the URL path does not include the protocol ( eg.
www.kde.org ) then
// prepend http:// ( eg. www.kde.org --
http://www.kde.org; )
if (!url.contains(://)) {
url.prepend(http://;);
}
} else if (kind == Email) {
url.prepend(mailto:;);
}
QWidget *activeWindow = QApplication::activeWindow();
qDebug() Launching KRun with url ,
activeWindow;
new KRun(QUrl(url), activeWindow);
}
}
Or is the issue really in konsole? Should Konsole create a new instance
of ``KRun()`` and then call ``k-init()``?
new KRun is the correct way to use KRun with a URL.
(The string concatenation in this code, to make up the URL, will break with
special chars and should use KUriFilters, but that's orthogonal).
The KRun constructor calls d-init(), which starts m_timer and connects it to
slotTimeout, which the first time, calls KRun::init().
So if this doesn't work correctly in konsole, it must mean that konsole isn't
going back to the event loop (so that initial timer can't run). Attach gdb to
it to confirm/deny this hypothesis. Otherwise add debug statements within KRun
to confirm/deny the various calls I describe above.
- David
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124089/#review81450
---
On June 12, 2015, 8:27 p.m., Jordan He wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124089/
---
(Updated June 12, 2015, 8:27 p.m.)
Review request for KDE Frameworks.
Repository: kio
Description
---
Connected timeout before timer start.
Diffs
-
src/widgets/krun.cpp 50660c0a0f103a03d7950aa1f65b60ff796d1825
Diff: https://git.reviewboard.kde.org/r/124089/diff/
Testing
---
Thanks,
Jordan He
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124089: Connected timeout before timer start.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124089/#review81450 --- startTimer is called many times so doing the connect every time is wrong, and the connect is already done before, so I don't understand this patch. What problem is it supposed to fix? - David Faure On June 12, 2015, 8:27 p.m., Jordan He wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124089/ --- (Updated June 12, 2015, 8:27 p.m.) Review request for KDE Frameworks. Repository: kio Description --- Connected timeout before timer start. Diffs - src/widgets/krun.cpp 50660c0a0f103a03d7950aa1f65b60ff796d1825 Diff: https://git.reviewboard.kde.org/r/124089/diff/ Testing --- Thanks, Jordan He ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 124089: Connected timeout before timer start.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124089/ --- Review request for KDE Frameworks. Repository: kio Description --- Connected timeout before timer start. Diffs - src/widgets/krun.cpp 50660c0a0f103a03d7950aa1f65b60ff796d1825 Diff: https://git.reviewboard.kde.org/r/124089/diff/ Testing --- Thanks, Jordan He ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124089: Connected timeout before timer start.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124089/#review81427 --- Ship it! Ship It! - Jordan He On June 12, 2015, 8:27 p.m., Jordan He wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124089/ --- (Updated June 12, 2015, 8:27 p.m.) Review request for KDE Frameworks. Repository: kio Description --- Connected timeout before timer start. Diffs - src/widgets/krun.cpp 50660c0a0f103a03d7950aa1f65b60ff796d1825 Diff: https://git.reviewboard.kde.org/r/124089/diff/ Testing --- Thanks, Jordan He ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124089: Connected timeout before timer start.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124089/#review81429 --- src/widgets/krun.cpp (line 99) https://git.reviewboard.kde.org/r/124089/#comment55801 New connect syntax maybe? Also, please don't give a Ship It to yourself, that's for the maintainers. - Kai Uwe Broulik On Juni 12, 2015, 8:27 nachm., Jordan He wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124089/ --- (Updated Juni 12, 2015, 8:27 nachm.) Review request for KDE Frameworks. Repository: kio Description --- Connected timeout before timer start. Diffs - src/widgets/krun.cpp 50660c0a0f103a03d7950aa1f65b60ff796d1825 Diff: https://git.reviewboard.kde.org/r/124089/diff/ Testing --- Thanks, Jordan He ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124089: Connected timeout before timer start.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124089/#review81433 --- src/widgets/krun.cpp (line 859) https://git.reviewboard.kde.org/r/124089/#comment55804 it happens here, just before a startTimer. In this code path at least you're now connecting twice. - David Edmundson On June 12, 2015, 8:27 p.m., Jordan He wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124089/ --- (Updated June 12, 2015, 8:27 p.m.) Review request for KDE Frameworks. Repository: kio Description --- Connected timeout before timer start. Diffs - src/widgets/krun.cpp 50660c0a0f103a03d7950aa1f65b60ff796d1825 Diff: https://git.reviewboard.kde.org/r/124089/diff/ Testing --- Thanks, Jordan He ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
