Re: Review Request 124101: Reenable support for KDateTime streaming to kDebug/qDebug, for more SC
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124101/ --- (Updated June 17, 2015, 10:42 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit bcad4105178086b09c6b80014377fc79fdf558b2 by Friedrich W. H. Kossebau to branch master. Repository: kdelibs4support Description --- When porting code to KF5 while using kdelibs4support, `kDebug() someKDateTimeObject;` will not build. Because for some undocumented reason (at least in current repo, did not investigate further) `QDebug operator(QDebug s, const KDateTime time);` had been disabled. I could not see any problems after reenabling it again. So would propose to do it for everyone, to make kdelibs4support a tiny bit more source-compatible for kdelibs4-using code :) Diffs - src/kdecore/kdebug.h ff7607f src/kdecore/kdebug.cpp 2705ec9 Diff: https://git.reviewboard.kde.org/r/124101/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124101: Reenable support for KDateTime streaming to kDebug/qDebug, for more SC
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124101/#review81521 --- Ship it! Yes. I think it was disabled while moving stuff around into different repos, at some point kdebug must have moved before kdatetime. - David Faure On June 15, 2015, 11:01 a.m., Friedrich W. H. Kossebau wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124101/ --- (Updated June 15, 2015, 11:01 a.m.) Review request for KDE Frameworks. Repository: kdelibs4support Description --- When porting code to KF5 while using kdelibs4support, `kDebug() someKDateTimeObject;` will not build. Because for some undocumented reason (at least in current repo, did not investigate further) `QDebug operator(QDebug s, const KDateTime time);` had been disabled. I could not see any problems after reenabling it again. So would propose to do it for everyone, to make kdelibs4support a tiny bit more source-compatible for kdelibs4-using code :) Diffs - src/kdecore/kdebug.h ff7607f src/kdecore/kdebug.cpp 2705ec9 Diff: https://git.reviewboard.kde.org/r/124101/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 124101: Reenable support for KDateTime streaming to kDebug/qDebug, for more SC
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124101/ --- Review request for KDE Frameworks. Repository: kdelibs4support Description --- When porting code to KF5 while using kdelibs4support, `kDebug() someKDateTimeObject;` will not build. Because for some undocumented reason (at least in current repo, did not investigate further) `QDebug operator(QDebug s, const KDateTime time);` had been disabled. I could not see any problems after reenabling it again. So would propose to do it for everyone, to make kdelibs4support a tiny bit more source-compatible for kdelibs4-using code :) Diffs - src/kdecore/kdebug.h ff7607f src/kdecore/kdebug.cpp 2705ec9 Diff: https://git.reviewboard.kde.org/r/124101/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
