Re: Review Request 124306: Don't choke on empty QIconItem
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124306/ --- (Updated July 15, 2015, 3:24 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 78b455d447c14d782b8a7fcf01ea122a98f40edc by Aleix Pol to branch master. Repository: kdeclarative Description --- Sometimes QML components have 0 width and height and that's perfectly fine. If we try to paint it, we get warnings such as: `QPainter::begin: Paint device returned engine == 0, type: 2` Diffs - src/qmlcontrols/kquickcontrolsaddons/qiconitem.cpp 3a9dd17 Diff: https://git.reviewboard.kde.org/r/124306/diff/ Testing --- Fixes the issue in muon-discover, doesn't break tests. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124306: Don't choke on empty QIconItem
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124306/#review82278 --- Ship it! it would be more performant to delete the node if it's empty. though this is still fine. - David Edmundson On July 9, 2015, 2:07 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124306/ --- (Updated July 9, 2015, 2:07 p.m.) Review request for KDE Frameworks. Repository: kdeclarative Description --- Sometimes QML components have 0 width and height and that's perfectly fine. If we try to paint it, we get warnings such as: `QPainter::begin: Paint device returned engine == 0, type: 2` Diffs - src/qmlcontrols/kquickcontrolsaddons/qiconitem.cpp 3a9dd17 Diff: https://git.reviewboard.kde.org/r/124306/diff/ Testing --- Fixes the issue in muon-discover, doesn't break tests. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124306: Don't choke on empty QIconItem
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124306/#review82271 --- src/qmlcontrols/kquickcontrolsaddons/qiconitem.cpp (line 137) https://git.reviewboard.kde.org/r/124306/#comment56650 (nitpick) a missing sace. img = m_... +1 - Mark Gaiser On jul 9, 2015, 2:07 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124306/ --- (Updated jul 9, 2015, 2:07 p.m.) Review request for KDE Frameworks. Repository: kdeclarative Description --- Sometimes QML components have 0 width and height and that's perfectly fine. If we try to paint it, we get warnings such as: `QPainter::begin: Paint device returned engine == 0, type: 2` Diffs - src/qmlcontrols/kquickcontrolsaddons/qiconitem.cpp 3a9dd17 Diff: https://git.reviewboard.kde.org/r/124306/diff/ Testing --- Fixes the issue in muon-discover, doesn't break tests. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124306: Don't choke on empty QIconItem
On jul 9, 2015, 2:22 p.m., Mark Gaiser wrote: src/qmlcontrols/kquickcontrolsaddons/qiconitem.cpp, line 138 https://git.reviewboard.kde.org/r/124306/diff/1/?file=383903#file383903line138 (nitpick) a missing sace. img = m_... space* - Mark --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124306/#review82271 --- On jul 9, 2015, 2:07 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124306/ --- (Updated jul 9, 2015, 2:07 p.m.) Review request for KDE Frameworks. Repository: kdeclarative Description --- Sometimes QML components have 0 width and height and that's perfectly fine. If we try to paint it, we get warnings such as: `QPainter::begin: Paint device returned engine == 0, type: 2` Diffs - src/qmlcontrols/kquickcontrolsaddons/qiconitem.cpp 3a9dd17 Diff: https://git.reviewboard.kde.org/r/124306/diff/ Testing --- Fixes the issue in muon-discover, doesn't break tests. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124306: Don't choke on empty QIconItem
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124306/#review82276 --- Ship it! Ship It! - Sebastian Kügler On July 9, 2015, 2:07 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124306/ --- (Updated July 9, 2015, 2:07 p.m.) Review request for KDE Frameworks. Repository: kdeclarative Description --- Sometimes QML components have 0 width and height and that's perfectly fine. If we try to paint it, we get warnings such as: `QPainter::begin: Paint device returned engine == 0, type: 2` Diffs - src/qmlcontrols/kquickcontrolsaddons/qiconitem.cpp 3a9dd17 Diff: https://git.reviewboard.kde.org/r/124306/diff/ Testing --- Fixes the issue in muon-discover, doesn't break tests. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
