Re: Review Request 124696: Fix (worrying) MSVC warning
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124696/ --- (Updated Aug. 11, 2015, 1:22 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Mirko Boehm. Changes --- Submitted with commit ea52fb68bad35c91ed2cb39dc8cd0aeeea2f4f48 by Kevin Funk to branch master. Repository: threadweaver Description --- Warning: Z:\kderoot\download\git\threadweaver\src\iddecorator.cpp(196): warning C4312: 'r einterpret_cast': conversion from 'const int' to 'ThreadWeaver::IdDecorator::Pri vate2 *' of greater size Diffs - src/iddecorator.cpp 5bf6d002eb2671a02f330cd3022e0692a0343fe4 Diff: https://git.reviewboard.kde.org/r/124696/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 124696: Fix (worrying) MSVC warning
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124696/ --- Review request for KDE Frameworks and Mirko Boehm. Repository: threadweaver Description --- Warning: Z:\kderoot\download\git\threadweaver\src\iddecorator.cpp(196): warning C4312: 'r einterpret_cast': conversion from 'const int' to 'ThreadWeaver::IdDecorator::Pri vate2 *' of greater size Diffs - src/iddecorator.cpp 5bf6d002eb2671a02f330cd3022e0692a0343fe4 Diff: https://git.reviewboard.kde.org/r/124696/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124696: Fix (worrying) MSVC warning
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124696/#review83699 --- Ship it! src/iddecorator.cpp (line 36) https://git.reviewboard.kde.org/r/124696/#comment57929 while at it: make static or wrap in anonymous namespace (in a separate commit?) - Milian Wolff On Aug. 11, 2015, 11 a.m., Kevin Funk wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124696/ --- (Updated Aug. 11, 2015, 11 a.m.) Review request for KDE Frameworks and Mirko Boehm. Repository: threadweaver Description --- Warning: Z:\kderoot\download\git\threadweaver\src\iddecorator.cpp(196): warning C4312: 'r einterpret_cast': conversion from 'const int' to 'ThreadWeaver::IdDecorator::Pri vate2 *' of greater size Diffs - src/iddecorator.cpp 5bf6d002eb2671a02f330cd3022e0692a0343fe4 Diff: https://git.reviewboard.kde.org/r/124696/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
