Re: Review Request 125268: Fix signal-slot connections in KNewFileMenuPrivate::confirmCreatingHiddenDir(QString)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125268/ --- (Updated Sept. 16, 2015, 9:01 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit 689fd43ae226ad026dd2fb6e198a5fef40c24b13 by Frank Reininghaus to branch master. Bugs: 352770 https://bugs.kde.org/show_bug.cgi?id=352770 Repository: kio Description --- Currently, the buttons in the dialog that is shown when trying to create a hidden directory (e.g., by pressing F10 in Dolphin and then entering a name that starts with a dot) do not work. This is because the slots are connected to the 'accepted' and 'rejected' signals of the QDialog. Actually, these signals are emitted by the QDialogButtonBox. Diffs - src/filewidgets/knewfilemenu.cpp 2e8f9c6 Diff: https://git.reviewboard.kde.org/r/125268/diff/ Testing --- Both buttons in the dialog work now: it is possible to create hidden directories, and it is also possible to choose a new name. Thanks, Frank Reininghaus ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125268: Fix signal-slot connections in KNewFileMenuPrivate::confirmCreatingHiddenDir(QString)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125268/#review85515 --- Ship it! Ship It! - David Faure On Sept. 16, 2015, 8:22 p.m., Frank Reininghaus wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125268/ > --- > > (Updated Sept. 16, 2015, 8:22 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Bugs: 352770 > https://bugs.kde.org/show_bug.cgi?id=352770 > > > Repository: kio > > > Description > --- > > Currently, the buttons in the dialog that is shown when trying to create a > hidden directory (e.g., by pressing F10 in Dolphin and then entering a name > that starts with a dot) do not work. This is because the slots are connected > to the 'accepted' and 'rejected' signals of the QDialog. Actually, these > signals are emitted by the QDialogButtonBox. > > > Diffs > - > > src/filewidgets/knewfilemenu.cpp 2e8f9c6 > > Diff: https://git.reviewboard.kde.org/r/125268/diff/ > > > Testing > --- > > Both buttons in the dialog work now: it is possible to create hidden > directories, and it is also possible to choose a new name. > > > Thanks, > > Frank Reininghaus > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125268: Fix signal-slot connections in KNewFileMenuPrivate::confirmCreatingHiddenDir(QString)
> On Sept. 16, 2015, 8:43 p.m., Kai Uwe Broulik wrote: > > if you're at it you might as well use the new connect syntax, so we could > > spot things like these easier in the future. Actually it wouldn't have caught this particular issue, since both QDBB and QDialog have these signals ;) - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125268/#review85514 --- On Sept. 16, 2015, 8:22 p.m., Frank Reininghaus wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125268/ > --- > > (Updated Sept. 16, 2015, 8:22 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Bugs: 352770 > https://bugs.kde.org/show_bug.cgi?id=352770 > > > Repository: kio > > > Description > --- > > Currently, the buttons in the dialog that is shown when trying to create a > hidden directory (e.g., by pressing F10 in Dolphin and then entering a name > that starts with a dot) do not work. This is because the slots are connected > to the 'accepted' and 'rejected' signals of the QDialog. Actually, these > signals are emitted by the QDialogButtonBox. > > > Diffs > - > > src/filewidgets/knewfilemenu.cpp 2e8f9c6 > > Diff: https://git.reviewboard.kde.org/r/125268/diff/ > > > Testing > --- > > Both buttons in the dialog work now: it is possible to create hidden > directories, and it is also possible to choose a new name. > > > Thanks, > > Frank Reininghaus > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125268: Fix signal-slot connections in KNewFileMenuPrivate::confirmCreatingHiddenDir(QString)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125268/#review85514 --- if you're at it you might as well use the new connect syntax, so we could spot things like these easier in the future. - Kai Uwe Broulik On Sept. 16, 2015, 8:22 nachm., Frank Reininghaus wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125268/ > --- > > (Updated Sept. 16, 2015, 8:22 nachm.) > > > Review request for KDE Frameworks and David Faure. > > > Bugs: 352770 > https://bugs.kde.org/show_bug.cgi?id=352770 > > > Repository: kio > > > Description > --- > > Currently, the buttons in the dialog that is shown when trying to create a > hidden directory (e.g., by pressing F10 in Dolphin and then entering a name > that starts with a dot) do not work. This is because the slots are connected > to the 'accepted' and 'rejected' signals of the QDialog. Actually, these > signals are emitted by the QDialogButtonBox. > > > Diffs > - > > src/filewidgets/knewfilemenu.cpp 2e8f9c6 > > Diff: https://git.reviewboard.kde.org/r/125268/diff/ > > > Testing > --- > > Both buttons in the dialog work now: it is possible to create hidden > directories, and it is also possible to choose a new name. > > > Thanks, > > Frank Reininghaus > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 125268: Fix signal-slot connections in KNewFileMenuPrivate::confirmCreatingHiddenDir(QString)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125268/ --- Review request for KDE Frameworks and David Faure. Bugs: 352770 https://bugs.kde.org/show_bug.cgi?id=352770 Repository: kio Description --- Currently, the buttons in the dialog that is shown when trying to create a hidden directory (e.g., by pressing F10 in Dolphin and then entering a name that starts with a dot) do not work. This is because the slots are connected to the 'accepted' and 'rejected' signals of the QDialog. Actually, these signals are emitted by the QDialogButtonBox. Diffs - src/filewidgets/knewfilemenu.cpp 2e8f9c6 Diff: https://git.reviewboard.kde.org/r/125268/diff/ Testing --- Both buttons in the dialog work now: it is possible to create hidden directories, and it is also possible to choose a new name. Thanks, Frank Reininghaus ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
