Re: Review Request 125705: Use LANG for month names in calendar applet

2015-11-18 Thread Martin Klapetek 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125705/
---

(Updated Nov. 18, 2015, 5:38 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit 6f3fed77d59227a9b3ec85d343ffb2443086f7fa by Martin 
Klapetek to branch master.


Bugs: 353715
http://bugs.kde.org/show_bug.cgi?id=353715


Repository: plasma-framework


Description
---

Simple QDate::longMonthName won't do the job as it
will return the month name using LC_DATE locale which is used
for date formatting etc. So for example, in en_US locale
and cs_CZ LC_DATE, it would return Czech month names while
it should return English ones. So here we force the LANG
locale and take the month name from that.


Diffs
-

  src/declarativeimports/calendar/calendar.cpp 67a08e5 

Diff: https://git.reviewboard.kde.org/r/125705/diff/


Testing
---

LC_DATE=cs_CZ
LANG=en_US

Month names in calendar applet are now english.


Thanks,

Martin Klapetek

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125705: Use LANG for month names in calendar applet

2015-11-18 Thread David Edmundson 


> On Oct. 28, 2015, 8:44 p.m., Martin Klapetek wrote:
> > So...any word on this?
> 
> Albert Astals Cid wrote:
> Re-reading your comment, if i understand it correctly, you claim it is a 
> bug in Qt that it does obey LC_DATE for month names when according to you 
> LC_DATE is only for the formatting and should be using LANG&friends, right? 
> Why not fix it upstream then?
> 
> Martin Klapetek wrote:
> I don't claim it's a bug as I simply don't know if it's correct behavior 
> or not, just that the way it works does not suit our intended use case, 
> because we encourage our users to mess with LC_* variables through the 
> Formats KCM, which makes it prone to mixed configurations like LC_DATE=cs_CZ 
> and LANG=en_US.
> 
> But nevertheless a) David Edmundson has a patch in the works so let's see 
> if they think it's a bug and b) we'd need something for the meantime anyway.
> 
> David Edmundson wrote:
> Just uploaded: https://codereview.qt-project.org/139295
> 
> Martin Klapetek wrote:
> Given the Qt patch was rejected, I'll ship this if noone objects.

+1


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125705/#review87617
---


On Oct. 20, 2015, 7:04 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125705/
> ---
> 
> (Updated Oct. 20, 2015, 7:04 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 353715
> http://bugs.kde.org/show_bug.cgi?id=353715
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Simple QDate::longMonthName won't do the job as it
> will return the month name using LC_DATE locale which is used
> for date formatting etc. So for example, in en_US locale
> and cs_CZ LC_DATE, it would return Czech month names while
> it should return English ones. So here we force the LANG
> locale and take the month name from that.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.cpp 67a08e5 
> 
> Diff: https://git.reviewboard.kde.org/r/125705/diff/
> 
> 
> Testing
> ---
> 
> LC_DATE=cs_CZ
> LANG=en_US
> 
> Month names in calendar applet are now english.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125705: Use LANG for month names in calendar applet

2015-11-17 Thread Martin Klapetek 


> On Oct. 28, 2015, 9:44 p.m., Martin Klapetek wrote:
> > So...any word on this?
> 
> Albert Astals Cid wrote:
> Re-reading your comment, if i understand it correctly, you claim it is a 
> bug in Qt that it does obey LC_DATE for month names when according to you 
> LC_DATE is only for the formatting and should be using LANG&friends, right? 
> Why not fix it upstream then?
> 
> Martin Klapetek wrote:
> I don't claim it's a bug as I simply don't know if it's correct behavior 
> or not, just that the way it works does not suit our intended use case, 
> because we encourage our users to mess with LC_* variables through the 
> Formats KCM, which makes it prone to mixed configurations like LC_DATE=cs_CZ 
> and LANG=en_US.
> 
> But nevertheless a) David Edmundson has a patch in the works so let's see 
> if they think it's a bug and b) we'd need something for the meantime anyway.
> 
> David Edmundson wrote:
> Just uploaded: https://codereview.qt-project.org/139295

Given the Qt patch was rejected, I'll ship this if noone objects.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125705/#review87617
---


On Oct. 20, 2015, 9:04 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125705/
> ---
> 
> (Updated Oct. 20, 2015, 9:04 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 353715
> http://bugs.kde.org/show_bug.cgi?id=353715
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Simple QDate::longMonthName won't do the job as it
> will return the month name using LC_DATE locale which is used
> for date formatting etc. So for example, in en_US locale
> and cs_CZ LC_DATE, it would return Czech month names while
> it should return English ones. So here we force the LANG
> locale and take the month name from that.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.cpp 67a08e5 
> 
> Diff: https://git.reviewboard.kde.org/r/125705/diff/
> 
> 
> Testing
> ---
> 
> LC_DATE=cs_CZ
> LANG=en_US
> 
> Month names in calendar applet are now english.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125705: Use LANG for month names in calendar applet

2015-10-28 Thread David Edmundson 


> On Oct. 28, 2015, 8:44 p.m., Martin Klapetek wrote:
> > So...any word on this?
> 
> Albert Astals Cid wrote:
> Re-reading your comment, if i understand it correctly, you claim it is a 
> bug in Qt that it does obey LC_DATE for month names when according to you 
> LC_DATE is only for the formatting and should be using LANG&friends, right? 
> Why not fix it upstream then?
> 
> Martin Klapetek wrote:
> I don't claim it's a bug as I simply don't know if it's correct behavior 
> or not, just that the way it works does not suit our intended use case, 
> because we encourage our users to mess with LC_* variables through the 
> Formats KCM, which makes it prone to mixed configurations like LC_DATE=cs_CZ 
> and LANG=en_US.
> 
> But nevertheless a) David Edmundson has a patch in the works so let's see 
> if they think it's a bug and b) we'd need something for the meantime anyway.

Just uploaded: https://codereview.qt-project.org/139295


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125705/#review87617
---


On Oct. 20, 2015, 7:04 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125705/
> ---
> 
> (Updated Oct. 20, 2015, 7:04 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 353715
> http://bugs.kde.org/show_bug.cgi?id=353715
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Simple QDate::longMonthName won't do the job as it
> will return the month name using LC_DATE locale which is used
> for date formatting etc. So for example, in en_US locale
> and cs_CZ LC_DATE, it would return Czech month names while
> it should return English ones. So here we force the LANG
> locale and take the month name from that.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.cpp 67a08e5 
> 
> Diff: https://git.reviewboard.kde.org/r/125705/diff/
> 
> 
> Testing
> ---
> 
> LC_DATE=cs_CZ
> LANG=en_US
> 
> Month names in calendar applet are now english.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125705: Use LANG for month names in calendar applet

2015-10-28 Thread Martin Klapetek 


> On Oct. 28, 2015, 9:44 p.m., Martin Klapetek wrote:
> > So...any word on this?
> 
> Albert Astals Cid wrote:
> Re-reading your comment, if i understand it correctly, you claim it is a 
> bug in Qt that it does obey LC_DATE for month names when according to you 
> LC_DATE is only for the formatting and should be using LANG&friends, right? 
> Why not fix it upstream then?

I don't claim it's a bug as I simply don't know if it's correct behavior or 
not, just that the way it works does not suit our intended use case, because we 
encourage our users to mess with LC_* variables through the Formats KCM, which 
makes it prone to mixed configurations like LC_DATE=cs_CZ and LANG=en_US.

But nevertheless a) David Edmundson has a patch in the works so let's see if 
they think it's a bug and b) we'd need something for the meantime anyway.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125705/#review87617
---


On Oct. 20, 2015, 9:04 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125705/
> ---
> 
> (Updated Oct. 20, 2015, 9:04 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 353715
> http://bugs.kde.org/show_bug.cgi?id=353715
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Simple QDate::longMonthName won't do the job as it
> will return the month name using LC_DATE locale which is used
> for date formatting etc. So for example, in en_US locale
> and cs_CZ LC_DATE, it would return Czech month names while
> it should return English ones. So here we force the LANG
> locale and take the month name from that.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.cpp 67a08e5 
> 
> Diff: https://git.reviewboard.kde.org/r/125705/diff/
> 
> 
> Testing
> ---
> 
> LC_DATE=cs_CZ
> LANG=en_US
> 
> Month names in calendar applet are now english.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125705: Use LANG for month names in calendar applet

2015-10-28 Thread Albert Astals Cid 


> On oct. 28, 2015, 8:44 p.m., Martin Klapetek wrote:
> > So...any word on this?

Re-reading your comment, if i understand it correctly, you claim it is a bug in 
Qt that it does obey LC_DATE for month names when according to you LC_DATE is 
only for the formatting and should be using LANG&friends, right? Why not fix it 
upstream then?


- Albert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125705/#review87617
---


On oct. 20, 2015, 7:04 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125705/
> ---
> 
> (Updated oct. 20, 2015, 7:04 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 353715
> http://bugs.kde.org/show_bug.cgi?id=353715
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Simple QDate::longMonthName won't do the job as it
> will return the month name using LC_DATE locale which is used
> for date formatting etc. So for example, in en_US locale
> and cs_CZ LC_DATE, it would return Czech month names while
> it should return English ones. So here we force the LANG
> locale and take the month name from that.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.cpp 67a08e5 
> 
> Diff: https://git.reviewboard.kde.org/r/125705/diff/
> 
> 
> Testing
> ---
> 
> LC_DATE=cs_CZ
> LANG=en_US
> 
> Month names in calendar applet are now english.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125705: Use LANG for month names in calendar applet

2015-10-28 Thread Martin Klapetek 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125705/#review87617
---


So...any word on this?

- Martin Klapetek


On Oct. 20, 2015, 9:04 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125705/
> ---
> 
> (Updated Oct. 20, 2015, 9:04 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 353715
> http://bugs.kde.org/show_bug.cgi?id=353715
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Simple QDate::longMonthName won't do the job as it
> will return the month name using LC_DATE locale which is used
> for date formatting etc. So for example, in en_US locale
> and cs_CZ LC_DATE, it would return Czech month names while
> it should return English ones. So here we force the LANG
> locale and take the month name from that.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.cpp 67a08e5 
> 
> Diff: https://git.reviewboard.kde.org/r/125705/diff/
> 
> 
> Testing
> ---
> 
> LC_DATE=cs_CZ
> LANG=en_US
> 
> Month names in calendar applet are now english.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125705: Use LANG for month names in calendar applet

2015-10-20 Thread Xuetian Weng 


> On Oct. 20, 2015, 9:30 p.m., Albert Astals Cid wrote:
> > src/declarativeimports/calendar/calendar.cpp, line 197
> > 
> >
> > uilanguages is not good for direct inputing into QLocale (yes i know, 
> > it's stupid).
> > 
> > See how uilanguages returns en-US and QLocale wants en_US

Actually QLocale has no problem parsing things like en-US. See implementation 
https://github.com/qtproject/qtbase/blob/dev/src/corelib/tools/qlocale.cpp#L401 
, the separator contains both _ and -. 

uiLanguages() tend to return standard bcp 47 format, thus I don't think the 
implementation will become stricter.


- Xuetian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125705/#review87164
---


On Oct. 20, 2015, 7:04 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125705/
> ---
> 
> (Updated Oct. 20, 2015, 7:04 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 353715
> http://bugs.kde.org/show_bug.cgi?id=353715
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Simple QDate::longMonthName won't do the job as it
> will return the month name using LC_DATE locale which is used
> for date formatting etc. So for example, in en_US locale
> and cs_CZ LC_DATE, it would return Czech month names while
> it should return English ones. So here we force the LANG
> locale and take the month name from that.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.cpp 67a08e5 
> 
> Diff: https://git.reviewboard.kde.org/r/125705/diff/
> 
> 
> Testing
> ---
> 
> LC_DATE=cs_CZ
> LANG=en_US
> 
> Month names in calendar applet are now english.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125705: Use LANG for month names in calendar applet

2015-10-20 Thread Albert Astals Cid 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125705/#review87164
---



src/declarativeimports/calendar/calendar.cpp (line 197)


uilanguages is not good for direct inputing into QLocale (yes i know, it's 
stupid).

See how uilanguages returns en-US and QLocale wants en_US


- Albert Astals Cid


On oct. 20, 2015, 7:04 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125705/
> ---
> 
> (Updated oct. 20, 2015, 7:04 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 353715
> http://bugs.kde.org/show_bug.cgi?id=353715
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Simple QDate::longMonthName won't do the job as it
> will return the month name using LC_DATE locale which is used
> for date formatting etc. So for example, in en_US locale
> and cs_CZ LC_DATE, it would return Czech month names while
> it should return English ones. So here we force the LANG
> locale and take the month name from that.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.cpp 67a08e5 
> 
> Diff: https://git.reviewboard.kde.org/r/125705/diff/
> 
> 
> Testing
> ---
> 
> LC_DATE=cs_CZ
> LANG=en_US
> 
> Month names in calendar applet are now english.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125705: Use LANG for month names in calendar applet

2015-10-20 Thread Martin Klapetek 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125705/
---

(Updated Oct. 20, 2015, 9:04 p.m.)


Review request for KDE Frameworks and Plasma.


Changes
---

Construct QLocale from QLocale().uiLanguages().first().


Bugs: 353715
http://bugs.kde.org/show_bug.cgi?id=353715


Repository: plasma-framework


Description
---

Simple QDate::longMonthName won't do the job as it
will return the month name using LC_DATE locale which is used
for date formatting etc. So for example, in en_US locale
and cs_CZ LC_DATE, it would return Czech month names while
it should return English ones. So here we force the LANG
locale and take the month name from that.


Diffs (updated)
-

  src/declarativeimports/calendar/calendar.cpp 67a08e5 

Diff: https://git.reviewboard.kde.org/r/125705/diff/


Testing
---

LC_DATE=cs_CZ
LANG=en_US

Month names in calendar applet are now english.


Thanks,

Martin Klapetek

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125705: Use LANG for month names in calendar applet

2015-10-20 Thread Martin Klapetek 


> On Oct. 20, 2015, 9:12 a.m., Xuetian Weng wrote:
> > src/declarativeimports/calendar/calendar.cpp, line 195
> > 
> >
> > This only checks LANG, meanwhile, LC_ALL and LC_MESSAGES, and maybe 
> > even LANGUAGE should also be considered.
> > 
> > But I guess using the first item from QLocale().uiLanguages() would 
> > just work.

Ok.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125705/#review87113
---


On Oct. 19, 2015, 6:13 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125705/
> ---
> 
> (Updated Oct. 19, 2015, 6:13 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 353715
> http://bugs.kde.org/show_bug.cgi?id=353715
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Simple QDate::longMonthName won't do the job as it
> will return the month name using LC_DATE locale which is used
> for date formatting etc. So for example, in en_US locale
> and cs_CZ LC_DATE, it would return Czech month names while
> it should return English ones. So here we force the LANG
> locale and take the month name from that.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.cpp 67a08e5 
> 
> Diff: https://git.reviewboard.kde.org/r/125705/diff/
> 
> 
> Testing
> ---
> 
> LC_DATE=cs_CZ
> LANG=en_US
> 
> Month names in calendar applet are now english.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125705: Use LANG for month names in calendar applet

2015-10-20 Thread Xuetian Weng 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125705/#review87113
---



src/declarativeimports/calendar/calendar.cpp (line 195)


This only checks LANG, meanwhile, LC_ALL and LC_MESSAGES, and maybe even 
LANGUAGE should also be considered.

But I guess using the first item from QLocale().uiLanguages() would just 
work.


- Xuetian Weng


On Oct. 19, 2015, 4:13 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125705/
> ---
> 
> (Updated Oct. 19, 2015, 4:13 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 353715
> http://bugs.kde.org/show_bug.cgi?id=353715
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Simple QDate::longMonthName won't do the job as it
> will return the month name using LC_DATE locale which is used
> for date formatting etc. So for example, in en_US locale
> and cs_CZ LC_DATE, it would return Czech month names while
> it should return English ones. So here we force the LANG
> locale and take the month name from that.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.cpp 67a08e5 
> 
> Diff: https://git.reviewboard.kde.org/r/125705/diff/
> 
> 
> Testing
> ---
> 
> LC_DATE=cs_CZ
> LANG=en_US
> 
> Month names in calendar applet are now english.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125705: Use LANG for month names in calendar applet

2015-10-19 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125705/#review87095
---


+1 


you won't be able to use this trick for the tooltip dates where we use 
formatDate, as we do need the timeformat from the regional locale.

- David Edmundson


On Oct. 19, 2015, 4:13 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125705/
> ---
> 
> (Updated Oct. 19, 2015, 4:13 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 353715
> http://bugs.kde.org/show_bug.cgi?id=353715
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Simple QDate::longMonthName won't do the job as it
> will return the month name using LC_DATE locale which is used
> for date formatting etc. So for example, in en_US locale
> and cs_CZ LC_DATE, it would return Czech month names while
> it should return English ones. So here we force the LANG
> locale and take the month name from that.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.cpp 67a08e5 
> 
> Diff: https://git.reviewboard.kde.org/r/125705/diff/
> 
> 
> Testing
> ---
> 
> LC_DATE=cs_CZ
> LANG=en_US
> 
> Month names in calendar applet are now english.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 125705: Use LANG for month names in calendar applet

2015-10-19 Thread Martin Klapetek 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125705/
---

Review request for KDE Frameworks and Plasma.


Bugs: 353715
http://bugs.kde.org/show_bug.cgi?id=353715


Repository: plasma-framework


Description
---

Simple QDate::longMonthName won't do the job as it
will return the month name using LC_DATE locale which is used
for date formatting etc. So for example, in en_US locale
and cs_CZ LC_DATE, it would return Czech month names while
it should return English ones. So here we force the LANG
locale and take the month name from that.


Diffs
-

  src/declarativeimports/calendar/calendar.cpp 67a08e5 

Diff: https://git.reviewboard.kde.org/r/125705/diff/


Testing
---

LC_DATE=cs_CZ
LANG=en_US

Month names in calendar applet are now english.


Thanks,

Martin Klapetek

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel