Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

2016-01-01 Thread Christoph Cullmann 


> On Jan. 1, 2016, 6:12 p.m., Alex Richardson wrote:
> > I added support for translating the ExtraNames key here: 
> > https://svn.reviewboard.kde.org/r/7154/

Cool ;=) Which nice new year present! Thanks!


- Christoph


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125869/#review90411
---


On Dec. 28, 2015, 7:25 p.m., Christoph Cullmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125869/
> ---
> 
> (Updated Dec. 28, 2015, 7:25 p.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid, Alex Richardson, David 
> Faure, and Luigi Toscano.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Convert all io slave .protocol data to json and embed it.
> Allows easier deployment of the slaves.
> 
> 
> Diffs
> -
> 
>   src/core/kprotocolinfo.cpp 7bfb9ad 
>   src/protocoltojson/main.cpp 05b9364 
> 
> Diff: https://git.reviewboard.kde.org/r/125869/diff/
> 
> 
> Testing
> ---
> 
> Tests still work (one needed patching, as the exec line contains now the full 
> path).
> 
> Correction: Somehow the ./autotests/jobtest test is unstable for me here, 
> sometimes it works, sometimes not :/ but even without this change.
> 
> 
> File Attachments
> 
> 
> trash.json
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/28/6ab2cd95-b0bd-4347-80f2-6f753fa50425__trash.json
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

2016-01-01 Thread Christoph Cullmann 


> On Oct. 30, 2015, 7:29 a.m., David Faure wrote:
> > src/ioslaves/trash/trash.json, line 6
> > 
> >
> > That doesn't look very English to me ;)
> > 
> > The original is:
> > 
> > ExtraNames=Original Path,Deletion Date
> > 
> > But this shows a problem: missing support for translating this field. 
> > We didn't realize there was a translatable field in these files. Please add 
> > support for translations, like was done for other json files (talk to e.g. 
> > Luigi Toscano).
> 
> Christoph Cullmann wrote:
> Hmm, then we have a problem: We can no longer convert the stuff and 
> remove the .protocol files, or?
> 
> Christoph Cullmann wrote:
> Ok, did read up a bit, ExtraNames seems to be the only translated thing 
> (at least if I read KProtocolInfo docs the right way).
> Can do the same trick as desktop2json does for that. Seems not that hard.
> But then we need CMake stuff for it, or? To convert on the fly to have 
> translations using the .protocol files like we have ATM in the .desktop files 
> for the plugin stuff.
> 
> David Faure wrote:
> I don't think you're looking in the right direction. AFAIK there is 
> support for translating json files directly in l10n (json -> po -> json) 
> these days. As I said, please ask Luigi or maybe Albert.
> 
> Christoph Cullmann wrote:
> Ok ;=)
> 
> Christoph Cullmann wrote:
> CC Luigi here, too.
> I looked again at what we have btw. in the other frameworks and I nowhere 
> really found any json -> po and back way, but that doesn't mean its not there 
> ;=)
> 
> David Faure wrote:
> I'm pretty sure this is all done in the l10n module, not in the other 
> frameworks.
> 
> Christoph Cullmann wrote:
> Any idea who else to ping? With that patch at least the shipped IO slaves 
> work perfect on Win/Lin without any hacks, I would really like to get that 
> in. Some .protocol -> json -> ... translation stuff should be easy to do, but 
> for translating the list inside JSON I am a bit lost ;=)
> 
> Luigi Toscano wrote:
> Generically, the i18n (or l10n, never rememeber) group. This specific 
> code (translation of json) was done by Burkhard Lueck. Now, I was out for 
> vacation and business, so give some time. It's too late anyway from the next 
> framework version, so there is one month.

Hi,

can I commit my changes to the converted + the i18n aware reading?

Will do a new review request for the actual conversion of the remaining 
.protocol files afterwards.


- Christoph


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125869/#review87721
---


On Dec. 28, 2015, 7:25 p.m., Christoph Cullmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125869/
> ---
> 
> (Updated Dec. 28, 2015, 7:25 p.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid, Alex Richardson, David 
> Faure, and Luigi Toscano.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Convert all io slave .protocol data to json and embed it.
> Allows easier deployment of the slaves.
> 
> 
> Diffs
> -
> 
>   src/core/kprotocolinfo.cpp 7bfb9ad 
>   src/protocoltojson/main.cpp 05b9364 
> 
> Diff: https://git.reviewboard.kde.org/r/125869/diff/
> 
> 
> Testing
> ---
> 
> Tests still work (one needed patching, as the exec line contains now the full 
> path).
> 
> Correction: Somehow the ./autotests/jobtest test is unstable for me here, 
> sometimes it works, sometimes not :/ but even without this change.
> 
> 
> File Attachments
> 
> 
> trash.json
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/28/6ab2cd95-b0bd-4347-80f2-6f753fa50425__trash.json
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

2016-01-01 Thread Alex Richardson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125869/#review90411
---


I added support for translating the ExtraNames key here: 
https://svn.reviewboard.kde.org/r/7154/

- Alex Richardson


On Dec. 28, 2015, 7:25 p.m., Christoph Cullmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125869/
> ---
> 
> (Updated Dec. 28, 2015, 7:25 p.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid, Alex Richardson, David 
> Faure, and Luigi Toscano.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Convert all io slave .protocol data to json and embed it.
> Allows easier deployment of the slaves.
> 
> 
> Diffs
> -
> 
>   src/core/kprotocolinfo.cpp 7bfb9ad 
>   src/protocoltojson/main.cpp 05b9364 
> 
> Diff: https://git.reviewboard.kde.org/r/125869/diff/
> 
> 
> Testing
> ---
> 
> Tests still work (one needed patching, as the exec line contains now the full 
> path).
> 
> Correction: Somehow the ./autotests/jobtest test is unstable for me here, 
> sometimes it works, sometimes not :/ but even without this change.
> 
> 
> File Attachments
> 
> 
> trash.json
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/28/6ab2cd95-b0bd-4347-80f2-6f753fa50425__trash.json
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

2015-12-28 Thread Alex Richardson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125869/#review90237
---


Could you post a patch with the JSON files? I'll look into implementing the 
translations then.

- Alex Richardson


On Dec. 27, 2015, 5:14 p.m., Christoph Cullmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125869/
> ---
> 
> (Updated Dec. 27, 2015, 5:14 p.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid, Alex Richardson, David 
> Faure, and Luigi Toscano.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Convert all io slave .protocol data to json and embed it.
> Allows easier deployment of the slaves.
> 
> 
> Diffs
> -
> 
>   src/core/kprotocolinfo.cpp 7bfb9ad 
>   src/protocoltojson/main.cpp 05b9364 
> 
> Diff: https://git.reviewboard.kde.org/r/125869/diff/
> 
> 
> Testing
> ---
> 
> Tests still work (one needed patching, as the exec line contains now the full 
> path).
> 
> Correction: Somehow the ./autotests/jobtest test is unstable for me here, 
> sometimes it works, sometimes not :/ but even without this change.
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

2015-12-28 Thread Christoph Cullmann 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125869/
---

(Updated Dec. 28, 2015, 7:25 p.m.)


Review request for KDE Frameworks, Albert Astals Cid, Alex Richardson, David 
Faure, and Luigi Toscano.


Repository: kio


Description
---

Convert all io slave .protocol data to json and embed it.
Allows easier deployment of the slaves.


Diffs
-

  src/core/kprotocolinfo.cpp 7bfb9ad 
  src/protocoltojson/main.cpp 05b9364 

Diff: https://git.reviewboard.kde.org/r/125869/diff/


Testing
---

Tests still work (one needed patching, as the exec line contains now the full 
path).

Correction: Somehow the ./autotests/jobtest test is unstable for me here, 
sometimes it works, sometimes not :/ but even without this change.


File Attachments (updated)


trash.json
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/28/6ab2cd95-b0bd-4347-80f2-6f753fa50425__trash.json


Thanks,

Christoph Cullmann

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

2015-12-28 Thread Christoph Cullmann 


> On Dec. 28, 2015, 5:20 p.m., Alex Richardson wrote:
> > Could you post a patch with the JSON files? I'll look into implementing the 
> > translations then.

Hi, atm my local build is broken, so no new patch, but I have attached the 
converted trash.protocol result.


- Christoph


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125869/#review90237
---


On Dec. 28, 2015, 7:25 p.m., Christoph Cullmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125869/
> ---
> 
> (Updated Dec. 28, 2015, 7:25 p.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid, Alex Richardson, David 
> Faure, and Luigi Toscano.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Convert all io slave .protocol data to json and embed it.
> Allows easier deployment of the slaves.
> 
> 
> Diffs
> -
> 
>   src/core/kprotocolinfo.cpp 7bfb9ad 
>   src/protocoltojson/main.cpp 05b9364 
> 
> Diff: https://git.reviewboard.kde.org/r/125869/diff/
> 
> 
> Testing
> ---
> 
> Tests still work (one needed patching, as the exec line contains now the full 
> path).
> 
> Correction: Somehow the ./autotests/jobtest test is unstable for me here, 
> sometimes it works, sometimes not :/ but even without this change.
> 
> 
> File Attachments
> 
> 
> trash.json
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/28/6ab2cd95-b0bd-4347-80f2-6f753fa50425__trash.json
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

2015-12-27 Thread Christoph Cullmann 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125869/
---

(Updated Dec. 27, 2015, 5:14 p.m.)


Review request for KDE Frameworks, Albert Astals Cid, Alex Richardson, David 
Faure, and Luigi Toscano.


Changes
---

I have one more element now in place: protocoltojson converts the translated 
stuff in the same format as desktoptojson (the helper from KPluginMetaData can 
be used to read it).
Still to do: to add the helper to do the json => po => json conversion.
Is this change ok that way? I would first submit this and open a new request 
for the missing parts and and extra one for the conversion of the existing 
.protocol files.


Repository: kio


Description
---

Convert all io slave .protocol data to json and embed it.
Allows easier deployment of the slaves.


Diffs (updated)
-

  src/core/kprotocolinfo.cpp 7bfb9ad 
  src/protocoltojson/main.cpp 05b9364 

Diff: https://git.reviewboard.kde.org/r/125869/diff/


Testing
---

Tests still work (one needed patching, as the exec line contains now the full 
path).

Correction: Somehow the ./autotests/jobtest test is unstable for me here, 
sometimes it works, sometimes not :/ but even without this change.


Thanks,

Christoph Cullmann

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

2015-12-08 Thread Andrew McCann 


> On Nov. 3, 2015, 9:47 p.m., Albert Astals Cid wrote:
> > How does this work without modifying 
> > KProtocolInfoPrivate::KProtocolInfoPrivate?
> 
> Christoph Cullmann wrote:
> You mean the JSON stuff? That was implemented in 
> https://git.reviewboard.kde.org/r/125830/
> For the http slave, that already works nicely, but we missed that 
> "ExtraNames" as used by other slaves need i18n care.
> 
> Albert Astals Cid wrote:
> i see, i did not see that there's two almost copied 
> KProtocolInfoPrivate::KProtocolInfoPrivate implementations
> 
> So the json magic stuff (you can see 
> ./src/ioslaves/http/kcookiejar/kcookiejar.json in kio) only works for 
> Description and Name inside KPlugin, someone would need to update 
> createjsoncontext.py and filljsonfrompo.py so they also take into account 
> ExtraNames inside childs of "KDE-KIO-Protocols" and then make that new code 
> from 125830 extract the correct translation from the json.
> 
> Alex Richardson wrote:
> Reading the translated string can be done using 
> `KPluginMetaData::readTranslatedString()`
> 
> Christoph Cullmann wrote:
> Hmm, Ok, can take a look at that scripts. Will it be a problem that the 
> ExtraNames are a stringlist or is that fine?
> 
> Albert Astals Cid wrote:
> You'll have to take care of serializing and unserializing the list, 
> ideally using a well known marker like ; or similar. The scripts are at 
> https://websvn.kde.org/trunk/l10n-kf5/scripts/
> 
> Christoph Cullmann wrote:
> Hi, ok, started to take a look at that again ;=) Is there actually any 
> way to get all entries out of KConfig for all locales in the .ini? Atm I 
> struggle a bit with the fact that the localized keys are hidden from any 
> keys() accessor I can get from the outside.

+1 on having an application for this diff to be applied.  I abandoned my own 
diff that did nearly the same thing. https://git.reviewboard.kde.org/r/126038/


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125869/#review87966
---


On Nov. 1, 2015, 6:13 p.m., Christoph Cullmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125869/
> ---
> 
> (Updated Nov. 1, 2015, 6:13 p.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid, Alex Richardson, David 
> Faure, and Luigi Toscano.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Convert all io slave .protocol data to json and embed it.
> Allows easier deployment of the slaves.
> 
> 
> Diffs
> -
> 
>   src/ioslaves/http/CMakeLists.txt 76a8e28 
>   src/ioslaves/help/main_ghelp.cpp 59c8558 
>   src/ioslaves/help/main.cpp 9939196 
>   src/ioslaves/help/help.protocol 1deefe5 
>   src/ioslaves/help/help.json PRE-CREATION 
>   src/ioslaves/help/ghelp.protocol d2a642a 
>   src/ioslaves/help/ghelp.json PRE-CREATION 
>   src/ioslaves/help/CMakeLists.txt 867b59d 
>   src/ioslaves/ftp/ftp.protocol 4c5f80c 
>   src/ioslaves/ftp/ftp.json PRE-CREATION 
>   src/ioslaves/ftp/ftp.cpp 382723a 
>   src/ioslaves/ftp/CMakeLists.txt 04f5600 
>   src/ioslaves/file/file.protocol 523c0f5 
>   src/ioslaves/file/file.json PRE-CREATION 
>   src/ioslaves/file/file.cpp 5ef1587 
>   src/ioslaves/file/CMakeLists.txt cb85cfb 
>   autotests/kprotocolinfotest.cpp fa3ad38 
>   src/ioslaves/http/http.protocol 49e5dc5 
>   src/ioslaves/http/https.protocol c15d06f 
>   src/ioslaves/http/webdav.protocol 05c977a 
>   src/ioslaves/http/webdavs.protocol d5e4b2f 
>   src/ioslaves/trash/CMakeLists.txt 05161cd 
>   src/ioslaves/trash/kio_trash.cpp cb23169 
>   src/ioslaves/trash/trash.json PRE-CREATION 
>   src/ioslaves/trash/trash.protocol 7430575 
> 
> Diff: https://git.reviewboard.kde.org/r/125869/diff/
> 
> 
> Testing
> ---
> 
> Tests still work (one needed patching, as the exec line contains now the full 
> path).
> 
> Correction: Somehow the ./autotests/jobtest test is unstable for me here, 
> sometimes it works, sometimes not :/ but even without this change.
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

2015-11-29 Thread Christoph Cullmann 


> On Nov. 3, 2015, 9:47 p.m., Albert Astals Cid wrote:
> > How does this work without modifying 
> > KProtocolInfoPrivate::KProtocolInfoPrivate?
> 
> Christoph Cullmann wrote:
> You mean the JSON stuff? That was implemented in 
> https://git.reviewboard.kde.org/r/125830/
> For the http slave, that already works nicely, but we missed that 
> "ExtraNames" as used by other slaves need i18n care.
> 
> Albert Astals Cid wrote:
> i see, i did not see that there's two almost copied 
> KProtocolInfoPrivate::KProtocolInfoPrivate implementations
> 
> So the json magic stuff (you can see 
> ./src/ioslaves/http/kcookiejar/kcookiejar.json in kio) only works for 
> Description and Name inside KPlugin, someone would need to update 
> createjsoncontext.py and filljsonfrompo.py so they also take into account 
> ExtraNames inside childs of "KDE-KIO-Protocols" and then make that new code 
> from 125830 extract the correct translation from the json.
> 
> Alex Richardson wrote:
> Reading the translated string can be done using 
> `KPluginMetaData::readTranslatedString()`
> 
> Christoph Cullmann wrote:
> Hmm, Ok, can take a look at that scripts. Will it be a problem that the 
> ExtraNames are a stringlist or is that fine?
> 
> Albert Astals Cid wrote:
> You'll have to take care of serializing and unserializing the list, 
> ideally using a well known marker like ; or similar. The scripts are at 
> https://websvn.kde.org/trunk/l10n-kf5/scripts/

Hi, ok, started to take a look at that again ;=) Is there actually any way to 
get all entries out of KConfig for all locales in the .ini? Atm I struggle a 
bit with the fact that the localized keys are hidden from any keys() accessor I 
can get from the outside.


- Christoph


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125869/#review87966
---


On Nov. 1, 2015, 6:13 p.m., Christoph Cullmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125869/
> ---
> 
> (Updated Nov. 1, 2015, 6:13 p.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid, Alex Richardson, David 
> Faure, and Luigi Toscano.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Convert all io slave .protocol data to json and embed it.
> Allows easier deployment of the slaves.
> 
> 
> Diffs
> -
> 
>   src/ioslaves/http/CMakeLists.txt 76a8e28 
>   src/ioslaves/help/main_ghelp.cpp 59c8558 
>   src/ioslaves/help/main.cpp 9939196 
>   src/ioslaves/help/help.protocol 1deefe5 
>   src/ioslaves/help/help.json PRE-CREATION 
>   src/ioslaves/help/ghelp.protocol d2a642a 
>   src/ioslaves/help/ghelp.json PRE-CREATION 
>   src/ioslaves/help/CMakeLists.txt 867b59d 
>   src/ioslaves/ftp/ftp.protocol 4c5f80c 
>   src/ioslaves/ftp/ftp.json PRE-CREATION 
>   src/ioslaves/ftp/ftp.cpp 382723a 
>   src/ioslaves/ftp/CMakeLists.txt 04f5600 
>   src/ioslaves/file/file.protocol 523c0f5 
>   src/ioslaves/file/file.json PRE-CREATION 
>   src/ioslaves/file/file.cpp 5ef1587 
>   src/ioslaves/file/CMakeLists.txt cb85cfb 
>   autotests/kprotocolinfotest.cpp fa3ad38 
>   src/ioslaves/http/http.protocol 49e5dc5 
>   src/ioslaves/http/https.protocol c15d06f 
>   src/ioslaves/http/webdav.protocol 05c977a 
>   src/ioslaves/http/webdavs.protocol d5e4b2f 
>   src/ioslaves/trash/CMakeLists.txt 05161cd 
>   src/ioslaves/trash/kio_trash.cpp cb23169 
>   src/ioslaves/trash/trash.json PRE-CREATION 
>   src/ioslaves/trash/trash.protocol 7430575 
> 
> Diff: https://git.reviewboard.kde.org/r/125869/diff/
> 
> 
> Testing
> ---
> 
> Tests still work (one needed patching, as the exec line contains now the full 
> path).
> 
> Correction: Somehow the ./autotests/jobtest test is unstable for me here, 
> sometimes it works, sometimes not :/ but even without this change.
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

2015-11-05 Thread Albert Astals Cid 


> On nov. 3, 2015, 9:47 p.m., Albert Astals Cid wrote:
> > How does this work without modifying 
> > KProtocolInfoPrivate::KProtocolInfoPrivate?
> 
> Christoph Cullmann wrote:
> You mean the JSON stuff? That was implemented in 
> https://git.reviewboard.kde.org/r/125830/
> For the http slave, that already works nicely, but we missed that 
> "ExtraNames" as used by other slaves need i18n care.
> 
> Albert Astals Cid wrote:
> i see, i did not see that there's two almost copied 
> KProtocolInfoPrivate::KProtocolInfoPrivate implementations
> 
> So the json magic stuff (you can see 
> ./src/ioslaves/http/kcookiejar/kcookiejar.json in kio) only works for 
> Description and Name inside KPlugin, someone would need to update 
> createjsoncontext.py and filljsonfrompo.py so they also take into account 
> ExtraNames inside childs of "KDE-KIO-Protocols" and then make that new code 
> from 125830 extract the correct translation from the json.
> 
> Alex Richardson wrote:
> Reading the translated string can be done using 
> `KPluginMetaData::readTranslatedString()`
> 
> Christoph Cullmann wrote:
> Hmm, Ok, can take a look at that scripts. Will it be a problem that the 
> ExtraNames are a stringlist or is that fine?

You'll have to take care of serializing and unserializing the list, ideally 
using a well known marker like ; or similar. The scripts are at 
https://websvn.kde.org/trunk/l10n-kf5/scripts/


- Albert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125869/#review87966
---


On nov. 1, 2015, 6:13 p.m., Christoph Cullmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125869/
> ---
> 
> (Updated nov. 1, 2015, 6:13 p.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid, Alex Richardson, David 
> Faure, and Luigi Toscano.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Convert all io slave .protocol data to json and embed it.
> Allows easier deployment of the slaves.
> 
> 
> Diffs
> -
> 
>   src/ioslaves/http/CMakeLists.txt 76a8e28 
>   src/ioslaves/help/main_ghelp.cpp 59c8558 
>   src/ioslaves/help/main.cpp 9939196 
>   src/ioslaves/help/help.protocol 1deefe5 
>   src/ioslaves/help/help.json PRE-CREATION 
>   src/ioslaves/help/ghelp.protocol d2a642a 
>   src/ioslaves/help/ghelp.json PRE-CREATION 
>   src/ioslaves/help/CMakeLists.txt 867b59d 
>   src/ioslaves/ftp/ftp.protocol 4c5f80c 
>   src/ioslaves/ftp/ftp.json PRE-CREATION 
>   src/ioslaves/ftp/ftp.cpp 382723a 
>   src/ioslaves/ftp/CMakeLists.txt 04f5600 
>   src/ioslaves/file/file.protocol 523c0f5 
>   src/ioslaves/file/file.json PRE-CREATION 
>   src/ioslaves/file/file.cpp 5ef1587 
>   src/ioslaves/file/CMakeLists.txt cb85cfb 
>   autotests/kprotocolinfotest.cpp fa3ad38 
>   src/ioslaves/http/http.protocol 49e5dc5 
>   src/ioslaves/http/https.protocol c15d06f 
>   src/ioslaves/http/webdav.protocol 05c977a 
>   src/ioslaves/http/webdavs.protocol d5e4b2f 
>   src/ioslaves/trash/CMakeLists.txt 05161cd 
>   src/ioslaves/trash/kio_trash.cpp cb23169 
>   src/ioslaves/trash/trash.json PRE-CREATION 
>   src/ioslaves/trash/trash.protocol 7430575 
> 
> Diff: https://git.reviewboard.kde.org/r/125869/diff/
> 
> 
> Testing
> ---
> 
> Tests still work (one needed patching, as the exec line contains now the full 
> path).
> 
> Correction: Somehow the ./autotests/jobtest test is unstable for me here, 
> sometimes it works, sometimes not :/ but even without this change.
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

2015-11-04 Thread Alex Richardson 


> On Nov. 3, 2015, 9:47 p.m., Albert Astals Cid wrote:
> > How does this work without modifying 
> > KProtocolInfoPrivate::KProtocolInfoPrivate?
> 
> Christoph Cullmann wrote:
> You mean the JSON stuff? That was implemented in 
> https://git.reviewboard.kde.org/r/125830/
> For the http slave, that already works nicely, but we missed that 
> "ExtraNames" as used by other slaves need i18n care.
> 
> Albert Astals Cid wrote:
> i see, i did not see that there's two almost copied 
> KProtocolInfoPrivate::KProtocolInfoPrivate implementations
> 
> So the json magic stuff (you can see 
> ./src/ioslaves/http/kcookiejar/kcookiejar.json in kio) only works for 
> Description and Name inside KPlugin, someone would need to update 
> createjsoncontext.py and filljsonfrompo.py so they also take into account 
> ExtraNames inside childs of "KDE-KIO-Protocols" and then make that new code 
> from 125830 extract the correct translation from the json.

Reading the translated string can be done using 
`KPluginMetaData::readTranslatedString()`


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125869/#review87966
---


On Nov. 1, 2015, 6:13 p.m., Christoph Cullmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125869/
> ---
> 
> (Updated Nov. 1, 2015, 6:13 p.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid, Alex Richardson, David 
> Faure, and Luigi Toscano.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Convert all io slave .protocol data to json and embed it.
> Allows easier deployment of the slaves.
> 
> 
> Diffs
> -
> 
>   src/ioslaves/http/CMakeLists.txt 76a8e28 
>   src/ioslaves/help/main_ghelp.cpp 59c8558 
>   src/ioslaves/help/main.cpp 9939196 
>   src/ioslaves/help/help.protocol 1deefe5 
>   src/ioslaves/help/help.json PRE-CREATION 
>   src/ioslaves/help/ghelp.protocol d2a642a 
>   src/ioslaves/help/ghelp.json PRE-CREATION 
>   src/ioslaves/help/CMakeLists.txt 867b59d 
>   src/ioslaves/ftp/ftp.protocol 4c5f80c 
>   src/ioslaves/ftp/ftp.json PRE-CREATION 
>   src/ioslaves/ftp/ftp.cpp 382723a 
>   src/ioslaves/ftp/CMakeLists.txt 04f5600 
>   src/ioslaves/file/file.protocol 523c0f5 
>   src/ioslaves/file/file.json PRE-CREATION 
>   src/ioslaves/file/file.cpp 5ef1587 
>   src/ioslaves/file/CMakeLists.txt cb85cfb 
>   autotests/kprotocolinfotest.cpp fa3ad38 
>   src/ioslaves/http/http.protocol 49e5dc5 
>   src/ioslaves/http/https.protocol c15d06f 
>   src/ioslaves/http/webdav.protocol 05c977a 
>   src/ioslaves/http/webdavs.protocol d5e4b2f 
>   src/ioslaves/trash/CMakeLists.txt 05161cd 
>   src/ioslaves/trash/kio_trash.cpp cb23169 
>   src/ioslaves/trash/trash.json PRE-CREATION 
>   src/ioslaves/trash/trash.protocol 7430575 
> 
> Diff: https://git.reviewboard.kde.org/r/125869/diff/
> 
> 
> Testing
> ---
> 
> Tests still work (one needed patching, as the exec line contains now the full 
> path).
> 
> Correction: Somehow the ./autotests/jobtest test is unstable for me here, 
> sometimes it works, sometimes not :/ but even without this change.
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

2015-11-04 Thread Christoph Cullmann 


> On Nov. 3, 2015, 9:47 p.m., Albert Astals Cid wrote:
> > How does this work without modifying 
> > KProtocolInfoPrivate::KProtocolInfoPrivate?
> 
> Christoph Cullmann wrote:
> You mean the JSON stuff? That was implemented in 
> https://git.reviewboard.kde.org/r/125830/
> For the http slave, that already works nicely, but we missed that 
> "ExtraNames" as used by other slaves need i18n care.
> 
> Albert Astals Cid wrote:
> i see, i did not see that there's two almost copied 
> KProtocolInfoPrivate::KProtocolInfoPrivate implementations
> 
> So the json magic stuff (you can see 
> ./src/ioslaves/http/kcookiejar/kcookiejar.json in kio) only works for 
> Description and Name inside KPlugin, someone would need to update 
> createjsoncontext.py and filljsonfrompo.py so they also take into account 
> ExtraNames inside childs of "KDE-KIO-Protocols" and then make that new code 
> from 125830 extract the correct translation from the json.
> 
> Alex Richardson wrote:
> Reading the translated string can be done using 
> `KPluginMetaData::readTranslatedString()`

Hmm, Ok, can take a look at that scripts. Will it be a problem that the 
ExtraNames are a stringlist or is that fine?


- Christoph


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125869/#review87966
---


On Nov. 1, 2015, 6:13 p.m., Christoph Cullmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125869/
> ---
> 
> (Updated Nov. 1, 2015, 6:13 p.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid, Alex Richardson, David 
> Faure, and Luigi Toscano.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Convert all io slave .protocol data to json and embed it.
> Allows easier deployment of the slaves.
> 
> 
> Diffs
> -
> 
>   src/ioslaves/http/CMakeLists.txt 76a8e28 
>   src/ioslaves/help/main_ghelp.cpp 59c8558 
>   src/ioslaves/help/main.cpp 9939196 
>   src/ioslaves/help/help.protocol 1deefe5 
>   src/ioslaves/help/help.json PRE-CREATION 
>   src/ioslaves/help/ghelp.protocol d2a642a 
>   src/ioslaves/help/ghelp.json PRE-CREATION 
>   src/ioslaves/help/CMakeLists.txt 867b59d 
>   src/ioslaves/ftp/ftp.protocol 4c5f80c 
>   src/ioslaves/ftp/ftp.json PRE-CREATION 
>   src/ioslaves/ftp/ftp.cpp 382723a 
>   src/ioslaves/ftp/CMakeLists.txt 04f5600 
>   src/ioslaves/file/file.protocol 523c0f5 
>   src/ioslaves/file/file.json PRE-CREATION 
>   src/ioslaves/file/file.cpp 5ef1587 
>   src/ioslaves/file/CMakeLists.txt cb85cfb 
>   autotests/kprotocolinfotest.cpp fa3ad38 
>   src/ioslaves/http/http.protocol 49e5dc5 
>   src/ioslaves/http/https.protocol c15d06f 
>   src/ioslaves/http/webdav.protocol 05c977a 
>   src/ioslaves/http/webdavs.protocol d5e4b2f 
>   src/ioslaves/trash/CMakeLists.txt 05161cd 
>   src/ioslaves/trash/kio_trash.cpp cb23169 
>   src/ioslaves/trash/trash.json PRE-CREATION 
>   src/ioslaves/trash/trash.protocol 7430575 
> 
> Diff: https://git.reviewboard.kde.org/r/125869/diff/
> 
> 
> Testing
> ---
> 
> Tests still work (one needed patching, as the exec line contains now the full 
> path).
> 
> Correction: Somehow the ./autotests/jobtest test is unstable for me here, 
> sometimes it works, sometimes not :/ but even without this change.
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

2015-11-03 Thread Luigi Toscano 


> On Oct. 30, 2015, 8:29 a.m., David Faure wrote:
> > src/ioslaves/trash/trash.json, line 6
> > 
> >
> > That doesn't look very English to me ;)
> > 
> > The original is:
> > 
> > ExtraNames=Original Path,Deletion Date
> > 
> > But this shows a problem: missing support for translating this field. 
> > We didn't realize there was a translatable field in these files. Please add 
> > support for translations, like was done for other json files (talk to e.g. 
> > Luigi Toscano).
> 
> Christoph Cullmann wrote:
> Hmm, then we have a problem: We can no longer convert the stuff and 
> remove the .protocol files, or?
> 
> Christoph Cullmann wrote:
> Ok, did read up a bit, ExtraNames seems to be the only translated thing 
> (at least if I read KProtocolInfo docs the right way).
> Can do the same trick as desktop2json does for that. Seems not that hard.
> But then we need CMake stuff for it, or? To convert on the fly to have 
> translations using the .protocol files like we have ATM in the .desktop files 
> for the plugin stuff.
> 
> David Faure wrote:
> I don't think you're looking in the right direction. AFAIK there is 
> support for translating json files directly in l10n (json -> po -> json) 
> these days. As I said, please ask Luigi or maybe Albert.
> 
> Christoph Cullmann wrote:
> Ok ;=)
> 
> Christoph Cullmann wrote:
> CC Luigi here, too.
> I looked again at what we have btw. in the other frameworks and I nowhere 
> really found any json -> po and back way, but that doesn't mean its not there 
> ;=)
> 
> David Faure wrote:
> I'm pretty sure this is all done in the l10n module, not in the other 
> frameworks.
> 
> Christoph Cullmann wrote:
> Any idea who else to ping? With that patch at least the shipped IO slaves 
> work perfect on Win/Lin without any hacks, I would really like to get that 
> in. Some .protocol -> json -> ... translation stuff should be easy to do, but 
> for translating the list inside JSON I am a bit lost ;=)

Generically, the i18n (or l10n, never rememeber) group. This specific code 
(translation of json) was done by Burkhard Lueck. Now, I was out for vacation 
and business, so give some time. It's too late anyway from the next framework 
version, so there is one month.


- Luigi


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125869/#review87721
---


On Nov. 1, 2015, 7:13 p.m., Christoph Cullmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125869/
> ---
> 
> (Updated Nov. 1, 2015, 7:13 p.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid, Alex Richardson, David 
> Faure, and Luigi Toscano.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Convert all io slave .protocol data to json and embed it.
> Allows easier deployment of the slaves.
> 
> 
> Diffs
> -
> 
>   src/ioslaves/http/CMakeLists.txt 76a8e28 
>   src/ioslaves/help/main_ghelp.cpp 59c8558 
>   src/ioslaves/help/main.cpp 9939196 
>   src/ioslaves/help/help.protocol 1deefe5 
>   src/ioslaves/help/help.json PRE-CREATION 
>   src/ioslaves/help/ghelp.protocol d2a642a 
>   src/ioslaves/help/ghelp.json PRE-CREATION 
>   src/ioslaves/help/CMakeLists.txt 867b59d 
>   src/ioslaves/ftp/ftp.protocol 4c5f80c 
>   src/ioslaves/ftp/ftp.json PRE-CREATION 
>   src/ioslaves/ftp/ftp.cpp 382723a 
>   src/ioslaves/ftp/CMakeLists.txt 04f5600 
>   src/ioslaves/file/file.protocol 523c0f5 
>   src/ioslaves/file/file.json PRE-CREATION 
>   src/ioslaves/file/file.cpp 5ef1587 
>   src/ioslaves/file/CMakeLists.txt cb85cfb 
>   autotests/kprotocolinfotest.cpp fa3ad38 
>   src/ioslaves/http/http.protocol 49e5dc5 
>   src/ioslaves/http/https.protocol c15d06f 
>   src/ioslaves/http/webdav.protocol 05c977a 
>   src/ioslaves/http/webdavs.protocol d5e4b2f 
>   src/ioslaves/trash/CMakeLists.txt 05161cd 
>   src/ioslaves/trash/kio_trash.cpp cb23169 
>   src/ioslaves/trash/trash.json PRE-CREATION 
>   src/ioslaves/trash/trash.protocol 7430575 
> 
> Diff: https://git.reviewboard.kde.org/r/125869/diff/
> 
> 
> Testing
> ---
> 
> Tests still work (one needed patching, as the exec line contains now the full 
> path).
> 
> Correction: Somehow the ./autotests/jobtest test is unstable for me here, 
> sometimes it works, sometimes not :/ but even without this change.
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

2015-11-03 Thread Albert Astals Cid 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125869/#review87966
---


How does this work without modifying KProtocolInfoPrivate::KProtocolInfoPrivate?

- Albert Astals Cid


On nov. 1, 2015, 6:13 p.m., Christoph Cullmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125869/
> ---
> 
> (Updated nov. 1, 2015, 6:13 p.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid, Alex Richardson, David 
> Faure, and Luigi Toscano.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Convert all io slave .protocol data to json and embed it.
> Allows easier deployment of the slaves.
> 
> 
> Diffs
> -
> 
>   src/ioslaves/http/CMakeLists.txt 76a8e28 
>   src/ioslaves/help/main_ghelp.cpp 59c8558 
>   src/ioslaves/help/main.cpp 9939196 
>   src/ioslaves/help/help.protocol 1deefe5 
>   src/ioslaves/help/help.json PRE-CREATION 
>   src/ioslaves/help/ghelp.protocol d2a642a 
>   src/ioslaves/help/ghelp.json PRE-CREATION 
>   src/ioslaves/help/CMakeLists.txt 867b59d 
>   src/ioslaves/ftp/ftp.protocol 4c5f80c 
>   src/ioslaves/ftp/ftp.json PRE-CREATION 
>   src/ioslaves/ftp/ftp.cpp 382723a 
>   src/ioslaves/ftp/CMakeLists.txt 04f5600 
>   src/ioslaves/file/file.protocol 523c0f5 
>   src/ioslaves/file/file.json PRE-CREATION 
>   src/ioslaves/file/file.cpp 5ef1587 
>   src/ioslaves/file/CMakeLists.txt cb85cfb 
>   autotests/kprotocolinfotest.cpp fa3ad38 
>   src/ioslaves/http/http.protocol 49e5dc5 
>   src/ioslaves/http/https.protocol c15d06f 
>   src/ioslaves/http/webdav.protocol 05c977a 
>   src/ioslaves/http/webdavs.protocol d5e4b2f 
>   src/ioslaves/trash/CMakeLists.txt 05161cd 
>   src/ioslaves/trash/kio_trash.cpp cb23169 
>   src/ioslaves/trash/trash.json PRE-CREATION 
>   src/ioslaves/trash/trash.protocol 7430575 
> 
> Diff: https://git.reviewboard.kde.org/r/125869/diff/
> 
> 
> Testing
> ---
> 
> Tests still work (one needed patching, as the exec line contains now the full 
> path).
> 
> Correction: Somehow the ./autotests/jobtest test is unstable for me here, 
> sometimes it works, sometimes not :/ but even without this change.
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

2015-11-03 Thread Christoph Cullmann 


> On Nov. 3, 2015, 9:47 p.m., Albert Astals Cid wrote:
> > How does this work without modifying 
> > KProtocolInfoPrivate::KProtocolInfoPrivate?

You mean the JSON stuff? That was implemented in 
https://git.reviewboard.kde.org/r/125830/
For the http slave, that already works nicely, but we missed that "ExtraNames" 
as used by other slaves need i18n care.


- Christoph


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125869/#review87966
---


On Nov. 1, 2015, 6:13 p.m., Christoph Cullmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125869/
> ---
> 
> (Updated Nov. 1, 2015, 6:13 p.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid, Alex Richardson, David 
> Faure, and Luigi Toscano.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Convert all io slave .protocol data to json and embed it.
> Allows easier deployment of the slaves.
> 
> 
> Diffs
> -
> 
>   src/ioslaves/http/CMakeLists.txt 76a8e28 
>   src/ioslaves/help/main_ghelp.cpp 59c8558 
>   src/ioslaves/help/main.cpp 9939196 
>   src/ioslaves/help/help.protocol 1deefe5 
>   src/ioslaves/help/help.json PRE-CREATION 
>   src/ioslaves/help/ghelp.protocol d2a642a 
>   src/ioslaves/help/ghelp.json PRE-CREATION 
>   src/ioslaves/help/CMakeLists.txt 867b59d 
>   src/ioslaves/ftp/ftp.protocol 4c5f80c 
>   src/ioslaves/ftp/ftp.json PRE-CREATION 
>   src/ioslaves/ftp/ftp.cpp 382723a 
>   src/ioslaves/ftp/CMakeLists.txt 04f5600 
>   src/ioslaves/file/file.protocol 523c0f5 
>   src/ioslaves/file/file.json PRE-CREATION 
>   src/ioslaves/file/file.cpp 5ef1587 
>   src/ioslaves/file/CMakeLists.txt cb85cfb 
>   autotests/kprotocolinfotest.cpp fa3ad38 
>   src/ioslaves/http/http.protocol 49e5dc5 
>   src/ioslaves/http/https.protocol c15d06f 
>   src/ioslaves/http/webdav.protocol 05c977a 
>   src/ioslaves/http/webdavs.protocol d5e4b2f 
>   src/ioslaves/trash/CMakeLists.txt 05161cd 
>   src/ioslaves/trash/kio_trash.cpp cb23169 
>   src/ioslaves/trash/trash.json PRE-CREATION 
>   src/ioslaves/trash/trash.protocol 7430575 
> 
> Diff: https://git.reviewboard.kde.org/r/125869/diff/
> 
> 
> Testing
> ---
> 
> Tests still work (one needed patching, as the exec line contains now the full 
> path).
> 
> Correction: Somehow the ./autotests/jobtest test is unstable for me here, 
> sometimes it works, sometimes not :/ but even without this change.
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

2015-11-03 Thread Christoph Cullmann 


> On Oct. 30, 2015, 7:29 a.m., David Faure wrote:
> > src/ioslaves/trash/trash.json, line 6
> > 
> >
> > That doesn't look very English to me ;)
> > 
> > The original is:
> > 
> > ExtraNames=Original Path,Deletion Date
> > 
> > But this shows a problem: missing support for translating this field. 
> > We didn't realize there was a translatable field in these files. Please add 
> > support for translations, like was done for other json files (talk to e.g. 
> > Luigi Toscano).
> 
> Christoph Cullmann wrote:
> Hmm, then we have a problem: We can no longer convert the stuff and 
> remove the .protocol files, or?
> 
> Christoph Cullmann wrote:
> Ok, did read up a bit, ExtraNames seems to be the only translated thing 
> (at least if I read KProtocolInfo docs the right way).
> Can do the same trick as desktop2json does for that. Seems not that hard.
> But then we need CMake stuff for it, or? To convert on the fly to have 
> translations using the .protocol files like we have ATM in the .desktop files 
> for the plugin stuff.
> 
> David Faure wrote:
> I don't think you're looking in the right direction. AFAIK there is 
> support for translating json files directly in l10n (json -> po -> json) 
> these days. As I said, please ask Luigi or maybe Albert.
> 
> Christoph Cullmann wrote:
> Ok ;=)
> 
> Christoph Cullmann wrote:
> CC Luigi here, too.
> I looked again at what we have btw. in the other frameworks and I nowhere 
> really found any json -> po and back way, but that doesn't mean its not there 
> ;=)
> 
> David Faure wrote:
> I'm pretty sure this is all done in the l10n module, not in the other 
> frameworks.

Any idea who else to ping? With that patch at least the shipped IO slaves work 
perfect on Win/Lin without any hacks, I would really like to get that in. Some 
.protocol -> json -> ... translation stuff should be easy to do, but for 
translating the list inside JSON I am a bit lost ;=)


- Christoph


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125869/#review87721
---


On Nov. 1, 2015, 6:13 p.m., Christoph Cullmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125869/
> ---
> 
> (Updated Nov. 1, 2015, 6:13 p.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid, Alex Richardson, David 
> Faure, and Luigi Toscano.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Convert all io slave .protocol data to json and embed it.
> Allows easier deployment of the slaves.
> 
> 
> Diffs
> -
> 
>   src/ioslaves/http/CMakeLists.txt 76a8e28 
>   src/ioslaves/help/main_ghelp.cpp 59c8558 
>   src/ioslaves/help/main.cpp 9939196 
>   src/ioslaves/help/help.protocol 1deefe5 
>   src/ioslaves/help/help.json PRE-CREATION 
>   src/ioslaves/help/ghelp.protocol d2a642a 
>   src/ioslaves/help/ghelp.json PRE-CREATION 
>   src/ioslaves/help/CMakeLists.txt 867b59d 
>   src/ioslaves/ftp/ftp.protocol 4c5f80c 
>   src/ioslaves/ftp/ftp.json PRE-CREATION 
>   src/ioslaves/ftp/ftp.cpp 382723a 
>   src/ioslaves/ftp/CMakeLists.txt 04f5600 
>   src/ioslaves/file/file.protocol 523c0f5 
>   src/ioslaves/file/file.json PRE-CREATION 
>   src/ioslaves/file/file.cpp 5ef1587 
>   src/ioslaves/file/CMakeLists.txt cb85cfb 
>   autotests/kprotocolinfotest.cpp fa3ad38 
>   src/ioslaves/http/http.protocol 49e5dc5 
>   src/ioslaves/http/https.protocol c15d06f 
>   src/ioslaves/http/webdav.protocol 05c977a 
>   src/ioslaves/http/webdavs.protocol d5e4b2f 
>   src/ioslaves/trash/CMakeLists.txt 05161cd 
>   src/ioslaves/trash/kio_trash.cpp cb23169 
>   src/ioslaves/trash/trash.json PRE-CREATION 
>   src/ioslaves/trash/trash.protocol 7430575 
> 
> Diff: https://git.reviewboard.kde.org/r/125869/diff/
> 
> 
> Testing
> ---
> 
> Tests still work (one needed patching, as the exec line contains now the full 
> path).
> 
> Correction: Somehow the ./autotests/jobtest test is unstable for me here, 
> sometimes it works, sometimes not :/ but even without this change.
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

2015-11-01 Thread Christoph Cullmann 


> On Oct. 30, 2015, 7:29 a.m., David Faure wrote:
> > src/ioslaves/trash/trash.json, line 6
> > 
> >
> > That doesn't look very English to me ;)
> > 
> > The original is:
> > 
> > ExtraNames=Original Path,Deletion Date
> > 
> > But this shows a problem: missing support for translating this field. 
> > We didn't realize there was a translatable field in these files. Please add 
> > support for translations, like was done for other json files (talk to e.g. 
> > Luigi Toscano).
> 
> Christoph Cullmann wrote:
> Hmm, then we have a problem: We can no longer convert the stuff and 
> remove the .protocol files, or?
> 
> Christoph Cullmann wrote:
> Ok, did read up a bit, ExtraNames seems to be the only translated thing 
> (at least if I read KProtocolInfo docs the right way).
> Can do the same trick as desktop2json does for that. Seems not that hard.
> But then we need CMake stuff for it, or? To convert on the fly to have 
> translations using the .protocol files like we have ATM in the .desktop files 
> for the plugin stuff.
> 
> David Faure wrote:
> I don't think you're looking in the right direction. AFAIK there is 
> support for translating json files directly in l10n (json -> po -> json) 
> these days. As I said, please ask Luigi or maybe Albert.
> 
> Christoph Cullmann wrote:
> Ok ;=)

CC Luigi here, too.
I looked again at what we have btw. in the other frameworks and I nowhere 
really found any json -> po and back way, but that doesn't mean its not there 
;=)


- Christoph


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125869/#review87721
---


On Oct. 29, 2015, 5:03 p.m., Christoph Cullmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125869/
> ---
> 
> (Updated Oct. 29, 2015, 5:03 p.m.)
> 
> 
> Review request for KDE Frameworks, Alex Richardson and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Convert all io slave .protocol data to json and embed it.
> Allows easier deployment of the slaves.
> 
> 
> Diffs
> -
> 
>   src/ioslaves/http/CMakeLists.txt 76a8e28 
>   src/ioslaves/help/main_ghelp.cpp 59c8558 
>   src/ioslaves/help/main.cpp 9939196 
>   src/ioslaves/help/help.protocol 1deefe5 
>   src/ioslaves/help/help.json PRE-CREATION 
>   src/ioslaves/help/ghelp.protocol d2a642a 
>   src/ioslaves/help/ghelp.json PRE-CREATION 
>   src/ioslaves/help/CMakeLists.txt 867b59d 
>   src/ioslaves/ftp/ftp.protocol 4c5f80c 
>   src/ioslaves/ftp/ftp.json PRE-CREATION 
>   src/ioslaves/ftp/ftp.cpp 382723a 
>   src/ioslaves/ftp/CMakeLists.txt 04f5600 
>   src/ioslaves/file/file.protocol 523c0f5 
>   src/ioslaves/file/file.json PRE-CREATION 
>   src/ioslaves/file/file.cpp 5ef1587 
>   src/ioslaves/file/CMakeLists.txt cb85cfb 
>   autotests/kprotocolinfotest.cpp fa3ad38 
>   src/ioslaves/http/http.protocol 49e5dc5 
>   src/ioslaves/http/https.protocol c15d06f 
>   src/ioslaves/http/webdav.protocol 05c977a 
>   src/ioslaves/http/webdavs.protocol d5e4b2f 
>   src/ioslaves/trash/CMakeLists.txt 05161cd 
>   src/ioslaves/trash/kio_trash.cpp cb23169 
>   src/ioslaves/trash/trash.json PRE-CREATION 
>   src/ioslaves/trash/trash.protocol 7430575 
> 
> Diff: https://git.reviewboard.kde.org/r/125869/diff/
> 
> 
> Testing
> ---
> 
> Tests still work (one needed patching, as the exec line contains now the full 
> path).
> 
> Correction: Somehow the ./autotests/jobtest test is unstable for me here, 
> sometimes it works, sometimes not :/ but even without this change.
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

2015-11-01 Thread David Faure 


> On Oct. 30, 2015, 7:29 a.m., David Faure wrote:
> > src/ioslaves/trash/trash.json, line 6
> > 
> >
> > That doesn't look very English to me ;)
> > 
> > The original is:
> > 
> > ExtraNames=Original Path,Deletion Date
> > 
> > But this shows a problem: missing support for translating this field. 
> > We didn't realize there was a translatable field in these files. Please add 
> > support for translations, like was done for other json files (talk to e.g. 
> > Luigi Toscano).
> 
> Christoph Cullmann wrote:
> Hmm, then we have a problem: We can no longer convert the stuff and 
> remove the .protocol files, or?
> 
> Christoph Cullmann wrote:
> Ok, did read up a bit, ExtraNames seems to be the only translated thing 
> (at least if I read KProtocolInfo docs the right way).
> Can do the same trick as desktop2json does for that. Seems not that hard.
> But then we need CMake stuff for it, or? To convert on the fly to have 
> translations using the .protocol files like we have ATM in the .desktop files 
> for the plugin stuff.
> 
> David Faure wrote:
> I don't think you're looking in the right direction. AFAIK there is 
> support for translating json files directly in l10n (json -> po -> json) 
> these days. As I said, please ask Luigi or maybe Albert.
> 
> Christoph Cullmann wrote:
> Ok ;=)
> 
> Christoph Cullmann wrote:
> CC Luigi here, too.
> I looked again at what we have btw. in the other frameworks and I nowhere 
> really found any json -> po and back way, but that doesn't mean its not there 
> ;=)

I'm pretty sure this is all done in the l10n module, not in the other 
frameworks.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125869/#review87721
---


On Nov. 1, 2015, 6:13 p.m., Christoph Cullmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125869/
> ---
> 
> (Updated Nov. 1, 2015, 6:13 p.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid, Alex Richardson, David 
> Faure, and Luigi Toscano.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Convert all io slave .protocol data to json and embed it.
> Allows easier deployment of the slaves.
> 
> 
> Diffs
> -
> 
>   src/ioslaves/http/CMakeLists.txt 76a8e28 
>   src/ioslaves/help/main_ghelp.cpp 59c8558 
>   src/ioslaves/help/main.cpp 9939196 
>   src/ioslaves/help/help.protocol 1deefe5 
>   src/ioslaves/help/help.json PRE-CREATION 
>   src/ioslaves/help/ghelp.protocol d2a642a 
>   src/ioslaves/help/ghelp.json PRE-CREATION 
>   src/ioslaves/help/CMakeLists.txt 867b59d 
>   src/ioslaves/ftp/ftp.protocol 4c5f80c 
>   src/ioslaves/ftp/ftp.json PRE-CREATION 
>   src/ioslaves/ftp/ftp.cpp 382723a 
>   src/ioslaves/ftp/CMakeLists.txt 04f5600 
>   src/ioslaves/file/file.protocol 523c0f5 
>   src/ioslaves/file/file.json PRE-CREATION 
>   src/ioslaves/file/file.cpp 5ef1587 
>   src/ioslaves/file/CMakeLists.txt cb85cfb 
>   autotests/kprotocolinfotest.cpp fa3ad38 
>   src/ioslaves/http/http.protocol 49e5dc5 
>   src/ioslaves/http/https.protocol c15d06f 
>   src/ioslaves/http/webdav.protocol 05c977a 
>   src/ioslaves/http/webdavs.protocol d5e4b2f 
>   src/ioslaves/trash/CMakeLists.txt 05161cd 
>   src/ioslaves/trash/kio_trash.cpp cb23169 
>   src/ioslaves/trash/trash.json PRE-CREATION 
>   src/ioslaves/trash/trash.protocol 7430575 
> 
> Diff: https://git.reviewboard.kde.org/r/125869/diff/
> 
> 
> Testing
> ---
> 
> Tests still work (one needed patching, as the exec line contains now the full 
> path).
> 
> Correction: Somehow the ./autotests/jobtest test is unstable for me here, 
> sometimes it works, sometimes not :/ but even without this change.
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

2015-10-30 Thread Christoph Cullmann 


> On Oct. 30, 2015, 7:29 a.m., David Faure wrote:
> > src/ioslaves/trash/trash.json, line 6
> > 
> >
> > That doesn't look very English to me ;)
> > 
> > The original is:
> > 
> > ExtraNames=Original Path,Deletion Date
> > 
> > But this shows a problem: missing support for translating this field. 
> > We didn't realize there was a translatable field in these files. Please add 
> > support for translations, like was done for other json files (talk to e.g. 
> > Luigi Toscano).

Hmm, then we have a problem: We can no longer convert the stuff and remove the 
.protocol files, or?


- Christoph


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125869/#review87721
---


On Oct. 29, 2015, 5:03 p.m., Christoph Cullmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125869/
> ---
> 
> (Updated Oct. 29, 2015, 5:03 p.m.)
> 
> 
> Review request for KDE Frameworks, Alex Richardson and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Convert all io slave .protocol data to json and embed it.
> Allows easier deployment of the slaves.
> 
> 
> Diffs
> -
> 
>   src/ioslaves/http/CMakeLists.txt 76a8e28 
>   src/ioslaves/help/main_ghelp.cpp 59c8558 
>   src/ioslaves/help/main.cpp 9939196 
>   src/ioslaves/help/help.protocol 1deefe5 
>   src/ioslaves/help/help.json PRE-CREATION 
>   src/ioslaves/help/ghelp.protocol d2a642a 
>   src/ioslaves/help/ghelp.json PRE-CREATION 
>   src/ioslaves/help/CMakeLists.txt 867b59d 
>   src/ioslaves/ftp/ftp.protocol 4c5f80c 
>   src/ioslaves/ftp/ftp.json PRE-CREATION 
>   src/ioslaves/ftp/ftp.cpp 382723a 
>   src/ioslaves/ftp/CMakeLists.txt 04f5600 
>   src/ioslaves/file/file.protocol 523c0f5 
>   src/ioslaves/file/file.json PRE-CREATION 
>   src/ioslaves/file/file.cpp 5ef1587 
>   src/ioslaves/file/CMakeLists.txt cb85cfb 
>   autotests/kprotocolinfotest.cpp fa3ad38 
>   src/ioslaves/http/http.protocol 49e5dc5 
>   src/ioslaves/http/https.protocol c15d06f 
>   src/ioslaves/http/webdav.protocol 05c977a 
>   src/ioslaves/http/webdavs.protocol d5e4b2f 
>   src/ioslaves/trash/CMakeLists.txt 05161cd 
>   src/ioslaves/trash/kio_trash.cpp cb23169 
>   src/ioslaves/trash/trash.json PRE-CREATION 
>   src/ioslaves/trash/trash.protocol 7430575 
> 
> Diff: https://git.reviewboard.kde.org/r/125869/diff/
> 
> 
> Testing
> ---
> 
> Tests still work (one needed patching, as the exec line contains now the full 
> path).
> 
> Correction: Somehow the ./autotests/jobtest test is unstable for me here, 
> sometimes it works, sometimes not :/ but even without this change.
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

2015-10-30 Thread Christoph Cullmann 


> On Oct. 30, 2015, 7:29 a.m., David Faure wrote:
> > src/ioslaves/trash/trash.json, line 6
> > 
> >
> > That doesn't look very English to me ;)
> > 
> > The original is:
> > 
> > ExtraNames=Original Path,Deletion Date
> > 
> > But this shows a problem: missing support for translating this field. 
> > We didn't realize there was a translatable field in these files. Please add 
> > support for translations, like was done for other json files (talk to e.g. 
> > Luigi Toscano).
> 
> Christoph Cullmann wrote:
> Hmm, then we have a problem: We can no longer convert the stuff and 
> remove the .protocol files, or?

Ok, did read up a bit, ExtraNames seems to be the only translated thing (at 
least if I read KProtocolInfo docs the right way).
Can do the same trick as desktop2json does for that. Seems not that hard.
But then we need CMake stuff for it, or? To convert on the fly to have 
translations using the .protocol files like we have ATM in the .desktop files 
for the plugin stuff.


- Christoph


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125869/#review87721
---


On Oct. 29, 2015, 5:03 p.m., Christoph Cullmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125869/
> ---
> 
> (Updated Oct. 29, 2015, 5:03 p.m.)
> 
> 
> Review request for KDE Frameworks, Alex Richardson and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Convert all io slave .protocol data to json and embed it.
> Allows easier deployment of the slaves.
> 
> 
> Diffs
> -
> 
>   src/ioslaves/http/CMakeLists.txt 76a8e28 
>   src/ioslaves/help/main_ghelp.cpp 59c8558 
>   src/ioslaves/help/main.cpp 9939196 
>   src/ioslaves/help/help.protocol 1deefe5 
>   src/ioslaves/help/help.json PRE-CREATION 
>   src/ioslaves/help/ghelp.protocol d2a642a 
>   src/ioslaves/help/ghelp.json PRE-CREATION 
>   src/ioslaves/help/CMakeLists.txt 867b59d 
>   src/ioslaves/ftp/ftp.protocol 4c5f80c 
>   src/ioslaves/ftp/ftp.json PRE-CREATION 
>   src/ioslaves/ftp/ftp.cpp 382723a 
>   src/ioslaves/ftp/CMakeLists.txt 04f5600 
>   src/ioslaves/file/file.protocol 523c0f5 
>   src/ioslaves/file/file.json PRE-CREATION 
>   src/ioslaves/file/file.cpp 5ef1587 
>   src/ioslaves/file/CMakeLists.txt cb85cfb 
>   autotests/kprotocolinfotest.cpp fa3ad38 
>   src/ioslaves/http/http.protocol 49e5dc5 
>   src/ioslaves/http/https.protocol c15d06f 
>   src/ioslaves/http/webdav.protocol 05c977a 
>   src/ioslaves/http/webdavs.protocol d5e4b2f 
>   src/ioslaves/trash/CMakeLists.txt 05161cd 
>   src/ioslaves/trash/kio_trash.cpp cb23169 
>   src/ioslaves/trash/trash.json PRE-CREATION 
>   src/ioslaves/trash/trash.protocol 7430575 
> 
> Diff: https://git.reviewboard.kde.org/r/125869/diff/
> 
> 
> Testing
> ---
> 
> Tests still work (one needed patching, as the exec line contains now the full 
> path).
> 
> Correction: Somehow the ./autotests/jobtest test is unstable for me here, 
> sometimes it works, sometimes not :/ but even without this change.
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

2015-10-30 Thread David Faure 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125869/#review87721
---



src/ioslaves/file/file.cpp (line 80)


embedd -> embed



src/ioslaves/trash/trash.json (line 6)


That doesn't look very English to me ;)

The original is:

ExtraNames=Original Path,Deletion Date

But this shows a problem: missing support for translating this field. We 
didn't realize there was a translatable field in these files. Please add 
support for translations, like was done for other json files (talk to e.g. 
Luigi Toscano).


- David Faure


On Oct. 29, 2015, 5:03 p.m., Christoph Cullmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125869/
> ---
> 
> (Updated Oct. 29, 2015, 5:03 p.m.)
> 
> 
> Review request for KDE Frameworks, Alex Richardson and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Convert all io slave .protocol data to json and embed it.
> Allows easier deployment of the slaves.
> 
> 
> Diffs
> -
> 
>   src/ioslaves/http/CMakeLists.txt 76a8e28 
>   src/ioslaves/help/main_ghelp.cpp 59c8558 
>   src/ioslaves/help/main.cpp 9939196 
>   src/ioslaves/help/help.protocol 1deefe5 
>   src/ioslaves/help/help.json PRE-CREATION 
>   src/ioslaves/help/ghelp.protocol d2a642a 
>   src/ioslaves/help/ghelp.json PRE-CREATION 
>   src/ioslaves/help/CMakeLists.txt 867b59d 
>   src/ioslaves/ftp/ftp.protocol 4c5f80c 
>   src/ioslaves/ftp/ftp.json PRE-CREATION 
>   src/ioslaves/ftp/ftp.cpp 382723a 
>   src/ioslaves/ftp/CMakeLists.txt 04f5600 
>   src/ioslaves/file/file.protocol 523c0f5 
>   src/ioslaves/file/file.json PRE-CREATION 
>   src/ioslaves/file/file.cpp 5ef1587 
>   src/ioslaves/file/CMakeLists.txt cb85cfb 
>   autotests/kprotocolinfotest.cpp fa3ad38 
>   src/ioslaves/http/http.protocol 49e5dc5 
>   src/ioslaves/http/https.protocol c15d06f 
>   src/ioslaves/http/webdav.protocol 05c977a 
>   src/ioslaves/http/webdavs.protocol d5e4b2f 
>   src/ioslaves/trash/CMakeLists.txt 05161cd 
>   src/ioslaves/trash/kio_trash.cpp cb23169 
>   src/ioslaves/trash/trash.json PRE-CREATION 
>   src/ioslaves/trash/trash.protocol 7430575 
> 
> Diff: https://git.reviewboard.kde.org/r/125869/diff/
> 
> 
> Testing
> ---
> 
> Tests still work (one needed patching, as the exec line contains now the full 
> path).
> 
> Correction: Somehow the ./autotests/jobtest test is unstable for me here, 
> sometimes it works, sometimes not :/ but even without this change.
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

2015-10-30 Thread Christoph Cullmann 


> On Oct. 30, 2015, 7:29 a.m., David Faure wrote:
> > src/ioslaves/trash/trash.json, line 6
> > 
> >
> > That doesn't look very English to me ;)
> > 
> > The original is:
> > 
> > ExtraNames=Original Path,Deletion Date
> > 
> > But this shows a problem: missing support for translating this field. 
> > We didn't realize there was a translatable field in these files. Please add 
> > support for translations, like was done for other json files (talk to e.g. 
> > Luigi Toscano).
> 
> Christoph Cullmann wrote:
> Hmm, then we have a problem: We can no longer convert the stuff and 
> remove the .protocol files, or?
> 
> Christoph Cullmann wrote:
> Ok, did read up a bit, ExtraNames seems to be the only translated thing 
> (at least if I read KProtocolInfo docs the right way).
> Can do the same trick as desktop2json does for that. Seems not that hard.
> But then we need CMake stuff for it, or? To convert on the fly to have 
> translations using the .protocol files like we have ATM in the .desktop files 
> for the plugin stuff.
> 
> David Faure wrote:
> I don't think you're looking in the right direction. AFAIK there is 
> support for translating json files directly in l10n (json -> po -> json) 
> these days. As I said, please ask Luigi or maybe Albert.

Ok ;=)


- Christoph


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125869/#review87721
---


On Oct. 29, 2015, 5:03 p.m., Christoph Cullmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125869/
> ---
> 
> (Updated Oct. 29, 2015, 5:03 p.m.)
> 
> 
> Review request for KDE Frameworks, Alex Richardson and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Convert all io slave .protocol data to json and embed it.
> Allows easier deployment of the slaves.
> 
> 
> Diffs
> -
> 
>   src/ioslaves/http/CMakeLists.txt 76a8e28 
>   src/ioslaves/help/main_ghelp.cpp 59c8558 
>   src/ioslaves/help/main.cpp 9939196 
>   src/ioslaves/help/help.protocol 1deefe5 
>   src/ioslaves/help/help.json PRE-CREATION 
>   src/ioslaves/help/ghelp.protocol d2a642a 
>   src/ioslaves/help/ghelp.json PRE-CREATION 
>   src/ioslaves/help/CMakeLists.txt 867b59d 
>   src/ioslaves/ftp/ftp.protocol 4c5f80c 
>   src/ioslaves/ftp/ftp.json PRE-CREATION 
>   src/ioslaves/ftp/ftp.cpp 382723a 
>   src/ioslaves/ftp/CMakeLists.txt 04f5600 
>   src/ioslaves/file/file.protocol 523c0f5 
>   src/ioslaves/file/file.json PRE-CREATION 
>   src/ioslaves/file/file.cpp 5ef1587 
>   src/ioslaves/file/CMakeLists.txt cb85cfb 
>   autotests/kprotocolinfotest.cpp fa3ad38 
>   src/ioslaves/http/http.protocol 49e5dc5 
>   src/ioslaves/http/https.protocol c15d06f 
>   src/ioslaves/http/webdav.protocol 05c977a 
>   src/ioslaves/http/webdavs.protocol d5e4b2f 
>   src/ioslaves/trash/CMakeLists.txt 05161cd 
>   src/ioslaves/trash/kio_trash.cpp cb23169 
>   src/ioslaves/trash/trash.json PRE-CREATION 
>   src/ioslaves/trash/trash.protocol 7430575 
> 
> Diff: https://git.reviewboard.kde.org/r/125869/diff/
> 
> 
> Testing
> ---
> 
> Tests still work (one needed patching, as the exec line contains now the full 
> path).
> 
> Correction: Somehow the ./autotests/jobtest test is unstable for me here, 
> sometimes it works, sometimes not :/ but even without this change.
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

2015-10-30 Thread David Faure 


> On Oct. 30, 2015, 7:29 a.m., David Faure wrote:
> > src/ioslaves/trash/trash.json, line 6
> > 
> >
> > That doesn't look very English to me ;)
> > 
> > The original is:
> > 
> > ExtraNames=Original Path,Deletion Date
> > 
> > But this shows a problem: missing support for translating this field. 
> > We didn't realize there was a translatable field in these files. Please add 
> > support for translations, like was done for other json files (talk to e.g. 
> > Luigi Toscano).
> 
> Christoph Cullmann wrote:
> Hmm, then we have a problem: We can no longer convert the stuff and 
> remove the .protocol files, or?
> 
> Christoph Cullmann wrote:
> Ok, did read up a bit, ExtraNames seems to be the only translated thing 
> (at least if I read KProtocolInfo docs the right way).
> Can do the same trick as desktop2json does for that. Seems not that hard.
> But then we need CMake stuff for it, or? To convert on the fly to have 
> translations using the .protocol files like we have ATM in the .desktop files 
> for the plugin stuff.

I don't think you're looking in the right direction. AFAIK there is support for 
translating json files directly in l10n (json -> po -> json) these days. As I 
said, please ask Luigi or maybe Albert.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125869/#review87721
---


On Oct. 29, 2015, 5:03 p.m., Christoph Cullmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125869/
> ---
> 
> (Updated Oct. 29, 2015, 5:03 p.m.)
> 
> 
> Review request for KDE Frameworks, Alex Richardson and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Convert all io slave .protocol data to json and embed it.
> Allows easier deployment of the slaves.
> 
> 
> Diffs
> -
> 
>   src/ioslaves/http/CMakeLists.txt 76a8e28 
>   src/ioslaves/help/main_ghelp.cpp 59c8558 
>   src/ioslaves/help/main.cpp 9939196 
>   src/ioslaves/help/help.protocol 1deefe5 
>   src/ioslaves/help/help.json PRE-CREATION 
>   src/ioslaves/help/ghelp.protocol d2a642a 
>   src/ioslaves/help/ghelp.json PRE-CREATION 
>   src/ioslaves/help/CMakeLists.txt 867b59d 
>   src/ioslaves/ftp/ftp.protocol 4c5f80c 
>   src/ioslaves/ftp/ftp.json PRE-CREATION 
>   src/ioslaves/ftp/ftp.cpp 382723a 
>   src/ioslaves/ftp/CMakeLists.txt 04f5600 
>   src/ioslaves/file/file.protocol 523c0f5 
>   src/ioslaves/file/file.json PRE-CREATION 
>   src/ioslaves/file/file.cpp 5ef1587 
>   src/ioslaves/file/CMakeLists.txt cb85cfb 
>   autotests/kprotocolinfotest.cpp fa3ad38 
>   src/ioslaves/http/http.protocol 49e5dc5 
>   src/ioslaves/http/https.protocol c15d06f 
>   src/ioslaves/http/webdav.protocol 05c977a 
>   src/ioslaves/http/webdavs.protocol d5e4b2f 
>   src/ioslaves/trash/CMakeLists.txt 05161cd 
>   src/ioslaves/trash/kio_trash.cpp cb23169 
>   src/ioslaves/trash/trash.json PRE-CREATION 
>   src/ioslaves/trash/trash.protocol 7430575 
> 
> Diff: https://git.reviewboard.kde.org/r/125869/diff/
> 
> 
> Testing
> ---
> 
> Tests still work (one needed patching, as the exec line contains now the full 
> path).
> 
> Correction: Somehow the ./autotests/jobtest test is unstable for me here, 
> sometimes it works, sometimes not :/ but even without this change.
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 125869: Convert all io slave .protocol data to json and embed it.

2015-10-29 Thread Christoph Cullmann 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125869/
---

Review request for KDE Frameworks, Alex Richardson and David Faure.


Repository: kio


Description
---

Convert all io slave .protocol data to json and embed it.
Allows easier deployment of the slaves.


Diffs
-

  src/ioslaves/http/CMakeLists.txt 76a8e28 
  src/ioslaves/help/main_ghelp.cpp 59c8558 
  src/ioslaves/help/main.cpp 9939196 
  src/ioslaves/help/help.protocol 1deefe5 
  src/ioslaves/help/help.json PRE-CREATION 
  src/ioslaves/help/ghelp.protocol d2a642a 
  src/ioslaves/help/ghelp.json PRE-CREATION 
  src/ioslaves/help/CMakeLists.txt 867b59d 
  src/ioslaves/ftp/ftp.protocol 4c5f80c 
  src/ioslaves/ftp/ftp.json PRE-CREATION 
  src/ioslaves/ftp/ftp.cpp 382723a 
  src/ioslaves/ftp/CMakeLists.txt 04f5600 
  src/ioslaves/file/file.protocol 523c0f5 
  src/ioslaves/file/file.json PRE-CREATION 
  src/ioslaves/file/file.cpp 5ef1587 
  src/ioslaves/file/CMakeLists.txt cb85cfb 
  autotests/kprotocolinfotest.cpp fa3ad38 
  src/ioslaves/http/http.protocol 49e5dc5 
  src/ioslaves/http/https.protocol c15d06f 
  src/ioslaves/http/webdav.protocol 05c977a 
  src/ioslaves/http/webdavs.protocol d5e4b2f 
  src/ioslaves/trash/CMakeLists.txt 05161cd 
  src/ioslaves/trash/kio_trash.cpp cb23169 
  src/ioslaves/trash/trash.json PRE-CREATION 
  src/ioslaves/trash/trash.protocol 7430575 

Diff: https://git.reviewboard.kde.org/r/125869/diff/


Testing
---

Tests still work (one needed patching, as the exec line contains now the full 
path).


Thanks,

Christoph Cullmann

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

2015-10-29 Thread Christoph Cullmann 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125869/
---

(Updated Oct. 29, 2015, 5:03 p.m.)


Review request for KDE Frameworks, Alex Richardson and David Faure.


Repository: kio


Description
---

Convert all io slave .protocol data to json and embed it.
Allows easier deployment of the slaves.


Diffs
-

  src/ioslaves/http/CMakeLists.txt 76a8e28 
  src/ioslaves/help/main_ghelp.cpp 59c8558 
  src/ioslaves/help/main.cpp 9939196 
  src/ioslaves/help/help.protocol 1deefe5 
  src/ioslaves/help/help.json PRE-CREATION 
  src/ioslaves/help/ghelp.protocol d2a642a 
  src/ioslaves/help/ghelp.json PRE-CREATION 
  src/ioslaves/help/CMakeLists.txt 867b59d 
  src/ioslaves/ftp/ftp.protocol 4c5f80c 
  src/ioslaves/ftp/ftp.json PRE-CREATION 
  src/ioslaves/ftp/ftp.cpp 382723a 
  src/ioslaves/ftp/CMakeLists.txt 04f5600 
  src/ioslaves/file/file.protocol 523c0f5 
  src/ioslaves/file/file.json PRE-CREATION 
  src/ioslaves/file/file.cpp 5ef1587 
  src/ioslaves/file/CMakeLists.txt cb85cfb 
  autotests/kprotocolinfotest.cpp fa3ad38 
  src/ioslaves/http/http.protocol 49e5dc5 
  src/ioslaves/http/https.protocol c15d06f 
  src/ioslaves/http/webdav.protocol 05c977a 
  src/ioslaves/http/webdavs.protocol d5e4b2f 
  src/ioslaves/trash/CMakeLists.txt 05161cd 
  src/ioslaves/trash/kio_trash.cpp cb23169 
  src/ioslaves/trash/trash.json PRE-CREATION 
  src/ioslaves/trash/trash.protocol 7430575 

Diff: https://git.reviewboard.kde.org/r/125869/diff/


Testing (updated)
---

Tests still work (one needed patching, as the exec line contains now the full 
path).

Correction: Somehow the ./autotests/jobtest test is unstable for me here, 
sometimes it works, sometimes not :/ but even without this change.


Thanks,

Christoph Cullmann

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel