Re: Review Request 126057: Use KDE_INSTALL_ICONDIR to install the icons
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126057/
---
(Updated Nov. 22, 2015, 11:31 a.m.)
Status
--
This change has been marked as submitted.
Review request for KDE Frameworks and andreas kainz.
Changes
---
Submitted with commit a341a4a9fc8290cb9d453ec12f3bca79b09f92bd by Heiko Becker
to branch master.
Repository: oxygen-icons5
Description
---
It was previously hard-coded to prefix/share which is not helpful on a
multiarch layout, where the prefix might be something like /usr/${arch}
but arch independent files should still go into /usr/share.
REVIEW: 126057
Diffs
-
CMakeLists.txt 85962199e481572e05e45dab6848983b8f22c3e1
Diff: https://git.reviewboard.kde.org/r/126057/diff/
Testing
---
Icons get installed into the desired location.
Thanks,
Heiko Becker
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 126057: Use KDE_INSTALL_ICONDIR to install the icons
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126057/
---
(Updated Nov. 17, 2015, 12:45 nachm.)
Review request for KDE Frameworks and andreas kainz.
Changes
---
Removed win32 handling, s/FULL_//
Summary (updated)
-
Use KDE_INSTALL_ICONDIR to install the icons
Repository: oxygen-icons5
Description (updated)
---
It was previously hard-coded to prefix/share which is not helpful on a
multiarch layout, where the prefix might be something like /usr/${arch}
but arch independent files should still go into /usr/share.
REVIEW: 126057
Diffs (updated)
-
CMakeLists.txt 85962199e481572e05e45dab6848983b8f22c3e1
Diff: https://git.reviewboard.kde.org/r/126057/diff/
Testing
---
Icons get installed into the desired location.
Thanks,
Heiko Becker
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 126057: Use KDE_INSTALL_ICONDIR to install the icons
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126057/#review88500
---
Ship it!
Ship It!
- Alex Merry
On Nov. 17, 2015, 12:45 p.m., Heiko Becker wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126057/
> ---
>
> (Updated Nov. 17, 2015, 12:45 p.m.)
>
>
> Review request for KDE Frameworks and andreas kainz.
>
>
> Repository: oxygen-icons5
>
>
> Description
> ---
>
> It was previously hard-coded to prefix/share which is not helpful on a
> multiarch layout, where the prefix might be something like /usr/${arch}
> but arch independent files should still go into /usr/share.
>
> REVIEW: 126057
>
>
> Diffs
> -
>
> CMakeLists.txt 85962199e481572e05e45dab6848983b8f22c3e1
>
> Diff: https://git.reviewboard.kde.org/r/126057/diff/
>
>
> Testing
> ---
>
> Icons get installed into the desired location.
>
>
> Thanks,
>
> Heiko Becker
>
>
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
