Re: Review Request 126366: Make KPluginMetaData constructible from a json path.

2015-12-15 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126366/
---

(Updated Dec. 15, 2015, 4:14 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit 64bf23c85bb86e8e1a15bc7baf875ab0b6a8 by Aleix Pol to 
branch master.


Repository: kcoreaddons


Description
---

Loads the json file upon construction. Simplifies adoption of json metadata 
files for KPackage.


Diffs
-

  src/lib/plugin/kpluginmetadata.h a91b94a 
  src/lib/plugin/kpluginmetadata.cpp 3674360 

Diff: https://git.reviewboard.kde.org/r/126366/diff/


Testing
---

Tests still pass.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 126366: Make KPluginMetaData constructible from a json path.

2015-12-15 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126366/
---

Review request for KDE Frameworks.


Repository: kcoreaddons


Description
---

Loads the json file upon construction. Simplifies adoption of json metadata 
files for KPackage.


Diffs
-

  src/lib/plugin/kpluginmetadata.h a91b94a 
  src/lib/plugin/kpluginmetadata.cpp 3674360 

Diff: https://git.reviewboard.kde.org/r/126366/diff/


Testing
---

Tests still pass.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126366: Make KPluginMetaData constructible from a json path.

2015-12-15 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126366/
---

(Updated Dec. 15, 2015, 4:27 p.m.)


Review request for KDE Frameworks.


Changes
---

turn assert into warning.


Repository: kcoreaddons


Description
---

Loads the json file upon construction. Simplifies adoption of json metadata 
files for KPackage.


Diffs (updated)
-

  src/lib/plugin/kpluginmetadata.h a91b94a 
  src/lib/plugin/kpluginmetadata.cpp 3674360 

Diff: https://git.reviewboard.kde.org/r/126366/diff/


Testing
---

Tests still pass.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126366: Make KPluginMetaData constructible from a json path.

2015-12-15 Thread Alex Richardson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126366/#review89555
---

Ship it!


If you have time, a minimal unit test would be nice to make sure we don't break 
this in future.

- Alex Richardson


On Dec. 15, 2015, 3:27 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126366/
> ---
> 
> (Updated Dec. 15, 2015, 3:27 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Loads the json file upon construction. Simplifies adoption of json metadata 
> files for KPackage.
> 
> 
> Diffs
> -
> 
>   src/lib/plugin/kpluginmetadata.h a91b94a 
>   src/lib/plugin/kpluginmetadata.cpp 3674360 
> 
> Diff: https://git.reviewboard.kde.org/r/126366/diff/
> 
> 
> Testing
> ---
> 
> Tests still pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126366: Make KPluginMetaData constructible from a json path.

2015-12-15 Thread Sebastian Kügler 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126366/#review89553
---


An autotest would be nice, and I think the ASSERT is too aggressive.


src/lib/plugin/kpluginmetadata.cpp (line 68)


I don't like the assert here. It may be third party data, and we're 
crashing the application then?


- Sebastian Kügler


On Dec. 15, 2015, 3:04 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126366/
> ---
> 
> (Updated Dec. 15, 2015, 3:04 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Loads the json file upon construction. Simplifies adoption of json metadata 
> files for KPackage.
> 
> 
> Diffs
> -
> 
>   src/lib/plugin/kpluginmetadata.h a91b94a 
>   src/lib/plugin/kpluginmetadata.cpp 3674360 
> 
> Diff: https://git.reviewboard.kde.org/r/126366/diff/
> 
> 
> Testing
> ---
> 
> Tests still pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel