Re: Review Request 127870: plasma-framework: AppletInterface::downloadPath()

2016-05-26 Thread Allen Winter 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127870/
---

(Updated May 27, 2016, 1:11 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit 97d8cd574c08ae3af1d98cfca2c3390a9265562e by Allen Winter 
to branch master.


Repository: plasma-framework


Description
---

Deprecate downloadPath(const QString ) in favor of downloadPath() since 
the file argument is not used.


Diffs
-

  src/scriptengines/qml/plasmoid/appletinterface.h 6cf71aa 
  src/scriptengines/qml/plasmoid/appletinterface.cpp 876af2c 

Diff: https://git.reviewboard.kde.org/r/127870/diff/


Testing
---

compiles. make test still passes.


Thanks,

Allen Winter

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127870: plasma-framework: AppletInterface::downloadPath()

2016-05-26 Thread Sebastian Kügler 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127870/#review95815
---


Ship it!




ping :)

- Sebastian Kügler


On May 8, 2016, 4:15 p.m., Allen Winter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127870/
> ---
> 
> (Updated May 8, 2016, 4:15 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Deprecate downloadPath(const QString ) in favor of downloadPath() since 
> the file argument is not used.
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/plasmoid/appletinterface.h 6cf71aa 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 876af2c 
> 
> Diff: https://git.reviewboard.kde.org/r/127870/diff/
> 
> 
> Testing
> ---
> 
> compiles. make test still passes.
> 
> 
> Thanks,
> 
> Allen Winter
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127870: plasma-framework: AppletInterface::downloadPath()

2016-05-19 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127870/#review95613
---




src/scriptengines/qml/plasmoid/appletinterface.h (line 279)


If at it, shouldn't this be const?


- Kai Uwe Broulik


On Mai 8, 2016, 4:15 nachm., Allen Winter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127870/
> ---
> 
> (Updated Mai 8, 2016, 4:15 nachm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Deprecate downloadPath(const QString ) in favor of downloadPath() since 
> the file argument is not used.
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/plasmoid/appletinterface.h 6cf71aa 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 876af2c 
> 
> Diff: https://git.reviewboard.kde.org/r/127870/diff/
> 
> 
> Testing
> ---
> 
> compiles. make test still passes.
> 
> 
> Thanks,
> 
> Allen Winter
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127870: plasma-framework: AppletInterface::downloadPath()

2016-05-19 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127870/#review95612
---


Ship it!




Ship It!

- Marco Martin


On May 8, 2016, 4:15 p.m., Allen Winter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127870/
> ---
> 
> (Updated May 8, 2016, 4:15 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Deprecate downloadPath(const QString ) in favor of downloadPath() since 
> the file argument is not used.
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/plasmoid/appletinterface.h 6cf71aa 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 876af2c 
> 
> Diff: https://git.reviewboard.kde.org/r/127870/diff/
> 
> 
> Testing
> ---
> 
> compiles. make test still passes.
> 
> 
> Thanks,
> 
> Allen Winter
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127870: plasma-framework: AppletInterface::downloadPath()

2016-05-08 Thread Allen Winter 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127870/
---

Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

Deprecate downloadPath(const QString ) in favor of downloadPath() since 
the file argument is not used.


Diffs
-

  src/scriptengines/qml/plasmoid/appletinterface.h 6cf71aa 
  src/scriptengines/qml/plasmoid/appletinterface.cpp 876af2c 

Diff: https://git.reviewboard.kde.org/r/127870/diff/


Testing
---

compiles. make test still passes.


Thanks,

Allen Winter

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel