Re: Review Request 128002: address alignment issue with the OS X native "macintosh" style
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128002/ --- (Updated June 9, 2016, 5:10 p.m.) Status -- This change has been marked as submitted. Review request for KDE Software on Mac OS X, KDE Frameworks and Christoph Feck. Changes --- Submitted with commit bd3b3c8b8af249c1dc3c020c09b8bab479411503 by René J.V. Bertin to branch master. Repository: kio Description --- This patch addresses a misalignment issue in KUrlNavigator when using the native "macintosh" widget style on OS X. Cf. https://bugs.kde.org/show_bug.cgi?id=296845 Diffs - src/filewidgets/kurlnavigatorbuttonbase.cpp 8b06bfa Diff: https://git.reviewboard.kde.org/r/128002/diff/ Testing --- On OS X 10.9 with frameworks 5.20.0 (sic), Qt 5.6.0 using my MacPorts build. The additional attribute doesn't have any effects for me with other styles, but this still has to be verified on other platforms. File Attachments The widget concerned in Kate's interface, showing the result with and without the patch. It is clear which is which. https://git.reviewboard.kde.org/media/uploaded/files/2016/05/24/ca3c7872-68ee-4ed6-b1f4-4d0b05111be1__Screen_Shot_2016-05-24_at_14.37.43.png other widgets remain to be done https://git.reviewboard.kde.org/media/uploaded/files/2016/05/24/71b20243-8dda-4f22-89e1-21559b767fd5__Screen_Shot_2016-05-24_at_14.38.30.png Thanks, René J.V. Bertin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 128002: address alignment issue with the OS X native "macintosh" style
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128002/#review95755 --- Ship it! Also the navigator got fixed by you after all. Thanks, René! - Marko Käning On May 24, 2016, 2:50 p.m., René J.V. Bertin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128002/ > --- > > (Updated May 24, 2016, 2:50 p.m.) > > > Review request for KDE Software on Mac OS X and KDE Frameworks. > > > Repository: kio > > > Description > --- > > This patch addresses a misalignment issue in KUrlNavigator when using the > native "macintosh" widget style on OS X. > > Cf. https://bugs.kde.org/show_bug.cgi?id=296845 > > > Diffs > - > > src/filewidgets/kurlnavigatorbuttonbase.cpp 8b06bfa > > Diff: https://git.reviewboard.kde.org/r/128002/diff/ > > > Testing > --- > > On OS X 10.9 with frameworks 5.20.0 (sic), Qt 5.6.0 using my MacPorts build. > > The additional attribute doesn't have any effects for me with other styles, > but this still has to be verified on other platforms. > > > File Attachments > > > The widget concerned in Kate's interface, showing the result with and without > the patch. It is clear which is which. > > https://git.reviewboard.kde.org/media/uploaded/files/2016/05/24/ca3c7872-68ee-4ed6-b1f4-4d0b05111be1__Screen_Shot_2016-05-24_at_14.37.43.png > other widgets remain to be done > > https://git.reviewboard.kde.org/media/uploaded/files/2016/05/24/71b20243-8dda-4f22-89e1-21559b767fd5__Screen_Shot_2016-05-24_at_14.38.30.png > > > Thanks, > > René J.V. Bertin > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 128002: address alignment issue with the OS X native "macintosh" style
On Tuesday May 24 2016 12:50:38 René J.V. Bertin wrote: > other widgets remain to be done > https://git.reviewboard.kde.org/r/128002/file/3043/ Does someone know (without delving deep into source code) what widget classes I might try to patch with a similar fix? R. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 128002: address alignment issue with the OS X native "macintosh" style
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128002/ --- Review request for KDE Software on Mac OS X and KDE Frameworks. Repository: kio Description --- This patch addresses a misalignment issue in KUrlNavigator when using the native "macintosh" widget style on OS X. Cf. https://bugs.kde.org/show_bug.cgi?id=296845 Diffs - src/filewidgets/kurlnavigatorbuttonbase.cpp 8b06bfa Diff: https://git.reviewboard.kde.org/r/128002/diff/ Testing --- On OS X 10.9 with frameworks 5.20.0 (sic), Qt 5.6.0 using my MacPorts build. The additional attribute doesn't have any effects for me with other styles, but this still has to be verified on other platforms. File Attachments The widget concerned in Kate's interface, showing the result with and without the patch. It is clear which is which. https://git.reviewboard.kde.org/media/uploaded/files/2016/05/24/ca3c7872-68ee-4ed6-b1f4-4d0b05111be1__Screen_Shot_2016-05-24_at_14.37.43.png other widgets remain to be done https://git.reviewboard.kde.org/media/uploaded/files/2016/05/24/71b20243-8dda-4f22-89e1-21559b767fd5__Screen_Shot_2016-05-24_at_14.38.30.png Thanks, René J.V. Bertin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
