Re: Review Request 128582: Remove unused KF5 dependencies
> On Авг. 25, 2016, 10:02 п.п., Andreas Sturmlechner wrote: > > lddtree /usr/lib64/libKF5KrossUi.so is listing all these three dependencies > > still in use. > > Alexander Potashev wrote: > Oops... You're right: kross/src/ui/actioncollectionview.cpp uses > 1. KComboBox from KCompletion, > 2. KMessageBox from KWidgetsAddons, > 3. KActionCollection from KXmlGui. > > KrossUi compiled without problem because some other dependencies (e.g. > KParts) linked to these 3 libraries publicly (in the sense of CMake keywords > PUBLIC/PRIVATE/INTERFACE). > > Will revert this commit. Anti-patch: https://git.reviewboard.kde.org/r/128818/ - Alexander --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128582/#review98658 --- On Авг. 3, 2016, 5:23 д.п., Alexander Potashev wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128582/ > --- > > (Updated Авг. 3, 2016, 5:23 д.п.) > > > Review request for KDE Frameworks. > > > Repository: kross > > > Description > --- > > Remove unused KF5 dependencies > > > Diffs > - > > CMakeLists.txt 6bf66a6d73a20077f223c3cf9bfd642935e85da4 > > Diff: https://git.reviewboard.kde.org/r/128582/diff/ > > > Testing > --- > > Still compiles successfully. > > > Thanks, > > Alexander Potashev > >
Re: Review Request 128582: Remove unused KF5 dependencies
> On Авг. 25, 2016, 10:02 п.п., Andreas Sturmlechner wrote: > > lddtree /usr/lib64/libKF5KrossUi.so is listing all these three dependencies > > still in use. Oops... You're right: kross/src/ui/actioncollectionview.cpp uses 1. KComboBox from KCompletion, 2. KMessageBox from KWidgetsAddons, 3. KActionCollection from KXmlGui. KrossUi compiled without problem because some other dependencies (e.g. KParts) linked to these 3 libraries publicly (in the sense of CMake keywords PUBLIC/PRIVATE/INTERFACE). Will revert this commit. - Alexander --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128582/#review98658 --- On Авг. 3, 2016, 5:23 д.п., Alexander Potashev wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128582/ > --- > > (Updated Авг. 3, 2016, 5:23 д.п.) > > > Review request for KDE Frameworks. > > > Repository: kross > > > Description > --- > > Remove unused KF5 dependencies > > > Diffs > - > > CMakeLists.txt 6bf66a6d73a20077f223c3cf9bfd642935e85da4 > > Diff: https://git.reviewboard.kde.org/r/128582/diff/ > > > Testing > --- > > Still compiles successfully. > > > Thanks, > > Alexander Potashev > >
Re: Review Request 128582: Remove unused KF5 dependencies
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128582/#review98658 --- lddtree /usr/lib64/libKF5KrossUi.so is listing all these three dependencies still in use. - Andreas Sturmlechner On Aug. 3, 2016, 2:23 a.m., Alexander Potashev wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128582/ > --- > > (Updated Aug. 3, 2016, 2:23 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kross > > > Description > --- > > Remove unused KF5 dependencies > > > Diffs > - > > CMakeLists.txt 6bf66a6d73a20077f223c3cf9bfd642935e85da4 > > Diff: https://git.reviewboard.kde.org/r/128582/diff/ > > > Testing > --- > > Still compiles successfully. > > > Thanks, > > Alexander Potashev > >
Re: Review Request 128582: Remove unused KF5 dependencies
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128582/ --- (Updated Aug. 3, 2016, 2:23 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit ce2a58313fbeaee6482c9718ce4dfdf5cc190875 by Alexander Potashev to branch master. Repository: kross Description --- Remove unused KF5 dependencies Diffs - CMakeLists.txt 6bf66a6d73a20077f223c3cf9bfd642935e85da4 Diff: https://git.reviewboard.kde.org/r/128582/diff/ Testing --- Still compiles successfully. Thanks, Alexander Potashev ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 128582: Remove unused KF5 dependencies
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128582/#review98024 --- Ship it! Ship It! - Aleix Pol Gonzalez On Aug. 3, 2016, 1:20 a.m., Alexander Potashev wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128582/ > --- > > (Updated Aug. 3, 2016, 1:20 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kross > > > Description > --- > > Remove unused KF5 dependencies > > > Diffs > - > > CMakeLists.txt 6bf66a6d73a20077f223c3cf9bfd642935e85da4 > > Diff: https://git.reviewboard.kde.org/r/128582/diff/ > > > Testing > --- > > Still compiles successfully. > > > Thanks, > > Alexander Potashev > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
