Re: Review Request 128595: [KUnitConversion] Add British "stone" unit of mass

2016-08-14 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128595/
---

(Updated Aug. 14, 2016, 9:52 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and David Edmundson.


Changes
---

Submitted with commit 0a72b66290dcde6cca5eea225406bd478e3d07e2 by Kai Uwe 
Broulik to branch master.


Repository: kunitconversion


Description
---

This weird unit is pretty common in the UK and equal to 6.35029318 kg.


Diffs
-

  src/mass.cpp c7bf147 
  src/unit.h e440346 

Diff: https://git.reviewboard.kde.org/r/128595/diff/


Testing
---

This is the type of stone you use to smash display windows.

https://en.wikipedia.org/wiki/Stone_(unit)

Verified that krunner spit out the same result as Google converter did.


Thanks,

Kai Uwe Broulik

Re: Review Request 128595: [KUnitConversion] Add British "stone" unit of mass

2016-08-04 Thread Kai Uwe Broulik 


> On Aug. 3, 2016, 10:18 nachm., David Edmundson wrote:
> > src/mass.cpp, line 268
> > 
> >
> > one of these should be "%1 stones" (with extra 's')
> 
> David Jarvie wrote:
> No, it's normally 'stone' for the plural as well.
> 
> David Edmundson wrote:
> I was convinced you're wrong so I did some research and apparently 
> it's..either!
> It must be regional.
> 
> http://dictionary.cambridge.org/dictionary/english/stone
> plural: stone or stones UK written abbreviation st a unit of weight equal 
> to 14 pounds or 6.35 kilograms
> 
> Whoever can up with this must have been stonesd.
> 
> David Edmundson wrote:
> *Whoever came up with this

I only heard "stone" on British television but according to Wikipedia article 
linked above "stones" is also correct in some other context. Dunno then, my gut 
feeling would be going with what the BBC uses :P


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128595/#review98074
---


On Aug. 3, 2016, 7:45 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128595/
> ---
> 
> (Updated Aug. 3, 2016, 7:45 nachm.)
> 
> 
> Review request for KDE Frameworks and David Edmundson.
> 
> 
> Repository: kunitconversion
> 
> 
> Description
> ---
> 
> This weird unit is pretty common in the UK and equal to 6.35029318 kg.
> 
> 
> Diffs
> -
> 
>   src/mass.cpp c7bf147 
>   src/unit.h e440346 
> 
> Diff: https://git.reviewboard.kde.org/r/128595/diff/
> 
> 
> Testing
> ---
> 
> This is the type of stone you use to smash display windows.
> 
> https://en.wikipedia.org/wiki/Stone_(unit)
> 
> Verified that krunner spit out the same result as Google converter did.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128595: [KUnitConversion] Add British "stone" unit of mass

2016-08-04 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128595/#review98117
---


Ship it!




ship it! 
(with albert's comment addressed)

- David Edmundson


On Aug. 3, 2016, 7:45 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128595/
> ---
> 
> (Updated Aug. 3, 2016, 7:45 p.m.)
> 
> 
> Review request for KDE Frameworks and David Edmundson.
> 
> 
> Repository: kunitconversion
> 
> 
> Description
> ---
> 
> This weird unit is pretty common in the UK and equal to 6.35029318 kg.
> 
> 
> Diffs
> -
> 
>   src/mass.cpp c7bf147 
>   src/unit.h e440346 
> 
> Diff: https://git.reviewboard.kde.org/r/128595/diff/
> 
> 
> Testing
> ---
> 
> This is the type of stone you use to smash display windows.
> 
> https://en.wikipedia.org/wiki/Stone_(unit)
> 
> Verified that krunner spit out the same result as Google converter did.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128595: [KUnitConversion] Add British "stone" unit of mass

2016-08-04 Thread David Edmundson 


> On Aug. 3, 2016, 10:18 p.m., David Edmundson wrote:
> > src/mass.cpp, line 268
> > 
> >
> > one of these should be "%1 stones" (with extra 's')
> 
> David Jarvie wrote:
> No, it's normally 'stone' for the plural as well.

I was convinced you're wrong so I did some research and apparently 
it's..either!
It must be regional.

http://dictionary.cambridge.org/dictionary/english/stone
plural: stone or stones UK written abbreviation st a unit of weight equal to 14 
pounds or 6.35 kilograms

Whoever can up with this must have been stonesd.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128595/#review98074
---


On Aug. 3, 2016, 7:45 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128595/
> ---
> 
> (Updated Aug. 3, 2016, 7:45 p.m.)
> 
> 
> Review request for KDE Frameworks and David Edmundson.
> 
> 
> Repository: kunitconversion
> 
> 
> Description
> ---
> 
> This weird unit is pretty common in the UK and equal to 6.35029318 kg.
> 
> 
> Diffs
> -
> 
>   src/mass.cpp c7bf147 
>   src/unit.h e440346 
> 
> Diff: https://git.reviewboard.kde.org/r/128595/diff/
> 
> 
> Testing
> ---
> 
> This is the type of stone you use to smash display windows.
> 
> https://en.wikipedia.org/wiki/Stone_(unit)
> 
> Verified that krunner spit out the same result as Google converter did.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128595: [KUnitConversion] Add British "stone" unit of mass

2016-08-04 Thread David Jarvie 


> On Aug. 3, 2016, 10:18 p.m., David Edmundson wrote:
> > src/mass.cpp, line 268
> > 
> >
> > one of these should be "%1 stones" (with extra 's')

No, it's normally 'stone' for the plural as well.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128595/#review98074
---


On Aug. 3, 2016, 7:45 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128595/
> ---
> 
> (Updated Aug. 3, 2016, 7:45 p.m.)
> 
> 
> Review request for KDE Frameworks and David Edmundson.
> 
> 
> Repository: kunitconversion
> 
> 
> Description
> ---
> 
> This weird unit is pretty common in the UK and equal to 6.35029318 kg.
> 
> 
> Diffs
> -
> 
>   src/mass.cpp c7bf147 
>   src/unit.h e440346 
> 
> Diff: https://git.reviewboard.kde.org/r/128595/diff/
> 
> 
> Testing
> ---
> 
> This is the type of stone you use to smash display windows.
> 
> https://en.wikipedia.org/wiki/Stone_(unit)
> 
> Verified that krunner spit out the same result as Google converter did.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128595: [KUnitConversion] Add British "stone" unit of mass

2016-08-03 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128595/#review98074
---



looks good. I have no idea how much a stone is.


src/mass.cpp (line 268)


one of these should be "%1 stones" (with extra 's')


- David Edmundson


On Aug. 3, 2016, 7:45 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128595/
> ---
> 
> (Updated Aug. 3, 2016, 7:45 p.m.)
> 
> 
> Review request for KDE Frameworks and David Edmundson.
> 
> 
> Repository: kunitconversion
> 
> 
> Description
> ---
> 
> This weird unit is pretty common in the UK and equal to 6.35029318 kg.
> 
> 
> Diffs
> -
> 
>   src/mass.cpp c7bf147 
>   src/unit.h e440346 
> 
> Diff: https://git.reviewboard.kde.org/r/128595/diff/
> 
> 
> Testing
> ---
> 
> This is the type of stone you use to smash display windows.
> 
> https://en.wikipedia.org/wiki/Stone_(unit)
> 
> Verified that krunner spit out the same result as Google converter did.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128595: [KUnitConversion] Add British "stone" unit of mass

2016-08-03 Thread Albert Astals Cid 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128595/#review98070
---




src/unit.h (line 87)


@since missing


- Albert Astals Cid


On Aug. 3, 2016, 7:45 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128595/
> ---
> 
> (Updated Aug. 3, 2016, 7:45 p.m.)
> 
> 
> Review request for KDE Frameworks and David Edmundson.
> 
> 
> Repository: kunitconversion
> 
> 
> Description
> ---
> 
> This weird unit is pretty common in the UK and equal to 6.35029318 kg.
> 
> 
> Diffs
> -
> 
>   src/mass.cpp c7bf147 
>   src/unit.h e440346 
> 
> Diff: https://git.reviewboard.kde.org/r/128595/diff/
> 
> 
> Testing
> ---
> 
> This is the type of stone you use to smash display windows.
> 
> https://en.wikipedia.org/wiki/Stone_(unit)
> 
> Verified that krunner spit out the same result as Google converter did.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel