Re: Review Request 129341: [kwallet] boost::shared_ptr -> std::shared_ptr
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129341/ --- (Updated Dec. 4, 2016, 6:55 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit f4e1653eefe9e81adbb7ec7f8eda51e02cd58f7b by Andreas Sturmlechner to branch master. Repository: kwallet Description --- Dropping implicit boost usage. Also, rename HAVE_QGPGME to HAVE_GPGMEPP. Diffs - src/runtime/kwalletd/CMakeLists.txt 5092a7e77a1ca7203827e444c11310566b2cc8b5 src/runtime/kwalletd/backend/CMakeLists.txt 2f99bc3cca89dd7a194f46cb314d2f7f90f931f3 src/runtime/kwalletd/backend/backendpersisthandler.h a6682353d62fd63e88a0de6277801c624c794c74 src/runtime/kwalletd/backend/backendpersisthandler.cpp 413d4cd23ef1e15b75cd366061f07f179241af58 src/runtime/kwalletd/backend/kwalletbackend.h 4811a58e942685b01ed097ef15c2838e3833865c src/runtime/kwalletd/backend/kwalletbackend.cc 43f30a545d36b64b102c794de3625621a694983e src/runtime/kwalletd/knewwalletdialog.h ea71fbc7d59fdd05da7ce395e371dd7fdf91e49d src/runtime/kwalletd/knewwalletdialog.cpp 0d9ffb8ed469536cee9d4055ac0bd001fff115a0 src/runtime/kwalletd/kwalletd.cpp ca7d4ffbdff4178878b3c705921ef2b1970e0dbd src/runtime/kwalletd/kwalletwizard.h 4cf8de424af800716e7c779d6d419eae4b54e426 src/runtime/kwalletd/kwalletwizard.cpp cd52e54a668554fc0e14f4ad4cb29ba6f27fd330 Diff: https://git.reviewboard.kde.org/r/129341/diff/ Testing --- Thanks, Andreas Sturmlechner
Re: Review Request 129341: [kwallet] boost::shared_ptr -> std::shared_ptr
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129341/ --- (Updated Dec. 4, 2016, 11:55 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit f4e1653eefe9e81adbb7ec7f8eda51e02cd58f7b by Andreas Sturmlechner to branch master. Repository: kwallet Description --- Dropping implicit boost usage. Also, rename HAVE_QGPGME to HAVE_GPGMEPP. Diffs - src/runtime/kwalletd/CMakeLists.txt 5092a7e77a1ca7203827e444c11310566b2cc8b5 src/runtime/kwalletd/backend/CMakeLists.txt 2f99bc3cca89dd7a194f46cb314d2f7f90f931f3 src/runtime/kwalletd/backend/backendpersisthandler.h a6682353d62fd63e88a0de6277801c624c794c74 src/runtime/kwalletd/backend/backendpersisthandler.cpp 413d4cd23ef1e15b75cd366061f07f179241af58 src/runtime/kwalletd/backend/kwalletbackend.h 4811a58e942685b01ed097ef15c2838e3833865c src/runtime/kwalletd/backend/kwalletbackend.cc 43f30a545d36b64b102c794de3625621a694983e src/runtime/kwalletd/knewwalletdialog.h ea71fbc7d59fdd05da7ce395e371dd7fdf91e49d src/runtime/kwalletd/knewwalletdialog.cpp 0d9ffb8ed469536cee9d4055ac0bd001fff115a0 src/runtime/kwalletd/kwalletd.cpp ca7d4ffbdff4178878b3c705921ef2b1970e0dbd src/runtime/kwalletd/kwalletwizard.h 4cf8de424af800716e7c779d6d419eae4b54e426 src/runtime/kwalletd/kwalletwizard.cpp cd52e54a668554fc0e14f4ad4cb29ba6f27fd330 Diff: https://git.reviewboard.kde.org/r/129341/diff/ Testing --- Thanks, Andreas Sturmlechner
Re: Review Request 129341: [kwallet] boost::shared_ptr -> std::shared_ptr
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129341/#review101264 --- Ship it! Looks OK. It would have been better to make this two separate commits though (one about shared_ptr and one about the #define, they are completely unrelated). - David Faure On Nov. 15, 2016, 8:54 p.m., Andreas Sturmlechner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129341/ > --- > > (Updated Nov. 15, 2016, 8:54 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kwallet > > > Description > --- > > Dropping implicit boost usage. > Also, rename HAVE_QGPGME to HAVE_GPGMEPP. > > > Diffs > - > > src/runtime/kwalletd/CMakeLists.txt > 5092a7e77a1ca7203827e444c11310566b2cc8b5 > src/runtime/kwalletd/backend/CMakeLists.txt > 2f99bc3cca89dd7a194f46cb314d2f7f90f931f3 > src/runtime/kwalletd/backend/backendpersisthandler.h > a6682353d62fd63e88a0de6277801c624c794c74 > src/runtime/kwalletd/backend/backendpersisthandler.cpp > 413d4cd23ef1e15b75cd366061f07f179241af58 > src/runtime/kwalletd/backend/kwalletbackend.h > 4811a58e942685b01ed097ef15c2838e3833865c > src/runtime/kwalletd/backend/kwalletbackend.cc > 43f30a545d36b64b102c794de3625621a694983e > src/runtime/kwalletd/knewwalletdialog.h > ea71fbc7d59fdd05da7ce395e371dd7fdf91e49d > src/runtime/kwalletd/knewwalletdialog.cpp > 0d9ffb8ed469536cee9d4055ac0bd001fff115a0 > src/runtime/kwalletd/kwalletd.cpp ca7d4ffbdff4178878b3c705921ef2b1970e0dbd > src/runtime/kwalletd/kwalletwizard.h > 4cf8de424af800716e7c779d6d419eae4b54e426 > src/runtime/kwalletd/kwalletwizard.cpp > cd52e54a668554fc0e14f4ad4cb29ba6f27fd330 > > Diff: https://git.reviewboard.kde.org/r/129341/diff/ > > > Testing > --- > > > Thanks, > > Andreas Sturmlechner > >
Re: Review Request 129341: [kwallet] boost::shared_ptr -> std::shared_ptr
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129341/ --- (Updated Nov. 15, 2016, 8:54 p.m.) Review request for KDE Frameworks. Changes --- HAVE_QGPGME -> HAVE_GPGMEPP Repository: kwallet Description (updated) --- Dropping implicit boost usage. Also, rename HAVE_QGPGME to HAVE_GPGMEPP. Diffs (updated) - src/runtime/kwalletd/CMakeLists.txt 5092a7e77a1ca7203827e444c11310566b2cc8b5 src/runtime/kwalletd/backend/CMakeLists.txt 2f99bc3cca89dd7a194f46cb314d2f7f90f931f3 src/runtime/kwalletd/backend/backendpersisthandler.h a6682353d62fd63e88a0de6277801c624c794c74 src/runtime/kwalletd/backend/backendpersisthandler.cpp 413d4cd23ef1e15b75cd366061f07f179241af58 src/runtime/kwalletd/backend/kwalletbackend.h 4811a58e942685b01ed097ef15c2838e3833865c src/runtime/kwalletd/backend/kwalletbackend.cc 43f30a545d36b64b102c794de3625621a694983e src/runtime/kwalletd/knewwalletdialog.h ea71fbc7d59fdd05da7ce395e371dd7fdf91e49d src/runtime/kwalletd/knewwalletdialog.cpp 0d9ffb8ed469536cee9d4055ac0bd001fff115a0 src/runtime/kwalletd/kwalletd.cpp ca7d4ffbdff4178878b3c705921ef2b1970e0dbd src/runtime/kwalletd/kwalletwizard.h 4cf8de424af800716e7c779d6d419eae4b54e426 src/runtime/kwalletd/kwalletwizard.cpp cd52e54a668554fc0e14f4ad4cb29ba6f27fd330 Diff: https://git.reviewboard.kde.org/r/129341/diff/ Testing --- Thanks, Andreas Sturmlechner
Re: Review Request 129341: [kwallet] boost::shared_ptr -> std::shared_ptr
> On Nov. 5, 2016, 12:56 p.m., Alexander Potashev wrote: > > Not sure if C++11's shared_ptr can be used, at least it's not mentioned > > here: > > https://community.kde.org/Frameworks/Policies#Frameworks_compiler_requirements_and_C.2B.2B11 I'm not an expert there, but it is already used in (at least) kactivities, kdeclarative and syntax-highlighting as well. - Andreas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129341/#review100597 --- On Nov. 5, 2016, 12:05 p.m., Andreas Sturmlechner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129341/ > --- > > (Updated Nov. 5, 2016, 12:05 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kwallet > > > Description > --- > > Dropping implicit boost usage. > > > Diffs > - > > src/runtime/kwalletd/backend/backendpersisthandler.cpp > 413d4cd23ef1e15b75cd366061f07f179241af58 > src/runtime/kwalletd/knewwalletdialog.h > ea71fbc7d59fdd05da7ce395e371dd7fdf91e49d > src/runtime/kwalletd/knewwalletdialog.cpp > 0d9ffb8ed469536cee9d4055ac0bd001fff115a0 > src/runtime/kwalletd/kwalletd.cpp ca7d4ffbdff4178878b3c705921ef2b1970e0dbd > src/runtime/kwalletd/kwalletwizard.cpp > cd52e54a668554fc0e14f4ad4cb29ba6f27fd330 > > Diff: https://git.reviewboard.kde.org/r/129341/diff/ > > > Testing > --- > > > Thanks, > > Andreas Sturmlechner > >
Re: Review Request 129341: [kwallet] boost::shared_ptr -> std::shared_ptr
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129341/#review100597 --- Not sure if C++11's shared_ptr can be used, at least it's not mentioned here: https://community.kde.org/Frameworks/Policies#Frameworks_compiler_requirements_and_C.2B.2B11 - Alexander Potashev On Ноя. 5, 2016, 3:05 п.п., Andreas Sturmlechner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129341/ > --- > > (Updated Ноя. 5, 2016, 3:05 п.п.) > > > Review request for KDE Frameworks. > > > Repository: kwallet > > > Description > --- > > Dropping implicit boost usage. > > > Diffs > - > > src/runtime/kwalletd/backend/backendpersisthandler.cpp > 413d4cd23ef1e15b75cd366061f07f179241af58 > src/runtime/kwalletd/knewwalletdialog.h > ea71fbc7d59fdd05da7ce395e371dd7fdf91e49d > src/runtime/kwalletd/knewwalletdialog.cpp > 0d9ffb8ed469536cee9d4055ac0bd001fff115a0 > src/runtime/kwalletd/kwalletd.cpp ca7d4ffbdff4178878b3c705921ef2b1970e0dbd > src/runtime/kwalletd/kwalletwizard.cpp > cd52e54a668554fc0e14f4ad4cb29ba6f27fd330 > > Diff: https://git.reviewboard.kde.org/r/129341/diff/ > > > Testing > --- > > > Thanks, > > Andreas Sturmlechner > >
Review Request 129341: [kwallet] boost::shared_ptr -> std::shared_ptr
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129341/ --- Review request for KDE Frameworks. Repository: kwallet Description --- Dropping implicit boost usage. Diffs - src/runtime/kwalletd/backend/backendpersisthandler.cpp 413d4cd23ef1e15b75cd366061f07f179241af58 src/runtime/kwalletd/knewwalletdialog.h ea71fbc7d59fdd05da7ce395e371dd7fdf91e49d src/runtime/kwalletd/knewwalletdialog.cpp 0d9ffb8ed469536cee9d4055ac0bd001fff115a0 src/runtime/kwalletd/kwalletd.cpp ca7d4ffbdff4178878b3c705921ef2b1970e0dbd src/runtime/kwalletd/kwalletwizard.cpp cd52e54a668554fc0e14f4ad4cb29ba6f27fd330 Diff: https://git.reviewboard.kde.org/r/129341/diff/ Testing --- Thanks, Andreas Sturmlechner
