Re: Review Request 129362: [KWindowInfo] Add pid()

2016-11-14 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129362/
---

(Updated Nov. 14, 2016, 11:19 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Martin Gräßlin.


Changes
---

Submitted with commit bea30245041d38d0801f052d5bd418d489d9dfac by Kai Uwe 
Broulik to branch master.


Repository: kwindowsystem


Description
---

Allows to retrieve the process ID of the window's application if present.


Diffs
-

  autotests/kwindowinfox11test.cpp 09d2837 
  src/kwindowinfo.h e3dea61 
  src/kwindowinfo.cpp e40e397 
  src/kwindowinfo_dummy_p.h 933140d 
  src/kwindowinfo_p.h 7a4ede5 
  src/platforms/xcb/kwindowinfo.cpp 3a3fee6 
  src/platforms/xcb/kwindowinfo_p_x11.h aeb046a 

Diff: https://git.reviewboard.kde.org/r/129362/diff/


Testing
---


Thanks,

Kai Uwe Broulik

Re: Review Request 129362: [KWindowInfo] Add pid()

2016-11-12 Thread Martin Gräßlin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129362/#review100802
---


Ship it!





autotests/kwindowinfox11test.cpp (line 772)


Lucky you that Qt is smart


- Martin Gräßlin


On Nov. 11, 2016, 11:35 vorm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129362/
> ---
> 
> (Updated Nov. 11, 2016, 11:35 vorm.)
> 
> 
> Review request for KDE Frameworks and Martin Gräßlin.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> ---
> 
> Allows to retrieve the process ID of the window's application if present.
> 
> 
> Diffs
> -
> 
>   autotests/kwindowinfox11test.cpp 09d2837 
>   src/kwindowinfo.h e3dea61 
>   src/kwindowinfo.cpp e40e397 
>   src/kwindowinfo_dummy_p.h 933140d 
>   src/kwindowinfo_p.h 7a4ede5 
>   src/platforms/xcb/kwindowinfo.cpp 3a3fee6 
>   src/platforms/xcb/kwindowinfo_p_x11.h aeb046a 
> 
> Diff: https://git.reviewboard.kde.org/r/129362/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

Re: Review Request 129362: [KWindowInfo] Add pid()

2016-11-11 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129362/
---

(Updated Nov. 11, 2016, 10:35 vorm.)


Review request for KDE Frameworks and Martin Gräßlin.


Changes
---

* Add autotest


Repository: kwindowsystem


Description
---

Allows to retrieve the process ID of the window's application if present.


Diffs (updated)
-

  autotests/kwindowinfox11test.cpp 09d2837 
  src/kwindowinfo.h e3dea61 
  src/kwindowinfo.cpp e40e397 
  src/kwindowinfo_dummy_p.h 933140d 
  src/kwindowinfo_p.h 7a4ede5 
  src/platforms/xcb/kwindowinfo.cpp 3a3fee6 
  src/platforms/xcb/kwindowinfo_p_x11.h aeb046a 

Diff: https://git.reviewboard.kde.org/r/129362/diff/


Testing
---


Thanks,

Kai Uwe Broulik

Re: Review Request 129362: [KWindowInfo] Add pid()

2016-11-10 Thread Martin Gräßlin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129362/#review100762
---



code looks good now, but please extend autotests/kwindowinfox11test.cpp with a 
test method for pid.

- Martin Gräßlin


On Nov. 10, 2016, 3:30 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129362/
> ---
> 
> (Updated Nov. 10, 2016, 3:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Gräßlin.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> ---
> 
> Allows to retrieve the process ID of the window's application if present.
> 
> 
> Diffs
> -
> 
>   src/kwindowinfo.h e3dea61 
>   src/kwindowinfo.cpp e40e397 
>   src/kwindowinfo_dummy_p.h 933140d 
>   src/kwindowinfo_p.h 7a4ede5 
>   src/platforms/xcb/kwindowinfo.cpp 3a3fee6 
>   src/platforms/xcb/kwindowinfo_p_x11.h aeb046a 
> 
> Diff: https://git.reviewboard.kde.org/r/129362/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

Re: Review Request 129362: [KWindowInfo] Add pid()

2016-11-10 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129362/
---

(Updated Nov. 10, 2016, 2:30 nachm.)


Review request for KDE Frameworks and Martin Gräßlin.


Changes
---

* Use extension dance instead of adding a new virtual


Repository: kwindowsystem


Description
---

Allows to retrieve the process ID of the window's application if present.


Diffs (updated)
-

  src/kwindowinfo.h e3dea61 
  src/kwindowinfo.cpp e40e397 
  src/kwindowinfo_dummy_p.h 933140d 
  src/kwindowinfo_p.h 7a4ede5 
  src/platforms/xcb/kwindowinfo.cpp 3a3fee6 
  src/platforms/xcb/kwindowinfo_p_x11.h aeb046a 

Diff: https://git.reviewboard.kde.org/r/129362/diff/


Testing
---


Thanks,

Kai Uwe Broulik

Re: Review Request 129362: [KWindowInfo] Add pid()

2016-11-08 Thread Martin Gräßlin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129362/#review100731
---



You cannot add a virtual method. You need to do an extension dance as my last 
commit.

- Martin Gräßlin


On Nov. 8, 2016, 12:47 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129362/
> ---
> 
> (Updated Nov. 8, 2016, 12:47 nachm.)
> 
> 
> Review request for KDE Frameworks and Martin Gräßlin.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> ---
> 
> Allows to retrieve the process ID of the window's application if present.
> 
> 
> Diffs
> -
> 
>   src/kwindowinfo.h e3dea61 
>   src/kwindowinfo.cpp e40e397 
>   src/kwindowinfo_dummy_p.h 933140d 
>   src/kwindowinfo_p.h 7a4ede5 
>   src/platforms/xcb/kwindowinfo.cpp 3a3fee6 
>   src/platforms/xcb/kwindowinfo_p_x11.h aeb046a 
> 
> Diff: https://git.reviewboard.kde.org/r/129362/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

Review Request 129362: [KWindowInfo] Add pid()

2016-11-08 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129362/
---

Review request for KDE Frameworks and Martin Gräßlin.


Repository: kwindowsystem


Description
---

Allows to retrieve the process ID of the window's application if present.


Diffs
-

  src/kwindowinfo.h e3dea61 
  src/kwindowinfo.cpp e40e397 
  src/kwindowinfo_dummy_p.h 933140d 
  src/kwindowinfo_p.h 7a4ede5 
  src/platforms/xcb/kwindowinfo.cpp 3a3fee6 
  src/platforms/xcb/kwindowinfo_p_x11.h aeb046a 

Diff: https://git.reviewboard.kde.org/r/129362/diff/


Testing
---


Thanks,

Kai Uwe Broulik