Re: Review Request 129588: http slave: add newlines to long error message

2016-12-07 Thread Elvis Angelaccio

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129588/
---

(Updated Dec. 7, 2016, 11:11 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Changes
---

Submitted with commit e5a4a221e312b9ba72f8cf889172a13af7b06c76 by Elvis 
Angelaccio to branch master.


Repository: kio


Description
---

Otherwise Dolphin shows an error dialog with too much width.


Diffs
-

  src/ioslaves/http/http.cpp 62eb09d2882097c3dea99ea73fd1933cea4376a7 

Diff: https://git.reviewboard.kde.org/r/129588/diff/


Testing
---

See screenshots.


File Attachments


Before
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/11/29/bb368736-5987-4800-996f-2e05c4971d7f__Spectacle.a29637.png
After
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/11/29/456f0afe-d192-4e09-8c9a-1fa0b27f5bb4__6wJEi10.png


Thanks,

Elvis Angelaccio



Re: Review Request 129588: http slave: add newlines to long error message

2016-12-05 Thread Sebastian Kügler

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129588/#review101296
---


Ship it!




Ship It!

- Sebastian Kügler


On Nov. 29, 2016, 6:23 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129588/
> ---
> 
> (Updated Nov. 29, 2016, 6:23 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Otherwise Dolphin shows an error dialog with too much width.
> 
> 
> Diffs
> -
> 
>   src/ioslaves/http/http.cpp 62eb09d2882097c3dea99ea73fd1933cea4376a7 
> 
> Diff: https://git.reviewboard.kde.org/r/129588/diff/
> 
> 
> Testing
> ---
> 
> See screenshots.
> 
> 
> File Attachments
> 
> 
> Before
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/11/29/bb368736-5987-4800-996f-2e05c4971d7f__Spectacle.a29637.png
> After
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/11/29/456f0afe-d192-4e09-8c9a-1fa0b27f5bb4__6wJEi10.png
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>



Review Request 129588: http slave: add newlines to long error message

2016-11-29 Thread Elvis Angelaccio

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129588/
---

Review request for KDE Frameworks and David Faure.


Repository: kio


Description
---

Otherwise Dolphin shows an error dialog with too much width.


Diffs
-

  src/ioslaves/http/http.cpp 62eb09d2882097c3dea99ea73fd1933cea4376a7 

Diff: https://git.reviewboard.kde.org/r/129588/diff/


Testing
---

See screenshots.


File Attachments


Before
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/11/29/bb368736-5987-4800-996f-2e05c4971d7f__Spectacle.a29637.png
After
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/11/29/456f0afe-d192-4e09-8c9a-1fa0b27f5bb4__6wJEi10.png


Thanks,

Elvis Angelaccio