T11950: Reduce the pain of working on monochrome Breeze icons

[Nathaniel Graham]

ngraham added a subtask: T12855: [Breeze Icons] Get rid of redundancy in 
icons-dark/.

TASK DETAIL
  https://phabricator.kde.org/T11950

To: ngraham
Cc: davidhurka, mglb, #frameworks, mart, trickyricky26, ndavis, #vdg, ngraham, 
dmenig, manueljlin, Orage, LeGast00n, cblack, konkinartem, ian, jguidon, 
Ghost6, jraleigh, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
michaelh, crozbo, firef, bruns, skadinna, aaronhoneycutt, mbohlender

T11950: Reduce the pain of working on monochrome Breeze icons

[David Hurka]

davidhurka added a comment.


  This is how my source file for find-location (D27983 
) looks in inkscape.
  
  F8174793: Screenshot_20200313_201936.png 

  
  Would it be nice to post such screenshots in Revisions, instead of 
montage-breeze-dark images? Theese are a bit redundant with automated tools. 
The screenshot would make it easy to spot pixel-misalignments.
  
  The montage-breeze output should stay, to see how the icon looks at original 
size. Or is another inkscape screenshot at original size (Key 1) sufficient?
  
  F8174818: Screenshot_20200313_203610.png 


TASK DETAIL
  https://phabricator.kde.org/T11950

To: ngraham, davidhurka
Cc: davidhurka, mglb, #frameworks, mart, trickyricky26, ndavis, #vdg, ngraham, 
manueljlin, Orage, LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, 
jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
michaelh, crozbo, firef, bruns, skadinna, aaronhoneycutt, mbohlender

T11950: Reduce the pain of working on monochrome Breeze icons

[Nathaniel Graham]

ngraham added a comment.


  Yes, looks very nice. Please feel free to work on this. My efforts were not 
very successful due to limited CMake knowledge and use of shell scripts instead 
of something more cross-platform like Python.

TASK DETAIL
  https://phabricator.kde.org/T11950

To: ngraham
Cc: davidhurka, mglb, #frameworks, mart, trickyricky26, ndavis, #vdg, ngraham, 
manueljlin, Orage, LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, 
jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
michaelh, crozbo, firef, bruns, skadinna, aaronhoneycutt, mbohlender

T11950: Reduce the pain of working on monochrome Breeze icons

[Noah Davis]

ndavis added a comment.


  @davidhurka pretty impressive. I'll have to try it myself. If the 
dependencies are minimal and it's easy to use, it might be worth it to have the 
tool in the breeze icons repo.

TASK DETAIL
  https://phabricator.kde.org/T11950

To: ngraham, ndavis
Cc: davidhurka, mglb, #frameworks, mart, trickyricky26, ndavis, #vdg, ngraham, 
manueljlin, Orage, LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, 
jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
michaelh, crozbo, firef, bruns, skadinna, aaronhoneycutt, mbohlender

T11950: Reduce the pain of working on monochrome Breeze icons

[David Hurka]

davidhurka added a comment.


  Whoops, this Task went past me //while// I created breeze-icon-cleaner 
. What a pity!
  
  I think with this tool, we can check the remaining four tasks of the TODO in 
the task description. Sounds optimistic? Well...:
  
  - breeze-icon-cleaner repository has change-to-dark.pl, which converts icons 
from Breeze to Breeze-Dark. (Easy task...)
  - It doesn’t “optimize” the icons, it creates new ones which //are// optimal. 
Below is an example, so you can judge yourself.
  - It embeds the stylesheets. It doesn’t even require additional attention 
while painting the icon in Inkscape, it simply deduces the classes from the 
colors. Easier than what @mglb suggested...
  - “adjust the text”? If code alignment is meant: see below.
  

http://www.w3.org/2000/svg";>


.ColorScheme-NegativeText {
color:#da4453;
}




  
  Let me know what you think.
  
  ---
  
  By the way: Nice that someone removed all that 24px icons and wrote a script 
to generate them. Thanks, @ngraham!

TASK DETAIL
  https://phabricator.kde.org/T11950

To: ngraham, davidhurka
Cc: davidhurka, mglb, #frameworks, mart, trickyricky26, ndavis, #vdg, ngraham, 
manueljlin, Orage, LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, 
jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
michaelh, crozbo, firef, bruns, skadinna, aaronhoneycutt, mbohlender

T11950: Reduce the pain of working on monochrome Breeze icons

[Nathaniel Graham]

ngraham added a revision: D27605: Also auto-generate 24@2x compatibility 
symlinks.

TASK DETAIL
  https://phabricator.kde.org/T11950

To: ngraham
Cc: mglb, #frameworks, mart, trickyricky26, ndavis, #vdg, ngraham, manueljlin, 
Orage, LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, MrPepe, 
fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, michaelh, crozbo, 
firef, bruns, skadinna, aaronhoneycutt, mbohlender

T11950: Reduce the pain of working on monochrome Breeze icons

[Nathaniel Graham]

ngraham updated the task description.

TASK DETAIL
  https://phabricator.kde.org/T11950

To: ngraham
Cc: mglb, #frameworks, mart, trickyricky26, ndavis, #vdg, ngraham, manueljlin, 
Orage, LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, MrPepe, 
fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, michaelh, crozbo, 
firef, bruns, skadinna, aaronhoneycutt, mbohlender

T11950: Reduce the pain of working on monochrome Breeze icons

[Nathaniel Graham]

ngraham updated the task description.

TASK DETAIL
  https://phabricator.kde.org/T11950

To: ngraham
Cc: mglb, #frameworks, mart, trickyricky26, ndavis, #vdg, ngraham, manueljlin, 
Orage, LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, MrPepe, 
fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, michaelh, crozbo, 
firef, bruns, skadinna, aaronhoneycutt, mbohlender

T11950: Reduce the pain of working on monochrome Breeze icons

[Nathaniel Graham]

ngraham added a revision: Unknown Object (Differential Revision).

TASK DETAIL
  https://phabricator.kde.org/T11950

To: ngraham
Cc: mglb, #frameworks, mart, trickyricky26, ndavis, #vdg, ngraham, manueljlin, 
Orage, LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, MrPepe, 
fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, michaelh, crozbo, 
firef, bruns, skadinna, aaronhoneycutt, mbohlender

T11950: Reduce the pain of working on monochrome Breeze icons

[Noah Davis]

ndavis added a comment.


  For the Inkscape optimized svg gradient problem: 
https://gitlab.com/inkscape/inbox/issues/1121

TASK DETAIL
  https://phabricator.kde.org/T11950

To: ngraham, ndavis
Cc: mglb, #frameworks, mart, trickyricky26, ndavis, #vdg, ngraham, manueljlin, 
LeGast00n, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, 
MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, michaelh, 
crozbo, firef, bruns, skadinna, aaronhoneycutt, mbohlender

T11950: Reduce the pain of working on monochrome Breeze icons

[Noah Davis]

ndavis added a comment.


  I don't trust optimizers unless it's `scour`. That's the only one I know of 
that doesn't seem to cause problems occasionally. Inkscape's Optimized SVG save 
option actually uses `scour` to do the optimization.
  
  I'm somewhat open to the idea of only requiring optimization at build time 
for the sake of making it easier for newbies to contribute, but I prefer 
reading optimized SVGs in patches because that makes it easier for me to spot 
mistakes. The massive quantity of noise that Inkscape puts into SVGs, even 
plain SVGs, is staggering. Maybe we could have something that cleans the SVGs 
when submitted for a patch? If it won't work with Phabricator, it might work 
with GitLab.
  
  In T11950#206330 , @ngraham wrote:
  
  > As far as I can tell, every single icon in the `icons-dark` folder is 
identical to the other ones with the exception of having the colors in the 
stylesheet changed. Auto-generating these in CMake seems quite feasible.
  
  
  There are a few that can't be auto-generated that way (gradients don't work 
with stylesheets), so we should have some logic to avoid overwriting files that 
already exist. Then we can eliminate all the icons that only need to have their 
stylesheet changed while keeping the option to do Breeze Dark specific icons.
  
  > Optimization creates real problem - sometimes icons after optimizations 
become hard to edit, so less people want to do modifications.
  
  There are 2 main issues that Optimizers introduce (in order of severity):
  
  - That gradients that don't get their properties from another gradient that 
they reference can't be swapped, unless you unset and reset the fill of the 
object you want to change the gradient for. This seems like a bug in Inkscape.
  - That some optimizers combine paths with similar properties by default. This 
isn't a big deal if you know to go to Path > Break Apart in Inkscape, but 
obviously not everyone is going to know Inkscape or SVGs very well. It's hard 
to say how much a new contributor should be expected to know about SVGs or 
Inkscape.
- Sometimes Break Apart causes objects to lose their properties and turn 
black. Usually not a big deal, it's very easy to fix, but not good for workflow.
- I suppose we could just make sure we don't use any settings in the 
optimizer for combining paths.

TASK DETAIL
  https://phabricator.kde.org/T11950

To: ngraham, ndavis
Cc: mglb, #frameworks, mart, trickyricky26, ndavis, #vdg, ngraham, LeGast00n, 
cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, 
fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, michaelh, crozbo, 
firef, bruns, skadinna, aaronhoneycutt, mbohlender

T11950: Reduce the pain of working on monochrome Breeze icons

[Mariusz Glebocki]

mglb added a comment.


  Inserting and applying styles can be done with icon template file with 
predefined swatches. Swatches (which are internally one-stop gradients) would 
be converted into style later with a script. Not trivial (i.e. not one line 
sed) to write due to indirect gradient use in inkscape, but also not really 
hard. Xml parser is the way to go. For extra newbie-friendly solution, "save as 
monochrome breeze svg" extension could be made.
  From designer point of view use is really simple - in fill and stroke dock 
click "swatch" type and pick named color from a list.
  
  Why breeze icons are "optimized"? As someone pointed out in another task, 
they are cached as bitmaps, so slightly more complicated XML is not a problem. 
Optimization creates real problem - sometimes icons after optimizations become 
hard to edit, so less people want to do modifications.

TASK DETAIL
  https://phabricator.kde.org/T11950

To: ngraham, mglb
Cc: mglb, #frameworks, mart, trickyricky26, ndavis, #vdg, ngraham, LeGast00n, 
cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, 
fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, michaelh, crozbo, 
firef, bruns, skadinna, aaronhoneycutt, mbohlender

T11950: Reduce the pain of working on monochrome Breeze icons

[Nathaniel Graham]

ngraham added a project: Frameworks.
ngraham added a subscriber: Frameworks.

TASK DETAIL
  https://phabricator.kde.org/T11950

To: ngraham
Cc: #frameworks, mart, trickyricky26, ndavis, #vdg, ngraham, LeGast00n, cblack, 
konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, GB_2, mglb, michaelh, crozbo, firef, 
bruns, skadinna, aaronhoneycutt, mbohlender