X11 on Windows
Hi frameworks and windows devs, from the release announcement of the latest frameworks release I learned that there were multiple changes to disable finding X11 on Windows (e.g. [1]). I think such changes are wrong and I have spoken against such changes (they are wrong, CMake supports disabling modules without checking in code!) in the past multiple times when I was aware of them (please include me in any reviews touching X11). Given that we came up with a good solution for OSX directly in ECM [2]. Can we get a similar solution for Windows? Then we can stop to patch random frameworks. Cheers Martin [1] http://commits.kde.org/kdelibs4support/ 9cd0b4ffe5d837f16f98346402300db0949b94e7 [2] http://commits.kde.org/extra-cmake-modules/ d4bcaf7eb3ff501ad0a5f06ed0724964e0e0f404 signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: X11 on Windows
On 12 October 2015 at 08:33, Martin Graesslin <mgraess...@kde.org> wrote: > Hi frameworks and windows devs, > > from the release announcement of the latest frameworks release I learned that > there were multiple changes to disable finding X11 on Windows (e.g. [1]). I > think such changes are wrong and I have spoken against such changes (they are > wrong, CMake supports disabling modules without checking in code!) in the past > multiple times when I was aware of them (please include me in any reviews > touching X11). > > Given that we came up with a good solution for OSX directly in ECM [2]. Can we > get a similar solution for Windows? Then we can stop to patch random > frameworks. > Hi Martin,good point. The difference is that KDE on Mac developer(s) prefer to support X11, and I am not sure anyone wants to spend precious time for supporting X11 on Windows. I am not, and I would be assuming WIN32 => NOT X11 in code I maintain. So if this is consistent with general direction, equivalent of APPLE_FORCE_X11 for windows makes no sense. So the case for Windows in KDECMakeSettings.cmake could be simpler, but yes, it's needed. Please give me some time for that. -- regards, Jaroslaw Staniek KDE: : A world-wide network of software engineers, artists, writers, translators : and facilitators committed to Free Software development - http://kde.org Calligra Suite: : A graphic art and office suite - http://calligra.org Kexi: : A visual database apps builder - http://calligra.org/kexi Qt Certified Specialist: : http://www.linkedin.com/in/jstaniek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: X11 on Windows
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 12.10.2015 um 10:01 schrieb Jaroslaw Staniek: > On 12 October 2015 at 08:33, Martin Graesslin <mgraess...@kde.org> > wrote: >> Hi frameworks and windows devs, >> >> from the release announcement of the latest frameworks release I >> learned that there were multiple changes to disable finding X11 >> on Windows (e.g. [1]). I think such changes are wrong and I have >> spoken against such changes (they are wrong, CMake supports >> disabling modules without checking in code!) in the past multiple >> times when I was aware of them (please include me in any reviews >> touching X11). >> >> Given that we came up with a good solution for OSX directly in >> ECM [2]. Can we get a similar solution for Windows? Then we can >> stop to patch random frameworks. >> > > Hi Martin,good point. The difference is that KDE on Mac > developer(s) prefer to support X11, and I am not sure anyone wants > to spend precious time for supporting X11 on Windows. > > I am not, and I would be assuming WIN32 => NOT X11 in code I > maintain. So if this is consistent with general direction, > equivalent of APPLE_FORCE_X11 for windows makes no sense. So the > case for Windows in KDECMakeSettings.cmake could be simpler, but > yes, it's needed. Please give me some time for that. > +1 regards, Patrick -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.21 (MingW32) iQIcBAEBAgAGBQJWG3MsAAoJEPAKI6QtGt1xgZsP/iGlt3YjvwF99mzlGMpE4JmK 8vb7PDWnHl9bo+/j37PxbIOo6+Ry8GqXn6Qz73Kfd30ogsf703eCq6b93Ot/4LIj /1gUxnNkYLEO1rk95jJYy5iYRplIx6R1+d2Nexof6NVXT93Bso+PU0LaIaCcXEEM oiQbw40lvAonY0I/MGzw3S9zvvh0MSqTOE5VukdHtJYECTjx6K5wQuztpvpMFcLO duZB3mQrw3I37diE4X75is6hn8owYvrqiQ5G7TVw26wlTzNN8a2x8jNxNN3Co0B5 OgJy9a6D5q1ZkwhiB3jCmzETjrjZowcWz+mWRyTgEenpgmqEUtRy+jGGtl8YnHtD hlZTOgjgcnLBN8hAHKWYb9mYOajTPRZ/xetBN9Clh5/TjQJt82Jh51idnwZVqZjY GBwFYUxiu2uIc5nJoM3gmZLsJP4QCZ3nEu+Ck855OGgTzXh6mBYnzq4T8jyKsFlK 2MyXtQQ2PRvd2cPUJMBz+hysdEnU9CHG0erGoxutRud6ikeCE5R5H/8nU037TDTl mkX9QUQr2Z3mydmob1cS+CfqPETHKy1EvtcuifPzm+PMuqw9IoWFqtulgTBN8EPp FtKDWGZKRdsHMKNxTe4YT0NCxqNG5vZdiHaOFJm3dGGC70bNGsxhSrbc9oOEMnjm 5Vjl8dN8RyIelO6J6I4P =dY4Z -END PGP SIGNATURE- ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: X11 on Windows
On Monday, October 12, 2015 10:01:42 AM CEST Jaroslaw Staniek wrote: > On 12 October 2015 at 08:33, Martin Graesslin <mgraess...@kde.org> wrote: > > Hi frameworks and windows devs, > > > > from the release announcement of the latest frameworks release I learned > > that there were multiple changes to disable finding X11 on Windows (e.g. > > [1]). I think such changes are wrong and I have spoken against such > > changes (they are wrong, CMake supports disabling modules without > > checking in code!) in the past multiple times when I was aware of them > > (please include me in any reviews touching X11). > > > > Given that we came up with a good solution for OSX directly in ECM [2]. > > Can we get a similar solution for Windows? Then we can stop to patch > > random frameworks. > > Hi Martin,good point. > The difference is that KDE on Mac developer(s) prefer to support X11, > and I am not sure anyone wants to spend precious time for supporting > X11 on Windows. No they don't. There were some confusing mails on the mailing list. The situation is exactly the same as on OSX and the change done in ECM is exactly based on the assumption that nobody wants to compile Qt software with X11 support on OSX [1] > > I am not, and I would be assuming WIN32 => NOT X11 in code I maintain. > So if this is consistent with general direction, equivalent of > APPLE_FORCE_X11 for windows makes no sense. I agree that it's probably not needed on Windows unless one wants to keep the theoretic workflows alive. The solution for OSX is also more to keep a compatibility as it's in fact a compatibility breakage. > So the case for Windows in KDECMakeSettings.cmake could be simpler, > but yes, it's needed. Please give me some time for that. Sure! Thanks for looking into it! Cheers Martin [1] There is the theoretic option to build Qt with X11 support on OSX. I assume such a theoretic option would also exist on Windows, if one wants to go crazy. signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
