Re: kdelibs4support does not contain any .po

2014-10-01 Thread David Faure 
On Wednesday 17 September 2014 23:07:50 Albert Astals Cid wrote:
 El Dimecres, 17 de setembre de 2014, a les 22:53:35, David Faure va 
escriure:
  On Monday 15 September 2014 23:12:19 Albert Astals Cid wrote:
   Hi David, kf-ers
   
   I can't find any .po inside kdelibs4support tarball.
   
   David can you make sure the files get packaged and installed for the
   next
   frameworks release?
  
  Indeed, they aren't picked up by make_rc_tag.sh because all other
  frameworks .po files are named ${repo}5.po or ${repo}5_*.po
  
  But the one for kdelibs4support is called kdelibs4support.po, no 5
  suffix.
  
  Shall I add a special case for kdelibs4support to make_rc_tag.sh, or
  should
  we rename the .po files for consistency?
 
 kdelibs4support5 is a weird name, no?
 
 I'd go for special case maybe?
 
 Also does this mean we are not shipping these either?
 
 kcm_webshortcuts.pot - kio
 kshorturifilter.pot - kio
 kurifilter.pot - kio

Hmm how is my script supposed to find out that these should be shipped with 
kio? Grepping the Messages.sh? Hmm, it sounded fragile at first, but it seems 
to work:

$ find . -name '*.sh' | xargs grep -- '-o \$podir' | sed -e 's,.*podir/,,'
kcm_webshortcuts.pot
kio5.pot
kurifilter.pot
kshorturifilter.pot

Alternatively we could move these under messages/frameworks/kio/ in l10n.

Or prefixing them with kio_, easy to collect with a wildcard then.

What do you think?

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: kdelibs4support does not contain any .po

2014-10-01 Thread Albert Astals Cid 
El Dimecres, 1 d'octubre de 2014, a les 10:51:05, David Faure va escriure:
 On Wednesday 17 September 2014 23:07:50 Albert Astals Cid wrote:
  El Dimecres, 17 de setembre de 2014, a les 22:53:35, David Faure va
 
 escriure:
   On Monday 15 September 2014 23:12:19 Albert Astals Cid wrote:
Hi David, kf-ers

I can't find any .po inside kdelibs4support tarball.

David can you make sure the files get packaged and installed for the
next
frameworks release?
   
   Indeed, they aren't picked up by make_rc_tag.sh because all other
   frameworks .po files are named ${repo}5.po or ${repo}5_*.po
   
   But the one for kdelibs4support is called kdelibs4support.po, no 5
   suffix.
   
   Shall I add a special case for kdelibs4support to make_rc_tag.sh, or
   should
   we rename the .po files for consistency?
  
  kdelibs4support5 is a weird name, no?
  
  I'd go for special case maybe?
  
  Also does this mean we are not shipping these either?
  
  kcm_webshortcuts.pot - kio
  kshorturifilter.pot - kio
  kurifilter.pot - kio
 
 Hmm how is my script supposed to find out that these should be shipped with
 kio? 

This is a good question :)

 Grepping the Messages.sh? Hmm, it sounded fragile at first, but it
 seems to work:
At the moment you can either grep or run the Messages.sh, the second is more 
robust, but needs more setup (or have a manual list, but noone likes that)

 $ find . -name '*.sh' | xargs grep -- '-o \$podir' | sed -e 's,.*podir/,,'
 kcm_webshortcuts.pot
 kio5.pot
 kurifilter.pot
 kshorturifilter.pot
 
 Alternatively we could move these under messages/frameworks/kio/ in l10n.
 
 Or prefixing them with kio_, easy to collect with a wildcard then.
 
 What do you think?

Another solution would be going to a bit more declarative solution for 
Message.sh like we use in
http://quickgit.kde.org/?p=kdeconnect-android.gita=blobh=e9d93d200c8979e35dd2a58a082a5ce8181e0f75hb=a22ffd611a36f475fe38a0c867a8b2890752a289f=StaticMessages.sh
that would make grepping trivial.

But changing all the Messages.sh (along with adding support to scripty) may be 
a bit hard, so i guess you can go with the hopeful grepping for now if that 
works.

Cheers,
  Albert
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: kdelibs4support does not contain any .po

2014-10-01 Thread David Faure 
On Wednesday 01 October 2014 23:08:29 Albert Astals Cid wrote:
 But changing all the Messages.sh (along with adding support to scripty) may
 be  a bit hard, so i guess you can go with the hopeful grepping for now
 if that works.

Done.

Works for my tests (kio  kde4support), we'll see about the rest for KF 5.3 :)

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: kdelibs4support does not contain any .po

2014-09-17 Thread David Faure 
On Monday 15 September 2014 23:12:19 Albert Astals Cid wrote:
 Hi David, kf-ers
 
 I can't find any .po inside kdelibs4support tarball.
 
 David can you make sure the files get packaged and installed for the next
 frameworks release?

Indeed, they aren't picked up by make_rc_tag.sh because all other frameworks 
.po files are named ${repo}5.po or ${repo}5_*.po

But the one for kdelibs4support is called kdelibs4support.po, no 5 suffix.

Shall I add a special case for kdelibs4support to make_rc_tag.sh, or should we 
rename the .po files for consistency?

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: kdelibs4support does not contain any .po

2014-09-17 Thread Albert Astals Cid 
El Dimecres, 17 de setembre de 2014, a les 22:53:35, David Faure va escriure:
 On Monday 15 September 2014 23:12:19 Albert Astals Cid wrote:
  Hi David, kf-ers
  
  I can't find any .po inside kdelibs4support tarball.
  
  David can you make sure the files get packaged and installed for the next
  frameworks release?
 
 Indeed, they aren't picked up by make_rc_tag.sh because all other frameworks
 .po files are named ${repo}5.po or ${repo}5_*.po
 
 But the one for kdelibs4support is called kdelibs4support.po, no 5 suffix.
 
 Shall I add a special case for kdelibs4support to make_rc_tag.sh, or should
 we rename the .po files for consistency?

kdelibs4support5 is a weird name, no?

I'd go for special case maybe?

Also does this mean we are not shipping these either?

kcm_webshortcuts.pot - kio
kshorturifilter.pot - kio
kurifilter.pot - kio
plasma_runner_example_homefiles.pot - krunner -- should this exist?

Cheers,
  Albert
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

kdelibs4support does not contain any .po

2014-09-15 Thread Albert Astals Cid 
Hi David, kf-ers

I can't find any .po inside kdelibs4support tarball.

David can you make sure the files get packaged and installed for the next 
frameworks release?

Do you want a bug?

Cheers,
  Albert

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel