Re: plasma-framework build broken

2013-10-13 Thread Stephen Kelly
Sebastian Kügler wrote:

 On Saturday, October 12, 2013 21:48:28 Sebastian Kügler wrote:
 It seems that one of your recent commits to plasma-frameworks broke its
 build:
 
 /home/sebas/kf5/src/plasma-
 
framework/src/declarativeimports/qtextracomponents/tests/columnproxymodeltes
 t.cpp:23:23:  fatal error: qtest_kde.h: No such file or directory
 
 Readding the things you removed there leads to the next error
 (threadweaver_export.h not found). I've given up at that point and have
 for now reverted your commit as a whole, which does indeed make it build
 again, in order not to block others' work.
 
 Did this actually build for you? If so, I wonder what's different on my
 system. Could you have another look?
 
 A clean build with all your changes in now works fine. Sorry for the
 noise.

Most likely you didn't need a clean build - just an incremental rebuild of 
kdelibs after you updated ecm.

Thanks,

Steve.

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


plasma-framework build broken

2013-10-12 Thread Sebastian Kügler
Hi Steve,

It seems that one of your recent commits to plasma-frameworks broke its build:

/home/sebas/kf5/src/plasma-
framework/src/declarativeimports/qtextracomponents/tests/columnproxymodeltest.cpp:23:23:
 
fatal error: qtest_kde.h: No such file or directory

Readding the things you removed there leads to the next error 
(threadweaver_export.h not found). I've given up at that point and have for 
now reverted your commit as a whole, which does indeed make it build again, in 
order not to block others' work.

Did this actually build for you? If so, I wonder what's different on my 
system. Could you have another look?

Cheers,
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: plasma-framework build broken

2013-10-12 Thread Sebastian Kügler
On Saturday, October 12, 2013 21:48:28 Sebastian Kügler wrote:
 It seems that one of your recent commits to plasma-frameworks broke its
 build:
 
 /home/sebas/kf5/src/plasma-
 framework/src/declarativeimports/qtextracomponents/tests/columnproxymodeltes
 t.cpp:23:23:  fatal error: qtest_kde.h: No such file or directory
 
 Readding the things you removed there leads to the next error 
 (threadweaver_export.h not found). I've given up at that point and have for 
 now reverted your commit as a whole, which does indeed make it build again,
 in order not to block others' work.
 
 Did this actually build for you? If so, I wonder what's different on my 
 system. Could you have another look?

A clean build with all your changes in now works fine. Sorry for the noise.
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel