Re: Review Request 128083: Find CPUs by subsystem rather than driver

[Martin Gräßlin]

> On June 6, 2016, 11:33 p.m., Rohan Garg wrote:
> > Hi
> > Could we get a shipit on these? I'd really appreciate it if we could have 
> > these in Frameworks 5.23

I don't want to disappoint you, but it's too late for 5.23


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128083/#review96236
---


On June 3, 2016, 2:15 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128083/
> ---
> 
> (Updated June 3, 2016, 2:15 p.m.)
> 
> 
> Review request for KDE Frameworks and Solid.
> 
> 
> Repository: solid
> 
> 
> Description
> ---
> 
> The driver "processor" is part of the ACPI module, which isn't used by
> all systems and architectures.
> 
> Detecting devices by CPU subsystem seems to work, and whilst
> theoretically this change could pick up a non CPU device in the same 
> subsystem they
> would be filtered out by the udevmanager which has an extra check
> that CPUs are valid and not just empty sockets.
> 
> 
> Diffs
> -
> 
>   src/solid/devices/backends/udev/udevdevice.cpp 
> 9fb5e092679cd3c6860b2055cf3dedb915addfda 
>   src/solid/devices/backends/udev/udevmanager.cpp 
> 3f3a671798e84e6d577df7c3b9b80150ac4d01fc 
> 
> Diff: https://git.reviewboard.kde.org/r/128083/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

KApiDox Maintainship

[Olivier Churlaud]

Hi,

 I did a lot of work on KApiDox the last weeks, and I have still a lot 
in mind to improve it. I spoke with Alex about the maintainship of 
KApidox as he doesn't have currently time to spend on it. He told me he 
was ok to pass me the maintainship.


 I don't know how this work, so I would like some explanations about 
what being the maintainer means, what are the responsibilities and 
constrains, and of course, after I'll know that, if it's ok that I 
change the Alex's name with mine for Kapidox maintainer.


Cheers
Olivier


--
Olivier CHURLAUD
Engineer Student at Ecole Centrale de Lyon
in Dual Degree at TU Berlin, M.Sc. Elektrotechnik
@: oliv...@churlaud.com
tel: +49 (0)1575-2931348
in:  http://linkedin.com/in/olivierchurlaud
web: http://olivier.churlaud.com

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 128115: do not load and debug in the same line

[Harald Sitter]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128115/
---

Review request for KDE Frameworks and Jeremy Whiting.


Repository: knewstuff


Description
---

if debugging is off the line is no-op and the load never happens, thus
breaking the test since the entry is always empty.

broke as result of review 126017

do not category debug in test

there's not much gain to be had from making tests less verbose, on the
contrary it might make debugging harder if something fails in an
isolated testbed (e.g. CI)


Diffs
-

  autotests/knewstuffentrytest.cpp a886afc514abfa21b6396a8b2c8c3a88d65b4a5d 

Diff: https://git.reviewboard.kde.org/r/128115/diff/


Testing
---

makes && test passes


Thanks,

Harald Sitter

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: knewstuff master kf5-qt5 » Linux,gcc - Build # 83 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/knewstuff%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/83/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 07 Jun 2016 09:07:10 +
Build duration: 1 min 20 sec

CHANGE SET
Revision 81e2895b40684e275aadc944cdbc2f333a20782f by sitter: (do not load and 
debug in the same line)
  change: edit autotests/knewstuffentrytest.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/9 (56%)FILES 11/51 (22%)CLASSES 11/51 (22%)LINE 755/4862 
(16%)CONDITIONAL 368/2907 (13%)

By packages
  
autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 77/77 (100%)CONDITIONAL 
40/80 (50%)
autotests.kmoretools
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 160/175 (91%)CONDITIONAL 
84/192 (44%)
src
FILES 2/9 (22%)CLASSES 2/9 (22%)LINE 19/980 (2%)CONDITIONAL 
0/368 (0%)
src.attica
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/276 (0%)CONDITIONAL 0/204 
(0%)
src.core
FILES 3/14 (21%)CLASSES 3/14 (21%)LINE 103/1386 (7%)CONDITIONAL 
54/958 (6%)
src.kmoretools
FILES 3/5 (60%)CLASSES 3/5 (60%)LINE 396/889 (45%)CONDITIONAL 
190/550 (35%)
src.staticxml
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/142 (0%)CONDITIONAL 0/115 
(0%)
src.ui
FILES 0/14 (0%)CLASSES 0/14 (0%)LINE 0/794 (0%)CONDITIONAL 
0/354 (0%)
src.upload
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/143 (0%)CONDITIONAL 0/86 
(0%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: knewstuff master stable-kf5-qt5 » Linux,gcc - Build # 84 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/knewstuff%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/84/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 07 Jun 2016 09:07:10 +
Build duration: 1 min 18 sec

CHANGE SET
Revision 81e2895b40684e275aadc944cdbc2f333a20782f by sitter: (do not load and 
debug in the same line)
  change: edit autotests/knewstuffentrytest.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/9 (56%)FILES 11/51 (22%)CLASSES 11/51 (22%)LINE 755/4862 
(16%)CONDITIONAL 368/2907 (13%)

By packages
  
autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 77/77 (100%)CONDITIONAL 
40/80 (50%)
autotests.kmoretools
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 160/175 (91%)CONDITIONAL 
84/192 (44%)
src
FILES 2/9 (22%)CLASSES 2/9 (22%)LINE 19/980 (2%)CONDITIONAL 
0/368 (0%)
src.attica
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/276 (0%)CONDITIONAL 0/204 
(0%)
src.core
FILES 3/14 (21%)CLASSES 3/14 (21%)LINE 103/1386 (7%)CONDITIONAL 
54/958 (6%)
src.kmoretools
FILES 3/5 (60%)CLASSES 3/5 (60%)LINE 396/889 (45%)CONDITIONAL 
190/550 (35%)
src.staticxml
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/142 (0%)CONDITIONAL 0/115 
(0%)
src.ui
FILES 0/14 (0%)CLASSES 0/14 (0%)LINE 0/794 (0%)CONDITIONAL 
0/354 (0%)
src.upload
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/143 (0%)CONDITIONAL 0/86 
(0%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: knewstuff master kf5-qt5 » Linux,gcc - Build # 83 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/knewstuff%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/83/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 07 Jun 2016 09:07:10 +
Build duration: 1 min 20 sec

CHANGE SET
Revision 81e2895b40684e275aadc944cdbc2f333a20782f by sitter: (do not load and 
debug in the same line)
  change: edit autotests/knewstuffentrytest.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/9 (56%)FILES 11/51 (22%)CLASSES 11/51 (22%)LINE 755/4862 
(16%)CONDITIONAL 368/2907 (13%)

By packages
  
autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 77/77 (100%)CONDITIONAL 
40/80 (50%)
autotests.kmoretools
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 160/175 (91%)CONDITIONAL 
84/192 (44%)
src
FILES 2/9 (22%)CLASSES 2/9 (22%)LINE 19/980 (2%)CONDITIONAL 
0/368 (0%)
src.attica
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/276 (0%)CONDITIONAL 0/204 
(0%)
src.core
FILES 3/14 (21%)CLASSES 3/14 (21%)LINE 103/1386 (7%)CONDITIONAL 
54/958 (6%)
src.kmoretools
FILES 3/5 (60%)CLASSES 3/5 (60%)LINE 396/889 (45%)CONDITIONAL 
190/550 (35%)
src.staticxml
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/142 (0%)CONDITIONAL 0/115 
(0%)
src.ui
FILES 0/14 (0%)CLASSES 0/14 (0%)LINE 0/794 (0%)CONDITIONAL 
0/354 (0%)
src.upload
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/143 (0%)CONDITIONAL 0/86 
(0%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128113: [kuiserverjobtracker] Fix crash when unregister job

[Anthony Fieroni]

> On Юни 7, 2016, 12:03 преди обяд, Elvis Angelaccio wrote:
> > Are we talking about this bug? https://bugs.kde.org/show_bug.cgi?id=362977
> > 
> > If yes, it's already fixed on Ark master.
> 
> Anthony Fieroni wrote:
> It's not this, it happens on all backend.
> 
> Elvis Angelaccio wrote:
> It happens with all CLI-based backends (zip, rar, ...) but it's the same 
> bug. We fixed this on master by reworking how Ark handles external processes.

I still think patch is relevant. finished is needed to delete object cause a 
leak, and due to async nature, dbus interface makes non block call, it 
shouldn't be delete obj. Maybe it's better to be
*QObject::connect(job, ::finished, jobView, ::deleteLater);*


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128113/#review96235
---


On Юни 7, 2016, 6:28 преди обяд, Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128113/
> ---
> 
> (Updated Юни 7, 2016, 6:28 преди обяд)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kjobwidgets
> 
> 
> Description
> ---
> 
> + Fix memory leak in finished
> 
> 
> Diffs
> -
> 
>   src/kuiserverjobtracker.cpp ebed3a5 
> 
> Diff: https://git.reviewboard.kde.org/r/128113/diff/
> 
> 
> Testing
> ---
> 
> ark --changetofirstpath --add --autofilename zip kjobwidgets
> Crash before, fix with patch
> 
> 
> File Attachments
> 
> 
> backtrace
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/5b87387e-7e7b-4982-b91b-a18f72414509__backtrace
> memcheck
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/06/07/ba4b0150-5e01-4cc1-8776-7530d053d6f0__memcheck
> memcheck 7 errorrs
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/06/07/f8813ccc-8835-4255-842c-29c57c2dea23__memcheck2
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128114: do not load and debug in the same line

[Harald Sitter]

> On June 7, 2016, 8:53 a.m., Aleix Pol Gonzalez wrote:
> > Are you sure that's the case? Is C++ that smart that it can decide not to 
> > execute part of the stream?

C++ isn't, Qt is.

In some build configs (e.g. gcc) qCDebug becomes noop as the macro essentially 
expands to a fancy `if-enabled { log(va_args) }` meaning no streaming happens 
at all unless the category is enabled. 
Utlimately the same would happen with nodebug builds btw, they also turn 
everything after the macro invocation noop by means of an always-false 
evaluation.

tldr: never call mutating code from inside the qDebug arguments as it can be 
noop because of Qt


- Harald


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128114/#review96247
---


On June 7, 2016, 8:48 a.m., Harald Sitter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128114/
> ---
> 
> (Updated June 7, 2016, 8:48 a.m.)
> 
> 
> Review request for KDE Frameworks, Andreas Cord-Landwehr and Jeremy Whiting.
> 
> 
> Repository: knewstuff
> 
> 
> Description
> ---
> 
> if debugging is off the line is no-op and the load never happens, thus
> breaking the test since the entry is always empty.
> 
> broke as result of review 126017
> 
> 
> Diffs
> -
> 
>   autotests/knewstuffentrytest.cpp a886afc514abfa21b6396a8b2c8c3a88d65b4a5d 
> 
> Diff: https://git.reviewboard.kde.org/r/128114/diff/
> 
> 
> Testing
> ---
> 
> makes && passes test
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128113: [kuiserverjobtracker] Fix crash when unregister job

[Elvis Angelaccio]

> On June 6, 2016, 9:03 p.m., Elvis Angelaccio wrote:
> > Are we talking about this bug? https://bugs.kde.org/show_bug.cgi?id=362977
> > 
> > If yes, it's already fixed on Ark master.
> 
> Anthony Fieroni wrote:
> It's not this, it happens on all backend.

It happens with all CLI-based backends (zip, rar, ...) but it's the same bug. 
We fixed this on master by reworking how Ark handles external processes.


- Elvis


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128113/#review96235
---


On June 7, 2016, 3:28 a.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128113/
> ---
> 
> (Updated June 7, 2016, 3:28 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kjobwidgets
> 
> 
> Description
> ---
> 
> + Fix memory leak in finished
> 
> 
> Diffs
> -
> 
>   src/kuiserverjobtracker.cpp ebed3a5 
> 
> Diff: https://git.reviewboard.kde.org/r/128113/diff/
> 
> 
> Testing
> ---
> 
> ark --changetofirstpath --add --autofilename zip kjobwidgets
> Crash before, fix with patch
> 
> 
> File Attachments
> 
> 
> backtrace
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/5b87387e-7e7b-4982-b91b-a18f72414509__backtrace
> memcheck
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/06/07/ba4b0150-5e01-4cc1-8776-7530d053d6f0__memcheck
> memcheck 7 errorrs
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/06/07/f8813ccc-8835-4255-842c-29c57c2dea23__memcheck2
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 128114: do not load and debug in the same line

[Harald Sitter]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128114/
---

Review request for KDE Frameworks, Andreas Cord-Landwehr and Jeremy Whiting.


Repository: knewstuff


Description
---

if debugging is off the line is no-op and the load never happens, thus
breaking the test since the entry is always empty.

broke as result of review 126017


Diffs
-

  autotests/knewstuffentrytest.cpp a886afc514abfa21b6396a8b2c8c3a88d65b4a5d 

Diff: https://git.reviewboard.kde.org/r/128114/diff/


Testing
---

makes && passes test


Thanks,

Harald Sitter

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128114: do not load and debug in the same line

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128114/#review96247
---



Are you sure that's the case? Is C++ that smart that it can decide not to 
execute part of the stream?

- Aleix Pol Gonzalez


On June 7, 2016, 10:48 a.m., Harald Sitter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128114/
> ---
> 
> (Updated June 7, 2016, 10:48 a.m.)
> 
> 
> Review request for KDE Frameworks, Andreas Cord-Landwehr and Jeremy Whiting.
> 
> 
> Repository: knewstuff
> 
> 
> Description
> ---
> 
> if debugging is off the line is no-op and the load never happens, thus
> breaking the test since the entry is always empty.
> 
> broke as result of review 126017
> 
> 
> Diffs
> -
> 
>   autotests/knewstuffentrytest.cpp a886afc514abfa21b6396a8b2c8c3a88d65b4a5d 
> 
> Diff: https://git.reviewboard.kde.org/r/128114/diff/
> 
> 
> Testing
> ---
> 
> makes && passes test
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128114: do not load and debug in the same line

[Andreas Cord-Landwehr]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128114/#review96246
---


Ship it!




Thanks, just wanted to start looking into this issue :)

- Andreas Cord-Landwehr


On Juni 7, 2016, 8:48 vorm., Harald Sitter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128114/
> ---
> 
> (Updated Juni 7, 2016, 8:48 vorm.)
> 
> 
> Review request for KDE Frameworks, Andreas Cord-Landwehr and Jeremy Whiting.
> 
> 
> Repository: knewstuff
> 
> 
> Description
> ---
> 
> if debugging is off the line is no-op and the load never happens, thus
> breaking the test since the entry is always empty.
> 
> broke as result of review 126017
> 
> 
> Diffs
> -
> 
>   autotests/knewstuffentrytest.cpp a886afc514abfa21b6396a8b2c8c3a88d65b4a5d 
> 
> Diff: https://git.reviewboard.kde.org/r/128114/diff/
> 
> 
> Testing
> ---
> 
> makes && passes test
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128114: do not load and debug in the same line

[Harald Sitter]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128114/
---

(Updated June 7, 2016, 9:06 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Andreas Cord-Landwehr and Jeremy Whiting.


Changes
---

Submitted with commit 81e2895b40684e275aadc944cdbc2f333a20782f by Harald Sitter 
to branch master.


Repository: knewstuff


Description
---

if debugging is off the line is no-op and the load never happens, thus
breaking the test since the entry is always empty.

broke as result of review 126017


Diffs
-

  autotests/knewstuffentrytest.cpp a886afc514abfa21b6396a8b2c8c3a88d65b4a5d 

Diff: https://git.reviewboard.kde.org/r/128114/diff/


Testing
---

makes && passes test


Thanks,

Harald Sitter

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128113: [kuiserverjobtracker] Fix crash when unregister job

[Anthony Fieroni]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128113/
---

(Updated Юни 7, 2016, 10:24 след обяд)


Review request for KDE Frameworks and David Faure.


Changes
---

David, the problem is KUiServerJobTracker::unregisterJob is not reentrant. 
KJobTrackerInterface::unregisterJob(job) trys to disconnect a job twice. Now 
issues is completely fixed, 20/20 not crash. Elvis, can you try against ark 
master?


Repository: kjobwidgets


Description
---

+ Fix memory leak in finished


Diffs (updated)
-

  src/kuiserverjobtracker.cpp ebed3a5 

Diff: https://git.reviewboard.kde.org/r/128113/diff/


Testing
---

ark --changetofirstpath --add --autofilename zip kjobwidgets
Crash before, fix with patch


File Attachments


backtrace
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/5b87387e-7e7b-4982-b91b-a18f72414509__backtrace
memcheck
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/06/07/ba4b0150-5e01-4cc1-8776-7530d053d6f0__memcheck
memcheck 7 errorrs
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/06/07/f8813ccc-8835-4255-842c-29c57c2dea23__memcheck2


Thanks,

Anthony Fieroni

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128085: Fix check that CPU is a valid CPU

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128085/#review96263
---


Ship it!




- Sebastian Kügler


On June 3, 2016, 12:15 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128085/
> ---
> 
> (Updated June 3, 2016, 12:15 p.m.)
> 
> 
> Review request for KDE Frameworks and Solid.
> 
> 
> Repository: solid
> 
> 
> Description
> ---
> 
> We have a check that an devices/system/cpu/cpuN entry contains a
> processor and not just an empty socket, however it relies on somewhat
> outdated /sys files.
> 
> cpuN/cpufreq isn't guaranteed to exist as for some systems (my AMD
> processor at least).
> 
> The docs in the linux kernel imply topology/core_id should always exist,
> and should still work as a valid check that we have a populated CPU
> socket.
> 
> 
> Diffs
> -
> 
>   src/solid/devices/backends/udev/udevmanager.cpp 
> 3f3a671798e84e6d577df7c3b9b80150ac4d01fc 
> 
> Diff: https://git.reviewboard.kde.org/r/128085/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128113: [kuiserverjobtracker] Fix crash when unregister job

[Anthony Fieroni]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128113/
---

(Updated Юни 8, 2016, 7:17 преди обяд)


Review request for KDE Frameworks and David Faure.


Repository: kjobwidgets


Description
---

+ Fix memory leak in finished


Diffs (updated)
-

  src/kuiserverjobtracker.cpp ebed3a5 

Diff: https://git.reviewboard.kde.org/r/128113/diff/


Testing
---

ark --changetofirstpath --add --autofilename zip kjobwidgets
Crash before, fix with patch


File Attachments


backtrace
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/5b87387e-7e7b-4982-b91b-a18f72414509__backtrace
memcheck
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/06/07/ba4b0150-5e01-4cc1-8776-7530d053d6f0__memcheck
memcheck 7 errorrs
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/06/07/f8813ccc-8835-4255-842c-29c57c2dea23__memcheck2


Thanks,

Anthony Fieroni

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Bug in kdelibs4support/kio/kfiledialog

[Christoph Feck]

On Wednesday 08 June 2016 00:58:33 Jonathan Schultz wrote:
> Sorry for cross-posting, but kde-frameworks-devel seems to be a
> more active list than kde-devel where I previously raised this
> issue.
> 
> I'd like to file a bug report for kdelibs4support/kio/kfiledialog
> but don't seem to be able to find a relevant category in KDE
> Bugzilla. If someone can point me in the right direction I'll go

https://bugs.kde.org/component-report.cgi?product=frameworks-kdelibs4support

> ahead with that. In the meantime, here is a description of the
> bug:
> 
> In short, some functions do not check whether d->native is non-null
> before calling a method belonging to the file chooser widget d->w.
> However, d->w is only set if d->native is null, so if this is not
> the case then the application crashes. This issue manifested on a
> windows build of kf5/okular by the application crashing in
> KFileDialog::setMimeFilter when the user attempts to opena file.
> However, I see that there are another half-dozen or so functions
> that have the same problem.
> 
> In any case I made the following patch and confirmed that with it
> okular
> 
> can open files without crashing:
>  > --- a/src/kio/kfiledialog.cpp
>  > +++ b/src/kio/kfiledialog.cpp
>  > @@ -326,8 +326,6 @@ QString KFileDialog::currentFilter() const
>  > 
>  >  void KFileDialog::setMimeFilter(const QStringList ,
>  >  
>  >  const QString )
>  >  
>  >  {
>  > 
>  > -d->w->setMimeFilter(mimeTypes, defaultType);
>  > -
>  > 
>  >  if (d->native) {
>  >  
>  >  QString allExtensions;
>  >  QStringList filters = mime2KdeFilter(mimeTypes,
>  >  );
>  > 
>  > @@ -336,6 +334,8 @@ void KFileDialog::setMimeFilter(const
>  > QStringList
> 
> ,
> 
>  >  }
>  >  d->native->filter = filters.join(QLatin1String("\n"));
>  >  
>  >  }
>  > 
>  > +else
>  > +d->w->setMimeFilter(mimeTypes, defaultType);
>  > 
>  >  }
> 
> Presumably all the other functions that do not currently test
> d->native should be made to do so.

The patch looks good, but the formatting should be

if (d->native) {
...
d->native->filter = 
} else {
d->w->setMimeFilter(...
}

I suggest to add it to https://git.reviewboard.kde.org/ so it does not 
get lost. Alternatively, add it to the bug report.

> Cheers,
> Jonathan
> ___
> Kde-frameworks-devel mailing list
> Kde-frameworks-devel@kde.org
> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127906: update qt5options manpage docbook to qt 5.6

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127906/
---

(Updated Juni 8, 2016, 4:57 vorm.)


Review request for Documentation, KDE Frameworks and David Faure.


Changes
---

update resolving issues from Luigi Toscano


Repository: kdoctools


Description
---

All options in this docbook like

display, session, cmap, ncols, nograb, dograb, sync, fn, bg, fg, btn, name, 
title, visual, inputstyle, im, noxim, reverse, stylesheet

are valid for Qt 3.3 QApplication, see

http://doc.qt.io/archives/3.3/qapplication.html#QApplication


In Qt 5.6 a QApplication automatically supports a few command line options like 
style, stylesheet, widgetcount, reverse, qmljsdebugger
see http://doc.qt.io/qt-5/qapplication.html


Do we really want to provide a manpage docbook for that?


Diffs (updated)
-

  docs/qt5options/man-qt5options.7.docbook d5891eb 

Diff: https://git.reviewboard.kde.org/r/127906/diff/


Testing
---


Thanks,

Burkhard Lück

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127903: Update kf5options manpage docbook

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127903/
---

(Updated Juni 8, 2016, 4:42 vorm.)


Review request for Documentation and KDE Frameworks.


Changes
---

update fixing issues from Luigi Toscanos review


Repository: kdoctools


Description
---

replace the obsolete content with updates
Use case for option desktopfile borrowed von Martin Gräßlins commit log

See Also: qt5options - does that really make sense for a kf5 app?
I really doubt that the qt5options manpage is uptodate


Diffs (updated)
-

  docs/kf5options/man-kf5options.7.docbook f79d42c 

Diff: https://git.reviewboard.kde.org/r/127903/diff/


Testing
---

passes checkXML5


Thanks,

Burkhard Lück

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127940: Rename docs/plasmapkg directory to docs/plasmapkg2

[Luigi Toscano]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127940/#review96277
---


Ship it!




If https://git.reviewboard.kde.org/r/127904/ went in, I don't see why this 
should not (after 5.23 at this point)

- Luigi Toscano


On Mag. 16, 2016, 3:25 p.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127940/
> ---
> 
> (Updated Mag. 16, 2016, 3:25 p.m.)
> 
> 
> Review request for KDE Frameworks, Localization and Translation (l10n) and 
> David Faure.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> rename directory + adapt CMakeLists.txt file
> 
> this change is necessary to fetch translated manpage docs 
> without hacks either in frameworks release script or in autogen.sh
> into the frameworks tarball.
> 
> See also https://git.reviewboard.kde.org/r/127904/ for a detailed explanation
> 
> Together with commiting this change I'll adapt Scripty.
> 
> 
> Diffs
> -
> 
>   docs/CMakeLists.txt 2acc3f0 
>   docs/plasmapkg/CMakeLists.txt a78d3bd 
>   docs/plasmapkg/man-plasmapkg2.1.docbook 0952bd2 
>   docs/plasmapkg2/CMakeLists.txt PRE-CREATION 
>   docs/plasmapkg2/man-plasmapkg2.1.docbook PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127940/diff/
> 
> 
> Testing
> ---
> 
> builds and installs the manpage to the same installdir as before
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127927: Move kcm_ssl kcm docs to subdir docs/kcontrol

[Luigi Toscano]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127927/#review96276
---


Ship it!




Too late for 5.23, but I think you can push after 5.23 is released.

- Luigi Toscano


On Mag. 15, 2016, 2:50 p.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127927/
> ---
> 
> (Updated Mag. 15, 2016, 2:50 p.m.)
> 
> 
> Review request for KDE Frameworks, Localization and Translation (l10n) and 
> David Faure.
> 
> 
> Repository: kdelibs4support
> 
> 
> Description
> ---
> 
> move directory + adapt/add CMakeLists.txt files
> 
> this change is necessary to fetch translated kcm_ssl docs 
> withaout hacks either in frameworks release script or in autogen.sh
> into the frameworks tarball.
> 
> See also https://git.reviewboard.kde.org/r/127904/ for a detailed explanation
> 
> Together with commiting this change I'll adapt Scripty.
> 
> 
> Diffs
> -
> 
>   docs/CMakeLists.txt b1e2a72 
>   docs/kcm_ssl/CMakeLists.txt 4d3bc75 
>   docs/kcm_ssl/details.png e0d7074 
>   docs/kcm_ssl/index.docbook f5d3ef1 
>   docs/kcm_ssl/module.png 2f69c6e 
>   docs/kcontrol/CMakeLists.txt PRE-CREATION 
>   docs/kcontrol/kcm_ssl/CMakeLists.txt PRE-CREATION 
>   docs/kcontrol/kcm_ssl/details.png PRE-CREATION 
>   docs/kcontrol/kcm_ssl/index.docbook PRE-CREATION 
>   docs/kcontrol/kcm_ssl/module.png PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127927/diff/
> 
> 
> Testing
> ---
> 
> builds and installs the kcm docs to the same installdir as before
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127903: Update kf5options manpage docbook

[Luigi Toscano]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127903/#review96267
---



Generic options for Qt5 (so qt5options) do work for every Qt5 application, 
including of course the ones that also use Frameworks. This can go in with few 
changes.


docs/kf5options/man-kf5options.7.docbook (line 10)


2015?



docs/kf5options/man-kf5options.7.docbook (line 79)


I would remove the FIXME



docs/kf5options/man-kf5options.7.docbook (line 85)


How much is left of the original manpage? I think you should add your name 
and change the comment to state that the Man page was originally written by... 
(up to kdelibs4).


- Luigi Toscano


On Mag. 26, 2016, 5:01 p.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127903/
> ---
> 
> (Updated Mag. 26, 2016, 5:01 p.m.)
> 
> 
> Review request for Documentation and KDE Frameworks.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> replace the obsolete content with updates
> Use case for option desktopfile borrowed von Martin Gräßlins commit log
> 
> See Also: qt5options - does that really make sense for a kf5 app?
> I really doubt that the qt5options manpage is uptodate
> 
> 
> Diffs
> -
> 
>   docs/kf5options/man-kf5options.7.docbook f79d42c 
> 
> Diff: https://git.reviewboard.kde.org/r/127903/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128088: Load KFileItemAction plugins with json metadata

[Emmanuel Pescosta]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128088/#review96284
---


Ship it!




Ship It!

- Emmanuel Pescosta


On June 5, 2016, 8:14 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128088/
> ---
> 
> (Updated June 5, 2016, 8:14 p.m.)
> 
> 
> Review request for Dolphin and KDE Frameworks.
> 
> 
> Repository: dolphin
> 
> 
> Description
> ---
> 
> Dolphin currently doesn't support JSON-only KFileItemAction plugins (without 
> a .desktop file).
> This patch adds support for them both in the context menu and in the settings 
> dialog (Services pane).
> 
> Since a plugin can have both a .desktop file and JSON metadata (as is the the 
> case for `kactivitymanagerd_fileitem_linking_plugin`), we need to be sure to 
> not add twice the plugin in the context menu. A QSet is used to prevent this 
> issue.
> 
> Open question: do we want to install these json-only plugins in a specific 
> subdirectory of `$QT_PLUGIN_PATH`? Like `$QT_PLUGIN_PATH/kf5/kio` or 
> something else? This way we could tell Dolphin to only look for plugins 
> within that subfolder (instead of checking every plugin in `$QT_PLUGIN_PATH`).
> 
> 
> Diffs
> -
> 
>   src/dolphincontextmenu.cpp dfec76144dafd9210aa8b6f45458ded98e27ab53 
>   src/settings/services/servicessettingspage.cpp 
> 4cfa2327c9fa77a6124b4d90040a9784cc8180c5 
> 
> Diff: https://git.reviewboard.kde.org/r/128088/diff/
> 
> 
> Testing
> ---
> 
> * Build Ark master after commit c369264d6c
> * Make sure that the Compress and Extract service menus are shown
> * Make sure that the menus above can be enabled/disabled in the Services pane 
> in the settings
> * Make sure that `kactivitymanagerd_fileitem_linking_plugin` is not shown 
> twice in the context menu
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Bug in kdelibs4support/kio/kfiledialog

[Jonathan Schultz]

Sorry for cross-posting, but kde-frameworks-devel seems to be a more 
active list than kde-devel where I previously raised this issue.


I'd like to file a bug report for kdelibs4support/kio/kfiledialog but 
don't seem to be able to find a relevant category in KDE Bugzilla. If 
someone can point me in the right direction I'll go ahead with that. In 
the meantime, here is a description of the bug:


In short, some functions do not check whether d->native is non-null 
before calling a method belonging to the file chooser widget d->w. 
However, d->w is only set if d->native is null, so if this is not the 
case then the application crashes. This issue manifested on a windows 
build of kf5/okular by the application crashing in 
KFileDialog::setMimeFilter when the user attempts to opena file. 
However, I see that there are another half-dozen or so functions that 
have the same problem.


In any case I made the following patch and confirmed that with it okular 
can open files without crashing:


> --- a/src/kio/kfiledialog.cpp
> +++ b/src/kio/kfiledialog.cpp
> @@ -326,8 +326,6 @@ QString KFileDialog::currentFilter() const
>  void KFileDialog::setMimeFilter(const QStringList ,
>  const QString )
>  {
> -d->w->setMimeFilter(mimeTypes, defaultType);
> -
>  if (d->native) {
>  QString allExtensions;
>  QStringList filters = mime2KdeFilter(mimeTypes, );
> @@ -336,6 +334,8 @@ void KFileDialog::setMimeFilter(const QStringList 
,

>  }
>  d->native->filter = filters.join(QLatin1String("\n"));
>  }
> +else
> +d->w->setMimeFilter(mimeTypes, defaultType);
>  }

Presumably all the other functions that do not currently test d->native 
should be made to do so.


Cheers,
Jonathan
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128116: KStandardAction::showStatusbar: fix copy/paste error

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128116/#review96256
---


Ship it!




Ship It!

- Albert Astals Cid


On June 7, 2016, 10:53 a.m., Jonathan Marten wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128116/
> ---
> 
> (Updated June 7, 2016, 10:53 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> ---
> 
> This function is intended to return the action for the StandardAction of 
> ShowStatusbar.  However, there seems to be an obvious copy/paste error here;  
> the action for ShowMenubar is retrieved instead.  This patch corrects this.
> 
> 
> Diffs
> -
> 
>   src/kstandardaction.cpp 29b7e9b 
> 
> Diff: https://git.reviewboard.kde.org/r/128116/diff/
> 
> 
> Testing
> ---
> 
> Built tier3/kconfigwidgets with this change, and tested with an application 
> which looks up the action by name.  Without this change there is a segfault 
> because the wrong action is found;  with the change the correct action is 
> found and works.
> 
> The autotest does not detect this problem because it only checks that an 
> action is returned; it doesn't check that it is the correct one!  Fixing this 
> would need an extra test of each returned action to check that its name() is 
> correct - not sure whether this is necessary?
> 
> 
> Thanks,
> 
> Jonathan Marten
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128083: Find CPUs by subsystem rather than driver

[Rohan Garg]

> On June 7, 2016, 3:03 a.m., Rohan Garg wrote:
> > Hi
> > Could we get a shipit on these? I'd really appreciate it if we could have 
> > these in Frameworks 5.23
> 
> Martin Gräßlin wrote:
> I don't want to disappoint you, but it's too late for 5.23
> 
> Kai Uwe Broulik wrote:
> If you give dfaure a cookie I'm sure he would re-spin for you. Tagging is 
> on the first Saturday, release on the *second*.

I'm sure that can be arranged ;)


- Rohan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128083/#review96236
---


On June 3, 2016, 5:45 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128083/
> ---
> 
> (Updated June 3, 2016, 5:45 p.m.)
> 
> 
> Review request for KDE Frameworks and Solid.
> 
> 
> Repository: solid
> 
> 
> Description
> ---
> 
> The driver "processor" is part of the ACPI module, which isn't used by
> all systems and architectures.
> 
> Detecting devices by CPU subsystem seems to work, and whilst
> theoretically this change could pick up a non CPU device in the same 
> subsystem they
> would be filtered out by the udevmanager which has an extra check
> that CPUs are valid and not just empty sockets.
> 
> 
> Diffs
> -
> 
>   src/solid/devices/backends/udev/udevdevice.cpp 
> 9fb5e092679cd3c6860b2055cf3dedb915addfda 
>   src/solid/devices/backends/udev/udevmanager.cpp 
> 3f3a671798e84e6d577df7c3b9b80150ac4d01fc 
> 
> Diff: https://git.reviewboard.kde.org/r/128083/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128116: KStandardAction::showStatusbar: fix copy/paste error

[Jonathan Marten]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128116/
---

(Updated June 7, 2016, 2:45 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit 3f7465b8d7c1649b54eb6ce72e88d2a3080e2234 by Jonathan 
Marten to branch master.


Repository: kconfigwidgets


Description
---

This function is intended to return the action for the StandardAction of 
ShowStatusbar.  However, there seems to be an obvious copy/paste error here;  
the action for ShowMenubar is retrieved instead.  This patch corrects this.


Diffs
-

  src/kstandardaction.cpp 29b7e9b 

Diff: https://git.reviewboard.kde.org/r/128116/diff/


Testing
---

Built tier3/kconfigwidgets with this change, and tested with an application 
which looks up the action by name.  Without this change there is a segfault 
because the wrong action is found;  with the change the correct action is found 
and works.

The autotest does not detect this problem because it only checks that an action 
is returned; it doesn't check that it is the correct one!  Fixing this would 
need an extra test of each returned action to check that its name() is correct 
- not sure whether this is necessary?


Thanks,

Jonathan Marten

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kdelibs4support master stable-kf5-qt5 » Linux,gcc - Build # 53 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kdelibs4support%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/53/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 07 Jun 2016 12:46:45 +
Build duration: 6 min 10 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 
39 test(s)Failed: TestSuite.globalcleanuptest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 4/7 (57%)FILES 160/268 (60%)CLASSES 160/268 (60%)LINE 21694/42752 
(51%)CONDITIONAL 14666/36445 (40%)

By packages
  
autotests
FILES 63/63 (100%)CLASSES 63/63 (100%)LINE 11519/11768 
(98%)CONDITIONAL 8481/16820 (50%)
src.kdecore
FILES 75/94 (80%)CLASSES 75/94 (80%)LINE 9221/16840 
(55%)CONDITIONAL 5722/11781 (49%)
src.kdeui
FILES 18/70 (26%)CLASSES 18/70 (26%)LINE 938/9815 
(10%)CONDITIONAL 460/5673 (8%)
src.kio
FILES 4/27 (15%)CLASSES 4/27 (15%)LINE 16/2396 (1%)CONDITIONAL 
3/1226 (0%)
src.kparts
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/26 (0%)CONDITIONAL 0/14 
(0%)
src.kssl
FILES 0/8 (0%)CLASSES 0/8 (0%)LINE 0/1708 (0%)CONDITIONAL 0/836 
(0%)
src.solid
FILES 0/5 (0%)CLASSES 0/5 (0%)LINE 0/199 (0%)CONDITIONAL 0/95 
(0%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127850: Let Plasma::Corona load the layout on all cases.

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127850/
---

(Updated June 7, 2016, 1:23 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Plasma and David Rosca.


Changes
---

Submitted with commit 9575b8c009d5500126cc0edb1a384ab39fd0a641 by Aleix Pol to 
branch master.


Bugs: 60777
http://bugs.kde.org/show_bug.cgi?id=60777


Repository: plasma-framework


Description
---

Iteration of: https://git.reviewboard.kde.org/r/127848/

We either load the existing layout or we load a default one.

With this, it could be removed from ShellCorona.


Diffs
-

  src/plasma/corona.h d8f829a 
  src/plasma/corona.cpp 1784516 

Diff: https://git.reviewboard.kde.org/r/127850/diff/


Testing
---

Tests pass.
PlasmaShell prints completed once both with and without configuration.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 128119: Explicitly declare methods as overridden

[Andreas Cord-Landwehr]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128119/
---

Review request for KDE Frameworks and Jeremy Whiting.


Repository: knewstuff


Description
---

Also remove virtual, since this is inheritated by the parent and
override states clearly that these are overriden methods.


Diffs
-

  src/ui/itemsviewbasedelegate_p.h 5b20f684b04e017b859e9aebdd34b52c1d298741 

Diff: https://git.reviewboard.kde.org/r/128119/diff/


Testing
---


Thanks,

Andreas Cord-Landwehr

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128119: Explicitly declare methods as overridden

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128119/#review96259
---


Ship it!




Ship It!

- Aleix Pol Gonzalez


On June 7, 2016, 3:40 p.m., Andreas Cord-Landwehr wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128119/
> ---
> 
> (Updated June 7, 2016, 3:40 p.m.)
> 
> 
> Review request for KDE Frameworks and Jeremy Whiting.
> 
> 
> Repository: knewstuff
> 
> 
> Description
> ---
> 
> Also remove virtual, since this is inheritated by the parent and
> override states clearly that these are overriden methods.
> 
> 
> Diffs
> -
> 
>   src/ui/itemsviewbasedelegate_p.h 5b20f684b04e017b859e9aebdd34b52c1d298741 
> 
> Diff: https://git.reviewboard.kde.org/r/128119/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 128120: Use KRun for open Url.

[Andreas Cord-Landwehr]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128120/
---

Review request for KDE Frameworks and Jeremy Whiting.


Repository: knewstuff


Description
---

Port away from QDesktopServices as David's comment says.


Diffs
-

  src/core/installation.cpp 69a9ac50d275712a1ded0dd3ef45bfaa273431c0 

Diff: https://git.reviewboard.kde.org/r/128120/diff/


Testing
---

manual testing


Thanks,

Andreas Cord-Landwehr

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128121: Use scoped pointer for complicated delete logic

[Andreas Cord-Landwehr]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128121/
---

(Updated June 7, 2016, 4:30 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Jeremy Whiting.


Changes
---

Submitted with commit d56207480607e80927c24ef84bc746cfd4dafd69 by Andreas 
Cord-Landwehr to branch master.


Repository: knewstuff


Description
---

Use scoped pointer for complicated delete logic


Diffs
-

  src/core/installation.cpp 69a9ac50d275712a1ded0dd3ef45bfaa273431c0 

Diff: https://git.reviewboard.kde.org/r/128121/diff/


Testing
---

manual testing


Thanks,

Andreas Cord-Landwehr

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128119: Explicitly declare methods as overridden

[Andreas Cord-Landwehr]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128119/
---

(Updated June 7, 2016, 5:10 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Jeremy Whiting.


Changes
---

Submitted with commit 2ba435376571f1c85457353260b7bc2fcf4f5b9c by Andreas 
Cord-Landwehr to branch master.


Repository: knewstuff


Description
---

Also remove virtual, since this is inheritated by the parent and
override states clearly that these are overriden methods.


Diffs
-

  src/ui/itemsviewbasedelegate_p.h 5b20f684b04e017b859e9aebdd34b52c1d298741 

Diff: https://git.reviewboard.kde.org/r/128119/diff/


Testing
---


Thanks,

Andreas Cord-Landwehr

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: KApiDox Maintainship

[Aleix Pol]

On Tue, Jun 7, 2016 at 7:28 AM, Olivier Churlaud  wrote:
> Hi,
>
>  I did a lot of work on KApiDox the last weeks, and I have still a lot in
> mind to improve it. I spoke with Alex about the maintainship of KApidox as
> he doesn't have currently time to spend on it. He told me he was ok to pass
> me the maintainship.
>
>  I don't know how this work, so I would like some explanations about what
> being the maintainer means, what are the responsibilities and constrains,
> and of course, after I'll know that, if it's ok that I change the Alex's
> name with mine for Kapidox maintainer.

+1

Thanks Olivier! KApiDox does need that love!
And thanks Alex for the work so far! :)

Aleix
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 128121: Use scoped pointer for complicated delete logic

[Andreas Cord-Landwehr]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128121/
---

Review request for KDE Frameworks and Jeremy Whiting.


Repository: knewstuff


Description
---

Use scoped pointer for complicated delete logic


Diffs
-

  src/core/installation.cpp 69a9ac50d275712a1ded0dd3ef45bfaa273431c0 

Diff: https://git.reviewboard.kde.org/r/128121/diff/


Testing
---

manual testing


Thanks,

Andreas Cord-Landwehr

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128121: Use scoped pointer for complicated delete logic

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128121/#review96261
---


Ship it!




Ship It!

- Aleix Pol Gonzalez


On June 7, 2016, 5:39 p.m., Andreas Cord-Landwehr wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128121/
> ---
> 
> (Updated June 7, 2016, 5:39 p.m.)
> 
> 
> Review request for KDE Frameworks and Jeremy Whiting.
> 
> 
> Repository: knewstuff
> 
> 
> Description
> ---
> 
> Use scoped pointer for complicated delete logic
> 
> 
> Diffs
> -
> 
>   src/core/installation.cpp 69a9ac50d275712a1ded0dd3ef45bfaa273431c0 
> 
> Diff: https://git.reviewboard.kde.org/r/128121/diff/
> 
> 
> Testing
> ---
> 
> manual testing
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel