date:20170111

davidedmundson created this revision.
davidedmundson added reviewers: Plasma, Frameworks.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D4084

AFFECTED FILES
  autotests/desktoptojsontest.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, #frameworks
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D4082: parse the desktop file 2 times

davidedmundson added a comment.


  See https://phabricator.kde.org/D4084

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D4082

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, dfaure, davidedmundson
Cc: apol, plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Accepted] D4084: Add unit test for desktopToJson being called without an explicit serviceType

apol accepted this revision.
apol added a reviewer: apol.
This revision is now accepted and ready to land.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D4084

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, #frameworks, apol
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D4082: parse the desktop file 2 times

apol accepted this revision.
apol added a reviewer: apol.
This revision is now accepted and ready to land.

REPOSITORY
  R244 KCoreAddons

BRANCH
  phab/prse2servicetypes

REVISION DETAIL
  https://phabricator.kde.org/D4082

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, dfaure, davidedmundson, apol
Cc: apol, plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Updated, 140 lines] D4082: parse the desktop file 2 times

mart updated this revision to Diff 10054.
mart added a comment.


  - add an autotest for a list item before the servicetypes definition

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4082?vs=10045=10054

BRANCH
  phab/prse2servicetypes

REVISION DETAIL
  https://phabricator.kde.org/D4082

AFFECTED FILES
  autotests/data/twostepsparsetest.desktop
  autotests/kpluginmetadatatest.cpp
  src/lib/plugin/desktopfileparser.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, dfaure, davidedmundson, apol
Cc: apol, plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Updated, 109 lines] D4082: parse the desktop file 2 times

mart updated this revision to Diff 10045.
mart marked an inline comment as done.
mart added a comment.


  - don't load servicetypes a second time

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4082?vs=10044=10045

BRANCH
  phab/prse2servicetypes

REVISION DETAIL
  https://phabricator.kde.org/D4082

AFFECTED FILES
  src/lib/plugin/desktopfileparser.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, dfaure, davidedmundson
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Commented On] D4082: parse the desktop file 2 times

davidedmundson added a comment.


  +1

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D4082

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, dfaure, davidedmundson
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Closed] D4082: parse the desktop file 2 times

This revision was automatically updated to reflect the committed changes.
Closed by commit R244:2a9b56e93407: parse the desktop file 2 times (authored by 
mart).

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4082?vs=10054=10055

REVISION DETAIL
  https://phabricator.kde.org/D4082

AFFECTED FILES
  autotests/data/twostepsparsetest.desktop
  autotests/kpluginmetadatatest.cpp
  src/lib/plugin/desktopfileparser.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, dfaure, davidedmundson, apol
Cc: apol, plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 193 - Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/193/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 11 Jan 2017 15:13:47 +
Build duration: 2 min 1 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.kservicetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5491/8008 
(69%)CONDITIONAL 2984/6178 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1466/1554 
(94%)CONDITIONAL 903/1792 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1766/3045 
(58%)CONDITIONAL 762/1892 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2043/2796 
(73%)CONDITIONAL 1234/2066 (60%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)

[Differential] [Updated] D4082: parse the desktop file 2 times

davidedmundson added a comment.


  Also you can remove the lines
  
} else if (key == QByteArrayLiteral("X-KDE-ServiceTypes") || key == 
QByteArrayLiteral("ServiceTypes")) {
const auto services = deserializeList(value);
  
  - for(const auto  : services) {
  - // some .desktop files still use the legacy ServiceTypes= key
  - QString fileName = service.toLower().replace(QLatin1Char('/'), 
QLatin1Char('-'))+QStringLiteral(".desktop");
  - serviceTypes.addFile(fileName);
  - }
  
  from inside DesktopFileParser::convertToJson as we'll hae already done that
  
  (I had written https://paste.kde.org/pipfub7bu last night, but wanted to 
split that tokenisation out that you've done)

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D4082

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, dfaure, davidedmundson
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Updated, 102 lines] D4082: parse the desktop file 2 times

mart updated this revision to Diff 10044.
mart added a comment.


  - don't close/reopen the file

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4082?vs=10039=10044

BRANCH
  phab/prse2servicetypes

REVISION DETAIL
  https://phabricator.kde.org/D4082

AFFECTED FILES
  src/lib/plugin/desktopfileparser.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, dfaure, davidedmundson
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Accepted] D3811: Use KPlugin for calendar applet plugins

2017-01-11 Thread Albert Astals Cid

aacid accepted this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D3811

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: dvratil, mart, davidedmundson, aacid
Cc: #frameworks, #plasma

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 197 - Fixed!


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/197/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 11 Jan 2017 21:30:22 +
Build duration: 1 min 53 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 
11 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5483/8008 
(68%)CONDITIONAL 2965/6178 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1464/1554 
(94%)CONDITIONAL 890/1792 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1766/3045 
(58%)CONDITIONAL 762/1892 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2037/2796 
(73%)CONDITIONAL 1228/2066 (59%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 197 - Fixed!


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/197/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 11 Jan 2017 21:30:22 +
Build duration: 1 min 53 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 
11 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5483/8008 
(68%)CONDITIONAL 2965/6178 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1464/1554 
(94%)CONDITIONAL 890/1792 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1766/3045 
(58%)CONDITIONAL 762/1892 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2037/2796 
(73%)CONDITIONAL 1228/2066 (59%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)

[Differential] [Commented On] D4082: parse the desktop file 2 times

apol added a comment.


  How about adding a test?
  
  Other than that, the patch looks good.
  
  It's horrible that we need to do so, but I guess it's the price of backwards 
compatibility. There's the possibility of doing the processing in two steps 
(desktop to pairs, pairs to json), but we agreed that this code shouldn't be 
optimized anyway (as it's transitional and what we support is json).

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D4082

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, dfaure, davidedmundson
Cc: apol, plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 196 - Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/196/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 11 Jan 2017 15:11:16 +
Build duration: 2 min 21 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.kservicetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5483/8008 
(68%)CONDITIONAL 2970/6178 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1464/1554 
(94%)CONDITIONAL 895/1792 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1766/3045 
(58%)CONDITIONAL 761/1892 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2037/2796 
(73%)CONDITIONAL 1229/2066 (59%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)

[Differential] [Accepted] D3811: Use KPlugin for calendar applet plugins

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D3811

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: dvratil, mart, aacid, davidedmundson
Cc: #frameworks, #plasma

[Differential] [Closed] D4040: [Icon Item] Round size we want to load a pixmap in

2017-01-11 Thread Kai Uwe Broulik

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:0a7ae2ce97c4: [Icon Item] Round size we want to load a 
pixmap in (authored by broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4040?vs=9901=10027

REVISION DETAIL
  https://phabricator.kde.org/D4040

AFFECTED FILES
  src/declarativeimports/core/iconitem.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, subdiff, plasma-devel, #frameworks, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D2075: Fix bug in kfiledialog.cpp that causes crashing when native widgets are used.

2017-01-11 Thread Kevin Funk

kfunk added a comment.


  Why did you remove all the early-returns? Was that the case before in one of 
your earlier patches?

REPOSITORY
  R239 KDELibs4Support

REVISION DETAIL
  https://phabricator.kde.org/D2075

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jonathans, #frameworks, dfaure, kfunk
Cc: kfunk, aacid

[Differential] [Request, 28 lines] D4080: KAboutData: Document that bug email address can also be a URL

marten created this revision.
marten added a reviewer: Frameworks.
marten set the repository for this revision to R244 KCoreAddons.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  Differential https://phabricator.kde.org/D4072 requests a change to the bug 
reporting system in order that the reporting address can be a URL, in addition 
to an email address as as present.  This requires no actual code changes to  
KAboutData, but as suggested the parameters and private variables are renamed 
and the API documentation updated to indicate this.

TEST PLAN
  Built kcoreaddons with these changes, all autotests pass.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D4080

AFFECTED FILES
  src/lib/kaboutdata.cpp
  src/lib/kaboutdata.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: marten, #frameworks

[Differential] [Updated] D4080: KAboutData: Document that bug email address can also be a URL

marten added a dependency: D4072: Bug reporter: Allow a URL (not just as an 
email address) for custom reporting.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D4080

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: marten, #frameworks

[Differential] [Updated] D4072: Bug reporter: Allow a URL (not just as an email address) for custom reporting

marten added a dependent revision: D4080: KAboutData: Document that bug email 
address can also be a URL.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D4072

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: marten, #frameworks
Cc: aacid

Re: [Interest] Qt 5.7+ and Command+Shift shortcuts on Mac

2017-01-11 Thread René J . V . Bertin

On Wednesday January 11 2017 06:08:39 Andy Shaw wrote:

Hi,

>I have been doing some patches lately (i.e. yesterday and the day before) to 
>fix shortcuts (these have been reported on JIRA already too) on Cocoa so I 
>don’t know if this is addressed already in Qt 5.8.x as a result. But it might 
>be worth keeping an eye on that to see if it is working there too.

I usually avoid .0 releases but if 5.8.0 is taking the role of a 5.7.3+ bug 
release in addition to introducing new features that would change things. 
provided it still supports OS X 10.9 .
What's its ETA?

Any chance those patches can be backported without serious refactoring? 
Supposing 5.8 has seen considerable internal overhauling it would be 
interesting to know it the issue in 5.7.1 is the same as the one in 5.8, no?

R.

[Differential] [Commented On] D4072: Bug reporter: Allow a URL (not just as an email address) for custom reporting

marten added a comment.


  Yes, I'll submit a separate diff for that.  Fortunately BC, since there are 
no actual code changes needed - only the parameter name.  The getter/setter 
bugAddress/setBugAddress will suffice as they are (with apidoc changes).

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D4072

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: marten, #frameworks
Cc: aacid

[Differential] [Commented On] D3702: kconfig_compiler: Use nullptr in generated code

2017-01-11 Thread David Faure

dfaure added a comment.


  The QFont::toString() I mentionned in my last comment were due to changes in 
Qt 5.8, and I now fixed them.
  
  https://codereview.qt-project.org/181645
  
  All good now, sorry for the noise.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D3702

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kfunk, #frameworks, davidedmundson
Cc: aacid, graesslin, dfaure

[Differential] [Updated, 55 lines] D3811: Use KPlugin for calendar applet plugins

2017-01-11 Thread Daniel Vrátil

dvratil updated this revision to Diff 10022.
dvratil added a comment.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.


  Fix loading of legacy plugins.

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3811?vs=9365=10022

REVISION DETAIL
  https://phabricator.kde.org/D3811

AFFECTED FILES
  src/declarativeimports/calendar/CMakeLists.txt
  src/declarativeimports/calendar/eventpluginsmanager.cpp
  src/declarativeimports/calendar/eventpluginsmanager.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: dvratil, mart, aacid
Cc: #frameworks, #plasma

[Differential] [Updated] D4082: parse the desktop file 2 times

mart added reviewers: davidedmundson, dfaure.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D4082

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, davidedmundson, dfaure
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Request, 102 lines] D4082: parse the desktop file 2 times

mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  Search for the ServiceTypes key in the desktop file before
  parsing it "for real", because how it's parsed depends from
  the service type definition, so if the servicetype is defined
  at the bottom of the file or after keys dependent from the type,
  those keys would be parsed incorrectly

TEST PLAN
  things using plugins like plasmashell still start correctly,
  dropping on the desktop a text file now proposes to create a notes widget.
  The notes widget has ServiceTypes defined *after* X-Plasma-DropMimetypes
  which is a stringlist, that would be misinterpreted as a string
  otherwise

REPOSITORY
  R244 KCoreAddons

BRANCH
  phab/prse2servicetypes

REVISION DETAIL
  https://phabricator.kde.org/D4082

AFFECTED FILES
  src/lib/plugin/desktopfileparser.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Commented On] D4082: parse the desktop file 2 times

mart added inline comments.

INLINE COMMENTS

> desktopfileparser.cpp:237
>  
> +bool tokenizeKeyValue(QFile , const QString , QByteArray , 
> QString , int )
> +{

maybe instead a bool it could have error codes to more easily assure the 
behavior is 100% the same as before

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D4082

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, davidedmundson, dfaure
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

Re: [Interest] Qt 5.7+ and Command+Shift shortcuts on Mac

2017-01-11 Thread Andy Shaw

Hi,

Qt 5.8.0 is in essence taking on the role of 5.7.3 I believe and it should be 
out in a week or so, but one of these patches will be in 5.8.1 and not 5.8.0 in 
any case.

They can be applied to 5.7.x without any problem as this code has not really 
changed much since Qt 5.7.0, the ones I am thinking of at least which would be 
worth looking at are:

  https://codereview.qt-project.org/#/c/181777/
https://codereview.qt-project.org/#/c/175556/

as this has helped improve things a fair bit.

Andy

René J.V. Bertin  skrev følgende den 11.01.2017, 09.10:

On Wednesday January 11 2017 06:08:39 Andy Shaw wrote:

Hi,

>I have been doing some patches lately (i.e. yesterday and the day before) 
to fix shortcuts (these have been reported on JIRA already too) on Cocoa so I 
don’t know if this is addressed already in Qt 5.8.x as a result. But it might 
be worth keeping an eye on that to see if it is working there too.

I usually avoid .0 releases but if 5.8.0 is taking the role of a 5.7.3+ bug 
release in addition to introducing new features that would change things. 
provided it still supports OS X 10.9 .
What's its ETA?

Any chance those patches can be backported without serious refactoring? 
Supposing 5.8 has seen considerable internal overhauling it would be 
interesting to know it the issue in 5.7.1 is the same as the one in 5.8, no?

R.

Re: [Interest] Qt 5.7+ and Command+Shift shortcuts on Mac

2017-01-11 Thread Andy Shaw

I have been doing some patches lately (i.e. yesterday and the day before) to 
fix shortcuts (these have been reported on JIRA already too) on Cocoa so I 
don’t know if this is addressed already in Qt 5.8.x as a result. But it might 
be worth keeping an eye on that to see if it is working there too.

Andy

Interest på vegne av René J.V. Bertin 
 skrev følgende den 10.01.2017, 19.55:

On Sunday January 8 2017 23:47:26 Samuel Gaist wrote:

Hi,

>https://bugreports.qt.io/browse/QTBUG-57990 is about a similar problem for 
Ubuntu.
>Coming from this https://forum.qt.io/topic/74872/ forum thread.
>
>5.7.0 works correctly for him but not 5.7.1

Thanks for this. I added my 2 cents to the bug report.

Sadly I skipped 5.7.0 so I don't know if my issue existed there. What I do 
know is that there are some reasons to believe that the Command+Shift shortcut 
issue is due to a regression in the Cocoa plugin, but that the only distinctive 
differences in that part of the code that are clearly related to shortcuts are 
apparently not to blame. (Easy to revert and that didn't solve anything for me.)

R.
___
Interest mailing list
inter...@qt-project.org
http://lists.qt-project.org/mailman/listinfo/interest

Review Request 129807: proposal: add ksvg2ico

2017-01-11 Thread René J . V . Bertin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129807/
---

Review request for KDE Frameworks, kdewin and Christoph Feck.

Repository: kiconthemes

Description
---

Recently I committed a few changes to `ecm_add_app_icon` that make use of the
fact that KIconThemes includes a `ksvg2icns` utility, making it possible to
generate an application icon from an SVG file instead of from a series of PNG
files.

With the present patch I propose to add an updated and partly rewritten version
of the ageing `svg2ico` tool from the KDEWin project to KIconThemes. The goal
is to have a proper and up-to-date tool to generate application icons from SVG
on MS Windows too.

I considered proposing it to KDEWin instead, but in the end I liked the idea
better to provide icon conversion utilities for Mac and Windows with a
framework, where they might also serve in a less KDE-centric context (and
cross-platform development).
I also played with the idea of integrating the png2ico step into the tool, but
noticed during testing that Matthias Benkmann's png2ico supports input sizes up
to 248x248 while KDEWin's png2ico is currently limited at 48x48 or maybe even
32x32. Lacking a MSWin development system I'm not volunteering to update that
code.

Diffs
-

src/CMakeLists.txt efba9e6
src/tools/ksvg2ico/CMakeLists.txt PRE-CREATION
src/tools/ksvg2ico/ksvg2ico.cpp PRE-CREATION

Diff: https://git.reviewboard.kde.org/r/129807/diff/

Testing
---

On Mac OS X 10.9 with Qt 5.7.1 and KF5 5.29.0 .

File Attachments

.ico file generated from sc-apps-calligrakarbon.svgz using ksvg2ico with
Benkmann's png2ico

https://git.reviewboard.kde.org/media/uploaded/files/2017/01/11/aa0973dc-1be8-4d36-82dc-8f7baa053fee__apps-calligrakarbon.ico

Thanks,

René J.V. Bertin

[Differential] [Commented On] D2075: Fix bug in kfiledialog.cpp that causes crashing when native widgets are used.

2017-01-11 Thread Jonathan Schultz

jonathans added a comment.


  I wrote the first patch to  be as minimal as possible and to be consistent 
with the previous coding style. I therefore left the early returns in place.
  
  I wrote the latest patch based on my interpretation of your (@kfunk) feedback 
that it makes more sense to test d->w than d->native. Because implementing this 
involved a change to the existing coding style I took the liberty of writing it 
according to what I believe to be good coding practice.
  
  Early returns are suitable for dealing with erroneous or trivial cases, but 
less so when dealing with modes of operation, as in this code. They interrupt 
the logical flow of the code, and because the conditionally executed code no 
longer sits inside an indented block, make it less evident to the reader that 
it is conditionally executed.
  
  Actually thinking about this code a bit more closely, I would now take the 
position that the earlier practice of only testing d->native is more sensible. 
What is happening here is that kfiledialog has two modes of operation: native 
and non-native. This mode is reflected in the two variables d->native and d->w, 
of which only one should ever be non-null. Which of the two variable the code 
tests now (ie with the latest patch) varies from case to case, which makes it 
inconsistent. Moreover the meaning of d->native is self-explanatory, unlike 
d->w. Although testing d->w would avoid segmentation faults if both d->native 
or d->w were null, the fact is that if that ever happened there would have to 
be a serious problem anyway and the code would be obviously broken. Trapping a 
segfault with a debugger would actually make it easier to locate the problem 
than, for instance, a file dialog window simply failing to be displayed.
  
  But that's all going off on a tangent. Whatever your call is on this case I'm 
happy to accept.

REPOSITORY
  R239 KDELibs4Support

REVISION DETAIL
  https://phabricator.kde.org/D2075

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jonathans, #frameworks, dfaure, kfunk
Cc: kfunk, aacid

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 195 - Fixed!


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/195/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 11 Jan 2017 22:11:25 +
Build duration: 1 min 49 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 
11 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5490/8008 
(69%)CONDITIONAL 2975/6178 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1464/1554 
(94%)CONDITIONAL 892/1792 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1767/3045 
(58%)CONDITIONAL 764/1892 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2043/2796 
(73%)CONDITIONAL 1234/2066 (60%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 195 - Fixed!


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/195/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 11 Jan 2017 22:11:25 +
Build duration: 1 min 49 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 
11 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5490/8008 
(69%)CONDITIONAL 2975/6178 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1464/1554 
(94%)CONDITIONAL 892/1792 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1767/3045 
(58%)CONDITIONAL 764/1892 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2043/2796 
(73%)CONDITIONAL 1234/2066 (60%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)

[Differential] [Closed] D4060: kio: Ensure user certificate directory has been created before storing certs to it

2017-01-11 Thread Michael Pyne

mpyne closed this revision.
mpyne added a comment.


  This diff was pushed to kio, closing manually since I seem to have messed up 
the commit msg. See 
https://cgit.kde.org/kio.git/commit/?id=d06e40bc1e84391640fc56a4c5ba252eaa9dcc6d

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D4060

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mpyne, #frameworks, apol, ahartmetz

[Differential] [Request, 6 lines] D4092: Part Revert "[Units] Make iconSizes property constant"

davidedmundson created this revision.
davidedmundson added reviewers: Plasma, Frameworks.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Though we can make the property constant, some applications still use the
  signal (for example FolderView.qml) to know that one of the icons has
  changed sizes and do some processing.
  
  Whilst it would be possible to fix folderview, we should avoid public
  API changes.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D4092

AFFECTED FILES
  src/declarativeimports/core/units.cpp
  src/declarativeimports/core/units.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, #frameworks
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D4092: Part Revert "[Units] Make iconSizes property constant"

apol added a comment.


  I don't get it. If it changes, why is it constant?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4092

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, #frameworks
Cc: apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D4080: KAboutData: Document that bug email address can also be a URL

2017-01-11 Thread Michael Pyne

mpyne accepted this revision.
mpyne added a reviewer: mpyne.
mpyne added a comment.
This revision is now accepted and ready to land.


  LGTM, and things seem to work in my testing as well.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D4080

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: marten, #frameworks, mpyne
Cc: mpyne

[Differential] [Request, 81 lines] D4096: KConfigDialog_UnitTest: cover also custom config widgets

2017-01-11 Thread Friedrich W. H. Kossebau

kossebau created this revision.
kossebau added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  Adds tests for using custom widgets with KConfigDialog

REPOSITORY
  R265 KConfigWidgets

BRANCH
  extendKConfigDialog_UnitTest

REVISION DETAIL
  https://phabricator.kde.org/D4096

AFFECTED FILES
  autotests/kconfigdialog_unittest.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kossebau, #frameworks

Re: Review Request 129807: proposal: add ksvg2ico

2017-01-11 Thread Christoph Feck


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129807/#review101945
---



Could you test it with an SVG file that contains text? From what I remember, 
painting text requires a QGuiApplication to access the font database.

Additionally, I do not like the hand-made command line parsing. We have 
QCommandLineParser for this.


src/CMakeLists.txt (line 5)


Is it actually useful on non-Windows systems? If not, please add a 
conditional similar to the Apple tool above.



src/tools/ksvg2ico/ksvg2ico.cpp (line 24)


Trailing whitespace



src/tools/ksvg2ico/ksvg2ico.cpp (line 116)


Trailing whitespace



src/tools/ksvg2ico/ksvg2ico.cpp (line 117)


Missing space after comma


- Christoph Feck


On Jan. 11, 2017, 9:15 p.m., René J.V. Bertin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129807/
> ---
> 
> (Updated Jan. 11, 2017, 9:15 p.m.)
> 
> 
> Review request for KDE Frameworks, kdewin and Christoph Feck.
> 
> 
> Repository: kiconthemes
> 
> 
> Description
> ---
> 
> Recently I committed a few changes to `ecm_add_app_icon` that make use of the 
> fact that KIconThemes includes a `ksvg2icns` utility, making it possible to 
> generate an application icon from an SVG file instead of from a series of PNG 
> files. 
> 
> With the present patch I propose to add an updated and partly rewritten 
> version of the ageing `svg2ico` tool from the KDEWin project to KIconThemes. 
> The goal is to have a proper and up-to-date tool to generate application 
> icons from SVG on MS Windows too.
> 
> I considered proposing it to KDEWin instead, but in the end I liked the idea 
> better to provide icon conversion utilities for Mac and Windows with a 
> framework, where they might also serve in a less KDE-centric context (and 
> cross-platform development).
> I also played with the idea of integrating the png2ico step into the tool, 
> but noticed during testing that Matthias Benkmann's png2ico supports input 
> sizes up to 248x248 while KDEWin's png2ico is currently limited at 48x48 or 
> maybe even 32x32. Lacking a MSWin development system I'm not volunteering to 
> update that code.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt efba9e6 
>   src/tools/ksvg2ico/CMakeLists.txt PRE-CREATION 
>   src/tools/ksvg2ico/ksvg2ico.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/129807/diff/
> 
> 
> Testing
> ---
> 
> On Mac OS X 10.9 with Qt 5.7.1 and KF5 5.29.0 .
> 
> 
> File Attachments
> 
> 
> .ico file generated from sc-apps-calligrakarbon.svgz using ksvg2ico with 
> Benkmann's png2ico
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2017/01/11/aa0973dc-1be8-4d36-82dc-8f7baa053fee__apps-calligrakarbon.ico
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 194 - Still Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/194/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 11 Jan 2017 21:15:44 +
Build duration: 1 min 57 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.kservicetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5483/8008 
(68%)CONDITIONAL 2968/6178 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1464/1554 
(94%)CONDITIONAL 895/1792 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1766/3045 
(58%)CONDITIONAL 761/1892 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2037/2796 
(73%)CONDITIONAL 1227/2066 (59%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)

[Differential] [Commented On] D4092: Part Revert "[Units] Make iconSizes property constant"

davidedmundson added a comment.


  In https://phabricator.kde.org/D4092#76611, @apol wrote:
  
  > I don't get it. If it changes, why is it constant?
  
  
  The icon sizes change
  
  These are exposed in a QQmlPropertyMap
  The address of that QQmlPropertyMap is always the same

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4092

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, #frameworks
Cc: apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D4092: Part Revert "[Units] Make iconSizes property constant"