KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 263 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/263/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 18 May 2018 03:40:30 +
 Build duration:
5 min 47 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(294/443)66%
(294/443)53%
(31742/60029)38%
(18736/49376)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8704/9259)48%
(5405/11151)autotests.http100%
(9/9)100%
(9/9)99%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(100/119)84%
(100/119)58%
(8392/14498)50%
(4897/9804)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets78%
(31/40)78%
(31/40)49%
(3900/7917)33%
(1638/4966)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(521/1008)42%
(417/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 18 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/18/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.10
 Date of build:
Fri, 18 May 2018 03:40:30 +
 Build duration:
4 min 11 sec and counting
   JUnit Tests
  Name: (root) Failed: 34 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiofilewidgets-kdiroperatortestFailed: TestSuite.kiofilewidgets-kfilecopytomenutestFailed: TestSuite.kiofilewidgets-kfilecustomdialogtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiofilewidgets-kfileplacesviewtestFailed: TestSuite.kiofilewidgets-kfilewidgettestFailed: TestSuite.kiofilewidgets-knewfilemenutestFailed: TestSuite.kiofilewidgets-kurlcomboboxtestFailed: TestSuite.kiofilewidgets-kurlnavigatortestFailed: TestSuite.kiofilewidgets-kurlrequestertestFailed: TestSuite.kiogui-favicontestFailed: TestSuite.kioslave-httpauthenticationtestFailed: TestSuite.kioslave-httpheaderdispositiontestFailed: TestSuite.kioslave-httpheadertokenizetestFailed: TestSuite.kioslave-httpobjecttestFailed: TestSuite.kioslave-kcookiejartestFailed: TestSuite.kiowidgets-accessmanagertestFailed: TestSuite.kiowidgets-accessmanagertest-qnamFailed: TestSuite.kiowidgets-clipboardupdatertestFailed: TestSuite.kiowidgets-dropjobtestFailed: TestSuite.kiowidgets-fileundomanagertestFailed: TestSuite.kiowidgets-jobguitestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltestFailed: TestSuite.kiowidgets-kfileitemactionstestFailed: TestSuite.kiowidgets-krununittestFailed: TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: TestSuite.kiowidgets-kurifiltertestFailed: TestSuite.kiowidgets-kurlcompletiontestFailed: TestSuite.kiowidgets-kurlcompletiontest-nowaitFailed: TestSuite.kiowidgets-pastetestFailed: TestSuite.kpasswdservertest

KDE CI: Frameworks knotifications kf5-qt5 WindowsMSVCQt5.10 - Build # 16 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20knotifications%20kf5-qt5%20WindowsMSVCQt5.10/16/
 Project:
Frameworks knotifications kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Thu, 17 May 2018 07:58:25 +
 Build duration:
19 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.KNotificationTest

D12919: [Plotter] Don't render if m_node is null

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R296:9d7c4927e506: [Plotter] Dont render if m_node is 
null (authored by broulik).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12919?vs=34261=34356

REVISION DETAIL
  https://phabricator.kde.org/D12919

AFFECTED FILES
  src/qmlcontrols/kquickcontrolsaddons/plotter.cpp

To: broulik, #plasma, bshah, davidedmundson
Cc: davidedmundson, bshah, kde-frameworks-devel, michaelh, ngraham, bruns

D12919: [Plotter] Don't render if m_node is null

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.


  I think it makes sense in the following situation:
  
  a remove window event is queued 
  a render event is queued
  
  we'll have set node to null, and called disconnect, but we'll still be 
processing pending events.
  
  Ship it

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D12919

To: broulik, #plasma, bshah, davidedmundson
Cc: davidedmundson, bshah, kde-frameworks-devel, michaelh, ngraham, bruns

D12945: kcoredirlister lstItems benchmark

[Jaime Torres Amate]

jtamate added a dependent revision: D11282: less expensive findByUrl in 
KCoreDirListerCache.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12945

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D11282: less expensive findByUrl in KCoreDirListerCache

[Jaime Torres Amate]

jtamate added a dependency: D12945: kcoredirlister lstItems benchmark.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11282

To: jtamate, #frameworks, dfaure
Cc: mwolff, michaelh, ngraham, bruns

D12945: kcoredirlister lstItems benchmark

[Jaime Torres Amate]

jtamate created this revision.
jtamate added reviewers: dfaure, Frameworks.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
jtamate requested review of this revision.

REVISION SUMMARY
  Decide which data structure is best for kcoredirlister lstItems.
  Defined as NonMovableFileItemList lstItems;  in kcoredirlister_p.h (484).
  
  The results in one machine:
  
  |  | QList | QListBinary | QListBinaryHash | QHash |
  | add  | 17| 35  | 20  | 18|
  | findByName   | 937   | 969 | 1.326   | 1.626 |
  | findByUrl| 1.953 | 66  | 7,6 | 7,2   |
  | findByUrlAll | 692   | 25  | 8,2 | 8,0   |
  |

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12945

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/kcoredirlister_benchmark.cpp

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12820: Add KWayland virtual desktop protocol

[Martin Flöser]

graesslin added inline comments.

INLINE COMMENTS

> mart wrote in org_kde_plasma_virtual_desktop.xml:45
> Ok, so no layout information at all neither in the manager nor in the single 
> virtual desktops?
> I kindof like that as makes things a lot simpler. Tough in this case if the 
> concept of layout becomes completely internal in kwin, how to communicate it 
> to the client? a pager would still need to loosely represent the same layout.

A possibility could be a sibling concept. Every desktop could have a reference 
to the desktop to the left/top/right/bottom.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D12820

To: mart, #kwin, #plasma, graesslin, hein
Cc: bshah, romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D12820: Add KWayland virtual desktop protocol

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> graesslin wrote in org_kde_plasma_virtual_desktop.xml:45
> I would prefer to not have any layout in the protocol. Setting a layout makes 
> it impossible to have different virtual desktop per output.

Ok, so no layout information at all neither in the manager nor in the single 
virtual desktops?
I kindof like that as makes things a lot simpler. Tough in this case if the 
concept of layout becomes completely internal in kwin, how to communicate it to 
the client? a pager would still need to loosely represent the same layout.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D12820

To: mart, #kwin, #plasma, graesslin, hein
Cc: bshah, romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D11282: less expensive findByUrl in KCoreDirListerCache

[Stefan Brüns]

bruns added a comment.
Restricted Application added a subscriber: kde-frameworks-devel.


  @jtamate - can you use `arc --diff` next time you create a revision, instead 
of using the web upload?
  
  Not using arc results in phabricator being unable to show the context 
("Context not available"), which makes reviewing considerably harder.
  
  See https://secure.phabricator.com/T5029 for background info.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11282

To: jtamate, #frameworks, dfaure
Cc: kde-frameworks-devel, bruns, mwolff, michaelh, ngraham

D12578: fix some issues reported by clazy

[Stefan Brüns]

bruns requested changes to this revision.
bruns added a comment.
This revision now requires changes to proceed.


  One change pending, then you are good to go ...

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12578

To: mgallien, #baloo, #frameworks, bruns
Cc: kde-frameworks-devel, bruns, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham

D12820: Add KWayland virtual desktop protocol

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> graesslin wrote in org_kde_plasma_virtual_desktop.xml:45
> A possibility could be a sibling concept. Every desktop could have a 
> reference to the desktop to the left/top/right/bottom.

How you would envision different virtual desktops per output?
to me is a bit of a weird concept, as an output is an actual desktop, not 
virtual?

> graesslin wrote in org_kde_plasma_virtual_desktop.xml:45
> A possibility could be a sibling concept. Every desktop could have a 
> reference to the desktop to the left/top/right/bottom.

> A possibility could be a sibling concept. Every desktop could have a 
> reference to the desktop to the left/top/right/bottom.

wouldn't become harder to track and rebuild a visual representation from it?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D12820

To: mart, #kwin, #plasma, graesslin, hein
Cc: bshah, romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D11282: less expensive findByUrl in KCoreDirListerCache

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> dfaure wrote in kcoredirlister.cpp:852
> That was the case already hmm but not in my version of kio. It looks like 
> this patch is on top of other patches.

D10742  - this makes it even harder to 
review ...

> mwolff wrote in kcoredirlister.cpp:1970
> O(N) iteration over a large hash is extremely slow, is this done elsewhere? 
> if so, then you may need to find an alternative approach - potentially via 
> multiple containers or by using a sorted vector after all like you proposed 
> initially

My proposal:
A few lines earlier, a `KFileItemList` (~`QList)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11282

To: jtamate, #frameworks, dfaure
Cc: kde-frameworks-devel, bruns, mwolff, michaelh, ngraham

D12578: fix some issues reported by clazy

[Matthieu Gallien]

mgallien marked an inline comment as done.
mgallien added a comment.


  @bruns Thanks for the review and sorry for my slowness.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12578

To: mgallien, #baloo, #frameworks, bruns
Cc: kde-frameworks-devel, bruns, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham

D12932: handle string lists as input

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:03ab297f2512: handle string lists as input (authored by 
astippich).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12932?vs=34323=34395

REVISION DETAIL
  https://phabricator.kde.org/D12932

AFFECTED FILES
  src/file/extractor/result.cpp

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns

D12950: add test which checks the property types

[Alexander Stippich]

astippich created this revision.
astippich added reviewers: mgallien, bruns.
Restricted Application added projects: Frameworks, Baloo.
Restricted Application added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  Check the type of the properties defined in kfilemetadata vs. the actual 
returned types obtained from QVariant.
  Testing only one file is sufficient as this is shared code. Expected failures 
are declared as such.

REPOSITORY
  R286 KFileMetaData

BRANCH
  property_tests

REVISION DETAIL
  https://phabricator.kde.org/D12950

AFFECTED FILES
  autotests/taglibextractortest.cpp
  autotests/taglibextractortest.h

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns

D12156: implement reading of rating tag

[Alexander Stippich]

astippich added a comment.


  any comments on the previous discussion?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D12156

To: astippich, mgallien, michaelh
Cc: kde-frameworks-devel, #baloo, bruns, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham

D12156: implement reading of rating tag

[Alexander Stippich]

astippich updated this revision to Diff 34398.
astippich added a comment.
Restricted Application edited subscribers, added: Baloo, kde-frameworks-devel; 
removed: Frameworks.


  - rebase on master
  - implement rating tag for m4a

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12156?vs=32591=34398

BRANCH
  rating

REVISION DETAIL
  https://phabricator.kde.org/D12156

AFFECTED FILES
  autotests/samplefiles/mp3_rating/testMM.mp3
  autotests/samplefiles/mp3_rating/testMM1.mp3
  autotests/samplefiles/mp3_rating/testMM10.mp3
  autotests/samplefiles/mp3_rating/testMM2.mp3
  autotests/samplefiles/mp3_rating/testMM3.mp3
  autotests/samplefiles/mp3_rating/testMM4.mp3
  autotests/samplefiles/mp3_rating/testMM5.mp3
  autotests/samplefiles/mp3_rating/testMM6.mp3
  autotests/samplefiles/mp3_rating/testMM7.mp3
  autotests/samplefiles/mp3_rating/testMM8.mp3
  autotests/samplefiles/mp3_rating/testMM9.mp3
  autotests/samplefiles/mp3_rating/testWMP.mp3
  autotests/samplefiles/mp3_rating/testWMP1.mp3
  autotests/samplefiles/mp3_rating/testWMP2.mp3
  autotests/samplefiles/mp3_rating/testWMP3.mp3
  autotests/samplefiles/mp3_rating/testWMP4.mp3
  autotests/samplefiles/mp3_rating/testWMP5.mp3
  autotests/samplefiles/test.flac
  autotests/samplefiles/test.m4a
  autotests/samplefiles/test.mpc
  autotests/samplefiles/test.ogg
  autotests/samplefiles/test.opus
  autotests/taglibextractortest.cpp
  autotests/taglibextractortest.h
  src/extractors/taglibextractor.cpp
  src/extractors/taglibextractor.h
  src/properties.h
  src/propertyinfo.cpp

To: astippich, mgallien, michaelh
Cc: kde-frameworks-devel, #baloo, bruns, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, #frameworks

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 16 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/16/
 Project:
Frameworks kwayland kf5-qt5 SUSEQt5.9
 Date of build:
Thu, 17 May 2018 21:16:28 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 43 test(s), Skipped: 0 test(s), Total: 44 test(s)Failed: TestSuite.kwayland-testRemoteAccess
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report57%
(4/7)90%
(225/251)90%
(225/251)84%
(24044/28682)52%
(11757/22674)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client98%
(40/41)98%
(40/41)98%
(11192/11475)49%
(7684/15553)autotests.server100%
(5/5)100%
(5/5)99%
(359/362)49%
(220/446)src.client97%
(69/71)97%
(69/71)84%
(5673/6728)65%
(1779/2748)src.server97%
(111/115)97%
(111/115)86%
(6820/7956)64%
(2074/3248)src.tools0%
(0/2)0%
(0/2)0%
(0/786)0%
(0/346)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/16)tests0%
(0/14)0%
(0/14)0%
(0/1255)0%
(0/317)

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 45 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/45/
 Project:
Frameworks kwayland kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 17 May 2018 21:16:28 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 42 test(s), Skipped: 0 test(s), Total: 44 test(s)Failed: TestSuite.kwayland-testRemoteAccessFailed: TestSuite.kwayland-testSubCompositor
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report57%
(4/7)90%
(225/251)90%
(225/251)84%
(24042/28682)52%
(11755/22674)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client98%
(40/41)98%
(40/41)98%
(11190/11475)49%
(7682/15553)autotests.server100%
(5/5)100%
(5/5)99%
(359/362)49%
(220/446)src.client97%
(69/71)97%
(69/71)84%
(5673/6728)65%
(1779/2748)src.server97%
(111/115)97%
(111/115)86%
(6820/7956)64%
(2074/3248)src.tools0%
(0/2)0%
(0/2)0%
(0/786)0%
(0/346)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/16)tests0%
(0/14)0%
(0/14)0%
(0/1255)0%
(0/317)

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 - Build # 7 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.10/7/
 Project:
Frameworks kwayland kf5-qt5 FreeBSDQt5.10
 Date of build:
Thu, 17 May 2018 21:16:28 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: (root) Failed: 15 test(s), Passed: 24 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kwayland-testCompositorFailed: TestSuite.kwayland-testDataDeviceFailed: TestSuite.kwayland-testDataSourceFailed: TestSuite.kwayland-testRegionFailed: TestSuite.kwayland-testRemoteAccessFailed: TestSuite.kwayland-testShmPoolFailed: TestSuite.kwayland-testSubCompositorFailed: TestSuite.kwayland-testSubSurfaceFailed: TestSuite.kwayland-testWaylandConnectionThreadFailed: TestSuite.kwayland-testWaylandRegistryFailed: TestSuite.kwayland-testWaylandServerDisplayFailed: TestSuite.kwayland-testWaylandShellFailed: TestSuite.kwayland-testWaylandSurfaceFailed: TestSuite.kwayland-testWindowmanagementFailed: TestSuite.kwayland-testXdgShellV5

D12578: fix some issues reported by clazy

[Matthieu Gallien]

mgallien updated this revision to Diff 34389.
mgallien added a comment.


  - fix one more issue

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12578?vs=34223=34389

BRANCH
  arcpatch-D12578

REVISION DETAIL
  https://phabricator.kde.org/D12578

AFFECTED FILES
  autotests/unit/file/pendingfilequeuetest.cpp
  src/engine/transaction.cpp
  src/file/fileindexerconfig.cpp
  src/file/fileindexscheduler.cpp
  src/file/firstrunindexer.cpp
  src/file/indexcleaner.cpp
  src/file/modifiedfileindexer.cpp
  src/file/newfileindexer.cpp
  src/file/xattrindexer.cpp
  src/kioslaves/kded/baloosearchmodule.cpp
  src/lib/query.cpp
  src/lib/searchstore.cpp
  src/lib/taglistjob.cpp
  src/lib/term.cpp

To: mgallien, #baloo, #frameworks, bruns
Cc: kde-frameworks-devel, bruns, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham

D12578: fix some issues reported by clazy

[Stefan Brüns]

bruns accepted this revision.
bruns added a comment.
This revision is now accepted and ready to land.


  No, worries, just wanted to make shure this does not stall 1 meter to the 
finish line ...

REPOSITORY
  R293 Baloo

BRANCH
  arcpatch-D12578

REVISION DETAIL
  https://phabricator.kde.org/D12578

To: mgallien, #baloo, #frameworks, bruns
Cc: kde-frameworks-devel, bruns, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham

D12578: fix some issues reported by clazy

[Matthieu Gallien]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:f887468b172a: fix some issues reported by clazy (authored 
by mgallien).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12578?vs=34389=34390

REVISION DETAIL
  https://phabricator.kde.org/D12578

AFFECTED FILES
  autotests/unit/file/pendingfilequeuetest.cpp
  src/engine/transaction.cpp
  src/file/fileindexerconfig.cpp
  src/file/fileindexscheduler.cpp
  src/file/firstrunindexer.cpp
  src/file/indexcleaner.cpp
  src/file/modifiedfileindexer.cpp
  src/file/newfileindexer.cpp
  src/file/xattrindexer.cpp
  src/kioslaves/kded/baloosearchmodule.cpp
  src/lib/query.cpp
  src/lib/searchstore.cpp
  src/lib/taglistjob.cpp
  src/lib/term.cpp

To: mgallien, #baloo, #frameworks, bruns
Cc: kde-frameworks-devel, bruns, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham

D12820: Add KWayland virtual desktop protocol

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> plasmavirtualdesktop_interface.cpp:36
> +
> +class PlasmaVirtualDesktopInterface::Private
> +{

class Q_DECL_HIDDEN PlasmaVirtualDesktopInterface::Private

Same for the server part.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D12820

To: mart, #kwin, #plasma, graesslin, hein
Cc: zzag, bshah, romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D11282: less expensive findByUrl in KCoreDirListerCache

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> mwolff wrote in kcoredirlister.cpp:2532
> this can be slow, see above

To make this more efficient, a little bit of reshuffling is needed IMHO:

1. Move the filter implementation from  `KDL::Private::addNewItem(...)` to 
`KDL::Private::addNewItems(...)`, i.e. sort the `items` based on 
`->matchesMimeFilter(item)` into two new QHashes
2. For each partition, use QHash::unite() to merge it into the respective list

3. Make `KDL::Private::addNewItem(...)` a wrapper function for 
`KDL::Private::addNewItems(...)`.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11282

To: jtamate, #frameworks, dfaure
Cc: kde-frameworks-devel, bruns, mwolff, michaelh, ngraham