D6513: Add support for Attica tags support

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 41131.
leinir marked 2 inline comments as done.
leinir added a comment.


  Address @dfaure's comments

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6513?vs=41034=41131

REVISION DETAIL
  https://phabricator.kde.org/D6513

AFFECTED FILES
  autotests/knewstuffentrytest.cpp
  src/attica/atticaprovider.cpp
  src/core/CMakeLists.txt
  src/core/engine.cpp
  src/core/engine.h
  src/core/entryinternal.cpp
  src/core/entryinternal.h
  src/core/provider.h
  src/core/tagsfilterchecker.cpp
  src/core/tagsfilterchecker.h
  src/staticxml/staticxmlprovider.cpp
  tests/CMakeLists.txt
  tests/khotnewstuff_test.cpp
  tests/khotnewstuff_test.knsrc.in
  tests/knewstuff2_test.cpp
  tests/knewstuff2_test.h
  tests/knewstuff2_test.knsrc
  tests/testdata/entry.xml
  tests/testdata/provider.xml

To: leinir, #knewstuff, apol, #kde_store, whiting, ahiemstra, mlaurent, dfaure, 
cfeck
Cc: dfaure, cfeck, mlaurent, ngraham, ahiemstra, kde-frameworks-devel, 
#knewstuff, michaelh, ZrenBot, bruns

D15283: Move SMB KCM to Network Settings category

[Kai Uwe Broulik]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:ace6f726eaf5: Move SMB KCM to Network Settings category 
(authored by broulik).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15283?vs=41022=41132

REVISION DETAIL
  https://phabricator.kde.org/D15283

AFFECTED FILES
  src/kcms/kio/smb.desktop

To: broulik, #frameworks, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D15070: Bindings: Query the install directory from python

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  In D15070#318496 , @bruns wrote:
  
  > And why isn't it up to the user to set GPB_PYTHON2_SITEARCH when installing 
out of the usual directories?
  
  
  Because we don't install things out of CMAKE_PREFIX_PATH unless asked 
explicitly. The logic has to be reversed...and the name changed: GPB_*_SITEARCH 
is fine as a internal name but noone will remember it when running CMake.
  
  Suggestion: 
  Do what the KDE_INSTALL_USE_QT_SYS_PATHS option does (OFF by default): If the 
option is set, the files are installed in the system dirs.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D15070

To: bruns, #frameworks
Cc: cgiboudeaux, bcooksley, kde-frameworks-devel, kde-buildsystem, michaelh, 
ngraham, bruns

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 217 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/217/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 07 Sep 2018 13:21:41 +
 Build duration:
4 min 6 sec and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(44/126)35%
(44/126)27%
(3599/13112)19%
(1821/9436)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(607/1113)29%
(313/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2217)7%
(96/1434)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)41%
(1420/3491)30%
(794/2633)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/135)0%
(0/12)src.plasma.private47%
(9/19)47%
(9/19)43%
(663/1542)30%
(301/1003)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)29%
(579/1976)18%
(312/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1096)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
   

D15337: Fix Solarized Light and Dark color schemes

[Andrew Crouthamel]

acrouthamel created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
acrouthamel requested review of this revision.

REVISION SUMMARY
  Solarized Light contrast was low. Upon investigation it was determined
  much of the color scheme did not follow Solarized base 16 colors or
  rules. Color scheme for both Dark and Light variants were adjusted to
  match the latest Solarized color scheme release palette and color
  interaction rules. Color schemes were also matched closely to the
  Vim color scheme created by the original Solarized author.

TEST PLAN
  Open Kate with new rc files and inspect the Color settings.

REPOSITORY
  R39 KTextEditor

BRANCH
  fix-solarized-colors

REVISION DETAIL
  https://phabricator.kde.org/D15337

AFFECTED FILES
  src/data/kateschemarc
  src/data/katesyntaxhighlightingrc

To: acrouthamel
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D15328: kfilewidget: convert connect syntax

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in kfilewidget.cpp:1225
>   QObject::disconnect(m_connEditTextChanged);
>   m_connEditTextChanged = QMetaObject::Connection();

Me neither ...

But me wonders if this should not use `{QSignalBlocker(locationEdit); ...}` 
instead.
Also, the comment above is slightly wrong, there is no `setCurrentItem()` below.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15328

To: jtamate, dfaure, #frameworks
Cc: bruns, anthonyfieroni, broulik, kde-frameworks-devel, michaelh, ngraham

D15337: Fix Solarized Light and Dark color schemes

[Andrew Crouthamel]

acrouthamel edited the summary of this revision.
acrouthamel edited the test plan for this revision.
acrouthamel added reviewers: Kate, KTextEditor, Framework: Syntax Highlighting.
acrouthamel added a project: KTextEditor.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D15337

To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, head7, cullmann, kfunk, sars, dhaumann

D15258: Remove random kio output

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:944f9b425842: Remove random kio output (authored by apol).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15258?vs=40948=41160

REVISION DETAIL
  https://phabricator.kde.org/D15258

AFFECTED FILES
  src/kioslave/kioslave.cpp

To: apol, #frameworks, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 215 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/215/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 07 Sep 2018 12:57:31 +
 Build duration:
3 min 10 sec and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(44/126)35%
(44/126)27%
(3599/13112)19%
(1821/9436)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(607/1113)29%
(313/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2217)7%
(96/1434)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)41%
(1420/3491)30%
(794/2633)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/135)0%
(0/12)src.plasma.private47%
(9/19)47%
(9/19)43%
(663/1542)30%
(301/1003)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)29%
(579/1976)18%
(312/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1096)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
  

D15330: [autotests] Compare booleans to booleans

[Vlad Zagorodniy]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:3c128a612c1f: [autotests] Compare booleans to booleans 
(authored by zzag).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15330?vs=41149=41152

REVISION DETAIL
  https://phabricator.kde.org/D15330

AFFECTED FILES
  autotests/client/test_datadevice.cpp

To: zzag, #kwin, romangg, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 55 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/55/
 Project:
Frameworks kwayland kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 07 Sep 2018 13:01:46 +
 Build duration:
4 min 49 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 45 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(234/254)92%
(234/254)87%
(24727/28366)54%
(9771/18261)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(41/41)100%
(41/41)99%
(11629/11698)50%
(6167/12251)autotests.server100%
(5/5)100%
(5/5)99%
(353/356)49%
(169/344)src.client99%
(71/72)99%
(71/72)85%
(5732/6771)65%
(1505/2322)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server100%
(115/115)100%
(115/115)87%
(6932/7966)66%
(1930/2931)src.tools0%
(0/2)0%
(0/2)0%
(0/693)0%
(0/272)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/69)0%
(0/10)tests0%
(0/14)0%
(0/14)0%
(0/732)0%
(0/131)

D15330: [autotests] Compare booleans to booleans

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  fix-build

REVISION DETAIL
  https://phabricator.kde.org/D15330

To: zzag, #kwin, romangg, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15328: kfilewidget: convert connect syntax

[Jaime Torres Amate]

jtamate updated this revision to Diff 41150.
jtamate marked an inline comment as done.
jtamate added a comment.


  Changed to 'Anonymous' connects and disconnects.
  
  Even if the documentation say: use 0 as a wildcard, the compiler thinks it 
should be a nullptr
  
  kfilewidget.cpp:1222:74: warning: zero as null pointer constant 
[-Wzero-as-null-pointer-constant]

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15328?vs=41148=41150

REVISION DETAIL
  https://phabricator.kde.org/D15328

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp
  src/filewidgets/kfilewidget.h

To: jtamate, dfaure, #frameworks
Cc: anthonyfieroni, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 216 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/216/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 07 Sep 2018 13:15:56 +
 Build duration:
4 min 0 sec and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(44/126)35%
(44/126)27%
(3599/13112)19%
(1821/9436)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(607/1113)29%
(313/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2217)7%
(96/1434)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)41%
(1420/3491)30%
(794/2633)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/135)0%
(0/12)src.plasma.private47%
(9/19)47%
(9/19)43%
(663/1542)30%
(301/1003)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)29%
(579/1976)18%
(312/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1096)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
   

KDE CI: Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.11 - Build # 6 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20WindowsMSVCQt5.11/6/
 Project:
Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Fri, 07 Sep 2018 08:20:10 +
 Build duration:
2 min 8 sec and counting
   CONSOLE OUTPUT
  [...truncated 228.59 KB...][ 78%] Building CXX object tests/CMakeFiles/khotnewstuff_upload.dir/khotnewstuff_upload_autogen/mocs_compilation.cpp.objkhotnewstuff.cppkhotnewstuff_upload.cpp[ 80%] Building CXX object tests/CMakeFiles/khotnewstuff_test.dir/khotnewstuff_test.cpp.obj[ 79%] Building CXX object tests/CMakeFiles/khotnewstuff.dir/__/src/knewstuff_debug.cpp.objkhotnewstuff_test.cppScanning dependencies of target kmoretoolstest2Scanning dependencies of target kmoretoolstest_interactiveScanning dependencies of target kmoretoolstest[ 81%] Building CXX object autotests/CMakeFiles/kmoretoolstest2.dir/kmoretools/kmoretoolstest2.cpp.objkmoretoolstest2.cpp[ 82%] Building CXX object tests/CMakeFiles/kmoretoolstest_interactive.dir/kmoretools/kmoretoolstest_interactive.cpp.objkmoretoolstest_interactive.cppknewstuffcore_debug.cpp[ 84%] Building CXX object tests/CMakeFiles/khotnewstuff.dir/__/src/core/knewstuffcore_debug.cpp.objc:\ci\workspace\frameworks knewstuff kf5-qt5 windowsmsvcqt5.11\tests\khotnewstuff_test.h(50): warning C4003: not enough actual parameters for macro 'QStringLiteral'c:\ci\workspace\frameworks knewstuff kf5-qt5 windowsmsvcqt5.11\tests\khotnewstuff_test.h(50): warning C4003: not enough actual parameters for macro 'QT_UNICODE_LITERAL'mocs_compilation.cppc:\ci\workspace\frameworks knewstuff kf5-qt5 windowsmsvcqt5.11\tests\khotnewstuff_test.h(50): warning C4003: not enough actual parameters for macro 'QT_UNICODE_LITERAL_II'knewstuff_debug.cpptagsfilterchecker.cppC:\CI\workspace\Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.11\src\core\tagsfilterchecker.cpp(124): warning C4273: 'KNSCore::TagsFilterChecker::TagsFilterChecker': inconsistent dll linkagec:\ci\workspace\frameworks knewstuff kf5-qt5 windowsmsvcqt5.11\src\core\tagsfilterchecker.h(64): note: see previous definition of '{ctor}'C:\CI\workspace\Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.11\src\core\tagsfilterchecker.cpp(132): warning C4273: 'KNSCore::TagsFilterChecker::~TagsFilterChecker': inconsistent dll linkagec:\ci\workspace\frameworks knewstuff kf5-qt5 windowsmsvcqt5.11\src\core\tagsfilterchecker.h(65): note: see previous definition of '{dtor}'C:\CI\workspace\Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.11\src\core\tagsfilterchecker.cpp(137): warning C4273: 'KNSCore::TagsFilterChecker::filterAccepts': inconsistent dll linkagec:\ci\workspace\frameworks knewstuff kf5-qt5 windowsmsvcqt5.11\src\core\tagsfilterchecker.h(74): note: see previous definition of 'filterAccepts'knewstuff_debug.cppknewstuffcore_debug.cpp[ 85%] Building CXX object tests/CMakeFiles/khotnewstuff_test.dir/__/src/knewstuff_debug.cpp.objstaticxmlprovider.cppC:\CI\workspace\Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.11\src\staticxml\staticxmlprovider.cpp(210): warning C4996: 'KNSCore::EntryInternal::setEntryXML': was declared deprecatedc:\ci\workspace\frameworks knewstuff kf5-qt5 windowsmsvcqt5.11\src\core\entryinternal.h(494): note: see declaration of 'KNSCore::EntryInternal::setEntryXML'[ 86%] Building CXX object autotests/CMakeFiles/kmoretoolstest2.dir/__/src/knewstuff_debug.cpp.obj[ 86%] Building CXX object tests/CMakeFiles/kmoretoolstest_interactive.dir/__/src/knewstuff_debug.cpp.obj[ 87%] Building CXX object tests/CMakeFiles/khotnewstuff.dir/__/src/core/tagsfilterchecker.cpp.obj[ 86%] Building CXX object tests/CMakeFiles/khotnewstuff_test.dir/__/src/core/knewstuffcore_debug.cpp.objC:\CI\workspace\Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.11\tests\khotnewstuff_test.cpp(41): fatal error C1083: Cannot open include file: 'unistd.h': No such file or directoryjom: C:\CI\workspace\Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.11\build\tests\CMakeFiles\khotnewstuff_test.dir\build.make [tests\CMakeFiles\khotnewstuff_test.dir\khotnewstuff_test.cpp.obj] Error 2knewstuff_debug.cppknewstuffcore_debug.cpp[ 87%] Building CXX object autotests/CMakeFiles/kmoretoolstest2.dir/kmoretoolstest2_autogen/mocs_compilation.cpp.obj[ 88%] Linking CXX executable ..\bin\khotnewstuff_upload.exemocs_compilation.cpp[ 89%] Building CXX object tests/CMakeFiles/kmoretoolstest_interactive.dir/kmoretoolstest_interactive_autogen/mocs_compilation.cpp.objmocs_compilation.cppLINK Pass 1: command "C:\PROGRA~2\MICROS~1\2017\PROFES~1\VC\Tools\MSVC\1414~1.264\bin\Hostx64\x64\link.exe /nologo @CMakeFiles\khotnewstuff_upload.dir\objects1.rsp /out:..\bin\khotnewstuff_upload.exe /implib:..\lib\khotnewstuff_upload.lib /pdb:C:\CI\workspace\Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.11\build\bin\khotnewstuff_upload.pdb /version:0.0 /machine:x64 /NODEFAULTLIB:libcmtd /DEFAULTLIB:msvcrtd /debug /INCREMENTAL /subsystem:windows ..\lib\KF5NewStuff.lib C:\Craft\CI-Qt511\windows-msvc2017_64-cl-debug\lib\Qt5Testd.lib 

KDE CI: Frameworks knewstuff kf5-qt5 SUSEQt5.9 - Build # 63 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20SUSEQt5.9/63/
 Project:
Frameworks knewstuff kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 07 Sep 2018 08:20:11 +
 Build duration:
1 min 44 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report38%
(5/13)17%
(11/63)17%
(11/63)15%
(903/5929)13%
(437/3463)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)100%
(81/81)53%
(38/72)autotests.kmoretools50%
(1/2)50%
(1/2)74%
(202/273)38%
(66/172)src22%
(2/9)22%
(2/9)2%
(22/956)0%
(0/364)src.attica0%
(0/2)0%
(0/2)0%
(0/298)0%
(0/229)src.core17%
(3/18)17%
(3/18)11%
(190/1800)11%
(146/1274)src.core.jobs0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/83)src.kmoretools60%
(3/5)60%
(3/5)52%
(408/791)36%
(187/526)src.qtquick0%
(0/5)0%
(0/5)0%
(0/276)0%
(0/104)src.staticxml0%
(0/1)0%
(0/1)0%
(0/169)0%
(0/148)src.ui0%
(0/8)0%
(0/8)0%
(0/745)0%
(0/317)src.upload0%
(0/1)0%
(0/1)0%
(0/121)0%
(0/80)tests0%
(0/3)0%
(0/3)0%
(0/133)0%
(0/72)tests.kmoretools0%
(0/1)0%
(0/1)0%
(0/101)0%
(0/22)

KDE CI: Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.11 - Build # 8 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20WindowsMSVCQt5.11/8/
 Project:
Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Fri, 07 Sep 2018 08:40:46 +
 Build duration:
5 min 6 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.kmoretoolstest

D6513: Add support for Attica tags support

[David Faure]

dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> leinir wrote in tagsfilterchecker.cpp:103
> Scott Meyers' book? (might need to grab a copy of that, then :) )

Yes.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D6513

To: leinir, #knewstuff, apol, #kde_store, whiting, ahiemstra, mlaurent, dfaure, 
cfeck
Cc: dfaure, cfeck, mlaurent, ngraham, ahiemstra, kde-frameworks-devel, 
#knewstuff, michaelh, ZrenBot, bruns

KDE CI: Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.11 - Build # 4 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20WindowsMSVCQt5.11/4/
 Project:
Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Fri, 07 Sep 2018 07:51:55 +
 Build duration:
1 min 47 sec and counting
   CONSOLE OUTPUT
  [...truncated 224.86 KB...]Scanning dependencies of target khotnewstuffScanning dependencies of target khotnewstuff_uploadScanning dependencies of target khotnewstuff_test[ 73%] Building CXX object tests/CMakeFiles/khotnewstuff.dir/khotnewstuff.cpp.obj[ 74%] Building CXX object tests/CMakeFiles/khotnewstuff.dir/__/src/knewstuff_debug.cpp.obj[ 75%] Building CXX object tests/CMakeFiles/khotnewstuff_upload.dir/khotnewstuff_upload.cpp.obj[ 76%] Building CXX object tests/CMakeFiles/khotnewstuff.dir/__/src/core/knewstuffcore_debug.cpp.obj[ 79%] Building CXX object tests/CMakeFiles/khotnewstuff_upload.dir/__/src/knewstuff_debug.cpp.obj[ 79%] Building CXX object tests/CMakeFiles/khotnewstuff.dir/__/src/staticxml/staticxmlprovider.cpp.obj[ 79%] Building CXX object tests/CMakeFiles/khotnewstuff.dir/__/src/core/tagsfilterchecker.cpp.obj[ 80%] Building CXX object tests/CMakeFiles/khotnewstuff_upload.dir/__/src/core/knewstuffcore_debug.cpp.obj[ 81%] Building CXX object tests/CMakeFiles/khotnewstuff_test.dir/khotnewstuff_test.cpp.objkhotnewstuff_upload.cppkhotnewstuff.cppkhotnewstuff_test.cppC:\CI\workspace\Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.11\tests\khotnewstuff_test.cpp(20): fatal error C1083: Cannot open include file: 'khotnewstuff_test.h': No such file or directoryjom: C:\CI\workspace\Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.11\build\tests\CMakeFiles\khotnewstuff_test.dir\build.make [tests\CMakeFiles\khotnewstuff_test.dir\khotnewstuff_test.cpp.obj] Error 2[ 82%] Building CXX object tests/CMakeFiles/khotnewstuff_upload.dir/__/src/core/tagsfilterchecker.cpp.objScanning dependencies of target kmoretoolstest_interactiveScanning dependencies of target kmoretoolstest2Scanning dependencies of target kmoretoolstest[ 83%] Building CXX object tests/CMakeFiles/kmoretoolstest_interactive.dir/kmoretools/kmoretoolstest_interactive.cpp.obj[ 84%] Building CXX object autotests/CMakeFiles/kmoretoolstest2.dir/kmoretools/kmoretoolstest2.cpp.objkmoretoolstest_interactive.cppkmoretoolstest2.cppknewstuffcore_debug.cpp[ 85%] Building CXX object tests/CMakeFiles/khotnewstuff.dir/khotnewstuff_autogen/mocs_compilation.cpp.objknewstuffcore_debug.cppjom: C:\CI\workspace\Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.11\build\CMakeFiles\Makefile2 [tests\CMakeFiles\khotnewstuff_test.dir\all] Error 2[ 85%] Building CXX object autotests/CMakeFiles/kmoretoolstest.dir/kmoretools/kmoretoolstest.cpp.objkmoretoolstest.cpptagsfilterchecker.cppC:\CI\workspace\Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.11\src\core\tagsfilterchecker.cpp(124): warning C4273: 'KNSCore::TagsFilterChecker::TagsFilterChecker': inconsistent dll linkagec:\ci\workspace\frameworks knewstuff kf5-qt5 windowsmsvcqt5.11\src\core\tagsfilterchecker.h(64): note: see previous definition of '{ctor}'C:\CI\workspace\Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.11\src\core\tagsfilterchecker.cpp(132): warning C4273: 'KNSCore::TagsFilterChecker::~TagsFilterChecker': inconsistent dll linkagec:\ci\workspace\frameworks knewstuff kf5-qt5 windowsmsvcqt5.11\src\core\tagsfilterchecker.h(65): note: see previous definition of '{dtor}'C:\CI\workspace\Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.11\src\core\tagsfilterchecker.cpp(137): warning C4273: 'KNSCore::TagsFilterChecker::filterAccepts': inconsistent dll linkagec:\ci\workspace\frameworks knewstuff kf5-qt5 windowsmsvcqt5.11\src\core\tagsfilterchecker.h(74): note: see previous definition of 'filterAccepts'knewstuff_debug.cppknewstuff_debug.cpp[ 85%] Building CXX object tests/CMakeFiles/khotnewstuff_upload.dir/__/src/staticxml/staticxmlprovider.cpp.obj[ 85%] Building CXX object tests/CMakeFiles/kmoretoolstest_interactive.dir/__/src/knewstuff_debug.cpp.obj[ 86%] Building CXX object autotests/CMakeFiles/kmoretoolstest2.dir/__/src/knewstuff_debug.cpp.obj[ 86%] Building CXX object autotests/CMakeFiles/kmoretoolstest.dir/__/src/knewstuff_debug.cpp.obj[ 87%] Building CXX object tests/CMakeFiles/khotnewstuff_upload.dir/khotnewstuff_upload_autogen/mocs_compilation.cpp.objtagsfilterchecker.cppC:\CI\workspace\Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.11\src\core\tagsfilterchecker.cpp(124): warning C4273: 'KNSCore::TagsFilterChecker::TagsFilterChecker': inconsistent dll linkagec:\ci\workspace\frameworks knewstuff kf5-qt5 windowsmsvcqt5.11\src\core\tagsfilterchecker.h(64): note: see previous definition of '{ctor}'C:\CI\workspace\Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.11\src\core\tagsfilterchecker.cpp(132): warning C4273: 'KNSCore::TagsFilterChecker::~TagsFilterChecker': inconsistent dll linkagec:\ci\workspace\frameworks knewstuff kf5-qt5 windowsmsvcqt5.11\src\core\tagsfilterchecker.h(65): note: see previous definition of 

KDE CI: Frameworks knewstuff kf5-qt5 FreeBSDQt5.11 - Build # 4 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20FreeBSDQt5.11/4/
 Project:
Frameworks knewstuff kf5-qt5 FreeBSDQt5.11
 Date of build:
Fri, 07 Sep 2018 07:51:55 +
 Build duration:
1 min 37 sec and counting
   CONSOLE OUTPUT
  [...truncated 177.22 KB...][ 63%] Building CXX object src/CMakeFiles/KF5NewStuff.dir/ui/itemsviewbasedelegate.cpp.o[ 64%] Building CXX object src/CMakeFiles/KF5NewStuff.dir/ui/progressindicator.cpp.o[ 64%] Building CXX object src/CMakeFiles/KF5NewStuff.dir/ui/widgetquestionlistener.cpp.o[ 65%] Building CXX object src/CMakeFiles/KF5NewStuff.dir/uploaddialog.cpp.o[ 66%] Building CXX object src/CMakeFiles/KF5NewStuff.dir/knewstuff_debug.cpp.o[ 67%] Building CXX object src/CMakeFiles/KF5NewStuff.dir/KF5NewStuff_autogen/mocs_compilation.cpp.o[ 68%] Linking CXX shared library ../bin/libKF5NewStuff.so[ 68%] Built target KF5NewStuffScanning dependencies of target kmoretoolstest_interactive_autogenScanning dependencies of target khotnewstuff_upload_autogenScanning dependencies of target kmoretoolstest_autogenScanning dependencies of target kmoretoolstest2_autogen[ 71%] Automatic MOC for target kmoretoolstest_interactive[ 71%] Automatic MOC for target kmoretoolstest[ 71%] Automatic MOC for target khotnewstuff_upload[ 72%] Automatic MOC for target kmoretoolstest2[ 72%] Built target khotnewstuff_upload_autogenScanning dependencies of target khotnewstuff_test_autogen[ 72%] Automatic MOC for target khotnewstuff_test[ 72%] Built target kmoretoolstest2_autogen[ 72%] Built target kmoretoolstest_interactive_autogen[ 72%] Built target kmoretoolstest_autogenScanning dependencies of target khotnewstuff_autogen[ 73%] Automatic MOC for target khotnewstuff[ 73%] Built target khotnewstuff_test_autogenScanning dependencies of target kmoretoolstest2Scanning dependencies of target kmoretoolstest[ 75%] Building CXX object autotests/CMakeFiles/kmoretoolstest2.dir/kmoretools/kmoretoolstest2.cpp.o[ 75%] Building CXX object autotests/CMakeFiles/kmoretoolstest.dir/kmoretools/kmoretoolstest.cpp.oScanning dependencies of target khotnewstuff_upload[ 76%] Building CXX object tests/CMakeFiles/khotnewstuff_upload.dir/khotnewstuff_upload.cpp.o[ 76%] Built target khotnewstuff_autogen[ 77%] Building CXX object tests/CMakeFiles/khotnewstuff_upload.dir/__/src/knewstuff_debug.cpp.o[ 77%] Building CXX object autotests/CMakeFiles/kmoretoolstest.dir/__/src/knewstuff_debug.cpp.o[ 78%] Building CXX object tests/CMakeFiles/khotnewstuff_upload.dir/__/src/core/knewstuffcore_debug.cpp.o[ 79%] Building CXX object autotests/CMakeFiles/kmoretoolstest2.dir/__/src/knewstuff_debug.cpp.o[ 79%] Building CXX object autotests/CMakeFiles/kmoretoolstest2.dir/kmoretoolstest2_autogen/mocs_compilation.cpp.o[ 80%] Building CXX object autotests/CMakeFiles/kmoretoolstest.dir/kmoretoolstest_autogen/mocs_compilation.cpp.o[ 81%] Building CXX object tests/CMakeFiles/khotnewstuff_upload.dir/__/src/core/tagsfilterchecker.cpp.o[ 82%] Linking CXX executable ../bin/kmoretoolstest[ 82%] Building CXX object tests/CMakeFiles/khotnewstuff_upload.dir/__/src/staticxml/staticxmlprovider.cpp.o[ 83%] Linking CXX executable ../bin/kmoretoolstest2[ 83%] Built target kmoretoolstest[ 84%] Building CXX object tests/CMakeFiles/khotnewstuff_upload.dir/khotnewstuff_upload_autogen/mocs_compilation.cpp.oScanning dependencies of target kmoretoolstest_interactive[ 85%] Building CXX object tests/CMakeFiles/kmoretoolstest_interactive.dir/kmoretools/kmoretoolstest_interactive.cpp.o/usr/home/jenkins/workspace/Frameworks knewstuff kf5-qt5 FreeBSDQt5.11/src/staticxml/staticxmlprovider.cpp:210:15: warning: 'setEntryXML' is deprecated [-Wdeprecated-declarations]entry.setEntryXML(n.toElement());  ^/usr/home/jenkins/workspace/Frameworks knewstuff kf5-qt5 FreeBSDQt5.11/src/core/entryinternal.h:494:5: note: 'setEntryXML' has been explicitly marked deprecated hereKNEWSTUFFCORE_DEPRECATED bool setEntryXML(const QDomElement );^/usr/home/jenkins/workspace/Frameworks knewstuff kf5-qt5 FreeBSDQt5.11/build/src/core/knewstuffcore_export.h:25:52: note: expanded from macro 'KNEWSTUFFCORE_DEPRECATED'#  define KNEWSTUFFCORE_DEPRECATED __attribute__ ((__deprecated__))   ^[ 85%] Built target kmoretoolstest21 warning generated.Scanning dependencies of target khotnewstuff_test[ 86%] Building CXX object tests/CMakeFiles/khotnewstuff_test.dir/khotnewstuff_test.cpp.o/usr/home/jenkins/workspace/Frameworks knewstuff kf5-qt5 FreeBSDQt5.11/tests/khotnewstuff_test.cpp:20:10: fatal error: 'khotnewstuff_test.h' file not found#include "khotnewstuff_test.h" ^Scanning dependencies of target khotnewstuff[ 86%] Building CXX object tests/CMakeFiles/khotnewstuff.dir/khotnewstuff.cpp.o[ 87%] Linking CXX executable ../bin/khotnewstuff_upload1 error generated.gmake[2]: *** [tests/CMakeFiles/khotnewstuff_test.dir/build.make:63: 

KDE CI: Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.11 - Build # 5 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20WindowsMSVCQt5.11/5/
 Project:
Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Fri, 07 Sep 2018 08:00:26 +
 Build duration:
4 min 32 sec and counting
   CONSOLE OUTPUT
  [...truncated 227.00 KB...][ 76%] Building CXX object tests/CMakeFiles/khotnewstuff_upload.dir/__/src/core/tagsfilterchecker.cpp.obj[ 78%] Building CXX object tests/CMakeFiles/khotnewstuff_upload.dir/__/src/core/knewstuffcore_debug.cpp.obj[ 80%] Building CXX object tests/CMakeFiles/khotnewstuff.dir/__/src/core/knewstuffcore_debug.cpp.obj[ 80%] Building CXX object tests/CMakeFiles/khotnewstuff.dir/khotnewstuff.cpp.objScanning dependencies of target khotnewstuff_test[ 79%] Building CXX object tests/CMakeFiles/khotnewstuff.dir/__/src/core/tagsfilterchecker.cpp.objkhotnewstuff_upload.cppkhotnewstuff.cpp[ 81%] Building CXX object tests/CMakeFiles/khotnewstuff_test.dir/khotnewstuff_test.cpp.objScanning dependencies of target kmoretoolstest2Scanning dependencies of target kmoretoolstestkhotnewstuff_test.cppScanning dependencies of target kmoretoolstest_interactive[ 84%] Building CXX object autotests/CMakeFiles/kmoretoolstest2.dir/kmoretools/kmoretoolstest2.cpp.obj[ 82%] Building CXX object autotests/CMakeFiles/kmoretoolstest.dir/kmoretools/kmoretoolstest.cpp.objkmoretoolstest2.cppkmoretoolstest.cppknewstuffcore_debug.cppknewstuff_debug.cppknewstuffcore_debug.cpp[ 86%] Building CXX object tests/CMakeFiles/khotnewstuff_test.dir/__/src/knewstuff_debug.cpp.obj[ 84%] Building CXX object tests/CMakeFiles/khotnewstuff_upload.dir/__/src/staticxml/staticxmlprovider.cpp.objtagsfilterchecker.cppC:\CI\workspace\Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.11\src\core\tagsfilterchecker.cpp(124): warning C4273: 'KNSCore::TagsFilterChecker::TagsFilterChecker': inconsistent dll linkagec:\ci\workspace\frameworks knewstuff kf5-qt5 windowsmsvcqt5.11\src\core\tagsfilterchecker.h(64): note: see previous definition of '{ctor}'C:\CI\workspace\Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.11\src\core\tagsfilterchecker.cpp(132): warning C4273: 'KNSCore::TagsFilterChecker::~TagsFilterChecker': inconsistent dll linkagec:\ci\workspace\frameworks knewstuff kf5-qt5 windowsmsvcqt5.11\src\core\tagsfilterchecker.h(65): note: see previous definition of '{dtor}'C:\CI\workspace\Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.11\src\core\tagsfilterchecker.cpp(137): warning C4273: 'KNSCore::TagsFilterChecker::filterAccepts': inconsistent dll linkagec:\ci\workspace\frameworks knewstuff kf5-qt5 windowsmsvcqt5.11\src\core\tagsfilterchecker.h(74): note: see previous definition of 'filterAccepts'[ 85%] Building CXX object tests/CMakeFiles/khotnewstuff.dir/__/src/staticxml/staticxmlprovider.cpp.objc:\ci\workspace\frameworks knewstuff kf5-qt5 windowsmsvcqt5.11\tests\khotnewstuff_test.h(50): warning C4003: not enough actual parameters for macro 'QStringLiteral'c:\ci\workspace\frameworks knewstuff kf5-qt5 windowsmsvcqt5.11\tests\khotnewstuff_test.h(50): warning C4003: not enough actual parameters for macro 'QT_UNICODE_LITERAL'c:\ci\workspace\frameworks knewstuff kf5-qt5 windowsmsvcqt5.11\tests\khotnewstuff_test.h(50): warning C4003: not enough actual parameters for macro 'QT_UNICODE_LITERAL_II'[ 86%] Building CXX object autotests/CMakeFiles/kmoretoolstest.dir/__/src/knewstuff_debug.cpp.objknewstuff_debug.cpptagsfilterchecker.cppC:\CI\workspace\Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.11\src\core\tagsfilterchecker.cpp(124): warning C4273: 'KNSCore::TagsFilterChecker::TagsFilterChecker': inconsistent dll linkagec:\ci\workspace\frameworks knewstuff kf5-qt5 windowsmsvcqt5.11\src\core\tagsfilterchecker.h(64): note: see previous definition of '{ctor}'C:\CI\workspace\Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.11\src\core\tagsfilterchecker.cpp(132): warning C4273: 'KNSCore::TagsFilterChecker::~TagsFilterChecker': inconsistent dll linkagec:\ci\workspace\frameworks knewstuff kf5-qt5 windowsmsvcqt5.11\src\core\tagsfilterchecker.h(65): note: see previous definition of '{dtor}'C:\CI\workspace\Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.11\src\core\tagsfilterchecker.cpp(137): warning C4273: 'KNSCore::TagsFilterChecker::filterAccepts': inconsistent dll linkagec:\ci\workspace\frameworks knewstuff kf5-qt5 windowsmsvcqt5.11\src\core\tagsfilterchecker.h(74): note: see previous definition of 'filterAccepts'staticxmlprovider.cppC:\CI\workspace\Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.11\tests\khotnewstuff_test.cpp(41): fatal error C1083: Cannot open include file: 'unistd.h': No such file or directoryjom: C:\CI\workspace\Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.11\build\tests\CMakeFiles\khotnewstuff_test.dir\build.make [tests\CMakeFiles\khotnewstuff_test.dir\khotnewstuff_test.cpp.obj] Error 2knewstuff_debug.cpp[ 87%] Building CXX object autotests/CMakeFiles/kmoretoolstest2.dir/__/src/knewstuff_debug.cpp.objstaticxmlprovider.cpp[ 88%] Building CXX object 

KDE CI: Frameworks knewstuff kf5-qt5 SUSEQt5.10 - Build # 103 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20SUSEQt5.10/103/
 Project:
Frameworks knewstuff kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 07 Sep 2018 08:00:26 +
 Build duration:
3 min 27 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report38%
(5/13)17%
(11/63)17%
(11/63)15%
(903/5929)13%
(436/3461)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)100%
(81/81)53%
(38/72)autotests.kmoretools50%
(1/2)50%
(1/2)74%
(202/273)38%
(66/172)src22%
(2/9)22%
(2/9)2%
(22/956)0%
(0/364)src.attica0%
(0/2)0%
(0/2)0%
(0/298)0%
(0/229)src.core17%
(3/18)17%
(3/18)11%
(190/1800)11%
(145/1272)src.core.jobs0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/83)src.kmoretools60%
(3/5)60%
(3/5)52%
(408/791)36%
(187/526)src.qtquick0%
(0/5)0%
(0/5)0%
(0/276)0%
(0/104)src.staticxml0%
(0/1)0%
(0/1)0%
(0/169)0%
(0/148)src.ui0%
(0/8)0%
(0/8)0%
(0/745)0%
(0/317)src.upload0%
(0/1)0%
(0/1)0%
(0/121)0%
(0/80)tests0%
(0/3)0%
(0/3)0%
(0/133)0%
(0/72)tests.kmoretools0%
(0/1)0%
(0/1)0%
(0/101)0%
(0/22)

D6513: Add support for Attica tags support

[Dan Leinir Turthra Jensen]

leinir added inline comments.

INLINE COMMENTS

> dfaure wrote in tagsfilterchecker.cpp:103
> Yes.

Great, thank you :) Yeah, going to have to nab a copy of that for a readthrough 
:)

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D6513

To: leinir, #knewstuff, apol, #kde_store, whiting, ahiemstra, mlaurent, dfaure, 
cfeck
Cc: dfaure, cfeck, mlaurent, ngraham, ahiemstra, kde-frameworks-devel, 
#knewstuff, michaelh, ZrenBot, bruns

KDE CI: Frameworks knewstuff kf5-qt5 SUSEQt5.9 - Build # 61 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20SUSEQt5.9/61/
 Project:
Frameworks knewstuff kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 07 Sep 2018 07:51:55 +
 Build duration:
49 sec and counting
   CONSOLE OUTPUT
  [...truncated 129.32 KB...]/home/jenkins/workspace/Frameworks knewstuff kf5-qt5 SUSEQt5.9/src/core/entryinternal.cpp: In member function ���bool KNSCore::EntryInternal::setEntryXML(QXmlStreamReader&)���:/home/jenkins/workspace/Frameworks knewstuff kf5-qt5 SUSEQt5.9/src/core/entryinternal.cpp:567:151: error: no matching function for call to ���QString::arg(QStringRef)��� Q_ASSERT_X(reader.tokenType() == QXmlStreamReader::EndElement, Q_FUNC_INFO, QString("token name was %1 and the type was %2").arg(reader.name()).arg(reader.tokenString()).toLocal8Bit().data());   ^In file included from /usr/include/qt5/QtCore/qdatetime.h:44, from /usr/include/qt5/QtCore/QDate:1, from /home/jenkins/workspace/Frameworks knewstuff kf5-qt5 SUSEQt5.9/src/core/entryinternal.h:25, from /home/jenkins/workspace/Frameworks knewstuff kf5-qt5 SUSEQt5.9/src/core/entryinternal.cpp:21:/usr/include/qt5/QtCore/qstring.h:264:31: note: candidate: ���QString QString::arg(qlonglong, int, int, QChar) const��� Q_REQUIRED_RESULT QString arg(qlonglong a, int fieldwidth=0, int base=10,   ^~~/usr/include/qt5/QtCore/qstring.h:264:31: note:   no known conversion for argument 1 from ���QStringRef��� to ���qlonglong��� {aka ���long long int���}/usr/include/qt5/QtCore/qstring.h:266:31: note: candidate: ���QString QString::arg(qulonglong, int, int, QChar) const��� Q_REQUIRED_RESULT QString arg(qulonglong a, int fieldwidth=0, int base=10,   ^~~/usr/include/qt5/QtCore/qstring.h:266:31: note:   no known conversion for argument 1 from ���QStringRef��� to ���qulonglong��� {aka ���long long unsigned int���}/usr/include/qt5/QtCore/qstring.h:928:16: note: candidate: ���QString QString::arg(long int, int, int, QChar) const��� inline QString QString::arg(long a, int fieldWidth, int base, QChar fillChar) const^~~/usr/include/qt5/QtCore/qstring.h:928:16: note:   no known conversion for argument 1 from ���QStringRef��� to ���long int���/usr/include/qt5/QtCore/qstring.h:930:16: note: candidate: ���QString QString::arg(ulong, int, int, QChar) const��� inline QString QString::arg(ulong a, int fieldWidth, int base, QChar fillChar) const^~~/usr/include/qt5/QtCore/qstring.h:930:16: note:   no known conversion for argument 1 from ���QStringRef��� to ���ulong��� {aka ���long unsigned int���}/usr/include/qt5/QtCore/qstring.h:924:16: note: candidate: ���QString QString::arg(int, int, int, QChar) const��� inline QString QString::arg(int a, int fieldWidth, int base, QChar fillChar) const^~~/usr/include/qt5/QtCore/qstring.h:924:16: note:   no known conversion for argument 1 from ���QStringRef��� to ���int���/usr/include/qt5/QtCore/qstring.h:926:16: note: candidate: ���QString QString::arg(uint, int, int, QChar) const��� inline QString QString::arg(uint a, int fieldWidth, int base, QChar fillChar) const^~~/usr/include/qt5/QtCore/qstring.h:926:16: note:   no known conversion for argument 1 from ���QStringRef��� to ���uint��� {aka ���unsigned int���}/usr/include/qt5/QtCore/qstring.h:932:16: note: candidate: ���QString QString::arg(short int, int, int, QChar) const��� inline QString QString::arg(short a, int fieldWidth, int base, QChar fillChar) const^~~/usr/include/qt5/QtCore/qstring.h:932:16: note:   no known conversion for argument 1 from ���QStringRef��� to ���short int���/usr/include/qt5/QtCore/qstring.h:934:16: note: candidate: ���QString QString::arg(ushort, int, int, QChar) const��� inline QString QString::arg(ushort a, int fieldWidth, int base, QChar fillChar) const^~~/usr/include/qt5/QtCore/qstring.h:934:16: note:   no known conversion for argument 1 from ���QStringRef��� to ���ushort��� {aka ���short unsigned int���}/usr/include/qt5/QtCore/qstring.h:280:31: note: candidate: ���QString QString::arg(double, int, char, int, QChar) const��� Q_REQUIRED_RESULT QString arg(double a, int fieldWidth = 0, char fmt = 'g', int prec = -1,   ^~~/usr/include/qt5/QtCore/qstring.h:280:31: note:   no known conversion for argument 1 from ���QStringRef��� to ���double���/usr/include/qt5/QtCore/qstring.h:282:31: note: candidate: ���QString QString::arg(char, int, QChar) const��� Q_REQUIRED_RESULT QString arg(char a, int fieldWidth = 0,   ^~~/usr/include/qt5/QtCore/qstring.h:282:31: note:   no known conversion for argument 1 from ���QStringRef��� to 

KDE CI: Frameworks knewstuff kf5-qt5 SUSEQt5.10 - Build # 102 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20SUSEQt5.10/102/
 Project:
Frameworks knewstuff kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 07 Sep 2018 07:51:56 +
 Build duration:
1 min 2 sec and counting
   CONSOLE OUTPUT
  [...truncated 192.06 KB...][ 59%] Linking CXX executable ../bin/knewstuffentrytest[ 60%] Building CXX object src/CMakeFiles/KF5NewStuff.dir/ui/imagepreviewwidget.cpp.o[ 60%] Building CXX object src/CMakeFiles/KF5NewStuff.dir/ui/itemsview.cpp.o[ 61%] Building CXX object src/CMakeFiles/KF5NewStuff.dir/ui/itemsviewdelegate.cpp.o[ 61%] Built target knewstuffentrytest[ 62%] Building CXX object src/CMakeFiles/KF5NewStuff.dir/ui/itemsgridviewdelegate.cpp.o[ 63%] Building CXX object src/CMakeFiles/KF5NewStuff.dir/ui/itemsviewbasedelegate.cpp.o[ 64%] Building CXX object src/CMakeFiles/KF5NewStuff.dir/ui/progressindicator.cpp.o[ 64%] Building CXX object src/CMakeFiles/KF5NewStuff.dir/ui/widgetquestionlistener.cpp.o[ 65%] Building CXX object src/CMakeFiles/KF5NewStuff.dir/uploaddialog.cpp.o[ 66%] Building CXX object src/CMakeFiles/KF5NewStuff.dir/knewstuff_debug.cpp.o[ 67%] Building CXX object src/CMakeFiles/KF5NewStuff.dir/KF5NewStuff_autogen/mocs_compilation.cpp.o[ 68%] Linking CXX shared library ../bin/libKF5NewStuff.so[ 68%] Built target KF5NewStuffScanning dependencies of target khotnewstuff_upload_autogenScanning dependencies of target kmoretoolstest2_autogenScanning dependencies of target kmoretoolstest_autogenScanning dependencies of target kmoretoolstest_interactive_autogenScanning dependencies of target khotnewstuff_test_autogenScanning dependencies of target khotnewstuff_autogen[ 70%] Automatic MOC for target kmoretoolstest[ 70%] Automatic MOC for target kmoretoolstest2[ 71%] Automatic MOC for target khotnewstuff_upload[ 72%] Automatic MOC for target kmoretoolstest_interactive[ 72%] Automatic MOC for target khotnewstuff_test[ 73%] Automatic MOC for target khotnewstuff[ 73%] Built target khotnewstuff_upload_autogen[ 73%] Built target khotnewstuff_autogen[ 73%] Built target kmoretoolstest_interactive_autogen[ 73%] Built target khotnewstuff_test_autogen[ 73%] Built target kmoretoolstest2_autogenScanning dependencies of target khotnewstuff_upload[ 73%] Built target kmoretoolstest_autogenScanning dependencies of target khotnewstuffScanning dependencies of target kmoretoolstest_interactive[ 73%] Building CXX object tests/CMakeFiles/khotnewstuff_upload.dir/__/src/staticxml/staticxmlprovider.cpp.o[ 74%] Building CXX object tests/CMakeFiles/khotnewstuff_upload.dir/__/src/knewstuff_debug.cpp.o[ 75%] Building CXX object tests/CMakeFiles/khotnewstuff_upload.dir/khotnewstuff_upload.cpp.o[ 76%] Building CXX object tests/CMakeFiles/khotnewstuff_upload.dir/__/src/core/tagsfilterchecker.cpp.o[ 77%] Building CXX object tests/CMakeFiles/khotnewstuff_upload.dir/__/src/core/knewstuffcore_debug.cpp.oScanning dependencies of target kmoretoolstest2Scanning dependencies of target khotnewstuff_test[ 77%] Building CXX object tests/CMakeFiles/khotnewstuff.dir/khotnewstuff.cpp.o[ 78%] Building CXX object tests/CMakeFiles/kmoretoolstest_interactive.dir/kmoretools/kmoretoolstest_interactive.cpp.o[ 79%] Building CXX object autotests/CMakeFiles/kmoretoolstest2.dir/kmoretools/kmoretoolstest2.cpp.o[ 80%] Building CXX object tests/CMakeFiles/khotnewstuff_test.dir/khotnewstuff_test.cpp.o/home/jenkins/workspace/Frameworks knewstuff kf5-qt5 SUSEQt5.10/tests/khotnewstuff_test.cpp:20:10: fatal error: khotnewstuff_test.h: No such file or directory #include "khotnewstuff_test.h"  ^compilation terminated.make[2]: *** [tests/CMakeFiles/khotnewstuff_test.dir/build.make:63: tests/CMakeFiles/khotnewstuff_test.dir/khotnewstuff_test.cpp.o] Error 1make[1]: *** [CMakeFiles/Makefile2:884: tests/CMakeFiles/khotnewstuff_test.dir/all] Error 2make[1]: *** Waiting for unfinished jobs[ 80%] Building CXX object tests/CMakeFiles/kmoretoolstest_interactive.dir/__/src/knewstuff_debug.cpp.o/home/jenkins/workspace/Frameworks knewstuff kf5-qt5 SUSEQt5.10/src/staticxml/staticxmlprovider.cpp: In member function ���void KNSCore::StaticXmlProvider::slotFeedFileLoaded(const QDomDocument&)���:/home/jenkins/workspace/Frameworks knewstuff kf5-qt5 SUSEQt5.10/src/staticxml/staticxmlprovider.cpp:210:40: warning: ���bool KNSCore::EntryInternal::setEntryXML(const QDomElement&)��� is deprecated [-Wdeprecated-declarations] entry.setEntryXML(n.toElement());^In file included from /home/jenkins/workspace/Frameworks knewstuff kf5-qt5 SUSEQt5.10/src/core/provider.h:27, from /home/jenkins/workspace/Frameworks knewstuff kf5-qt5 SUSEQt5.10/src/staticxml/staticxmlprovider_p.h:23, from /home/jenkins/workspace/Frameworks knewstuff kf5-qt5 SUSEQt5.10/src/staticxml/staticxmlprovider.cpp:22:/home/jenkins/workspace/Frameworks knewstuff kf5-qt5 SUSEQt5.10/src/core/entryinternal.h:494:35: note: 

D6513: Add support for Attica tags support

[Dan Leinir Turthra Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R304:2ad3e66d81b6: Add support for Attica tags support 
(authored by leinir).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6513?vs=41131=41133

REVISION DETAIL
  https://phabricator.kde.org/D6513

AFFECTED FILES
  autotests/knewstuffentrytest.cpp
  src/attica/atticaprovider.cpp
  src/core/CMakeLists.txt
  src/core/engine.cpp
  src/core/engine.h
  src/core/entryinternal.cpp
  src/core/entryinternal.h
  src/core/provider.h
  src/core/tagsfilterchecker.cpp
  src/core/tagsfilterchecker.h
  src/staticxml/staticxmlprovider.cpp
  tests/CMakeLists.txt
  tests/khotnewstuff_test.cpp
  tests/khotnewstuff_test.knsrc.in
  tests/knewstuff2_test.cpp
  tests/knewstuff2_test.h
  tests/knewstuff2_test.knsrc
  tests/testdata/entry.xml
  tests/testdata/provider.xml

To: leinir, #knewstuff, apol, #kde_store, whiting, ahiemstra, mlaurent, dfaure, 
cfeck
Cc: dfaure, cfeck, mlaurent, ngraham, ahiemstra, kde-frameworks-devel, 
#knewstuff, michaelh, ZrenBot, bruns

KDE CI: Frameworks knewstuff kf5-qt5 SUSEQt5.9 - Build # 62 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20SUSEQt5.9/62/
 Project:
Frameworks knewstuff kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 07 Sep 2018 08:00:26 +
 Build duration:
47 sec and counting
   CONSOLE OUTPUT
  [...truncated 130.19 KB...]/home/jenkins/workspace/Frameworks knewstuff kf5-qt5 SUSEQt5.9/src/core/entryinternal.cpp:567:151: error: no matching function for call to ���QString::arg(QStringRef)��� Q_ASSERT_X(reader.tokenType() == QXmlStreamReader::EndElement, Q_FUNC_INFO, QString("token name was %1 and the type was %2").arg(reader.name()).arg(reader.tokenString()).toLocal8Bit().data());   ^In file included from /usr/include/qt5/QtCore/qdatetime.h:44, from /usr/include/qt5/QtCore/QDate:1, from /home/jenkins/workspace/Frameworks knewstuff kf5-qt5 SUSEQt5.9/src/core/entryinternal.h:25, from /home/jenkins/workspace/Frameworks knewstuff kf5-qt5 SUSEQt5.9/src/core/entryinternal.cpp:21:/usr/include/qt5/QtCore/qstring.h:264:31: note: candidate: ���QString QString::arg(qlonglong, int, int, QChar) const��� Q_REQUIRED_RESULT QString arg(qlonglong a, int fieldwidth=0, int base=10,   ^~~/usr/include/qt5/QtCore/qstring.h:264:31: note:   no known conversion for argument 1 from ���QStringRef��� to ���qlonglong��� {aka ���long long int���}/usr/include/qt5/QtCore/qstring.h:266:31: note: candidate: ���QString QString::arg(qulonglong, int, int, QChar) const��� Q_REQUIRED_RESULT QString arg(qulonglong a, int fieldwidth=0, int base=10,   ^~~/usr/include/qt5/QtCore/qstring.h:266:31: note:   no known conversion for argument 1 from ���QStringRef��� to ���qulonglong��� {aka ���long long unsigned int���}/usr/include/qt5/QtCore/qstring.h:928:16: note: candidate: ���QString QString::arg(long int, int, int, QChar) const��� inline QString QString::arg(long a, int fieldWidth, int base, QChar fillChar) const^~~/usr/include/qt5/QtCore/qstring.h:928:16: note:   no known conversion for argument 1 from ���QStringRef��� to ���long int���/usr/include/qt5/QtCore/qstring.h:930:16: note: candidate: ���QString QString::arg(ulong, int, int, QChar) const��� inline QString QString::arg(ulong a, int fieldWidth, int base, QChar fillChar) const^~~/usr/include/qt5/QtCore/qstring.h:930:16: note:   no known conversion for argument 1 from ���QStringRef��� to ���ulong��� {aka ���long unsigned int���}/usr/include/qt5/QtCore/qstring.h:924:16: note: candidate: ���QString QString::arg(int, int, int, QChar) const��� inline QString QString::arg(int a, int fieldWidth, int base, QChar fillChar) const^~~/usr/include/qt5/QtCore/qstring.h:924:16: note:   no known conversion for argument 1 from ���QStringRef��� to ���int���/usr/include/qt5/QtCore/qstring.h:926:16: note: candidate: ���QString QString::arg(uint, int, int, QChar) const��� inline QString QString::arg(uint a, int fieldWidth, int base, QChar fillChar) const^~~/usr/include/qt5/QtCore/qstring.h:926:16: note:   no known conversion for argument 1 from ���QStringRef��� to ���uint��� {aka ���unsigned int���}/usr/include/qt5/QtCore/qstring.h:932:16: note: candidate: ���QString QString::arg(short int, int, int, QChar) const��� inline QString QString::arg(short a, int fieldWidth, int base, QChar fillChar) const^~~/usr/include/qt5/QtCore/qstring.h:932:16: note:   no known conversion for argument 1 from ���QStringRef��� to ���short int���/usr/include/qt5/QtCore/qstring.h:934:16: note: candidate: ���QString QString::arg(ushort, int, int, QChar) const��� inline QString QString::arg(ushort a, int fieldWidth, int base, QChar fillChar) const^~~/usr/include/qt5/QtCore/qstring.h:934:16: note:   no known conversion for argument 1 from ���QStringRef��� to ���ushort��� {aka ���short unsigned int���}/usr/include/qt5/QtCore/qstring.h:280:31: note: candidate: ���QString QString::arg(double, int, char, int, QChar) const��� Q_REQUIRED_RESULT QString arg(double a, int fieldWidth = 0, char fmt = 'g', int prec = -1,   ^~~/usr/include/qt5/QtCore/qstring.h:280:31: note:   no known conversion for argument 1 from ���QStringRef��� to ���double���/usr/include/qt5/QtCore/qstring.h:282:31: note: candidate: ���QString QString::arg(char, int, QChar) const��� Q_REQUIRED_RESULT QString arg(char a, int fieldWidth = 0,   ^~~/usr/include/qt5/QtCore/qstring.h:282:31: note:   no known conversion for argument 1 from ���QStringRef��� to ���char���/usr/include/qt5/QtCore/qstring.h:284:31: note: candidate: ���QString QString::arg(QChar, int, QChar) const��� Q_REQUIRED_RESULT QString arg(QChar a, int fieldWidth = 0, 

KDE CI: Frameworks knewstuff kf5-qt5 FreeBSDQt5.11 - Build # 5 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20FreeBSDQt5.11/5/
 Project:
Frameworks knewstuff kf5-qt5 FreeBSDQt5.11
 Date of build:
Fri, 07 Sep 2018 08:00:25 +
 Build duration:
1 min 17 sec and counting

KDE CI: Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.11 - Build # 7 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20WindowsMSVCQt5.11/7/
 Project:
Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Fri, 07 Sep 2018 08:35:31 +
 Build duration:
1 min 36 sec and counting
   CONSOLE OUTPUT
  [...truncated 216.39 KB...][ 70%] Linking CXX shared library ..\bin\KF5NewStuff.dll   Creating library ..\lib\KF5NewStuff.lib and object ..\lib\KF5NewStuff.exp   Creating library ..\lib\KF5NewStuff.lib and object ..\lib\KF5NewStuff.exp[ 70%] Built target KF5NewStuffScanning dependencies of target kmoretoolstest_autogenScanning dependencies of target kmoretoolstest2_autogenScanning dependencies of target kmoretoolstest_interactive_autogenScanning dependencies of target khotnewstuff_autogenScanning dependencies of target khotnewstuff_upload_autogenScanning dependencies of target khotnewstuff_test_autogen[ 75%] Automatic MOC for target kmoretoolstest[ 75%] Automatic MOC for target khotnewstuff_upload[ 75%] Automatic MOC for target khotnewstuff[ 75%] Built target khotnewstuff_upload_autogen[ 75%] Built target khotnewstuff_autogen[ 75%] Automatic MOC for target khotnewstuff_test[ 75%] Built target khotnewstuff_test_autogen[ 71%] Automatic MOC for target kmoretoolstest2[ 75%] Built target kmoretoolstest2_autogen[ 75%] Built target kmoretoolstest_autogen[ 75%] Automatic MOC for target kmoretoolstest_interactiveScanning dependencies of target khotnewstuff_uploadScanning dependencies of target khotnewstuff[ 75%] Built target kmoretoolstest_interactive_autogenScanning dependencies of target khotnewstuff_test[ 76%] Building CXX object tests/CMakeFiles/khotnewstuff.dir/khotnewstuff.cpp.obj[ 76%] Building CXX object tests/CMakeFiles/khotnewstuff_upload.dir/khotnewstuff_upload.cpp.obj[ 77%] Building CXX object tests/CMakeFiles/khotnewstuff_upload.dir/__/src/knewstuff_debug.cpp.obj[ 78%] Building CXX object tests/CMakeFiles/khotnewstuff.dir/__/src/knewstuff_debug.cpp.obj[ 79%] Building CXX object tests/CMakeFiles/khotnewstuff_upload.dir/__/src/staticxml/staticxmlprovider.cpp.obj[ 79%] Building CXX object tests/CMakeFiles/khotnewstuff.dir/__/src/core/knewstuffcore_debug.cpp.obj[ 80%] Building CXX object tests/CMakeFiles/khotnewstuff_upload.dir/__/src/core/knewstuffcore_debug.cpp.obj[ 81%] Building CXX object tests/CMakeFiles/khotnewstuff_upload.dir/khotnewstuff_upload_autogen/mocs_compilation.cpp.objkhotnewstuff_upload.cppkhotnewstuff.cpp[ 82%] Building CXX object tests/CMakeFiles/khotnewstuff_test.dir/khotnewstuff_test.cpp.objkhotnewstuff_test.cppScanning dependencies of target kmoretoolstest2Scanning dependencies of target kmoretoolstest_interactiveScanning dependencies of target kmoretoolstest[ 83%] Building CXX object autotests/CMakeFiles/kmoretoolstest2.dir/kmoretools/kmoretoolstest2.cpp.objkmoretoolstest2.cpp[ 85%] Building CXX object autotests/CMakeFiles/kmoretoolstest.dir/kmoretools/kmoretoolstest.cpp.objkmoretoolstest.cppknewstuff_debug.cppknewstuffcore_debug.cppstaticxmlprovider.cppmocs_compilation.cpp[ 86%] Building CXX object tests/CMakeFiles/khotnewstuff.dir/__/src/staticxml/staticxmlprovider.cpp.objC:\CI\workspace\Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.11\src\staticxml\staticxmlprovider.cpp(210): warning C4996: 'KNSCore::EntryInternal::setEntryXML': was declared deprecatedc:\ci\workspace\frameworks knewstuff kf5-qt5 windowsmsvcqt5.11\src\core\entryinternal.h(494): note: see declaration of 'KNSCore::EntryInternal::setEntryXML'knewstuff_debug.cppknewstuffcore_debug.cppstaticxmlprovider.cpp[ 87%] Building CXX object tests/CMakeFiles/khotnewstuff_test.dir/__/src/knewstuff_debug.cpp.objc:\ci\workspace\frameworks knewstuff kf5-qt5 windowsmsvcqt5.11\tests\khotnewstuff_test.h(50): warning C4003: not enough actual parameters for macro 'QStringLiteral'c:\ci\workspace\frameworks knewstuff kf5-qt5 windowsmsvcqt5.11\tests\khotnewstuff_test.h(50): warning C4003: not enough actual parameters for macro 'QT_UNICODE_LITERAL'c:\ci\workspace\frameworks knewstuff kf5-qt5 windowsmsvcqt5.11\tests\khotnewstuff_test.h(50): warning C4003: not enough actual parameters for macro 'QT_UNICODE_LITERAL_II'[ 88%] Building CXX object autotests/CMakeFiles/kmoretoolstest2.dir/__/src/knewstuff_debug.cpp.obj[ 89%] Building CXX object autotests/CMakeFiles/kmoretoolstest.dir/__/src/knewstuff_debug.cpp.obj[ 90%] Building CXX object tests/CMakeFiles/khotnewstuff.dir/khotnewstuff_autogen/mocs_compilation.cpp.obj[ 91%] Building CXX object tests/CMakeFiles/khotnewstuff_test.dir/__/src/core/knewstuffcore_debug.cpp.objC:\CI\workspace\Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.11\tests\khotnewstuff_test.cpp(41): fatal error C1083: Cannot open include file: 'unistd.h': No such file or directoryjom: C:\CI\workspace\Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.11\build\tests\CMakeFiles\khotnewstuff_test.dir\build.make [tests\CMakeFiles\khotnewstuff_test.dir\khotnewstuff_test.cpp.obj] Error 2knewstuff_debug.cppknewstuffcore_debug.cpp[ 92%] 

D15328: kfilewidget: convert connect syntax

[Jaime Torres Amate]

jtamate created this revision.
jtamate added reviewers: dfaure, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
jtamate requested review of this revision.

REVISION SUMMARY
  Convert from the old syntax to the new connect syntax

TEST PLAN
  The open file dialog works.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15328

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp
  src/filewidgets/kfilewidget.h

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15328: kfilewidget: convert connect syntax

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> kfilewidget.cpp:440
> +connect(d->ops, ::urlEntered, this,
> +[&](const QUrl ){d->_k_urlEntered(url);});
> +connect(d->ops, ::fileHighlighted, this,

Shouldn't this be using the `url` from the signal?
Also, please prefer explicit captures over `&` or `=`

> kfilewidget.cpp:473
>  
>  QAction *goToNavigatorAction = 
> coll->addAction(QStringLiteral("gotonavigator"), this, 
> SLOT(_k_activateUrlNavigator()));
>  goToNavigatorAction->setShortcut(QKeySequence(Qt::CTRL + Qt::Key_L));

Why not change this as well?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15328

To: jtamate, dfaure, #frameworks
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15321: [Calendar] Expose firstDayOfWeek in MonthView for calendar widgets to override the Locale

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Note that Plasma 5.14 depends on 5.50 which is already released, so any 
change that requires this property can only go in once 5.14 was branched off

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15321

To: Zren, broulik
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 214 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/214/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 07 Sep 2018 10:54:56 +
 Build duration:
2 min 21 sec and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(44/126)35%
(44/126)27%
(3599/13112)19%
(1821/9436)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(607/1113)29%
(313/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2217)7%
(96/1434)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)41%
(1420/3491)30%
(794/2633)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/135)0%
(0/12)src.plasma.private47%
(9/19)47%
(9/19)43%
(663/1542)30%
(301/1003)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)29%
(579/1976)18%
(312/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1096)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
  

D15337: Fix Solarized Light and Dark color schemes

[Andrew Crouthamel]

acrouthamel updated this revision to Diff 41171.
acrouthamel marked an inline comment as done.
acrouthamel added a comment.


  - Solarized Light Region Marker fix and small Dark tweak.

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15337?vs=41170=41171

BRANCH
  fix-solarized-colors

REVISION DETAIL
  https://phabricator.kde.org/D15337

AFFECTED FILES
  src/data/kateschemarc
  src/data/katesyntaxhighlightingrc

To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars

D15337: Fix Solarized Light and Dark color schemes

[Dominik Haumann]

dhaumann added inline comments.

INLINE COMMENTS

> katesyntaxhighlightingrc:143
> -Operator=ff93a1a1,ff93a1a1,-,-,,---
> -Others=ff859900,ff859900,-,-,,---
> -Preprocessor=ff27ae60,ff27ae60,-,-,,---

Isn't "Others" now missing? Every color theme should define 31 colors. If this 
was not the case before, then it was also wrong before :)

Can you check again?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D15337

To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars

D15337: Fix Solarized Light and Dark color schemes

[Andrew Crouthamel]

acrouthamel updated this revision to Diff 41172.
acrouthamel added a comment.


  - Fixed Light scheme Error color

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15337?vs=41171=41172

BRANCH
  fix-solarized-colors

REVISION DETAIL
  https://phabricator.kde.org/D15337

AFFECTED FILES
  src/data/kateschemarc
  src/data/katesyntaxhighlightingrc

To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars

D15337: Fix Solarized Light and Dark color schemes

[Andrew Crouthamel]

acrouthamel marked 2 inline comments as done.
acrouthamel added a comment.


  You were right again. For some reason that Others= disappeared from my 
~/.config/katesyntaxhighlightingrc so I didn't notice it. Even though it was 
defined and displaying fine in the GUI. Weird.
  
  I also made a few more adjustments to Markers colors to adhere to the 
Solarized rules for gray colors. I think it is pretty set now, unless something 
else disappeared...

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D15337

To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars

D14529: Android: Make sure Qm translations get loaded

[Albert Astals Cid]

aacid accepted this revision.
aacid added a comment.
This revision is now accepted and ready to land.


  ok then i guess :)

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14529

To: apol, #frameworks, aacid
Cc: svuorela, aacid, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, 
bruns

D15337: Fix Solarized Light and Dark color schemes

[Dominik Haumann]

dhaumann added a comment.


  Thanks for working on this. Looks good to me - just a minor question about 
the section for Solarized light.
  
  And also related: would you also create the .theme files for 
KSyntaxHighlighting?

INLINE COMMENTS

> katesyntaxhighlightingrc:104
>  # Solarized (light), Default Item Styles
> -[Default Item Styles - Schema Solarized (light)]
> -Alert=ffd33682,ffd33682,1-,-,,---

Am I mistaken, or did you remove the section here?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D15337

To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars

D15337: Fix Solarized Light and Dark color schemes

[Andrew Crouthamel]

acrouthamel added a comment.


  @dhaumann, I've added these colors to KSyntaxHighlighting over here: D15340 


REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D15337

To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars

D15337: Fix Solarized Light and Dark color schemes

[Dominik Haumann]

dhaumann added a comment.


  Solarized dark still only has 28 colors, right? Can you add the missing ones?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D15337

To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars

D15337: Fix Solarized Light and Dark color schemes

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Looks good to me. Can you commit yourself?

REPOSITORY
  R39 KTextEditor

BRANCH
  fix-solarized-colors

REVISION DETAIL
  https://phabricator.kde.org/D15337

To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars

D15337: Fix Solarized Light and Dark color schemes

[Andrew Crouthamel]

acrouthamel added a comment.


  Thanks, I can. I'm getting an error in Arcanist, so let me diagnose that and 
I'll land it.

REPOSITORY
  R39 KTextEditor

BRANCH
  fix-solarized-colors

REVISION DETAIL
  https://phabricator.kde.org/D15337

To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars

D15340: Add Solarized Light and Dark themes

[Andrew Crouthamel]

acrouthamel created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
acrouthamel requested review of this revision.

REVISION SUMMARY
  This adds Solarized Light and Dark themes, with the same color scheme
  selected in Phabricator diff D15337 . 
This includes the themes here in
  KSyntaxHighlighting for when KTextEditor themes are replaced.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  add-solarized-themes

REVISION DETAIL
  https://phabricator.kde.org/D15340

AFFECTED FILES
  data/themes/solarized-dark.theme
  data/themes/solarized-light.theme

To: acrouthamel
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D15340: Add Solarized Light and Dark themes

[Andrew Crouthamel]

acrouthamel edited the summary of this revision.
acrouthamel added reviewers: Kate, Framework: Syntax Highlighting.
acrouthamel added a project: Framework: Syntax Highlighting.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D15340

To: acrouthamel, #kate, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, genethomas, 
kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

D15337: Fix Solarized Light and Dark color schemes

[Andrew Crouthamel]

acrouthamel edited the summary of this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D15337

To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars

D15337: Fix Solarized Light and Dark color schemes

[Andrew Crouthamel]

acrouthamel added a comment.


  In D15337#322043 , @dhaumann wrote:
  
  > Solarized dark still only has 28 colors, right? Can you add the missing 
ones?
  
  
  Man, I'm looking forward to this JSON system in the future. LOL. Ok, fixed 
again. I counted all of them before commit.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D15337

To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars

D15337: Fix Solarized Light and Dark color schemes

[Andrew Crouthamel]

acrouthamel updated this revision to Diff 41181.
acrouthamel added a comment.


  - Added three missing definitions

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15337?vs=41177=41181

BRANCH
  fix-solarized-colors

REVISION DETAIL
  https://phabricator.kde.org/D15337

AFFECTED FILES
  src/data/kateschemarc
  src/data/katesyntaxhighlightingrc

To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars

D15337: Fix Solarized Light and Dark color schemes

[Andrew Crouthamel]

acrouthamel updated this revision to Diff 41170.
acrouthamel added a comment.


  - Fixed section code

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15337?vs=41168=41170

BRANCH
  fix-solarized-colors

REVISION DETAIL
  https://phabricator.kde.org/D15337

AFFECTED FILES
  src/data/kateschemarc
  src/data/katesyntaxhighlightingrc

To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars

D15337: Fix Solarized Light and Dark color schemes

[Andrew Crouthamel]

acrouthamel updated this revision to Diff 41176.
acrouthamel added a comment.


  - Some Marker color tweaks to ensure Solarized interaction rule adherence

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15337?vs=41172=41176

BRANCH
  fix-solarized-colors

REVISION DETAIL
  https://phabricator.kde.org/D15337

AFFECTED FILES
  src/data/kateschemarc
  src/data/katesyntaxhighlightingrc

To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars

D15337: Fix Solarized Light and Dark color schemes

[Andrew Crouthamel]

acrouthamel marked an inline comment as done.
acrouthamel added a comment.


  I've fixed the section. I'm actually working on the KSyntaxHighlighting 
themes now, you'll see those in another patch.

INLINE COMMENTS

> dhaumann wrote in katesyntaxhighlightingrc:104
> Am I mistaken, or did you remove the section here?

No, you're right, that's a mistake. I just fixed it.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D15337

To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars

D15337: Fix Solarized Light and Dark color schemes

[Andrew Crouthamel]

acrouthamel updated this revision to Diff 41177.
acrouthamel added a comment.


  - Fixed Others definition

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15337?vs=41176=41177

BRANCH
  fix-solarized-colors

REVISION DETAIL
  https://phabricator.kde.org/D15337

AFFECTED FILES
  src/data/kateschemarc
  src/data/katesyntaxhighlightingrc

To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars

D6513: Add support for Attica tags support

[Nathaniel Graham]

ngraham added a comment.


  So is this enough for people to start tagging KDE4 content as such? Or is 
anything else still required before that capability lands?

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D6513

To: leinir, #knewstuff, apol, #kde_store, whiting, ahiemstra, mlaurent, dfaure, 
cfeck
Cc: dfaure, cfeck, mlaurent, ngraham, ahiemstra, kde-frameworks-devel, 
#knewstuff, michaelh, ZrenBot, bruns

D15337: Fix Solarized Light and Dark color schemes

[Andrew Crouthamel]

acrouthamel closed this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D15337

To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars

D15328: kfilewidget: convert connect syntax

[Jaime Torres Amate]

jtamate updated this revision to Diff 41148.
jtamate marked 2 inline comments as done.
jtamate added a comment.


  Changed [&] by [this]in the lambdas.
  Added a lambda for KActionCollection::addAction. I didn't knew it was already 
possible.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15328?vs=41145=41148

REVISION DETAIL
  https://phabricator.kde.org/D15328

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp
  src/filewidgets/kfilewidget.h

To: jtamate, dfaure, #frameworks
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15328: kfilewidget: convert connect syntax

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> kfilewidget.cpp:1225
>  // the KDirOperator's view-selection in there
> -QObject::disconnect(locationEdit, SIGNAL(editTextChanged(QString)),
> -q, SLOT(_k_slotLocationChanged(QString)));
> +QObject::disconnect(m_connEditTextChanged);
>  

Whenever disconnect after that reset connection to QMetaObject::Connection 
cause disconnect empty connection is safe, double disconnect same one - does 
not.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15328

To: jtamate, dfaure, #frameworks
Cc: anthonyfieroni, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15330: [autotests] Compare booleans to booleans

[Vlad Zagorodniy]

zzag created this revision.
zzag added reviewers: KWin, romangg.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
zzag requested review of this revision.

REVISION SUMMARY
  Compiler errors:
  
  17:06:23 
/usr/lib64/gcc/x86_64-suse-linux/8/../../../../x86_64-suse-linux/bin/ld: 
CMakeFiles/testDataDevice.dir/test_datadevice.cpp.o: in function 
`TestDataDevice::testDrag()':
  17:06:23 /home/jenkins/workspace/Frameworks kwayland kf5-qt5 
SUSEQt5.9/autotests/client/test_datadevice.cpp:290: undefined reference to 
`bool QTest::qCompare(int const&, bool const&, char const*, char 
const*, char const*, int)'
  17:06:23 
/usr/lib64/gcc/x86_64-suse-linux/8/../../../../x86_64-suse-linux/bin/ld: 
CMakeFiles/testDataDevice.dir/test_datadevice.cpp.o: in function 
`TestDataDevice::testDragInternally()':
  17:06:23 /home/jenkins/workspace/Frameworks kwayland kf5-qt5 
SUSEQt5.9/autotests/client/test_datadevice.cpp:369: undefined reference to 
`bool QTest::qCompare(int const&, bool const&, char const*, char 
const*, char const*, int)'

TEST PLAN
  Ran testDataDevice, still passes.

REPOSITORY
  R127 KWayland

BRANCH
  fix-build

REVISION DETAIL
  https://phabricator.kde.org/D15330

AFFECTED FILES
  autotests/client/test_datadevice.cpp

To: zzag, #kwin, romangg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15328: kfilewidget: convert connect syntax

[Jaime Torres Amate]

jtamate added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in kfilewidget.cpp:1225
> Whenever disconnect after that reset connection to QMetaObject::Connection 
> cause disconnect empty connection is safe, double disconnect same one - does 
> not.

I'm sorry but I don't understand your comment.
m_connEditTextChanged is created in the constructor, line 585.
Afterwards it is disconnected and reconnected in:
setDummyHistoryEntry, removeDummyHistoryEntry and readRecentFiles.

> broulik wrote in kfilewidget.cpp:440
> Shouldn't this be using the `url` from the signal?
> Also, please prefer explicit captures over `&` or `=`

I think it is using the url, the parameter to the lambda and _k_urlEntered(url);

Changed & for this, d can't be used directly.

> broulik wrote in kfilewidget.cpp:473
> Why not change this as well?

Because I didn't knew KActionCollection have it already! Done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15328

To: jtamate, dfaure, #frameworks
Cc: anthonyfieroni, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15328: kfilewidget: convert connect syntax

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> jtamate wrote in kfilewidget.cpp:1225
> I'm sorry but I don't understand your comment.
> m_connEditTextChanged is created in the constructor, line 585.
> Afterwards it is disconnected and reconnected in:
> setDummyHistoryEntry, removeDummyHistoryEntry and readRecentFiles.

QObject::disconnect(m_connEditTextChanged);
  m_connEditTextChanged = QMetaObject::Connection();

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15328

To: jtamate, dfaure, #frameworks
Cc: anthonyfieroni, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15328: kfilewidget: convert connect syntax

[Jaime Torres Amate]

jtamate marked an inline comment as done.
jtamate added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in kfilewidget.cpp:1225
>   QObject::disconnect(m_connEditTextChanged);
>   m_connEditTextChanged = QMetaObject::Connection();

I'm sorry, but I still don't get it.
Doesn't connect/disconnect work more or less as new/delete?
I mean, if m_connEditTextChanged is reconnected, can't it be disconnected 
safely?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15328

To: jtamate, dfaure, #frameworks
Cc: anthonyfieroni, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 218 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/218/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 08 Sep 2018 04:12:49 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(44/126)35%
(44/126)27%
(3599/13112)19%
(1821/9436)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(607/1113)29%
(313/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2217)7%
(96/1434)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)41%
(1420/3491)30%
(794/2633)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/135)0%
(0/12)src.plasma.private47%
(9/19)47%
(9/19)43%
(663/1542)30%
(301/1003)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)29%
(579/1976)18%
(312/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1096)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%

D13700: implement reading of the replaygain tags

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> taglibextractor.cpp:943
> +}
> +result->add(Property::ReplayGainAlbumGain, 
> data.replayGainAlbumGain.toDouble());
> +}

You should check if the value can be converted to double, and probably also if 
it is in a sane range.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D13700

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D13700: implement reading of the replaygain tags

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> astippich wrote in taglibextractor.cpp:50
> This is used throughout the taglibextractor and should then be corrected 
> everywhere in a different patch imho.

Can you do a followup-patch to fix this?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D13700

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams