D20556: Keep empty Json metadata docs out of DocumentData DB

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, astippich, ngraham, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  In case a document is marked for content indexing, but none of the
  extractors returns any data, the Baloo::Result::finish() method will
  serialize the data as an empty Json document, "{}".
  
  Having no data for a document in the DB is no error, this is the case
  already when content indexing is disabled or when the indexer has not
  yet processed the document, so leave it out to save some space.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20556

AFFECTED FILES
  src/file/extractor/result.cpp
  src/lib/file.cpp

To: bruns, #baloo, #frameworks, astippich, ngraham, poboiko
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20525: [InformationPanel] Use the new inline configuration mode

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
This revision now requires changes to proceed.


  Please bump the minimum required version for `KF5BalooWidgets` to 19.07.70.

INLINE COMMENTS

> informationpanelcontent.cpp:121
> +connect(m_configureButtons, ::accepted, this, [this]() {
> +
> this->m_metaDataWidget->setConfigurationMode(Baloo::ConfigurationMode::Accept);
> +m_configureButtons->setVisible(false);

Why `this->` only on this line? (I'd just remove it as it's unnecessary)

> informationpanelcontent.cpp:127
> +connect(m_configureButtons, ::rejected, this, [this]() {
> +
> this->m_metaDataWidget->setConfigurationMode(Baloo::ConfigurationMode::Cancel);
> +m_configureButtons->setVisible(false);

Same here

> informationpanelcontent.cpp:237
>  
> +void InformationPanelContent::configureShownProperties() {
> +m_configureLabel->setVisible(true);

Coding style: brace should go to next line (the function below is also wrong...)

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D20525

To: bruns, #dolphin, #baloo, #frameworks, ngraham, astippich, #vdg, 
elvisangelaccio
Cc: elvisangelaccio, meven, kfm-devel, alexde, feverfew, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, mikesomov

D20525: [InformationPanel] Use the new inline configuration mode

[Elvis Angelaccio]

elvisangelaccio added a comment.


  About the UI, I noticed that when the panel is in "configure" mode, it's 
still possible to right-click it and click the "Configure" entry, which will do 
nothing.
  We could fix this by disabling the entry once clicked. Another idea: make the 
entry checkable instead of using the buttonbox.
  
  If we choose to go with the buttonbox, I'd rename the "Ok" button to "Save" 
or similar.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D20525

To: bruns, #dolphin, #baloo, #frameworks, ngraham, astippich, #vdg, 
elvisangelaccio
Cc: elvisangelaccio, meven, kfm-devel, alexde, feverfew, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, mikesomov

D20555: Don't use qAsConst over a temporary variable

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R268:abe32ec59939: Dont use qAsConst over a temporary 
variable (authored by mlaurent).

REPOSITORY
  R268 KGlobalAccel

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20555?vs=56238=56239

REVISION DETAIL
  https://phabricator.kde.org/D20555

AFFECTED FILES
  src/runtime/component.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20557: Install krcc.h header

[Albert Astals Cid]

aacid added a subscriber: dfaure.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D20557

To: aacid
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D20558: Bug fix: find c++ stl using regex

[Sharaf Zaman]

sh-zam created this revision.
sh-zam added a reviewer: apol.
Herald added projects: Frameworks, Build System.
Herald added a subscriber: kde-buildsystem.
sh-zam requested review of this revision.

REVISION SUMMARY
  Find C++ shared lib path using regex. This change makes finding path
  independent of the order in which it was added by cmake.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20558

AFFECTED FILES
  toolchain/ECMAndroidDeployQt.cmake

To: sh-zam, apol
Cc: kde-buildsystem, kde-frameworks-devel, bencreasy, michaelh, ngraham, bruns

D20524: [FileMetaDataWidget] Allow inline configuration of visible properties

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> filemetadatawidget.h:93
> + * Switch between regular (view) and configuration mode.
> + * @since 5.58
> + */

Should be `@since 19.08.0` (baloo-widgets follows the KDE Applications 
versioning)

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D20524

To: bruns, #baloo, #dolphin, #frameworks, ngraham, astippich
Cc: elvisangelaccio, gennad, domson, ashaposhnikov, astippich, spoorun, abrahams

D20558: Bug fix: find c++ stl using regex

[Sharaf Zaman]

sh-zam added a comment.


  > Why are you using it without Android.cmake?
  
  I am building Krita and to add `create-apk` target I am using `include 
(ECMAndroidDeployQt.cmake)`, I can't use `Android.cmake` because of some 
variables as it expects to run as a toolchain.
  
  Later today, I will submit the patch for Krita which you might have to review 
:-)

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D20558

To: sh-zam, apol
Cc: kde-buildsystem, kde-frameworks-devel, bencreasy, michaelh, ngraham, bruns

D20558: Bug fix: find c++ stl using regex

[Sharaf Zaman]

sh-zam updated this revision to Diff 56257.
sh-zam added a comment.


  - disallow whitespaces in path

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20558?vs=56243=56257

BRANCH
  arcpatch-D20558

REVISION DETAIL
  https://phabricator.kde.org/D20558

AFFECTED FILES
  toolchain/ECMAndroidDeployQt.cmake

To: sh-zam, apol
Cc: kde-buildsystem, kde-frameworks-devel, bencreasy, michaelh, ngraham, bruns

D20510: SvgItem, IconItem: drop "smooth" property override, update node on change

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:18a2ca50ab09: SvgItem, IconItem: drop smooth 
property override, update node on change (authored by kossebau).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20510?vs=56147=56250

REVISION DETAIL
  https://phabricator.kde.org/D20510

AFFECTED FILES
  src/declarativeimports/core/iconitem.cpp
  src/declarativeimports/core/iconitem.h
  src/declarativeimports/core/svgitem.cpp
  src/declarativeimports/core/svgitem.h

To: kossebau, #plasma, davidedmundson, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 74 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/74/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 14 Apr 2019 22:07:42 +
 Build duration:
15 min and counting
   BUILD ARTIFACTS
  acc/KF5Plasma-5.58.0.xmlacc/KF5PlasmaQuick-5.58.0.xmllogs/KF5Plasma/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3636/13354)18%
(1821/9854)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(610/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(311/2257)6%
(91/1454)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)44%
(689/1579)29%
(303/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(315/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%
(0/1022)tests.dpi0%
   

D20509: Detect duplicate ANDROID_EXTRA_LIBS and minor bug fix

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Looks good to me, can you land it?

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20509

To: sh-zam, apol, vkrause
Cc: kde-buildsystem, kde-frameworks-devel, bencreasy, michaelh, ngraham, bruns

D20557: Install krcc.h header

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20557

AFFECTED FILES
  src/CMakeLists.txt

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 67 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/67/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 14 Apr 2019 22:07:43 +
 Build duration:
12 min and counting
   BUILD ARTIFACTS
  acc/KF5Plasma-5.58.0.xmlacc/KF5PlasmaQuick-5.58.0.xmllogs/KF5Plasma/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3628/13353)18%
(1819/9854)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(311/2257)6%
(91/1454)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(315/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%
(0/1022)tests.dpi0%
   

Re: New framework: KCalCore

[Alexander Potashev]

вт, 9 апр. 2019 г. в 20:10, Volker Krause :
>
> On Sunday, 7 April 2019 16:24:13 CEST Alexander Potashev wrote:
> > вс, 7 апр. 2019 г. в 15:45, Volker Krause :
> > > Hi,
> > >
> > > I'd like to propose KCalCore for review to move from KDE PIM to KF5.
> > >
> > > KCalCore is an implementation of the iCalendar standard based on libical,
> > > covering the data model, input/output and the rather complex recurrence
> > > algorithms defined in that standard. It's used outside of KDE PIM as well,
> > > e.g. by Zanshin or the Plasma Mobile calendar app.
> >
> > Hi Volker,
> >
> > While porting KTimeTracker to KF5, I noticed that KCalCore lost KIO
> > support on the way from KDELibs4 to KF 5.0.
> >
> > Of course I can subclass ICalFormat, but the FileStorage<->ICalFormat
> > relation looks weird to me: ICalFormat::save() is the method that
> > actually writes file to disk, while class name "ICalFormat" suggests
> > that it should only be concerned about iCal contents, not the I/O.
> >
> > May be CalFormat should only implement marshal/unmarshal methods, then
> > actual r/w from disk can be done in FileStorage. Otherwise, for me to
> > add KIO support right now I need to subclass ICalFormat rather than
> > FileStorage which is weird.
>
> Right. IMHO the entire file handling code should probably not be in there in
> the first place. That is, the CalStorage class hierarchy and the file I/O
> methods from the CalFormat hierachy (streaming to/from QIODevice rather than
> working with full QByteArray serialization might however make sense there).
>
> This is also why KIO support was a very bad idea in there, the KCalCore API is
> synchronous (predating KIO), while KIO is asynchronous, and so is likely any
> other persistence backend one might want to use.
>
> Looking at lxr.kde.org I'm however reluctant to remove any of this now though,
> this is still too widely used.

Hi Volker,

Thanks for your thoughts!

Since David suggested renaming KCalCore to something else, how about we instead
 1. Redesign the API (e.g. drop file handling, etc) and call it e.g.
KCal, get it into KF5,
 2. Keep releasing KCalCore as part of KDEPIM and may be port it to
KF5::KCal as backend to reduce codebase,
 3. Deprecate KCalCore and gradually port everything to the new clean KF5::KCal?
...
 4. PROFIT: nobody's code is hurt since the legacy KCalCore API is
still available.

-- 
Alexander Potashev

D20509: Detect duplicate ANDROID_EXTRA_LIBS and minor bug fix

[Sharaf Zaman]

sh-zam updated this revision to Diff 56244.
sh-zam added a comment.


  improved name and code flow

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20509?vs=56151=56244

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20509

AFFECTED FILES
  toolchain/specifydependencies.cmake

To: sh-zam, apol, vkrause
Cc: kde-buildsystem, kde-frameworks-devel, bencreasy, michaelh, ngraham, bruns

D20509: Detect duplicate ANDROID_EXTRA_LIBS and minor bug fix

[Sharaf Zaman]

sh-zam marked 2 inline comments as done.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D20509

To: sh-zam, apol, vkrause
Cc: kde-buildsystem, kde-frameworks-devel, bencreasy, michaelh, ngraham, bruns

D20542: Retitle button "Close" to "Close file" when a file has been removed on disk

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  +1 shipit!

REPOSITORY
  R39 KTextEditor

BRANCH
  arcpatch-D20542

REVISION DETAIL
  https://phabricator.kde.org/D20542

To: meven, #ktexteditor, ngraham
Cc: cullmann, kossebau, kwrite-devel, kde-frameworks-devel, domson, michaelh, 
ngraham, bruns, demsking, sars, dhaumann

D20536: Use consistent default Kickoff user icon

[Nathaniel Graham]

ngraham added a comment.


  This makes it inconsistent with the default user avatar shown in the Users 
KCM though. That's kinda odd.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20536

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D20536: Use consistent default Kickoff user icon

[Björn Feber]

GB_2 added a comment.


  In D20536#450246 , @ngraham wrote:
  
  > This makes it inconsistent with the default user avatar shown in the Users 
KCM though. That's kinda odd.
  
  
  Ok, then we could rename that 128px icon to something different.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20536

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D19850: Make AppStream generation opt-in

[Nathaniel Graham]

ngraham added a comment.


  Ping! Can we land this or a variant of it?

REPOSITORY
  R290 KPackage

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19850

To: apol, #plasma, ngraham
Cc: sitter, ngraham, kde-frameworks-devel, michaelh, bruns

D20550: Oxygen desktoptheme: add padding to hands, against jagged outline on rotation

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  antialiasoxygenclockhands

REVISION DETAIL
  https://phabricator.kde.org/D20550

To: kossebau, #vdg, #plasma, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20556: Keep empty Json metadata docs out of DocumentData DB

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20556

To: bruns, #baloo, #frameworks, astippich, ngraham, poboiko
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20536: Use consistent default Kickoff user icon

[Björn Feber]

GB_2 updated this revision to Diff 56263.
GB_2 added a comment.


  Change name of blue user icon, will need to make a patch for `user-manager` 
too

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20536?vs=56196=56263

BRANCH
  use-consistent-default-kickoff-user-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20536

AFFECTED FILES
  icons-dark/applets/128/user-identity.svg
  icons-dark/applets/128/user-man.svg
  icons-dark/applets/22/user-identity.svg
  icons/applets/128/user-identity.svg
  icons/applets/128/user-man.svg
  icons/applets/22/user-identity.svg

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D20542: Retitle button "Close" to "Close file" when a file has been removed on disk

[Christoph Cullmann]

cullmann accepted this revision.

REPOSITORY
  R39 KTextEditor

BRANCH
  arcpatch-D20542

REVISION DETAIL
  https://phabricator.kde.org/D20542

To: meven, #ktexteditor, ngraham, cullmann
Cc: cullmann, kossebau, kwrite-devel, kde-frameworks-devel, domson, michaelh, 
ngraham, bruns, demsking, sars, dhaumann

D20536: Use consistent default Kickoff user icon

[Björn Feber]

GB_2 added a dependency: D20564: Change default user avatar.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20536

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D20536: Use consistent default Kickoff user icon

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  +1, assuming D20564  is approved and 
lands.

REPOSITORY
  R266 Breeze Icons

BRANCH
  use-consistent-default-kickoff-user-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20536

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D20565: Ensure not to fold the end marker

[loh tar]

loh.tar created this revision.
loh.tar added reviewers: KTextEditor, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  ...to avoid a deceptive look
  
  With recent fixes was also the closing brace folded which can cause a false 
look of the remaining visible code

TEST PLAN
  Fold differend kind of code, only tested yet with C/C++ where it seems to 
work.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20565

AFFECTED FILES
  src/view/kateviewhelpers.cpp

To: loh.tar, #ktexteditor, cullmann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20209: Add support for KBookmarkOwner to communicate if it has tabs open

[David Faure]

dfaure added a comment.


  Urgh. Indeed. And looking around I find many inline virtuals in apparently 
public headers... http://www.davidfaure.fr/2019/inline_virtual_dtors.diff 
(though maybe some of these don't have d pointers at all...)
  
  About KBookmarkOwner, the lack of an explicit constructor is a problem too 
(apps wouldn't instanciate the d pointer). I just added TODO KF6 comments, for 
the next person in your position: 
https://commits.kde.org/kbookmarks/746ecc8db9a04e4d47adc62b0aa03733ca8ecdf8
  
  Meanwhile we have to find another way. Would my idea of adding methods to 
KBookmarkMenu work out?

REPOSITORY
  R294 KBookmarks

REVISION DETAIL
  https://phabricator.kde.org/D20209

To: hallas, #frameworks, ngraham, cfeck, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20557: Install krcc.h header

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Can't remember what use case I had in mind back then... Probably someone 
asked me to implement this

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20557

To: aacid, dfaure
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D20519: Fix double delete on broken files

[Albert Astals Cid]

aacid closed this revision.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D20519

To: aacid, dfaure
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kbookmarks » kf5-qt5 WindowsMSVCQt5.11 - Build # 36 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20WindowsMSVCQt5.11/36/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sun, 14 Apr 2019 18:51:13 +
 Build duration:
23 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kbookmarktest

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 77 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/77/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 14 Apr 2019 22:07:43 +
 Build duration:
3 min 15 sec and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

D20557: Install krcc.h header

[Albert Astals Cid]

This revision was automatically updated to reflect the committed changes.
Closed by commit R243:4b1927e954fb: Install krcc.h header (authored by aacid).

REPOSITORY
  R243 KArchive

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20557?vs=56242=56251

REVISION DETAIL
  https://phabricator.kde.org/D20557

AFFECTED FILES
  src/CMakeLists.txt

To: aacid, dfaure
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D20558: Bug fix: find c++ stl using regex

[Sharaf Zaman]

sh-zam added a comment.


  Can we add a `cmake_minimum_required` to `3.7`? Regex fails to compile on 
older versions, when run outside of `Android.cmake`.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D20558

To: sh-zam, apol
Cc: kde-buildsystem, kde-frameworks-devel, bencreasy, michaelh, ngraham, bruns

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

[Björn Feber]

GB_2 added a comment.


  Ping

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D20140

To: ndavis, #plasma, #vdg
Cc: GB_2, ngraham, kde-frameworks-devel, michaelh, bruns

D20558: Bug fix: find c++ stl using regex

[Aleix Pol Gonzalez]

apol added a comment.


  In D20558#450198 , @sh-zam wrote:
  
  > Can we add a `cmake_minimum_required` to `3.7`? Regex fails to compile on 
older versions, when run outside of `Android.cmake`.
  
  
  Sure, add it.
  Why are you using it without Android.cmake?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D20558

To: sh-zam, apol
Cc: kde-buildsystem, kde-frameworks-devel, bencreasy, michaelh, ngraham, bruns

D20509: Detect duplicate ANDROID_EXTRA_LIBS and minor bug fix

[Sharaf Zaman]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:24538afeaf61: Detect duplicate ANDROID_EXTRA_LIBS and 
minor bug fix (authored by sh-zam).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20509?vs=56244=56255

REVISION DETAIL
  https://phabricator.kde.org/D20509

AFFECTED FILES
  toolchain/specifydependencies.cmake

To: sh-zam, apol, vkrause
Cc: kde-buildsystem, kde-frameworks-devel, bencreasy, michaelh, ngraham, bruns

D20209: Add support for KBookmarkOwner to communicate if it has tabs open

[David Hallas]

hallas added inline comments.

INLINE COMMENTS

> dfaure wrote in kbookmarkowner.h:120
> One day we'll probably wonder how many tabs are actually open, to avoid 
> saying "Bookmark Tabs As Folder" if there's only one tab. So I'd prefer for 
> that and make this an int rather than a bool.
> 
> Bigger problem: this is a public class. You CANNOT add a new virtual method, 
> that is binary incompatible.
> You have to do this with a setter and a getter (and putting the member 
> variable behind the d pointer).

Good point (both of them)

What are our binary compatibility promises? Is //every// version of frameworks 
always binary backwards compatible? Or do we have a window every now and then 
where we can make source compatible changes but not binary compatible? I don't 
mind changing this to be using settings and getters, but that just makes this 
API stand out from the rest. All the other APIs in the class are virtual 
functions which should be overwritten by the actual owner. I know this does not 
argue against our binary compatible promise though :D

REPOSITORY
  R294 KBookmarks

REVISION DETAIL
  https://phabricator.kde.org/D20209

To: hallas, #frameworks, ngraham, cfeck, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20526: fix extracting of some properties to match what was writen

[Alexander Stippich]

astippich added a comment.


  IMHO for searching, the separation from a single string into multiple entries 
is the best thing to do, from a metadata editing point of view not so much.
  How about inserting the TStringList entry by entry, without using the 
contactsFromString method? That would maintain the exact representation of 
metadata tags also for the baloo database.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20526

To: mgallien, astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20525: [InformationPanel] Use the new inline configuration mode

[Méven Car]

meven added a comment.


  I like this change. This will make D19243 
 D19241 
 irrelevant and fix indirectly the bug 
389571.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D20525

To: bruns, #dolphin, #baloo, #frameworks, ngraham, astippich
Cc: meven, kfm-devel, alexde, feverfew, spoorun, navarromorales, firef, 
andrebarros, emmanuelp, mikesomov

D20528: Change properties attributes for consistency

[Alexander Stippich]

astippich added a dependency: D19445: Handle variant list in formatting 
functions.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20528

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20530: Fix signed/unsigned warning after statx change

[David Faure]

dfaure created this revision.
dfaure added reviewers: meven, fvogt, bruns.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  file.cpp:947:60: warning: comparison between signed and unsigned integer 
expressions [-Wsign-compare]
  
} else if (n > 0 && static_cast(n) != bufferSize) {
  
  Tricky because the type of bufferSize depends on which #if branch was taken.

TEST PLAN
  Compiles without warning now (apparently I don't have statx available)

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20530

AFFECTED FILES
  src/ioslaves/file/file.cpp

To: dfaure, meven, fvogt, bruns
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 259 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/259/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sun, 14 Apr 2019 10:49:01 +
 Build duration:
4 min 42 sec and counting
   CONSOLE OUTPUT
  [...truncated 1164 lines...][2019-04-14T10:53:27.812Z] [ 35%] Built target kio_help[2019-04-14T10:53:27.812Z] [ 35%] Building CXX object src/ioslaves/http/CMakeFiles/kio_http.dir/httpauthentication.cpp.obj[2019-04-14T10:53:28.084Z]Creating library ..\..\..\lib\ftp.lib and object ..\..\..\lib\ftp.exp[2019-04-14T10:53:29.085Z]Creating library ..\..\..\lib\ftp.lib and object ..\..\..\lib\ftp.exp[2019-04-14T10:53:29.367Z] [ 35%] Built target kio_ftp[2019-04-14T10:53:29.367Z] Scanning dependencies of target kacltest[2019-04-14T10:53:29.367Z] [ 35%] Building CXX object src/gui/CMakeFiles/KF5KIOGui.dir/KF5KIOGui_autogen/mocs_compilation.cpp.obj[2019-04-14T10:53:29.646Z] mocs_compilation.cpp[2019-04-14T10:53:29.646Z] [ 36%] Building CXX object autotests/CMakeFiles/kacltest.dir/kacltest.cpp.obj[2019-04-14T10:53:29.914Z] kacltest.cpp[2019-04-14T10:53:30.532Z] Scanning dependencies of target kfileitemtest[2019-04-14T10:53:30.831Z] [ 36%] Building CXX object autotests/CMakeFiles/kfileitemtest.dir/kfileitemtest.cpp.obj[2019-04-14T10:53:31.114Z] kfileitemtest.cpp[2019-04-14T10:53:32.123Z] C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\ioslaves\file\file.cpp(867): error C7525: inline variables require at least '/std:c++17'[2019-04-14T10:53:32.123Z] C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\ioslaves\file\file.cpp(867): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int[2019-04-14T10:53:32.123Z] C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\ioslaves\file\file.cpp(867): error C2146: syntax error: missing ';' before identifier 'stat_uid'[2019-04-14T10:53:32.123Z] C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\ioslaves\file\file.cpp(868): error C7525: inline variables require at least '/std:c++17'[2019-04-14T10:53:32.123Z] C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\ioslaves\file\file.cpp(868): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int[2019-04-14T10:53:32.123Z] C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\ioslaves\file\file.cpp(868): error C2146: syntax error: missing ';' before identifier 'stat_gid'[2019-04-14T10:53:32.123Z] TODO: st_uid and st_gid are always zero, use GetSecurityInfo to find the owner[2019-04-14T10:53:32.123Z] Scanning dependencies of target kmountpointtest[2019-04-14T10:53:32.392Z] jom: C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\build\src\ioslaves\file\CMakeFiles\kio_file.dir\build.make [src\ioslaves\file\CMakeFiles\kio_file.dir\file.cpp.obj] Error 2[2019-04-14T10:53:32.392Z] file_win.cpp[2019-04-14T10:53:32.392Z] mocs_compilation.cpp[2019-04-14T10:53:32.675Z] [ 37%] Building CXX object src/ioslaves/http/CMakeFiles/kio_http.dir/httpfilter.cpp.obj[2019-04-14T10:53:33.348Z] [ 38%] Building CXX object autotests/CMakeFiles/kacltest.dir/kacltest_autogen/mocs_compilation.cpp.obj[2019-04-14T10:53:33.348Z] C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\ioslaves\file\file_win.cpp(62): warning C4996: 'KIO::UDSEntry::insert': was declared deprecated[2019-04-14T10:53:33.348Z] C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.11/src/core/udsentry.h(148): note: see declaration of 'KIO::UDSEntry::insert'[2019-04-14T10:53:33.348Z] C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\ioslaves\file\file_win.cpp(64): warning C4996: 'KIO::UDSEntry::insert': was declared deprecated[2019-04-14T10:53:33.348Z] C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.11/src/core/udsentry.h(148): note: see declaration of 'KIO::UDSEntry::insert'[2019-04-14T10:53:33.348Z] C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\ioslaves\file\file_win.cpp(96): warning C4996: 'KIO::UDSEntry::insert': was declared deprecated[2019-04-14T10:53:33.348Z] C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.11/src/core/udsentry.h(156): note: see declaration of 'KIO::UDSEntry::insert'[2019-04-14T10:53:33.348Z] C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\ioslaves\file\file_win.cpp(97): warning C4996: 'KIO::UDSEntry::insert': was declared deprecated[2019-04-14T10:53:33.348Z] C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.11/src/core/udsentry.h(156): note: see declaration of 'KIO::UDSEntry::insert'[2019-04-14T10:53:33.348Z] C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\ioslaves\file\file_win.cpp(98): warning C4996: 'KIO::UDSEntry::insert': was declared deprecated[2019-04-14T10:53:33.348Z] C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.11/src/core/udsentry.h(156): note: see declaration of 'KIO::UDSEntry::insert'[2019-04-14T10:53:33.348Z] C:\CI\workspace\Frameworks\kio\kf5-qt5 

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 76 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/76/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 14 Apr 2019 10:49:01 +
 Build duration:
7 min 31 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.58.0.xmllogs/KF5KIO/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 5 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kfileitemtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_kurifiltertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/399)66%
(264/399)54%
(32993/60671)39%
(16867/43768)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9308/9772)48%
(4284/9015)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8473/14452)51%
(4703/9226)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)54%
(4352/8049)40%
(1884/4697)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(572/1080)39%
(343/888)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4291)35%
(1294/3672)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
 

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 89 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/89/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 14 Apr 2019 10:49:01 +
 Build duration:
10 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.58.0.xmllogs/KF5KIO/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kfileitemtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/399)66%
(264/399)54%
(32970/60662)39%
(16861/43765)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9306/9772)48%
(4287/9015)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8446/14442)51%
(4696/9223)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)54%
(4346/8049)40%
(1877/4697)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(572/1080)39%
(343/888)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4291)35%
(1294/3672)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
   

D17857: DocumentPrivate: Don't jump view when edit using 'scroll past last line'

[loh tar]

loh.tar added a comment.


  Looks to me a call to KateLayoutCache::updateViewCache may help at some point.
  But have no idea where to place and with which parms. 
  In KateLayoutCache::displayViewLine is "limit=0" on second call.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17857

To: loh.tar, #ktexteditor, cullmann, dhaumann
Cc: swestersund, cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, domson, michaelh, ngraham, bruns, demsking, sars

D20513: Remove last traces of KFileMetaDataWidget from information panel

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> filemetadataconfigurationdialog.h:35
>   * @brief Dialog which allows to configure which meta data should be shown
>   *in the KFileMetaDataWidget.
>   */

Can you please also update this comment? It should mention 
`Baloo::FileMetaDataWidget`.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D20513

To: bruns, #frameworks, apol, ngraham, #dolphin
Cc: elvisangelaccio, kfm-devel, alexde, feverfew, meven, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, mikesomov

D20524: [FileMetaDataWidget] Allow inline configuration of visible properties

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> filemetadatawidget.cpp:53
>  {
> +QCheckBox* check;
>  QLabel* label;

I'd call it `checkBox` for better clarity.

> filemetadatawidget.cpp:113-114
>  row.value->deleteLater();
> +if (row.check)
> +row.check->deleteLater();
>  }

Missing braces

> filemetadatawidget.h:47-49
> +ReStart = 0,
> +Accept,
> +Cancel

Can you add some apidox for this enum? In particular, it's not so clear what 
`ReStart` is used for.

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D20524

To: bruns, #baloo, #dolphin, #frameworks, ngraham, astippich
Cc: elvisangelaccio, gennad, domson, ashaposhnikov, astippich, spoorun, abrahams

D20534: avoid conflicting shortcuts for switching tabs

[Christoph Cullmann]

cullmann created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
cullmann requested review of this revision.

REVISION SUMMARY
  use ALT + Home/End for top/bottom of view

REPOSITORY
  R39 KTextEditor

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20534

AFFECTED FILES
  src/view/kateview.cpp

To: cullmann
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D20523: Remove a dead declaration

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R824:c51ec36cee75: Remove a dead declaration (authored by 
bruns).

REPOSITORY
  R824 Baloo Widgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20523?vs=56165=56186

REVISION DETAIL
  https://phabricator.kde.org/D20523

AFFECTED FILES
  src/filemetadatawidget.cpp

To: bruns, #baloo, #frameworks, ngraham, astippich, elvisangelaccio
Cc: gennad, domson, ashaposhnikov, astippich, spoorun, abrahams

D20534: avoid conflicting shortcuts for switching tabs

[Christoph Cullmann]

cullmann added reviewers: Kate, ngraham, dhaumann.
cullmann added a comment.


  Ok with that?
  
  Follow up of https://phabricator.kde.org/D7497

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20534

To: cullmann, #kate, ngraham, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D20513: Remove last traces of KFileMetaDataWidget from information panel

[Stefan Brüns]

bruns marked an inline comment as done.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D20513

To: bruns, #frameworks, apol, ngraham, #dolphin
Cc: elvisangelaccio, kfm-devel, alexde, feverfew, meven, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, mikesomov

D20513: Remove last traces of KFileMetaDataWidget from information panel

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R318:05a4d27813e3: Remove last traces of KFileMetaDataWidget 
from information panel (authored by bruns).

REPOSITORY
  R318 Dolphin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20513?vs=56192=56193

REVISION DETAIL
  https://phabricator.kde.org/D20513

AFFECTED FILES
  src/panels/information/filemetadataconfigurationdialog.h
  src/panels/information/informationpanelcontent.h

To: bruns, #frameworks, apol, ngraham, #dolphin, elvisangelaccio
Cc: elvisangelaccio, kfm-devel, alexde, feverfew, meven, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, mikesomov

D20513: Remove last traces of KFileMetaDataWidget from information panel

[Elvis Angelaccio]

elvisangelaccio accepted this revision.
elvisangelaccio added a comment.
This revision is now accepted and ready to land.


  Thanks

REPOSITORY
  R318 Dolphin

BRANCH
  arcpatch-D20513

REVISION DETAIL
  https://phabricator.kde.org/D20513

To: bruns, #frameworks, apol, ngraham, #dolphin, elvisangelaccio
Cc: elvisangelaccio, kfm-devel, alexde, feverfew, meven, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, mikesomov

D20525: [InformationPanel] Use the new inline configuration mode

[Stefan Brüns]

bruns updated this revision to Diff 56194.
bruns added a comment.


  rebase

REPOSITORY
  R318 Dolphin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20525?vs=56168=56194

BRANCH
  cleanup

REVISION DETAIL
  https://phabricator.kde.org/D20525

AFFECTED FILES
  src/CMakeLists.txt
  src/panels/information/filemetadataconfigurationdialog.cpp
  src/panels/information/filemetadataconfigurationdialog.h
  src/panels/information/informationpanel.cpp
  src/panels/information/informationpanelcontent.cpp
  src/panels/information/informationpanelcontent.h

To: bruns, #dolphin, #baloo, #frameworks, ngraham, astippich
Cc: meven, kfm-devel, alexde, feverfew, spoorun, navarromorales, firef, 
andrebarros, emmanuelp, mikesomov

D20536: Use consistent default Kickoff user icon

[Björn Feber]

GB_2 updated this revision to Diff 56196.
GB_2 added a comment.


  Use symlinks instead of copying the icons

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20536?vs=56195=56196

BRANCH
  use-consistent-default-kickoff-user-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20536

AFFECTED FILES
  icons-dark/applets/22/user-identity.svg
  icons/applets/22/user-identity.svg

To: GB_2, #plasma, #vdg
Cc: #vdg, kde-frameworks-devel, #plasma, michaelh, ngraham, bruns

D17857: DocumentPrivate: Don't jump view when edit using 'scroll past last line'

[loh tar]

loh.tar added a comment.


  Yes! A short test looked very promising.
  Will play a little more, because had done some changes to this patch here :-/

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17857

To: loh.tar, #ktexteditor, cullmann, dhaumann
Cc: swestersund, cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, domson, michaelh, ngraham, bruns, demsking, sars

D20529: add license to python test files

[Stefan Brüns]

bruns added a subscriber: bcooksley.
bruns added a comment.


  @bcooksley - these tests currently fail to run under Windows: 
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5 
WindowsMSVCQt5.11/149/testReport
  
  > "C:/CI/workspace/Frameworks/kfilemetadata/kf5-qt5 
WindowsMSVCQt5.11/build/autotests/../autotests/samplefiles/testexternalextractor/main.py"
 failed to start: "Process failed to start: Unknown error 0x00c1."
  
  Apparently the python installation is "incomplete". I see two possible 
options, either install the missing python parts, or just disable the test on 
Windows. As the test is not really crucial, I would be fine with the second 
option.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20529

To: astippich, bruns
Cc: bcooksley, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20524: [FileMetaDataWidget] Allow inline configuration of visible properties

[Stefan Brüns]

bruns edited the summary of this revision.

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D20524

To: bruns, #baloo, #dolphin, #frameworks, ngraham, astippich
Cc: elvisangelaccio, gennad, domson, ashaposhnikov, astippich, spoorun, abrahams

D20530: Fix signed/unsigned warning after statx change

[David Faure]

dfaure closed this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20530

To: dfaure, meven, fvogt, bruns
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

Re: New framework: KCalCore

[David Faure]

On dimanche 7 avril 2019 14:45:09 CEST Volker Krause wrote:
> Hi,
> 
> I'd like to propose KCalCore for review to move from KDE PIM to KF5.
> 
> KCalCore is an implementation of the iCalendar standard based on libical,

I wonder about the name, which doesn't mean much outside the circle of PIM 
people. Shouldn't this be called KCalendar ?

If the "Core" simply means non-GUI, we certainly don't have that word in every 
non-GUI framework.

> covering the data model, input/output and the rather complex recurrence
> algorithms defined in that standard. It's used outside of KDE PIM as well,
> e.g. by Zanshin or the Plasma Mobile calendar app.

This makes me wonder: where does that mobile calendar app get the events from?
Akonadi? (then it still depends on kde/pim/*, and this move in itself doesn't 
really remove the unwanted workspace->apps dependency?)

Zanshin does use akonadi (though one could imagine a mobile version that only 
uses KDav and KCalCore^H^H^H KCalendar).


Some review:

icalformat_p.h://TODO: KDE5, move this implementation to icalformat_p.cpp
incidencebase.h: * // TODO_KDE5: Provide a virtual serialize() method, as done 
with assign() and equals().
incidencebase.h: * // TODO_KDE5: Provide a virtual serialize() method, as done 
with assign() and equals().
person.h:// TODO_KDE5: FIXME: This operator does slicing,if the object is 
in fact one of the derived classes (Attendee)

This would be the perfect time to make these changes, if they are valid.

Allen, the first TODO above is from you (commit efe923294b4d7).
I don't get it, this is a _p.h file (i.e. no SC/BC guarantees), why not just 
outline the method if you wanted to?

The "TODO: KDE5:" in calendar.h however looks like pie-in-the-sky wishful 
thinking, but maybe the suggestion
about merging some virtual methods makes sense, I don't know.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

D20524: [FileMetaDataWidget] Allow inline configuration of visible properties

[Elvis Angelaccio]

elvisangelaccio added a comment.


  Hmm, it seems you need to rebase this patch:
  
$ arc patch D20524
 INFO  Base commit is not in local repository; trying to fetch.
Created and checked out branch arcpatch-D20524.


This diff is against commit b26a3680b04cb9877721d693eb79ccb321fe40aa, 
but
the commit is nowhere in the working copy. Try to apply it against the
current working copy state? (49e778edf7bd70842879cc338fb85c1a178ecf7f)
[Y/n] Y
  
  ( I tried to apply it on current master)

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D20524

To: bruns, #baloo, #dolphin, #frameworks, ngraham, astippich
Cc: elvisangelaccio, gennad, domson, ashaposhnikov, astippich, spoorun, abrahams

D17857: DocumentPrivate: Don't jump view when edit using 'scroll past last line'

[Christoph Cullmann]

cullmann added a comment.


  Ok, I can reproduce the issue you mention.
  I will take a look.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17857

To: loh.tar, #ktexteditor, cullmann, dhaumann
Cc: swestersund, cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, domson, michaelh, ngraham, bruns, demsking, sars

D17857: DocumentPrivate: Don't jump view when edit using 'scroll past last line'

[Christoph Cullmann]

cullmann added a comment.


  Please try if my last commit fixed that:
  
  
https://cgit.kde.org/ktexteditor.git/commit/?id=a9f97f1be115c1e4ede391b6d3d5e2aed6350992

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17857

To: loh.tar, #ktexteditor, cullmann, dhaumann
Cc: swestersund, cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, domson, michaelh, ngraham, bruns, demsking, sars

D20495: KateIconBorder: Fix folding popup width and height

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Works ok for me.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20495

To: loh.tar, #ktexteditor, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D20495: KateIconBorder: Fix folding popup width and height

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:4396efe1cdce: KateIconBorder: Fix folding popup width and 
height (authored by cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20495?vs=56071=56184

REVISION DETAIL
  https://phabricator.kde.org/D20495

AFFECTED FILES
  src/view/kateviewhelpers.cpp

To: loh.tar, #ktexteditor, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D20513: Remove last traces of KFileMetaDataWidget from information panel

[Stefan Brüns]

bruns updated this revision to Diff 56192.
bruns added a comment.


  remove one more reference in comments

REPOSITORY
  R318 Dolphin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20513?vs=56152=56192

BRANCH
  arcpatch-D20513

REVISION DETAIL
  https://phabricator.kde.org/D20513

AFFECTED FILES
  src/panels/information/filemetadataconfigurationdialog.h
  src/panels/information/informationpanelcontent.h

To: bruns, #frameworks, apol, ngraham, #dolphin
Cc: elvisangelaccio, kfm-devel, alexde, feverfew, meven, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, mikesomov

D20513: Remove last traces of KFileMetaDataWidget from information panel

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in filemetadataconfigurationdialog.h:35
> Can you please also update this comment? It should mention 
> `Baloo::FileMetaDataWidget`.

Good catch ...

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D20513

To: bruns, #frameworks, apol, ngraham, #dolphin, elvisangelaccio
Cc: elvisangelaccio, kfm-devel, alexde, feverfew, meven, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, mikesomov

D20536: Use consistent default Kickoff user icon

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  Add the 22px default user icon that is used everywhere else.
  F6771466: Consistent Default Kickoff User Icon.png 


TEST PLAN
  Open Kickoff.

REPOSITORY
  R266 Breeze Icons

BRANCH
  use-consistent-default-kickoff-user-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20536

AFFECTED FILES
  icons-dark/applets/22/user-identity.svg
  icons/applets/22/user-identity.svg

To: GB_2, #plasma, #vdg
Cc: #vdg, kde-frameworks-devel, #plasma, michaelh, ngraham, bruns

D17857: DocumentPrivate: Don't jump view when edit using 'scroll past last line'

[Christoph Cullmann]

cullmann added a comment.


  :=) Nice that it helps.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17857

To: loh.tar, #ktexteditor, cullmann, dhaumann
Cc: swestersund, cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, domson, michaelh, ngraham, bruns, demsking, sars

D20525: [InformationPanel] Use the new inline configuration mode

[Stefan Brüns]

bruns edited the summary of this revision.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D20525

To: bruns, #dolphin, #baloo, #frameworks, ngraham, astippich
Cc: meven, kfm-devel, alexde, feverfew, spoorun, navarromorales, firef, 
andrebarros, emmanuelp, mikesomov

D20534: avoid conflicting shortcuts for switching tabs

[Christoph Cullmann]

cullmann added a comment.


  Upsa, pushed it with my copyright update :/

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20534

To: cullmann, #kate, ngraham, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D20524: [FileMetaDataWidget] Allow inline configuration of visible properties

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in filemetadatawidget.h:47-49
> Can you add some apidox for this enum? In particular, it's not so clear what 
> `ReStart` is used for.

Sure, just wanted to see if the (UI) design itself is deemed appropriate.

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D20524

To: bruns, #baloo, #dolphin, #frameworks, ngraham, astippich
Cc: elvisangelaccio, gennad, domson, ashaposhnikov, astippich, spoorun, abrahams

D20534: avoid conflicting shortcuts for switching tabs

[Christoph Cullmann]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:9f2ffd36c587: avoid conflicting shortcuts for switching 
tabs (authored by cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20534?vs=56185=56198

REVISION DETAIL
  https://phabricator.kde.org/D20534

AFFECTED FILES
  src/view/kateview.cpp

To: cullmann, #kate, ngraham, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D20528: Change properties attributes for consistency

[Stefan Brüns]

bruns accepted this revision.
bruns added a comment.
This revision is now accepted and ready to land.


  10 lines removed, 1 added, 10 times more functionality 

REPOSITORY
  R286 KFileMetaData

BRANCH
  properties_consistency

REVISION DETAIL
  https://phabricator.kde.org/D20528

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D17857: DocumentPrivate: Don't jump view when edit using 'scroll past last line'

[loh tar]

loh.tar added a comment.


  Did anyone tried this patch?
  While coding my focus was only on behavior while enter text. Now I notice 
that the folding is "broken" in a way that the view jumps to the bottom :-S
  
  First digging indicate that makeVisible(..) is called twice, and the second 
time reported  cache()->displayViewLine(..) "out of view" which is pretty 
surprising. The given cursor position is the same.
  Will look at this later this day.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17857

To: loh.tar, #ktexteditor, cullmann, dhaumann
Cc: swestersund, cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, domson, michaelh, ngraham, bruns, demsking, sars

D17857: DocumentPrivate: Don't jump view when edit using 'scroll past last line'

[Christoph Cullmann]

cullmann added a comment.


  Didn't try folding :)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17857

To: loh.tar, #ktexteditor, cullmann, dhaumann
Cc: swestersund, cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, domson, michaelh, ngraham, bruns, demsking, sars

D19445: Handle variant list in formatting functions

[Alexander Stippich]

astippich added a dependent revision: D20528: Change properties attributes for 
consistency.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D19445

To: astippich, ngraham, bruns
Cc: apol, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20529: add license to python test files

[Alexander Stippich]

astippich created this revision.
astippich added a reviewer: bruns.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  silence EBN

REPOSITORY
  R286 KFileMetaData

BRANCH
  py_license

REVISION DETAIL
  https://phabricator.kde.org/D20529

AFFECTED FILES
  autotests/samplefiles/testexternalextractor/main.py
  autotests/samplefiles/testexternalwriter/main.py

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20523: Remove a dead declaration

[Alexander Stippich]

astippich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R824 Baloo Widgets

BRANCH
  cleanup

REVISION DETAIL
  https://phabricator.kde.org/D20523

To: bruns, #baloo, #frameworks, ngraham, astippich
Cc: gennad, domson, ashaposhnikov, astippich, spoorun, abrahams

D20528: Change properties attributes for consistency

[Alexander Stippich]

astippich created this revision.
astippich added a reviewer: bruns.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  Move all the handling of (string-)lists into
  the member function, and mark the attributes
  consistently.

REPOSITORY
  R286 KFileMetaData

BRANCH
  properties_consistency

REVISION DETAIL
  https://phabricator.kde.org/D20528

AFFECTED FILES
  autotests/taglibextractortest.cpp
  src/formatstrings.cpp
  src/formatstrings_p.h
  src/propertyinfo.cpp

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20209: Add support for KBookmarkOwner to communicate if it has tabs open

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> hallas wrote in kbookmarkowner.h:120
> Good point (both of them)
> 
> What are our binary compatibility promises? Is //every// version of 
> frameworks always binary backwards compatible? Or do we have a window every 
> now and then where we can make source compatible changes but not binary 
> compatible? I don't mind changing this to be using settings and getters, but 
> that just makes this API stand out from the rest. All the other APIs in the 
> class are virtual functions which should be overwritten by the actual owner. 
> I know this does not argue against our binary compatible promise though :D

Every version of KF5 is source and binary compatible (just like Qt5).
The next time for a possible BC breakage will be KF6 (when Qt6 comes out), so 
not just yet.

Two alternative solutions:

- creating a KBookmarkOwnerV2 interface, deriving from KBookmarkOwner. This is 
a typical solution for extending interfaces, but it's somewhat cumbersome (ugly 
name, downcasting...).
- adding a getter/setter to another class where it would make more sense, maybe 
KBookmarkMenu? Would the app that you have in mind, have access to it?

REPOSITORY
  R294 KBookmarks

REVISION DETAIL
  https://phabricator.kde.org/D20209

To: hallas, #frameworks, ngraham, cfeck, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20523: Remove a dead declaration

[Elvis Angelaccio]

elvisangelaccio accepted this revision.

REPOSITORY
  R824 Baloo Widgets

BRANCH
  cleanup

REVISION DETAIL
  https://phabricator.kde.org/D20523

To: bruns, #baloo, #frameworks, ngraham, astippich, elvisangelaccio
Cc: gennad, domson, ashaposhnikov, astippich, spoorun, abrahams

D20530: Fix signed/unsigned warning after statx change

[Méven Car]

meven accepted this revision.
meven added a comment.
This revision is now accepted and ready to land.


  Thanks !
  
  To have statx you need glibc 2.28 (released last august) and linux 4.11 even 
older.
  Debian stable has glibc 2.19...

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20530

To: dfaure, meven, fvogt, bruns
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20526: fix extracting of some properties to match what was writen

[Matthieu Gallien]

mgallien created this revision.
mgallien added reviewers: astippich, bruns.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
mgallien requested review of this revision.

REVISION SUMMARY
  Currently, one can write and read through taglib extractor and writer
  plugins. Unfortunately, some "smart" transformation on the data are
  applied when reading them. This does not allow to read exactly what was
  writen.
  
  This is a work in progress to shed some light on what is needed to get Elisa 
to support reading and writing of properties through KFileMetaData.
  
  This is somehow linked to D19087  and 
D20502  .

TEST PLAN
  New automatic test is OK, no regressions.

REPOSITORY
  R286 KFileMetaData

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20526

AFFECTED FILES
  autotests/taglibwritertest.cpp
  autotests/taglibwritertest.h
  src/extractors/taglibextractor.cpp

To: mgallien, astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20519: Fix double delete on broken files

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Good catch.
  I'd still prefer if such changes would come with a unittest, because it will 
be hard otherwise to immediately detect (while developing) that changes don't 
introduce any regressions.
  I managed to write a unittest for this one, please integrate it into your 
commit:
  
  http://www.davidfaure.fr/2019/ktar_unittest.diff
  http://www.davidfaure.fr/2019/tar_emptyfile_missingdir.tar.gz
  
  The tar file was created like this (this info should go into the commit log)
  
  mkdir dir
  touch dir/foo
  tar cf tar_emptyfile_missingdir.tar dir/foo
  rm -f dir/foo
  mkdir dir/foo
  touch dir/foo/file
  tar rf tar_emptyfile_missingdir.tar dir/foo/file
  gzip tar_emptyfile_missingdir.tar

INLINE COMMENTS

> karchive.cpp:77
> +
> +// Returns in containingDirectory the directory that actually contains 
> the returned entry
> +const KArchiveEntry *entry(const QString &_name, KArchiveDirectory 
> **containingDirectory) const

A cleaner solution is to return a small struct with the two things we want to 
return.
This would also remove the need for a "dummy" variable.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D20519

To: aacid, dfaure
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D20529: add license to python test files

[Stefan Brüns]

bruns accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  py_license

REVISION DETAIL
  https://phabricator.kde.org/D20529

To: astippich, bruns
Cc: bcooksley, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19445: Handle variant list in formatting functions

[Stefan Brüns]

bruns accepted this revision.
bruns added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> propertyinfotest.cpp:91
>  { Property::BitRate,   true,  1470,
> QStringLiteral("14.7 Mbit/s")},
> +{ Property::BitRate,   true,  bitRateList, 
> QStringLiteral("128 kbit/s and 130 kbit/s")},
>  { Property::ImageOrientation,  true,  5,   
> QStringLiteral("Transposed")},

That one looks strange :-P

REPOSITORY
  R286 KFileMetaData

BRANCH
  generic_display_list

REVISION DETAIL
  https://phabricator.kde.org/D19445

To: astippich, ngraham, bruns
Cc: apol, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20526: fix extracting of some properties to match what was writen

[Stefan Brüns]

bruns added a comment.


  In D20526#449560 , @astippich 
wrote:
  
  > IMHO for searching, the separation from a single string into multiple 
entries is the best thing to do, from a metadata editing point of view not so 
much.
  >  How about inserting the TStringList entry by entry, without using the 
contactsFromString method? That would maintain the exact representation of 
metadata tags also for the baloo database.
  
  
  When searching is left to baloo, it already splits up strings at whitespace 
etc., so you can provide the string as is.
  
  As far as I can see, in some cases (e.g. "ARTIST"), the `Taglib::StringList 
PropertyMap::operator[]` is first joined (`.toString(';')`) and then split 
again. How about avoiding that in the first place?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20526

To: mgallien, astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20525: [InformationPanel] Use the new inline configuration mode

[Nathaniel Graham]

ngraham added a reviewer: VDG.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D20525

To: bruns, #dolphin, #baloo, #frameworks, ngraham, astippich, #vdg
Cc: meven, kfm-devel, alexde, feverfew, spoorun, navarromorales, firef, 
andrebarros, emmanuelp, mikesomov

D20524: [FileMetaDataWidget] Allow inline configuration of visible properties

[Nathaniel Graham]

ngraham added a comment.


  In D20524#449668 , 
@elvisangelaccio wrote:
  
  > Hmm, it seems you need to rebase this patch:
  
  
  Worked for me:
  
 INFO  Base commit is not in local repository; trying to fetch.
Created and checked out branch arcpatch-D20524.


This diff is against commit b26a3680b04cb9877721d693eb79ccb321fe40aa, 
but
the commit is nowhere in the working copy. Try to apply it against the
current working copy state? (5f2ab5c62dd56e5a1dae468355c9e72d84d94398)
[Y/n] y

Checking patch src/filemetadatawidget.h...
Checking patch src/filemetadatawidget.cpp...
Applied patch src/filemetadatawidget.h cleanly.
Applied patch src/filemetadatawidget.cpp cleanly.
 OKAY  Successfully committed patch.

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D20524

To: bruns, #baloo, #dolphin, #frameworks, ngraham, astippich
Cc: elvisangelaccio, gennad, domson, ashaposhnikov, astippich, spoorun, abrahams

D20284: Fix l/100 km to MPG conversion

[Michal Malý]

madcatx marked 2 inline comments as done.
madcatx added inline comments.

INLINE COMMENTS

> aacid wrote in fuel_efficiency.cpp:36
> I understand what you mean here, but i don't think that reciprocal is the 
> word that describes this (are you a native speaker? if so maybe it's juts 
> that my english is bad :D)
> 
> Oh, it's actually called reciprocal number too, i think here we use the 
> inverse naming for it https://en.wikipedia.org/wiki/Multiplicative_inverse
> 
> Maybe naming it "m_isReciprocaltoDefaultUnit" would make it understand? i.e. 
> makes it clear that that value is in relation to the default unit?

Direct translation from my native language would be "inverse" too, although 
somehow I prefer the word "reciprocal" as it feels less ambiguous. (People may 
perceive "inversion" in multiple ways but "reciprocity" has a pretty solid 
definition as far as math goes... IMHO :) )

Regardless, I changed the name and added an explanatory comment.

REPOSITORY
  R292 KUnitConversion

REVISION DETAIL
  https://phabricator.kde.org/D20284

To: madcatx, broulik, #frameworks, aacid
Cc: apol, aacid, meven, kde-frameworks-devel, michaelh, ngraham, bruns

D20524: [FileMetaDataWidget] Allow inline configuration of visible properties

[Stefan Brüns]

bruns added a comment.


  In D20524#449784 , @ngraham wrote:
  
  > In D20524#449668 , 
@elvisangelaccio wrote:
  >
  > > Hmm, it seems you need to rebase this patch:
  >
  >
  > Worked for me:
  >
  >INFO  Base commit is not in local repository; trying to fetch.
  >   Created and checked out branch arcpatch-D20524.
  >  
  >  
  >   This diff is against commit b26a3680b04cb9877721d693eb79ccb321fe40aa, 
but
  >   the commit is nowhere in the working copy. Try to apply it against the
  >   current working copy state? (5f2ab5c62dd56e5a1dae468355c9e72d84d94398)
  >   [Y/n] y
  >  
  >   Checking patch src/filemetadatawidget.h...
  >   Checking patch src/filemetadatawidget.cpp...
  >   Applied patch src/filemetadatawidget.h cleanly.
  >   Applied patch src/filemetadatawidget.cpp cleanly.
  >OKAY  Successfully committed patch.
  >
  
  
  I have some debug output lower in the commit stack, which is likely 
responsible for the SHA hash mismatch, although it should apply with just the 
warning.
  
  Note, D20523  was commited in the mean 
time.

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D20524

To: bruns, #baloo, #dolphin, #frameworks, ngraham, astippich
Cc: elvisangelaccio, gennad, domson, ashaposhnikov, astippich, spoorun, abrahams

D20542: Retitle button "Close" to "Close file" when a file has been removed on disk

[Méven Car]

meven created this revision.
meven added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
meven requested review of this revision.

REVISION SUMMARY
  CCBUG: 406305

REPOSITORY
  R39 KTextEditor

BRANCH
  close-file

REVISION DETAIL
  https://phabricator.kde.org/D20542

AFFECTED FILES
  src/dialogs/katedialogs.cpp

To: meven, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D20284: Fix l/100 km to MPG conversion

[Albert Astals Cid]

This revision was automatically updated to reflect the committed changes.
Closed by commit R292:bc7495095baa: Fix l/100 km to MPG conversion (authored by 
madcatx, committed by aacid).

REPOSITORY
  R292 KUnitConversion

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20284?vs=56203=56215

REVISION DETAIL
  https://phabricator.kde.org/D20284

AFFECTED FILES
  autotests/convertertest.cpp
  src/fuel_efficiency.cpp

To: madcatx, broulik, #frameworks, aacid
Cc: apol, aacid, meven, kde-frameworks-devel, michaelh, ngraham, bruns

D20510: SvgItem, IconItem: drop "smooth" property override, update node on change

[Friedrich W. H. Kossebau]

kossebau added a comment.


  A good example to see how the smooth property was broken is the animation of 
the analog clock's hands (best enable second hand to see often):
  the Hand.qml has "smooth: !anim.running" set as property for the SvgItem. 
Without this patch, the hand during animation looks fine. With this patch, the 
hand looks very unsmooth during animation.
  
  As aftermath I would actually do a patch to change this to "smooth: true", 
given it looks quite bad and no-one before complained about resource issues, so 
this once intended optimization seems unneeded now.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20510

To: kossebau, #plasma, davidedmundson, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20284: Fix l/100 km to MPG conversion

[Michal Malý]

madcatx updated this revision to Diff 56201.
madcatx added a comment.


  Added an inverse test with initial value in MPG

REPOSITORY
  R292 KUnitConversion

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20284?vs=55574=56201

REVISION DETAIL
  https://phabricator.kde.org/D20284

AFFECTED FILES
  autotests/convertertest.cpp
  src/fuel_efficiency.cpp

To: madcatx, broulik, #frameworks, aacid
Cc: apol, aacid, meven, kde-frameworks-devel, michaelh, ngraham, bruns

D20284: Fix l/100 km to MPG conversion

[Michal Malý]

madcatx updated this revision to Diff 56203.
madcatx added a comment.


  More obvious explanation of the meaning of `m_isReciprocal`

REPOSITORY
  R292 KUnitConversion

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20284?vs=56201=56203

REVISION DETAIL
  https://phabricator.kde.org/D20284

AFFECTED FILES
  autotests/convertertest.cpp
  src/fuel_efficiency.cpp

To: madcatx, broulik, #frameworks, aacid
Cc: apol, aacid, meven, kde-frameworks-devel, michaelh, ngraham, bruns

D20525: [InformationPanel] Use the new inline configuration mode

[Nathaniel Graham]

ngraham added a comment.


  +1, this is a much nicer UI. Some of the text gets cut off horizontally 
though when the panel is narrow:
  
  F6771538: Screenshot_20190414_081327.png 

  
  I imagine it would be even worse in German or with a Romance language. Maybe 
in edit mode, you can just show the properties and not their values as well?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D20525

To: bruns, #dolphin, #baloo, #frameworks, ngraham, astippich, #vdg
Cc: meven, kfm-devel, alexde, feverfew, spoorun, navarromorales, firef, 
andrebarros, emmanuelp, mikesomov