D27695: WIP: Create a new TopArea element using widgets/toparea svg

[Marco Martin]

mart added a comment.


  I would call the component PlasmoidHeading, to make clear it's only for use 
in plasmoids

INLINE COMMENTS

> TopArea.qml:28
> +
> +property bool flipped: false
> + 

enum Location {

  Header,
  Footer

(maybe a middle as well?)

  }

property Location location

> TopArea.qml:30
> + 
> +Layout.fillWidth: true
> +Layout.bottomMargin: flipped ? 0 : topAreaSvg.margins.top

shouldn't assume it's in a layout..
maybe keep Layout.fillwidth to keep it compact, layout margins shouldn't be 
necessary.

> TopArea.qml:37
> +
> +leftInset: -topAreaSvg.margins.left
> +rightInset: -topAreaSvg.margins.right

topAreaSvg.fixedMargins so works also when you disable them

> TopArea.qml:43
> +background: PlasmaCore.FrameSvgItem {
> +id: topAreaSvg
> +imagePath: "test"

you can check for headers:
plasmoid.location === Plasmacore.Types.TopEdge and disable the top border

same thing for footers, disabling bottom edge when 
plasmoid.location === Plasmacore.Types.BottomEdge

> TopArea.qml:44
> +id: topAreaSvg
> +imagePath: "test"
> +prefix: flipped? 'flipped' : ''

"plasmoidheading" svg name

> TopArea.qml:45
> +imagePath: "test"
> +prefix: flipped? 'flipped' : ''
> +}

prefixes as "header" and "footer"

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27695

To: niccolove, mart
Cc: davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27807: Changed style of pressed list item to be consistent

[Noah Davis]

ndavis added a comment.


  Wouldn't it make more sense to use different pressed and hovered states 
instead of designing the pressed state to be used as a hover state because the 
hover state isn't used? Also, it's strange that listitem.svg and viewitem.svg 
both exist and are both used for similar purposes. Do you know why they are 
both used?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27807

To: niccolove, #vdg, #plasma
Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27807: Changed style of pressed list item to be consistent

[Nathaniel Graham]

ngraham added a comment.


  In D27807#621347 , @ndavis wrote:
  
  > It's strange that the plasma-devel mailing list isn't automatically added, 
even when it's a reviewer group.
  
  
  Because then people who are both subscribed to the mailing list and also 
members/watchers of the #plasma  group 
get two emails for every comment/change/update/etc.
  
  Anyway, it seems like we generally need to rethink these states. I think 
KRunner should be used as the model for how to have both visually distinct and 
visually pleasing hovered and pressed states.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27807

To: niccolove, #vdg, #plasma
Cc: ngraham, plasma-devel, ndavis, kde-frameworks-devel, LeGast00n, cblack, 
GB_2, michaelh, bruns

D27802: smb: fix ipv6 support

[Thiago Macieira]

thiago added a comment.


  STD3 also forbids domain labels ending in dash, so can you add a test for 
`smb://[fe80::]/` too? You'll need to adjust your code

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27802

To: sitter, ngraham
Cc: thiago, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27810: Correctly disable UDS_ACCESS being set

[David Edmundson]

davidedmundson edited the test plan for this revision.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27810

To: davidedmundson, sitter, feverfew
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.12 - Build # 100 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.12/100/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 03 Mar 2020 18:47:30 +
 Build duration:
4 min 21 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: projectroot.tests.ECMPoQmToolsTestName: projectroot.tests Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.tests.ECMAddTests Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.13 - Build # 66 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.13/66/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Tue, 03 Mar 2020 18:47:30 +
 Build duration:
3 min 56 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: projectroot.tests.ECMPoQmToolsTestName: projectroot.tests Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.tests.ECMAddTests Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

D27767: [ModifiedFileIndexer] Correct time checks for new files

[Alexander Stippich]

astippich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D27767

To: bruns, #baloo, ngraham, astippich
Cc: astippich, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, spoorun, ngraham, bruns, 
abrahams

D27464: Add application menu dbus paths to org_kde_plasma_window interface

[Carson Black]

cblack added a comment.


  @zzag does anything else look off to you?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27464

To: cblack, #kwin, zzag, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27767: [ModifiedFileIndexer] Correct time checks for new files

[Alexander Stippich]

astippich added a comment.


  I would like to request a clear answer for https://phabricator.kde.org/D25517 
once again

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D27767

To: bruns, #baloo, ngraham, astippich
Cc: astippich, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, spoorun, ngraham, bruns, 
abrahams

D27463: KconfigXT: Add a value attribute to Enum field choices

[Méven Car]

meven updated this revision to Diff 76866.
meven added a comment.


  Improve naming, fix case of normal entries, adding a test for this case

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27463?vs=76856=76866

BRANCH
  arcpatch-D27463_1

REVISION DETAIL
  https://phabricator.kde.org/D27463

AFFECTED FILES
  autotests/kconfig_compiler/test4.cpp.ref
  autotests/kconfig_compiler/test4.kcfg
  autotests/kconfig_compiler/test5.cpp.ref
  autotests/kconfig_compiler/test5.kcfg
  src/core/kcoreconfigskeleton.cpp
  src/core/kcoreconfigskeleton.h
  src/kconfig_compiler/KConfigCommonStructs.h
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigXmlParser.cpp
  src/kconfig_compiler/README.dox
  src/kconfig_compiler/kcfg.xsd

To: meven, ervin, bport, crossi, #frameworks
Cc: ngraham, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27463: KconfigXT: Add a value attribute to Enum field choices

[Méven Car]

meven added a comment.


  I fixed an issue when testing this with D27477 
 and it is fixed and the issue it revealed 
is tested.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27463

To: meven, ervin, bport, crossi, #frameworks
Cc: ngraham, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27807: Changed style of pressed list item to be consistent

[Noah Davis]

ndavis added a subscriber: plasma-devel.
ndavis added a comment.


  It's strange that the plasma-devel mailing list isn't automatically added, 
even when it's a reviewer group.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27807

To: niccolove, #vdg, #plasma
Cc: plasma-devel, ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27810: Correctly disable UDS_ACCESS being set

[David Edmundson]

davidedmundson added reviewers: sitter, feverfew.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27810

To: davidedmundson, sitter, feverfew
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27810: Correctly disable UDS_ACCESS being set

[David Edmundson]

davidedmundson created this revision.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  718abcb69b78385123dd7a05a66a656af772d581 
 
tries to disable UDS_ACCESS
  being set. See the long comment introduced.
  
  It did this by setting the value to -1 which doesn't achieve that
  result.
  
  -1 is a perfectly valid value that gets send to the client.
  
  Having it set breaks anyone calling udsEntry.numberValue(UDS_ACCESS,
  aLegitimateDefault) getting their default. Something used by kio-fuse.

TEST PLAN
  Used kio-fuse
  Opened a samba file in mplayer
  It opened

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27810

AFFECTED FILES
  smb/kio_smb_browse.cpp

To: davidedmundson
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27810: Correctly disable UDS_ACCESS being set

[Harald Sitter]

sitter accepted this revision.
sitter added a comment.
This revision is now accepted and ready to land.


  I am pretty sure I picked that up somewhere, might be worth asking lxr for 
possible other places we set ACCESS to -1

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27810

To: davidedmundson, sitter, feverfew
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D25388: Make constructor explicit and cleanup QWebPluginFactory #include.

[John Hayes]

jhayes abandoned this revision.

REPOSITORY
  R300 KDEWebKit

REVISION DETAIL
  https://phabricator.kde.org/D25388

To: jhayes
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27766: [ModifiedFileIndexer] Omit BasicIndexingJob run when not required

[Alexander Stippich]

astippich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D27766

To: bruns, #baloo, ngraham, astippich
Cc: anthonyfieroni, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, 
cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D27811: [KConfigGui] Check font weight when clearing styleName property

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure, davidedmundson, cfeck, ervin, 
meven.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  This is an addendum for commit a2774ff5b41987c3919a9e 
; 
making the check
  tighter.

TEST PLAN
  make && ctest

REPOSITORY
  R237 KConfig

BRANCH
  l-kconfiggui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27811

AFFECTED FILES
  src/gui/kconfiggroupgui.cpp

To: ahmadsamir, #frameworks, dfaure, davidedmundson, cfeck, ervin, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26749: Support NDK r20 and Qt 5.14

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:c9ebd3917e59: Support NDK r20 and Qt 5.14 (authored by 
vkrause).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26749?vs=73822=76876

REVISION DETAIL
  https://phabricator.kde.org/D26749

AFFECTED FILES
  toolchain/Android.cmake
  toolchain/ECMAndroidDeployQt.cmake
  toolchain/deployment-file-qt514.json.in

To: vkrause, apol
Cc: flherne, apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, 
GB_2, bencreasy, michaelh, ngraham, bruns

D27152: Introduce FilesystemEntry class

[Stefan Brüns]

bruns requested changes to this revision.
bruns added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> filesystem_entry.cpp:77
> +{
> +return m_type == FilesystemType::Unknown ? m_typeString : 
> FilesystemTypeToString(m_type);
> +}

Why don't you just keep the string?

> fstabdevice.cpp:41
>  m_device.remove(parentUdi() + "/");
> +const FilesystemEntry* fsEntry = 
> FstabHandling::filesystemEntry(m_device);
> +if (fsEntry == nullptr) {

Ircs, raw pointers ... you newer know who owns them ... It is a pointer to an 
entry in a QHash, it may be deleted/moved when you don't expect it.

Unfortunately, std::optional is C++17 only.

Return it by value, return a default constructed instance if no found, and 
compare `fsEntry.device() != m_device`

> fstabhandling.cpp:264
> +}
> +return fstabEntry->mountOptions();
> +}

this looks wrong ...

> fstabhandling.cpp:316
> +if (fstabEntry != globalFstabCache->localData().m_fstabCache.end()) {
> +return &(*fstabEntry);
> +}

this is bad, bad, bad, ...

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D27152

To: hallas, #frameworks, bruns, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27807: Changed style of pressed list item to be consistent

[Niccolò Venerandi]

niccolove created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  The style of pressed- listitem (which is actually often used for hover as 
well, while the hover- listitem is never used afaik) was inconsistent with 
viewitem, such as Kickoff app list (which probably should use listitem, since 
it's a list). This patch makes them look the same, in a much prettier and 
consistent way:

TEST PLAN
  (gimme a sec to upload screenshots)

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  consistentlistitemselected (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27807

AFFECTED FILES
  src/desktoptheme/breeze/widgets/listitem.svg

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

[Niccolò Venerandi]

niccolove updated this revision to Diff 76860.
niccolove added a comment.


  Moved the file to Extra components

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27695?vs=76822=76860

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27695

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/TopArea.qml

To: niccolove, mart
Cc: ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27504: WIP: RFC: smb faster copy to local

[Harald Sitter]

sitter updated this revision to Diff 76865.
sitter added a comment.


  - refine code a bit
  - extend to ::get works same as smbCopyGet. in fact I feel like the two 
functions should be merged. at their hearts they both could read into 
QIODevices (QFile/QBuffer(QBA))
  - use segment class for all transfer use to ultimately replace the xfer_buf 
define with smart calculation of transfer size
  - ::smbCopyPut didn't get any measurable improvement from threading, so I am 
leaving it out for now. having written that the lack of difference may have 
been because HDD IO of the server was saturated so perhaps this deserves 
another look

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27504?vs=76001=76865

BRANCH
  smb-threaded-read

REVISION DETAIL
  https://phabricator.kde.org/D27504

AFFECTED FILES
  smb/CMakeLists.txt
  smb/kio_smb.h
  smb/kio_smb_dir.cpp
  smb/kio_smb_file.cpp
  smb/transfer.h

To: sitter, ngraham, cfeck
Cc: hallas, anthonyfieroni, asturmlechner, kde-frameworks-devel, kfm-devel, 
pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, 
GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, 
ngraham, andrebarros, bruns, emmanuelp, mikesomov

D27804: smb: add hack to support spaces in workgroup names

[Thiago Macieira]

thiago added a comment.


  Looks good, but testing should be extended. I suggest:
  
  1. A workgroup with non-US-ASCII characters in the name, if that's permitted
  2. A workgroup with % in the name: the URL should have "%25"
  3. Roundtrip checking. The test only does toSmbcUrl(), so please test the 
reverse.
  4. Error-checking the conversion from query to hostname: things like %00 (a 
NUL byte), URL delimiters (':', '/', '?' and '#'), byte sequences that do not 
encode UTF-8 (like %FF).
  
  I think that you'll find that % works in one direction only. I have no idea 
what you'll find for #4.

INLINE COMMENTS

> smburl.cpp:134
> +QUrlQuery query(sambaUrl);
> +const QString workgroup = query.queryItemValue("kio-workgroup");
> +if (workgroup.isEmpty()) {

For the % issue, you may want to pass `QUrl::FullyDecoded` as the second 
argument to queryItemValue.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27804

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, thiago, pberestov, iasensio, fprice, 
LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27787: Remove 48px telegram icons

[Noah Davis]

ndavis added a comment.


  In D27787#621050 , @rocka wrote:
  
  > Could we please not remove this icon, or at least keep it available as an 
alternative? It fits the general style so well.
  
  
  The only way to have alternative icons is to make an alternative icon theme 
that uses the alternative icon as its only icon.
  
  This is close enough to being a breeze icon that we really don't need our own 
version of it for now: 
https://raw.githubusercontent.com/telegramdesktop/tdesktop/dev/Telegram/Resources/art/icon512.png
  
  If the desktop client icon changes to an incompatible style, we'll make a new 
breeze telegram icon.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27787

To: ndavis, #vdg
Cc: rocka, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27807: Changed style of pressed list item to be consistent

[Niccolò Venerandi]

niccolove added reviewers: VDG, Plasma.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27807

To: niccolove, #vdg, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27807: Changed style of pressed list item to be consistent

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27807

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27807: Changed style of pressed list item to be consistent

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27807

To: niccolove, #vdg, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

[Niccolò Venerandi]

niccolove added a comment.


  In D27695#621305 , @davidedmundson 
wrote:
  
  > PC3 is designed to be only a theme for QQC2
  
  
  That's why I moved it to plasmaextracomponent with the last commit, actually

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27695

To: niccolove, mart
Cc: davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

[Niccolò Venerandi]

niccolove updated this revision to Diff 76862.
niccolove added a comment.


  Replace test with widgets/toparea

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27695?vs=76860=76862

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27695

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/TopArea.qml

To: niccolove, mart
Cc: davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

[Niccolò Venerandi]

niccolove marked an inline comment as done.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27695

To: niccolove, mart
Cc: davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D23457: Port the search interface from QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir updated this revision to Diff 76852.
ahmadsamir edited the summary of this revision.
ahmadsamir added a comment.


  Modify the extended context menu:
  
  - QRegularExpression supports fixed-length positive/negative lookbehind
  - With QRegularExpression/PCRE, \x escape sequences must/should be wrapped in 
curly braces

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23457?vs=74387=76852

BRANCH
  l-qregularexpression (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23457

AFFECTED FILES
  autotests/src/regexpsearch_test.cpp
  autotests/src/searchbar_test.cpp
  src/CMakeLists.txt
  src/document/katedocument.cpp
  src/search/kateplaintextsearch.cpp
  src/search/kateregexp.cpp
  src/search/kateregexp.h
  src/search/kateregexpsearch.cpp
  src/search/kateregexpsearch.h
  src/search/katesearchbar.cpp
  src/search/katesearchbar.h
  src/utils/katesedcmd.cpp
  src/utils/katesedcmd.h

To: ahmadsamir, #ktexteditor, dhaumann, cullmann
Cc: kde-frameworks-devel, kwrite-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 447 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/447/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 03 Mar 2020 13:42:47 +
 Build duration:
9 min 43 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.68.0.xmllogs/KF5KIO/5.68.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiofilewidgets_knewfilemenutestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/406)67%
(270/406)56%
(34808/62063)40%
(17681/43818)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9732/10191)47%
(4549/9638)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)60%
(8728/14617)51%
(4517/8835)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4666/8327)43%
(2072/4812)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(680/1269)39%
(390/1000)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1372)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4288)36%
(1309/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
 

D27801: smb: add a unit test for smburl

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> smburl.cpp:67
>  
>  bool SMBUrl::cd(const QString )
>  {

Can't we then just rename the method to `::cdUp()`?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27801

To: sitter, ngraham
Cc: apol, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27805: Add a screenshot capture item and use it to test rendering

[David Edmundson]

davidedmundson added a comment.


  I love the direction. +

INLINE COMMENTS

> ItemCapture.cpp:59
> +qWarning() << "No previous image found for capture" << d->name;
> +QVERIFY2(result->saveToFile(dir.absoluteFilePath(filePath)), "Unable 
> to store first version of capture.");
> +return;

I don't like how we're saving files into the user's source directory directly.

I'm sure we'll get lots of people forgetting to add the files and claiming it 
works because make test works the second time.

And we'll get other people committing lots of _new.png files committed 
accidentally.



I think a new temp dir would be best, alternatively we check some env 
variable/arg that a user can set to specify they want to generate a baseline

> ItemCapture.cpp:81
> +
> +QVERIFY2(dir.remove(filePath), "Could not remove old capture.");
> +QVERIFY2(dir.rename(newFilePath, filePath), "Could not rename new 
> capture.");

Why are we replacing the image if it's slightly different?

> ItemCapture.h:61
> + */
> +Q_PROPERTY(qreal errorMargin READ errorMargin WRITE setErrorMargin 
> NOTIFY errorMarginChanged)
> +

specify if 1% is

0.01 or 1 ?

> qmltest.cpp:22
> +
> +QUICK_TEST_MAIN_WITH_SETUP(Charts, Setup)
> +

I don't know what QUICK_TEXT_MAIN does, but we probably want to make sure we 
have:

QGuiApplication::setAttribute(AA_DisableHighDpiScaling, true);
QGuiApplication::setDesktopSettingsAware(false);

QQuickWindow::setTextRenderType(the qt rendering)

that should help generating the same thing across machines

REPOSITORY
  R1049 KQuickCharts

REVISION DETAIL
  https://phabricator.kde.org/D27805

To: ahiemstra
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27463: KconfigXT: Add a value attribute to Enum field choices

[Méven Car]

meven updated this revision to Diff 76849.
meven added a comment.


  Move values attribute for ItemEnum::Choice to 
KCoreConfigSkeleton::ItemEnum::ItemEnum::mValues to preserve Binary compatiblity

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27463?vs=76446=76849

BRANCH
  arcpatch-D27463_1

REVISION DETAIL
  https://phabricator.kde.org/D27463

AFFECTED FILES
  autotests/kconfig_compiler/test4.cpp.ref
  autotests/kconfig_compiler/test4.kcfg
  src/core/kcoreconfigskeleton.cpp
  src/core/kcoreconfigskeleton.h
  src/kconfig_compiler/KConfigCommonStructs.h
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigXmlParser.cpp
  src/kconfig_compiler/README.dox
  src/kconfig_compiler/kcfg.xsd

To: meven, ervin, bport, crossi, #frameworks
Cc: ngraham, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 313 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/313/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 03 Mar 2020 13:42:48 +
 Build duration:
8 min 12 sec and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiofilewidgets_knewfilemenutestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 322 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/322/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Tue, 03 Mar 2020 13:42:48 +
 Build duration:
7 min 33 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.68.0.xmllogs/KF5KIO/5.68.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiofilewidgets_knewfilemenutestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/406)67%
(270/406)56%
(34798/62063)40%
(17665/43814)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9732/10191)47%
(4549/9638)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)60%
(8726/14617)51%
(4511/8835)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4666/8327)43%
(2070/4808)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(680/1269)39%
(390/1000)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1372)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1788/4288)36%
(1300/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
 

D27800: smb: split module into two targets of which one is a static lib

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Looks good, it's not being used though so as is it feels wrong.

REPOSITORY
  R320 KIO Extras

BRANCH
  smb-smburl-static

REVISION DETAIL
  https://phabricator.kde.org/D27800

To: sitter, ngraham, apol
Cc: apol, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27801: smb: add a unit test for smburl

[Harald Sitter]

sitter updated this revision to Diff 76861.
sitter added a comment.


  follow Aleix' suggestion and change cd() to cdUp() seeing as it now only cds 
up

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27801?vs=76832=76861

BRANCH
  smb-smburl-static-autotest

REVISION DETAIL
  https://phabricator.kde.org/D27801

AFFECTED FILES
  smb/CMakeLists.txt
  smb/autotests/CMakeLists.txt
  smb/autotests/smburltest.cpp
  smb/kio_smb_browse.cpp
  smb/smburl.cpp
  smb/smburl.h

To: sitter, ngraham
Cc: apol, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27804: smb: add hack to support spaces in workgroup names

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: ngraham.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  workgroup names are as best I can tell always still netbios names which
  means they can contain a bunch of characters ordinarily not found in valid
  host names. e.g. spaces
  this causes trouble with the IANA SMB URI draft, as used by libsmbc,
  since the workgroup would be the host field of the RI when browsing
  a workgroup (i.e. filtering hosts that are member of a given workgroup)
  because QUrl does not allow invalid hostnames in the host field.
  
  to bypass this problem we now put the workgroup name into the query of the
  url as `kio-workgroup`, should it cause trouble in the host field. SMBUrl
  takes this query into account when constructing the url for smbc.
  since the latter has uniquely exciting potential for breakage this entire
  dance is only done when absolutely necessary and otherwise we continue with
  all the same code and behavior as without this commit.
  
  on a side note: the awkward name flexibility seems to not extend to
  computer names anymore (supposedly because of LLMNR) so this entire
  use case is already very niche as we (and libsmbclient) currently only
  support workgroup browsing for NT1 networks, and NT1 is by default not
  supported on windows10 or samba.
  
  FIXED-IN: 20.04
  BUG: 204423

TEST PLAN
  builds, test passes, can browse workgroup with space in name

REPOSITORY
  R320 KIO Extras

BRANCH
  smb-smburl-static-autotest-ipv6-spaces

REVISION DETAIL
  https://phabricator.kde.org/D27804

AFFECTED FILES
  smb/autotests/smburltest.cpp
  smb/kio_smb_browse.cpp
  smb/smburl.cpp

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, thiago, pberestov, iasensio, fprice, 
LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27805: Add a screenshot capture item and use it to test rendering

[Arjen Hiemstra]

ahiemstra created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  This adds the ItemCapture item to the test runner, which can be
  used to capture images of items and compare them to a previous 
  version. It also updates the three chart tests to make use of
  this and adds the images for these tests.

TEST PLAN
  Autotests still pass.

REPOSITORY
  R1049 KQuickCharts

BRANCH
  screenshot_autotest

REVISION DETAIL
  https://phabricator.kde.org/D27805

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/ChartTestCase.qml
  autotests/ItemCapture.cpp
  autotests/ItemCapture.h
  autotests/qmltest.cpp
  autotests/screenshots/BarChart_simple.png
  autotests/screenshots/LineChart_simple.png
  autotests/screenshots/PieChart_model.png
  autotests/screenshots/PieChart_multiValue.png
  autotests/screenshots/PieChart_simple.png
  autotests/tst_BarChart.qml
  autotests/tst_LineChart.qml
  autotests/tst_PieChart.qml

To: ahiemstra
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27807: Changed style of pressed list item to be consistent

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27807

To: niccolove, #vdg, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

[David Edmundson]

davidedmundson added a comment.


  PC3 is designed to be only a theme for QQC2
  
  For new API this is the wrong place.

INLINE COMMENTS

> TopArea.qml:44
> +id: topAreaSvg
> +imagePath: "test"
> +prefix: flipped? 'flipped' : ''

test?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27695

To: niccolove, mart
Cc: davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27463: KconfigXT: Add a value attribute to Enum field choices

[Méven Car]

meven updated this revision to Diff 76856.
meven added a comment.


  Fix no value set case

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27463?vs=76849=76856

BRANCH
  arcpatch-D27463_1

REVISION DETAIL
  https://phabricator.kde.org/D27463

AFFECTED FILES
  autotests/kconfig_compiler/test4.cpp.ref
  autotests/kconfig_compiler/test4.kcfg
  src/core/kcoreconfigskeleton.cpp
  src/core/kcoreconfigskeleton.h
  src/kconfig_compiler/KConfigCommonStructs.h
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigXmlParser.cpp
  src/kconfig_compiler/README.dox
  src/kconfig_compiler/kcfg.xsd

To: meven, ervin, bport, crossi, #frameworks
Cc: ngraham, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27800: smb: split module into two targets of which one is a static lib

[Harald Sitter]

sitter added a comment.


  used in D27801 

REPOSITORY
  R320 KIO Extras

BRANCH
  smb-smburl-static

REVISION DETAIL
  https://phabricator.kde.org/D27800

To: sitter, ngraham, apol
Cc: apol, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27801: smb: add a unit test for smburl

[Aleix Pol Gonzalez]

apol added a comment.


  +1 from me

INLINE COMMENTS

> apol wrote in smburl.cpp:67
> Can't we then just rename the method to `::cdUp()`?

it can return void too, nobody is checking it anyway.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27801

To: sitter, ngraham
Cc: apol, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27464: Add application menu dbus paths to org_kde_plasma_window interface

[Carson Black]

cblack added a dependent revision: D27818: [wayland/AbstractClient] Broadcast 
application menu events.

REPOSITORY
  R127 KWayland

BRANCH
  cblack/appmenu-listener

REVISION DETAIL
  https://phabricator.kde.org/D27464

To: cblack, #kwin, zzag, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27464: Add application menu dbus paths to org_kde_plasma_window interface

[Vlad Zahorodnii]

zzag accepted this revision.
zzag added a comment.
This revision is now accepted and ready to land.


  Thanks. Even though the patch is accepted, please do not land it yet. 
https://phabricator.kde.org/D27464#621521

REPOSITORY
  R127 KWayland

BRANCH
  cblack/appmenu-listener

REVISION DETAIL
  https://phabricator.kde.org/D27464

To: cblack, #kwin, zzag, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27816: KI18N_WRAP_UI macro: set SKIP_AUTOUIC property on ui file and gen. header

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Frameworks, ilic.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REPOSITORY
  R249 KI18n

BRANCH
  setskipautouic

REVISION DETAIL
  https://phabricator.kde.org/D27816

AFFECTED FILES
  cmake/KF5I18nMacros.cmake.in

To: kossebau, #frameworks, ilic
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27810: Correctly disable UDS_ACCESS being set

[Alexander Saoutkin]

feverfew added a comment.


  In D27810#621427 , @sitter wrote:
  
  > I am pretty sure I picked that up somewhere, might be worth asking lxr for 
possible other places we set ACCESS to -1
  
  
  grep through kio/kio-extras doesn't reveal this being a pattern.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27810

To: davidedmundson, sitter, feverfew
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27810: Correctly disable UDS_ACCESS being set

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:01e442c75140: Correctly disable UDS_ACCESS being set 
(authored by davidedmundson).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D27810?vs=76872=76879#toc

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27810?vs=76872=76879

REVISION DETAIL
  https://phabricator.kde.org/D27810

AFFECTED FILES
  smb/kio_smb_browse.cpp

To: davidedmundson, sitter, feverfew
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27464: Add application menu dbus paths to org_kde_plasma_window interface

[Carson Black]

cblack updated this revision to Diff 76885.
cblack added a comment.


  Address feedback

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27464?vs=76811=76885

BRANCH
  cblack/appmenu-listener

REVISION DETAIL
  https://phabricator.kde.org/D27464

AFFECTED FILES
  src/client/plasmawindowmanagement.cpp
  src/client/plasmawindowmanagement.h
  src/client/protocols/plasma-window-management.xml
  src/client/registry.cpp
  src/server/plasmawindowmanagement_interface.cpp
  src/server/plasmawindowmanagement_interface.h

To: cblack, #kwin, zzag, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27464: Add application menu dbus paths to org_kde_plasma_window interface

[Vlad Zahorodnii]

zzag added a comment.


  Looks good to me, but please don't land without corresponding KWin patch.

INLINE COMMENTS

> plasmawindowmanagement.h:700
> +/**
> + *  TODO: Documentation.
> + **/

You missed this one.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27464

To: cblack, #kwin, zzag, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27464: Add application menu dbus paths to org_kde_plasma_window interface

[Carson Black]

cblack updated this revision to Diff 76886.
cblack added a comment.


  Add missing documentation

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27464?vs=76885=76886

BRANCH
  cblack/appmenu-listener

REVISION DETAIL
  https://phabricator.kde.org/D27464

AFFECTED FILES
  src/client/plasmawindowmanagement.cpp
  src/client/plasmawindowmanagement.h
  src/client/protocols/plasma-window-management.xml
  src/client/registry.cpp
  src/server/plasmawindowmanagement_interface.cpp
  src/server/plasmawindowmanagement_interface.h

To: cblack, #kwin, zzag, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27766: [ModifiedFileIndexer] Omit BasicIndexingJob run when not required

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:55a43cf13514: [ModifiedFileIndexer] Omit BasicIndexingJob 
run when not required (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27766?vs=76734=76891

REVISION DETAIL
  https://phabricator.kde.org/D27766

AFFECTED FILES
  src/file/modifiedfileindexer.cpp

To: bruns, #baloo, ngraham, astippich
Cc: anthonyfieroni, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, 
cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D27767: [ModifiedFileIndexer] Correct time checks for new files

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:0bbe57ef7f33: [ModifiedFileIndexer] Correct time checks 
for new files (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27767?vs=76744=76892

REVISION DETAIL
  https://phabricator.kde.org/D27767

AFFECTED FILES
  src/file/modifiedfileindexer.cpp

To: bruns, #baloo, ngraham, astippich
Cc: astippich, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, spoorun, ngraham, bruns, 
abrahams

D27464: Add application menu dbus paths to org_kde_plasma_window interface

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> plasmawindowmanagement.cpp:372
> +
> +Q_UNUSED(window);
> +}

Please move it to the top of the method and remove the semicolon.

> plasmawindowmanagement.h:526-527
>  
> +QString applicationMenuServiceName() const;
> +QString applicationMenuObjectPath() const;
> +

Please add documentation.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27464

To: cblack, #kwin, zzag, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27152: Introduce FilesystemEntry class

[David Hallas]

hallas updated this revision to Diff 76898.
hallas marked 9 inline comments as done.
hallas added a comment.


  Addressed review comments

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27152?vs=75961=76898

BRANCH
  introduce_filesystem_entry

REVISION DETAIL
  https://phabricator.kde.org/D27152

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/filesystem_entry_test.cpp
  autotests/filesystem_entry_test.h
  autotests/filesystem_type_test.cpp
  autotests/filesystem_type_test.h
  src/solid/devices/backends/fstab/CMakeLists.txt
  src/solid/devices/backends/fstab/filesystem_entry.cpp
  src/solid/devices/backends/fstab/filesystem_entry.h
  src/solid/devices/backends/fstab/filesystem_type.cpp
  src/solid/devices/backends/fstab/filesystem_type.h
  src/solid/devices/backends/fstab/fstabdevice.cpp
  src/solid/devices/backends/fstab/fstabhandling.cpp
  src/solid/devices/backends/fstab/fstabhandling.h

To: hallas, #frameworks, bruns, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27152: Introduce FilesystemEntry class

[David Hallas]

hallas added a comment.


  @bruns  - thanks a lot for the feedback, I have updated the patch with your 
suggestions.

INLINE COMMENTS

> bruns wrote in filesystem_entry.cpp:77
> Why don't you just keep the string?

It was merely meant as an optimization, I don't know if it makes sense - I'll 
remove it.

> bruns wrote in fstabdevice.cpp:41
> Ircs, raw pointers ... you newer know who owns them ... It is a pointer to an 
> entry in a QHash, it may be deleted/moved when you don't expect it.
> 
> Unfortunately, std::optional is C++17 only.
> 
> Return it by value, return a default constructed instance if no found, and 
> compare `fsEntry.device() != m_device`

Good point :) I have changed this as you suggested, but I have added a method 
to `FilesystemEntry` called `isValid` to check if it is valid

> bruns wrote in fstabhandling.cpp:264
> this looks wrong ...

Yes definitely :) I have removed the line

> bruns wrote in fstabhandling.cpp:316
> this is bad, bad, bad, ...

Fixed

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D27152

To: hallas, #frameworks, bruns, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 54 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/54/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 03 Mar 2020 08:00:21 +
 Build duration:
5 min 1 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 490 test(s), Skipped: 0 test(s), Total: 492 test(s)Failed: projectroot.autotests.testicaltimezonesFailed: projectroot.autotests.testrecurtodo

D27676: smb: ecm clang-format the entire code base

[Harald Sitter]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R320:a1775f44b8fb: smb: ecm clang-format the entire code base 
(authored by sitter).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27676?vs=76458=76828

REVISION DETAIL
  https://phabricator.kde.org/D27676

AFFECTED FILES
  smb/discovery.h
  smb/dnssddiscoverer.cpp
  smb/dnssddiscoverer.h
  smb/kio_smb.cpp
  smb/kio_smb.h
  smb/kio_smb_auth.cpp
  smb/kio_smb_browse.cpp
  smb/kio_smb_config.cpp
  smb/kio_smb_dir.cpp
  smb/kio_smb_file.cpp
  smb/kio_smb_internal.cpp
  smb/kio_smb_internal.h
  smb/kio_smb_mount.cpp
  smb/wsdiscoverer.cpp
  smb/wsdiscoverer.h

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27464: Add application menu dbus paths to org_kde_plasma_window interface

[David Edmundson]

davidedmundson accepted this revision.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27464

To: cblack, #kwin, zzag, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27800: smb: split module into two targets of which one is a static lib

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: ngraham.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  this allows us to use the intermediate static target for unit testing
  (which we'll want for smburl at the very least).
  the effective output remains unchanged, we simply have a fake library
  now before we turn it into a proper plugin .so.
  
  kdemain as a result was moved to its own file and only gets built into the
  final plugin but not the static library as it'd not have any use there
  anyway

TEST PLAN
  builds and works still

REPOSITORY
  R320 KIO Extras

BRANCH
  smb-smburl-static

REVISION DETAIL
  https://phabricator.kde.org/D27800

AFFECTED FILES
  smb/CMakeLists.txt
  smb/kio_smb.cpp
  smb/main.cpp

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27787: Remove 48px telegram icons

[Rocket Aaron]

rocka added a comment.


  Could we please not remove this icon, or at least keep it available as an 
alternative? It fits the general style so well.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27787

To: ndavis, #vdg
Cc: rocka, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

KDE CI: Frameworks » kirigami » kf5-qt5 WindowsMSVCQt5.14 - Build # 42 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20WindowsMSVCQt5.14/42/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Tue, 03 Mar 2020 09:16:09 +
 Build duration:
4 min 14 sec and counting
   JUnit Tests
  Name: projectrootC_.CI.Job_Build Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: projectrootC_.CI.Job_Build.autotests.tst_actiontoolbar.qml

D27695: WIP: Create a new TopArea element using widgets/toparea svg

[Niccolò Venerandi]

niccolove updated this revision to Diff 76822.
niccolove added a comment.


  Width is fill anyway, no need to calculate it

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27695?vs=76572=76822

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27695

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/TopArea.qml

To: niccolove, mart
Cc: ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

[Niccolò Venerandi]

niccolove marked an inline comment as done.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27695

To: niccolove, mart
Cc: ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Cyril Rossi]

crossi updated this revision to Diff 76833.
crossi added a comment.


  rework: introduce parentGroup attribute to group element

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27133?vs=75059=76833

REVISION DETAIL
  https://phabricator.kde.org/D27133

AFFECTED FILES
  autotests/kconfig_compiler/CMakeLists.txt
  autotests/kconfig_compiler/kconfigcompiler_test.cpp
  autotests/kconfig_compiler/test_subgroups.cpp.ref
  autotests/kconfig_compiler/test_subgroups.h.ref
  autotests/kconfig_compiler/test_subgroups.kcfg
  autotests/kconfig_compiler/test_subgroups.kcfgc
  autotests/kconfig_compiler/test_subgroups_main.cpp
  src/kconfig_compiler/KConfigCommonStructs.h
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigSourceGenerator.h
  src/kconfig_compiler/KConfigXmlParser.cpp
  src/kconfig_compiler/KConfigXmlParser.h
  src/kconfig_compiler/kcfg.xsd

To: crossi, ervin, dfaure, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27801: smb: add a unit test for smburl

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: ngraham.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  only tests some of the obvious scenarios I can see right now.
  
  ::cd() has been changed to only support going up one path element. it's
  all we need it for and the previous code was almost certainly incorrect
  by calling setUrl with input that is definitely not anywhere near a valid
  url

TEST PLAN
  builds and test passes

REPOSITORY
  R320 KIO Extras

BRANCH
  smb-smburl-static-autotest

REVISION DETAIL
  https://phabricator.kde.org/D27801

AFFECTED FILES
  smb/CMakeLists.txt
  smb/autotests/CMakeLists.txt
  smb/autotests/smburltest.cpp
  smb/smburl.cpp

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Cyril Rossi]

crossi edited the summary of this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27133

To: crossi, ervin, dfaure, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27802: smb: fix ipv6 support

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: ngraham.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  libsmbc doesn't presently support smb://[ABCD::DCBA]/ uris because it
  has very opinionated colon parsing. as a workaround we convert hosts
  that are ipv6 addresses to their windows ipv6 literal representation.
  that is basically s/:/-/g and s/%/s/g and appending .ipv6-literal.net.
  
  BUG: 417682
  FIXED-IN: 20.04

TEST PLAN
  builds, test passes, `'smb://[::1]/foo'` works as expected

REPOSITORY
  R320 KIO Extras

BRANCH
  smb-smburl-static-autotest-ipv6

REVISION DETAIL
  https://phabricator.kde.org/D27802

AFFECTED FILES
  smb/autotests/smburltest.cpp
  smb/smburl.cpp

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov