Re: Review Request 126632: add a "Complementary" color scheme to kcolorscheme
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126632/#review90998 --- If I could take this, steal it away on a summer cruise, propose, marry and have ten kids with it I would. (I had no idea this was in the pipes but from a design perspective this makes PERFECT sense) VDG approves - Jens Reuterberg On Jan. 5, 2016, 11:16 a.m., Marco Martin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126632/ > --- > > (Updated Jan. 5, 2016, 11:16 a.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: kconfigwidgets > > > Description > --- > > Since some releases, plasma-frameworks locally expands kcolorscheme to have a > new "Complementary" section: this is done for things like the lockscreen and > the logout ui, where the colors are flipped from the current theme. > A local extension there is kinda unfortunate as makes the color configs files > not completely compatible, and I think there is an use case for this in > normal applications as well (Gwenview switches to a dark palette when in > fullscreen mode for instance) > Since I want to make the default plasma theme follow the system color scheme, > I would need for it to support this "complementary" area as well. > > > Diffs > - > > src/kcolorscheme.h 22bc21b > src/kcolorscheme.cpp 427ffa4 > > Diff: https://git.reviewboard.kde.org/r/126632/diff/ > > > Testing > --- > > > Thanks, > > Marco Martin > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 118289: Change titlewidget from bold to increased font size
> On May 27, 2014, 9:56 a.m., Christoph Feck wrote: > > I'll leave the decision which factor to use to the VDG. > > Thomas Pfeiffer wrote: > To get feedback from the VDG, I'd suggest adding alake to the request, > he's our expert on those matters. > > Sebastian Kügler wrote: > I've notified Jens, he's in a more convenient timezone. :) And I'm all for 1.4 its better for visual consistency which is something we should focus on and it simply looks better. - Jens --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118289/#review58546 --- On May 27, 2014, midnight, Sebastian Kügler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118289/ > --- > > (Updated May 27, 2014, midnight) > > > Review request for KDE Frameworks, KDE Usability and Christoph Feck. > > > Repository: kwidgetsaddons > > > Description > --- > > Change titlewidget from bold to increased font size > > This patch removes the bold weight from KTitleWidget and makes the text > a bit bigger, improving focus. This is more in line with common > expectations of a title, and it's more in line with Plasma 5's > typography. > > > Diffs > - > > src/ktitlewidget.h a0c5641 > src/ktitlewidget.cpp b1f3ca7 > > Diff: https://git.reviewboard.kde.org/r/118289/diff/ > > > Testing > --- > > Checked in different systemsettings modules and Kate's dialog. Changed font > size in systemsettings -- font and size are correctly updated in the widget > layout. > > > File Attachments > > > titlewidget in systemsettings (before) > > https://git.reviewboard.kde.org/media/uploaded/files/2014/05/24/1f207a1c--4581-9f75-b2ff87671ee0__titlewidget-ss-before.png > titlewidget in systemsettings (after) > > https://git.reviewboard.kde.org/media/uploaded/files/2014/05/24/0c07a018-cd56-4111-bda6-aafb1ebdcbc1__titlewidget-ss-after.png > titlewidget in kate (before) > > https://git.reviewboard.kde.org/media/uploaded/files/2014/05/24/a3ce0956-4339-495e-9775-e9625b4e0311__titlewidget-kate-before.png > titlewidget in kate (after) > > https://git.reviewboard.kde.org/media/uploaded/files/2014/05/24/616bebac-2bed-4427-9190-02f22d798801__titlewidget-kate-after.png > Example at 1.2x > > https://git.reviewboard.kde.org/media/uploaded/files/2014/05/26/93b91b9b-5c22-42d3-be03-6c30e5709ba3__titlewidget-ss-1.2.png > Example at 1.4x > > https://git.reviewboard.kde.org/media/uploaded/files/2014/05/26/3b2b6c38-c431-4a01-be73-3cb4c3c9006e__titlewidget-ss-1.4.png > > > Thanks, > > Sebastian Kügler > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
D7810: Add missing icon sizes
jensreuterberg added a subscriber: andreask. jensreuterberg added a comment. Well the issue is that they are not "scalable" - I mean the goal should rather be to make them functionable on all sizes but being SVG's means that they may become misaligned when rendered. (Ie if you make an icon made for one size slightly bigger or smaller it will risk suddenly becoming blurry). If @andreask thinks its ok as a risk I am all for it - we should keep in mind though to ensure that all icons have wide breadth of sizes and if possible have a follow up on all icons used and which ones are "just resized" and which are done in the correct sizes. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D7810 To: mandian, #breeze, #vdg, jensreuterberg, #frameworks, ngraham Cc: andreask, hein, ngraham, cfeck, #frameworks
D8592: Update default colors to match new colors in D7424
jensreuterberg added a comment. +1 but as with the original proposal - remember that we may need to revert this if the change balloons out of control REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D8592 To: ngraham, #frameworks, broulik, #vdg Cc: jensreuterberg, #frameworks
D7810: Add missing icon sizes
jensreuterberg added a comment. Just as a heads up, check whether the icons become fuzzy in certain sizes on Mate for example REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D7810 To: mandian, #breeze, #vdg, jensreuterberg, #frameworks, ngraham, hein Cc: andreask, hein, ngraham, cfeck, #frameworks
D7810: Add missing icon sizes
jensreuterberg added a comment. Cool! Just please keep an eye out. Pixel-aligning icons is a PITA but worthwhile so if there is something that ends up blurry please ping REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D7810 To: mandian, #breeze, #vdg, jensreuterberg, #frameworks, ngraham, hein Cc: andreask, hein, ngraham, cfeck, #frameworks
