D25015: Update breeze theme shadows

2019-11-09 Thread Niccolò Venerandi 
niccolove added a comment.


  In D25015#559344 , @filipf wrote:
  
  > I'd prefer the shadows to have equal strength all around, I couldn't get 
used to weaker shadows in the corners.
  
  
  Oh! That's a pity, I really liked them. I will update it as soon as I have 
time.
  
  In D25015#559687 , @ngraham wrote:
  
  > Ah, pixel-perfect before-and-after images make it much easier to see. I 
will reiterate my belief that the shadows now need to be bigger if we're going 
to make them lighter and weaker.
  
  
  Uhm, I will try something and get back to you.
  
  In D25015#559765 , @ndavis wrote:
  
  > Rather than painstakingly making shadows by hand in Inkscape, perhaps we 
should be using KWin for the shadows?
  
  
  Remember that there are third party desktop themes with SVG that we probably 
want to support. Wouldn't using KWin for shadows break those?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg
Cc: ndavis, manueljlin, ngraham, filipf, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25015: Update breeze theme shadows

2019-11-06 Thread Niccolò Venerandi 
niccolove added a comment.


  Any update on this? I can also upload the shadow for the panel.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg
Cc: manueljlin, ngraham, filipf, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

2019-11-17 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 69879.
niccolove added a comment.


  Resized 2px tabbar line to 3px

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25334?vs=69841=69879

BRANCH
  tabbar_blue_background (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25334

AFFECTED FILES
  src/desktoptheme/breeze/widgets/tabbar.svg

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25015: Update breeze theme shadows

2019-11-17 Thread Niccolò Venerandi 
niccolove added a comment.


  Finally! I'm 100% this works now.
  
  In D25015#563300 , @niccolove 
wrote:
  
  > This is a comparison: F7766697: Screenshot_20191116_165659.png 

  >  The problem is not that you don't see, it's that it doesn't show. I'll try 
to understand what's going on and get back to you.
  
  
  Please refer to the comparison to see the difference, although I think it's 
quite noticeable :-)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg
Cc: cblack, ndavis, manueljlin, ngraham, filipf, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-11-17 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 69880.
niccolove added a comment.


  Changed 2px lines to 3px

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25340?vs=69851=69880

BRANCH
  backrgound-color-iconviewer (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25340

AFFECTED FILES
  src/desktoptheme/breeze/widgets/tasks.svg

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25015: Update breeze theme shadows

2019-11-17 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 69886.
niccolove added a comment.


  Updated breeze shadows

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25015?vs=69820=69886

BRANCH
  bettershadows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25015

AFFECTED FILES
  src/desktoptheme/breeze/dialogs/background.svg
  src/desktoptheme/breeze/translucent/dialogs/background.svg
  src/desktoptheme/breeze/translucent/widgets/panel-background.svg
  src/desktoptheme/breeze/translucent/widgets/tooltip.svg
  src/desktoptheme/breeze/widgets/panel-background.svg
  src/desktoptheme/breeze/widgets/tooltip.svg

To: niccolove, #vdg
Cc: cblack, ndavis, manueljlin, ngraham, filipf, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-11-17 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 69882.
niccolove added a comment.


  Tweaked colors of icon view backgrounds

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25340?vs=69880=69882

BRANCH
  backrgound-color-iconviewer (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25340

AFFECTED FILES
  src/desktoptheme/breeze/widgets/tasks.svg

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-11-17 Thread Niccolò Venerandi 
niccolove added a comment.


  In D25340#563593 , @ndavis wrote:
  
  > Here's a cleaned up version of the file with the changes Nate and I 
requested: F7767647: tasks.svg 
  
  
  Oh sorry, I missed this. I'll use that file.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-11-17 Thread Niccolò Venerandi 
niccolove added a comment.


  Now that we got back the 3px line, I would say that it is recognizable. I 
like the idea of having the background and reinforcing the idea that 
line=visible. But it's such a minor change that I would be okay with any option 
really.
  F7768659: Screenshot_20191117_210453.png 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25015: Update breeze theme shadows

2019-11-15 Thread Niccolò Venerandi 
niccolove added a comment.


  This is what you think ends too early (for comparison):
  F7762929: Screenshot_20191114_100519.png 

  What do you think of:
  F7765076: Screenshot_20191115_145942.png 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg
Cc: cblack, ndavis, manueljlin, ngraham, filipf, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, bruns

D25015: Update breeze theme shadows

2019-11-15 Thread Niccolò Venerandi 
niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg
Cc: cblack, ndavis, manueljlin, ngraham, filipf, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, bruns

D25015: Update breeze theme shadows

2019-11-15 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 69820.
niccolove added a comment.


  Updated to new shadows

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25015?vs=68912=69820

BRANCH
  breeze-shadows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25015

AFFECTED FILES
  src/desktoptheme/breeze/dialogs/background.svg
  src/desktoptheme/breeze/widgets/panel-background.svg

To: niccolove, #vdg
Cc: cblack, ndavis, manueljlin, ngraham, filipf, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, bruns

D25015: Update breeze theme shadows

2019-11-15 Thread Niccolò Venerandi 
niccolove added a comment.


  In D25015#563147 , @ngraham wrote:
  
  > Do these shadows get cached or something? When I build the diff and restart 
plasmashell, the shadows I see are identical, pixel-for-pixel.
  
  
  I don't know. But you can manually change them by replacing the .svgz in 
/usr/share/plasma/desktopthemes/default/ dialogs/background.svgz and 
widgets/panel-background.svgz with the new svg.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg
Cc: cblack, ndavis, manueljlin, ngraham, filipf, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, bruns

D25334: Added transparent blue background to tabbars

2019-11-16 Thread Niccolò Venerandi 
niccolove edited the summary of this revision.
niccolove edited the test plan for this revision.
niccolove added a reviewer: VDG.
niccolove added a subscriber: VDG.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg
Cc: #vdg, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25334: Added transparent blue background to tabbars

2019-11-16 Thread Niccolò Venerandi 
niccolove created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  Used the T11124  highlight effect for 
breeze tabbars by editing the file widgets/tabbar.svg.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  tabbar_blue_background (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25334

AFFECTED FILES
  src/desktoptheme/breeze/widgets/tabbar.svg

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25334: Added transparent blue background to tabbars

2019-11-16 Thread Niccolò Venerandi 
niccolove added a comment.


  In D25334#563301 , @ngraham wrote:
  
  > If anything, I think the tab bar line should increase to be 3px to match 
the open app task manager highlight. If we do the reverse, the highlight for 
open app swill be too subtle IMO.
  
  
  Uhm, what if we drew the blue background for the active app? That is what 
Windows does as well, and I think it makes sense. When you open a widget, the 
window will lose focus, so there will never be two elements with blue 
background in the panel. Hover is still clearly visible. See:
  Before:
  F7766706: Screenshot_20191116_170621.png 

  After:
  F7766713: Screenshot_20191116_171634.png 

  At this point open-but-inactive applications could be made more visible by 
adding a gray background as transparent as the blue on.
  F7766720: Screenshot_20191116_172052.png 

  I think that this last one looks much prettier and usable, but that's just an 
idea I only wanted to try, feel free to tell me that's not a good idea. Also, 
changing the background colors there could also be done regardless of the line 
thickness. I just felt like it was much prettier.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

2019-11-16 Thread Niccolò Venerandi 
niccolove added a comment.


  In D25334#563334 , @ngraham wrote:
  
  > If you wanna do that, let's split it out into a different patch though.
  
  
  Sure. Should this patch land first, or should I try to make two at the same 
time?

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

2019-11-16 Thread Niccolò Venerandi 
niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg
Cc: #vdg, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25334: Added transparent blue background to tabbars

2019-11-16 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 69841.
niccolove added a comment.


  Fixed broken north bottom-left tabbar line

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25334?vs=69840=69841

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25334

AFFECTED FILES
  src/desktoptheme/breeze/widgets/tabbar.svg

To: niccolove, #vdg
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25015: Update breeze theme shadows

2019-11-16 Thread Niccolò Venerandi 
niccolove added a comment.


  This is a comparison: F7766697: Screenshot_20191116_165659.png 

  The problem is not that you don't see, it's that it doesn't show. I'll try to 
understand what's going on and get back to you.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg
Cc: cblack, ndavis, manueljlin, ngraham, filipf, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, bruns

D25334: Added transparent blue background to tabbars

2019-11-16 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 69840.
niccolove edited the summary of this revision.
niccolove added a comment.


  Resized blue line of tabbars

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25334?vs=69833=69840

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25334

AFFECTED FILES
  src/desktoptheme/breeze/widgets/tabbar.svg

To: niccolove, #vdg
Cc: #vdg, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25334: Added transparent blue background to tabbars

2019-11-16 Thread Niccolò Venerandi 
niccolove added a comment.


  In D25334#563254 , @KonqiDragon 
wrote:
  
  > Something like this looks better and clearer.
  >  F6924045: grafik.png 
  
  
  That's because no element was selected. If you select an element, only that 
one appears selected:
  F7766584: Screenshot_20191116_154652.png 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg
Cc: KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D25334: Added transparent blue background to tabbars

2019-11-16 Thread Niccolò Venerandi 
niccolove added a comment.


  In D25334#563265 , @ngraham wrote:
  
  > Did you change the SVGs for vertical tab bars as well?
  
  
  Uh, yes I did. Try deleting the plasma theme + svg cache in .cache
  
  > I also noticed one visual papercut in the plasma-pa tab bar: the blue line 
highlight becomes thinner on the right edge: F7766617: 
Screenshot_20191116_081301.png 
  > 
  > Any idea what's up with that?
  
  Fixed, my bad. Or, better put, OOPSIE WOOPSIE!! Uwu I made a fucky wucky!! A 
wittle fucko boingo!

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

2019-11-16 Thread Niccolò Venerandi 
niccolove added a comment.


  In D25334#563285 , @ngraham wrote:
  
  > Perfect, all issues fixed, and thanks for pointing  me in the direction of 
the cache files. Deleting those fixed a bunch of other issues I was having with 
applying plasma theme SVG changes.
  
  
  Did it fix the shadows? I can't apply my own shadows to the new distro I'm 
using.
  
  Regarding this task, I just realized a possible problem: 
  I originally copied this effect from the highlight effect that's used when 
you hover on applications, which uses a 3px blue line:
  F774: Screenshot_20191116_164209.png 

  But then, tweaking things around, I realized that a 2px line looks way better 
in my panel, imo:
  F776: Screenshot_20191116_164303.png 

  Therefore right now this effect and the application hover effect are 
inconsistent. I'm not a fan of bringing back that 3px line though. Do you think 
I should change the application top lines, or leave them as-is?

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-11-16 Thread Niccolò Venerandi 
niccolove created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  Added:
  
  - Light blue color for active window
  - Light gray color for inactive but not minimized window

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  backrgound-color-iconviewer (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25340

AFFECTED FILES
  src/desktoptheme/breeze/widgets/tasks.svg

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25340: Added background colors to active and inactive icon view

2019-11-16 Thread Niccolò Venerandi 
niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25340: Added background colors to active and inactive icon view

2019-11-16 Thread Niccolò Venerandi 
niccolove edited the test plan for this revision.
niccolove added a reviewer: VDG.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25340: Added background colors to active and inactive icon view

2019-11-16 Thread Niccolò Venerandi 
niccolove added a subscriber: ndavis.
niccolove added a comment.


  > @ndavis said:
  >  Here's what I think:
  > 
  > - The line should indicate that the app is opened, the window is not 
minimized and the window is focused (opaque blue) or inactive (opaque gray)
  > - The background should indicate whether an app is not opened (no BG), 
minimized or inactive (semi-transparent gray), or focused (semi-transparent 
blue)
  
  Please note that would require change in how desktop themes are handled, not 
in the desktop theme itself, as far as I understand it. I'm afraid I don't have 
the experience to implement what you are saying; this is the best I can offer. 
Of course, if there is anybody else, it could be a good idea.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25340: Added background colors to active and inactive icon view

2019-11-16 Thread Niccolò Venerandi 
niccolove added a comment.


  In D25340#563400 , @ndavis wrote:
  
  > This diff is against commit 467d721cc96258b54048c0dd1508d16e03c0cd55, which 
isn't in git master. Do I actually need that commit for this patch to work?
  
  
  No. My bad. Let me fix.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25340: Added background colors to active and inactive icon view

2019-11-16 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 69851.
niccolove added a comment.


  Added background colors to active and inactive icon view

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25340?vs=69849=69851

BRANCH
  backrgound-color-iconviewer (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25340

AFFECTED FILES
  src/desktoptheme/breeze/widgets/tasks.svg

To: niccolove, #vdg
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25015: Update breeze theme shadows

2019-11-23 Thread Niccolò Venerandi 
niccolove added a comment.


  F7780181: image.png 
  I just can't get the padding right on angles when changing their size. What 
size should I change of the colored rectangles?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg
Cc: cblack, ndavis, manueljlin, ngraham, filipf, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-11-23 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 70207.
niccolove added a comment.


  Changed opacity of inactive vs non-visible application background color

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25340?vs=69882=70207

BRANCH
  backrgound-color-iconviewer (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25340

AFFECTED FILES
  src/desktoptheme/breeze/widgets/tasks.svg

To: niccolove, #vdg, ngraham
Cc: manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

2019-11-23 Thread Niccolò Venerandi 
niccolove added a comment.


  F7780227: Screenshot_20191123_130602.png 

  I'm sorry, isn't this right?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-11-23 Thread Niccolò Venerandi 
niccolove added a comment.


  > Might be too subtle, maybe more opacity would be needed
  
  This should have a 13% vs 23% opacity, what do you think?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham
Cc: manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25015: Update breeze theme shadows

2019-12-15 Thread Niccolò Venerandi 
niccolove added a comment.


  Got it. Blur is not rounded either to me. The shadow was hiding it.
  F7819795: Screenshot_20191215_170023.png 

  
  In D25015#575297 , @mart wrote:
  
  > In D25015#568865 , @niccolove 
wrote:
  >
  > > Got it. The shape is actually rounded BUT the desktop contract effect is 
applied in the whole rectangle underneath, and it makes everything look like a 
rectangle. Here's the widget with fully transparent background, but with the 
contract effect on:
  > >  F7788618: Screenshot_20191128_153515.png 

  > >  Of course, I can't just turn off the contrast desktop effect. I'm unsure 
how to move forward with this.
  > >  Here's Plasma without desktop effect:
  > >  F7788630: Screenshot_20191128_154652.png 

  > >  As you can see, shadows are working!
  >
  >
  > Not sure why it looks rectangular, on current theme the mask- prefix is 
correctly used and the blur is correctly shaped with rounded borders
  
  
  If you remove the shadows, desktop effect and background, do you still see 
rounded blur? If so, it's my machine.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  bettershadows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg, ngraham
Cc: mart, broulik, cblack, ndavis, manueljlin, ngraham, filipf, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25334: Added transparent blue background to tabbars

2019-12-15 Thread Niccolò Venerandi 
niccolove added a comment.


  Breeze dark highlight is currently #3daee9 in the Breeze Dark colorscheme. If 
that's too light, we could darken it there, right?
  Currently it's: F7819764: Screenshot_20191215_163924.png 

  Darker could be (example value):
  F7819766: Screenshot_20191215_164056.png 

  Otherwise, the highlight effect could be made more transparent so that it's 
darker, but that would be a problem for consistency, as the same highlight 
color is also used throughout the desktop theme.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25015: Update breeze theme shadows

2019-12-15 Thread Niccolò Venerandi 
niccolove added a comment.


  I just compared the blur and contrast effects and the mask is used in the 
exact same way :-/ I have no idea what could be wrong there.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  bettershadows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg, ngraham
Cc: mart, broulik, cblack, ndavis, manueljlin, ngraham, filipf, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-12-07 Thread Niccolò Venerandi 
niccolove added a comment.


  In D25340#573594 , @ndavis wrote:
  
  > Wait, is a change to tabbar.svg supposed to be in this diff?
  
  
  Nope, I must have messed up the different arc features. Sorry.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham, ndavis
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-12-07 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 71050.
niccolove added a comment.


  Reset tabbar to master

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25340?vs=71048=71050

BRANCH
  backrgound-color-iconviewer (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25340

AFFECTED FILES
  src/desktoptheme/breeze/widgets/tasks.svg

To: niccolove, #vdg, ngraham, ndavis
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-12-07 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 71048.
niccolove added a comment.


  Changed inactive to 5%

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25340?vs=70207=71048

BRANCH
  backrgound-color-iconviewer (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25340

AFFECTED FILES
  src/desktoptheme/breeze/widgets/tabbar.svg
  src/desktoptheme/breeze/widgets/tasks.svg

To: niccolove, #vdg, ngraham
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

2019-12-07 Thread Niccolò Venerandi 
niccolove added a comment.


  In D25334#566992 , @ngraham wrote:
  
  > In D25334#566745 , @ndavis wrote:
  >
  > > Yes that's right, the Kickoff tabs are fine, it's the panel that doesn't 
look right. It just doesn't look good with that kind of highlight to me. Or 
maybe the highlight background is too bright.
  >
  >
  > To me it looks fine with Breeze light IMO. If you think it looks bad with 
Breeze Dark, that seems like kind of a problem since as far as I was aware, 
this is the proposed new highlight style that you're working on, right? It 
definitely needs to look good with Breeze Dark, or at least no worse than the 
status quo.
  
  
  As per the screenshot above, this patch highlight look just as it was before 
in Breeze Dark, there was no change of that. If you think the current highlight 
is wrong with breeze dark, I could create a different task for that.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-12-08 Thread Niccolò Venerandi 
niccolove added a comment.


  In D25340#573672 , @ndavis wrote:
  
  > @niccolove Do you mind if I commandeer this? I know dealing with these 
kinds of issues can be super annoying and I'm already used to it.
  
  
  Feel free to do that :-)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham, ndavis
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D24593: Modified breeze shadows

2019-10-15 Thread Niccolò Venerandi 
niccolove added a comment.


  In D24593#546586 , @filipf wrote:
  
  > > b) radial gradients instead of linear on the four sides to make the 
center darker than the angles.
  >
  > Other than this, they look great to me. I think they should be uniformly 
dispersed.
  >
  > One of the things with shadows is that the user shouldn't really notice 
them. With the radial style I can't help but notice there's shadows missing in 
the corners.
  
  
  What do you think?
  F7601293: Screenshot_20191015_190157.png 

  
  In D24593#546731 , @Luwx wrote:
  
  > Making good looking pure svg box shadows is a bit tricky.
  >
  > A while back I tried to create one:
  >
  > F7590931: shadow.png 
  >
  > The left one uses blur (like breeze decoration does) and the right uses 
gradients with quite a few stops to emulate the blurred square (I don't know if 
this has any effect on performance), radial gradients were used only in the 
corners.
  >
  > It this is of any help, here is the svg: F7590940: shadow.svg 

  
  
  Thanks, that's interesting. May I ask why did you use multiple linear 
gradients instead of a big linear one?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: Luwx, filipf, ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, bruns

D24593: Modified breeze shadows

2019-10-24 Thread Niccolò Venerandi 
niccolove added a comment.


  In D24593#551591 , @ngraham wrote:
  
  > Is this ready for formal review now or are you still tweaking and/or 
soliciting comments?
  
  
  Ready for review :-)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: Luwx, filipf, ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, bruns

D24593: Modified breeze shadows

2019-10-24 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 68626.
niccolove added a comment.


  Made missing shadow on corners less noticeable on widgets shadows

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24593?vs=67853=68626

BRANCH
  breeze-shadows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24593

AFFECTED FILES
  src/desktoptheme/breeze/dialogs/background.svg
  src/desktoptheme/breeze/widgets/panel-background.svg

To: niccolove, #vdg
Cc: Luwx, filipf, ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, bruns

D24593: Modified breeze shadows

2019-10-28 Thread Niccolò Venerandi 
niccolove abandoned this revision.
niccolove added a comment.


  Let's try again https://phabricator.kde.org/D25015

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: Luwx, filipf, ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, bruns

D25015: I have received negative feedback (and I agree with it) on the current state of breeze shadows: they are quite dark, narrow, and feel unnatural. I tried to adress that by making shadows more s

2019-10-28 Thread Niccolò Venerandi 
niccolove added a reviewer: VDG.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25015: Update breeze theme shadows

2019-10-28 Thread Niccolò Venerandi 
niccolove retitled this revision from "I have received negative feedback (and I 
agree with it) on the current state of breeze shadows: they are quite dark, 
narrow, and feel unnatural. I tried to adress that by making shadows more 
sparse and a bit lighter especially on the angles while..." to "Update breeze 
theme shadows".
niccolove edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25014: I have received negative feedback (and I agree with it) on the current state of breeze shadows: they are quite dark, narrow, and feel unnatural. I tried to adress that by making shadows more s

2019-10-28 Thread Niccolò Venerandi 
niccolove created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  ...trying to keep it distinguishable when on white background. I received 
some positive feedback on these shadows from T10891 
 and the VDG channel. More specifically, I 
changed dialogs/background.svg to have a) longer linear gradients and b) radial 
gradients instead of linear on the four sides to make the center darker than 
the angles.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  breeze-shadows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25014

AFFECTED FILES
  src/desktoptheme/breeze/dialogs/background.svg

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25015: I have received negative feedback (and I agree with it) on the current state of breeze shadows: they are quite dark, narrow, and feel unnatural. I tried to adress that by making shadows more s

2019-10-28 Thread Niccolò Venerandi 
niccolove created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  ...trying to keep it distinguishable when on white background. I received 
some positive feedback on these shadows from T10891 
 and the VDG channel. More specifically, I 
changed dialogs/background.svg to have a) longer linear gradients and b) radial 
gradients instead of linear on the four sides to make the center darker than 
the angles.

TEST PLAN
  F7629404: Screenshot_20191019_164936.png 

  F7629444: Screenshot_20191019_165736.png 

  F7629446: Screenshot_20191019_165804.png 


REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  breeze-shadows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25015

AFFECTED FILES
  src/desktoptheme/breeze/dialogs/background.svg

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25014: I have received negative feedback (and I agree with it) on the current state of breeze shadows: they are quite dark, narrow, and feel unnatural. I tried to adress that by making shadows more s

2019-10-28 Thread Niccolò Venerandi 
niccolove abandoned this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25014

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25015: Update breeze theme shadows

2019-10-29 Thread Niccolò Venerandi 
niccolove added a comment.


  In D25015#48 , @ngraham wrote:
  
  > If anything I wonder if we should make them bigger too, to better match the 
default Breeze shadows.
  
  
  I'd prefer to avoid them making more sparse because a) they look worse to me 
when applied to small objects such as notifications (you have big shadows for a 
relatively small item, they don't give the impression to be casted by that 
item) b) lots and lots of techical problem when trying to change shadow size :-/

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg
Cc: ngraham, filipf, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24593: Modified breeze shadows

2019-10-19 Thread Niccolò Venerandi 
niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: Luwx, filipf, ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, bruns

D24593: Modified breeze shadows

2019-10-26 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 68788.
niccolove added a comment.


  Rebase on master - test

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24593?vs=68626=68788

BRANCH
  breeze-shadows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24593

AFFECTED FILES
  src/desktoptheme/breeze/dialogs/background.svg
  src/desktoptheme/breeze/widgets/panel-background.svg

To: niccolove, #vdg
Cc: Luwx, filipf, ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, bruns

D24593: Modified breeze shadows

2019-10-26 Thread Niccolò Venerandi 
niccolove added a comment.


  In D24593#552915 , @ngraham wrote:
  
  > Needs a rebase on master. It doesn't apply for me.
  
  
  Does it apply now? If not, I messed up something and I will just reset to 
master and add the svgs again.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: Luwx, filipf, ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, bruns

D25015: Update breeze theme shadows

2019-11-27 Thread Niccolò Venerandi 
niccolove added a comment.


  In D25015#568331 , @ngraham wrote:
  
  > Actually it looks like that was due to some kind of caching issue. It's 
gone now. LGTM!
  >
  > Everyone else good with this?
  
  
  Actually, it seems to me that borders are not correctly rounded except when 
on bright background, and sometimes. I'm not sure why would that be. Do you 
also see this, or is it just me?
  F7787476: image.png 
  F7787479: image.png 

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  bettershadows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg, ngraham
Cc: cblack, ndavis, manueljlin, ngraham, filipf, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, bruns

D25015: Update breeze theme shadows

2019-11-28 Thread Niccolò Venerandi 
niccolove added a comment.


  Got it. The shape is actually rounded BUT the desktop contract effect is 
applied in the whole rectangle underneath, and it makes everything look like a 
rectangle. Here's the widget with fully transparent background, but with the 
contract effect on:
  F7788618: Screenshot_20191128_153515.png 

  Of course, I can't just turn off the contrast desktop effect. I'm unsure how 
to move forward with this.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  bettershadows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg, ngraham
Cc: cblack, ndavis, manueljlin, ngraham, filipf, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, bruns

D25015: Update breeze theme shadows

2019-11-14 Thread Niccolò Venerandi 
niccolove added a comment.


  In D25015#560514 , @ndavis wrote:
  
  > > Remember that there are third party desktop themes with SVG that we 
probably want to support. Wouldn't using KWin for shadows break those?
  >
  > If we remove the code for using those SVG shadows, it won't break them in 
the sense that they will stop working. It'll just mean those parts of the 
desktop themes won't be used. I suppose that could be seen as a form of visual 
breakage.
  >
  > For complete theme sets, this shouldn't be such a problem since they also 
typically come with their own window decorations and recommend a specific 
widget style. For people who just want to get rid of the shadows we should 
probably provide an option somewhere to disable them rather than making them 
edit the plasma theme. I suppose we could wait until Plasma 6 to make that kind 
of change, but that's a ways away.
  
  
  I'm against this; there are many desktop themes that tweak their shadows 
without being a theme set, and it would be an important regression to ignore 
them.
  
  > Regardless of the method we use to achieve it (including continuing to use 
SVGs), I think it might be best to make Plasmashell's shadows match the shadows 
cast by menus (such as context menus) in applications. These are defined in the 
Breeze widget style and have different sizes to match the different window 
shadow sizes.
  
  This is interesting. I have to look more into it.
  
  Meanwhile, I tried to do a more sparse and equal-all-around shadow (to 
address Nate+Filip), but I'm not 100% okay with it. Opinions?
  
  F7762929: Screenshot_20191114_100519.png 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg
Cc: cblack, ndavis, manueljlin, ngraham, filipf, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, bruns

D24593: Modified breeze shadows

2019-10-12 Thread Niccolò Venerandi 
niccolove added a comment.


  I'm sorry, when I use scour on svg files, it looks like git does not 
recognize that the file has changed. How can I fix that?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24593: Modified breeze shadows

2019-10-12 Thread Niccolò Venerandi 
niccolove added a reviewer: VDG.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24593: Modified breeze shadows

2019-10-12 Thread Niccolò Venerandi 
niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24593: Modified breeze shadows

2019-10-12 Thread Niccolò Venerandi 
niccolove created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
niccolove requested review of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  breeze-shadows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24593

AFFECTED FILES
  src/desktoptheme/breeze/dialogs/background.svg
  src/desktoptheme/breeze/widgets/panel-background.svg

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24593: Modified breeze shadows

2019-10-12 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 67790.
niccolove added a comment.


  Used scour on svg files

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24593?vs=67789=67790

BRANCH
  breeze-shadows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24593

AFFECTED FILES
  src/desktoptheme/breeze/dialogs/background.svg
  src/desktoptheme/breeze/widgets/panel-background.svg

To: niccolove, #vdg
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24593: Modified breeze shadows

2019-10-12 Thread Niccolò Venerandi 
niccolove added a comment.


  Uhm, I probably got Scour wrong. Sorry.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24593: Modified breeze shadows

2019-10-12 Thread Niccolò Venerandi 
niccolove edited the summary of this revision.
niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24593: Modified breeze shadows

2019-10-13 Thread Niccolò Venerandi 
niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24593: Modified breeze shadows

2019-10-13 Thread Niccolò Venerandi 
niccolove added a comment.


  In D24593#546309 , @ngraham wrote:
  
  > In D24593#546042 , @niccolove 
wrote:
  >
  > > I'm sorry, when I use scour on svg files, it looks like git does not 
recognize that the file has changed. How can I fix that?
  >
  >
  > That means that the files actually haven't changed compared to the prior 
version. It looks like the diff is messed up and is using the scoured version 
as the base rather than the latest git master.
  
  
  It now shows me a diff, is relatively to master or to my previous svg? in 
that case, I can do another diff  without messing up 
(hopefully)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24593: Modified breeze shadows

2019-10-13 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 67853.
niccolove added a comment.


  Re-done the widgets/panel-background.svg

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24593?vs=67852=67853

BRANCH
  breeze-shadows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24593

AFFECTED FILES
  src/desktoptheme/breeze/dialogs/background.svg
  src/desktoptheme/breeze/widgets/panel-background.svg

To: niccolove, #vdg
Cc: ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24593: Modified breeze shadows

2019-10-13 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 67852.
niccolove added a comment.


  Re-done the dialogs/background.svg

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24593?vs=67790=67852

BRANCH
  breeze-shadows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24593

AFFECTED FILES
  src/desktoptheme/breeze/dialogs/background.svg
  src/desktoptheme/breeze/widgets/panel-background.svg

To: niccolove, #vdg
Cc: ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-10 Thread Niccolò Venerandi 
niccolove added a comment.


  - Breeze panel and dialog being different when using a dark theme
  - Avoiding controls to be used in ViewBackground areas / using Background 
Breeze color without it looking gray
  
  I have no idea how these could be fixed without just using a color file-d 
theme by default :-(
  The top area could work for the second one, but stuff like wifi password box 
and clipboard box might probably still fall outside...
  
  - Breeze panel and dialog being different when there's a maximized window
  
  I have no idea how this could be addressed at all. It's not currently doing 
that either. And making the panel opaque on maximized app would not work either 
unless the dialog is also fully opaque. Which I'm not a fan of, in this patch.
  
  tl;dr: kinda stuck with this one, not sure what I could do to address those 
problems. I should keep thinking about this.
  
  Maybe the look could be implemented first for just Breeze Light and Dark and 
not Breeze first, but it would probably be very weird to explain it to the user 
("Breeze is more opaque and follows the colorscheme, Breeze Light is the 
opposite").

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27122

To: niccolove, ndavis, ngraham, cblack
Cc: cblack, ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, 
manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, konkinartem, ian, jguidon, 
Ghost6, jraleigh, zachus, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, michaelh, crozbo, ZrenBot, firef, 
bruns, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart

D27354: Remove hardcoded colors

2020-02-13 Thread Niccolò Venerandi 
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:1ed47e7c4188: Remove hardcoded colors (authored by 
niccolove).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27354?vs=75572=75629

REVISION DETAIL
  https://phabricator.kde.org/D27354

AFFECTED FILES
  src/desktoptheme/breeze/translucent/widgets/panel-background.svg
  src/desktoptheme/breeze/widgets/panel-background.svg

To: niccolove, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27354: Remove hardcoded colors

2020-02-12 Thread Niccolò Venerandi 
niccolove added a reviewer: ndavis.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27354

To: niccolove, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27354: Remove hardcoded colors

2020-02-12 Thread Niccolò Venerandi 
niccolove created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  Fixes 
https://www.reddit.com/r/kde/comments/f2mxd3/517_seeing_weird_white_corners_on_my_autohiding/
  
  BUG:417511

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27354

AFFECTED FILES
  src/desktoptheme/breeze/translucent/widgets/panel-background.svg
  src/desktoptheme/breeze/widgets/panel-background.svg

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-25 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 76382.
niccolove added a comment.


  re-tweaked commits

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27122?vs=76381=76382

BRANCH
  contrast_effect_background_color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27122

AFFECTED FILES
  src/desktoptheme/breeze-dark/CMakeLists.txt
  src/desktoptheme/breeze-dark/metadata.desktop.cmake
  src/desktoptheme/breeze-dark/translucent/widgets/panel-background.svg
  src/desktoptheme/breeze-light/metadata.desktop.cmake
  src/desktoptheme/breeze/metadata.desktop.cmake
  src/desktoptheme/breeze/translucent/dialogs/background.svg
  src/desktoptheme/breeze/translucent/widgets/panel-background.svg
  src/desktoptheme/breeze/translucent/widgets/tooltip.svg

To: niccolove, ndavis, ngraham, cblack
Cc: trmdi, cblack, ndavis, filipf, ngraham, davidedmundson, 
kde-frameworks-devel, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, 
konkinartem, ian, jguidon, Ghost6, jraleigh, zachus, MrPepe, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, 
michaelh, crozbo, ZrenBot, firef, bruns, skadinna, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, 
mbohlender, mart

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-04 Thread Niccolò Venerandi 
niccolove added a comment.


  Two questions:
  
  - I know we should not assume it's a Layout, but margins should be defined 
inside the file as they compensate the inset; is it possible to both define 
them with Layout and anchors, or something that would work with both?
  - Is code on line 51 fine? Lines are a bit long there

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27695

To: niccolove, mart
Cc: davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-04 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 76947.
niccolove added a comment.


  Moved TopArea to PlasmoidHeading and various fixes in it

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27695?vs=76862=76947

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27695

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/PlasmoidHeading.qml

To: niccolove, mart
Cc: davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27848: Remove the tooltip icon

2020-03-04 Thread Niccolò Venerandi 
niccolove accepted this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  remove-tooltip-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27848

To: ngraham, #vdg, #plasma, cblack, niccolove
Cc: cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27807: Changed style of pressed list item to be consistent

2020-03-03 Thread Niccolò Venerandi 
niccolove created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  The style of pressed- listitem (which is actually often used for hover as 
well, while the hover- listitem is never used afaik) was inconsistent with 
viewitem, such as Kickoff app list (which probably should use listitem, since 
it's a list). This patch makes them look the same, in a much prettier and 
consistent way:

TEST PLAN
  (gimme a sec to upload screenshots)

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  consistentlistitemselected (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27807

AFFECTED FILES
  src/desktoptheme/breeze/widgets/listitem.svg

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-03 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 76860.
niccolove added a comment.


  Moved the file to Extra components

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27695?vs=76822=76860

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27695

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/TopArea.qml

To: niccolove, mart
Cc: ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27807: Changed style of pressed list item to be consistent

2020-03-03 Thread Niccolò Venerandi 
niccolove added reviewers: VDG, Plasma.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27807

To: niccolove, #vdg, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27807: Changed style of pressed list item to be consistent

2020-03-03 Thread Niccolò Venerandi 
niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27807

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27807: Changed style of pressed list item to be consistent

2020-03-03 Thread Niccolò Venerandi 
niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27807

To: niccolove, #vdg, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-03 Thread Niccolò Venerandi 
niccolove added a comment.


  In D27695#621305 , @davidedmundson 
wrote:
  
  > PC3 is designed to be only a theme for QQC2
  
  
  That's why I moved it to plasmaextracomponent with the last commit, actually

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27695

To: niccolove, mart
Cc: davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-03 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 76862.
niccolove added a comment.


  Replace test with widgets/toparea

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27695?vs=76860=76862

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27695

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/TopArea.qml

To: niccolove, mart
Cc: davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-03 Thread Niccolò Venerandi 
niccolove marked an inline comment as done.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27695

To: niccolove, mart
Cc: davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27807: Changed style of pressed list item to be consistent

2020-03-03 Thread Niccolò Venerandi 
niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27807

To: niccolove, #vdg, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27807: Changed style of pressed list item to be consistent

2020-03-04 Thread Niccolò Venerandi 
niccolove abandoned this revision.
niccolove added a comment.


  Actually, there is a proper way to do this. Gimme a sec.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27807

To: niccolove, #vdg, #plasma
Cc: ngraham, plasma-devel, ndavis, kde-frameworks-devel, LeGast00n, cblack, 
GB_2, michaelh, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-02-27 Thread Niccolò Venerandi 
niccolove added a dependent revision: D27189: Created a top area based on 
widgets/toparea.svg.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27695

To: niccolove, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27444: Added top area

2020-02-27 Thread Niccolò Venerandi 
niccolove added a dependent revision: D27695: WIP: Create a new TopArea element 
using widgets/toparea svg.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27444

To: niccolove, #vdg, ngraham, ndavis
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-02-27 Thread Niccolò Venerandi 
niccolove created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  This creates a new component that uses the widgets/toparea svg. First time I 
try to add something to PlasmaComponents, so I probably got stuff wrong and I 
probably have to still do thing like adding documentation. I'm creating the 
diff to get feedback on how to move forward with this.
  
  Depends on D27444 

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27695

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/TopArea.qml

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-02-27 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 76534.
niccolove added a comment.


  Fixed conditionals

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27695?vs=76531=76534

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27695

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/TopArea.qml

To: niccolove, mart
Cc: ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-02-27 Thread Niccolò Venerandi 
niccolove added a reviewer: mart.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27695

To: niccolove, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-02-27 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 76528.
niccolove added a comment.


  Added licence

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27695?vs=76527=76528

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27695

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/TopArea.qml

To: niccolove, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-02-27 Thread Niccolò Venerandi 
niccolove edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27695

To: niccolove, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-02-27 Thread Niccolò Venerandi 
niccolove marked an inline comment as done.
niccolove added inline comments.

INLINE COMMENTS

> ahiemstra wrote in TopArea.qml:40
> This conditional is wrong. The syntax is `condition ? true_case : false_case` 
> so you want to write `flipped ? -topAreaSvg.margins.top : 
> -topAreaSvg.margins.bottom` or something similar.

Dumb me. I'm used to python.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27695

To: niccolove, mart
Cc: ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-02-27 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 76531.
niccolove added a comment.


  Fixed svg path

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27695?vs=76528=76531

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27695

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/TopArea.qml

To: niccolove, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-02-27 Thread Niccolò Venerandi 
niccolove edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27695

To: niccolove, mart
Cc: ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27444: Added top area

2020-02-27 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 76562.
niccolove added a comment.


  Hardcoded colors

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27444?vs=76378=76562

BRANCH
  top_area (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27444

AFFECTED FILES
  src/desktoptheme/breeze/widgets/toparea.svg

To: niccolove, #vdg, ngraham, ndavis
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-02-27 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 76572.
niccolove marked an inline comment as done.
niccolove added a comment.


  Fixed margin

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27695?vs=76534=76572

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27695

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/TopArea.qml

To: niccolove, mart
Cc: ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-25 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 76373.
niccolove added a comment.


  Tweaked values

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27122?vs=75787=76373

BRANCH
  contrast_effect_background_color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27122

AFFECTED FILES
  .gitignore
  CMakeLists.txt
  plasma-framework.categories
  src/CMakeLists.txt
  src/declarativeimports/core/private/DefaultToolTip.qml
  src/declarativeimports/plasmacomponents3/CheckIndicator.qml
  src/declarativeimports/plasmacomponents3/RadioButton.qml
  src/declarativeimports/plasmacomponents3/RadioIndicator.qml
  src/declarativeimports/plasmacomponents3/TabButton.qml
  src/declarativeimports/plasmacomponents3/ToolButton.qml
  src/declarativeimports/plasmaextracomponents/qml/Heading.qml
  src/declarativeimports/plasmaextracomponents/qml/Title.qml
  src/declarativeimports/plasmastyle/CheckBoxStyle.qml
  src/declarativeimports/plasmastyle/RadioButtonStyle.qml
  src/desktoptheme/breeze-dark/CMakeLists.txt
  src/desktoptheme/breeze-dark/metadata.desktop.cmake
  src/desktoptheme/breeze-dark/translucent/widgets/panel-background.svg
  src/desktoptheme/breeze-light/metadata.desktop.cmake
  src/desktoptheme/breeze/dialogs/background.svg
  src/desktoptheme/breeze/metadata.desktop.cmake
  src/desktoptheme/breeze/translucent/dialogs/background.svg
  src/desktoptheme/breeze/translucent/widgets/panel-background.svg
  src/desktoptheme/breeze/translucent/widgets/tooltip.svg
  src/desktoptheme/breeze/widgets/actionbutton.svg
  src/desktoptheme/breeze/widgets/checkmarks.svg
  src/desktoptheme/breeze/widgets/panel-background.svg
  src/desktoptheme/breeze/widgets/tooltip.svg
  src/plasma/CMakeLists.txt
  src/plasma/pluginloader.cpp
  src/plasma/private/dataenginemanager.cpp
  src/plasmaquick/CMakeLists.txt
  src/scriptengines/qml/CMakeLists.txt
  src/scriptengines/qml/plasmoid/containmentinterface.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.h
  src/scriptengines/qml/plasmoid/dropmenu.cpp
  src/scriptengines/qml/plasmoid/dropmenu.h
  tests/components/radiobutton3.qml

To: niccolove, ndavis, ngraham, cblack
Cc: cblack, ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, 
manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, konkinartem, ian, jguidon, 
Ghost6, jraleigh, zachus, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, michaelh, crozbo, ZrenBot, firef, 
bruns, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart

  1   2   3   >