Re: Review Request 126774: Fix many warnings presented by clazy

[Russell Greene]

  Start 46: httpfiltertest
46/47 Test #46: httpfiltertest ...   Passed
0.01 sec
  Start 47: kioslave-kcookiejartest
47/47 Test #47: kioslave-kcookiejartest ..   Passed
0.30 sec

94% tests passed, 3 tests failed out of 47

Total Test time (real) =  67.92 sec

The following tests FAILED:
  3 - kiocore-kacltest (Failed)
  8 - kiocore-jobtest (OTHER_FAULT)
 43 - kioslave-httpheaderdispositiontest (Failed)
Errors while running CTest
Makefile:106: recipe for target 'test' failed
make: *** [test] Error 8


Thanks,

Russell Greene

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126774: Fix many warnings presented by clazy

[Russell Greene]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126774/
---

(Updated Feb. 20, 2016, 8:41 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Aleix Pol Gonzalez.


Changes
---

Submitted with commit dc81eb9be52d8027cf80192ea3c693270cee979c by David Faure 
on behalf of Russell Greene to branch master.


Repository: kio


Description
---

Fix many warnings presented by clazy

I ran the clazy static anaylizer on the codebase and fixed many of the errors.

Many of these were using QStringLiteral instead of QString, which removes an 
allocation, including Q_OBJECT macros, adding const ref instad of const lvalue, 
stuff like that.


Diffs
-

  autotests/http/httpheaderdispositiontest.cpp ac41656 
  autotests/http/httpheadertokenizetest.cpp e57be09 
  autotests/jobtest.cpp dfbfba9 
  autotests/kacltest.cpp 2b88906 
  autotests/kcookiejar/kcookiejartest.cpp dab6987 
  autotests/kfileitemtest.cpp 49d11e1 
  autotests/kfileplacesmodeltest.cpp effc95b 
  autotests/klocalsocketservertest.cpp 9b7f246 
  autotests/klocalsockettest.cpp 0d831f2 
  autotests/kmountpointtest.cpp f6eccd8 
  autotests/knewfilemenutest.cpp 1b11f15 
  autotests/kprotocolinfotest.cpp 812f7f7 
  autotests/ktcpsockettest.cpp 640d871 
  autotests/kurlnavigatortest.cpp 1b295c3 
  autotests/udsentry_benchmark.cpp 16c8b7e 
  src/core/dataprotocol_p.h 784226b 
  src/core/global.cpp eaa4264 
  src/core/job_error.cpp 7943cb3 
  src/core/kprotocolinfofactory.cpp 1329b6b 
  src/core/kprotocolmanager.cpp bd42c9e 
  src/core/ksambasharedata.cpp b63f518 
  src/core/ksslcertificatemanager.cpp 07feda4 
  src/core/restorejob.cpp ee5cca9 
  src/core/sessiondata.cpp d21ab21 
  src/core/simplejob.cpp 440fa62 
  src/core/slave.cpp 5ae4d97 
  src/core/slavebase.cpp a9bf648 
  src/core/statjob.cpp e55e3b4 
  src/core/storedtransferjob.cpp 3e86cb9 
  src/core/tcpslavebase.cpp 2bd1c0f 
  src/filewidgets/defaults-kfile.h 825a297 
  src/filewidgets/defaultviewadapter_p.h 79381e4 
  src/filewidgets/kdiroperator.cpp 9c2b6be 
  src/filewidgets/kfilecopytomenu.cpp dab5db6 
  src/filewidgets/kfileplacesitem.cpp 1748188 
  src/filewidgets/kfileplacesmodel.cpp e9d37a9 
  src/filewidgets/kfileplacesview.cpp 4121191 
  src/filewidgets/knewfilemenu.cpp b249898 
  src/filewidgets/kurlnavigator.cpp 64d2a6d 
  src/ioslaves/ftp/ftp.cpp 7477a6a 
  src/ioslaves/http/http.cpp 76da711 
  src/ioslaves/http/kcookiejar/kcookiejar.cpp c06882a 
  src/ioslaves/http/kcookiejar/kcookieserver.cpp 3e7dd8c 
  src/ioslaves/trash/kcmtrash.cpp 79c2ca7 
  src/ioslaves/trash/ktrash.cpp 298a201 
  src/ioslaves/trash/tests/testtrash.cpp 339aa19 
  src/ioslaves/trash/trashimpl.cpp 26d9ea8 
  src/kcms/kio/kcookiespolicyselectiondlg.cpp fcd0763 
  src/kcms/kio/kproxydlg.cpp fe2583e 
  src/kcms/kio/main.cpp 387cf89 
  src/kcms/kio/useragentdlg.cpp a6560b5 
  src/kcms/kio/useragentinfo.cpp 1459fcc 
  src/kcms/kio/useragentselectordlg.cpp 3952761 
  src/kioexec/main.cpp 6f4540f 
  src/kntlm/kntlm.cpp ed6f388 
  src/kpac/script.cpp 9b126ca 
  src/kpasswdserver/kpasswdserver.cpp 7a53300 
  src/kssld/kssld.cpp fcc3bed 
  src/protocoltojson/main.cpp 05b9364 
  src/urifilters/ikws/kuriikwsfiltereng.h c8fbcd2 
  src/urifilters/ikws/searchprovider.cpp 8652997 
  src/urifilters/ikws/searchproviderdlg.cpp 4effe08 
  src/urifilters/localdomain/localdomainurifilter.cpp 4ebd1c0 
  src/urifilters/shorturi/kshorturifilter.cpp c9024b0 
  src/widgets/accessmanager.cpp 68f4a27 
  src/widgets/accessmanagerreply_p.cpp 2ade6fd 
  src/widgets/delegateanimationhandler.cpp 8e08a0c 
  src/widgets/fileundomanager.cpp c9790ab 
  src/widgets/kbuildsycocaprogressdialog.cpp 9ee0644 
  src/widgets/kfileitemactions.cpp 4343da7 
  src/widgets/kopenwithdialog.cpp 808af73 
  src/widgets/kpropertiesdialog.cpp a4fdeb9 
  src/widgets/krun.cpp af48473 
  src/widgets/kurlcompletion.cpp 7160491 
  src/widgets/kurlrequester.cpp 06e9ddb 

Diff: https://git.reviewboard.kde.org/r/126774/diff/


Testing
---

I ran the entire test suite with the exact same results as master:


Running tests...
Test project /home/russellg/KDE/kio/build
  Start  1: testtrash
 1/47 Test  #1: testtrash    Passed
1.24 sec
  Start  2: kpasswdservertest
 2/47 Test  #2: kpasswdservertest    Passed
0.73 sec
  Start  3: kiocore-kacltest
 3/47 Test  #3: kiocore-kacltest .***Failed
0.04 sec
  Start  4: kiocore-listdirtest
 4/47 Test  #4: kiocore-listdirtest ..   Passed
0.18 sec
  Start  5: kiocore-kmountpointtest
 5/47 Test  #5: kiocore-kmountpointtest ..   Passed
0.04 sec
  Start  6: kiocore-upurltest
 6/47 Test  #6: kiocore-upurltest

[Differential] [Request, 69 lines] D4628: Add ability to disable saving in `KTextEditor::Document`

[Russell Greene]

russellg created this revision.
russellg set the repository for this revision to R39 KTextEditor.
Restricted Application added subscribers: Frameworks, kwrite-devel.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  I'm currently writing an application where the user is expected to type some 
code in, but it isn't then saved to a file, but it is just passed back to the 
application in memory.
  
  It's misleading to the user for them to press Ctrl+S and then a save dialog 
comes up--they shouldn't be saving it!
  
  Here's my fix. Any suggestions are welcome.

TEST PLAN
  I added a basic test to the test suite, it's not very good though. I wanted 
to make sure that the `documentSaveAs` function was failing _before_ I called 
`setSaveEnabled`, but that would require somehow pressing "cancel" on the file 
dialog which I do not know how to do, if it's possible at all.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D4628

AFFECTED FILES
  autotests/src/katedocument_test.cpp
  autotests/src/katedocument_test.h
  src/document/katedocument.cpp
  src/document/katedocument.h
  src/include/ktexteditor/document.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: russellg
Cc: kwrite-devel, #frameworks

[Differential] [Updated, 70 lines] D4628: Add ability to disable saving in `KTextEditor::Document`

[Russell Greene]

russellg removed R39 KTextEditor as the repository for this revision.
russellg updated this revision to Diff 11390.
russellg added a comment.


  Updated the test to be slightly better. Use `QVERIFY(...)` instead of 
`QCOMPARE(..., true)` in one case, and make sure that `saveEnabled()` is false 
after calling `setSaveEnabled(false)`.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4628?vs=11389=11390

REVISION DETAIL
  https://phabricator.kde.org/D4628

AFFECTED FILES
  autotests/src/katedocument_test.cpp
  autotests/src/katedocument_test.h
  src/document/katedocument.cpp
  src/document/katedocument.h
  src/include/ktexteditor/document.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: russellg
Cc: kwrite-devel, #frameworks

[Differential] [Request, 1 line] D4778: Add include that is needed in msys2

[Russell Greene]

russellg created this revision.
russellg added projects: Frameworks, Windows.

REVISION SUMMARY
  In the latest msys2, they updated some windows headers to require this extra 
include. It's not specific to this project, openFrameworks had to do it as well 
.

TEST PLAN
  None, it just fixes a build. If I could get some guidance I would be willing 
to try to get a CI build for it.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D4778

AFFECTED FILES
  src/solid/devices/backends/win/winbattery.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: russellg, #frameworks
Cc: kfunk

[Differential] [Commented On] D4628: Add ability to disable saving in `KTextEditor::Document`

[Russell Greene]

russellg added a comment.


  Sounds good, that's good idea!

REVISION DETAIL
  https://phabricator.kde.org/D4628

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: russellg, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, #frameworks

[Differential] [Abandoned] D4628: Add ability to disable saving in `KTextEditor::Document`

[Russell Greene]

russellg abandoned this revision.

REVISION DETAIL
  https://phabricator.kde.org/D4628

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: russellg, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, #frameworks

D4778: Add include that is needed in msys2

[Russell Greene]

russellg added a comment.


  So where does this go now?
  
  Sorry I've never submitted a patch in phabricator before :P
  
  Am I supposed to merge this, or is somebody else?

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D4778

To: russellg, #frameworks, kfunk
Cc: kfunk

D4778: Add include that is needed in msys2

[Russell Greene]

russellg added a comment.


  Alright, I will in the future :)

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D4778

To: russellg, #frameworks, kfunk
Cc: kfunk