D28044: C: remove ' as digit separator

[jonathan poelen]

jpoelen created this revision.
jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
jpoelen added projects: Kate, Frameworks.
jpoelen requested review of this revision.

REVISION SUMMARY
  This is not in C standard, but only in C++

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  c (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28044

AFFECTED FILES
  data/syntax/c.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D28045: Lua: add # as additional deliminator to activate auto-completion with `#something`

[jonathan poelen]

jpoelen created this revision.
jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
jpoelen added projects: Kate, Frameworks.
jpoelen requested review of this revision.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  lua (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28045

AFFECTED FILES
  data/syntax/lua.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D10621: Highlighting Indexer: list of suggestions

[jonathan poelen]

jpoelen updated this revision to Diff 30448.
jpoelen added a comment.


  New suggestions:
  
  - Regex "^xyz\b" -> WordDetect with column=0
  - Regex "^xyz" with xyz a string of more than 2 characters -> StringDetext 
with column=0
  
  Output:
  
  - Double quote are no longer escaped
  - "^\\s*" is no longer deleted

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10621?vs=29869&id=30448

BRANCH
  suggest

REVISION DETAIL
  https://phabricator.kde.org/D10621

AFFECTED FILES
  src/indexer/katehighlightingindexer.cpp

To: jpoelen, dhaumann
Cc: vkrause, #framework_syntax_highlighting, dhaumann, #frameworks, michaelh, 
genethomas, ngraham, cullmann

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

[jonathan poelen]

jpoelen updated this revision to Diff 32852.
jpoelen added a comment.


  - SQL: various improvements and fix if/case/loop/end detection with SQL 
(Oracle)
  - add sql tests
  - update kateversion to 5.0 and allows multiple spaces for "end if", "end 
case" and "end loop"

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11470?vs=29866&id=32852

BRANCH
  new_sql_oracle

REVISION DETAIL
  https://phabricator.kde.org/D11470

AFFECTED FILES
  autotests/folding/highlight.cmake.fold
  autotests/folding/test.sql.fold
  autotests/folding/test.sql_oracle.fold
  autotests/html/test.sql.html
  autotests/html/test.sql_oracle.html
  autotests/input/highlight.sh
  autotests/input/highlight.sh.syntax
  autotests/input/test.sql
  autotests/input/test.sql_oracle
  autotests/reference/test.sql.ref
  autotests/reference/test.sql_oracle.ref
  data/syntax/sql-mysql.xml
  data/syntax/sql-oracle.xml
  data/syntax/sql-postgresql.xml
  data/syntax/sql.xml
  src/indexer/katehighlightingindexer.cpp
  src/lib/rule.cpp
  src/lib/rule_p.h

To: jpoelen, #framework_syntax_highlighting, dhaumann
Cc: #frameworks, michaelh, bruns

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

[jonathan poelen]

jpoelen updated this revision to Diff 32853.
jpoelen added a comment.


  - autotests/input/highlight.sh.syntax and autotests/input/highlight.sh are 
restored

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11470?vs=32852&id=32853

BRANCH
  new_sql_oracle

REVISION DETAIL
  https://phabricator.kde.org/D11470

AFFECTED FILES
  autotests/folding/highlight.cmake.fold
  autotests/folding/test.sql.fold
  autotests/folding/test.sql_oracle.fold
  autotests/html/test.sql.html
  autotests/html/test.sql_oracle.html
  autotests/input/test.sql
  autotests/input/test.sql_oracle
  autotests/reference/test.sql.ref
  autotests/reference/test.sql_oracle.ref
  data/syntax/sql-mysql.xml
  data/syntax/sql-oracle.xml
  data/syntax/sql-postgresql.xml
  data/syntax/sql.xml
  src/indexer/katehighlightingindexer.cpp
  src/lib/rule.cpp
  src/lib/rule_p.h

To: jpoelen, #framework_syntax_highlighting, dhaumann
Cc: #frameworks, michaelh, bruns

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

[jonathan poelen]

jpoelen updated this revision to Diff 32855.
jpoelen added a comment.


  - diff with the proper branch

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11470?vs=32853&id=32855

BRANCH
  new_sql_oracle

REVISION DETAIL
  https://phabricator.kde.org/D11470

AFFECTED FILES
  autotests/folding/test.sql.fold
  autotests/folding/test.sql_oracle.fold
  autotests/html/test.sql.html
  autotests/html/test.sql_oracle.html
  autotests/input/test.sql
  autotests/input/test.sql_oracle
  autotests/reference/test.sql.ref
  autotests/reference/test.sql_oracle.ref
  data/syntax/sql-mysql.xml
  data/syntax/sql-oracle.xml
  data/syntax/sql-postgresql.xml
  data/syntax/sql.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann
Cc: #frameworks, michaelh, bruns

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

[jonathan poelen]

jpoelen updated this revision to Diff 32860.
jpoelen added a comment.


  - SQL: various improvements and fix if/case/loop/end detection with SQL 
(Oracle)
  - add sql tests
  - update kateversion to 5.0 and allows multiple spaces for "end if", "end 
case" and "end loop"
  - autotests/input/highlight.sh.syntax and autotests/input/highlight.sh are 
restored

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11470?vs=32855&id=32860

BRANCH
  sql2

REVISION DETAIL
  https://phabricator.kde.org/D11470

AFFECTED FILES
  autotests/folding/test.sql.fold
  autotests/folding/test.sql_oracle.fold
  autotests/html/test.sql.html
  autotests/html/test.sql_oracle.html
  autotests/input/test.sql
  autotests/input/test.sql_oracle
  autotests/reference/test.sql.ref
  autotests/reference/test.sql_oracle.ref
  data/syntax/sql-mysql.xml
  data/syntax/sql-oracle.xml
  data/syntax/sql-postgresql.xml
  data/syntax/sql.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann
Cc: #frameworks, michaelh, bruns

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

[jonathan poelen]

jpoelen updated this revision to Diff 32861.
jpoelen added a comment.


  I am completely lost with `arc diff`. The command adds files that I did not 
normally modify in this branch and specifiying a reference commit does not seem 
to work.
  
  I ended up doing everything through a new branch, sorry to rot the history 
like this :/.

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11470?vs=32860&id=32861

BRANCH
  sql2

REVISION DETAIL
  https://phabricator.kde.org/D11470

AFFECTED FILES
  autotests/folding/test.sql.fold
  autotests/folding/test.sql_oracle.fold
  autotests/html/test.sql.html
  autotests/html/test.sql_oracle.html
  autotests/input/test.sql
  autotests/input/test.sql_oracle
  autotests/reference/test.sql.ref
  autotests/reference/test.sql_oracle.ref
  data/syntax/sql-mysql.xml
  data/syntax/sql-oracle.xml
  data/syntax/sql-postgresql.xml
  data/syntax/sql.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann
Cc: #frameworks, michaelh, bruns

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

[jonathan poelen]

jpoelen added a comment.


  The page on Phabricator is much better than before. My problem was about 
creating a branch without the `-t` option which requires me to specify a 
commit/branch to do the diff.
  
  I also realized later that I was reloading a page from the revision history, 
so I always saw the same bad file list and did not understand why. In fact, the 
last 3 diff are exactly the same.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D11470

To: jpoelen, #framework_syntax_highlighting, dhaumann
Cc: rkflx, #frameworks, michaelh, bruns

D12569: Pony: fix identifier and keyword

[jonathan poelen]

jpoelen created this revision.
jpoelen added a reviewer: dhaumann.
jpoelen added a project: Framework: Syntax Highlighting.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
jpoelen requested review of this revision.

REVISION SUMMARY
  - missing `elseiftype` keyword
  - fix DataType of 1 or 2 characters or starting with `_`
  - `'` suffix is valid for a variable

TEST PLAN
  Run the tests.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix_pony

REVISION DETAIL
  https://phabricator.kde.org/D12569

AFFECTED FILES
  autotests/folding/highlight.pony.fold
  autotests/html/highlight.pony.html
  autotests/input/highlight.pony
  autotests/reference/highlight.pony.ref
  data/syntax/pony.xml

To: jpoelen, dhaumann
Cc: #frameworks, michaelh, genethomas, bruns, cullmann, vkrause, dhaumann

D12689: Lua: updated for Lua5.3

[jonathan poelen]

jpoelen created this revision.
jpoelen added reviewers: dhaumann, Framework: Syntax Highlighting.
jpoelen added projects: Framework: Syntax Highlighting, Frameworks.
Restricted Application added a subscriber: Frameworks.
jpoelen requested review of this revision.

REVISION SUMMARY
  Add of:
  
  - shebang
  - hexadecimal float
  - special char: \u{xxx}, \xXX, \ddd and `\z`
  - bitwise operator
  - metamethod
  - some other improvements

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  lua

REVISION DETAIL
  https://phabricator.kde.org/D12689

AFFECTED FILES
  autotests/folding/highlight.lua.fold
  autotests/html/highlight.lua.html
  autotests/input/highlight.lua
  autotests/reference/highlight.lua.ref
  data/syntax/doxygenlua.xml
  data/syntax/lua.xml

To: jpoelen, dhaumann, #framework_syntax_highlighting
Cc: #frameworks, michaelh, genethomas, bruns, cullmann, vkrause, dhaumann

D12854: Awk: fix regex in a function and update syntax for gawk

[jonathan poelen]

jpoelen created this revision.
jpoelen added a project: Framework: Syntax Highlighting.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
jpoelen requested review of this revision.

REVISION SUMMARY
  - fix `match(str, /it's a regex, not an operator and normal text/)`
  - fix escaped characters
  - add `Symbol`, `Separator Symbol` and `Control Flow` style
  - add some functions and keywords.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  awk

REVISION DETAIL
  https://phabricator.kde.org/D12854

AFFECTED FILES
  autotests/folding/highlight.awk.fold
  autotests/html/highlight.awk.html
  autotests/input/highlight.awk
  autotests/reference/highlight.awk.ref
  data/syntax/awk.xml

To: jpoelen
Cc: kde-frameworks-devel, michaelh, genethomas, ngraham, bruns, cullmann, 
vkrause, dhaumann

D12854: Awk: fix regex in a function and update syntax for gawk

[jonathan poelen]

jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D12854

To: jpoelen, #framework_syntax_highlighting, dhaumann
Cc: kde-frameworks-devel, michaelh, genethomas, ngraham, bruns, cullmann, 
vkrause, dhaumann

D12689: Lua: updated for Lua5.3

[jonathan poelen]

jpoelen added a comment.


  There is indeed a problem with Kate, but it works with KSyntaxHighlighting. I 
will look in what part of doxygenlua.xml the problem is.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D12689

To: jpoelen, dhaumann, #framework_syntax_highlighting
Cc: kde-frameworks-devel, michaelh, genethomas, ngraham, bruns, cullmann, 
vkrause, dhaumann

D12860: DoxygenLua: fix closing comment blocks

[jonathan poelen]

jpoelen created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
jpoelen requested review of this revision.

REVISION SUMMARY
  Kate-editor needs the context to be marked dynamic to use a placeholder in a 
dynamic rule.
  
  BUG: 394184

TEST PLAN
  Open Kate with the code lua below:
  
[[
commented out
]]
local test
  
  An equivalent is already in autotests/input/highlight.lua

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  luafix

REVISION DETAIL
  https://phabricator.kde.org/D12860

AFFECTED FILES
  data/syntax/doxygenlua.xml

To: jpoelen
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12860: DoxygenLua: fix closing comment blocks

[jonathan poelen]

jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D12860

To: jpoelen, #framework_syntax_highlighting, dhaumann
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12860: DoxygenLua: fix closing comment blocks

[jonathan poelen]

jpoelen edited the test plan for this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D12860

To: jpoelen, #framework_syntax_highlighting, dhaumann
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12854: Awk: fix regex in a function and update syntax for gawk

[jonathan poelen]

jpoelen updated this revision to Diff 34098.
jpoelen added a comment.


  - Awk: add collating symbols and equivalence classes

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12854?vs=34076&id=34098

BRANCH
  awk

REVISION DETAIL
  https://phabricator.kde.org/D12854

AFFECTED FILES
  autotests/folding/highlight.awk.fold
  autotests/html/highlight.awk.html
  autotests/input/highlight.awk
  autotests/reference/highlight.awk.ref
  data/syntax/awk.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann
Cc: kde-frameworks-devel, michaelh, genethomas, ngraham, bruns, cullmann, 
vkrause, dhaumann

D12689: Lua: updated for Lua5.3

[jonathan poelen]

jpoelen added a comment.


  @dhaumann The difference is in the `dynamic` attribute of a context. Kate 
propagates the captures only if the value is `true` whereas SyntaxHighlighting 
never looks at that value and only uses the `dynamic` attribute of the rules.
  
  Personally, I find that having this attribute in contexts unnecessarily 
complicates the writing of rules. Same for `fallthrough` which is redundant to 
`fallthroughContext`.
  
  Doxygenlua.xml fixed in D12860 

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D12689

To: jpoelen, dhaumann, #framework_syntax_highlighting
Cc: vkrause, kde-frameworks-devel, michaelh, genethomas, ngraham, bruns, 
cullmann, dhaumann

D13394: C++: update for c++20 and fix some syntax errors

[jonathan poelen]

jpoelen created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
jpoelen requested review of this revision.

REVISION SUMMARY
  - new keywords, attributes and standard macros
  - hexadecimal floatting point (c++17)
  - highlight UDL (standard and user)
  - fix some syntax error (`operator""_x`, `#elif 0`, ...)
  - highlight the content of #define to the color of c++

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  cpp

REVISION DETAIL
  https://phabricator.kde.org/D13394

AFFECTED FILES
  autotests/folding/example.rmd.fold
  autotests/folding/folding.cpp.fold
  autotests/folding/highlight.cpp.fold
  autotests/folding/highlight.lex.fold
  autotests/folding/highlight.y.fold
  autotests/folding/preprocessor-bug363280.cpp.fold
  autotests/html/folding.cpp.html
  autotests/html/highlight.cpp.html
  autotests/input/highlight.cpp
  autotests/reference/folding.cpp.ref
  autotests/reference/highlight.cpp.ref
  data/syntax/gcc.xml
  data/syntax/isocpp.xml

To: jpoelen
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13394: C++: update for c++20 and fix some syntax errors

[jonathan poelen]

jpoelen edited the summary of this revision.
jpoelen added a reviewer: dhaumann.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D13394

To: jpoelen, dhaumann
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13395: Pony: fix single quote escape and a possible infinite loop with #

[jonathan poelen]

jpoelen created this revision.
jpoelen added a reviewer: dhaumann.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
jpoelen requested review of this revision.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix-pony

REVISION DETAIL
  https://phabricator.kde.org/D13395

AFFECTED FILES
  autotests/folding/highlight.pony.fold
  autotests/html/highlight.pony.html
  autotests/input/highlight.pony
  autotests/reference/highlight.pony.ref
  data/syntax/pony.xml

To: jpoelen, dhaumann
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13394: C++: update for c++20 and fix some syntax errors

[jonathan poelen]

jpoelen updated this revision to Diff 36229.
jpoelen added a comment.


  - C++: test with clang:: in an attribute

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13394?vs=35729&id=36229

BRANCH
  cpp

REVISION DETAIL
  https://phabricator.kde.org/D13394

AFFECTED FILES
  autotests/folding/example.rmd.fold
  autotests/folding/folding.cpp.fold
  autotests/folding/highlight.cpp.fold
  autotests/folding/highlight.lex.fold
  autotests/folding/highlight.y.fold
  autotests/folding/preprocessor-bug363280.cpp.fold
  autotests/html/folding.cpp.html
  autotests/html/highlight.cpp.html
  autotests/input/highlight.cpp
  autotests/reference/folding.cpp.ref
  autotests/reference/highlight.cpp.ref
  data/syntax/gcc.xml
  data/syntax/isocpp.xml

To: jpoelen, dhaumann
Cc: cullmann, kde-frameworks-devel, michaelh, ngraham, bruns

D13394: C++: update for c++20 and fix some syntax errors

[jonathan poelen]

jpoelen added inline comments.

INLINE COMMENTS

> dhaumann wrote in gcc.xml:576-577
> These can be WordDetect as well, right?

It does not work because of ':'. But Putting it in `weakDeliminator` will break 
things.
For this to work, it would need `additionalDeliminator` and `weakDeliminator` 
attributes for WordDetect (and Keyword).

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  cpp

REVISION DETAIL
  https://phabricator.kde.org/D13394

To: jpoelen, dhaumann, cullmann
Cc: cullmann, kde-frameworks-devel, michaelh, ngraham, bruns

D13394: C++: update for c++20 and fix some syntax errors

[jonathan poelen]

jpoelen added a comment.


  I do not have a developer account, but I can do it. This is not a problem 
because I will contribute again.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  cpp

REVISION DETAIL
  https://phabricator.kde.org/D13394

To: jpoelen, dhaumann, cullmann
Cc: cullmann, kde-frameworks-devel, michaelh, ngraham, bruns

D13829: Lua: fix multi-line string

[jonathan poelen]

jpoelen created this revision.
jpoelen added a reviewer: dhaumann.
Restricted Application added a project: Frameworks.
Restricted Application edited subscribers, added: kde-frameworks-devel; 
removed: Frameworks.
jpoelen requested review of this revision.

REVISION SUMMARY
  Strings that end with \z or \ can continue to the next line
  
  BUG: 395515

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  lua

REVISION DETAIL
  https://phabricator.kde.org/D13829

AFFECTED FILES
  autotests/folding/highlight.lua.fold
  autotests/html/highlight.lua.html
  autotests/input/highlight.lua
  autotests/reference/highlight.lua.ref
  data/syntax/lua.xml

To: jpoelen, dhaumann
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13394: C++: update for c++20 and fix some syntax errors

[jonathan poelen]

jpoelen added a comment.


  Thank you, but I already made the request and it was accepted last night. I 
will do the next push :)

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D13394

To: jpoelen, dhaumann, cullmann
Cc: kwrite-devel, cullmann, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, sars, dhaumann

D14137: CSS: update syntax and fix some errors

[jonathan poelen]

jpoelen created this revision.
jpoelen added a reviewer: dhaumann.
jpoelen added projects: Frameworks, Framework: Syntax Highlighting.
Restricted Application added a project: Kate.
Restricted Application edited subscribers, added: kde-frameworks-devel, 
kwrite-devel; removed: Frameworks.
jpoelen requested review of this revision.

REVISION SUMMARY
  - fix tag followed by a pseudo-class in a nested rule (@media, ...)
  - fix constraint in a rule
  - fix Kate auto-completion for properties and rules
  
  New highlighting categories
  
  - Keyword
  - Operator
  - Separator Symbol
  - SpecialChar
  - Variable
  - Value Keyword
  - Color
  - Number
  - Unit
  - Selector Tag

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  css

REVISION DETAIL
  https://phabricator.kde.org/D14137

AFFECTED FILES
  autotests/folding/highlight.css.fold
  autotests/html/highlight.css.html
  autotests/html/review128925-1.css.html
  autotests/html/review128925-2.css.html
  autotests/html/test.htm.html
  autotests/input/highlight.css
  autotests/reference/highlight.css.ref
  autotests/reference/review128925-1.css.ref
  autotests/reference/review128925-2.css.ref
  autotests/reference/test.css.ref
  autotests/reference/test.htm.ref
  data/syntax/css.xml

To: jpoelen, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, genethomas, kevinapavew, 
ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

D14137: CSS: update syntax and fix some errors

[jonathan poelen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:423239c45ec5: CSS: update syntax and fix some errors 
(authored by jpoelen).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14137?vs=37815&id=37912

REVISION DETAIL
  https://phabricator.kde.org/D14137

AFFECTED FILES
  autotests/folding/highlight.css.fold
  autotests/html/highlight.css.html
  autotests/html/review128925-1.css.html
  autotests/html/review128925-2.css.html
  autotests/html/test.htm.html
  autotests/input/highlight.css
  autotests/reference/highlight.css.ref
  autotests/reference/review128925-1.css.ref
  autotests/reference/review128925-2.css.ref
  autotests/reference/test.css.ref
  autotests/reference/test.htm.ref
  data/syntax/css.xml

To: jpoelen, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, genethomas, kevinapavew, 
ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

D14137: CSS: update syntax and fix some errors

[jonathan poelen]

jpoelen added a comment.


  It is done. So much emotion :')

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14137

To: jpoelen, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, genethomas, kevinapavew, 
ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

D14282: CSS: fix test reference of the previous commit

[jonathan poelen]

jpoelen created this revision.
jpoelen added a reviewer: dhaumann.
Restricted Application added projects: Kate, Frameworks.
jpoelen requested review of this revision.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix_cxx

REVISION DETAIL
  https://phabricator.kde.org/D14282

AFFECTED FILES
  autotests/reference/highlight.css.ref
  autotests/reference/review128925-1.css.ref
  autotests/reference/review128925-2.css.ref

To: jpoelen, dhaumann
Cc: kde-frameworks-devel, kwrite-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14283: C++: fix standard floating-point literals

[jonathan poelen]

jpoelen created this revision.
jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added a subscriber: kwrite-devel.
jpoelen requested review of this revision.

REVISION SUMMARY
  BUG: 389693

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix_cpp_udl

REVISION DETAIL
  https://phabricator.kde.org/D14283

AFFECTED FILES
  autotests/folding/highlight.cpp.fold
  autotests/html/highlight.cpp.html
  autotests/input/highlight.cpp
  autotests/reference/highlight.cpp.ref
  data/syntax/isocpp.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann
Cc: kde-frameworks-devel, kwrite-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14283: C++: fix standard floating-point literals

[jonathan poelen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:7a2ae6be229b: C++: fix standard floating-point literals 
(authored by jpoelen).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14283?vs=38218&id=38276

REVISION DETAIL
  https://phabricator.kde.org/D14283

AFFECTED FILES
  autotests/folding/highlight.cpp.fold
  autotests/html/highlight.cpp.html
  autotests/input/highlight.cpp
  autotests/reference/highlight.cpp.ref
  data/syntax/isocpp.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann
Cc: kde-frameworks-devel, kwrite-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14282: CSS: fix test reference of the previous commit

[jonathan poelen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:a82af177bc2f: CSS: fix test reference of the previous 
commit (authored by jpoelen).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14282?vs=38217&id=38277

REVISION DETAIL
  https://phabricator.kde.org/D14282

AFFECTED FILES
  autotests/reference/highlight.css.ref
  autotests/reference/review128925-1.css.ref
  autotests/reference/review128925-2.css.ref

To: jpoelen, dhaumann
Cc: kde-frameworks-devel, kwrite-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14434: add functions to access keywords

[jonathan poelen]

jpoelen created this revision.
jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added a subscriber: kwrite-devel.
jpoelen requested review of this revision.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  keywordlist

REVISION DETAIL
  https://phabricator.kde.org/D14434

AFFECTED FILES
  autotests/syntaxrepository_test.cpp
  src/lib/definition.cpp
  src/lib/definition.h
  src/lib/keywordlist.cpp
  src/lib/keywordlist_p.h

To: jpoelen, #framework_syntax_highlighting, dhaumann
Cc: kde-frameworks-devel, kwrite-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14434: add functions to access keywords

[jonathan poelen]

jpoelen added a comment.


  This follows 
https://mail.kde.org/pipermail/kde-frameworks-devel/2018-July/066564.html

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14434

To: jpoelen, #framework_syntax_highlighting, dhaumann
Cc: kde-frameworks-devel, kwrite-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14603: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting

[jonathan poelen]

jpoelen created this revision.
jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel.
jpoelen requested review of this revision.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  scss

REVISION DETAIL
  https://phabricator.kde.org/D14603

AFFECTED FILES
  autotests/folding/highlight.scss.fold
  autotests/html/highlight.css.html
  autotests/html/highlight.scss.html
  autotests/html/review128925-1.scss.html
  autotests/html/review128925-2.scss.html
  autotests/input/highlight.scss
  autotests/reference/highlight.css.ref
  autotests/reference/highlight.scss.ref
  autotests/reference/review128925-1.scss.ref
  autotests/reference/review128925-2.css.ref
  autotests/reference/review128925-2.scss.ref
  autotests/reference/test.css.ref
  data/syntax/css.xml
  data/syntax/scss.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann
Cc: kwrite-devel, dhaumann, kde-frameworks-devel, 
#framework_syntax_highlighting, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars

D14603: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting

[jonathan poelen]

jpoelen added a comment.


  I copied all the keywords in the css.xml file and it's a shame. I think that 
Keyword could refer to those of other files with `##` as for IncludeRules.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14603

To: jpoelen, #framework_syntax_highlighting, dhaumann
Cc: kwrite-devel, dhaumann, kde-frameworks-devel, 
#framework_syntax_highlighting, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars

D14603: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting

[jonathan poelen]

jpoelen added a comment.


  Yes, I can start tomorrow.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14603

To: jpoelen, #framework_syntax_highlighting, dhaumann, vkrause
Cc: cullmann, kwrite-devel, dhaumann, kde-frameworks-devel, 
#framework_syntax_highlighting, michaelh, kevinapavew, ngraham, bruns, 
demsking, sars

D14632: keyword rule: Spport for keywords inclusion from another language/file

[jonathan poelen]

jpoelen created this revision.
jpoelen added reviewers: Framework: Syntax Highlighting, cullmann, dhaumann.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel.
jpoelen requested review of this revision.

REVISION SUMMARY
  The presence of "##" in the name of the keyword rule indicates that it is 
necessary to look for the list in another file (format: 
"listName##languageName")

TEST PLAN
  A quick test was done by removing the "properties" list from scss.xml and 
with "properties##CSS" as the keyword name.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  keyword_rule

REVISION DETAIL
  https://phabricator.kde.org/D14632

AFFECTED FILES
  src/indexer/katehighlightingindexer.cpp
  src/lib/rule.cpp

To: jpoelen, #framework_syntax_highlighting, cullmann, dhaumann
Cc: kwrite-devel, vkrause, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D14632: keyword rule: Spport for keywords inclusion from another language/file

[jonathan poelen]

jpoelen edited the summary of this revision.
jpoelen edited the test plan for this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14632

To: jpoelen, #framework_syntax_highlighting, cullmann, dhaumann
Cc: kwrite-devel, vkrause, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D14632: keyword rule: Spport for keywords inclusion from another language/file

[jonathan poelen]

jpoelen edited the summary of this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14632

To: jpoelen, #framework_syntax_highlighting, cullmann, dhaumann
Cc: kwrite-devel, vkrause, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D14632: keyword rule: Spport for keywords inclusion from another language/file

[jonathan poelen]

jpoelen added a comment.


  I just thought of `Definition::keywordLists()` which does not list the 
keywords used by this new syntax.
  
  - Should we add the lists used as and when parsing?
  - Move the functionality on the tag ``? (``, ` 
name##language  `)
  - Other?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14632

To: jpoelen, #framework_syntax_highlighting, cullmann, dhaumann
Cc: kwrite-devel, vkrause, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

[jonathan poelen]

jpoelen added a comment.


  There have been changes in the xml files that will cause conflicts. I would 
look in the next few days.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D11470

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, cullmann, rkflx, michaelh, kevinapavew, 
ngraham, bruns, demsking, sars, dhaumann

D14603: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting

[jonathan poelen]

jpoelen added a comment.


  Ok, i'm doing this in the week.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  scss

REVISION DETAIL
  https://phabricator.kde.org/D14603

To: jpoelen, #framework_syntax_highlighting, dhaumann, vkrause, cullmann
Cc: cullmann, kwrite-devel, dhaumann, kde-frameworks-devel, 
#framework_syntax_highlighting, michaelh, kevinapavew, ngraham, bruns, 
demsking, sars

D21421: Tcsh: fix operators and keywords

[jonathan poelen]

jpoelen created this revision.
jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
jpoelen added projects: Framework: Syntax Highlighting, Kate, Frameworks.
jpoelen requested review of this revision.

REVISION SUMMARY
  - missing `foreach` and `end`
  - fix folding with `if (expr) cmd`
  - missing != with `[ ... ]`
  - rules for arithmetic comparison
  - add dsControlFlow style
  - `[[ ... ]]` does not exists

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix_tcsh (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21421

AFFECTED FILES
  autotests/folding/highlight.tcsh.fold
  autotests/html/highlight.tcsh.html
  autotests/input/highlight.tcsh
  autotests/reference/highlight.tcsh.ref
  data/syntax/tcsh.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kde-frameworks-devel, kwrite-devel, gennad, bmortimer, domson, michaelh, 
genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

D21421: Tcsh: fix operators and keywords

[jonathan poelen]

jpoelen added a comment.


  I forgot to ask about running the tests. Is it normal that system syntax 
files take precedence if we have an `index.katesyntax`? Currently I have to run 
the tests by setting the environment variable `XDG_DATA_DIRS`.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix_tcsh (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21421

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kde-frameworks-devel, kwrite-devel, gennad, bmortimer, domson, michaelh, 
genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

D21421: Tcsh: fix operators and keywords

[jonathan poelen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:4d2329e3f63e: Tcsh: fix operators and keywords (authored 
by jpoelen).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21421?vs=58696&id=58742

REVISION DETAIL
  https://phabricator.kde.org/D21421

AFFECTED FILES
  autotests/folding/highlight.tcsh.fold
  autotests/html/highlight.tcsh.html
  autotests/input/highlight.tcsh
  autotests/reference/highlight.tcsh.ref
  data/syntax/tcsh.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kde-frameworks-devel, kwrite-devel, gennad, bmortimer, domson, michaelh, 
genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

D21421: Tcsh: fix operators and keywords

[jonathan poelen]

jpoelen added a comment.


  OK I understand. Initially I had not changed the version number of txsh.xml 
and it is based on the reference in 
`/usr/share/org.kde.syntax-highlighting/syntax/index.katesyntax` rather than in 
the repository.
  And the fact that the versions in the index file were newer than my xml 
files... I had errors with highlight.fish.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D21421

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kde-frameworks-devel, kwrite-devel, gennad, bmortimer, domson, michaelh, 
genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

D21508: Jam: various improvements and fixes

[jonathan poelen]

jpoelen created this revision.
jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
jpoelen added projects: Kate, Frameworks.
jpoelen requested review of this revision.

REVISION SUMMARY
  - fix `x=`: is a rule named `x=`, not a variable
  - fix `exe onx`: is a rule call, not a variable
  - fix `ifxxx`, `rulexxx`, etc: not keywords
  - fix `variable default = xxx ;`
  - fix keywords and operators in a condition: they must be separated by spaces
  - fix `on target`
  - fix `switch`
  - fix `class` and `module`
  - fix `for local x`
  - new styles: Feature and FeatureOperator for ``, `-`, 
`abc:abc`, `abc/abc`, `abc&&def`
  - don't use black color in Rule

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix_jam (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21508

AFFECTED FILES
  autotests/folding/Jamroot.fold
  autotests/html/Jamroot.html
  autotests/input/Jamroot
  autotests/reference/Jamroot.ref
  data/syntax/jam.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kde-frameworks-devel, kwrite-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D21508: Jam: various improvements and fixes

[jonathan poelen]

jpoelen added a comment.


  I left it because it goes well with dark or light themes, but I removed it. 
Is the policy the same for bold, underlined and italic as for color? Because a 
basic applied distinction between Comment and CommentTitle seems to me 
preferable. I imagine not, but I would like to be sure.
  
  In any case I have to do an update because I mixed class and module :/

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix_jam (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21508

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kde-frameworks-devel, kwrite-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D21508: Jam: various improvements and fixes

[jonathan poelen]

jpoelen updated this revision to Diff 59150.
jpoelen added a comment.


  - fix module
  - remove hard coded color

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21508?vs=58930&id=59150

BRANCH
  fix_jam (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21508

AFFECTED FILES
  autotests/folding/Jamroot.fold
  autotests/html/Jamroot.html
  autotests/input/Jamroot
  autotests/reference/Jamroot.ref
  data/syntax/jam.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kde-frameworks-devel, kwrite-devel, LeGast00n, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D21585: C++: update for C++20

[jonathan poelen]

jpoelen created this revision.
jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
jpoelen added projects: Framework: Syntax Highlighting, Kate, Frameworks.
jpoelen requested review of this revision.

REVISION SUMMARY
  - new attributes: assert, ensures and expects
  - new types: char8_t
  - new keywords: consteval, import, module, concept, requires, co_await, 
co_return, co_yield

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  cpp2a (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21585

AFFECTED FILES
  autotests/folding/highlight.cpp.fold
  autotests/html/highlight.cpp.html
  autotests/input/highlight.cpp
  autotests/reference/highlight.cpp.ref
  data/syntax/isocpp.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, domson, 
michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, 
dhaumann

D21586: Add syntax definition for ninja build

[jonathan poelen]

jpoelen created this revision.
jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
jpoelen added projects: Framework: Syntax Highlighting, Kate, Frameworks.
jpoelen requested review of this revision.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  ninja (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21586

AFFECTED FILES
  autotests/folding/build.ninja.fold
  autotests/html/build.ninja.html
  autotests/input/build.ninja
  autotests/reference/build.ninja.ref
  data/syntax/ninja.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, domson, 
michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, 
dhaumann

D21587: Lua: update for Lua54 and end of function as Keyword rather than Control

[jonathan poelen]

jpoelen created this revision.
jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
jpoelen added projects: Framework: Syntax Highlighting, Kate, Frameworks.
jpoelen requested review of this revision.

REVISION SUMMARY
  function foo()
  
if x then
end <--- Control Flow
  
  end <--- Keyword

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  lua54 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21587

AFFECTED FILES
  autotests/html/highlight.lua.html
  autotests/html/test.pbl.html
  autotests/reference/highlight.lua.ref
  autotests/reference/test.pbl.ref
  data/syntax/lua.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, domson, 
michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, 
dhaumann

D21587: Lua: update for Lua54 and end of function as Keyword rather than Control

[jonathan poelen]

jpoelen edited the summary of this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D21587

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, domson, 
michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, 
dhaumann

D21585: C++: update for C++20

[jonathan poelen]

jpoelen updated this revision to Diff 59156.
jpoelen added a comment.


  oops, missing version increase

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21585?vs=59152&id=59156

BRANCH
  cpp2a (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21585

AFFECTED FILES
  autotests/folding/highlight.cpp.fold
  autotests/html/highlight.cpp.html
  autotests/input/highlight.cpp
  autotests/reference/highlight.cpp.ref
  data/syntax/isocpp.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, domson, 
michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, 
dhaumann

D21585: C++: update for C++20

[jonathan poelen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:9ba02971123d: C++: update for C++20 (authored by jpoelen).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21585?vs=59156&id=59162

REVISION DETAIL
  https://phabricator.kde.org/D21585

AFFECTED FILES
  autotests/folding/highlight.cpp.fold
  autotests/html/highlight.cpp.html
  autotests/input/highlight.cpp
  autotests/reference/highlight.cpp.ref
  data/syntax/isocpp.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, domson, 
michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, 
dhaumann

D21587: Lua: update for Lua54 and end of function as Keyword rather than Control

[jonathan poelen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:602bbc7b7397: Lua: update for Lua54 and end of function 
as Keyword rather than Control (authored by jpoelen).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21587?vs=59155&id=59163

REVISION DETAIL
  https://phabricator.kde.org/D21587

AFFECTED FILES
  autotests/html/highlight.lua.html
  autotests/html/test.pbl.html
  autotests/reference/highlight.lua.ref
  autotests/reference/test.pbl.ref
  data/syntax/lua.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, domson, 
michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, 
dhaumann

D21508: Jam: various improvements and fixes

[jonathan poelen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:6864c25f1d54: Jam: various improvements and fixes 
(authored by jpoelen).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21508?vs=59150&id=59164

REVISION DETAIL
  https://phabricator.kde.org/D21508

AFFECTED FILES
  autotests/folding/Jamroot.fold
  autotests/html/Jamroot.html
  autotests/input/Jamroot
  autotests/reference/Jamroot.ref
  data/syntax/jam.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kde-frameworks-devel, kwrite-devel, LeGast00n, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D21586: Add syntax definition for ninja build

[jonathan poelen]

jpoelen updated this revision to Diff 59240.
jpoelen added a comment.


  I am confused, the generation of index.katesyntax fails because the list 
"variables" does not exist (there is no variable predefined in this context). 
We may be in a situation where a change of branch does not recompile the index 
file :/.
  
  I'll have to be more careful next time.

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21586?vs=59154&id=59240

BRANCH
  ninja (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21586

AFFECTED FILES
  autotests/folding/build.ninja.fold
  autotests/html/build.ninja.html
  autotests/input/build.ninja
  autotests/reference/build.ninja.ref
  data/syntax/ninja.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, domson, 
michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, 
dhaumann

D21586: Add syntax definition for ninja build

[jonathan poelen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:a72b6b5e53ec: Add syntax definition for ninja build 
(authored by jpoelen).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21586?vs=59240&id=59421

REVISION DETAIL
  https://phabricator.kde.org/D21586

AFFECTED FILES
  autotests/folding/build.ninja.fold
  autotests/html/build.ninja.html
  autotests/input/build.ninja
  autotests/reference/build.ninja.ref
  data/syntax/ninja.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, domson, 
michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, 
dhaumann

D6128: CMake: OR/AND not highlighted after expr in () If you type in "if((A AND B) OR C)", "OR" is not highlighted.

[jonathan poelen]

jpoelen created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  upstream

REVISION DETAIL
  https://phabricator.kde.org/D6128

AFFECTED FILES
  data/syntax/cmake.xml

To: jpoelen
Cc: #frameworks

D6128: Bug 360656 - CMake: OR/AND not highlighted after expr in ()

[jonathan poelen]

jpoelen retitled this revision from "CMake: OR/AND not highlighted after expr 
in () If you type in "if((A AND B) OR C)", "OR" is not highlighted." to "Bug 
360656 - CMake: OR/AND not highlighted after expr in ()".
jpoelen edited the summary of this revision.
jpoelen edited the test plan for this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D6128

To: jpoelen
Cc: #frameworks

D6128: Bug 360656 - CMake: OR/AND not highlighted after expr in ()

[jonathan poelen]

jpoelen updated this revision to Diff 15238.
jpoelen edited the summary of this revision.
jpoelen added a comment.


  - Update test reference data

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6128?vs=15237&id=15238

BRANCH
  upstream

REVISION DETAIL
  https://phabricator.kde.org/D6128

AFFECTED FILES
  CMakeLists.txt
  KF5SyntaxHighlightingConfig.cmake.in
  autotests/html/highlight.cmake.html
  autotests/html/highlight.dox.html
  autotests/html/test.c.html
  autotests/reference/highlight.cmake.ref
  autotests/reference/highlight.dox.ref
  autotests/reference/test.c.ref
  data/syntax/cmake.xml
  data/syntax/doxygen.xml
  data/syntax/haskell.xml
  src/lib/CMakeLists.txt

To: jpoelen
Cc: #frameworks

D6128: Bug 360656 - CMake: OR/AND not highlighted after expr in ()

[jonathan poelen]

jpoelen updated this revision to Diff 15239.
jpoelen added a comment.


  Previous diff on bad branch

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6128?vs=15238&id=15239

BRANCH
  upstream

REVISION DETAIL
  https://phabricator.kde.org/D6128

AFFECTED FILES
  autotests/html/highlight.cmake.html
  autotests/reference/highlight.cmake.ref
  data/syntax/cmake.xml

To: jpoelen
Cc: #frameworks

D6128: Bug 360656 - CMake: OR/AND not highlighted after expr in ()

[jonathan poelen]

jpoelen updated this revision to Diff 15240.
jpoelen added a comment.


  - cmake test: add an expression with nested parenthesis

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6128?vs=15239&id=15240

BRANCH
  upstream

REVISION DETAIL
  https://phabricator.kde.org/D6128

AFFECTED FILES
  autotests/folding/highlight.cmake.fold
  autotests/html/highlight.cmake.html
  autotests/input/highlight.cmake
  autotests/reference/highlight.cmake.ref
  data/syntax/cmake.xml

To: jpoelen
Cc: #frameworks

D6128: Bug 360656 - CMake: OR/AND not highlighted after expr in ()

[jonathan poelen]

jpoelen added a reviewer: Framework: Syntax Hightlighting.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D6128

To: jpoelen, #framework_syntax_hightlighting
Cc: #frameworks

D6288: isocpp.xml: replace P printf-like format with p

[jonathan poelen]

jpoelen created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  'P' format does not exist, 'p' format is missing.

TEST PLAN
  printf("%p", pointer);

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  ioscpp-printf-like

REVISION DETAIL
  https://phabricator.kde.org/D6288

AFFECTED FILES
  data/syntax/isocpp.xml

To: jpoelen
Cc: #frameworks

D6328: add unit test for isocpp

[jonathan poelen]

jpoelen created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  ioscpp-test

REVISION DETAIL
  https://phabricator.kde.org/D6328

AFFECTED FILES
  autotests/folding/highlight.cpp.fold
  autotests/html/highlight.cpp.html
  autotests/input/highlight.cpp
  autotests/reference/highlight.cpp.ref

To: jpoelen
Cc: #frameworks

D7297: Add Pony highlighting

[jonathan poelen]

jpoelen created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  pony

REVISION DETAIL
  https://phabricator.kde.org/D7297

AFFECTED FILES
  autotests/folding/highlight.pony.fold
  autotests/foldingtest.pony
  autotests/html/highlight.pony.html
  autotests/input/highlight.pony
  autotests/reference/highlight.pony.ref
  data/syntax/pony.xml

To: jpoelen
Cc: #frameworks

D6288: isocpp.xml: replace P printf-like format with p

[jonathan poelen]

jpoelen abandoned this revision.
jpoelen added a comment.


  This commit is already merged.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D6288

To: jpoelen
Cc: #frameworks

D7297: Add Pony highlighting

[jonathan poelen]

jpoelen added a reviewer: Framework: Syntax Hightlighting.
jpoelen edited projects, added Framework: Syntax Hightlighting; removed 
Frameworks.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D7297

To: jpoelen, #framework_syntax_hightlighting
Cc: #frameworks, cullmann, vkrause, dhaumann

D7297: Add Pony highlighting

[jonathan poelen]

jpoelen updated this revision to Diff 18194.
jpoelen added a comment.
Restricted Application added a project: Frameworks.


  - Pony: Support for attributes and best behavior for function definitions. 
Add license and removed autotests/foldingtest.pony

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7297?vs=18110&id=18194

BRANCH
  pony

REVISION DETAIL
  https://phabricator.kde.org/D7297

AFFECTED FILES
  CMakeLists.txt
  KF5SyntaxHighlightingConfig.cmake.in
  autotests/folding/Doxyfile.example.fold
  autotests/folding/craftenv.ps1.fold
  autotests/folding/highlight.cmake.fold
  autotests/folding/highlight.cpp.fold
  autotests/folding/highlight.hs.fold
  autotests/folding/highlight.js.fold
  autotests/folding/highlight.php.fold
  autotests/folding/highlight.pl.fold
  autotests/folding/highlight.pony.fold
  autotests/folding/highlight.yang.fold
  autotests/folding/light52_tb.vhdl.fold
  autotests/folding/test.bash.fold
  autotests/folding/test.htm.fold
  autotests/folding/test.py.fold
  autotests/folding/test.zsh.fold
  autotests/folding/test_syntax.sql.fold
  autotests/foldingtest.cpp
  autotests/html/Doxyfile.example.html
  autotests/html/craftenv.ps1.html
  autotests/html/highlight.cmake.html
  autotests/html/highlight.cpp.html
  autotests/html/highlight.dox.html
  autotests/html/highlight.hs.html
  autotests/html/highlight.js.html
  autotests/html/highlight.lex.html
  autotests/html/highlight.php.html
  autotests/html/highlight.pl.html
  autotests/html/highlight.pony.html
  autotests/html/highlight.yang.html
  autotests/html/light52_tb.vhdl.html
  autotests/html/test.bash.html
  autotests/html/test.c.html
  autotests/html/test.css.html
  autotests/html/test.htm.html
  autotests/html/test.py.html
  autotests/html/test.zsh.html
  autotests/html/test_syntax.sql.html
  autotests/htmlhighlighter_test.cpp
  autotests/input/Doxyfile.example
  autotests/input/craftenv.ps1
  autotests/input/highlight.cmake
  autotests/input/highlight.cpp
  autotests/input/highlight.hs
  autotests/input/highlight.js
  autotests/input/highlight.php
  autotests/input/highlight.pl
  autotests/input/highlight.pony
  autotests/input/highlight.yang
  autotests/input/light52_tb.vhdl
  autotests/input/test.bash
  autotests/input/test.htm
  autotests/input/test.py
  autotests/input/test.zsh
  autotests/reference/Doxyfile.example.ref
  autotests/reference/craftenv.ps1.ref
  autotests/reference/highlight.cmake.ref
  autotests/reference/highlight.cpp.ref
  autotests/reference/highlight.dox.ref
  autotests/reference/highlight.hs.ref
  autotests/reference/highlight.js.ref
  autotests/reference/highlight.lex.ref
  autotests/reference/highlight.php.ref
  autotests/reference/highlight.pl.ref
  autotests/reference/highlight.pony.ref
  autotests/reference/highlight.sh.ref
  autotests/reference/highlight.yang.ref
  autotests/reference/light52_tb.vhdl.ref
  autotests/reference/test.bash.ref
  autotests/reference/test.c.ref
  autotests/reference/test.css.ref
  autotests/reference/test.htm.ref
  autotests/reference/test.py.ref
  autotests/reference/test.zsh.ref
  autotests/reference/test_syntax.sql.ref
  autotests/syntaxrepository_test.cpp
  autotests/testhighlighter.cpp
  autotests/theme_test.cpp
  data/CMakeLists.txt
  data/syntax-data.qrc.in
  data/syntax/4dos.xml
  data/syntax/abap.xml
  data/syntax/actionscript.xml
  data/syntax/ada.xml
  data/syntax/agda.xml
  data/syntax/ahdl.xml
  data/syntax/ahk.xml
  data/syntax/alert.xml
  data/syntax/alert_indent.xml
  data/syntax/ample.xml
  data/syntax/ansforth94.xml
  data/syntax/ansic89.xml
  data/syntax/asm-avr.xml
  data/syntax/asn1.xml
  data/syntax/awk.xml
  data/syntax/bash.xml
  data/syntax/bitbake.xml
  data/syntax/bmethod.xml
  data/syntax/boo.xml
  data/syntax/c.xml
  data/syntax/carto-css.xml
  data/syntax/ccss.xml
  data/syntax/cgis.xml
  data/syntax/changelog.xml
  data/syntax/chicken.xml
  data/syntax/cisco.xml
  data/syntax/clipper.xml
  data/syntax/clojure.xml
  data/syntax/cmake.xml
  data/syntax/coldfusion.xml
  data/syntax/commonlisp.xml
  data/syntax/component-pascal.xml
  data/syntax/cpp.xml
  data/syntax/crk.xml
  data/syntax/cs.xml
  data/syntax/css.xml
  data/syntax/cubescript.xml
  data/syntax/cue.xml
  data/syntax/curry.xml
  data/syntax/d.xml
  data/syntax/dockerfile.xml
  data/syntax/dosbat.xml
  data/syntax/dot.xml
  data/syntax/doxyfile.xml
  data/syntax/doxygen.xml
  data/syntax/doxygenlua.xml
  data/syntax/e.xml
  data/syntax/eiffel.xml
  data/syntax/erlang.xml
  data/syntax/euphoria.xml
  data/syntax/ferite.xml
  data/syntax/fgl-4gl.xml
  data/syntax/fgl-per.xml
  data/syntax/fortran.xml
  data/syntax/freebasic.xml
  data/syntax/fsharp.xml
  data/syntax/fstab.xml
  data/syntax/gap.xml
  data/syntax/gcc.xml
  data/syntax/gdl.xml
  data/syntax/gettext.xml
  data/syntax/gnuplot.xml
  data/syntax/grammar.xml
  data/syntax/groovy.xml
  data/syntax/haml.xml
  data/syntax/haskell.xml
  data/syntax/haxe.xml
  data/syntax/html.xml

D7297: Add Pony highlighting

[jonathan poelen]

jpoelen updated this revision to Diff 18196.
jpoelen added a comment.


  Pony: Support for attributes and best behavior for function definitions. Add 
license and removed autotests/foldingtest.pony

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7297?vs=18194&id=18196

BRANCH
  pony

REVISION DETAIL
  https://phabricator.kde.org/D7297

AFFECTED FILES
  autotests/folding/highlight.pony.fold
  autotests/html/highlight.pony.html
  autotests/input/highlight.pony
  autotests/reference/highlight.pony.ref
  data/syntax/pony.xml

To: jpoelen, #framework_syntax_hightlighting
Cc: dhaumann, #frameworks, cullmann, vkrause

D10621: Highlighting Indexer: list of suggestions

[jonathan poelen]

jpoelen created this revision.
jpoelen added a reviewer: dhaumann.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
jpoelen requested review of this revision.

REVISION SUMMARY
  Proposes mergers of rules and the replacement of:
  
  - RegExp by StringDetect, AnyChar, RangeDetect, etc.
  - StringDetect by DetectChar or Detect2Chars.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  suggest

REVISION DETAIL
  https://phabricator.kde.org/D10621

AFFECTED FILES
  src/indexer/katehighlightingindexer.cpp

To: jpoelen, dhaumann
Cc: dhaumann, #frameworks, michaelh

D10621: Highlighting Indexer: list of suggestions

[jonathan poelen]

jpoelen added a project: Framework: Syntax Highlighting.
jpoelen added a subscriber: Framework: Syntax Highlighting.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D10621

To: jpoelen, dhaumann
Cc: #framework_syntax_highlighting, dhaumann, #frameworks, michaelh, 
genethomas, cullmann, vkrause

D10646: Support case-insensitive WordDetect

[jonathan poelen]

jpoelen created this revision.
jpoelen added a reviewer: dhaumann.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
jpoelen requested review of this revision.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  word_insensitive

REVISION DETAIL
  https://phabricator.kde.org/D10646

AFFECTED FILES
  autotests/folding/highlight.cmake.fold
  src/lib/rule.cpp
  src/lib/rule_p.h

To: jpoelen, dhaumann
Cc: dhaumann, #frameworks, michaelh

D10646: Support case-insensitive WordDetect

[jonathan poelen]

jpoelen added a comment.


  It seems that KTextEditor does not have the problem because KateHlWordDetect 
is based on KateHlStringDetect which uses the inSensitive parameter.

INLINE COMMENTS

> rule_p.h:249
>  QString m_word;
> +Qt::CaseSensitivity m_caseSensitivity;
>  };

Yes, but it is in any case overwritten by doLoad(). StringDetect and others do 
not have this initialization either, should I also make the modification?
In fact, I do not think it's relevant because the analysis tools would no 
longer detect "uninitialized" variables in the case, for example, of calling 
doMatch before doLoad.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  word_insensitive

REVISION DETAIL
  https://phabricator.kde.org/D10646

To: jpoelen, dhaumann
Cc: dhaumann, #frameworks, michaelh

D10621: Highlighting Indexer: list of suggestions

[jonathan poelen]

jpoelen added a comment.


  I've already planned to fix all the suggestions, but I lost a lot of time 
updating the `sql*.xml` files and came across a very strange bug related to 
QRegularExpression by adding some tests. At the moment, I do not know if it's 
my tool to test, my version of Qt that is old or a real bug. Like last week my 
hard drive is dead, I took the opportunity to have a more recent configuration. 
I will make a few patches this weekend when I finished setting my new 
environment.
  
  The tool: https://github.com/jonathanpoelen/vt-kate-syntax-highlighter with 
the `-n` option.
  I also have a tool to generate a graph of the rules of an xml: 
https://github.com/jonathanpoelen/syntax-highlighting/tree/tools (graph.lua). 
The output is in a format readable by `graphviz`. The script is rudimentary and 
the xml parser does not work with some files (2 or 3).

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D10621

To: jpoelen, dhaumann
Cc: vkrause, #framework_syntax_highlighting, dhaumann, #frameworks, michaelh, 
genethomas, cullmann

D10621: Highlighting Indexer: list of suggestions

[jonathan poelen]

jpoelen added a comment.


  I just tried with a format containing 5000 `` rules. This gives 2000 to 6000 more 
allocation than with WordDetect. Same for StringDetect vs Detect2Chars.
  
  At the speed level, for a single rule and a file with 13 * 8000 `aa `, 
WordDetect is 10% faster, but there is no difference between StringDetect and 
Detect2Chars. On the other hand, the more the number of rule increases the more 
the difference is important, even between StringDetect and Detect2Chars. 5000 
times the same rule is extremely slow.
  
  The memory test is done with `XDG_DATA_DIRS=$PWD memusage 
kate-syntax-highlighter x.aa >/dev/null`
  Speed one with `XDG_DATA_DIRS=$PWD /usr/bin/time --format="%Es - %MK" 
kate-syntax-highlighter x.aa >/dev/null`
  
  $PWD/org.kde.syntax-highlighting/syntax/aa.xml:
  





 
   
   
   
   
 


 
 




REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D10621

To: jpoelen, dhaumann
Cc: vkrause, #framework_syntax_highlighting, dhaumann, #frameworks, michaelh, 
genethomas, ngraham, cullmann

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

[jonathan poelen]

jpoelen created this revision.
jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann.
Restricted Application added a project: Frameworks.
jpoelen requested review of this revision.

REVISION SUMMARY
  Previously, the variables prefixed by if / case / loop / end are a mix of 
keywords and normal text.
  
  Improvements:
  
  - Categorization of "Keywords" to "Operator Keyword" and "ControlFlow".
  - Removes duplicate keywords in "functions" and "keywords" list.
  - Some elements of the keywords list are moved to the functions list.
  - Adds SQL functions.
  - Removes symbols from Keyword list.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  sql

REVISION DETAIL
  https://phabricator.kde.org/D11470

AFFECTED FILES
  autotests/folding/test.sql.fold
  autotests/folding/test.sql_oracle.fold
  autotests/html/test.sql.html
  autotests/html/test.sql_oracle.html
  autotests/input/highlight.sh
  autotests/input/highlight.sh.syntax
  autotests/input/test.sql
  autotests/input/test.sql_oracle
  autotests/reference/test.sql.ref
  autotests/reference/test.sql_oracle.ref
  data/syntax/sql-mysql.xml
  data/syntax/sql-oracle.xml
  data/syntax/sql-postgresql.xml
  data/syntax/sql.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann
Cc: #frameworks, michaelh, ngraham

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

[jonathan poelen]

jpoelen updated this revision to Diff 29866.
jpoelen added a comment.


  File mode restored for autotests/input/highlight.sh and 
autotests/input/highlight.sh.syntax

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11470?vs=29865&id=29866

BRANCH
  sql

REVISION DETAIL
  https://phabricator.kde.org/D11470

AFFECTED FILES
  autotests/folding/test.sql.fold
  autotests/folding/test.sql_oracle.fold
  autotests/html/test.sql.html
  autotests/html/test.sql_oracle.html
  autotests/input/test.sql
  autotests/input/test.sql_oracle
  autotests/reference/test.sql.ref
  autotests/reference/test.sql_oracle.ref
  data/syntax/sql-mysql.xml
  data/syntax/sql-oracle.xml
  data/syntax/sql-postgresql.xml
  data/syntax/sql.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann
Cc: #frameworks, michaelh, ngraham

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

[jonathan poelen]

jpoelen added a comment.


  There is a bug on which I fell while completing the tests: the output is not 
stable.
  
  Several successive calls to `./bin/kate-syntax-highlighter 
$PROJ/autotests/input/test.sql` give a different result. `valgrind` returns a 
lot of "Conditional jump or move depends on uninitialised value(s) ", but I do 
not have the debug symbols and I do not know which library the error comes from 
(I tried with qt5-debug-base without result).

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D11470

To: jpoelen, #framework_syntax_highlighting, dhaumann
Cc: #frameworks, michaelh, ngraham

D10621: Highlighting Indexer: list of suggestions

[jonathan poelen]

jpoelen updated this revision to Diff 29869.
jpoelen added a comment.


  More suggestions and fixes some false positives.

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10621?vs=27439&id=29869

BRANCH
  suggest

REVISION DETAIL
  https://phabricator.kde.org/D10621

AFFECTED FILES
  src/indexer/katehighlightingindexer.cpp

To: jpoelen, dhaumann
Cc: vkrause, #framework_syntax_highlighting, dhaumann, #frameworks, michaelh, 
genethomas, ngraham, cullmann

D14603: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting

[jonathan poelen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:113ebe28645a: SCSS: update syntax. CSS: fix Operator and 
Selector Tag highlighting (authored by jpoelen).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D14603?vs=39067&id=40004#toc

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14603?vs=39067&id=40004

REVISION DETAIL
  https://phabricator.kde.org/D14603

AFFECTED FILES
  autotests/folding/highlight.scss.fold
  autotests/html/highlight.css.html
  autotests/html/highlight.scss.html
  autotests/html/review128925-1.scss.html
  autotests/html/review128925-2.scss.html
  autotests/input/highlight.scss
  autotests/reference/highlight.css.ref
  autotests/reference/highlight.scss.ref
  autotests/reference/review128925-1.scss.ref
  autotests/reference/review128925-2.css.ref
  autotests/reference/review128925-2.scss.ref
  autotests/reference/test.css.ref
  data/syntax/css.xml
  data/syntax/scss.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, vkrause, cullmann
Cc: cullmann, kwrite-devel, dhaumann, kde-frameworks-devel, 
#framework_syntax_highlighting, michaelh, kevinapavew, ngraham, bruns, 
demsking, sars

D14603: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting

[jonathan poelen]

jpoelen added a comment.


  Yes, my compilation folder was pointing to my fork on github  from which I 
make the patches (as I do not have the right version for ECM, I have a script 
that does among other things a new CMakeLists.txt in another folder and adds 
symbolic links for project files). If there was no more error it was because I 
saw them in the conflicts.
  
  Currently I put `find_package (ECM 5.31.0 ...` (instead of 5.49.0) and delete 
`include (ECMAddQch)` which I think should be in `if (BUILD_QCH)`.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14603

To: jpoelen, #framework_syntax_highlighting, dhaumann, vkrause, cullmann
Cc: cullmann, kwrite-devel, dhaumann, kde-frameworks-devel, 
#framework_syntax_highlighting, michaelh, kevinapavew, ngraham, bruns, 
demsking, sars

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

[jonathan poelen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:3ebb3c09e512: SQL: various improvements and fix 
if/case/loop/end detection with SQL (Oracle) (authored by jpoelen).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D11470?vs=32861&id=40010#toc

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11470?vs=32861&id=40010

REVISION DETAIL
  https://phabricator.kde.org/D11470

AFFECTED FILES
  autotests/folding/test.sql.fold
  autotests/folding/test.sql_oracle.fold
  autotests/html/test.sql.html
  autotests/html/test.sql_oracle.html
  autotests/input/test.sql
  autotests/input/test.sql_oracle
  autotests/reference/test.sql.ref
  autotests/reference/test.sql_oracle.ref
  data/syntax/sql-mysql.xml
  data/syntax/sql-oracle.xml
  data/syntax/sql-postgresql.xml
  data/syntax/sql.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, cullmann, rkflx, michaelh, kevinapavew, 
ngraham, bruns, demsking, sars, dhaumann

D14632: keyword rule: Spport for keywords inclusion from another language/file

[jonathan poelen]

jpoelen updated this revision to Diff 41298.
jpoelen added a comment.


  include rule in keyword list to import those from another file

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14632?vs=39138&id=41298

BRANCH
  kwinclude

REVISION DETAIL
  https://phabricator.kde.org/D14632

AFFECTED FILES
  autotests/syntaxrepository_test.cpp
  data/schema/language.xsd
  data/syntax/scss.xml
  src/indexer/katehighlightingindexer.cpp
  src/lib/definition.cpp
  src/lib/definition.h
  src/lib/definition_p.h
  src/lib/keywordlist.cpp
  src/lib/keywordlist_p.h

To: jpoelen, #framework_syntax_highlighting, cullmann, dhaumann
Cc: kwrite-devel, vkrause, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D14632: keyword rule: Spport for keywords inclusion from another language/file

[jonathan poelen]

jpoelen added a comment.


  Sorry to answer so late, I had trouble logging in.
  
  I think I misinterpreted the use of `includedDefinitions()`. For me, this 
function lists the languages ​included by the rules and which influence the 
colors. While the inclusion of a keyword list has no influence here. In the 
case of SASS, there is no IncludeRules to CSS because small syntactic details 
do not allow it, it would not be logical to have CSS in the list of 
`includedDefinitions()`.
  
  Basically, I added `includedKeywordDefinitions()` because of a Format test 
that did not work. But it's true that putting it in the public interface is not 
a good idea.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14632

To: jpoelen, #framework_syntax_highlighting, cullmann, dhaumann
Cc: kwrite-devel, vkrause, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D14632: keyword rule: Spport for keywords inclusion from another language/file

[jonathan poelen]

jpoelen added a comment.


  `resolveIncludeKeywords()` would then use `loadKeywords()` instead of 
`load()` ? This should be enough.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14632

To: jpoelen, #framework_syntax_highlighting, cullmann, dhaumann
Cc: kwrite-devel, vkrause, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D14632: keyword rule: Spport for keywords inclusion from another language/file

[jonathan poelen]

jpoelen updated this revision to Diff 41872.
jpoelen added a comment.


  - restore operators list
  - lazy load keyword lists

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14632?vs=41298&id=41872

BRANCH
  kwinclude

REVISION DETAIL
  https://phabricator.kde.org/D14632

AFFECTED FILES
  data/schema/language.xsd
  data/syntax/scss.xml
  src/indexer/katehighlightingindexer.cpp
  src/lib/definition.cpp
  src/lib/definition_p.h
  src/lib/keywordlist.cpp
  src/lib/keywordlist_p.h

To: jpoelen, #framework_syntax_highlighting, cullmann, dhaumann
Cc: kwrite-devel, vkrause, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D14632: keyword rule: Spport for keywords inclusion from another language/file

[jonathan poelen]

jpoelen added a comment.


  (I inadvertently edit the operators list in the previous commit)
  
  Finally, I added a parameter to `load()` and `loadHighlighting()` rather than 
a new function because there was a lot of code duplication.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14632

To: jpoelen, #framework_syntax_highlighting, cullmann, dhaumann
Cc: kwrite-devel, vkrause, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D14632: keyword rule: Spport for keywords inclusion from another language/file

[jonathan poelen]

jpoelen updated this revision to Diff 42628.
jpoelen added a comment.


  - fix the recursion detection and handling of nested included keyword lists

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14632?vs=41872&id=42628

BRANCH
  kwinclude

REVISION DETAIL
  https://phabricator.kde.org/D14632

AFFECTED FILES
  autotests/syntaxrepository_test.cpp
  data/schema/language.xsd
  data/syntax/scss.xml
  src/indexer/katehighlightingindexer.cpp
  src/lib/definition.cpp
  src/lib/definition_p.h
  src/lib/keywordlist.cpp
  src/lib/keywordlist_p.h

To: jpoelen, #framework_syntax_highlighting, cullmann, dhaumann
Cc: kwrite-devel, vkrause, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D10621: Highlighting Indexer: list of suggestions

[jonathan poelen]

jpoelen added a comment.


  I agree that some rules are excessive or even false, but the last time I 
watched (it was several months ago now), some regexes suggested to be 
DetectString seemed to have writing errors (mainly `\\` count as 2 characters 
in xml) and some more or less useful propositions. If there has been no change 
at this level, it should still be checked.
  
  Actually, I came to the conclusion that the parser himself could make some 
changes on the fly. For example, DetectChar/Detect2Chars are specializations of 
DetectString and the concatenation of regexes could be automatic, which would 
make most checks obsolete. There would be only suggestions to turn a Regex into 
something else, but it is much easier using an AST rather than a very slobbery 
regexes.
  
  Finally, this commit will never make a complete list without false positives, 
especially since code reviews filter out such errors. We can abandon it.
  
  PS: this commit uses `attrToBool` as for the parser (if it has not changed) 
and adds 2 missing `return false`. I do not have time to take care of it at the 
moment.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D10621

To: jpoelen, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, vkrause, 
#framework_syntax_highlighting, dhaumann, bmortimer, hase, michaelh, 
genethomas, ngraham, bruns, demsking, cullmann, sars

D21586: Add syntax definition for ninja build

[jonathan poelen]

jpoelen added a comment.


  After reflection (:D), I think the constraint is weak, the creation of new 
syntax is rare compared to the rest.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D21586

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, domson, 
michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, 
dhaumann

D23013: Latex: several fixes (math mode, nested verbatim, ...)

[jonathan poelen]

jpoelen created this revision.
jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
jpoelen added projects: Kate, Frameworks.
jpoelen requested review of this revision.

REVISION SUMMARY
  - nested { and macro identifier with math mode
  - add shortintertext, Cref, param with math env and fix providecommand
  - text macro in math mode
  - nested verbatim
  - ...
  
  BUG: 320303
  BUG: 274440
  BUG: 322081

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  tex (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23013

AFFECTED FILES
  autotests/folding/example.rmd.fold
  autotests/folding/highlight.tex.fold
  autotests/folding/test.tex.fold
  autotests/html/highlight.tex.html
  autotests/html/test.tex.html
  autotests/input/highlight.tex
  autotests/input/test.tex
  autotests/reference/highlight.tex.ref
  autotests/reference/test.tex.ref
  autotests/syntaxrepository_test.cpp
  data/syntax/latex.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kde-frameworks-devel, kwrite-devel, univerz, LeGast00n, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23014: Lua: fix color of end with several levels of condition and function nesting

[jonathan poelen]

jpoelen created this revision.
jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
jpoelen added projects: Kate, Frameworks.
jpoelen requested review of this revision.

REVISION SUMMARY
  if x then
  
function foo()
  if x then
  end -- control (before: keyword)
end -- keyword (before: control)
  
  end -- control

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  lua (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23014

AFFECTED FILES
  autotests/folding/highlight.lua.fold
  autotests/html/highlight.lua.html
  autotests/input/highlight.lua
  autotests/reference/highlight.lua.ref
  data/syntax/lua.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kde-frameworks-devel, kwrite-devel, univerz, LeGast00n, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23015: Highlighting indexer: all warnings are fatal

[jonathan poelen]

jpoelen created this revision.
jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
jpoelen added projects: Kate, Frameworks.
jpoelen requested review of this revision.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  warning_as_error (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23015

AFFECTED FILES
  src/indexer/katehighlightingindexer.cpp

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kde-frameworks-devel, kwrite-devel, univerz, LeGast00n, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23014: Lua: fix color of end with several levels of condition and function nesting

[jonathan poelen]

jpoelen updated this revision to Diff 63376.
jpoelen added a comment.


  increase the version number

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23014?vs=63320&id=63376

BRANCH
  lua (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23014

AFFECTED FILES
  autotests/folding/highlight.lua.fold
  autotests/html/highlight.lua.html
  autotests/input/highlight.lua
  autotests/reference/highlight.lua.ref
  data/syntax/lua.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kde-frameworks-devel, kwrite-devel, univerz, LeGast00n, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann