[kde-freebsd] [Bug 209799] misc/kdeedu4: kdeprefix removal too thorough

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=209799

--- Comment #5 from Kurt Jaeger  ---
Committed, thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
kde-freebsd mailing list
kde-freebsd@kde.org
https://mail.kde.org/mailman/listinfo/kde-freebsd
See also http://freebsd.kde.org/ for latest information

[kde-freebsd] [Bug 209799] misc/kdeedu4: kdeprefix removal too thorough

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=209799

Kurt Jaeger  changed:

   What|Removed |Added

   Assignee|k...@freebsd.org |p...@freebsd.org
 Status|New |Closed
  Flags|maintainer-feedback?(kde@Fr |maintainer-feedback+
   |eeBSD.org)  |
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
kde-freebsd mailing list
kde-freebsd@kde.org
https://mail.kde.org/mailman/listinfo/kde-freebsd
See also http://freebsd.kde.org/ for latest information

[kde-freebsd] [Bug 209799] misc/kdeedu4: kdeprefix removal too thorough

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=209799

--- Comment #4 from commit-h...@freebsd.org ---
A commit references this bug:

Author: pi
Date: Sat May 28 07:49:52 UTC 2016
New revision: 415976
URL: https://svnweb.freebsd.org/changeset/ports/415976

Log:
  devel/kdebindings4, devel/kdesdk4, misc/kdeedu4: re-add USE_KDE4

  In r415864, kdeprefix was removed from a whole lot of ports. In a
  few cases, USE_KDE4= was removed entirely. There are some combinations
  of OPTIONS that can cause build failures because KDE4_VERSION isn't
  defined. This fixes it.

  PR:   209799
  Submitted by: gr...@kde.org (kde)

Changes:
  head/devel/kdebindings4/Makefile
  head/devel/kdesdk4/Makefile
  head/misc/kdeedu4/Makefile

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
kde-freebsd mailing list
kde-freebsd@kde.org
https://mail.kde.org/mailman/listinfo/kde-freebsd
See also http://freebsd.kde.org/ for latest information

[kde-freebsd] [Bug 209799] misc/kdeedu4: kdeprefix removal too thorough

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=209799

Vladimir Krstulja  changed:

   What|Removed |Added

   See Also||https://bugs.freebsd.org/bu
   ||gzilla/show_bug.cgi?id=2098
   ||02

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
kde-freebsd mailing list
kde-freebsd@kde.org
https://mail.kde.org/mailman/listinfo/kde-freebsd
See also http://freebsd.kde.org/ for latest information

[kde-freebsd] [Bug 209799] misc/kdeedu4: kdeprefix removal too thorough

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=209799

Vladimir Krstulja  changed:

   What|Removed |Added

   Keywords||patch
Summary|misc/kdeedu4 kdeprefix  |misc/kdeedu4: kdeprefix
   |removal too thorough|removal too thorough

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
kde-freebsd mailing list
kde-freebsd@kde.org
https://mail.kde.org/mailman/listinfo/kde-freebsd
See also http://freebsd.kde.org/ for latest information

[kde-freebsd] [Bug 209799] misc/kdeedu4 kdeprefix removal too thorough

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=209799

gr...@kde.org changed:

   What|Removed |Added

 CC||p...@freebsd.org

--- Comment #3 from gr...@kde.org ---
rene@, right now kde@ is under-staffed, so we're in a process of
starting-to-get-ports-mentored. Adding pi@, who has offered to commit things
for those of us in the process.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
kde-freebsd mailing list
kde-freebsd@kde.org
https://mail.kde.org/mailman/listinfo/kde-freebsd
See also http://freebsd.kde.org/ for latest information

[kde-freebsd] [Bug 209799] misc/kdeedu4 kdeprefix removal too thorough

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=209799

--- Comment #2 from Rene Ladan  ---
If USE_KDE4 got removed completely, it indeed needs to be re-added with an
empty value (or "yes").

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
kde-freebsd mailing list
kde-freebsd@kde.org
https://mail.kde.org/mailman/listinfo/kde-freebsd
See also http://freebsd.kde.org/ for latest information

[kde-freebsd] [Bug 209799] misc/kdeedu4 kdeprefix removal too thorough

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=209799

gr...@kde.org changed:

   What|Removed |Added

 CC||r...@freebsd.org

--- Comment #1 from gr...@kde.org ---
Adding rene@ because of


r415864 | rene | 2016-05-25 22:56:06 +0200 (Wed, 25 May 2016) | 10 lines


which introduces this obscure edge case.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
kde-freebsd mailing list
kde-freebsd@kde.org
https://mail.kde.org/mailman/listinfo/kde-freebsd
See also http://freebsd.kde.org/ for latest information

[kde-freebsd] [Bug 209799] misc/kdeedu4 kdeprefix removal too thorough

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=209799

Bug ID: 209799
   Summary: misc/kdeedu4 kdeprefix removal too thorough
   Product: Ports & Packages
   Version: Latest
  Hardware: Any
OS: Any
Status: New
  Severity: Affects Only Me
  Priority: ---
 Component: Individual Port(s)
  Assignee: k...@freebsd.org
  Reporter: gr...@kde.org
 Flags: maintainer-feedback?(k...@freebsd.org)
  Assignee: k...@freebsd.org

Created attachment 170733
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=170733=edit
Add blank USE_KDE4 to metaports that need it

In r415864, kdeprefix was removed from a whole lot of ports. In a few cases,
USE_KDE4= was removed entirely. This happened in some KDE metaports, not in all
of them. Many metaports have retained this line:

USE_KDE4=  # blank, needed to get KDE4_VERSION

Attached patch restores this line to three metaports that have lost it
entirely. There's two reasons for this:

 - consistency with the other metaports (less important)
 - there are some combinations of OPTIONS that can cause build failures because
KDE4_VERSION isn't defined

The latter issue can be illustrated as follows:

 - cd /usr/ports/misc/kdeedu4
 - make config
 - *uncheck* marble
 - portlint, or build

Because of marble (which is enabled by default), usually you get USE_KDE4 set
through this line in the Makefile:

MARBLE_USE= KDE4=marble_run

When marble is unchecked, you get this (from portlint):


FATAL: Makefile: either PORTVERSION or DISTVERSION must be specified
FATAL: Makefile: kdeedu- < kdeedu-4.14.3. Choose another PORTVERSION or bump
PORTEPOCH.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
kde-freebsd mailing list
kde-freebsd@kde.org
https://mail.kde.org/mailman/listinfo/kde-freebsd
See also http://freebsd.kde.org/ for latest information