Re: [Kde-hardware-devel] Review Request: Handle unsupported actions quietly
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107257/ --- (Updated Nov. 21, 2012, 7:20 p.m.) Review request for Solid. Changes --- Record an appropriate error code during action initialisation. Add error codes for the other ways initialisation might fail. Description (updated) --- Handle unsupported actions quietly Attempting to load a configured action on a machine where it is not supported (e.g. DPMS when the display doesn't support it or it is not compiled in) fails and brings up a notification, something that is particularly intrusive during login. Provide a method for ActionPool::loadAction callers to ask why the load failed. PowerDevil::Core::loadProfile uses this check to decide whether to warn to stderr rather than notifying the user of a misconfiguration. Other loadAction callers are unchanged. Action loading failure may be due to an error during initialisation or simply because no such action exits. In the former case the error must be recorded so that it is available to pass on to later loadAction callers. NB: A more complete fix might involve detecting whether the action is supportable when loading the action configuration and/or in the profile generator. However that may not turn out to be a feasible approach. BUG: 302846 Diffs (updated) - powerdevil/daemon/powerdevilactionpool.h 8a94eacc8ef2c2aead8cb075cbc80b783c1aeb4c powerdevil/daemon/powerdevilactionpool.cpp a9950f174fe184b8faa54c54fc00654984c65b3f powerdevil/daemon/powerdevilcore.cpp 2dcdbc62236d5c1fae384fdb9111825a2ebf5204 Diff: http://git.reviewboard.kde.org/r/107257/diff/ Testing (updated) --- Tested in VM with cirrus/vnc (dpms) and qxl/spice (non-dpms) graphics. Tested the NoAction and LoadFailed cases act as expected. Tested nothing horrible happens when disabling and re-enabling powerdevil in kded Services Manager. Thanks, Oliver Henshaw ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel
Re: [Kde-hardware-devel] Review Request: Silence Profile foo could not activate bar which is a non-existent action message
On Nov. 18, 2012, 1:23 p.m., Kai Uwe Broulik wrote: Great! Now that I have tested the Keyboard brightness support patch that is on Review Board atm, I get two error messages simultaneously on startup: One for DPMS, the other for Keyboard brightness. This really needs to be fixed/silenced … I'm not sure what the Keyboard brightness problem is - that doesn't have a isSupported implementation as far as I can see. If you mean you've still got it in your config after removing the patch, isn't that the kind of misconfiguration that the notification is meant to warn about? Maybe invalid KConfigGroups shouldn't be persisted back to the configuration? Though maybe only for the NoAction case from the other review request, not for LoadFailed or NotSupported. Not really sure enough of how KConfigGroups work to tell whether that's a promising approach, though. - Oliver --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106863/#review22166 --- On Nov. 3, 2012, 2:46 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106863/ --- (Updated Nov. 3, 2012, 2:46 p.m.) Review request for Solid. Description --- That message usually appears when starting before the Desktop is up, causing an ugly 1990's passivepopup dialog on the screen, and its contents are not really novice-user-resolvable. On my machine it always claims The profile Battery tried to activate DPMSControl which is a non-existent action., which is when I compile powerdevil myself that DPMS stuff is not compiled (DPMS build requirements not met here) and so the action floats around in the config but cannot be triggered anyways. (Imho this is a really infamous message, have seen it quite often on other machines *duck*). All the other actions seem to be installed anyways, so this missing action poses no threat. I guess a kWarning would be sufficient for this. Diffs - powerdevil/daemon/actions/CMakeLists.txt db9ca47 powerdevil/daemon/actions/dpms/powerdevildpmsaction.cpp 55689b5 powerdevil/daemon/powerdevilactionpool.cpp a9950f1 Diff: http://git.reviewboard.kde.org/r/106863/diff/ Testing --- Compiles. The previous passivepopup does not appear anymore. Did not test whether the kwarning is triggered, though. (Dunno how to get powerdevil debug console output) Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel
[Kde-hardware-devel] Review Request: Handle unsupported actions quietly
Hello, I bought a ACER netbook ref 0531H a couple of years ago. I installed the successive versions of Kubuntu without problems, especially with the integrated webcam (Suyin, Crystal Eye). Skype, Cheese and Camorama worked fine with it. After upgrading to Kubuntu Precise (not sure), the webcam was not more correctly recognized by the kernel. Now the webcam looks to be recognized sometimes as a Sonix device, with error messages about UVC compliance. Sometimes it isn't recognized at all. I tried many things without success. That the reason why, I post this mail on the list, even if I am not sure that it is the right place. Any support to help me is welcome. Thank you for your feedback. Cheers. Xavier Detailed information : Sometimes lsusb provides: Bus 001 Device 060: ID 0c45:6310 Microdia Sonix USB 2.0 Camera Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub Bus 002 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub Bus 003 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub Bus 004 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub Bus 005 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub Sometimes, the webcam didn't appear. I tried with many kernels such as for Quantal or Raring (Dev): uname -rvpoi 3.2.0-24-generic #37-Ubuntu SMP Wed Apr 25 08:43:52 UTC 2012 i686 i386 GNU/Linux and uname -rvpoi 3.7.0-3-generic #9-Ubuntu SMP Tue Nov 20 22:40:43 UTC 2012 i686 i686 GNU/Linux In any case, the message in dmesg is similar : dmesg | grep video [0.241729] pci :00:02.0: Boot video device [ 15.772698] acer_wmi: Disabling ACPI video driver [ 508.803505] Linux video capture interface: v2.00 [ 509.004525] uvcvideo: Found UVC 1.00 device USB 2.0 Camera (0c45:6310) [ 509.007843] uvcvideo: UVC non compliance - GET_DEF(PROBE) not supported. Enabling workaround. [ 509.008838] uvcvideo: Failed to query (129) UVC probe control : -32 (exp. 26). [ 509.008850] uvcvideo: Failed to initialize the device (-5). [ 509.010150] usbcore: registered new interface driver uvcvideo [11441.142956] uvcvideo: Found UVC 1.00 device USB 2.0 Camera (0c45:6310) [11441.144825] uvcvideo: UVC non compliance - GET_DEF(PROBE) not supported. Enabling workaround. [11441.145821] uvcvideo: Failed to query (129) UVC probe control : -32 (exp. 26). [11441.145833] uvcvideo: Failed to initialize the device (-5). I tried to install the last version of the UVC driver but without any change: No correct recognization of the webcam (esp. no /dev/video0 device). http://git.linuxtv.org/media_build.git ./build sudo make install sudo camorama == device not found I tried to create manually the /dev/video0 device by: xavier@mercure:/dev$ sudo mknod /dev/video0 c 81 0 xavier@mercure:/dev$ sudo chmod 666 /dev/video0 xavier@mercure:/dev$ sudo ln -s /dev/video0 /dev/video xavier@mercure:/dev$ sudo camorama == device not found ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel
Re: [Kde-hardware-devel] Review Request: Silence Profile foo could not activate bar which is a non-existent action message
On Nov. 18, 2012, 1:23 p.m., Kai Uwe Broulik wrote: Great! Now that I have tested the Keyboard brightness support patch that is on Review Board atm, I get two error messages simultaneously on startup: One for DPMS, the other for Keyboard brightness. This really needs to be fixed/silenced … Oliver Henshaw wrote: I'm not sure what the Keyboard brightness problem is - that doesn't have a isSupported implementation as far as I can see. If you mean you've still got it in your config after removing the patch, isn't that the kind of misconfiguration that the notification is meant to warn about? Maybe invalid KConfigGroups shouldn't be persisted back to the configuration? Though maybe only for the NoAction case from the other review request, not for LoadFailed or NotSupported. Not really sure enough of how KConfigGroups work to tell whether that's a promising approach, though. I think I will discard this request in favor of your implementation since yours also gives a feedback what happened and looks nicer :P And yes, I think non-existent actions (ie. the config file references an action that is not availble due to not being compiled) should be dropped from the config file. - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106863/#review22166 --- On Nov. 3, 2012, 2:46 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106863/ --- (Updated Nov. 3, 2012, 2:46 p.m.) Review request for Solid. Description --- That message usually appears when starting before the Desktop is up, causing an ugly 1990's passivepopup dialog on the screen, and its contents are not really novice-user-resolvable. On my machine it always claims The profile Battery tried to activate DPMSControl which is a non-existent action., which is when I compile powerdevil myself that DPMS stuff is not compiled (DPMS build requirements not met here) and so the action floats around in the config but cannot be triggered anyways. (Imho this is a really infamous message, have seen it quite often on other machines *duck*). All the other actions seem to be installed anyways, so this missing action poses no threat. I guess a kWarning would be sufficient for this. Diffs - powerdevil/daemon/actions/CMakeLists.txt db9ca47 powerdevil/daemon/actions/dpms/powerdevildpmsaction.cpp 55689b5 powerdevil/daemon/powerdevilactionpool.cpp a9950f1 Diff: http://git.reviewboard.kde.org/r/106863/diff/ Testing --- Compiles. The previous passivepopup does not appear anymore. Did not test whether the kwarning is triggered, though. (Dunno how to get powerdevil debug console output) Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel
