Re: [Kde-hardware-devel] Review Request 123263: WIP: KDE Connect backend for Solid
On July 31, 2015, 12:38 p.m., Aleix Pol Gonzalez wrote: Is it done yet? What's the status? Kai Uwe Broulik wrote: I don't know, someone marked it as submitted but it cearly isn't. What's left before we can merge it? - Albert --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123263/#review83263 --- On July 31, 2015, 12:15 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123263/ --- (Updated July 31, 2015, 12:15 p.m.) Review request for kdeconnect, Solid, Albert Vaca Cintora, and Emmanuel Pescosta. Repository: solid Description --- This adds a KDE Connect backend to Solid enabling us to show phone battery status in the device notifier, and have the phone appear in the device notifier like an external storage. It is pretty synchronous at the moment. Any ideas how I could improve that? I guess when someone wants to get devices, it creates a new device interface and calls allDevices() or devicesFromQuery() immediately afterwards, so I cannot just do that stuff async and defer population? Or call deviceAdded for each of the initial ones once I have them? It requires adjustment in the kdeconnect KIO slave so it can handle addresses like kdeconnect://org/kde/kdeconnect/123456 or kdeconnect:udi=/org/kde/kdeconnect/123456 (like mtp kio does) because all Dolphin or the device notifier have is the UDI. It also needs a new device action that matches Portable Media Player with the kdeconnect protocol, similar to mtp. By adjusting the predicate in Dolphin's Places sidebar (and probably the file dialog) to query for the kdeconnect protocol, we can have its places automatically updated without having KDE Connect manually mess with KFilePlaces. Diffs - src/solid/devices/CMakeLists.txt 9271ae1 src/solid/devices/backends/kdeconnect/CMakeLists.txt PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectbattery.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectbattery.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdevice.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdevice.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdeviceinterface.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdeviceinterface.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectmanager.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectmanager.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectportablemediaplayer.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectportablemediaplayer.cpp PRE-CREATION src/solid/devices/managerbase.cpp eee4de5 Diff: https://git.reviewboard.kde.org/r/123263/diff/ Testing --- With some crash fixes already pushed to plasma-workspace it works pretty well. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel
Re: [Kde-hardware-devel] Review Request 123263: WIP: KDE Connect backend for Solid
On Juli 31, 2015, 7:38 nachm., Aleix Pol Gonzalez wrote: Is it done yet? What's the status? I don't know, someone marked it as submitted but it cearly isn't. - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123263/#review83263 --- On Juli 31, 2015, 7:15 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123263/ --- (Updated Juli 31, 2015, 7:15 nachm.) Review request for kdeconnect, Solid, Albert Vaca Cintora, and Emmanuel Pescosta. Repository: solid Description --- This adds a KDE Connect backend to Solid enabling us to show phone battery status in the device notifier, and have the phone appear in the device notifier like an external storage. It is pretty synchronous at the moment. Any ideas how I could improve that? I guess when someone wants to get devices, it creates a new device interface and calls allDevices() or devicesFromQuery() immediately afterwards, so I cannot just do that stuff async and defer population? Or call deviceAdded for each of the initial ones once I have them? It requires adjustment in the kdeconnect KIO slave so it can handle addresses like kdeconnect://org/kde/kdeconnect/123456 or kdeconnect:udi=/org/kde/kdeconnect/123456 (like mtp kio does) because all Dolphin or the device notifier have is the UDI. It also needs a new device action that matches Portable Media Player with the kdeconnect protocol, similar to mtp. By adjusting the predicate in Dolphin's Places sidebar (and probably the file dialog) to query for the kdeconnect protocol, we can have its places automatically updated without having KDE Connect manually mess with KFilePlaces. Diffs - src/solid/devices/CMakeLists.txt 9271ae1 src/solid/devices/backends/kdeconnect/CMakeLists.txt PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectbattery.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectbattery.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdevice.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdevice.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdeviceinterface.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdeviceinterface.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectmanager.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectmanager.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectportablemediaplayer.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectportablemediaplayer.cpp PRE-CREATION src/solid/devices/managerbase.cpp eee4de5 Diff: https://git.reviewboard.kde.org/r/123263/diff/ Testing --- With some crash fixes already pushed to plasma-workspace it works pretty well. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel
Re: [Kde-hardware-devel] Review Request 123263: WIP: KDE Connect backend for Solid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123263/#review83263 --- Is it done yet? What's the status? - Aleix Pol Gonzalez On jul. 31, 2015, 9:15 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123263/ --- (Updated jul. 31, 2015, 9:15 p.m.) Review request for kdeconnect, Solid, Albert Vaca Cintora, and Emmanuel Pescosta. Repository: solid Description --- This adds a KDE Connect backend to Solid enabling us to show phone battery status in the device notifier, and have the phone appear in the device notifier like an external storage. It is pretty synchronous at the moment. Any ideas how I could improve that? I guess when someone wants to get devices, it creates a new device interface and calls allDevices() or devicesFromQuery() immediately afterwards, so I cannot just do that stuff async and defer population? Or call deviceAdded for each of the initial ones once I have them? It requires adjustment in the kdeconnect KIO slave so it can handle addresses like kdeconnect://org/kde/kdeconnect/123456 or kdeconnect:udi=/org/kde/kdeconnect/123456 (like mtp kio does) because all Dolphin or the device notifier have is the UDI. It also needs a new device action that matches Portable Media Player with the kdeconnect protocol, similar to mtp. By adjusting the predicate in Dolphin's Places sidebar (and probably the file dialog) to query for the kdeconnect protocol, we can have its places automatically updated without having KDE Connect manually mess with KFilePlaces. Diffs - src/solid/devices/CMakeLists.txt 9271ae1 src/solid/devices/backends/kdeconnect/CMakeLists.txt PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectbattery.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectbattery.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdevice.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdevice.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdeviceinterface.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdeviceinterface.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectmanager.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectmanager.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectportablemediaplayer.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectportablemediaplayer.cpp PRE-CREATION src/solid/devices/managerbase.cpp eee4de5 Diff: https://git.reviewboard.kde.org/r/123263/diff/ Testing --- With some crash fixes already pushed to plasma-workspace it works pretty well. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel
Re: [Kde-hardware-devel] Review Request 123263: WIP: KDE Connect backend for Solid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123263/ --- (Updated jul. 31, 2015, 9:15 p.m.) Status -- This change has been marked as submitted. Review request for kdeconnect, Solid, Albert Vaca Cintora, and Emmanuel Pescosta. Repository: solid Description --- This adds a KDE Connect backend to Solid enabling us to show phone battery status in the device notifier, and have the phone appear in the device notifier like an external storage. It is pretty synchronous at the moment. Any ideas how I could improve that? I guess when someone wants to get devices, it creates a new device interface and calls allDevices() or devicesFromQuery() immediately afterwards, so I cannot just do that stuff async and defer population? Or call deviceAdded for each of the initial ones once I have them? It requires adjustment in the kdeconnect KIO slave so it can handle addresses like kdeconnect://org/kde/kdeconnect/123456 or kdeconnect:udi=/org/kde/kdeconnect/123456 (like mtp kio does) because all Dolphin or the device notifier have is the UDI. It also needs a new device action that matches Portable Media Player with the kdeconnect protocol, similar to mtp. By adjusting the predicate in Dolphin's Places sidebar (and probably the file dialog) to query for the kdeconnect protocol, we can have its places automatically updated without having KDE Connect manually mess with KFilePlaces. Diffs - src/solid/devices/CMakeLists.txt 9271ae1 src/solid/devices/backends/kdeconnect/CMakeLists.txt PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectbattery.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectbattery.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdevice.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdevice.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdeviceinterface.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdeviceinterface.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectmanager.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectmanager.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectportablemediaplayer.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectportablemediaplayer.cpp PRE-CREATION src/solid/devices/managerbase.cpp eee4de5 Diff: https://git.reviewboard.kde.org/r/123263/diff/ Testing --- With some crash fixes already pushed to plasma-workspace it works pretty well. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel