[Kde-hardware-devel] Review Request 113587: Add support for x-gvfs style options in fstab

2013-11-02 Thread Stefan Brüns

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113587/
---

Review request for Solid.


Repository: kdelibs


Description
---

These fstab options allows an administrator to specify names and icons intended 
for the user, shown in a GUI
For details, see 
https://git.gnome.org/browse/gvfs/tree/monitor/udisks2/what-is-shown.txt


Diffs
-

  solid/solid/backends/fstab/fstabdevice.h bac409e 
  solid/solid/backends/fstab/fstabdevice.cpp 0c91c6a 
  solid/solid/backends/fstab/fstabhandling.h 4780a67 
  solid/solid/backends/fstab/fstabhandling.cpp e874ffd 
  solid/solid/backends/fstab/fstabstorageaccess.h bbe93e3 
  solid/solid/backends/fstab/fstabstorageaccess.cpp 5482d48 

Diff: http://git.reviewboard.kde.org/r/113587/diff/


Testing
---

Add x-gvfs-name=Share%20on%20Laptop to CIFS mount, open dolphin - Name has 
changed


Thanks,

Stefan Brüns

___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel


Re: [Kde-hardware-devel] Review Request 113587: Add support for x-gvfs style options in fstab

2013-11-03 Thread Stefan Brüns

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113587/
---

(Updated Nov. 3, 2013, 2:36 p.m.)


Review request for Solid.


Changes
---

Adjusted coding style, added translation to description string


Repository: kdelibs


Description
---

These fstab options allows an administrator to specify names and icons intended 
for the user, shown in a GUI
For details, see 
https://git.gnome.org/browse/gvfs/tree/monitor/udisks2/what-is-shown.txt


Diffs (updated)
-

  solid/solid/backends/fstab/fstabstorageaccess.cpp 5482d48 
  solid/solid/backends/fstab/fstabstorageaccess.h bbe93e3 
  solid/solid/backends/fstab/fstabhandling.cpp e874ffd 
  solid/solid/backends/fstab/fstabhandling.h 4780a67 
  solid/solid/backends/fstab/fstabdevice.cpp 0c91c6a 
  solid/solid/backends/fstab/fstabdevice.h bac409e 

Diff: http://git.reviewboard.kde.org/r/113587/diff/


Testing
---

Add x-gvfs-name=Share%20on%20Laptop to CIFS mount, open dolphin - Name has 
changed


Thanks,

Stefan Brüns

___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel


Re: [Kde-hardware-devel] Review Request 113587: Add support for x-gvfs style options in fstab

2013-11-03 Thread Stefan Brüns


 On Nov. 3, 2013, 11:41 a.m., Kai Uwe Broulik wrote:
  solid/solid/backends/fstab/fstabdevice.cpp, line 60
  http://git.reviewboard.kde.org/r/113587/diff/1/?file=208373#file208373line60
 
  Needs i18n(c)?

This was leveraged from the old code, but will change ...


- Stefan


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113587/#review42884
---


On Nov. 3, 2013, 2:36 p.m., Stefan Brüns wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/113587/
 ---
 
 (Updated Nov. 3, 2013, 2:36 p.m.)
 
 
 Review request for Solid.
 
 
 Repository: kdelibs
 
 
 Description
 ---
 
 These fstab options allows an administrator to specify names and icons 
 intended for the user, shown in a GUI
 For details, see 
 https://git.gnome.org/browse/gvfs/tree/monitor/udisks2/what-is-shown.txt
 
 
 Diffs
 -
 
   solid/solid/backends/fstab/fstabstorageaccess.cpp 5482d48 
   solid/solid/backends/fstab/fstabstorageaccess.h bbe93e3 
   solid/solid/backends/fstab/fstabhandling.cpp e874ffd 
   solid/solid/backends/fstab/fstabhandling.h 4780a67 
   solid/solid/backends/fstab/fstabdevice.cpp 0c91c6a 
   solid/solid/backends/fstab/fstabdevice.h bac409e 
 
 Diff: http://git.reviewboard.kde.org/r/113587/diff/
 
 
 Testing
 ---
 
 Add x-gvfs-name=Share%20on%20Laptop to CIFS mount, open dolphin - Name has 
 changed
 
 
 Thanks,
 
 Stefan Brüns
 


___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel


Re: [Kde-hardware-devel] Review Request 113587: Add support for x-gvfs style options in fstab

2013-11-03 Thread Stefan Brüns

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113587/
---

(Updated Nov. 3, 2013, 2:41 p.m.)


Review request for Solid.


Repository: kdelibs


Description
---

These fstab options allows an administrator to specify names and icons intended 
for the user, shown in a GUI
For details, see 
https://git.gnome.org/browse/gvfs/tree/monitor/udisks2/what-is-shown.txt


Diffs (updated)
-

  solid/solid/backends/fstab/fstabstorageaccess.cpp 5482d48 
  solid/solid/backends/fstab/fstabstorageaccess.h bbe93e3 
  solid/solid/backends/fstab/fstabhandling.cpp e874ffd 
  solid/solid/backends/fstab/fstabhandling.h 4780a67 
  solid/solid/backends/fstab/fstabdevice.cpp 0c91c6a 
  solid/solid/backends/fstab/fstabdevice.h bac409e 

Diff: http://git.reviewboard.kde.org/r/113587/diff/


Testing
---

Add x-gvfs-name=Share%20on%20Laptop to CIFS mount, open dolphin - Name has 
changed


Thanks,

Stefan Brüns

___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel


Re: [Kde-hardware-devel] Review Request 113587: Add support for x-gvfs style options in fstab

2013-11-24 Thread Stefan Brüns

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113587/#review44346
---


So, ship it or drop it?

- Stefan Brüns


On Nov. 3, 2013, 2:41 p.m., Stefan Brüns wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/113587/
 ---
 
 (Updated Nov. 3, 2013, 2:41 p.m.)
 
 
 Review request for Solid.
 
 
 Repository: kdelibs
 
 
 Description
 ---
 
 These fstab options allows an administrator to specify names and icons 
 intended for the user, shown in a GUI
 For details, see 
 https://git.gnome.org/browse/gvfs/tree/monitor/udisks2/what-is-shown.txt
 
 
 Diffs
 -
 
   solid/solid/backends/fstab/fstabstorageaccess.cpp 5482d48 
   solid/solid/backends/fstab/fstabstorageaccess.h bbe93e3 
   solid/solid/backends/fstab/fstabhandling.cpp e874ffd 
   solid/solid/backends/fstab/fstabhandling.h 4780a67 
   solid/solid/backends/fstab/fstabdevice.cpp 0c91c6a 
   solid/solid/backends/fstab/fstabdevice.h bac409e 
 
 Diff: http://git.reviewboard.kde.org/r/113587/diff/
 
 
 Testing
 ---
 
 Add x-gvfs-name=Share%20on%20Laptop to CIFS mount, open dolphin - Name has 
 changed
 
 
 Thanks,
 
 Stefan Brüns
 


___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel


Re: [Kde-hardware-devel] Review Request 113587: Add support for x-gvfs style options in fstab

2014-06-21 Thread Stefan Brüns

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113587/
---

(Updated June 22, 2014, 1:39 a.m.)


Review request for kdelibs and Solid.


Changes
---

Still waiting for review ...


Repository: kdelibs


Description
---

These fstab options allows an administrator to specify names and icons intended 
for the user, shown in a GUI
For details, see 
https://git.gnome.org/browse/gvfs/tree/monitor/udisks2/what-is-shown.txt


Diffs
-

  solid/solid/backends/fstab/fstabstorageaccess.cpp 5482d48 
  solid/solid/backends/fstab/fstabstorageaccess.h bbe93e3 
  solid/solid/backends/fstab/fstabhandling.cpp e874ffd 
  solid/solid/backends/fstab/fstabhandling.h 4780a67 
  solid/solid/backends/fstab/fstabdevice.cpp 0c91c6a 
  solid/solid/backends/fstab/fstabdevice.h bac409e 

Diff: https://git.reviewboard.kde.org/r/113587/diff/


Testing
---

Add x-gvfs-name=Share%20on%20Laptop to CIFS mount, open dolphin - Name has 
changed


Thanks,

Stefan Brüns

___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel


Re: Review Request 113587: Add support for x-gvfs style options in fstab

2017-03-13 Thread Stefan Brüns

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113587/
---

(Updated March 13, 2017, 9:37 p.m.)


Status
--

This change has been discarded.


Review request for kdelibs and Solid.


Repository: kdelibs


Description
---

These fstab options allows an administrator to specify names and icons intended 
for the user, shown in a GUI
For details, see 
https://git.gnome.org/browse/gvfs/tree/monitor/udisks2/what-is-shown.txt


Diffs
-

  solid/solid/backends/fstab/fstabdevice.h bac409e 
  solid/solid/backends/fstab/fstabdevice.cpp 0c91c6a 
  solid/solid/backends/fstab/fstabhandling.h 4780a67 
  solid/solid/backends/fstab/fstabhandling.cpp e874ffd 
  solid/solid/backends/fstab/fstabstorageaccess.h bbe93e3 
  solid/solid/backends/fstab/fstabstorageaccess.cpp 5482d48 

Diff: https://git.reviewboard.kde.org/r/113587/diff/


Testing
---

Add "x-gvfs-name=Share%20on%20Laptop" to CIFS mount, open dolphin -> Name has 
changed


Thanks,

Stefan Brüns