[Bug 310734] Akonadi DAV resource doesn't react on 403 errors

2012-11-28 Thread Grégory Oestreicher
https://bugs.kde.org/show_bug.cgi?id=310734

--- Comment #9 from Grégory Oestreicher  ---
(In reply to comment #8)
> Should I file another report regarding not checking for unbind privilege?

That's up to you, or we can continue in private email. Maybe making this public
would help people finding why some servers that used to work suddenly break
awfully :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs


[Bug 310734] Akonadi DAV resource doesn't react on 403 errors

2012-11-27 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=310734

Christoph Feck  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs


[Bug 310734] Akonadi DAV resource doesn't react on 403 errors

2012-11-27 Thread Thomas Tanghus
https://bugs.kde.org/show_bug.cgi?id=310734

Thomas Tanghus  changed:

   What|Removed |Added

 Status|RESOLVED|UNCONFIRMED
 Resolution|FIXED   |---

--- Comment #8 from Thomas Tanghus  ---
That was fast! Thanks Grégory.
Should I file another report regarding not checking for unbind privilege?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs


[Bug 310734] Akonadi DAV resource doesn't react on 403 errors

2012-11-27 Thread Grégory Oestreicher
https://bugs.kde.org/show_bug.cgi?id=310734

Grégory Oestreicher  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
   Version Fixed In||4.9.4
 Resolution|--- |FIXED
  Latest Commit||http://commits.kde.org/kdep
   ||im-runtime/f8105ee3df44b88f
   ||371f914de68571e73f736fa1

--- Comment #7 from Grégory Oestreicher  ---
Git commit f8105ee3df44b88f371f914de68571e73f736fa1 by Grégory Oestreicher.
Committed on 27/11/2012 at 22:53.
Pushed by goestreicher into branch 'KDE/4.9'.

Always report deletion errors
FIXED-IN: 4.9.4

M  +4-15   resources/dav/resource/davgroupwareresource.cpp

http://commits.kde.org/kdepim-runtime/f8105ee3df44b88f371f914de68571e73f736fa1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs


[Bug 310734] Akonadi DAV resource doesn't react on 403 errors

2012-11-27 Thread Thomas Tanghus
https://bugs.kde.org/show_bug.cgi?id=310734

--- Comment #6 from Thomas Tanghus  ---
(In reply to comment #4)
> What do you mean by 'assigned to the resource'? From OwnCloud UI?

Currently from phpmyadmin ;)

> If you're fine with posting the response XML please do so, I'll have a look.

No problem. It's just test data. The ACL for the collection looks OK to me. It
only has write-content permission, but the Akonadi DAV resource apparently
interprets that as write including bind and unbind?
The bind and unbind on the contained resource is superfluous, but the client
should just ignore it as I understand from the RFC
https://tools.ietf.org/html/rfc3744#section-3.9

The permissions are checked here btw
https://github.com/owncloud/apps/blob/master/contacts/lib/sabre/addressbook.php#L67

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs


[Bug 310734] Akonadi DAV resource doesn't react on 403 errors

2012-11-27 Thread Thomas Tanghus
https://bugs.kde.org/show_bug.cgi?id=310734

--- Comment #5 from Thomas Tanghus  ---
Created attachment 75505
  --> https://bugs.kde.org/attachment.cgi?id=75505&action=edit
Result from current-user-privilege-set query

I only left results from one contained resource in the collection.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs


[Bug 310734] Akonadi DAV resource doesn't react on 403 errors

2012-11-27 Thread Grégory Oestreicher
https://bugs.kde.org/show_bug.cgi?id=310734

--- Comment #4 from Grégory Oestreicher  ---
(In reply to comment #3)
> >Can you have a look at the collection permissions in akonadiconsole?
> 
> Right click on collection->Folder properties->ACL, right?

Exact.

> Create/Modify/Delete for both collection and items. This is actually not
> what I assigned to the resource. 

What do you mean by 'assigned to the resource'? From OwnCloud UI?

> What is the proper query to retrieve the ACL?

The resource uses current-user-privilege-set, as defined in rfc3744. You can
check it out here: http://tools.ietf.org/html/rfc3744#page-21

To know what the resource receives you can run a network capture over an
unencrypted link and look for the response from the server to this query. If
you're fine with posting the response XML please do so, I'll have a look.

For the initial issue I'll try to find some time tonight to have a look. The
resource should catch the 403.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs


[Bug 310734] Akonadi DAV resource doesn't react on 403 errors

2012-11-27 Thread Thomas Tanghus
https://bugs.kde.org/show_bug.cgi?id=310734

--- Comment #3 from Thomas Tanghus  ---
(In reply to comment #2)
> It's weird that you are able to delete in the first place. If the ACLs were
> applied correctly then you couldn't. 

I'm still trying to grasp WebDAV ACLs, so I may have made errors in them :-P

>Can you have a look at the collection permissions in akonadiconsole?

Right click on collection->Folder properties->ACL, right?
Create/Modify/Delete for both collection and items. This is actually not what I
assigned to the resource. 
What is the proper query to retrieve the ACL?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs


[Bug 310734] Akonadi DAV resource doesn't react on 403 errors

2012-11-26 Thread Grégory Oestreicher
https://bugs.kde.org/show_bug.cgi?id=310734

Grégory Oestreicher  changed:

   What|Removed |Added

 CC||g...@kamago.net

--- Comment #2 from Grégory Oestreicher  ---
It's weird that you are able to delete in the first place. If the ACLs were
applied correctly then you couldn't. Can you have a look at the collection
permissions in akonadiconsole?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs


[Bug 310734] Akonadi DAV resource doesn't react on 403 errors

2012-11-26 Thread Thomas Tanghus
https://bugs.kde.org/show_bug.cgi?id=310734

--- Comment #1 from Thomas Tanghus  ---
He he, just noticed that it doesn't respond on error 500 either, but I found a
bug in my code meanwhile ;)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs