[frameworks-kholidays] [Bug 392503] holidays for India (in_en-gb) not complete

[Allen Winter]

https://bugs.kde.org/show_bug.cgi?id=392503

Allen Winter  changed:

   What|Removed |Added

   Version Fixed In||5.45

--- Comment #13 from Allen Winter  ---
I wonder how/if to backport this since kholidays was previously not a
framework?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[frameworks-kholidays] [Bug 392503] holidays for India (in_en-gb) not complete

[Allen Winter]

https://bugs.kde.org/show_bug.cgi?id=392503

Allen Winter  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/kho
   ||lidays/c84e4d9d1724e4d49bbb
   ||2ae8db32c47a4c098ed7
 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED

--- Comment #12 from Allen Winter  ---
Git commit c84e4d9d1724e4d49bbb2ae8db32c47a4c098ed7 by Allen Winter.
Committed on 02/04/2018 at 17:29.
Pushed by winterz into branch 'master'.

holidays/plan2/holiday_in_en-gb - update holiday file for India
Thank you for the patch.

M  +136  -29   holidays/plan2/holiday_in_en-gb

https://commits.kde.org/kholidays/c84e4d9d1724e4d49bbb2ae8db32c47a4c098ed7

-- 
You are receiving this mail because:
You are the assignee for the bug.

[frameworks-kholidays] [Bug 392503] holidays for India (in_en-gb) not complete

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=392503

--- Comment #11 from sk.griffi...@gmail.com ---
Created attachment 111748
  --> https://bugs.kde.org/attachment.cgi?id=111748=edit
holiday file for india (spellings corrected)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[frameworks-kholidays] [Bug 392503] holidays for India (in_en-gb) not complete

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=392503

--- Comment #10 from sk.griffi...@gmail.com ---
I will change no earlier than 5:00:00 UTC

-- 
You are receiving this mail because:
You are the assignee for the bug.

[frameworks-kholidays] [Bug 392503] holidays for India (in_en-gb) not complete

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=392503

--- Comment #9 from sk.griffi...@gmail.com ---
Oops

-- 
You are receiving this mail because:
You are the assignee for the bug.

[frameworks-kholidays] [Bug 392503] holidays for India (in_en-gb) not complete

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=392503

--- Comment #8 from Christoph Feck  ---
relegious -> religious

-- 
You are receiving this mail because:
You are the assignee for the bug.

[frameworks-kholidays] [Bug 392503] holidays for India (in_en-gb) not complete

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=392503

--- Comment #7 from sk.griffi...@gmail.com ---
How is the file added to frameworks? How can i modify the one on my computer?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[frameworks-kholidays] [Bug 392503] holidays for India (in_en-gb) not complete

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=392503

--- Comment #6 from sk.griffi...@gmail.com ---
Created attachment 111742
  --> https://bugs.kde.org/attachment.cgi?id=111742=edit
holiday file for india

-- 
You are receiving this mail because:
You are the assignee for the bug.

[frameworks-kholidays] [Bug 392503] holidays for India (in_en-gb) not complete

[Christophe Giboudeaux]

https://bugs.kde.org/show_bug.cgi?id=392503

Christophe Giboudeaux  changed:

   What|Removed |Added

 CC||win...@kde.org

--- Comment #5 from Christophe Giboudeaux  ---
I'm afraid you're right, the lunar calendar doesn't seem to be supported.

A solution could be specifying the days for each year (starting with 2018 and
for a couple years).

That's what was done eg. in the indonesian file (holiday_id_id)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[frameworks-kholidays] [Bug 392503] holidays for India (in_en-gb) not complete

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=392503

--- Comment #4 from sk.griffi...@gmail.com ---
This might be more difficult than anticipated. The holidays are based on hindu
calendar, which varies from the georgian calendar. The indiannational calender
that is supported also corresponds to georgian calendar. The closest one to
hindu calendar is the hebrew calendar, but its not exactly corresponding. The
best bet would be to add support for hindu calendar. Alternatively, if the
dates of holidays in hindu calendar can be compared to hebrew one, and if they
are found to match for reasonable number of years, then the holiday file can be
created with dates referred with the hebrew calendar. However i lack the
resources to compare them. If someone can point me, i would be prepared to
verify

-- 
You are receiving this mail because:
You are the assignee for the bug.

[frameworks-kholidays] [Bug 392503] holidays for India (in_en-gb) not complete

[Christophe Giboudeaux]

https://bugs.kde.org/show_bug.cgi?id=392503

--- Comment #3 from Christophe Giboudeaux  ---
Thanks !

-- 
You are receiving this mail because:
You are the assignee for the bug.

[frameworks-kholidays] [Bug 392503] holidays for India (in_en-gb) not complete

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=392503

--- Comment #2 from sk.griffi...@gmail.com ---
I have little experience in programming but i will try

-- 
You are receiving this mail because:
You are the assignee for the bug.

[frameworks-kholidays] [Bug 392503] holidays for India (in_en-gb) not complete

[Christophe Giboudeaux]

https://bugs.kde.org/show_bug.cgi?id=392503

--- Comment #1 from Christophe Giboudeaux  ---
Do you want to submit a patch ?

The code can be found in the kholidays repository
(https://cgit.kde.org/kholidays.git/)

The file format is explained in the file-format.txt file and the holidays files
are in the plan2/ folder.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[frameworks-kholidays] [Bug 392503] holidays for India (in_en-gb) not complete

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=392503

sk.griffi...@gmail.com changed:

   What|Removed |Added

 CC||sk.griffi...@gmail.com
Version|unspecified |5.44.0

-- 
You are receiving this mail because:
You are the assignee for the bug.