[kmail2] [Bug 398036] Password for sending mails not used when specified via password prompt

2018-08-31 Thread Jan Hambrecht
https://bugs.kde.org/show_bug.cgi?id=398036

--- Comment #7 from Jan Hambrecht  ---
Many thanks and great work!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmail2] [Bug 398036] Password for sending mails not used when specified via password prompt

2018-08-31 Thread Luca Beltrame
https://bugs.kde.org/show_bug.cgi?id=398036

Luca Beltrame  changed:

   What|Removed |Added

 CC||lbeltr...@kde.org

--- Comment #6 from Luca Beltrame  ---
Note that you also need
https://commits.kde.org/kmailtransport/6656ae1449c8743243391d15dca41a912e2aecd3
in case you need to patch it yourself due to a small error that cropped up in
the previous commit.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmail2] [Bug 398036] Password for sending mails not used when specified via password prompt

2018-08-31 Thread Laurent Montel
https://bugs.kde.org/show_bug.cgi?id=398036

Laurent Montel  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
  Latest Commit||https://commits.kde.org/kma
   ||iltransport/6c0464d203066cd
   ||dadc9383867d6d585b0e613f4
 Resolution|--- |FIXED
   Version Fixed In||5.9.1

--- Comment #5 from Laurent Montel  ---
Git commit 6c0464d203066cddadc9383867d6d585b0e613f4 by Laurent Montel.
Committed on 31/08/2018 at 06:46.
Pushed by mlaurent into branch 'Applications/18.08'.

Fix Bug 398036 - Password for sending mails not used when specified via
password prompt

Thanks Jan Hambrecht for debugging
FIXED-IN: 5.9.1

M  +3-2src/kmailtransport/plugins/smtp/smtpjob.cpp

https://commits.kde.org/kmailtransport/6c0464d203066cddadc9383867d6d585b0e613f4

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmail2] [Bug 398036] Password for sending mails not used when specified via password prompt

2018-08-30 Thread Jan Hambrecht
https://bugs.kde.org/show_bug.cgi?id=398036

--- Comment #4 from Jan Hambrecht  ---
Looking at src/kmailtransport/plugins/smtp/smtpjob.cpp it seems the password
from the password dialog is only set to the transport but not to the login job
(see line 290). Probably because of the XOAUTH2 handling in line 286.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmail2] [Bug 398036] Password for sending mails not used when specified via password prompt

2018-08-30 Thread Laurent Montel
https://bugs.kde.org/show_bug.cgi?id=398036

--- Comment #3 from Laurent Montel  ---
Git commit 325d0e03480ee756713eccdcffe19a09c44daff2 by Laurent Montel.
Committed on 30/08/2018 at 11:49.
Pushed by mlaurent into branch 'Applications/18.08'.

Disable password lineedit when we don't store password

M  +14   -1src/kmailtransport/plugins/smtp/smtpconfigwidget.cpp
M  +1-0src/kmailtransport/plugins/smtp/smtpconfigwidget.h

https://commits.kde.org/kmailtransport/325d0e03480ee756713eccdcffe19a09c44daff2

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmail2] [Bug 398036] Password for sending mails not used when specified via password prompt

2018-08-30 Thread Jan Hambrecht
https://bugs.kde.org/show_bug.cgi?id=398036

--- Comment #2 from Jan Hambrecht  ---
Yes it is probably sensible to disable the lineedit in the settings dialog if
the store password option is unchecked.

In any case if kmail asks the user for a password via the password prompt
popping up before sending, it should be used for authentication on the mail
server. Otherwise there is no point asking the user for a password, isn't it?
This used to work in older versions and just stopped working in the last kmail
version.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmail2] [Bug 398036] Password for sending mails not used when specified via password prompt

2018-08-30 Thread Laurent Montel
https://bugs.kde.org/show_bug.cgi?id=398036

Laurent Montel  changed:

   What|Removed |Added

 CC||mon...@kde.org

--- Comment #1 from Laurent Montel  ---
Hi,
How do you want that it works ?

Perhaps I need to disable password lineedit when we don't store password.
IT's more logical as it's never stored no ?

-- 
You are receiving this mail because:
You are the assignee for the bug.