Re: [PATCH] Add touchscreen and pen driver for the Surface 3
On Fri, Jul 29, 2016 at 9:03 AM, Bastien Nocera wrote: > Yes, see the upstream "Input: surface3_spi - add surface pen support for > Surface 3" patch. > But that's just the tip of the pen, the button at the top of it is a > Bluetooth device, so if you want to be more precise in the changelog entry. OK. Applied and pushed out. josh ___ kernel mailing list kernel@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/kernel@lists.fedoraproject.org
Re: [PATCH] Add CrystalCove PWM support, for CherryTrail devices
OK, noted for next time. Thanks
- Original Message -
> On Thu, Jul 28, 2016 at 7:35 AM, Bastien Nocera wrote:
> > From: Bastien Nocera
> >
> > ---
> > config-x86-generic | 2 +-
> > kernel.spec| 5 -
> > 2 files changed, 5 insertions(+), 2 deletions(-)
>
> Fixed up to apply and pushed. A small comment below.
>
> > diff --git a/config-x86-generic b/config-x86-generic
> > index c9a654a..0f66965 100644
> > --- a/config-x86-generic
> > +++ b/config-x86-generic
> > @@ -122,7 +122,7 @@ CONFIG_BXT_WC_PMIC_OPREGION=y
> > CONFIG_GPIO_CRYSTAL_COVE=y
> > CONFIG_AXP288_ADC=y
> > CONFIG_AXP288_FUEL_GAUGE=y
> > -# CONFIG_PWM_CRC is not set
> > +CONFIG_PWM_CRC=y
> >
> >
> > CONFIG_X86_INTEL_PSTATE=y
> > diff --git a/kernel.spec b/kernel.spec
> > index 35ac1fb..984d88f 100644
> > --- a/kernel.spec
> > +++ b/kernel.spec
> > @@ -42,7 +42,7 @@ Summary: The Linux kernel
> > # For non-released -rc kernels, this will be appended after the rcX and
> > # gitX tags, so a 3 here would become part of release "0.rcX.gitX.3"
> > #
> > -%global baserelease 1
> > +%global baserelease 2
> > %global fedora_build %{baserelease}
>
> This kind of change is fine, but mostly unnecessary since rawhide is
> rebuilt every day.
>
> > # base_sublevel is the kernel version we're starting with and patching
> > @@ -2168,6 +2168,9 @@ fi
> > #
> > #
> > %changelog
> > +* Thu Jul 28 2016 Bastien Nocera - 4.8.0-0.rc0.git1.2
> > +- Add CrystalCove PWM support, for CherryTrail devices
>
> We only add the version/release info if we're actually going to do a
> build off of this specific commit. Otherwise just omit that part.
>
> Thanks.
>
> josh
> ___
> kernel mailing list
> kernel@lists.fedoraproject.org
> https://lists.fedoraproject.org/admin/lists/kernel@lists.fedoraproject.org
>
___
kernel mailing list
kernel@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/kernel@lists.fedoraproject.org
Re: [PATCH] Add touchscreen and pen driver for the Surface 3
Yes, see the upstream "Input: surface3_spi - add surface pen support for Surface 3" patch. But that's just the tip of the pen, the button at the top of it is a Bluetooth device, so if you want to be more precise in the changelog entry. - Original Message - > On Fri, Jul 29, 2016 at 8:58 AM, Bastien Nocera wrote: > > From: Bastien Nocera > > > > --- > > config-x86-generic | 1 + > > kernel.spec| 5 - > > 2 files changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/config-x86-generic b/config-x86-generic > > index 0f66965..a4a1640 100644 > > --- a/config-x86-generic > > +++ b/config-x86-generic > > @@ -278,6 +278,7 @@ CONFIG_PVPANIC=m > > > > # CONFIG_TOUCHSCREEN_INTEL_MID is not set > > CONFIG_TOUCHSCREEN_GOODIX=m > > +CONFIG_TOUCHSCREEN_SURFACE3_SPI=m > > This single option covers both the touchscreen and the pen devices? > > josh > ___ kernel mailing list kernel@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/kernel@lists.fedoraproject.org
Re: [PATCH] Add touchscreen and pen driver for the Surface 3
On Fri, Jul 29, 2016 at 8:58 AM, Bastien Nocera wrote: > From: Bastien Nocera > > --- > config-x86-generic | 1 + > kernel.spec| 5 - > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/config-x86-generic b/config-x86-generic > index 0f66965..a4a1640 100644 > --- a/config-x86-generic > +++ b/config-x86-generic > @@ -278,6 +278,7 @@ CONFIG_PVPANIC=m > > # CONFIG_TOUCHSCREEN_INTEL_MID is not set > CONFIG_TOUCHSCREEN_GOODIX=m > +CONFIG_TOUCHSCREEN_SURFACE3_SPI=m This single option covers both the touchscreen and the pen devices? josh ___ kernel mailing list kernel@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/kernel@lists.fedoraproject.org
Re: [PATCH] Add CrystalCove PWM support, for CherryTrail devices
On Thu, Jul 28, 2016 at 7:35 AM, Bastien Nocera wrote:
> From: Bastien Nocera
>
> ---
> config-x86-generic | 2 +-
> kernel.spec| 5 -
> 2 files changed, 5 insertions(+), 2 deletions(-)
Fixed up to apply and pushed. A small comment below.
> diff --git a/config-x86-generic b/config-x86-generic
> index c9a654a..0f66965 100644
> --- a/config-x86-generic
> +++ b/config-x86-generic
> @@ -122,7 +122,7 @@ CONFIG_BXT_WC_PMIC_OPREGION=y
> CONFIG_GPIO_CRYSTAL_COVE=y
> CONFIG_AXP288_ADC=y
> CONFIG_AXP288_FUEL_GAUGE=y
> -# CONFIG_PWM_CRC is not set
> +CONFIG_PWM_CRC=y
>
>
> CONFIG_X86_INTEL_PSTATE=y
> diff --git a/kernel.spec b/kernel.spec
> index 35ac1fb..984d88f 100644
> --- a/kernel.spec
> +++ b/kernel.spec
> @@ -42,7 +42,7 @@ Summary: The Linux kernel
> # For non-released -rc kernels, this will be appended after the rcX and
> # gitX tags, so a 3 here would become part of release "0.rcX.gitX.3"
> #
> -%global baserelease 1
> +%global baserelease 2
> %global fedora_build %{baserelease}
This kind of change is fine, but mostly unnecessary since rawhide is
rebuilt every day.
> # base_sublevel is the kernel version we're starting with and patching
> @@ -2168,6 +2168,9 @@ fi
> #
> #
> %changelog
> +* Thu Jul 28 2016 Bastien Nocera - 4.8.0-0.rc0.git1.2
> +- Add CrystalCove PWM support, for CherryTrail devices
We only add the version/release info if we're actually going to do a
build off of this specific commit. Otherwise just omit that part.
Thanks.
josh
___
kernel mailing list
kernel@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/kernel@lists.fedoraproject.org
[PATCH] Add touchscreen and pen driver for the Surface 3
From: Bastien Nocera
---
config-x86-generic | 1 +
kernel.spec| 5 -
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/config-x86-generic b/config-x86-generic
index 0f66965..a4a1640 100644
--- a/config-x86-generic
+++ b/config-x86-generic
@@ -278,6 +278,7 @@ CONFIG_PVPANIC=m
# CONFIG_TOUCHSCREEN_INTEL_MID is not set
CONFIG_TOUCHSCREEN_GOODIX=m
+CONFIG_TOUCHSCREEN_SURFACE3_SPI=m
# CONFIG_SMSC37B787_WDT is not set
CONFIG_VIA_WDT=m
diff --git a/kernel.spec b/kernel.spec
index a5c128e..55ca182 100644
--- a/kernel.spec
+++ b/kernel.spec
@@ -42,7 +42,7 @@ Summary: The Linux kernel
# For non-released -rc kernels, this will be appended after the rcX and
# gitX tags, so a 3 here would become part of release "0.rcX.gitX.3"
#
-%global baserelease 2
+%global baserelease 3
%global fedora_build %{baserelease}
# base_sublevel is the kernel version we're starting with and patching
@@ -2172,6 +2172,9 @@ fi
#
#
%changelog
+* Fri Jul 29 2016 Bastien Nocera - 4.8.0-0.rc0.git2.3
+- Add touchscreen and pen driver for the Surface 3
+
* Thu Jul 28 2016 Bastien Nocera - 4.8.0-0.rc0.git2.2
- Add CrystalCove PWM support, for CherryTrail devices
--
2.7.4
___
kernel mailing list
kernel@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/kernel@lists.fedoraproject.org
