Re: [OS-BUILD PATCH 0/0] common: build TRUSTED_KEYS in everywhere
From: Ondrej Mosnáček on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1284#note_663080152 Ok, you're almost there, but I'd like to see this information captured *in the commit message*. Years later, someone might wonder why `=y` was chosen for `CONFIG_TRUSTED_KEYS`. They should be able to just do `git log redhat/configs/common/generic/CONFIG_TRUSTED_KEYS` and see in the commit message the reasoning (e.g. something like "Set TRUSTED_KEYS to =y in both Fedora and RHEL, as otherwise breaks because IMA needs to use trusted keys early in the boot process."). This is what every developer should strive for in every commit message - explaining the "why" behind the change is crucial. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: [OS-BUILD PATCH] Use common config for NODES_SHIFT
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1333#note_662978276 This is due to a flaw in the logic of the updated ack_nack bot: https://gitlab.com/cki-project/kernel-webhooks/-/merge_requests/496 The idea was that if an MR touched a redhat/configs/CONFIG file then we'd find the corresponding Kconfig file and look up the Kconfig path in owners.yaml to find relevant reviewers. But of course with something like NODES_SHIFT that matches many different arch Kconfig files 臘. So I need to improve the logic to determine if the CONFIG file is in an arch- specific location and then filter any found Kconfigs based on that. But until that happens (next week?) you may find yourself added as a reviewer for the odd MR that is not relevant to you. Please ignore it. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: [OS-BUILD PATCH] arm64: use common CONFIG_MAX_ZONEORDER for arm kernel
From: Mark Langsdorf on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1331#note_662957636 Acked-by: Mark Langsdorf (via approve button) ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: [OS-BUILD PATCH] Use common config for NODES_SHIFT
From: Mark Salter on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1333#note_662954610 Just curious. Why the need for x86 review? ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[OS-BUILD PATCH] Use common config for NODES_SHIFT
From: Mark Salter Use common config for NODES_SHIFT ARK is currently has CONFIG_NODES_SHIFT=6 where Fedora is set to 9. Let's simplify things and share the Fedora config with ARK. Signed-off-by: Mark Salter diff --git a/redhat/configs/ark/generic/arm/aarch64/CONFIG_NODES_SHIFT b/redhat/configs/ark/generic/arm/aarch64/CONFIG_NODES_SHIFT deleted file mode 100644 index blahblah..blahblah 0 --- a/redhat/configs/ark/generic/arm/aarch64/CONFIG_NODES_SHIFT +++ /dev/null @@ -1 +0,0 @@ -CONFIG_NODES_SHIFT=6 diff --git a/redhat/configs/fedora/generic/arm/aarch64/CONFIG_NODES_SHIFT b/redhat/configs/common/generic/arm/aarch64/CONFIG_NODES_SHIFT rename from redhat/configs/fedora/generic/arm/aarch64/CONFIG_NODES_SHIFT rename to redhat/configs/common/generic/arm/aarch64/CONFIG_NODES_SHIFT index blahblah..blahblah 100644 --- a/redhat/configs/fedora/generic/arm/aarch64/CONFIG_NODES_SHIFT +++ b/redhat/configs/common/generic/arm/aarch64/CONFIG_NODES_SHIFT -- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1333 ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: [OS-BUILD PATCHv2] netfilter: Add deprecation notices for xtables
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1226#note_662676095 Closing this for now with a plan to repost later. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
