Re: [OS-BUILD PATCH 1/3] redhat: Use kspdx-tool output for the License: field
From: Herton R. Krzesinski on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2648#note_1527728838 Well there are still firmware being included in the linux sources, one example: ```drivers/net/appletalk/cops_ffdrv.h``` But probably cases like this should be handled upstream (moving or removing them..., or adding a proper SPDX identifier). From the License tag I think we need to remove the Redistributable... info since it's not a valid identifier. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCHv3] redhat/kernel.spec.template: update compression variables to support zstd
From: Scott Weaver on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2650#note_1527276870 OK, so this change was intentional and there doesn't seem to be a good reason to compress `Module.symvers` with `-9`. Dropping that looks okay to me. Thanks for the clarification. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCH 1/3] redhat: Use kspdx-tool output for the License: field
From: Jan Stancek on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2648#note_1526842225 not really a big issue, I'll resolve this too - can be fixed along some more important changes ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCH 1/3] redhat: Use kspdx-tool output for the License: field
From: Jan Stancek on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2648#note_1526841131 ok, since it seems unlikely, I'm going to resolve this thread, I opened you first issue :-) https://gitlab.com/vkuznets/kspdx-tool/-/issues/1 ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCH 1/3] redhat: Use kspdx-tool output for the License: field
From: Vitaly Kuznetsov on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2648#note_1526606091 Indeed! ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCH 1/3] redhat: Use kspdx-tool output for the License: field
From: Vitaly Kuznetsov on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2648#note_1526605878 Not that it is not allowed, just not present in the source :-) There's code to drop unneeded highest level parentheses so e.g. `(GPL-2.0-only)` becomes `GPL-2.0-only`, it can certainly be improved to cover this case, i.e. `(everythin-without-spaces)` == `everything-without-spaces`. FWIW, I have a repo for kspdx-tool here: https://gitlab.com/vkuznets/kspdx- tool and in the MR it's just a copy. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCHv3] redhat/kernel.spec.template: update compression variables to support zstd
From: Brian Masney on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2650#note_1526448774 `Module.symvers` was compressed with `-9` but the kernel modules were not compressed with that. I wanted to keep the compression consistent across the spec file. If we add `-9` to the `compression_flags` variable, then it's potentially going to increase the build time since it'll apply that to the kernel modules as well. I don't have any stats on how much, and overall it likely won't matter much. I can go either way with or without the `-9` flag, but I think it should be consistent across the two use cases. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCH 1/3] redhat: Use kspdx-tool output for the License: field
From: Jan Stancek on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2648#note_1526334920 This `pass` looks redundant ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCH 1/3] redhat: Use kspdx-tool output for the License: field
From: Jan Stancek on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2648#note_1526318798 Should these replacements also match deprecated licenses that end with ')'? Or is my format not allowed? ``` ]$ cat test/test.c // SPDX-License-Identifier: GPL-2.0 OR (GPL-1.0) $ ./redhat/scripts/kspdx-tool/kspdx.py ./test --joint GPL-2.0-only OR (GPL-1.0) ``` ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCH 1/3] redhat: Use kspdx-tool output for the License: field
From: Vitaly Kuznetsov on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2648#note_1526314134 FWIW, there's an ongoing discussion on making the resulting list of licenses way more readable by ignoring dual licensing, e.g. if a file is licensed under "(GPL-2.0-only WITH Linux-syscall-note) OR BSD-2-Clause" we can pick the less permissive "GPL-2.0-only WITH Linux-syscall-note" from the two. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCH 1/3] redhat: Use kspdx-tool output for the License: field
From: Vitaly Kuznetsov on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2648#note_1526295217 Yes, this is intentional. I (and the script which actually builds the 'License:' field now) didn't find anything under 'Redistributable' in the kernel. My guess is that this was a leftover from the times when kernel was also shipping firmware blobs. This is gone since 2017 with ``` commit 5620a0d1aacd554ebebcff373e31107bb1ef7769 Author: Greg Kroah-Hartman Date: Thu Sep 14 14:23:01 2017 -0700 firmware: delete in-kernel firmware ``` with all blobs moving to 'linux-firmware'. Secure Boot, as far as I understand, shouldn't have anything to do with licensing. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
