Re: [OS-BUILD PATCH 0/0] scsi: sd: remove unused sd_probe_types
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3055#note_1896848313 I am okay with this. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCHv17 0/2] redhat/kernel.spec: add uki_addons to create UKI kernel cmdline addons
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2917#note_1890590437 I would actually agree that I prefer the files broken out instead of a tarball. We could create a script that generates a manifest of file locations from the source repository, and a small script to properly place the files in the correct place based on that manifest during rpmbuild. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCHv3 0/6] secure boot signing updates
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2849#note_1881008425 As it turns out, the Silverblue desktop does not update their bootloader set up at right now, meaning those users are not getting the new shim yet. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCHv2 0/0] fedora: updates for 6.9 merge window
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3073#note_1871938140 It shouldn't need any RHEL acks, the common removal is a no-op for RHEL. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[OS-BUILD PATCHv3] Add libperf-debuginfo subpackage
From: Justin M. Forbes Add libperf-debuginfo subpackage When libperf was added, I failed to add the libperf-debuginfo subpackage. This leaves libperf debuginfo in kernel-debuginfo-common which is installonly, and creaes file conflicts. Add the debuginfo subpackage so things are where they belong. Signed-off-by: Justin M. Forbes diff --git a/redhat/kernel.spec.template b/redhat/kernel.spec.template index blahblah..blahblah 100644 --- a/redhat/kernel.spec.template +++ b/redhat/kernel.spec.template @@ -1137,6 +1137,19 @@ Summary: Developement files for the perf library from kernel source This package includes libraries and header files needed for development of applications which use perf library from kernel source. +%package -n libperf-debuginfo +Summary: Debug information for package libperf +Group: Development/Debug +Requires: %{name}-debuginfo-common-%{_target_cpu} = %{version}-%{release} +AutoReqProv: no +%description -n libperf-debuginfo +This package provides debug information for the libperf package. + +# Note that this pattern only works right to match the .build-id +# symlinks because of the trailing nonmatching alternation and +# the leading .*, because of find-debuginfo.sh's buggy handling +# of matching the pattern against the symlinks file. +%{expand:%%global _find_debuginfo_opts %{?_find_debuginfo_opts} -p '.*%%{_libdir}/libperf.so(\.debug)?|XXX' -o libperf-debuginfo.list} # with_libperf %endif @@ -3561,6 +3574,10 @@ fi\ %{_docdir}/libperf/html/libperf-counting.html %{_docdir}/libperf/html/libperf-sampling.html +%if %{with_debuginfo} +%files -f libperf-debuginfo.list -n libperf-debuginfo +%endif + # with_libperf %endif -- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2950 -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[OS-BUILD PATCHv2] Add libperf-debuginfo subpackage
From: Justin M. Forbes Add libperf-debuginfo subpackage When libperf was added, I failed to add the libperf-debuginfo subpackage. This leaves libperf debuginfo in kernel-debuginfo-common which is installonly, and creaes file conflicts. Add the debuginfo subpackage so things are where they belong. Signed-off-by: Justin M. Forbes diff --git a/redhat/kernel.spec.template b/redhat/kernel.spec.template index blahblah..blahblah 100644 --- a/redhat/kernel.spec.template +++ b/redhat/kernel.spec.template @@ -1137,6 +1137,19 @@ Summary: Developement files for the perf library from kernel source This package includes libraries and header files needed for development of applications which use perf library from kernel source. +%package -n libperf-debuginfo +Summary: Debug information for package libperf +Group: Development/Debug +Requires: %{name}-debuginfo-common-%{_target_cpu} = %{version}-%{release} +AutoReqProv: no +%description -n libperf-debuginfo +This package provides debug information for the libperf package. + +# Note that this pattern only works right to match the .build-id +# symlinks because of the trailing nonmatching alternation and +# the leading .*, because of find-debuginfo.sh's buggy handling +# of matching the pattern against the symlinks file. +%{expand:%%global _find_debuginfo_opts %{?_find_debuginfo_opts} -p '.*%%{_libdir}/libperf.so(\.debug)?|XXX' -o libperf-debuginfo.list} # with_libperf %endif @@ -3561,6 +3574,7 @@ fi\ %{_docdir}/libperf/html/libperf-counting.html %{_docdir}/libperf/html/libperf-sampling.html +%files -f libperf-debuginfo.list -n libperf-debuginfo # with_libperf %endif -- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2950 -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[OS-BUILD PATCH] Add libperf-debuginfo subpackage
From: Justin M. Forbes Add libperf-debuginfo subpackage When libperf was added, I failed to add the libperf-debuginfo subpackage. This leaves libperf debuginfo in kernel-debuginfo-common which is installonly, and creaes file conflicts. Add the debuginfo subpackage so things are where they belong. Signed-off-by: Justin M. Forbes diff --git a/redhat/kernel.spec.template b/redhat/kernel.spec.template index blahblah..blahblah 100644 --- a/redhat/kernel.spec.template +++ b/redhat/kernel.spec.template @@ -1137,6 +1137,19 @@ Summary: Developement files for the perf library from kernel source This package includes libraries and header files needed for development of applications which use perf library from kernel source. +%package -n libperf-debuginfo +Summary: Debug information for package libperf +Group: Development/Debug +Requires: %{name}-debuginfo-common-%{_target_cpu} = %{version}-%{release} +AutoReqProv: no +%description -n libperf-debuginfo +This package provides debug information for the libperf package. + +# Note that this pattern only works right to match the .build-id +# symlinks because of the trailing nonmatching alternation and +# the leading .*, because of find-debuginfo.sh's buggy handling +# of matching the pattern against the symlinks file. +%{expand:%%global _find_debuginfo_opts %{?_find_debuginfo_opts} -p '.*%%{_libdir}/libperf.so(\.debug)?|XXX' -o libperf-debuginfo.list} # with_libperf %endif @@ -3561,6 +3574,7 @@ fi\ %{_docdir}/libperf/html/libperf-counting.html %{_docdir}/libperf/html/libperf-sampling.html +%files -f libperf-debuginfo.list -n libperf-debuginfo # with_libperf %endif -- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2950 -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCH] [redhat] configs: Disable CONFIG_XFS_SUPPORT_V4
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2916#note_1781439931 Will do. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCH] [redhat] configs: Disable CONFIG_XFS_SUPPORT_V4
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2916#note_1781319143 As it turns out, we have already had a complaint from rawhide. I am going to turn this back on For Fedora. I will see about getting a blog post out so that we can say Fedora 40 will be the last version to support V4, and make a note to turn it off once we hit what will be the first rebase after Fedora 40 is EOL. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCH 0/2] tools/rtla: Fix Makefile compiler options for clang
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2918#note_1772764818 This is upstream now -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[OS-BUILD PATCH] Flip secureboot signature order
From: Justin M. Forbes Flip secureboot signature order In preparation for dropping down to the single signature, we need to flip the signature order. Once a new shim is shipped, we can then drop down to a single signature. Signed-off-by: Justin M. Forbes diff --git a/redhat/kernel.spec.template b/redhat/kernel.spec.template index blahblah..blahblah 100644 --- a/redhat/kernel.spec.template +++ b/redhat/kernel.spec.template @@ -825,13 +825,13 @@ Source13: redhatsecureboot301.cer Source14: secureboot_s390.cer Source15: secureboot_ppc.cer -%define secureboot_ca_1 %{SOURCE10} -%define secureboot_ca_0 %{SOURCE11} +%define secureboot_ca_0 %{SOURCE10} +%define secureboot_ca_1 %{SOURCE11} %ifarch x86_64 aarch64 -%define secureboot_key_1 %{SOURCE12} -%define pesign_name_1 redhatsecureboot501 -%define secureboot_key_0 %{SOURCE13} -%define pesign_name_0 redhatsecureboot301 +%define secureboot_key_0 %{SOURCE12} +%define pesign_name_0 redhatsecureboot501 +%define secureboot_key_1 %{SOURCE13} +%define pesign_name_1 redhatsecureboot301 %endif %ifarch s390x %define secureboot_key_0 %{SOURCE14} @@ -850,12 +850,12 @@ Source11: redhatsecurebootca2.cer Source12: redhatsecureboot401.cer Source13: redhatsecureboot003.cer -%define secureboot_ca_1 %{SOURCE10} -%define secureboot_ca_0 %{SOURCE11} -%define secureboot_key_1 %{SOURCE12} -%define pesign_name_1 redhatsecureboot401 -%define secureboot_key_0 %{SOURCE13} -%define pesign_name_0 redhatsecureboot003 +%define secureboot_ca_0 %{SOURCE10} +%define secureboot_ca_1 %{SOURCE11} +%define secureboot_key_0 %{SOURCE12} +%define pesign_name_0 redhatsecureboot401 +%define secureboot_key_1 %{SOURCE13} +%define pesign_name_1 redhatsecureboot003 # released_kernel %endif -- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2941 -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCH] DO NOT MERGE: Revert Fix cursor planes with virtualized drivers series
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2931#note_1767836165 Turns out this code just exposed a mutter bug, the fix was there. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCH] DO NOT MERGE: Revert Fix cursor planes with virtualized drivers series
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2931#note_1762987981 /block javierm is looking into a proper fix. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[OS-BUILD PATCH] DO NOT MERGE: Revert Fix cursor planes with virtualized drivers series
From: Justin M. Forbes DO NOT MERGE: Revert Fix cursor planes with virtualized drivers series This is a temporary revert while things are worked out upstream. This series breaks gnome on virtio-vga, which means it also breaks openqa, and keeps kernel updates gated out of rawhide. Signed-off-by: Justin M. Forbes diff --git a/Documentation/gpu/drm-kms.rst b/Documentation/gpu/drm-kms.rst index blahblah..blahblah 100644 --- a/Documentation/gpu/drm-kms.rst +++ b/Documentation/gpu/drm-kms.rst @@ -581,12 +581,6 @@ Variable Refresh Properties .. kernel-doc:: drivers/gpu/drm/drm_connector.c :doc: Variable refresh properties -Cursor Hotspot Properties - -.. kernel-doc:: drivers/gpu/drm/drm_plane.c - :doc: hotspot properties - Existing KMS Properties --- diff --git a/drivers/gpu/drm/drm_atomic_state_helper.c b/drivers/gpu/drm/drm_atomic_state_helper.c index blahblah..blahblah 100644 --- a/drivers/gpu/drm/drm_atomic_state_helper.c +++ b/drivers/gpu/drm/drm_atomic_state_helper.c @@ -275,20 +275,6 @@ void __drm_atomic_helper_plane_state_reset(struct drm_plane_state *plane_state, plane_state->normalized_zpos = val; } } - - if (plane->hotspot_x_property) { - if (!drm_object_property_get_default_value(>base, - plane->hotspot_x_property, - )) - plane_state->hotspot_x = val; - } - - if (plane->hotspot_y_property) { - if (!drm_object_property_get_default_value(>base, - plane->hotspot_y_property, - )) - plane_state->hotspot_y = val; - } } EXPORT_SYMBOL(__drm_atomic_helper_plane_state_reset); diff --git a/drivers/gpu/drm/drm_atomic_uapi.c b/drivers/gpu/drm/drm_atomic_uapi.c index blahblah..blahblah 100644 --- a/drivers/gpu/drm/drm_atomic_uapi.c +++ b/drivers/gpu/drm/drm_atomic_uapi.c @@ -551,22 +551,6 @@ static int drm_atomic_plane_set_property(struct drm_plane *plane, } else if (plane->funcs->atomic_set_property) { return plane->funcs->atomic_set_property(plane, state, property, val); - } else if (property == plane->hotspot_x_property) { - if (plane->type != DRM_PLANE_TYPE_CURSOR) { - drm_dbg_atomic(plane->dev, - "[PLANE:%d:%s] is not a cursor plane: 0x%llx\n", - plane->base.id, plane->name, val); - return -EINVAL; - } - state->hotspot_x = val; - } else if (property == plane->hotspot_y_property) { - if (plane->type != DRM_PLANE_TYPE_CURSOR) { - drm_dbg_atomic(plane->dev, - "[PLANE:%d:%s] is not a cursor plane: 0x%llx\n", - plane->base.id, plane->name, val); - return -EINVAL; - } - state->hotspot_y = val; } else { drm_dbg_atomic(plane->dev, "[PLANE:%d:%s] unknown property [PROP:%d:%s]\n", @@ -627,10 +611,6 @@ drm_atomic_plane_get_property(struct drm_plane *plane, *val = state->scaling_filter; } else if (plane->funcs->atomic_get_property) { return plane->funcs->atomic_get_property(plane, state, property, val); - } else if (property == plane->hotspot_x_property) { - *val = state->hotspot_x; - } else if (property == plane->hotspot_y_property) { - *val = state->hotspot_y; } else { drm_dbg_atomic(dev, "[PLANE:%d:%s] unknown property [PROP:%d:%s]\n", diff --git a/drivers/gpu/drm/drm_ioctl.c b/drivers/gpu/drm/drm_ioctl.c index blahblah..blahblah 100644 --- a/drivers/gpu/drm/drm_ioctl.c +++ b/drivers/gpu/drm/drm_ioctl.c @@ -364,15 +364,6 @@ drm_setclientcap(struct drm_device *dev, void *data, struct drm_file *file_priv) return -EINVAL; file_priv->writeback_connectors = req->value; break; - case DRM_CLIENT_CAP_CURSOR_PLANE_HOTSPOT: - if (!drm_core_check_feature(dev, DRIVER_CURSOR_HOTSPOT)) - return -EOPNOTSUPP; - if (!file_priv->atomic) - return -EINVAL; - if (req->value > 1) - return -EINVAL; - file_priv->supports_virtualized_cursor_plane = req->value; - break; default: return -EINVAL; } diff --git a/drivers/gpu/drm/drm_plane.c b/drivers/gpu/drm/drm_plane.c index blahblah..blahblah 100644 ---
[OS-BUILD PATCH] Turn on SECURITY_DMESG_RESTRICT
From: Justin M. Forbes Turn on SECURITY_DMESG_RESTRICT It was requested by ProdSec that we enable SECURITY_DMESG_RESTRICT as this makes several security bugs more difficult to exploit. It should be noted that this just controls the default setting of kernel.dmesg_restrict sysctl and thus can be always set back to 0 at runtime. Users in the wheel group also have access to journalctl -k or sudo for dmesg access without giving it to every user on the system. Signed-off-by: Justin M. Forbes diff --git a/redhat/configs/common/generic/CONFIG_SECURITY_DMESG_RESTRICT b/redhat/configs/common/generic/CONFIG_SECURITY_DMESG_RESTRICT index blahblah..blahblah 100644 --- a/redhat/configs/common/generic/CONFIG_SECURITY_DMESG_RESTRICT +++ b/redhat/configs/common/generic/CONFIG_SECURITY_DMESG_RESTRICT @@ -1 +1 @@ -# CONFIG_SECURITY_DMESG_RESTRICT is not set +CONFIG_SECURITY_DMESG_RESTRICT=y diff --git a/redhat/configs/fedora/generic/CONFIG_SECURITY_DMESG_RESTRICT b/redhat/configs/fedora/generic/CONFIG_SECURITY_DMESG_RESTRICT deleted file mode 100644 index blahblah..blahblah 0 --- a/redhat/configs/fedora/generic/CONFIG_SECURITY_DMESG_RESTRICT +++ /dev/null @@ -1 +0,0 @@ -CONFIG_SECURITY_DMESG_RESTRICT=y -- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2930 -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[OS-BUILD PATCHv4 0/0] Add libperf packages and build kernel tools for Fedora
From: Justin M. Forbes on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2907 NOTE: Truncated patchset since committer email 'scwea...@redhat.com' does not match the submitter's GitLab public email address 'jfor...@fedoraproject.org'. When kernel-tools was split out to a separate package in Fedora, it was due to several factors. Most of those issues have been mitigated in other ways, and there are advantages to building tools with the kernel build. Let's turn on tools for Fedora. To do so, we need to add the libperf packages, but this enables them for Fedora only. It is worth noting that the Fedora package for bpftool will retain the upstream kernel versioning. This is because the bpftool versioning scheme is incompatible with the stable Fedora process. --- redhat/kernel.spec.template | 78 ++-- 1 files changed, 74 insertions(+), 4 deletions(-) -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[OS-BUILD PATCHv3 4/5] Remove separate license tag for libperf
From: Justin M. Forbes Remove separate license tag for libperf Signed-off-by: Justin M. Forbes diff --git a/redhat/kernel.spec.template b/redhat/kernel.spec.template index blahblah..blahblah 100644 --- a/redhat/kernel.spec.template +++ b/redhat/kernel.spec.template @@ -1135,13 +1135,11 @@ This package provides debug information for the perf python bindings. %if %{with_libperf} %package -n libperf Summary: The perf library from kernel source -License: GPL-2.0-only AND (LGPL-2.1-only OR BSD-2-Clause) %description -n libperf This package contains the kernel source perf library. %package -n libperf-devel Summary: Developement files for the perf library from kernel source -License: GPL-2.0-only AND (LGPL-2.1-only OR BSD-2-Clause) %description -n libperf-devel This package includes libraries and header files needed for development of applications which use perf library from kernel source. -- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2907 -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[OS-BUILD PATCHv3 3/5] Don't use upstream bpftool version for Fedora package
From: Justin M. Forbes Don't use upstream bpftool version for Fedora package Upstream bpftool went with their own versioning. While this works in rawhide and RHEL where release is bumped wth every build, it does not work with Fedora. Because bpftool sublevel is not bumped with stable updates, and we don't update the release in Fedora when the version has changed, we ended up with a failure because the bpftool subpackage version already exists. For Fedora, we will stick with the kernel versioning for the package. bpftool -V still displays the upstream bpftool version number. Signed-off-by: Justin M. Forbes diff --git a/redhat/kernel.spec.template b/redhat/kernel.spec.template index blahblah..blahblah 100644 --- a/redhat/kernel.spec.template +++ b/redhat/kernel.spec.template @@ -1227,7 +1227,14 @@ analysing the logical and timing behavior of Linux. %if %{with_bpftool} +%if 0%{?fedora} +# bpftoolverion doesn't bump with stable updates so let's stick with +# upstream kernel version for the package name. We still get correct +# output with bpftool -V. +%define bpftoolversion %specrpmversion +%else %define bpftoolversion %%SPECBPFTOOLVERSION%% +%endif %package -n bpftool Summary: Inspection and simple manipulation of eBPF programs and maps -- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2907 -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[OS-BUILD PATCHv3 1/5] add libperf packages and enable perf, libperf, tools and bpftool packages
From: Thorsten Leemhuis add libperf packages and enable perf, libperf, tools and bpftool packages Signed-off-by: Thorsten Leemhuis diff --git a/redhat/kernel.spec.template b/redhat/kernel.spec.template index blahblah..blahblah 100644 --- a/redhat/kernel.spec.template +++ b/redhat/kernel.spec.template @@ -224,6 +224,8 @@ Summary: The Linux kernel %define with_cross_headers %{?_without_cross_headers: 0} %{?!_without_cross_headers: 1} # perf %define with_perf %{?_without_perf: 0} %{?!_without_perf: 1} +# libperf +%define with_libperf %{?_without_libperf: 0} %{?!_without_libperf: 1} # tools %define with_tools %{?_without_tools: 0} %{?!_without_tools: 1} # bpf tool @@ -300,9 +302,10 @@ Summary: The Linux kernel # no stablelist %define with_kernel_abi_stablelists 0 # Fedora builds these separately -%define with_perf 0 -%define with_tools 0 -%define with_bpftool 0 +%define with_perf 1 +%define with_libperf 1 +%define with_tools 1 +%define with_bpftool 1 # No realtime fedora variants %define with_realtime 0 %define with_arm64_64k 0 @@ -388,6 +391,7 @@ Summary: The Linux kernel %define with_realtime 0 %define with_vdso_install 0 %define with_perf 0 +%define with_libperf 0 %define with_tools 0 %define with_bpftool 0 %define with_kernel_abi_stablelists 0 @@ -402,6 +406,7 @@ Summary: The Linux kernel %define with_base 0 %define with_vdso_install 0 %define with_perf 0 +%define with_libperf 0 %define with_tools 0 %define with_bpftool 0 %define with_kernel_abi_stablelists 0 @@ -417,6 +422,7 @@ Summary: The Linux kernel %define with_debuginfo 0 %define with_vdso_install 0 %define with_perf 0 +%define with_libperf 0 %define with_tools 0 %define with_bpftool 0 %define with_kernel_abi_stablelists 0 @@ -480,6 +486,7 @@ Summary: The Linux kernel %define with_cross_headers 0 %define with_tools 0 %define with_perf 0 +%define with_libperf 0 %define with_bpftool 0 %define with_selftests 0 %define with_debug 0 @@ -572,6 +579,7 @@ Summary: The Linux kernel %define with_debuginfo 0 %define with_perf 0 +%define with_libperf 0 %define with_tools 0 %define with_bpftool 0 %define with_selftests 0 @@ -1124,6 +1132,23 @@ This package provides debug information for the perf python bindings. # with_perf %endif +%if %{with_libperf} +%package -n libperf +Summary: The perf library from kernel source +License: GPL-2.0-only AND (LGPL-2.1-only OR BSD-2-Clause) +%description -n libperf +This package contains the kernel source perf library. + +%package -n libperf-devel +Summary: Developement files for the perf library from kernel source +License: GPL-2.0-only AND (LGPL-2.1-only OR BSD-2-Clause) +%description -n libperf-devel +This package includes libraries and header files needed for development +of applications which use perf library from kernel source. + +# with_libperf +%endif + %if %{with_tools} %package -n %{package_name}-tools Summary: Assortment of tools for the Linux kernel @@ -2728,6 +2753,12 @@ chmod +x tools/perf/check-headers.sh %{perf_make} DESTDIR=$RPM_BUILD_ROOT all %endif +%if %{with_libperf} +%global libperf_make \ + %{__make} %{?make_opts} EXTRA_CFLAGS="${RPM_OPT_FLAGS}" LDFLAGS="%{__global_ldflags}" %{?cross_opts} -C tools/lib/perf V=1 +%{libperf_make} DESTDIR=$RPM_BUILD_ROOT +%endif + %global tools_make \ CFLAGS="${RPM_OPT_FLAGS}" LDFLAGS="%{__global_ldflags}" %{make} %{?make_opts} @@ -3009,6 +3040,10 @@ mkdir -p %{buildroot}/%{_mandir}/man1 rm -rf %{buildroot}%{_libdir}/traceevent %endif +%if %{with_libperf} +%{libperf_make} DESTDIR=%{buildroot} prefix=%{_prefix} libdir=%{_libdir} install install_headers +%endif + %if %{with_tools} %ifarch %{cpupowerarchs} %{make} -C tools/power/cpupower DESTDIR=$RPM_BUILD_ROOT libdir=%{_libdir} mandir=%{_mandir} CPUFREQ_BENCH=false install @@ -3494,6 +3529,37 @@ fi\ # with_perf %endif +%if %{with_libperf} +%files -n libperf +%{_libdir}/libperf.so.0 +%{_libdir}/libperf.so.0.0.1 + +%files -n libperf-devel +%{_libdir}/libperf.so +%{_libdir}/pkgconfig/libperf.pc +%{_includedir}/internal/*.h +%{_includedir}/perf/bpf_perf.h +%{_includedir}/perf/core.h +%{_includedir}/perf/cpumap.h +%{_includedir}/perf/perf_dlfilter.h +%{_includedir}/perf/event.h +%{_includedir}/perf/evlist.h +%{_includedir}/perf/evsel.h +%{_includedir}/perf/mmap.h +%{_includedir}/perf/threadmap.h +%{_mandir}/man3/libperf.3.gz +%{_mandir}/man7/libperf-counting.7.gz +%{_mandir}/man7/libperf-sampling.7.gz +%{_docdir}/libperf/examples/sampling.c +%{_docdir}/libperf/examples/counting.c +%{_docdir}/libperf/html/libperf.html +%{_docdir}/libperf/html/libperf-counting.html +%{_docdir}/libperf/html/libperf-sampling.html + +# with_libperf +%endif + + %if %{with_tools} %ifnarch %{cpupowerarchs} %files -n %{package_name}-tools @@ -3543,6 +3609,8 @@ fi\ %files -n %{package_name}-tools-libs-devel %{_libdir}/libcpupower.so %{_includedir}/cpufreq.h +%{_includedir}/cpuidle.h +%{_includedir}/powercap.h %endif %files -n
[OS-BUILD PATCHv3 5/5] Remove defines forcing tools on, they override cmdline
From: Justin M. Forbes Remove defines forcing tools on, they override cmdline Signed-off-by: Justin M. Forbes diff --git a/redhat/kernel.spec.template b/redhat/kernel.spec.template index blahblah..blahblah 100644 --- a/redhat/kernel.spec.template +++ b/redhat/kernel.spec.template @@ -301,11 +301,6 @@ Summary: The Linux kernel %define with_ipaclones 0 # no stablelist %define with_kernel_abi_stablelists 0 -# Fedora builds these separately -%define with_perf 1 -%define with_libperf 1 -%define with_tools 1 -%define with_bpftool 1 # No realtime fedora variants %define with_realtime 0 %define with_arm64_64k 0 -- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2907 -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[OS-BUILD PATCHv3 2/5] Don't ship libperf.a in libperf-devel
From: Justin M. Forbes Don't ship libperf.a in libperf-devel Signed-off-by: Justin M. Forbes diff --git a/redhat/kernel.spec.template b/redhat/kernel.spec.template index blahblah..blahblah 100644 --- a/redhat/kernel.spec.template +++ b/redhat/kernel.spec.template @@ -3042,6 +3042,8 @@ rm -rf %{buildroot}%{_libdir}/traceevent %if %{with_libperf} %{libperf_make} DESTDIR=%{buildroot} prefix=%{_prefix} libdir=%{_libdir} install install_headers +# This is installed on some arches and we don't want to ship it +rm -rf %{buildroot}%{_libdir}/libperf.a %endif %if %{with_tools} -- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2907 -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[OS-BUILD PATCHv3 0/5] Add libperf packages and build kernel tools for Fedora
From: Justin M. Forbes on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2907 When kernel-tools was split out to a separate package in Fedora, it was due to several factors. Most of those issues have been mitigated in other ways, and there are advantages to building tools with the kernel build. Let's turn on tools for Fedora. To do so, we need to add the libperf packages, but this enables them for Fedora only. It is worth noting that the Fedora package for bpftool will retain the upstream kernel versioning. This is because the bpftool versioning scheme is incompatible with the stable Fedora process. --- redhat/kernel.spec.template | 78 ++-- 1 files changed, 74 insertions(+), 4 deletions(-) -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCHv2 0/4] Add libperf packages and build kernel tools for Fedora
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2907#note_1749975554 I believe you are correct. Will fix it up. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCHv2 0/4] Add libperf packages and build kernel tools for Fedora
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2907#note_1749916656 I do not expect that it would hit Makefile.perf for any reason. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCHv2 0/4] Add libperf packages and build kernel tools for Fedora
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2907#note_1749873338 As I said above, this particular MR is include in releases because I need koji building these packages. Since pipelines now run on include in releases, this MR should be impacting others too. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCHv2 0/4] Add libperf packages and build kernel tools for Fedora
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2907#note_1749868492 Why would we remove arches which should work fine? If we can build tools for ELN with the native_tools bit, we should be able to do the same for rawhide, no? -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCHv2 0/4] Add libperf packages and build kernel tools for Fedora
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2907#note_1749862624 This MR is "include in release" so it is being tested in all pipelines. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCHv8 0/3] redhat/Makefile: fix and clean up some of the logic
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2892#note_1746082497 https://gitlab.com/redhat/red-hat-ci-tools/kernel/cki-internal-pipelines/cki- trusted-contributors/-/jobs/6016814624 is one example. Basically the self-test script creates the data files to test. With this change the script calls 'make setup-source' which now depends on 'make clean-sources' which deletes anything created (the data files to test). -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCHv8 0/3] redhat/Makefile: fix and clean up some of the logic
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2892#note_1745969503 This had to be reverted. It turns out that fixing this race put a new race in which caused CKI to fail more often than not. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCHv2 0/4] Add libperf packages and build kernel tools for Fedora
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2907#note_1745521167 Indeed they are, the turned off are for other places where tools are turned off. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCHv2 0/4] Add libperf packages and build kernel tools for Fedora
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2907#note_1745476990 I have looked at them, and they are off for eln. As you can see from the ELN build linked above, we do not build libperf on ELN. I don't think that CKI is actually failing on libperf here for ELN. It is failing on cross compile issues. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCHv2 0/4] Add libperf packages and build kernel tools for Fedora
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2907#note_1745290922 @scweaver It may be, but when I emailed acme about it, he said it wasn't ready to be turned on. I am guessing it is moving too quickly and RHEL 10 will be enabled with a specific ABI? -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCHv2 0/4] Add libperf packages and build kernel tools for Fedora
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2907#note_1745288040 I suppose so. I am guessing this is because we don't add --without libperf which is a new option now. Realistically libperf is turned off for ELN now though so, not sure why it is being built. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCHv2 0/4] Add libperf packages and build kernel tools for Fedora
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2907#note_1745279374 When I say "turn on tools" I mean simply enabling those subpackages in Fedora. Most (excluding libperf) have always been enabled in ELN, but Fedora used a separate package to build them. Fedora is getting rid of that separate package and wishes to build the tools subpackages as part of kernel now. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCHv2 0/4] Add libperf packages and build kernel tools for Fedora
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2907#note_1745275743 I do not. with_libperf is only set for Fedora at the moment. If ELN/Rawhide want to turn it on, the would need to do so with another MR. This can be seen in the resulting builds from koji where ELN does not build libperf packages, but Fedora does. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCHv2 0/4] Add libperf packages and build kernel tools for Fedora
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2907#note_1745260387 I meant actual builds in koji. https://koji.fedoraproject.org/koji/buildinfo?buildID=2378280 for Rawhide and https://koji.fedoraproject.org/koji/buildinfo?buildID=2378291 for ELN. As can be seen there, this MR does exactly what it aims to do. No build failures. CKI is the issue here, not this MR. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCHv2 0/4] Add libperf packages and build kernel tools for Fedora
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2907#note_1745226469 There are, which makes no sense, as this MR is "include in release" and neither Fedora or ELN builds failed yesterday with this MR included. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCHv2 0/4] Add libperf packages and build kernel tools for Fedora
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2907#note_1745186783 It will be needed for all other MRs after this is merged, it just was not needed before this MR. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCHv2 0/4] Add libperf packages and build kernel tools for Fedora
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2907#note_1741124750 @mh21_rh It appears we might need to add --without libperf to the cki builds for this MR. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCHv2 0/4] Add libperf packages and build kernel tools for Fedora
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2907#note_1740885976 Possibly, but to be honest the versioning is not exactly interesting either. As you can see from the commit 9910a74d6ebf6 there isn't a whole lot of reason for anyone to care about the bpftool version number. It is pulled from the kernel tree, but with a dynamically linked libbpf we may well have a completely incorrect version number. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[OS-BUILD PATCH] Add scaffolding to build the kernel-headers package for Fedora
From: Justin M. Forbes Add scaffolding to build the kernel-headers package for Fedora For years, the scripts to build the kernel headers package have been sitting on maintainers desktops. Let's get those into kernel-ark. I have been using these to create the Fedora kernel-headers dist-git for a while now. Signed-off-by: Justin M. Forbes diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -845,6 +845,22 @@ ifeq ("$(RHDISTGIT_BRANCH)", "") endif $(REDHAT)/scripts/rh-dist-git.sh +dist-headers-srpm: + @scripts/create_headers_tarball.sh + @cp $(REDHAT)/kernel-headers.spec.template $(SOURCES)/kernel-headers.spec + @$(REDHAT)/scripts/genspec/headerspec.sh + @cp $(SOURCES)/kernel-headers.spec $(SOURCES)/../SPECS/ + $(RPMBUILD) --define "_sourcedir $(SOURCES)" --define "_builddir $(RPM)/BUILD" --define "_srcrpmdir $(RPM)/SRPMS" --define "_rpmdir $(RPM)/RPMS" --define "_specdir $(RPM)/SPECS" --define "dist $(DIST)" --nodeps -bs $(RPM)/SOURCES/kernel-headers.spec + +dist-git-headers: dist-headers-srpm +ifeq ("$(RHDISTGIT_BRANCH)", "") + $(error RHDISTGIT_BRANCH unset) +endif + SPECPACKAGE_NAME=kernel-headers SRPM=$(SRPMS)/kernel-headers-$(BASEVERSION)$(DIST).src.rpm $(REDHAT)/scripts/rh-headers-dist-git.sh + +dist-git-headers-test: export RH_DIST_GIT_TEST="1" +dist-git-headers-test: dist-git-headers + dist-rtg: dist-release @$(MAKE) dist-release-tag @$(MAKE) dist-git diff --git a/redhat/kernel-headers.spec.template b/redhat/kernel-headers.spec.template new file mode 100644 index blahblah..blahblah 100644 --- /dev/null +++ b/redhat/kernel-headers.spec.template @@ -0,0 +1,112 @@ +# For a stable, released kernel, released_kernel should be 1. For rawhide +# and/or a kernel built from an rc or git snapshot, released_kernel should +# be 0. +%global released_kernel %%SPECRELEASED_KERNEL%% + +%%SPECBUILDID%% +%define specversion %%SPECVERSION%% +%define tarfile_release %%SPECTARFILE_RELEASE%% +# This is needed to do merge window version magic +# This allows pkg_release to have configurable %%{?dist} tag +%define specrelease %%SPECRELEASE%% + +# This package doesn't contain any binary, thus no debuginfo package is needed +%global debug_package %{nil} + +Name: kernel-headers +Summary: Header files for the Linux kernel for use by glibc +License: ((GPL-2.0-only WITH Linux-syscall-note) OR BSD-2-Clause) AND ((GPL-2.0-only WITH Linux-syscall-note) OR BSD-3-Clause) AND ((GPL-2.0-only WITH Linux-syscall-note) OR CDDL-1.0) AND ((GPL-2.0-only WITH Linux-syscall-note) OR Linux-OpenIB) AND ((GPL-2.0-only WITH Linux-syscall-note) OR MIT) AND ((GPL-2.0-or-later WITH Linux-syscall-note) OR BSD-3-Clause) AND ((GPL-2.0-or-later WITH Linux-syscall-note) OR MIT) AND BSD-3-Clause AND (GPL-1.0-or-later WITH Linux-syscall-note) AND GPL-2.0-only AND (GPL-2.0-only WITH Linux-syscall-note) AND (GPL-2.0-or-later WITH Linux-syscall-note) AND (LGPL-2.0-or-later WITH Linux-syscall-note) AND (LGPL-2.1-only WITH Linux-syscall-note) AND (LGPL-2.1-or-later WITH Linux-syscall-note) AND MIT +URL: http://www.kernel.org/ +Version: %{specversion} +Release: %{specrelease} +# This is a tarball with headers from the kernel, which should be created +# using create_headers_tarball.sh provided in the kernel source package. +# To create the tarball, you should go into a prepared/patched kernel sources +# directory, or git kernel source repository, and do eg.: +# For a RHEL package: (...)/create_headers_tarball.sh -m RHEL_RELEASE +# For a Fedora package: kernel/scripts/create_headers_tarball.sh -r +Source0: kernel-headers-%{tarfile_release}.tar.xz +Obsoletes: glibc-kernheaders < 3.0-46 +Provides: glibc-kernheaders = 3.0-46 +%if "0%{?variant}" +Obsoletes: kernel-headers < %{specversion}-%{specrelease} +Provides: kernel-headers = %{specversion}-%{specrelease} +%endif + +%description +Kernel-headers includes the C header files that specify the interface +between the Linux kernel and userspace libraries and programs. The +header files define structures and constants that are needed for +building most standard programs and are also needed for rebuilding the +glibc package. + +%package -n kernel-cross-headers +Summary: Header files for the Linux kernel for use by cross-glibc + +%description -n kernel-cross-headers +Kernel-cross-headers includes the C header files that specify the interface +between the Linux kernel and userspace libraries and programs. The +header files define structures and constants that are needed for +building most standard programs and are also needed for rebuilding the +cross-glibc package. + +%prep +%setup -q -c + +%build + +%install +# List of architectures we support and want to copy their headers +ARCH_LIST="arm arm64 powerpc riscv s390 x86" + +ARCH=%_target_cpu +case $ARCH in + armv7hl) + ARCH=arm + ;; + aarch64) + ARCH=arm64 +
[OS-BUILD PATCHv2 4/4] Remove separate license tag for libperf
From: Justin M. Forbes Remove separate license tag for libperf Signed-off-by: Justin M. Forbes diff --git a/redhat/kernel.spec.template b/redhat/kernel.spec.template index blahblah..blahblah 100644 --- a/redhat/kernel.spec.template +++ b/redhat/kernel.spec.template @@ -1135,13 +1135,11 @@ This package provides debug information for the perf python bindings. %if %{with_libperf} %package -n libperf Summary: The perf library from kernel source -License: GPL-2.0-only AND (LGPL-2.1-only OR BSD-2-Clause) %description -n libperf This package contains the kernel source perf library. %package -n libperf-devel Summary: Developement files for the perf library from kernel source -License: GPL-2.0-only AND (LGPL-2.1-only OR BSD-2-Clause) %description -n libperf-devel This package includes libraries and header files needed for development of applications which use perf library from kernel source. -- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2907 -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[OS-BUILD PATCHv2 3/4] Don't use upstream bpftool version for Fedora package
From: Justin M. Forbes Don't use upstream bpftool version for Fedora package Upstream bpftool went with their own versioning. While this works in rawhide and RHEL where release is bumped wth every build, it does not work with Fedora. Because bpftool sublevel is not bumped with stable updates, and we don't update the release in Fedora when the version has changed, we ended up with a failure because the bpftool subpackage version already exists. For Fedora, we will stick with the kernel versioning for the package. bpftool -V still displays the upstream bpftool version number. Signed-off-by: Justin M. Forbes diff --git a/redhat/kernel.spec.template b/redhat/kernel.spec.template index blahblah..blahblah 100644 --- a/redhat/kernel.spec.template +++ b/redhat/kernel.spec.template @@ -1227,7 +1227,14 @@ analysing the logical and timing behavior of Linux. %if %{with_bpftool} +%if 0%{?fedora} +# bpftoolverion doesn't bump with stable updates so let's stick with +# upstream kernel version for the package name. We still get correct +# output with bpftool -V. +%define bpftoolversion %specrpmversion +%else %define bpftoolversion %%SPECBPFTOOLVERSION%% +%endif %package -n bpftool Summary: Inspection and simple manipulation of eBPF programs and maps -- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2907 -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[OS-BUILD PATCHv2 1/4] add libperf packages and enable perf, libperf, tools and bpftool packages
From: Thorsten Leemhuis add libperf packages and enable perf, libperf, tools and bpftool packages Signed-off-by: Thorsten Leemhuis diff --git a/redhat/kernel.spec.template b/redhat/kernel.spec.template index blahblah..blahblah 100644 --- a/redhat/kernel.spec.template +++ b/redhat/kernel.spec.template @@ -224,6 +224,8 @@ Summary: The Linux kernel %define with_cross_headers %{?_without_cross_headers: 0} %{?!_without_cross_headers: 1} # perf %define with_perf %{?_without_perf: 0} %{?!_without_perf: 1} +# libperf +%define with_libperf %{?_without_libperf: 0} %{?!_without_libperf: 1} # tools %define with_tools %{?_without_tools: 0} %{?!_without_tools: 1} # bpf tool @@ -300,9 +302,10 @@ Summary: The Linux kernel # no stablelist %define with_kernel_abi_stablelists 0 # Fedora builds these separately -%define with_perf 0 -%define with_tools 0 -%define with_bpftool 0 +%define with_perf 1 +%define with_libperf 1 +%define with_tools 1 +%define with_bpftool 1 # No realtime fedora variants %define with_realtime 0 %define with_arm64_64k 0 @@ -388,6 +391,7 @@ Summary: The Linux kernel %define with_realtime 0 %define with_vdso_install 0 %define with_perf 0 +%define with_libperf 0 %define with_tools 0 %define with_bpftool 0 %define with_kernel_abi_stablelists 0 @@ -402,6 +406,7 @@ Summary: The Linux kernel %define with_base 0 %define with_vdso_install 0 %define with_perf 0 +%define with_libperf 0 %define with_tools 0 %define with_bpftool 0 %define with_kernel_abi_stablelists 0 @@ -417,6 +422,7 @@ Summary: The Linux kernel %define with_debuginfo 0 %define with_vdso_install 0 %define with_perf 0 +%define with_libperf 0 %define with_tools 0 %define with_bpftool 0 %define with_kernel_abi_stablelists 0 @@ -480,6 +486,7 @@ Summary: The Linux kernel %define with_cross_headers 0 %define with_tools 0 %define with_perf 0 +%define with_libperf 0 %define with_bpftool 0 %define with_selftests 0 %define with_debug 0 @@ -572,6 +579,7 @@ Summary: The Linux kernel %define with_debuginfo 0 %define with_perf 0 +%define with_libperf 0 %define with_tools 0 %define with_bpftool 0 %define with_selftests 0 @@ -1124,6 +1132,23 @@ This package provides debug information for the perf python bindings. # with_perf %endif +%if %{with_libperf} +%package -n libperf +Summary: The perf library from kernel source +License: GPL-2.0-only AND (LGPL-2.1-only OR BSD-2-Clause) +%description -n libperf +This package contains the kernel source perf library. + +%package -n libperf-devel +Summary: Developement files for the perf library from kernel source +License: GPL-2.0-only AND (LGPL-2.1-only OR BSD-2-Clause) +%description -n libperf-devel +This package includes libraries and header files needed for development +of applications which use perf library from kernel source. + +# with_libperf +%endif + %if %{with_tools} %package -n %{package_name}-tools Summary: Assortment of tools for the Linux kernel @@ -2728,6 +2753,12 @@ chmod +x tools/perf/check-headers.sh %{perf_make} DESTDIR=$RPM_BUILD_ROOT all %endif +%if %{with_libperf} +%global libperf_make \ + %{__make} %{?make_opts} EXTRA_CFLAGS="${RPM_OPT_FLAGS}" LDFLAGS="%{__global_ldflags}" %{?cross_opts} -C tools/lib/perf V=1 +%{libperf_make} DESTDIR=$RPM_BUILD_ROOT +%endif + %global tools_make \ CFLAGS="${RPM_OPT_FLAGS}" LDFLAGS="%{__global_ldflags}" %{make} %{?make_opts} @@ -3009,6 +3040,10 @@ mkdir -p %{buildroot}/%{_mandir}/man1 rm -rf %{buildroot}%{_libdir}/traceevent %endif +%if %{with_libperf} +%{libperf_make} DESTDIR=%{buildroot} prefix=%{_prefix} libdir=%{_libdir} install install_headers +%endif + %if %{with_tools} %ifarch %{cpupowerarchs} %{make} -C tools/power/cpupower DESTDIR=$RPM_BUILD_ROOT libdir=%{_libdir} mandir=%{_mandir} CPUFREQ_BENCH=false install @@ -3494,6 +3529,37 @@ fi\ # with_perf %endif +%if %{with_libperf} +%files -n libperf +%{_libdir}/libperf.so.0 +%{_libdir}/libperf.so.0.0.1 + +%files -n libperf-devel +%{_libdir}/libperf.so +%{_libdir}/pkgconfig/libperf.pc +%{_includedir}/internal/*.h +%{_includedir}/perf/bpf_perf.h +%{_includedir}/perf/core.h +%{_includedir}/perf/cpumap.h +%{_includedir}/perf/perf_dlfilter.h +%{_includedir}/perf/event.h +%{_includedir}/perf/evlist.h +%{_includedir}/perf/evsel.h +%{_includedir}/perf/mmap.h +%{_includedir}/perf/threadmap.h +%{_mandir}/man3/libperf.3.gz +%{_mandir}/man7/libperf-counting.7.gz +%{_mandir}/man7/libperf-sampling.7.gz +%{_docdir}/libperf/examples/sampling.c +%{_docdir}/libperf/examples/counting.c +%{_docdir}/libperf/html/libperf.html +%{_docdir}/libperf/html/libperf-counting.html +%{_docdir}/libperf/html/libperf-sampling.html + +# with_libperf +%endif + + %if %{with_tools} %ifnarch %{cpupowerarchs} %files -n %{package_name}-tools @@ -3543,6 +3609,8 @@ fi\ %files -n %{package_name}-tools-libs-devel %{_libdir}/libcpupower.so %{_includedir}/cpufreq.h +%{_includedir}/cpuidle.h +%{_includedir}/powercap.h %endif %files -n
[OS-BUILD PATCHv2 2/4] Don't ship libperf.a in libperf-devel
From: Justin M. Forbes Don't ship libperf.a in libperf-devel Signed-off-by: Justin M. Forbes diff --git a/redhat/kernel.spec.template b/redhat/kernel.spec.template index blahblah..blahblah 100644 --- a/redhat/kernel.spec.template +++ b/redhat/kernel.spec.template @@ -3042,6 +3042,8 @@ rm -rf %{buildroot}%{_libdir}/traceevent %if %{with_libperf} %{libperf_make} DESTDIR=%{buildroot} prefix=%{_prefix} libdir=%{_libdir} install install_headers +# This is installed on some arches and we don't want to ship it +rm -rf %{buildroot}%{_libdir}/libperf.a %endif %if %{with_tools} -- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2907 -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[OS-BUILD PATCHv2 0/4] Add libperf packages and build kernel tools for Fedora
From: Justin M. Forbes on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2907 When kernel-tools was split out to a separate package in Fedora, it was due to several factors. Most of those issues have been mitigated in other ways, and there are advantages to building tools with the kernel build. Let's turn on tools for Fedora. To do so, we need to add the libperf packages, but this enables them for Fedora only. It is worth noting that the Fedora package for bpftool will retain the upstream kernel versioning. This is because the bpftool versioning scheme is incompatible with the stable Fedora process. --- redhat/kernel.spec.template | 81 +++- 1 files changed, 78 insertions(+), 3 deletions(-) -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[OS-BUILD PATCH 3/3] Don't use upstream bpftool version for Fedora package
From: Justin M. Forbes Don't use upstream bpftool version for Fedora package Upstream bpftool went with their own versioning. While this works in rawhide and RHEL where release is bumped wth every build, it does not work with Fedora. Because bpftool sublevel is not bumped with stable updates, and we don't update the release in Fedora when the version has changed, we ended up with a failure because the bpftool subpackage version already exists. For Fedora, we will stick with the kernel versioning for the package. bpftool -V still displays the upstream bpftool version number. Signed-off-by: Justin M. Forbes diff --git a/redhat/kernel.spec.template b/redhat/kernel.spec.template index blahblah..blahblah 100644 --- a/redhat/kernel.spec.template +++ b/redhat/kernel.spec.template @@ -1227,7 +1227,14 @@ analysing the logical and timing behavior of Linux. %if %{with_bpftool} +%if 0%{?fedora} +# bpftoolverion doesn't bump with stable updates so let's stick with +# upstream kernel version for the package name. We still get correct +# output with bpftool -V. +%define bpftoolversion %specrpmversion +%else %define bpftoolversion %%SPECBPFTOOLVERSION%% +%endif %package -n bpftool Summary: Inspection and simple manipulation of eBPF programs and maps -- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2907 -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[OS-BUILD PATCH 1/3] add libperf packages and enable perf, libperf, tools and bpftool packages
From: Thorsten Leemhuis add libperf packages and enable perf, libperf, tools and bpftool packages Signed-off-by: Thorsten Leemhuis diff --git a/redhat/kernel.spec.template b/redhat/kernel.spec.template index blahblah..blahblah 100644 --- a/redhat/kernel.spec.template +++ b/redhat/kernel.spec.template @@ -224,6 +224,8 @@ Summary: The Linux kernel %define with_cross_headers %{?_without_cross_headers: 0} %{?!_without_cross_headers: 1} # perf %define with_perf %{?_without_perf: 0} %{?!_without_perf: 1} +# libperf +%define with_libperf %{?_without_libperf: 0} %{?!_without_libperf: 1} # tools %define with_tools %{?_without_tools: 0} %{?!_without_tools: 1} # bpf tool @@ -300,9 +302,10 @@ Summary: The Linux kernel # no stablelist %define with_kernel_abi_stablelists 0 # Fedora builds these separately -%define with_perf 0 -%define with_tools 0 -%define with_bpftool 0 +%define with_perf 1 +%define with_libperf 1 +%define with_tools 1 +%define with_bpftool 1 # No realtime fedora variants %define with_realtime 0 %define with_arm64_64k 0 @@ -388,6 +391,7 @@ Summary: The Linux kernel %define with_realtime 0 %define with_vdso_install 0 %define with_perf 0 +%define with_libperf 0 %define with_tools 0 %define with_bpftool 0 %define with_kernel_abi_stablelists 0 @@ -402,6 +406,7 @@ Summary: The Linux kernel %define with_base 0 %define with_vdso_install 0 %define with_perf 0 +%define with_libperf 0 %define with_tools 0 %define with_bpftool 0 %define with_kernel_abi_stablelists 0 @@ -417,6 +422,7 @@ Summary: The Linux kernel %define with_debuginfo 0 %define with_vdso_install 0 %define with_perf 0 +%define with_libperf 0 %define with_tools 0 %define with_bpftool 0 %define with_kernel_abi_stablelists 0 @@ -480,6 +486,7 @@ Summary: The Linux kernel %define with_cross_headers 0 %define with_tools 0 %define with_perf 0 +%define with_libperf 0 %define with_bpftool 0 %define with_selftests 0 %define with_debug 0 @@ -572,6 +579,7 @@ Summary: The Linux kernel %define with_debuginfo 0 %define with_perf 0 +%define with_libperf 0 %define with_tools 0 %define with_bpftool 0 %define with_selftests 0 @@ -1124,6 +1132,23 @@ This package provides debug information for the perf python bindings. # with_perf %endif +%if %{with_libperf} +%package -n libperf +Summary: The perf library from kernel source +License: GPL-2.0-only AND (LGPL-2.1-only OR BSD-2-Clause) +%description -n libperf +This package contains the kernel source perf library. + +%package -n libperf-devel +Summary: Developement files for the perf library from kernel source +License: GPL-2.0-only AND (LGPL-2.1-only OR BSD-2-Clause) +%description -n libperf-devel +This package includes libraries and header files needed for development +of applications which use perf library from kernel source. + +# with_libperf +%endif + %if %{with_tools} %package -n %{package_name}-tools Summary: Assortment of tools for the Linux kernel @@ -2728,6 +2753,12 @@ chmod +x tools/perf/check-headers.sh %{perf_make} DESTDIR=$RPM_BUILD_ROOT all %endif +%if %{with_libperf} +%global libperf_make \ + %{__make} %{?make_opts} EXTRA_CFLAGS="${RPM_OPT_FLAGS}" LDFLAGS="%{__global_ldflags}" %{?cross_opts} -C tools/lib/perf V=1 +%{libperf_make} DESTDIR=$RPM_BUILD_ROOT +%endif + %global tools_make \ CFLAGS="${RPM_OPT_FLAGS}" LDFLAGS="%{__global_ldflags}" %{make} %{?make_opts} @@ -3009,6 +3040,10 @@ mkdir -p %{buildroot}/%{_mandir}/man1 rm -rf %{buildroot}%{_libdir}/traceevent %endif +%if %{with_libperf} +%{libperf_make} DESTDIR=%{buildroot} prefix=%{_prefix} libdir=%{_libdir} install install_headers +%endif + %if %{with_tools} %ifarch %{cpupowerarchs} %{make} -C tools/power/cpupower DESTDIR=$RPM_BUILD_ROOT libdir=%{_libdir} mandir=%{_mandir} CPUFREQ_BENCH=false install @@ -3494,6 +3529,37 @@ fi\ # with_perf %endif +%if %{with_libperf} +%files -n libperf +%{_libdir}/libperf.so.0 +%{_libdir}/libperf.so.0.0.1 + +%files -n libperf-devel +%{_libdir}/libperf.so +%{_libdir}/pkgconfig/libperf.pc +%{_includedir}/internal/*.h +%{_includedir}/perf/bpf_perf.h +%{_includedir}/perf/core.h +%{_includedir}/perf/cpumap.h +%{_includedir}/perf/perf_dlfilter.h +%{_includedir}/perf/event.h +%{_includedir}/perf/evlist.h +%{_includedir}/perf/evsel.h +%{_includedir}/perf/mmap.h +%{_includedir}/perf/threadmap.h +%{_mandir}/man3/libperf.3.gz +%{_mandir}/man7/libperf-counting.7.gz +%{_mandir}/man7/libperf-sampling.7.gz +%{_docdir}/libperf/examples/sampling.c +%{_docdir}/libperf/examples/counting.c +%{_docdir}/libperf/html/libperf.html +%{_docdir}/libperf/html/libperf-counting.html +%{_docdir}/libperf/html/libperf-sampling.html + +# with_libperf +%endif + + %if %{with_tools} %ifnarch %{cpupowerarchs} %files -n %{package_name}-tools @@ -3543,6 +3609,8 @@ fi\ %files -n %{package_name}-tools-libs-devel %{_libdir}/libcpupower.so %{_includedir}/cpufreq.h +%{_includedir}/cpuidle.h +%{_includedir}/powercap.h %endif %files -n
[OS-BUILD PATCH 2/3] Don't ship libperf.a in libperf-devel
From: Justin M. Forbes Don't ship libperf.a in libperf-devel Signed-off-by: Justin M. Forbes diff --git a/redhat/kernel.spec.template b/redhat/kernel.spec.template index blahblah..blahblah 100644 --- a/redhat/kernel.spec.template +++ b/redhat/kernel.spec.template @@ -3042,6 +3042,8 @@ rm -rf %{buildroot}%{_libdir}/traceevent %if %{with_libperf} %{libperf_make} DESTDIR=%{buildroot} prefix=%{_prefix} libdir=%{_libdir} install install_headers +# This is installed on some arches and we don't want to ship it +rm -rf %{buildroot}%{_libdir}/libperf.a %endif %if %{with_tools} -- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2907 -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[OS-BUILD PATCH 0/3] Add libperf packages and build kernel tools for Fedora
From: Justin M. Forbes on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2907 When kernel-tools was split out to a separate package in Fedora, it was due to several factors. Most of those issues have been mitigated in other ways, and there are advantages to building tools with the kernel build. Let's turn on tools for Fedora. To do so, we need to add the libperf packages, but this enables them for Fedora only. It is worth noting that the Fedora package for bpftool will retain the upstream kernel versioning. This is because the bpftool versioning scheme is incompatible with the stable Fedora process. --- redhat/kernel.spec.template | 83 +++- 1 files changed, 80 insertions(+), 3 deletions(-) -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[OS-BUILD PATCH] Flip values for FSCACHE and NETFS_SUPPORT to avoid mismatch
From: Justin M. Forbes Flip values for FSCACHE and NETFS_SUPPORT to avoid mismatch Upstream commit 915cd30cdea88 combines fscache and netfs. This resulted in a config mismatch. This update puts us back to where we were within the new code. Signed-off-by: Justin M. Forbes diff --git a/redhat/configs/pending-rhel/generic/CONFIG_FSCACHE b/redhat/configs/rhel/generic/CONFIG_FSCACHE rename from redhat/configs/pending-rhel/generic/CONFIG_FSCACHE rename to redhat/configs/rhel/generic/CONFIG_FSCACHE index blahblah..blahblah 100644 --- a/redhat/configs/pending-rhel/generic/CONFIG_FSCACHE +++ b/redhat/configs/rhel/generic/CONFIG_FSCACHE diff --git a/redhat/configs/pending-rhel/generic/CONFIG_NETFS_SUPPORT b/redhat/configs/rhel/generic/CONFIG_NETFS_SUPPORT rename from redhat/configs/pending-rhel/generic/CONFIG_NETFS_SUPPORT rename to redhat/configs/rhel/generic/CONFIG_NETFS_SUPPORT index blahblah..blahblah 100644 --- a/redhat/configs/pending-rhel/generic/CONFIG_NETFS_SUPPORT +++ b/redhat/configs/rhel/generic/CONFIG_NETFS_SUPPORT diff --git a/redhat/configs/pending-rhel/generic/s390x/zfcpdump/CONFIG_CACHEFILES b/redhat/configs/rhel/generic/s390x/zfcpdump/CONFIG_CACHEFILES rename from redhat/configs/pending-rhel/generic/s390x/zfcpdump/CONFIG_CACHEFILES rename to redhat/configs/rhel/generic/s390x/zfcpdump/CONFIG_CACHEFILES index blahblah..blahblah 100644 --- a/redhat/configs/pending-rhel/generic/s390x/zfcpdump/CONFIG_CACHEFILES +++ b/redhat/configs/rhel/generic/s390x/zfcpdump/CONFIG_CACHEFILES -- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2904 -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[OS-BUILD PATCH] Remove CONFIG_NET_EMATCH_STACK file for RHEL
From: Justin M. Forbes Remove CONFIG_NET_EMATCH_STACK file for RHEL This file was set to: CONFIG_NET_EMATCH_STACK is not set Unofortunately that is not a valid entry for this. It would require an integer. In the past, Kconfig didn't care so much, but recent changes make Kconfig error out on this and kill the build. We can simply delete the entry because CONFIG_NET_EMATCH is not set for RHEL either, and that is the only thing with a dep on CONFIG_NET_EMATCH_STACK. Signed-off-by: Justin M. Forbes diff --git a/redhat/configs/rhel/generic/CONFIG_NET_EMATCH_STACK b/redhat/configs/rhel/generic/CONFIG_NET_EMATCH_STACK deleted file mode 100644 index blahblah..blahblah 0 --- a/redhat/configs/rhel/generic/CONFIG_NET_EMATCH_STACK +++ /dev/null @@ -1 +0,0 @@ -# CONFIG_NET_EMATCH_STACK is not set -- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2900 -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCHv2 0/6] secure boot signing updates
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2849#note_1732719906 I do not, the Fedora signing method is a bit different. More importantly though, we can't merge this yet. Fedora still needs both signatures while we wait for the updated shim. I was last told we are a month out or so. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCH] Enable CONFIG_MARVELL_88Q2XXX_PHY
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2881#note_1729380152 Correct. I just merged a fix for that and will rerun the pipeline. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCHv2] net: bump CONFIG_MAX_SKB_FRAGS to 45
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2873#note_1729220761 There is an MR to address that one, but it has not been merged yet. You shouldn't need to do anything in this MR to address it though, we will just re-run the CKI when we know things to be working again. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCH] net: bump CONFIG_MAX_SKB_FRAGS to 45
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2873#note_1725945431 Yup, you can ignore it. Typical merge window stuff. The docs merge made us add a buildreq on python3-pyyaml but that MR is not merged yet. CKI fails on it because the container images don't have that package available yet. I expect it will all be cleared up in the next day or 2, and the CKI will pass again. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[OS-BUILD PATCH] Add python3-pyyaml to buildreqs for kernel-docs
From: Justin M. Forbes Add python3-pyyaml to buildreqs for kernel-docs Upstream commit f061c9f7d058f added a script to parse the Netlink YAML specs and generate RST files. As a result, we need python3-pyyaml for "make htmldocs" to succeed. Signed-off-by: Justin M. Forbes diff --git a/redhat/kernel.spec.template b/redhat/kernel.spec.template index blahblah..blahblah 100644 --- a/redhat/kernel.spec.template +++ b/redhat/kernel.spec.template @@ -673,7 +673,7 @@ BuildRequires: bpftool BuildRequires: rsync %endif %if %{with_doc} -BuildRequires: xmlto, asciidoc, python3-sphinx, python3-sphinx_rtd_theme +BuildRequires: xmlto, asciidoc, python3-sphinx, python3-sphinx_rtd_theme, python3-pyyaml %endif %if %{with_sparse} BuildRequires: sparse -- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2872 -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCH] Fix up "random: Add hook to override device reads and getrandom(2)"
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2857#note_1721497514 This MR already exists: https://gitlab.com/cki-project/kernel- ark/-/merge_requests/2856 -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[OS-BUILD PATCH] random: replace import_single_range() with import_ubuf()
From: Justin M. Forbes random: replace import_single_range() with import_ubuf() Upstream commit 6ac805d138709 dropped the iov arg from import_single_range() and upstream commit 9fd7874c0e5c8 replaced import_single_range() with import_ubuff(). As our patch 7c0b728ae37e7 still called import_single_range() in drivers/char/random, this needs to be brought up to date to continue working. Reported-by: Scott Weaver Signed-off-by: Justin M. Forbes diff --git a/drivers/char/random.c b/drivers/char/random.c index blahblah..blahblah 100644 --- a/drivers/char/random.c +++ b/drivers/char/random.c @@ -1406,7 +1406,7 @@ SYSCALL_DEFINE3(getrandom, char __user *, ubuf, size_t, len, unsigned int, flags rcu_read_unlock(); if (rng) { - ret = import_single_range(ITER_DEST, ubuf, len, , ); + ret = import_ubuf(ITER_DEST, ubuf, len, ); if (unlikely(ret)) return ret; ret = rng->extrng_read_iter(, !!(flags & GRND_RANDOM)); -- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2856 -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCHv2] redhat: fix dist-git/upload for the kernel.changelog.xz file
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2841#note_1704939342 Something perhaps worth considering in the longer term. Every time a binary file changes, we must upload the entire file to the look aside (or dist-git before this change). I am wondering if a non compressed changelog would be much less actual overhead as only a diff has to be stored with each update. Perhaps it might be better to wait to compress during the rpmbuild itself so that it is still compressed when installed with kernel-docs? As RPMs and git history is compressed, I think this might be the better method. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCH] redhat: fix dist-git/upload for the kernel.changelog.xz file
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2841#note_1704891059 This seems a reasonable fix. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCHv3 0/2] redhat: create an empty changelog file when changing its name
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2838#note_1704813417 Editing .gitignore actually means editing `redhat/scripts/expand_srpm.sh` but pretty much any solution we choose will require editing that script. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCHv3 0/2] redhat: create an empty changelog file when changing its name
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2838#note_1704742952 Slight problem with this approach. By default .xz files are in .gitignore for dist-git. This breaks our current process as: ``` Source file 'kernel.changelog.xz' was neither listed in the 'sources' file nor tracked in git nor listed in additional sources. Push operation was cancelled Hint: this check (.git/hooks/pre-push script) can be bypassed by adding the argument '--no-verify' argument to the push command. error: failed to push some refs to 'ssh://pkgs.fedoraproject.org/rpms/kernel' Could not execute push: Failed to execute command. ``` -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCHv2 0/0] redhat: scripts: An automation script for disabling unused driver for x86
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2832#note_1688517627 Thank you. I have acked this. The changes to RHMAINTAINERS which would make it so that the Fedora review is all that matters will make it in with the next update. In the meantime, perhaps @prarit will resolve his thread and maybe give an ack? -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCH 0/0] redhat: scripts: An automation script for disabling unused driver for x86
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2832#note_1684872559 I don't disagree, though all new config items coming in for RHEL have to be reviewed by the subsystem owners anyway, and tend to default to off unless requested otherwise. There may be some cases of legacy hardware which isn't supported by newer RHEL versions, but RHEL would certainly have a different list. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCH 0/0] redhat: scripts: An automation script for disabling unused driver for x86
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2832#note_1684856741 I am okay with this concept. I might recommend that we move all of this to `redhat/scripts/fedora` though as it is pretty fedora specific at the moment. It will also allow me to set up ack rules so that RHEL maintainers do not need to review the changes to it. (This is a new directory, which might not have been present when this work was started) -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCH 0/0] redhat: scripts: An automation script for disabling unused driver for x86
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2832#note_1684758822 > Right so you are kinda stuck and you default to on. Ok, I get your data source comment now (which is sorta the same as my who-decides-unnecessary comment). I would have thought drivers like these with no intention going on x86 would state that in the Kconfig, but perhaps they are stuck with the same reasoning: why limit it? With some they don't bother. With others they really don't know. A vendor makes a DAC chip, or a regulator, and a driver for it gets upstream. They are hoping to sell those chips to as many vendors as will buy them. AFAIK there is no central registry of "here's everything that is shipping". I still think with this approach, we may end up missing some eccentric hardware not in wide use, but it would be easy enough to turn those back on once a bug is filed. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCH 0/0] redhat: scripts: An automation script for disabling unused driver for x86
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2832#note_1684711819 While Fedora is very much interested in enabling any drivers for hardware that is or soon will be in the wild, there isn't much point in enabling a driver on an arch where it will never be used. The real problem with IIO and so many other chips, is drivers come before the hardware really. I know certain vendors regularly appear in laptops from major vendors, but I don't know which new chips the laptop vendors are planning to incorporate in future products. As a result, I tend to turn on most of them. Basically, if there is no actual way to use a driver on an arch, it is just extra surface area and should be disabled. If we had some sort of a legitimate data feed for several arches I would guess we could turn off hundreds of drivers. There is a similar problem with aarch64, in that several drivers end up enabled for SoCs that we will never run on because no vendor picks them up for a form factor of interest. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCH 0/0] redhat: scripts: An automation script for disabling unused driver for x86
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2832#note_1683958591 I suppose I am curious as to why it is set up like this then. I do understand that new iio drivers can (and do) show up pretty much every merge window. Having an allow list would make sure that new drivers are disabled if they are not in that list. That means that we need a reliable data source to keep this list updated, or we will disable new x86 iio drivers by default, which does not make for a great user experience. Certainly the config changes here are acceptable. The script itself is not a bad idea, but it can not be run again after the next merge window unless someone, or ideally some automated process, can update the allow_list. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCH 0/0] redhat: scripts: An automation script for disabling unused driver for x86
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2832#note_1683946934 I still do not see how custom-overrides has anything to do with this. If the hardware doesn't exist on x86, it needs to be disabled on x86 permanently, not for a specific build, not for a specific system. The custom-overrides directory is supposed to remain empty for general use, it is for end users to make changes to the standard config. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCH 0/0] redhat: scripts: An automation script for disabling unused driver for x86
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2832#note_1682187133 The problem being solved would be unnecessarily enabled drivers. Turning them off lowers attack surface among other things. I would absolutely love a solid data source which tells me what hardware is actually in the wild, and what I can disable. But I don't know how much value the script is without some sort of valid data source that is regularly updated. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCH 0/0] redhat: scripts: An automation script for disabling unused driver for x86
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2832#note_1682054528 I don't see why we would be using custom-overrides for this at all. If it is hardware that does not exist on x86, we should be disabling the config there. We have an issue that many of these drivers are written for an upstream chip, but when they are merged to the kernel, we don't know what hardware they will actually end up in. We have been turning them on if they are a vendor which typically supplies to x86 board or pc manufacturers, so that if they do use that part in a future product, it is supported. This does make for a nice end user experience as more things are supported on release, but it does present a problem that we have a large number of drivers enabled as modules which serve no purpose in the real world. I like the problem that this is trying to solve, I just want to know where it is getting the data to do so, and how that data is maintained. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCH 0/0] redhat: scripts: An automation script for disabling unused driver for x86
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2832#note_1681957728 While I certainly like the concept, how is the allow list maintained? Where is the information pulled from? -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCHv2 0/0] Enable erofs and fs-verity and mark tech preview
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2825#note_1670023778 Perfect, thank you. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCH 0/0] Enable erofs and fs-verity and mark tech preview
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2825#note_1668110534 Thanks for the heads up. Both of these should be behind: `#ifdef CONFIG_RHEL_DIFFERENCES` As we do not want this behavior for Fedora. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCHv4 0/3] redhat: introduce RH_KABI_EXCLUDE_WITH_SIZE and enable size checks
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1619#note_1654178039 Appreciate the updates. As it no longer has Fedora files, my ack is no longer required, but it looks good to me. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCHv3 0/2] redhat: introduce RH_KABI_EXCLUDE_WITH_SIZE and enable size checks
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1619#note_1651907511 This should also not be required. Fedora does not need an entry for this one anymore because the Kconfig is now dependent on RHEL_DIFFERENCES which is not enabled for Fedora. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCHv3 0/2] redhat: introduce RH_KABI_EXCLUDE_WITH_SIZE and enable size checks
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1619#note_1651905832 This file should not be required. We set the config appropriately in redhat/configs/rhel and there is nothing common between the RHEL and Fedora configs for it. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCH] Fix s390 zfcpfdump bpf build failures for cgroups
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2812#note_1635995157 Verified in koji that this does fix the s390 build for ELN. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[OS-BUILD PATCHv2 2/2] Add mean_and_variance_test to mod-internal.list
From: Justin M. Forbes Add mean_and_variance_test to mod-internal.list Needed because Fedora turned on bcachefs. Signed-off-by: Justin M. Forbes diff --git a/redhat/scripts/mod/mod-internal.list b/redhat/scripts/mod/mod-internal.list index blahblah..blahblah 100644 --- a/redhat/scripts/mod/mod-internal.list +++ b/redhat/scripts/mod/mod-internal.list @@ -46,6 +46,7 @@ list-test locktorture mac80211_hwsim mac80211-tests +mean_and_variance_test memcpy_kunit mptcp_crypto_test mptcp_token_test -- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2795 ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[OS-BUILD PATCHv2 1/2] Add cfg80211-tests and mac80211-tests to mod-internal.list
From: Justin M. Forbes Add cfg80211-tests and mac80211-tests to mod-internal.list New kunit tests with 6.7 that need to be added to mod-internal list as they need the kunit symbols. Signed-off-by: Justin M. Forbes diff --git a/redhat/scripts/mod/mod-internal.list b/redhat/scripts/mod/mod-internal.list index blahblah..blahblah 100644 --- a/redhat/scripts/mod/mod-internal.list +++ b/redhat/scripts/mod/mod-internal.list @@ -1,5 +1,6 @@ bitfield_kunit checksum_kunit +cfg80211-tests clk-fractional-divider_test clk-gate_test clk_test @@ -44,6 +45,7 @@ lib_test list-test locktorture mac80211_hwsim +mac80211-tests memcpy_kunit mptcp_crypto_test mptcp_token_test -- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2795 ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[OS-BUILD PATCHv2 0/2] Add cfg80211-tests and mac80211-tests to mod-internal.list
From: Justin M. Forbes on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2795 New kunit tests with 6.7 that need to be added to mod-internal list as they need the kunit symbols. Signed-off-by: Justin M. Forbes --- redhat/scripts/mod/mod-internal.list | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[OS-BUILD PATCH] Add cfg80211-tests and mac80211-tests to mod-internal.list
From: Justin M. Forbes Add cfg80211-tests and mac80211-tests to mod-internal.list New kunit tests with 6.7 that need to be added to mod-internal list as they need the kunit symbols. Signed-off-by: Justin M. Forbes diff --git a/redhat/scripts/mod/mod-internal.list b/redhat/scripts/mod/mod-internal.list index blahblah..blahblah 100644 --- a/redhat/scripts/mod/mod-internal.list +++ b/redhat/scripts/mod/mod-internal.list @@ -1,5 +1,6 @@ bitfield_kunit checksum_kunit +cfg80211-tests clk-fractional-divider_test clk-gate_test clk_test @@ -44,6 +45,7 @@ lib_test list-test locktorture mac80211_hwsim +mac80211-tests memcpy_kunit mptcp_crypto_test mptcp_token_test -- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2795 ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCH 0/0] Add various modules to mod-internal.list after experiences with -next
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2771#note_1629841670 I apprecaiate this. Adding include in releases until it gets acks. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCH] [redhat] configs: Enable GPIO_SIM as a builtin for s390/zfcpdump
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2766#note_1622753084 s390 does not, s390-zfcpdump does because it doesn't support modules at all. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCH] fedora: Switch TI_SCI_CLK and TI_SCI_PM_DOMAINS symbols to built-in
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2727#note_1584175715 Pipeline failure is unrelated, ELN binutils update broke the kernel build. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCH] tpm: Fix typo in tpmrm class definition
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2716#note_1559028949 That was quick. Already upstream. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[OS-BUILD PATCH] tpm: Fix typo in tpmrm class definition
From: Justin M. Forbes tpm: Fix typo in tpmrm class definition Commit d2e8071bed0be ("tpm: make all 'class' structures const") unfortunately had a typo for the name on tpmrm. Fixes: d2e8071bed0b ("tpm: make all 'class' structures const") Signed-off-by: "Justin M. Forbes" diff --git a/drivers/char/tpm/tpm-chip.c b/drivers/char/tpm/tpm-chip.c index blahblah..blahblah 100644 --- a/drivers/char/tpm/tpm-chip.c +++ b/drivers/char/tpm/tpm-chip.c @@ -33,7 +33,7 @@ const struct class tpm_class = { .shutdown_pre = tpm_class_shutdown, }; const struct class tpmrm_class = { - .name = "tmprm", + .name = "tpmrm", }; dev_t tpm_devt; -- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2716 ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCH] tpm: Enable hwrng only for Pluton on AMD CPUs
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2706#note_1555027298 This is upstream now. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[OS-BUILD PATCH] tpm: Enable hwrng only for Pluton on AMD CPUs
From: Jarkko Sakkinen tpm: Enable hwrng only for Pluton on AMD CPUs The vendor check introduced by commit 554b841d4703 ("tpm: Disable RNG for all AMD fTPMs") doesn't work properly on a number of Intel fTPMs. On the reported systems the TPM doesn't reply at bootup and returns back the command code. This makes the TPM fail probe on Lenovo Legion Y540 laptop. Since only Microsoft Pluton is the only known combination of AMD CPU and fTPM from other vendor, disable hwrng otherwise. In order to make sysadmin aware of this, print also info message to the klog. Cc: sta...@vger.kernel.org Fixes: 554b841d4703 ("tpm: Disable RNG for all AMD fTPMs") Reported-by: Todd Brandt Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217804 Reported-by: Patrick Steinhardt Reported-by: Raymond Jay Golo Reported-by: Ronan Pigott Reviewed-by: Jerry Snitselaar Signed-off-by: Jarkko Sakkinen diff --git a/drivers/char/tpm/tpm_crb.c b/drivers/char/tpm/tpm_crb.c index blahblah..blahblah 100644 --- a/drivers/char/tpm/tpm_crb.c +++ b/drivers/char/tpm/tpm_crb.c @@ -463,28 +463,6 @@ static bool crb_req_canceled(struct tpm_chip *chip, u8 status) return (cancel & CRB_CANCEL_INVOKE) == CRB_CANCEL_INVOKE; } -static int crb_check_flags(struct tpm_chip *chip) -{ - u32 val; - int ret; - - ret = crb_request_locality(chip, 0); - if (ret) - return ret; - - ret = tpm2_get_tpm_pt(chip, TPM2_PT_MANUFACTURER, , NULL); - if (ret) - goto release; - - if (val == 0x414D4400U /* AMD */) - chip->flags |= TPM_CHIP_FLAG_HWRNG_DISABLED; - -release: - crb_relinquish_locality(chip, 0); - - return ret; -} - static const struct tpm_class_ops tpm_crb = { .flags = TPM_OPS_AUTO_STARTUP, .status = crb_status, @@ -826,9 +804,14 @@ static int crb_acpi_add(struct acpi_device *device) if (rc) goto out; - rc = crb_check_flags(chip); - if (rc) - goto out; +#ifdef CONFIG_X86 + /* A quirk for https://www.amd.com/en/support/kb/faq/pa-410 */ + if (boot_cpu_data.x86_vendor == X86_VENDOR_AMD && + priv->sm != ACPI_TPM2_COMMAND_BUFFER_WITH_PLUTON) { + dev_info(dev, "Disabling hwrng\n"); + chip->flags |= TPM_CHIP_FLAG_HWRNG_DISABLED; + } +#endif /* CONFIG_X86 */ rc = tpm_chip_register(chip); -- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2706 ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[OS-BUILD PATCH] Flip CONFIG_SND_SOC_CS35L56_SDW to m and clean up
From: Justin M. Forbes Flip CONFIG_SND_SOC_CS35L56_SDW to m and clean up Upstream commit 4754e29c779fe makes SND_SOC_INTEL_SOUNDWIRE_SOF_MACH select SND_SOC_CS35L56. This was previously disabled in RHEL and the new select results in a mismatch. Let's turn on CONFIG_SND_SOC_CS35L56_SDW for x86 in common, and lean up all of the other references to it. Signed-off-by: Justin M. Forbes diff --git a/redhat/configs/common/generic/CONFIG_SND_SOC_CS35L56_SDW b/redhat/configs/common/generic/CONFIG_SND_SOC_CS35L56_SDW deleted file mode 100644 index blahblah..blahblah 0 --- a/redhat/configs/common/generic/CONFIG_SND_SOC_CS35L56_SDW +++ /dev/null @@ -1 +0,0 @@ -# CONFIG_SND_SOC_CS35L56_SDW is not set diff --git a/redhat/configs/fedora/generic/CONFIG_SND_SOC_CS35L56_SDW b/redhat/configs/common/generic/x86/CONFIG_SND_SOC_CS35L56_SDW rename from redhat/configs/fedora/generic/CONFIG_SND_SOC_CS35L56_SDW rename to redhat/configs/common/generic/x86/CONFIG_SND_SOC_CS35L56_SDW index blahblah..blahblah 100644 --- a/redhat/configs/fedora/generic/CONFIG_SND_SOC_CS35L56_SDW +++ b/redhat/configs/common/generic/x86/CONFIG_SND_SOC_CS35L56_SDW diff --git a/redhat/configs/pending-rhel/generic/CONFIG_SND_SOC_CS35L56_SDW b/redhat/configs/fedora/generic/arm/aarch64/CONFIG_SND_SOC_CS35L56_SDW rename from redhat/configs/pending-rhel/generic/CONFIG_SND_SOC_CS35L56_SDW rename to redhat/configs/fedora/generic/arm/aarch64/CONFIG_SND_SOC_CS35L56_SDW index blahblah..blahblah 100644 --- a/redhat/configs/pending-rhel/generic/CONFIG_SND_SOC_CS35L56_SDW +++ b/redhat/configs/fedora/generic/arm/aarch64/CONFIG_SND_SOC_CS35L56_SDW diff --git a/redhat/configs/rhel/generic/CONFIG_SND_SOC_CS35L56_SDW b/redhat/configs/rhel/generic/CONFIG_SND_SOC_CS35L56_SDW deleted file mode 100644 index blahblah..blahblah 0 --- a/redhat/configs/rhel/generic/CONFIG_SND_SOC_CS35L56_SDW +++ /dev/null @@ -1 +0,0 @@ -# CONFIG_SND_SOC_CS35L56_SDW is not set -- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2690 ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCH] redhat: bump libcpupower soname to match upstream
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2663#note_1534375545 Added include in release as this actually failed today's ELN build. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCH] redhat: drop unneeded build-time dependency gcc-plugin-devel
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2656#note_1532139710 > > Prarit Bhargava commented: > > @coxu , ISTR doing this same thing a while ago. IIRC, there were valid use cases for the dependency. @jmflinuxtx do you recall what they were? I'm light on details now. It absolutely could be the case that we can get rid of this package dependency now. Your last discussion on that was https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2358 Justin ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCHv4 0/0] fedora: remove ARMv7 AKA armhfp support
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2607#note_1510107631 Everything looks good except for the removal of the aarch64-16k configs from the spec. If you can do an update with those added back, it should be an easy merge. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCHv3 0/0] fedora: remove ARMv7 AKA armhfp support
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2607#note_1509460304 It doesn't particularly matter so much in this case, the required acks are out of hand because it is a re-org, but outside of spec and config build work it is a no-op. We can reset the required acks to reviewers in that area, but need it to pass CKI and be ready to merge or the webhooks will walk over it all again. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCHv3 0/0] fedora: remove ARMv7 AKA armhfp support
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2607#note_1508427945 Given this is a no-op, there is no need for this level of review. Nothing is changing in the generated configs, it is simply rearranging the underlying config files now that armv7 is gone. I think acks from msalter and Fedora are sufficient here. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCHv2] Enable CONFIG_EXPERT for both RHEL and Fedora
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2612#note_1505070459 Sorry for the late response, I was travelling. I did an audit this week across all arches with post build configs, and the result is the V2 for this change. Specifically CONFIG_TRIM_UNUSED_KSYMS which is set in rt kernels actually disables LIVEPATCH. We had a few suboptions to CONFIG_HID_PICOLCD which were flipped from their defaults, and CONFIG_ARCH_MMAP_RND_BITS needed different values for a couple of different arches. As of now, things no existing configs (outside of EXPERT) are flipped with this change. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[OS-BUILD PATCHv2] Enable CONFIG_EXPERT for both RHEL and Fedora
From: Justin M. Forbes Enable CONFIG_EXPERT for both RHEL and Fedora With CONFIG_EXPERT disabled, we have had instances of things changing underneath without our knowledge. This is evident where we had config items specifically set, but they are ignored because the item is now dependent upon CONFIG_EXPERT. It is time to enable CONFIG_EXPERT to ensure that we know exactly how our configs are built. Additionally, RT is hidden behind CONFIG_EXPERT as well, so RHEL developers already had to ensure that configs dependent upon expert were set correctly for both x86 and aarch64. This should make things a bit easier in that regard since EXPERT is now set everywhere. V2: Fix up some mismatches between generated configs and previously built configs. Signed-off-by: Justin M. Forbes diff --git a/redhat/configs/rhel/rt/generic/CONFIG_ADVISE_SYSCALLS b/redhat/configs/common/generic/CONFIG_ADVISE_SYSCALLS rename from redhat/configs/rhel/rt/generic/CONFIG_ADVISE_SYSCALLS rename to redhat/configs/common/generic/CONFIG_ADVISE_SYSCALLS index blahblah..blahblah 100644 --- a/redhat/configs/rhel/rt/generic/CONFIG_ADVISE_SYSCALLS +++ b/redhat/configs/common/generic/CONFIG_ADVISE_SYSCALLS diff --git a/redhat/configs/rhel/generic/CONFIG_AIO b/redhat/configs/common/generic/CONFIG_AIO rename from redhat/configs/rhel/generic/CONFIG_AIO rename to redhat/configs/common/generic/CONFIG_AIO index blahblah..blahblah 100644 --- a/redhat/configs/rhel/generic/CONFIG_AIO +++ b/redhat/configs/common/generic/CONFIG_AIO diff --git a/redhat/configs/rhel/rt/generic/CONFIG_ALLOW_DEV_COREDUMP b/redhat/configs/common/generic/CONFIG_ALLOW_DEV_COREDUMP rename from redhat/configs/rhel/rt/generic/CONFIG_ALLOW_DEV_COREDUMP rename to redhat/configs/common/generic/CONFIG_ALLOW_DEV_COREDUMP index blahblah..blahblah 100644 --- a/redhat/configs/rhel/rt/generic/CONFIG_ALLOW_DEV_COREDUMP +++ b/redhat/configs/common/generic/CONFIG_ALLOW_DEV_COREDUMP diff --git a/redhat/configs/rhel/rt/generic/CONFIG_ARCH_MMAP_RND_BITS b/redhat/configs/common/generic/CONFIG_ARCH_MMAP_RND_BITS rename from redhat/configs/rhel/rt/generic/CONFIG_ARCH_MMAP_RND_BITS rename to redhat/configs/common/generic/CONFIG_ARCH_MMAP_RND_BITS index blahblah..blahblah 100644 --- a/redhat/configs/rhel/rt/generic/CONFIG_ARCH_MMAP_RND_BITS +++ b/redhat/configs/common/generic/CONFIG_ARCH_MMAP_RND_BITS diff --git a/redhat/configs/rhel/rt/generic/CONFIG_ARCH_MMAP_RND_COMPAT_BITS b/redhat/configs/common/generic/CONFIG_ARCH_MMAP_RND_COMPAT_BITS rename from redhat/configs/rhel/rt/generic/CONFIG_ARCH_MMAP_RND_COMPAT_BITS rename to redhat/configs/common/generic/CONFIG_ARCH_MMAP_RND_COMPAT_BITS index blahblah..blahblah 100644 --- a/redhat/configs/rhel/rt/generic/CONFIG_ARCH_MMAP_RND_COMPAT_BITS +++ b/redhat/configs/common/generic/CONFIG_ARCH_MMAP_RND_COMPAT_BITS diff --git a/redhat/configs/rhel/rt/generic/CONFIG_ATA_FORCE b/redhat/configs/common/generic/CONFIG_ATA_FORCE rename from redhat/configs/rhel/rt/generic/CONFIG_ATA_FORCE rename to redhat/configs/common/generic/CONFIG_ATA_FORCE index blahblah..blahblah 100644 --- a/redhat/configs/rhel/rt/generic/CONFIG_ATA_FORCE +++ b/redhat/configs/common/generic/CONFIG_ATA_FORCE diff --git a/redhat/configs/rhel/rt/generic/CONFIG_ATH9K_PCOEM b/redhat/configs/common/generic/CONFIG_ATH9K_PCOEM rename from redhat/configs/rhel/rt/generic/CONFIG_ATH9K_PCOEM rename to redhat/configs/common/generic/CONFIG_ATH9K_PCOEM index blahblah..blahblah 100644 --- a/redhat/configs/rhel/rt/generic/CONFIG_ATH9K_PCOEM +++ b/redhat/configs/common/generic/CONFIG_ATH9K_PCOEM diff --git a/redhat/configs/rhel/rt/generic/CONFIG_ATH9K_RFKILL b/redhat/configs/common/generic/CONFIG_ATH9K_RFKILL rename from redhat/configs/rhel/rt/generic/CONFIG_ATH9K_RFKILL rename to redhat/configs/common/generic/CONFIG_ATH9K_RFKILL index blahblah..blahblah 100644 --- a/redhat/configs/rhel/rt/generic/CONFIG_ATH9K_RFKILL +++ b/redhat/configs/common/generic/CONFIG_ATH9K_RFKILL diff --git a/redhat/configs/rhel/rt/generic/CONFIG_BASE_FULL b/redhat/configs/common/generic/CONFIG_BASE_FULL rename from redhat/configs/rhel/rt/generic/CONFIG_BASE_FULL rename to redhat/configs/common/generic/CONFIG_BASE_FULL index blahblah..blahblah 100644 --- a/redhat/configs/rhel/rt/generic/CONFIG_BASE_FULL +++ b/redhat/configs/common/generic/CONFIG_BASE_FULL diff --git a/redhat/configs/rhel/rt/generic/CONFIG_BLOCK b/redhat/configs/common/generic/CONFIG_BLOCK rename from redhat/configs/rhel/rt/generic/CONFIG_BLOCK rename to redhat/configs/common/generic/CONFIG_BLOCK index blahblah..blahblah 100644 --- a/redhat/configs/rhel/rt/generic/CONFIG_BLOCK +++ b/redhat/configs/common/generic/CONFIG_BLOCK diff --git a/redhat/configs/common/generic/arm/aarch64/CONFIG_BUG b/redhat/configs/common/generic/CONFIG_BUG rename from redhat/configs/common/generic/arm/aarch64/CONFIG_BUG rename to redhat/configs/common/generic/CONFIG_BUG index blahblah..blahblah 100644 --- a/redhat/configs/common/generic/arm/aarch64/CONFIG_BUG +++
[OS-BUILD PATCH] Enable CONFIG_EXPERT for both RHEL and Fedora
From: Justin M. Forbes Enable CONFIG_EXPERT for both RHEL and Fedora With CONFIG_EXPERT disabled, we have had instances of things changing underneath without our knowledge. This is evident where we had config items specifically set, but they are ignored because the item is now dependent upon CONFIG_EXPERT. It is time to enable CONFIG_EXPERT to ensure that we know exactly how our configs are built. Additionally, RT is hidden behind CONFIG_EXPERT as well, so RHEL developers already had to ensure that configs dependent upon expert were set correctly for both x86 and aarch64. This should make things a bit easier in that regard since EXPERT is now set everywhere. Signed-off-by: Justin M. Forbes diff --git a/redhat/configs/rhel/rt/generic/CONFIG_ADVISE_SYSCALLS b/redhat/configs/common/generic/CONFIG_ADVISE_SYSCALLS rename from redhat/configs/rhel/rt/generic/CONFIG_ADVISE_SYSCALLS rename to redhat/configs/common/generic/CONFIG_ADVISE_SYSCALLS index blahblah..blahblah 100644 --- a/redhat/configs/rhel/rt/generic/CONFIG_ADVISE_SYSCALLS +++ b/redhat/configs/common/generic/CONFIG_ADVISE_SYSCALLS diff --git a/redhat/configs/rhel/generic/CONFIG_AIO b/redhat/configs/common/generic/CONFIG_AIO rename from redhat/configs/rhel/generic/CONFIG_AIO rename to redhat/configs/common/generic/CONFIG_AIO index blahblah..blahblah 100644 --- a/redhat/configs/rhel/generic/CONFIG_AIO +++ b/redhat/configs/common/generic/CONFIG_AIO diff --git a/redhat/configs/rhel/rt/generic/CONFIG_ALLOW_DEV_COREDUMP b/redhat/configs/common/generic/CONFIG_ALLOW_DEV_COREDUMP rename from redhat/configs/rhel/rt/generic/CONFIG_ALLOW_DEV_COREDUMP rename to redhat/configs/common/generic/CONFIG_ALLOW_DEV_COREDUMP index blahblah..blahblah 100644 --- a/redhat/configs/rhel/rt/generic/CONFIG_ALLOW_DEV_COREDUMP +++ b/redhat/configs/common/generic/CONFIG_ALLOW_DEV_COREDUMP diff --git a/redhat/configs/rhel/rt/generic/CONFIG_ARCH_MMAP_RND_BITS b/redhat/configs/common/generic/CONFIG_ARCH_MMAP_RND_BITS rename from redhat/configs/rhel/rt/generic/CONFIG_ARCH_MMAP_RND_BITS rename to redhat/configs/common/generic/CONFIG_ARCH_MMAP_RND_BITS index blahblah..blahblah 100644 --- a/redhat/configs/rhel/rt/generic/CONFIG_ARCH_MMAP_RND_BITS +++ b/redhat/configs/common/generic/CONFIG_ARCH_MMAP_RND_BITS diff --git a/redhat/configs/rhel/rt/generic/CONFIG_ARCH_MMAP_RND_COMPAT_BITS b/redhat/configs/common/generic/CONFIG_ARCH_MMAP_RND_COMPAT_BITS rename from redhat/configs/rhel/rt/generic/CONFIG_ARCH_MMAP_RND_COMPAT_BITS rename to redhat/configs/common/generic/CONFIG_ARCH_MMAP_RND_COMPAT_BITS index blahblah..blahblah 100644 --- a/redhat/configs/rhel/rt/generic/CONFIG_ARCH_MMAP_RND_COMPAT_BITS +++ b/redhat/configs/common/generic/CONFIG_ARCH_MMAP_RND_COMPAT_BITS diff --git a/redhat/configs/rhel/rt/generic/CONFIG_ATA_FORCE b/redhat/configs/common/generic/CONFIG_ATA_FORCE rename from redhat/configs/rhel/rt/generic/CONFIG_ATA_FORCE rename to redhat/configs/common/generic/CONFIG_ATA_FORCE index blahblah..blahblah 100644 --- a/redhat/configs/rhel/rt/generic/CONFIG_ATA_FORCE +++ b/redhat/configs/common/generic/CONFIG_ATA_FORCE diff --git a/redhat/configs/rhel/rt/generic/CONFIG_ATH9K_PCOEM b/redhat/configs/common/generic/CONFIG_ATH9K_PCOEM rename from redhat/configs/rhel/rt/generic/CONFIG_ATH9K_PCOEM rename to redhat/configs/common/generic/CONFIG_ATH9K_PCOEM index blahblah..blahblah 100644 --- a/redhat/configs/rhel/rt/generic/CONFIG_ATH9K_PCOEM +++ b/redhat/configs/common/generic/CONFIG_ATH9K_PCOEM diff --git a/redhat/configs/rhel/rt/generic/CONFIG_ATH9K_RFKILL b/redhat/configs/common/generic/CONFIG_ATH9K_RFKILL rename from redhat/configs/rhel/rt/generic/CONFIG_ATH9K_RFKILL rename to redhat/configs/common/generic/CONFIG_ATH9K_RFKILL index blahblah..blahblah 100644 --- a/redhat/configs/rhel/rt/generic/CONFIG_ATH9K_RFKILL +++ b/redhat/configs/common/generic/CONFIG_ATH9K_RFKILL diff --git a/redhat/configs/rhel/rt/generic/CONFIG_BASE_FULL b/redhat/configs/common/generic/CONFIG_BASE_FULL rename from redhat/configs/rhel/rt/generic/CONFIG_BASE_FULL rename to redhat/configs/common/generic/CONFIG_BASE_FULL index blahblah..blahblah 100644 --- a/redhat/configs/rhel/rt/generic/CONFIG_BASE_FULL +++ b/redhat/configs/common/generic/CONFIG_BASE_FULL diff --git a/redhat/configs/rhel/rt/generic/CONFIG_BLOCK b/redhat/configs/common/generic/CONFIG_BLOCK rename from redhat/configs/rhel/rt/generic/CONFIG_BLOCK rename to redhat/configs/common/generic/CONFIG_BLOCK index blahblah..blahblah 100644 --- a/redhat/configs/rhel/rt/generic/CONFIG_BLOCK +++ b/redhat/configs/common/generic/CONFIG_BLOCK diff --git a/redhat/configs/common/generic/arm/aarch64/CONFIG_BUG b/redhat/configs/common/generic/CONFIG_BUG rename from redhat/configs/common/generic/arm/aarch64/CONFIG_BUG rename to redhat/configs/common/generic/CONFIG_BUG index blahblah..blahblah 100644 --- a/redhat/configs/common/generic/arm/aarch64/CONFIG_BUG +++ b/redhat/configs/common/generic/CONFIG_BUG diff --git
Re: [OS-BUILD PATCH 0/0] Ensure the directory /lib/modules// is removed when on uninstall
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2605#note_1477068856 This should be fixed now. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue